nv foo 'echo bar ; exit -2 ; echo fail'; run foo; echo $?
bar
0
=> setenv foo 'echo bar ; exit ; echo fail'; run foo; echo $?
bar
0
"
Fixes: 8c4e3b79bd0 ("cmd: exit: Fix return value")
Signed-off-by: Marek Vasut
---
Cc: Adrian Vovk
Cc: Hector Palacios
Cc: Pan
Hi Max,
On 12/13/22 13:24, Max van den Biggelaar wrote:
Hi,
I have a question regarding the U-Boot exit command. We are currently using
mainline U-Boot 2022.04 version to provide our embedded systems with a
bootloader image. To start our firmware via U-Boot environment, we use a
bootscript t
On 11/21/22 09:55, Hector Palacios wrote:
Hi Marek,
On 11/19/22 15:12, Marek Vasut wrote:
On 11/18/22 12:19, Hector Palacios wrote:
Commit 8c4e3b79bd0bb76eea16869e9666e19047c0d005 supposedly
passed one-level up the argument passed to 'exit' but it also
broke 'exit' p
Hi Marek,
On 11/19/22 15:12, Marek Vasut wrote:
On 11/18/22 12:19, Hector Palacios wrote:
Commit 8c4e3b79bd0bb76eea16869e9666e19047c0d005 supposedly
passed one-level up the argument passed to 'exit' but it also
broke 'exit' purpose of stopping a script.
In reality, ev
echo $?
bar
0
=> setenv foo 'echo bar ; exit -1 ; echo should not see this'; run foo;
echo $?
bar
0
=> setenv foo 'echo bar ; exit -2 ; echo should not see this'; run foo;
echo $?
bar
0
=> setenv f
All mii operations require a valid PHY address except the 'device'
command, which expects the PHY name rather than the address.
Signed-off-by: Hector Palacios
---
cmd/mii.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/mii.c b/cmd/mii.c
index ce7b393eeaae..c0
does not help. This DDR is still performing
slowly in
U-Boot, but I can't find the reason why.
Thanks for your help, anyway.
--
Hector Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
e
multiple.
This was discovered in U-Boot where the issue can be reproduced by
writing any size that is 1 byte less than a page-size multiple.
For example, on a NAND with 2K page (0x800):
=> nand erase.part
=> nand write $loadaddr 7ff
Signed-off-by: Hector Palacios
---
d
On 07/18/2016 09:18 AM, Hector Palacios wrote:
> nand_do_write_ops() determines if it is writing a partial page with the
> formula:
> if (column || (writelen < mtd->writesize - 1))
>
> When 'writelen' is exactly 1 byte less than the NAND page size the formula
d write $loadaddr 7ff
Signed-off-by: Hector Palacios
---
Changes in v2
- v1 was wronly generated over U-Boot v2015.04
drivers/mtd/nand/nand_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 689716753ae6..82802
e, although
it should.
As a consequence the function remains in the while(1) loop with 'writelen'
becoming 0x and iterating until the watchdog timeout triggers.
To reproduce the issue on a NAND with 2K page (0x800):
=> nand erase.part
=> nand write $loadaddr
On 07/15/2016 08:49 PM, Scott Wood wrote:
> On Fri, 2016-07-15 at 09:45 +0200, Hector Palacios wrote:
>> nand_do_write_ops() determines if it is writing a partial page with the
>> formula:
>> part_pagewr = (column || writelen < (mtd->writesize - 1))
>>
>
d write $loadaddr 7ff
Signed-off-by: Hector Palacios
---
drivers/mtd/nand/nand_base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 689716753ae6..c8be74849e56 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/d
, less one byte.
Thanks in advance for your comments.
Hector Palacios (1):
mtd: nand: fix bug writing 1 byte less than page size
drivers/mtd/nand/nand_base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
___
U-Boot mailing list
U-Boot@lis
ns silent Linux does not work with these commands.
This patch moves the fixup_silent_linux() call out of the
BOOTM_STATE_LOADOS state and into BOOTM_STATE_OS_PREP, to silence Linux
independently of the used command (booti, bootm or bootz).
Signed-off-by: Hector Palacios
Reviewed-by: Simon Glass
ns silent Linux does not work with these commands.
This patch moves the fixup_silent_linux() call out of the
BOOTM_STATE_LOADOS state and into BOOTM_STATE_OS_PREP, to silence Linux
independently of the used command (booti, bootm or bootz).
Signed-off-by: Hector Palacios
---
common/bootm.c | 12 ++
i.MX6UL defines speed grading in OCOTP register 0x440[17:16]
as follows:
00 reserved
01 528MHz
10 700MHz
11 reserved
This commit removes the constants (which had the speed hardcoded
in their names) and uses values instead.
Signed-off-by: Hector Palacios
aster to
> jethro.
>
Could you please cherry-pick this to jethro?
git cherry-pick a7545b13feb60399822b7a2c3ea4961a265c0c6f
It applies cleanly.
Thanks.
--
Hector Palacios
--
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale
This includes into the SDK Boundary Devices i.MX/Vybrid recovery
utility, a host tool which allows to boot an image via USB in
serial downloader mode.
It currently supports i.MX5, i.MX6, i.MX7, and Vybrid families.
Signed-off-by: Hector Palacios
---
.../nativesdk-packagegroup-sdk-host.bbappend
ne MMC_SECURE_ERASE_ARG 0x8000
> +#define MMC_TRIM_ARG 0x0001
> +#define MMC_DISCARD_ARG 0x0003
> +#define MMC_SECURE_TRIM1_ARG 0x8001
> +#define MMC_SECURE_TRIM2_ARG 0x80008000
>
> #define MMC_STATUS_MASK (~0x0206BF7F)
&
clock divisor value(SDCLKFS
> or DVS in System Control Register) or setting RSTA bit.
>
> Signed-off-by: Eric Nelson
Reviewed-by: Hector Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Hi Eric,
On 12/04/2015 07:33 PM, Eric Nelson wrote:
> Hi Fabio and Hector,
>
> On 12/04/2015 10:43 AM, Eric Nelson wrote:
>> On 12/04/2015 10:38 AM, Eric Nelson wrote:
>>> On 12/04/2015 10:32 AM, Eric Nelson wrote:
The low four bits of the SYSCTL register are reserved on the USDHC
contr
> +#if !defined(CONFIG_MX6)
Per your commit message should this be
#if (!defined(CONFIG_MX6) && !defined(CONFIG_MX7))
> #define SYSCTL_CKEN 0x0008
> #define SYSCTL_PEREN 0x0004
> #define SYSCTL_HCKEN 0x0002
> #define SYSCTL_IPGEN 0x0001
> +#endif
> #define SYSCTL_RSTA 0x0100
> #define SYSCTL_RSTC 0x0200
> #define SYSCTL_RSTD 0x0400
>
--
Hector Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
se/ENGcm03648"
> issue (with or without a code change) for a couple of hours now.
>
> Can you give this a spin?
>
> It seems unlikely to address the issue unless what we're seeing is a
> side effect of a glitch while switching clocks.
As Fabio, I can reproduce this 100% of the times.
The patch does not fix it, though.
--
Hector Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
le's SABRESD on both SD card and eMMC with
v2015.04. The issue has been there always, I believe.
Apparently the command erases the first block, but the operation returns an
error, so
it aborts and it doesn't continue erasing futher blocks.
I opened a similar thread a while ago:
htt
espite failing during the attach procedure now
should
return an error).
4. Run the command again several times:
=> ubi part MyPart
=> ubi part MyPart
In my case, after calling this three times, the target hangs. I think the exit
path in
ubi_init() does not properly free every all
espite failing during the attach procedure now
should
return an error).
4. Run the command again several times:
=> ubi part MyPart
=> ubi part MyPart
In my case, after calling this three times, the target hangs. I think the exit
path in
ubi_init() does not properly free every all
Hi Fabio,
On 11/21/2014 06:10 PM, Fabio Estevam wrote:
> Hi Hector,
>
> On Fri, Nov 21, 2014 at 2:54 PM, Hector Palacios
> wrote:
>> The write operation may fail when trying to write to a locked area. In
>> this case the ERROR bit is set in the CTRL register. Check f
The write operation may fail when trying to write to a locked area. In
this case the ERROR bit is set in the CTRL register. Check for that
condition and return an error.
Signed-off-by: Hector Palacios
---
drivers/misc/mxs_ocotp.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a
ction may now return success even if the final
preparation function fails, but it's probably enough to print a message
because (if successful) the real programming of the fuses has already
completed.
Signed-off-by: Hector Palacios
---
drivers/misc/mxs_ocotp.c | 5 +
1 file changed, 1
A previous operation may have set the error flag, which must be cleared
before a new write operation can be issued.
Signed-off-by: Hector Palacios
---
drivers/misc/mxs_ocotp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/misc/mxs_ocotp.c b/drivers/misc/mxs_ocotp.c
index
Fuse drivers, like the mxs_ocotp.c, may return negative error codes but
the commands are only allowed to return CMD_RET_* enum values to the
shell, otherwise the following error appears:
"exit not allowed from main input shell."
Signed-off-by: Hector Palacios
---
Chan
Fuse drivers, like the mxs_ocotp.c, may return negative error codes but
the commands are not allowed to return negative error codes to the shell,
otherwise the following error appears:
"exit not allowed from main input shell."
Signed-off-by: Hector Palacios
---
common/cmd_
ntries, and calling env_flags_validate() in
'env_op_create' mode, which only checks for ENV_FLAGS_VARACCESS_PREVENT_CREATE permission.
Any ideas on how to properly fix this?
Best regards,
--
Hector Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
On 05/21/2014 04:20 AM, Jaehoon Chung wrote:
Hi, Hector.
On 05/21/2014 01:37 AM, Hector Palacios wrote:
Hi,
On 05/16/2014 06:59 AM, Jaehoon Chung wrote:
Signed-off-by: Jaehoon Chung
Tested-by: Lukasz Majewski
Acked-by: Lukasz Majewski
What platforms did you test DDR mode on?
I have
switch to any of the DDR modes. I guess the fsl_esdhc.c
driver needs some adaptation for DDR to work.
Best regards,
--
Hector Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
FATBUFSIZE);
if (mydata->fatbuf == NULL) {
debug("Error: allocating memory\n");
return -1;
Tested on an i.MX6 custom platform.
Tested-by: Hector Palacios
Thanks,
--
Héctor Palacios
___
U-Boot m
Hi,
On 03/28/2014 03:36 PM, Eric Nelson wrote:
Hi Hector,
On 03/28/2014 06:49 AM, Fabio Estevam wrote:
On Fri, Mar 28, 2014 at 7:15 AM, Hector Palacios
wrote:
Cache was invalidated on the read operation, but it should
also be flushed otherwise.
Signed-off-by: Hector Palacios
After
Cache was invalidated on the read operation, but it should
also be flushed otherwise.
Signed-off-by: Hector Palacios
---
Notes:
After enabling L2 cache on i.MX6 I found out that many times
when running the 'gpt' command to partition a uSD card, the
data was not written
str_uuid = partitions[i].uuid;
Sorry, I sent my tested-by on a different thread:
http://patchwork.ozlabs.org/patch/319649/
Tested on i.MX6 (armv7) custom board and it is working fine without
the -mno-unaligned-access flag.
Tested-by: Hector Palacios
Replying to Tom's q
The calloc() call was allocating space for the sizeof the struct
pointer rather than for the struct contents.
Besides, since this buffer is passed to mmc for writing and some
platforms may use cache, the legacy_mbr struct should be cache-aligned.
Signed-off-by: Hector Palacios
---
Notes
The calloc() call was allocating space for the sizeof the struct
pointer rather than for the struct contents.
Signed-off-by: Hector Palacios
---
disk/part_efi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/disk/part_efi.c b/disk/part_efi.c
index 5dfaf490c89a..7fabec059d7a
Since function mmc_get_env_devno is __weak and can be overridden by
board code, boards do not need to mandatory define
CONFIG_SYS_MMC_ENV_DEV.
If the constant is not defined, define it to 0 by default.
Signed-off-by: Hector Palacios
Reviewed-by: Stephen Warren
---
Notes:
Changes since v2
boards may decide to store the environment in a different partition.
The __weak function also allows to remove some ifdefs from the code.
If CONFIG_SYS_MMC_ENV_PART is not defined, partition 0 is assumed
(default value for U-Boot when a partition is not provided).
Signed-off-by: Hector Palacios
R
boards may decide to store the environment in a different partition.
The __weak function also allows to remove some ifdefs from the code.
If CONFIG_SYS_MMC_ENV_PART is not defined, partition 0 is assumed
(default value for U-Boot when a partition is not provided).
Signed-off-by: Hector Palacios
Since function mmc_get_env_devno is __weak and can be overridden by
board code, boards do not need to mandatory define
CONFIG_SYS_MMC_ENV_DEV.
If the constant is not defined, define it to 0 by default.
Signed-off-by: Hector Palacios
---
Notes:
Changes since v1:
- Use default define if
Hi Stephen,
On 01/15/2014 06:40 PM, Stephen Warren wrote:
On 01/15/2014 03:53 AM, Hector Palacios wrote:
Since function mmc_get_env_devno is __weak and can be overridden by
board code, boards do not necessarily need to define
CONFIG_SYS_MMC_ENV_DEV. If the constant is not defined, return 0 by
Hello Otavio,
On 01/15/2014 12:09 PM, Otavio Salvador wrote:
Hello Hector,
On Wed, Jan 15, 2014 at 8:53 AM, Hector Palacios mailto:hector.palac...@digi.com>> wrote:
This complements commit 9404a5fc7cb58 "env_mmc: allow environment to be
in an eMMC partition" by al
Fix incorrect name for iomux 0x7 of MX6_PAD_RGMII_TX_CTL which really
has function ENET_REF_CLK and not ANATOP_REF_OUT.
On imx6q also fix select input value to 1.
Signed-off-by: Hector Palacios
---
arch/arm/include/asm/arch-mx6/mx6dl_pins.h | 2 +-
arch/arm/include/asm/arch-mx6/mx6q_pins.h | 2
Since function mmc_get_env_devno is __weak and can be overridden by
board code, boards do not necessarily need to define
CONFIG_SYS_MMC_ENV_DEV. If the constant is not defined, return 0 by
default.
Signed-off-by: Hector Palacios
---
common/env_mmc.c | 4
1 file changed, 4 insertions
boards may decide to store the environment in a different partition.
The __weak function also allows to remove some ifdefs from the code.
If CONFIG_SYS_MMC_ENV_PART is not defined, partition 0 is assumed
(default value for U-Boot when a partition is not provided).
Signed-off-by: Hector Palacios
C
Dear Otavio,
On 01/03/2014 06:35 PM, Otavio Salvador wrote:
On Thu, Jan 2, 2014 at 9:36 PM, Marek Vasut wrote:
On Thursday, January 02, 2014 at 05:53:00 PM, Hector Palacios wrote:
Hi,
I saw commit 2a91c9134675140853577b565210458b5774e6cf that introduces mmc
subcommands 'open' and
mmand?
mmc open
is the same as
mmc dev
where is the boot partition
mmc close
is the same as
mmc dev 0
as a 0 will switch to partition 0 (user data).
Best regards,
--
Hector Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Hi Fabio,
On 11/21/2013 05:35 PM, Fabio Estevam wrote:
Hi Hector,
On 11/21/2013 08:19 AM, Hector Palacios wrote:
Hello,
I was trying to have GPIOs be able to wake up my ARM i.MX28 system from
suspend but noticed that the existing hook irq_set_wake() in the driver
ct->chip.irq_set_w
.driver = {
.name = "gpio-mxs",
.owner = THIS_MODULE,
.of_match_table = mxs_gpio_dt_ids,
+ .pm = &mxs_gpio_pm_ops,
},
.probe = mxs_gpio_probe,
.id_table = mxs_gpio_ids
Dear Peter,
On 10/25/2013 08:02 AM, Peter Chen wrote:
According to Freescale imx28 Errata, "ENGR119653 USB: ARM to USB
register error issue", All USB register write operations must
use the ARM SWP instruction. So, we implement special hw_write
and hw_test_and_clear for imx28.
Discussion for it
t;
> CCing Lothar and Hector, so we have more eyes on this. I got around to test it
> on M25P80 briefly and so far so good, thanks. Please do test this if possible.
I don't have anything connected to MXS SPI bus. Since it is half-duplex its
usage is
pretty lim
Dear Jagan,
On 10/14/2013 06:57 PM, Jagan Teki wrote:
On Mon, Oct 14, 2013 at 9:37 PM, Tom Rini wrote:
On Mon, Oct 14, 2013 at 06:00:20PM +0200, Hector Palacios wrote:
Dear Marek,
I noticed that 'fatls' displays duplicated filenames (short and
long) for every file in the media:
#
prevcksum = 0x;
dentptr++;
continue;
}
#endif
Could you please check?
Best regards,
--
Hector Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
init to board_early_init_f(),
where all the other upstream clock are initialized and also make
sure there is proper stabilization delay.
Signed-off-by: Marek Vasut
Cc: Fabio Estevam
Cc: Hector Palacios
Cc: Oliver Metz
Cc: Otavio Salvador
Cc: Stefano Babic
Cc: Tom Rini
---
board/bluegiga
mxs_clkctrl_regs *)MXS_CLKCTRL_BASE;
+
And the same here.
It works ok, but I can't say if it fixes exactly those seldom initialization problems
because I don't have a reliable way to reproduce them.
Tested-by: Hector Palacios
Best regards,
--
Hecto
is list: send the line "unsubscribe linux-iio" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Best regards,
--
Hector Palacios
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
much luck yet.
Oops, sorry, did you mean you were trying to backport them into U-Boot? Then please
disregards my previous message.
Best regards,
--
Hector Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
me functions
42def8ab25ecd8a81f1bd4b452445ed3636d159f mtd: fsl_ifc_nand: remove incorrect
kfree()
d855bd95ad35568b109f1b4587b68f0c950011f5 mtd: omap2: allow bulding as a module
Best regards,
--
Hector Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
On 09/16/2013 03:10 AM, Fabio Estevam wrote:
From: Fabio Estevam
Performing tftp transfers on mx28 results in random timeouts.
Hector Palacios and Robert Hodaszi analyzed the root cause being related to the
alignment of the 'buff' buffer inside fec_recv().
GCC versions such as 4
Hello,
Going back to this old thread I have some news regarding the problem with TFTP
transmissions blocking (timed out) after 10 seconds on the FEC of the MX28.
See below:
On 07/17/2013 05:55 PM, Hector Palacios wrote:
Dear Marek,
On 07/16/2013 06:44 AM, Marek Vasut wrote:
Dear Fabio
ption\n");
return -EINVAL;
}
Best regards,
--
Hector Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Dear Huang,
On 09/02/2013 10:50 AM, Huang Shijie wrote:
于 2013年09月02日 16:42, Hector Palacios 写道:
I am writing the JFFS2 partition from my custom U-Boot. Do you mean
that they way it writes it could not be compatible with what the new
driver expects? That sounds really bad.
The mtd code(as
On 08/27/2013 10:12 AM, Hector Palacios wrote:
On 08/27/2013 10:09 AM, Alexander Shishkin wrote:
Hector Palacios writes:
Dear Peter,
On 08/27/2013 04:51 AM, Peter Chen wrote:
On Mon, Aug 26, 2013 at 06:24:48PM +0200, Hector Palacios wrote:
Dear Peter,
On 08/12/2013 03:22 AM, Peter Chen
On 08/27/2013 10:09 AM, Alexander Shishkin wrote:
Hector Palacios writes:
Dear Peter,
On 08/27/2013 04:51 AM, Peter Chen wrote:
On Mon, Aug 26, 2013 at 06:24:48PM +0200, Hector Palacios wrote:
Dear Peter,
On 08/12/2013 03:22 AM, Peter Chen wrote:
This patchset adds tested otg id switch
Dear Peter,
On 08/27/2013 04:51 AM, Peter Chen wrote:
On Mon, Aug 26, 2013 at 06:24:48PM +0200, Hector Palacios wrote:
Dear Peter,
On 08/12/2013 03:22 AM, Peter Chen wrote:
This patchset adds tested otg id switch function and vbus connect
and disconnect detection for chipidea driver. And fix
comments [6/13]
- Fix some typos [8/13]
- Retire flag CI_HDRC_PULLUP_ON_VBUS [12/13] [13/13]
Patches 6 and 12 in this series seem to be incomplete or malformed. Please
check.
Best regards,
--
Hector Palacios
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the
Dear Peter,
On 08/14/2013 01:43 AM, Peter Chen wrote:
On Mon, Aug 12, 2013 at 09:22:46AM +0800, Peter Chen wrote:
This patchset adds tested otg id switch function and vbus connect
and disconnect detection for chipidea driver. And fix kinds of
bugs found at chipidea drivers after enabling id and
Dear Alexandre,
On 08/22/2013 12:13 AM, Alexandre Belloni wrote:
Hi Pawel,
On 14/08/2013 16:44, Pawel Moll wrote:
On Tue, 2013-08-13 at 22:23 +0100, Jonathan Cameron wrote:
On 07/22/13 15:04, Hector Palacios wrote:
Some LRADC channels have fixed pre-dividers so they can measure
different
Hi Marcel,
On 07/29/2013 06:43 PM, Marcel Holtmann wrote:
Hi Hector,
The Atheros firmware download driver is not dependent on HCI
USB driver. This driver is needed to complement any Atheros
driver like BT_HCIUART_ATH3K.
Signed-off-by: Hector Palacios
CC: Suraj Sumangala
CC: Vikram
The Atheros firmware download driver is not dependent on HCI
USB driver. This driver is needed to complement any Atheros
driver like BT_HCIUART_ATH3K.
Signed-off-by: Hector Palacios
CC: Suraj Sumangala
CC: Vikram Kandukuri
---
drivers/bluetooth/Kconfig | 1 -
1 file changed, 1 deletion
Dear Marek,
On 07/24/2013 05:54 PM, Marek Vasut wrote:
Dear Hector Palacios,
The AUTO_RESTART flag of HW_RTC_PERSISTENT0 register will
power up the chip automatically 180ms after power down.
This bit must be enabled by the boot loader to ensure the
target can start upon hardware reset or
tting the flag.
Signed-off-by: Hector Palacios
---
arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
index 5ee2d88..285ac79 100644
--
e renamed to
mxs_power_set_auto_restart().
Best regards,
--
Hector Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Dear Lars,
On 07/23/2013 10:46 AM, Lars-Peter Clausen wrote:
On 07/22/2013 04:04 PM, Hector Palacios wrote:
[...]
+static ssize_t mxs_lradc_show_scale_available_ch(struct device *dev,
+ struct device_attribute *attr,
+ char *buf,
+ int ch
Hello Marek,
On 07/23/2013 12:36 AM, Marek Vasut wrote:
Dear Hector Palacios,
Adds in_voltageX_scale_available file for every channel to read
the different available scales.
There are two scales per channel:
[0] = divider_by_two disabled (default)
[1] = divider_by_two enabled
The scale is
-by: Hector Palacios
---
drivers/staging/iio/adc/mxs-lradc.c | 112 +++-
1 file changed, 111 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/mxs-lradc.c
b/drivers/staging/iio/adc/mxs-lradc.c
index 5037577..5d332b1 100644
--- a/drivers/staging/iio
a custom i.MX28 platform.
Could someone please test on an i.MX23?
Hector Palacios (5):
iio: mxs-lradc: change the realbits to 12
ARM: dts: add reference voltage property for MXS LRADC
iio: mxs-lradc: add scale attribute to channels
iio: mxs-lradc: add scale_available file to channels
iio:
)
- allows to read the scaling attribute (computed from the Vref)
Signed-off-by: Hector Palacios .
Acked-by: Marek Vasut
---
drivers/staging/iio/adc/mxs-lradc.c | 77 +
1 file changed, 53 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/iio/adc/mxs-lradc.c
Some LRADC channels have fixed pre-dividers so they can measure
different voltages at full scale. The reference voltage allows to
expose a scaling attribute through the IIO sysfs so that a user can
compute the real voltage out of a measured sample value.
Signed-off-by: Hector Palacios
Acked-by
.
Besides, the driver was using an 18 bit mask (LRADC_CH_VALUE_MASK) to
report touch coordinates to userland. A 12 bit mask should be used instead
or else the touch libraries will expect a coordinates range between 0
and 0x3 (18 bits), instead of between 0 and 0xfff (12 bits).
Signed-off-by: Hector
Added write_raw function to manipulate the optional divider_by_two
through the scaling attribute out of the available scales.
Signed-off-by: Hector Palacios
---
drivers/staging/iio/adc/mxs-lradc.c | 56 -
1 file changed, 55 insertions(+), 1 deletion(-)
diff
ain in readability.
I'm happy either way.
I prefer the struct approach, it removes one dimension to the array and I find
it cleaner.
Best regards,
--
Hector Palacios
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@v
Hi Marek,
On 07/22/2013 09:42 AM, Marek Vasut wrote:
Dear Hector Palacios,
Hi Marek,
On 07/19/2013 06:14 PM, Marek Vasut wrote:
Dear Hector Palacios,
Dear Marek,
On 07/19/2013 04:30 PM, Marek Vasut wrote:
@@ -228,39 +230,12 @@ struct mxs_lradc {
#define LRADC_RESOLUTION
Hi Alexandre,
On 07/19/2013 07:06 PM, Alexandre Belloni wrote:
Hi Hector,
On 19/07/2013 11:13, Hector Palacios wrote:
Some LRADC channels have fixed pre-dividers and all have an optional
divider by two which allows a maximum input voltage of VDDIO - 50mV.
This patch
- adds the scaling info
Hi Marek,
On 07/19/2013 06:14 PM, Marek Vasut wrote:
Dear Hector Palacios,
Dear Marek,
On 07/19/2013 04:30 PM, Marek Vasut wrote:
@@ -228,39 +230,12 @@ struct mxs_lradc {
#define LRADC_RESOLUTION 12
#define LRADC_SINGLE_SAMPLE_MASK ((1
;unsigned long mask', right? Yeah, I think I had resolved that one
before submitting, but looks like I didn't.
The other check is not resolved afaik. We agreed to remove it, but on a
different patch.
Otherwise:
Acked-by: Marek Vasut
Marek Vasut
Best regards,
--
Hector Palacios
-
hat I first submitted, but it was rejected and I was told
to use the scale_available descriptor instead, which is the common interface the rest
of drivers use.
Best regards,
--
Hector Palacios
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a m
hat I first submitted, but it was rejected and I was told
to use the scale_available descriptor instead, which is the common interface the rest
of drivers use.
Best regards,
--
Hector Palacios
___
devicetree-discuss mailing list
devicetree-discuss@li
;unsigned long mask', right? Yeah, I think I had resolved that one
before submitting, but looks like I didn't.
The other check is not resolved afaik. We agreed to remove it, but on a
different patch.
Otherwise:
Acked-by: Marek Vasut
Marek Vasut
Dear Marek,
On 07/19/2013 04:39 PM, Marek Vasut wrote:
Dear Hector Palacios,
Added write_raw function to manipulate the optional divider_by_two
through the scaling attribute out of the available scales.
Signed-off-by: Hector Palacios
---
drivers/staging/iio/adc/mxs-lradc.c | 55
Dear Marek,
On 07/19/2013 04:39 PM, Marek Vasut wrote:
Dear Hector Palacios,
Added write_raw function to manipulate the optional divider_by_two
through the scaling attribute out of the available scales.
Signed-off-by: Hector Palacios
---
drivers/staging/iio/adc/mxs-lradc.c | 55
.
Besides, the driver was using an 18 bit mask (LRADC_CH_VALUE_MASK) to
report touch coordinates to userland. A 12 bit mask should be used instead
or else the touch libraries will expect a coordinates range between 0
and 0x3 (18 bits), instead of between 0 and 0xfff (12 bits).
Signed-off-by: Hector
Added write_raw function to manipulate the optional divider_by_two
through the scaling attribute out of the available scales.
Signed-off-by: Hector Palacios
---
drivers/staging/iio/adc/mxs-lradc.c | 55 -
1 file changed, 54 insertions(+), 1 deletion(-)
diff
Added write_raw function to manipulate the optional divider_by_two
through the scaling attribute out of the available scales.
Signed-off-by: Hector Palacios
---
drivers/staging/iio/adc/mxs-lradc.c | 55 -
1 file changed, 54 insertions(+), 1 deletion(-)
diff
1 - 100 of 181 matches
Mail list logo