Re: THRIFT-148 - Twisted Support

2009-03-02 Thread Kevin Clark
Hey Terry, No problem. Frankly, if nobody else speaks up, you and Esteve *are* consensus. I'm just waiting things out a little while longer so as not to step on toes. On Mon, Mar 2, 2009 at 3:25 PM, Terry Jones te...@jon.es wrote: Hi Kevin Kevin == Kevin Clark kevin.cl...@gmail.com writes

Re: THRIFT-148 - Twisted Support

2009-03-02 Thread Kevin Clark
Ok. Last call. I'm pushing in 15 minutes. On Mon, Mar 2, 2009 at 5:14 PM, Bryan Duxbury br...@rapleaf.com wrote: No problem. Frankly, if nobody else speaks up, you and Esteve *are* consensus. +1 to that. I say go for it. -Bryan -- Kevin Clark http://glu.ttono.us

[jira] Assigned: (THRIFT-148) Add support for Twisted

2009-03-02 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark reassigned THRIFT-148: -- Assignee: Esteve Fernandez Add support for Twisted

[jira] Commented: (THRIFT-278) #validate exceptions should contain the offending value

2009-02-12 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12672987#action_12672987 ] Kevin Clark commented on THRIFT-278: Does this work? Maybe I'm reading it wrong

[jira] Commented: (THRIFT-254) Add optional strict version support to binary protocols

2009-02-04 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670537#action_12670537 ] Kevin Clark commented on THRIFT-254: In r740930. Thanks a lot! Add optional strict

[jira] Commented: (THRIFT-302) Native extension fails to build

2009-02-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670040#action_12670040 ] Kevin Clark commented on THRIFT-302: This looks fine to me. +1 I'll push today

[jira] Assigned: (THRIFT-302) Native extension fails to build

2009-02-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark reassigned THRIFT-302: -- Assignee: Esteve Fernandez Native extension fails to build

Re: Feature freeze date?

2009-02-03 Thread Kevin Clark
Kevin Clark wrote: Ok, I'd support this. Anyone have suggestions for how we go about it? I'd start by: - deciding which languages have the highest priority - officially appointing someone as the key person for each language and/or platform - trying to close old or pending issues. A bug

[jira] Commented: (THRIFT-275) Remove deprecated classes from Ruby library

2009-02-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670061#action_12670061 ] Kevin Clark commented on THRIFT-275: I'm alright with this, as long as we well document

[jira] Commented: (THRIFT-245) FIELDS constant should contain name of enumerated type for enum fields

2009-02-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670060#action_12670060 ] Kevin Clark commented on THRIFT-245: +1 FIELDS constant should contain name

[jira] Commented: (THRIFT-302) Native extension fails to build

2009-02-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670092#action_12670092 ] Kevin Clark commented on THRIFT-302: That means it came from me. I'm trying to track

[jira] Commented: (THRIFT-175) Specs in Ruby library should be run during make check

2009-02-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670124#action_12670124 ] Kevin Clark commented on THRIFT-175: That's doable, yup. Specs in Ruby library should

[jira] Commented: (THRIFT-302) Native extension fails to build

2009-02-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670132#action_12670132 ] Kevin Clark commented on THRIFT-302: Looks like it came from krb4, and the headers

[jira] Commented: (THRIFT-175) Specs in Ruby library should be run during make check

2009-02-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670068#action_12670068 ] Kevin Clark commented on THRIFT-175: I agree. I'm just not sure what the right fix

[jira] Commented: (THRIFT-278) #validate exceptions should contain the offending value

2009-02-03 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670064#action_12670064 ] Kevin Clark commented on THRIFT-278: +1 #validate exceptions should contain

[jira] Commented: (THRIFT-302) Native extension fails to build

2009-02-02 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12669700#action_12669700 ] Kevin Clark commented on THRIFT-302: We fixed strlcpy by including it with an ifdef

[jira] Commented: (THRIFT-302) Native extension fails to build

2009-02-02 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12669718#action_12669718 ] Kevin Clark commented on THRIFT-302: It's being used: sisyphus:~/code/thrift kev$ g g

[jira] Commented: (THRIFT-291) tweak README for Thrift's new location at Apache

2009-01-30 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12668897#action_12668897 ] Kevin Clark commented on THRIFT-291: I don't know that Thrift was inspired by protocol

[jira] Commented: (THRIFT-248) Factor BinaryProtocolAccelerated into separate protocol and struct components

2009-01-29 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12668726#action_12668726 ] Kevin Clark commented on THRIFT-248: Works for me! Pull out the RopeTransport stuff

[jira] Commented: (THRIFT-236) Structs should be serialized in a consistent order

2009-01-20 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12665544#action_12665544 ] Kevin Clark commented on THRIFT-236: Do we still need to modify the generator to use

[jira] Commented: (THRIFT-238) Generated structs should have constructor option to skip default values

2009-01-16 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12664555#action_12664555 ] Kevin Clark commented on THRIFT-238: I'm not sure I like the idea, but if we wanted

[jira] Commented: (THRIFT-276) Ruby libraries should have one class per file

2009-01-16 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12664763#action_12664763 ] Kevin Clark commented on THRIFT-276: I agree entirely. It's only this way for legacy

[jira] Commented: (THRIFT-277) Abstract Transport in Ruby #read method should throw NotImplementedException

2009-01-16 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12664765#action_12664765 ] Kevin Clark commented on THRIFT-277: +1 Abstract Transport in Ruby #read method

[jira] Commented: (THRIFT-216) Ruby tests don't pass due to fixtures not having a validate method

2009-01-15 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12664188#action_12664188 ] Kevin Clark commented on THRIFT-216: No worries. It was easy to make things right on my

Welcoming new committer Bryan Duxbury!

2009-01-15 Thread Kevin Clark
incubation project. Let's make him feel welcome. -- Kevin Clark http://glu.ttono.us

[jira] Commented: (THRIFT-269) Kevin's link points to the wrong site

2009-01-15 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12664287#action_12664287 ] Kevin Clark commented on THRIFT-269: Oh, thanks! Nice. Kevin's link points

[jira] Commented: (THRIFT-216) Ruby tests don't pass due to fixtures not having a validate method

2009-01-14 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663798#action_12663798 ] Kevin Clark commented on THRIFT-216: Yes, sorry about that. I'll push when I get

[jira] Assigned: (THRIFT-216) Ruby tests don't pass due to fixtures not having a validate method

2009-01-14 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark reassigned THRIFT-216: -- Assignee: Esteve Fernandez Ruby tests don't pass due to fixtures not having a validate method

[jira] Closed: (THRIFT-216) Ruby tests don't pass due to fixtures not having a validate method

2009-01-14 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-216. -- Resolution: Fixed Ok, it's in r734565. Sorry about the wait. Ruby tests don't pass due to fixtures

[jira] Commented: (THRIFT-262) Generate Javadocs for library classes

2009-01-14 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663964#action_12663964 ] Kevin Clark commented on THRIFT-262: +1 here. Generate Javadocs for library classes

[jira] Commented: (THRIFT-254) Add optional strict version support to binary protocols

2009-01-12 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663107#action_12663107 ] Kevin Clark commented on THRIFT-254: Ah, ok, that makes sense. I think this is fine

[jira] Commented: (THRIFT-260) Some Protocol methods shouldn't have default nil implementations

2009-01-12 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12663234#action_12663234 ] Kevin Clark commented on THRIFT-260: Yup, this makes sense and should be done. Some

[jira] Commented: (THRIFT-248) Factor BinaryProtocolAccelerated into separate protocol and struct components

2009-01-09 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12662482#action_12662482 ] Kevin Clark commented on THRIFT-248: Right, the way BPA gets around constant ruby calls

[jira] Commented: (THRIFT-254) Add optional strict version support to binary protocols

2009-01-09 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12662484#action_12662484 ] Kevin Clark commented on THRIFT-254: I'd support a change like this. I'll review

[jira] Commented: (THRIFT-248) Factor BinaryProtocolAccelerated into separate protocol and struct components

2009-01-09 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12662583#action_12662583 ] Kevin Clark commented on THRIFT-248: Most of the operations in MemoryBuffer happen in C

[jira] Commented: (THRIFT-248) Factor BinaryProtocolAccelerated into separate protocol and struct components

2009-01-08 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12662072#action_12662072 ] Kevin Clark commented on THRIFT-248: That sounds reasonable on the write side

[jira] Commented: (THRIFT-248) Factor BinaryProtocolAccelerated into separate protocol and struct components

2009-01-07 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12661719#action_12661719 ] Kevin Clark commented on THRIFT-248: Some implications of this (which Bryan and I have

[jira] Commented: (THRIFT-236) Structs should be serialized in a consistent order

2009-01-06 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12661348#action_12661348 ] Kevin Clark commented on THRIFT-236: THRIFT-246 requires this to modify the generator

[jira] Closed: (THRIFT-216) Ruby tests don't pass due to fixtures not having a validate method

2009-01-06 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-216. -- Resolution: Invalid This was due to fixtures not being regenerated on spec run, which has since been

[jira] Commented: (THRIFT-189) Speed up Ruby struct constructors some more

2009-01-06 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12661350#action_12661350 ] Kevin Clark commented on THRIFT-189: This looks fine, but we should probably just go

[jira] Commented: (THRIFT-216) Ruby tests don't pass due to fixtures not having a validate method

2009-01-06 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12661367#action_12661367 ] Kevin Clark commented on THRIFT-216: Doh, you're right, the compiler tests don't seem

[jira] Commented: (THRIFT-248) Factor BinaryProtocolAccelerated into separate protocol and struct components

2009-01-05 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12660954#action_12660954 ] Kevin Clark commented on THRIFT-248: +1. I'd happily accept patches that do

[jira] Resolved: (THRIFT-231) Ruby generated structs lack a hash method, and thus cannot be used as map keys or set members

2009-01-05 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark resolved THRIFT-231. Resolution: Fixed Ok, pushed without the class check in 731760. Thanks! Ruby generated structs

[jira] Resolved: (THRIFT-157) Ruby generator produces incorrect output for strings with single-quotes or for class references across namespaces

2009-01-05 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark resolved THRIFT-157. Resolution: Fixed In 731763. Thanks! Sorry about the wait. Ruby generator produces incorrect

[jira] Closed: (THRIFT-246) Make #struct_fields part of the generated code rather than using reflection

2009-01-05 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-246. -- Resolution: Fixed Cool, in 731806. Make #struct_fields part of the generated code rather than using

[jira] Commented: (THRIFT-236) Structs should be serialized in a consistent order

2008-12-17 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12657616#action_12657616 ] Kevin Clark commented on THRIFT-236: You mention Ruby in the description, but is what

[jira] Commented: (THRIFT-231) Ruby generated structs lack a hash method, and thus cannot be used as map keys or set members

2008-12-17 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12657625#action_12657625 ] Kevin Clark commented on THRIFT-231: From the rdoc on Object#eql? and friends

[jira] Commented: (THRIFT-236) Structs should be serialized in a consistent order

2008-12-17 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12657626#action_12657626 ] Kevin Clark commented on THRIFT-236: Ok. I'd support this. +1 Structs should

[jira] Commented: (THRIFT-231) Ruby generated structs lack a hash method, and thus cannot be used as map keys or set members

2008-12-15 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12656799#action_12656799 ] Kevin Clark commented on THRIFT-231: Sure, but I'm a little uncomfortable using

[jira] Commented: (THRIFT-231) Ruby generated structs lack a hash method, and thus cannot be used as map keys or set members

2008-12-12 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12656230#action_12656230 ] Kevin Clark commented on THRIFT-231: Why'd you take out the class check in #== ? Ruby

[jira] Closed: (THRIFT-185) Struct doesn't check if struct fields are of proper struct type when Thrift.type_checking is on

2008-12-12 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-185. -- Resolution: Fixed Ok, it's in r726156. Struct doesn't check if struct fields are of proper struct

[jira] Commented: (THRIFT-231) Ruby generated structs lack a hash method, and thus cannot be used as map keys or set members

2008-12-11 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12655794#action_12655794 ] Kevin Clark commented on THRIFT-231: If you want this to work, we'll also need

[mojo-dev] [jira] Commented: (MWAS-26) NullPointerException when running plugin

2008-12-08 Thread Kevin Clark (JIRA)
[ http://jira.codehaus.org/browse/MWAS-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=157329#action_157329 ] Kevin Clark commented on MWAS-26: - You might want to fix your doco http://mojo.codehaus.org/was6-maven

Re: Patch for Ruby

2008-12-07 Thread Kevin Clark
Chandranshu -- Kevin Clark http://glu.ttono.us

[mojo-dev] [jira] Commented: (MWAS-26) NullPointerException when running plugin

2008-12-05 Thread Kevin Clark (JIRA)
[ http://jira.codehaus.org/browse/MWAS-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=157019#action_157019 ] Kevin Clark commented on MWAS-26: - Error is [INFO] Building Lincoln Business Utils EJB [INFO]task

[mojo-dev] [jira] Created: (MWAS-26) NullPointerException when running plugin

2008-12-05 Thread Kevin Clark (JIRA)
: Vista RSA 7.0.0.7 WAS 6.1.0.19 fixpacks installed WAS_HOME=c:\opt\IBM\SDP70\runtimes\base_v61 Reporter: Kevin Clark Assignee: David J. M. Karlsen Attachments: pom.xml Commandline to run mvn org.codehaus.mojo:was6-maven-plugin:1.0:installApp -DearFile=c:\tmp.ear

[jira] Commented: (THRIFT-213) Thrift::Serializer can become corrupt

2008-11-24 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12650280#action_12650280 ] Kevin Clark commented on THRIFT-213: Sounds fine. I'm happy to apply a patch that fixes

[jira] Closed: (THRIFT-207) validate appears before AND after read method

2008-11-19 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-207. -- Resolution: Fixed Sorry about that. Fixed in 719126. validate appears before AND after read method

[jira] Commented: (THRIFT-185) Struct doesn't check if struct fields are of proper struct type when Thrift.type_checking is on

2008-11-17 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12648407#action_12648407 ] Kevin Clark commented on THRIFT-185: This looks fine except that I'm concerned

[jira] Commented: (THRIFT-196) Specs should regenerate fixture code

2008-11-14 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12647661#action_12647661 ] Kevin Clark commented on THRIFT-196: Mmmaybe. I guess one situation where that wouldn't

[jira] Closed: (THRIFT-206) ruby required field validation requires before read instead of after

2008-11-14 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-206. -- Resolution: Fixed In 714069. ruby required field validation requires before read instead of after

[jira] Closed: (THRIFT-196) Specs should regenerate fixture code

2008-11-14 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-196. -- Resolution: Fixed In 714070. Specs should regenerate fixture code

[jira] Closed: (THRIFT-197) Thrift exceptions should subclass Thrift::Exception

2008-11-14 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-197. -- Resolution: Fixed In 714070. Thrift exceptions should subclass Thrift::Exception

[jira] Commented: (THRIFT-206) ruby required field validation requires before read instead of after

2008-11-13 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12647464#action_12647464 ] Kevin Clark commented on THRIFT-206: I'm going to push, but is there a test that could

[jira] Created: (THRIFT-196) Specs should regenerate fixture code

2008-11-10 Thread Kevin Clark (JIRA)
Specs should regenerate fixture code Key: THRIFT-196 URL: https://issues.apache.org/jira/browse/THRIFT-196 Project: Thrift Issue Type: Bug Components: Library (Ruby) Reporter: Kevin

[jira] Updated: (THRIFT-196) Specs should regenerate fixture code

2008-11-10 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-196: --- Attachment: 0001-rb-Specs-should-regenerate-fixture-code-THRIFT-196.patch Adds a dep to the default

[jira] Updated: (THRIFT-197) Thrift exceptions should subclass Thrift::Exception

2008-11-10 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark updated THRIFT-197: --- Attachment: 0001-rb-Thrift-exceptions-should-subclass-Thrift-Except.patch Thrift exceptions should

[jira] Closed: (THRIFT-143) If a required field is omitted on serialization, throw an exception

2008-11-10 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-143. -- Resolution: Fixed In r712945. If a required field is omitted on serialization, throw an exception

[jira] Commented: (THRIFT-143) If a required field is omitted on serialization, throw an exception

2008-11-05 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12645413#action_12645413 ] Kevin Clark commented on THRIFT-143: Looks fine to me. I'll push soonish. I'm

[jira] Closed: (THRIFT-147) Ruby generated classes should include class doc strings

2008-10-30 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-147. -- Resolution: Fixed In 709309 Ruby generated classes should include class doc strings

[jira] Closed: (THRIFT-188) Improve Ruby struct constructor speed

2008-10-30 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-188. -- Resolution: Fixed In 709313 Improve Ruby struct constructor speed

[jira] Closed: (THRIFT-165) Add some additional reflection features to Ruby generated code

2008-10-16 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-165. -- Resolution: Fixed Pushed in 705330. Thanks! Add some additional reflection features to Ruby

[jira] Created: (THRIFT-174) Fixtures data in Ruby generator tests (test/rb) should be updated automatically

2008-10-16 Thread Kevin Clark (JIRA)
Issue Type: Bug Components: Test Suite Reporter: Kevin Clark Currently stale fixtures data sits in test/rb/fixtures. It should be automatically generated for make check. -- This message is automatically generated by JIRA. - You can reply to this email to add

[jira] Created: (THRIFT-175) Specs in Ruby library should be run during make check

2008-10-16 Thread Kevin Clark (JIRA)
(Ruby) Reporter: Kevin Clark We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly. -- This message is automatically generated by JIRA. - You can reply to this email to add

[jira] Commented: (THRIFT-156) Patch to Ruby HTTPClient to support SSL and to send correct Thrift Content-Type header

2008-10-15 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12639931#action_12639931 ] Kevin Clark commented on THRIFT-156: Looks fine to me, I'm going to push. Anyone know

[jira] Resolved: (THRIFT-156) Patch to Ruby HTTPClient to support SSL and to send correct Thrift Content-Type header

2008-10-15 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark resolved THRIFT-156. Resolution: Fixed In In 704994. Patch to Ruby HTTPClient to support SSL and to send correct

[jira] Commented: (THRIFT-157) Ruby generator produces incorrect output for strings with single-quotes or for class references across namespaces

2008-10-15 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12639934#action_12639934 ] Kevin Clark commented on THRIFT-157: HI Dave, both of these ideas look fine

[jira] Commented: (THRIFT-165) Add some additional reflection features to Ruby generated code

2008-10-15 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12640039#action_12640039 ] Kevin Clark commented on THRIFT-165: Is there a reason the std namespace is imported

[jira] Commented: (THRIFT-165) Add some additional reflection features to Ruby generated code

2008-10-15 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12640045#action_12640045 ] Kevin Clark commented on THRIFT-165: But upcase_string seems to use std:: explicitly

Re: [Mono-dev] Mono 2.0 download

2008-10-06 Thread Kevin Clark
2008/10/6 Andrew Jorgensen [EMAIL PROTECTED] As we announced before we are only producing binaries for openSUSE 11.0 SUSE Linux Enterprise 10 Windows Mac OS X We have left up the old repositories for now. We may remove them around the 2.2 release cycle. Jezz way to alienate the

Re: [Mono-dev] Mono 2.0 download

2008-10-06 Thread Kevin Clark
2008/10/7 Andrew Jorgensen [EMAIL PROTECTED] The original announcement about that is here: http://lists.ximian.com/pipermail/mono-devel-list/2008-September/029144.html It would not be terribly difficult to make 2.0 available for 10.3 but we must be clear on the point that it is not tested

Re: Redesign of the Thrift site

2008-08-30 Thread Kevin Clark
-- Kevin Clark http://glu.ttono.us

[jira] Commented: (THRIFT-118) Improved inspect for Ruby structs

2008-08-26 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625829#action_12625829 ] Kevin Clark commented on THRIFT-118: This looks great. I expect you didn't mean

[jira] Closed: (THRIFT-118) Improved inspect for Ruby structs

2008-08-26 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-118. -- Resolution: Fixed Pushed in 689193. Improved inspect for Ruby structs

[jira] Commented: (THRIFT-120) Some methods not named properly in nocamel style

2008-08-26 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625846#action_12625846 ] Kevin Clark commented on THRIFT-120: Looks good to me. If no one has issue, I'll push

Re: Patches in need of review/commit

2008-08-25 Thread Kevin Clark
-112 -- Kevin Clark http://glu.ttono.us

[jira] Commented: (THRIFT-112) Initialize method is unnecessarily slow for structs with many optional fields

2008-08-25 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625509#action_12625509 ] Kevin Clark commented on THRIFT-112: Wait, what's an optional field? Fields are set

[jira] Closed: (THRIFT-112) Initialize method is unnecessarily slow for structs with many optional fields

2008-08-25 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-112. -- Resolution: Fixed Fixed in 688891. Initialize method is unnecessarily slow for structs with many

[jira] Closed: (THRIFT-117) FramedTransport should support borrow so it can be used with BinaryProtocolAccelerated

2008-08-25 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-117. -- Resolution: Fixed Wonderful. Pushed in 688901. FramedTransport should support borrow so it can

[jira] Commented: (THRIFT-112) Initialize method is unnecessarily slow for structs with many optional fields

2008-08-25 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625578#action_12625578 ] Kevin Clark commented on THRIFT-112: For reference, here's the protocol benchmarks

[jira] Commented: (THRIFT-117) FramedTransport should support borrow so it can be used with BinaryProtocolAccelerated

2008-08-20 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624179#action_12624179 ] Kevin Clark commented on THRIFT-117: This looks fine, can you attach a test as well

[jira] Closed: (THRIFT-75) While sending a message, if a struct serialization raises an exception, the transport should be closed

2008-07-28 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-75. - Resolution: Fixed In r680538 While sending a message, if a struct serialization raises an exception

[jira] Closed: (THRIFT-90) Thrift::BinaryProtocolAccelerated is missing specs

2008-07-28 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-90. - Resolution: Fixed In 679898 Thrift::BinaryProtocolAccelerated is missing specs

[jira] Closed: (THRIFT-97) BinaryProtocolAccelerated does not encode strings with null bytes properly

2008-07-28 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-97. - Resolution: Fixed In 679899 BinaryProtocolAccelerated does not encode strings with null bytes properly

[jira] Commented: (THRIFT-97) BinaryProtocolAccelerated does not encode strings with null bytes properly

2008-07-25 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617043#action_12617043 ] Kevin Clark commented on THRIFT-97: --- This looks good to me, but I'm on vacation and away

Re: thrift facebook svn repo

2008-07-22 Thread Kevin Clark
Codebase. Codebase. Need to go back to bed apparently. On Tue, Jul 22, 2008 at 11:28 AM, Kevin Clark [EMAIL PROTECTED] wrote: I don't see any advantage in having the codeplace served from two seperate svn repos. I'd personally prefer the redirection to the Apache repo. -- Kevin Clark

[jira] Closed: (THRIFT-74) Thrift::Socket.new should accept optional timeout argument

2008-07-18 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-74. - Resolution: Fixed In 678053. Thrift::Socket.new should accept optional timeout argument

[jira] Closed: (THRIFT-88) backwards_compatibility_spec is not testing TProtocolException

2008-07-18 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-88. - Resolution: Fixed In 678055. backwards_compatibility_spec is not testing TProtocolException

[jira] Closed: (THRIFT-78) Type-checking doesn't show what field had the error

2008-07-18 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-78. - Resolution: Fixed In 678059. Type-checking doesn't show what field had the error

[jira] Closed: (THRIFT-87) Website improvements: more info on index.xml and whoare.xml

2008-07-16 Thread Kevin Clark (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Clark closed THRIFT-87. - Resolution: Fixed Pushed. Site should update soon. Website improvements: more info on index.xml

<    1   2   3   4   5   6   >