Re: [RFC] Revert "drm/sched: Split free_job into own work item"

2024-01-24 Thread Mario Limonciello
On 1/24/2024 10:26, Vlastimil Babka wrote: On 1/23/24 03:11, Mario Limonciello wrote: commit f7fe64ad0f22 ("drm/sched: Split free_job into own work item") causes graphics hangs at GDM or right after logging in on a Framework 13 AMD laptop (containing a Phoenix APU). This reve

Re: regression/bisected/6.8 commit f7fe64ad0f22ff034f8ebcfbd7299ee9cc9b57d7 leads to GPU hang when I open GNOME activities

2024-01-24 Thread Mario Limonciello
On 1/24/2024 08:37, Mikhail Gavrilov wrote: On Wed, Jan 24, 2024 at 7:19 AM Mikhail Gavrilov wrote: Who could dig into it, please? You decided to revert it? https://lkml.org/lkml/2024/1/22/1866 It's not a straight "git revert" on 6.8-rc1 because of some other contextual changes. I

Re: regression/bisected/6.8 commit f7fe64ad0f22ff034f8ebcfbd7299ee9cc9b57d7 leads to GPU hang when I open GNOME activities

2024-01-24 Thread Mario Limonciello
On 1/24/2024 08:37, Mikhail Gavrilov wrote: On Wed, Jan 24, 2024 at 7:19 AM Mikhail Gavrilov wrote: Who could dig into it, please? You decided to revert it? https://lkml.org/lkml/2024/1/22/1866 It's not a straight "git revert" on 6.8-rc1 because of some other contextual changes. I

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-01-24 Thread Mario Limonciello
On 1/22/2024 11:06, Sébastien Chaumat wrote: Le mer. 17 janv. 2024 à 03:20, Mario Limonciello mailto:mario.limoncie...@amd.com>> a écrit : On 1/16/2024 10:18, Jan Beulich wrote: > On 16.01.2024 16:52, Sébastien Chaumat wrote: >> Le mar. 2 janv. 2024 à 21:23, Sé

Re: [RFC] Revert "drm/sched: Split free_job into own work item"

2024-01-23 Thread Mario Limonciello
On 1/22/2024 20:11, Mario Limonciello wrote: commit f7fe64ad0f22 ("drm/sched: Split free_job into own work item") causes graphics hangs at GDM or right after logging in on a Framework 13 AMD laptop (containing a Phoenix APU). This reverts commit f7fe64ad0f22ff034f8ebcfbd7299ee9cc9b57

[Canonical-ubuntu-qa] [Bug 1970069] Re: Annoying boot messages interfering with splash screen

2024-01-23 Thread Mario Limonciello
If it's a SAUCE only patch, I think it should be proposed here: https://lists.ubuntu.com/mailman/listinfo/kernel-team -- You received this bug notification because you are a member of Canonical's Ubuntu QA, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1970069 Title: Annoying

[Kernel-packages] [Bug 1970069] Re: Annoying boot messages interfering with splash screen

2024-01-23 Thread Mario Limonciello
If it's a SAUCE only patch, I think it should be proposed here: https://lists.ubuntu.com/mailman/listinfo/kernel-team -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1970069 Title:

[RFC] Revert "drm/sched: Split free_job into own work item"

2024-01-22 Thread Mario Limonciello
Split free_job into own work item") Signed-off-by: Mario Limonciello --- This is a regression introduced in 6.8-rc1, bisected from 6.7. This revert done on top of 6.8-rc1 fixes the issue. I'm happy to gather any data to use to properly debug if that is preferable to a revert. --- drive

Re: [PATCH v2 0/8] Expand and improve AMDGPU documentation

2024-01-22 Thread Mario Limonciello
Documentation/gpu/amdgpu/display/display-contributing.rst delete mode 100644 drivers/gpu/drm/amd/display/TODO Reviewed-by: Mario Limonciello

[PATCH] Revert "drm/amd/pm: fix the high voltage and temperature issue"

2024-01-19 Thread Mario Limonciello
ssues/3062 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 24 -- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 33 ++- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 1 - .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 8 +---

[Kernel-packages] [Bug 2036737] Re: Enable dynamic boost control in ccp kernel driver

2024-01-18 Thread Mario Limonciello
** Changed in: linux (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/2036737 Title: Enable dynamic boost control in ccp kernel driver

[Kernel-packages] [Bug 2049758] Re: DP connection swap to break eDP behavior on AMD 7735U

2024-01-18 Thread Mario Limonciello
** Description changed: - Some OEM platforms swap DP connections on the Rembrandt-R, which causes - improper eDP behavior. AMD experimented with reproducing at CRB level to - come out with a solution + [Impact] + Some OEM platforms swap DP connections on the Rembrandt-R, which causes improper

[Kernel-packages] [Bug 2049758] Re: DP connection swap to break eDP behavior on AMD 7735U

2024-01-18 Thread Mario Limonciello
** Also affects: linux-firmware (Ubuntu) Importance: Undecided Status: New ** Also affects: linux (Ubuntu) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Noble) Importance: Undecided Status: New ** Also affects: linux-firmware (Ubuntu Noble)

[Kernel-packages] [Bug 1965303] Re: Migrate from fbdev drivers to simpledrm and DRM fbdev emulation layer

2024-01-18 Thread Mario Limonciello
Is this going to happen for noble? It should just be kernel config changes at this point. ** Changed in: linux (Ubuntu Mantic) Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.

[Canonical-ubuntu-qa] [Bug 1970069] Re: Annoying boot messages interfering with splash screen

2024-01-17 Thread Mario Limonciello
#18 Instead of changing this patch can you finish the adoption for simpledrm? This will get a DRM framebuffer up and running instantly. It should help a lot. #19 Presumably the fsck stuff is coming from systemd-fsck@.service, right? -- You received this bug notification because you are a

[Kernel-packages] [Bug 2039570] Re: [amdgpu] Fullscreen in any Wayland / Xwayland window shows a black screen (no screen detected)

2024-01-17 Thread Mario Limonciello
Since the PPA failed would you be able to manually build 6.5.13 to see if it's fixed there? -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/2039570 Title: [amdgpu] Fullscreen in any

[Kernel-packages] [Bug 2042713] Re: Pale Green blank screen after login

2024-01-17 Thread Mario Limonciello
Boot a bad kernel, reboot the system, boot a good kernel. >From the good kernel: journalctl -k -b0 > good_kernel.txt journalctl -k -b-1 > bad_kernel.txt -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2024-01-17 Thread Mario Limonciello
On 1/16/2024 10:18, Jan Beulich wrote: On 16.01.2024 16:52, Sébastien Chaumat wrote: Le mar. 2 janv. 2024 à 21:23, Sébastien Chaumat a écrit : output of gpioinfo kernel alone : line 5: unnamed input active-low consumer=interrupt line 84: unnamed

[Kernel-packages] [Bug 2048735] Re: Disable keyboard wakeup for Framework 13

2024-01-16 Thread Mario Limonciello
It's a pretty complicated backport to 6.1. there is a directory rename, missing quirks that this builds on. Considering 6.1 OEM will transition to 6.5 OEM eventually it might be better to only target to 6.5 OEM. They patches were nominated to 6.6.y already, but 6.5.y is EOL upstream so it's up

[Kernel-packages] [Bug 2049220] Re: Update firmware for MT7921 in order to fix Framework 13 AMD 7040

2024-01-12 Thread Mario Limonciello
** Also affects: linux-firmware (Ubuntu Noble) Importance: Undecided Status: New ** Also affects: linux-firmware (Ubuntu Mantic) Importance: Undecided Status: New ** Also affects: linux-firmware (Ubuntu Jammy) Importance: Undecided Status: New -- You received this

Bug#1059606: fwupd: add build support for loongarch64

2023-12-29 Thread Mario Limonciello
This will be fixed by the next upload with this change: https://salsa.debian.org/efi-team/fwupd/-/commit/493293f60f78ed8c67d4839437765be140ebb25f Sent with Shortwave

Re: [PATCH] drm/amdgpu: Check resize bar register when system uses large bar

2023-12-29 Thread Mario Limonciello
On 12/20/2023 19:58, Ma, Jun wrote: Hi Christian, On 12/20/2023 10:10 PM, Christian König wrote: Am 19.12.23 um 06:58 schrieb Ma Jun: Print a warnning message if the system can't access the resize bar register when using large bar. Well pretty clear NAK, we have embedded use cases where

[Bug 2047374] Re: TPM PCR0 recontruction fails on Pluton fTPM

2023-12-27 Thread Mario Limonciello
The way this works is that the tpm event log is used to attempt to reconstruct pcr0. If it doesn't match the value in the tpm pcr0 then there is a bug or malware. The same report was brought into fwupd upstream. Various artifacts were captured and the conclusion is this is a BIOS bug. It should

[Kernel-packages] [Bug 2046504] Re: Fix AMDGPU display on lower resolution modes

2023-12-26 Thread Mario Limonciello
The patches for this issue are in the original bug: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2042867 -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux-oem-6.5 in Ubuntu. https://bugs.launchpad.net/bugs/2046504 Title:

[Touch-packages] [Bug 2046646] Re: package fwupd 1.7.9-1~22.04.3 failed to install/upgrade: installed fwupd package post-installation script subprocess returned error exit status 127

2023-12-26 Thread Mario Limonciello
** Package changed: fwupd (Ubuntu) => initramfs-tools (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to initramfs-tools in Ubuntu. https://bugs.launchpad.net/bugs/2046646 Title: package fwupd 1.7.9-1~22.04.3 failed

[Kernel-packages] [Bug 2045573] Re: AMDGPU: cp queue preemption timeout

2023-12-26 Thread Mario Limonciello
*** This bug is a duplicate of bug 2047389 *** https://bugs.launchpad.net/bugs/2047389 ** This bug has been marked a duplicate of bug 2047389 Fix AMDGPU crash on 6.5 kernel -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in

[Desktop-packages] [Bug 2046853] [NEW] Power Profiles daemon should change multiple drivers

2023-12-18 Thread Mario Limonciello
Public bug reported: The current version of power-profiles-daemon (0.13) has support both for amd/intel pstate drivers as well as the ACPI platform profile drivers. If the system supports both types of drivers then only the ACPI platform profile driver gets used. This doesn't do a great job as a

[Desktop-packages] [Bug 2028674] Re: Automatically switch profiles based on plugged-in status

2023-12-18 Thread Mario Limonciello
Something I want to mention is that some drivers in the kernel and some implementations of vendor's EC firmware internally handle AC vs battery differently within a given platform profile. So you "automatically" get a better power savings just going to battery compared to AC. Thus I don't think

[Desktop-packages] [Bug 2034678] Re: Power profile constantly resets to Balanced

2023-12-17 Thread Mario Limonciello
This is a firmware or kernel bug, not a power profiles daemon bug. Please report it to Lenovo to investigate the details. ** Changed in: power-profiles-daemon (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 2043318] Re: Screen keeps dimming, power mode switches to 'power saver' by itself

2023-12-17 Thread Mario Limonciello
Closing it here as this is a firmware bug not a software bug. ** Changed in: power-profiles-daemon (Ubuntu) Status: Confirmed => Invalid -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to power-profiles-daemon in Ubuntu.

Re: [PATCH] drm/amd/display: disable FPO and SubVP for older DMUB versions on DCN32x

2023-12-15 Thread Mario Limonciello
vokxygd6-e+8p-4qo6fowa6zp2...@mail.gmail.com/ Signed-off-by: Hamza Mahfooz Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c b/drivers/g

[PATCH 2/2] Documentation/amdgpu: Remove a spurious character

2023-12-15 Thread Mario Limonciello
`/` wasn't meant to be in the Dragon Range line Signed-off-by: Mario Limonciello --- Documentation/gpu/amdgpu/apu-asic-info-table.csv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/gpu/amdgpu/apu-asic-info-table.csv b/Documentation/gpu/amdgpu/apu-asic-info

[PATCH 1/2] Documentation/amdgpu: Add Hawk Point processors

2023-12-15 Thread Mario Limonciello
These have been announced so add them to the table. Link: https://www.amd.com/en/product/13971 Signed-off-by: Mario Limonciello --- Documentation/gpu/amdgpu/apu-asic-info-table.csv | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/gpu/amdgpu/apu-asic-info

[PATCH v2] drm/amd: Add missing definitions for `SMU_MAX_LEVELS_VDDGFX`

2023-12-15 Thread Mario Limonciello
-off-by: Mario Limonciello --- v1->v2: * s/VDDGFX/VDDC/ --- drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 ++ drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c b/driv

[PATCH] drm/amd: Move IMU enable pm mutex call a level lower

2023-12-15 Thread Mario Limonciello
smu_set_gfx_power_up_by_imu() is called by both smu_set_gfx_imu_enable() and amdgpu_dpm_set_gfx_power_up_by_imu() but only uses a mutex in amdgpu_dpm_set_gfx_power_up_by_imu(). Move the mutex use into smu_set_gfx_imu_enable() to protect multiple simultaneous calls. Signed-off-by: Mario

[PATCH v3 3/3] drm/amd: Retry delayed work handler if sensor is busy

2023-12-15 Thread Mario Limonciello
The SW CTF delayed work handler triggers a shutdown if a sensor read failed for any reason. The specific circumstance of a busy sensor should be retried however to ensure that a good value can be returned. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 6

[PATCH v3 2/3] drm/amd: Make SW CTF handler cope with different read_sensor() results

2023-12-15 Thread Mario Limonciello
to catch this circumstance and output a warning. Signed-off-by: Mario Limonciello --- v2->v3: * Correctly handle fallthrough case v1->v2: * Only show `Failed to read hotspot temperature` when sensor read fails --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 24 ++-

[PATCH v3 1/3] drm/amd: Return -EBUSY in read_sensor() if RAS interrupt triggered

2023-12-15 Thread Mario Limonciello
Any callers to read_sensor() may get the wrong data if the RAS interrupt has been triggered and no actual sensor read occurred. Adjust the return code for this condition to be -EBUSY. Suggested-by: Lijo Lazar Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/smu11

[PATCH v2 2/3] drm/amd: Make SW CTF handler cope with different read_sensor() results

2023-12-15 Thread Mario Limonciello
to catch this circumstance and output a warning. Signed-off-by: Mario Limonciello --- v1->v2: * Only show `Failed to read hotspot temperature` when sensor read fails --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) d

[PATCH v2 3/3] drm/amd: Retry delayed work handler if sensor is busy

2023-12-15 Thread Mario Limonciello
The SW CTF delayed work handler triggers a shutdown if a sensor read failed for any reason. The specific circumstance of a busy sensor should be retried however to ensure that a good value can be returned. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 6

[PATCH v2 1/3] drm/amd: Return -EBUSY in read_sensor() if RAS interrupt triggered

2023-12-15 Thread Mario Limonciello
Any callers to read_sensor() may get the wrong data if the RAS interrupt has been triggered and no actual sensor read occurred. Adjust the return code for this condition to be -EBUSY. Suggested-by: Lijo Lazar Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/smu11

Re: [PATCH v2] drm/amd: Add a workaround for GFX11 systems that fail to flush TLB

2023-12-14 Thread Mario Limonciello
this out to the field, introduce a workaround that will add an extra dummy read on resume that the result is discarded. Cc: sta...@vger.kernel.org # 6.1+ Cc: Tim Huang Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3045 Signed-off-by: Mario Limonciello --- v1->v2: * Add a dummy r

[PATCH] drm/amd/display: Add a new DC debug mask for PSR-SU

2023-12-14 Thread Mario Limonciello
Some issues have been raised that appear to be tied to PSR-SU. To allow users to confirm they're tied to PSR-SU without turning off PSR entirely introduce a new debug mask: amdgpu.dcdebugmask=0x200 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 3

[PATCH] drm/amd: Add missing definitions for `SMU_MAX_LEVELS_VDDGFX`

2023-12-14 Thread Mario Limonciello
://gitlab.freedesktop.org/drm/amd/-/issues/3049 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 ++ drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr

[Desktop-packages] [Bug 2046491] [NEW] Finger Print Sensor is not working on goodixmoc device

2023-12-14 Thread Mario Limonciello
Public bug reported: AMD testing of some Goodix MOC devices shows that this device fails to work properly: [ 208.586084] usb 1-2: New USB device found, idVendor=27c6, idProduct=6496, bcdDevice= 1.00 The issue is specifically that there is a problem with the 'enroll create' state. It has been

Re: [PATCH] drm/amd: Add a workaround for GFX11 systems that fail to flush TLB

2023-12-14 Thread Mario Limonciello
On 12/14/2023 03:21, Christian König wrote: Am 13.12.23 um 20:44 schrieb Alex Deucher: On Wed, Dec 13, 2023 at 2:32 PM Mario Limonciello wrote: On 12/13/2023 13:12, Mario Limonciello wrote: On 12/13/2023 13:07, Alex Deucher wrote: On Wed, Dec 13, 2023 at 1:00 PM Mario Limonciello wrote

Bug#1058701: RM: pm-utils; abandoned upstream

2023-12-14 Thread Mario Limonciello
Package: ftp.debian.org Severity: normal X-Debbugs-Cc: mario.limoncie...@amd.com The pm-utils package hasn't had any activity in Debian since 2019. All bugs have been ignored. Upstream [1] has been dead since 2010. Modern userspace uses systemd to perform suspend/resume instead. [1]

[PATCH] drm/amd: Make SW CTF handler cope with different read_sensor() results

2023-12-14 Thread Mario Limonciello
to catch this circumstance and output a warning. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu

Re: [GIT PULL] mmutable branch between pdx86 amd wbrf branch and wifi / amdgpu due for the v6.8 merge window

2023-12-14 Thread Mario Limonciello
On 12/14/2023 10:36, Kalle Valo wrote: Hans de Goede writes: Hi Wifi and AMDGPU maintainers, Here is a pull-request for the platform-drivers-x86 parts of: https://lore.kernel.org/platform-driver-x86/20231211100630.2170152-1-jun@amd.com/ From my pov the pdx86 bits are ready and the

[PATCH v2] drm/amd: Add a workaround for GFX11 systems that fail to flush TLB

2023-12-13 Thread Mario Limonciello
that will add an extra dummy read on resume that the result is discarded. Cc: sta...@vger.kernel.org # 6.1+ Cc: Tim Huang Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3045 Signed-off-by: Mario Limonciello --- v1->v2: * Add a dummy read callback instead and use that. --- drivers/gpu/

Re: [PATCH] drm/amd: Add a workaround for GFX11 systems that fail to flush TLB

2023-12-13 Thread Mario Limonciello
On 12/13/2023 13:12, Mario Limonciello wrote: On 12/13/2023 13:07, Alex Deucher wrote: On Wed, Dec 13, 2023 at 1:00 PM Mario Limonciello wrote: Some systems with MP1 13.0.4 or 13.0.11 have a firmware bug that causes the first MES packet after resume to fail. This packet is used to flush

Re: [PATCH] drm/amd: Add a workaround for GFX11 systems that fail to flush TLB

2023-12-13 Thread Mario Limonciello
On 12/13/2023 13:07, Alex Deucher wrote: On Wed, Dec 13, 2023 at 1:00 PM Mario Limonciello wrote: Some systems with MP1 13.0.4 or 13.0.11 have a firmware bug that causes the first MES packet after resume to fail. This packet is used to flush the TLB when GART is enabled. This issue is fixed

[PATCH] drm/amd: Add a workaround for GFX11 systems that fail to flush TLB

2023-12-13 Thread Mario Limonciello
that will retry the flush when detecting running on an older firmware and decrease relevant error messages to debug while workaround is in use. Cc: sta...@vger.kernel.org # 6.1+ Cc: Tim Huang Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3045 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd

Re: [PATCH] Revert "drm/amd/display: Adjust the MST resume flow"

2023-12-13 Thread Mario Limonciello
On 12/13/2023 08:17, Alex Deucher wrote: On Tue, Dec 12, 2023 at 9:00 PM Mario Limonciello wrote: On 12/12/2023 18:08, Oliver Schmidt wrote: Hi Wayne, On 12.12.23 17:06, Mario Limonciello wrote: I looked through your bugs related to this and I didn't see a reference to the specific docking

Re: [PATCH] Revert "drm/amd/display: Adjust the MST resume flow"

2023-12-12 Thread Mario Limonciello
On 12/12/2023 18:08, Oliver Schmidt wrote: Hi Wayne, On 12.12.23 17:06, Mario Limonciello wrote: I looked through your bugs related to this and I didn't see a reference to the specific docking station model. The logs mentioned "Thinkpad dock" but no model. Could you share more a

[Bug 2039570] Re: [amdgpu] Fullscreen in any Wayland / Xwayland window shows a black screen (no screen detected)

2023-12-12 Thread Mario Limonciello
OK thanks for clarifying. Can you please still try latest 6.5.13 and 6.6.6 and see if it happens in either of those? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to mutter in Ubuntu. https://bugs.launchpad.net/bugs/2039570 Title:

[Kernel-packages] [Bug 2039570] Re: [amdgpu] Fullscreen in any Wayland / Xwayland window shows a black screen (no screen detected)

2023-12-12 Thread Mario Limonciello
OK thanks for clarifying. Can you please still try latest 6.5.13 and 6.6.6 and see if it happens in either of those? -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/2039570 Title:

[Desktop-packages] [Bug 2039570] Re: [amdgpu] Fullscreen in any Wayland / Xwayland window shows a black screen (no screen detected)

2023-12-12 Thread Mario Limonciello
OK thanks for clarifying. Can you please still try latest 6.5.13 and 6.6.6 and see if it happens in either of those? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to mutter in Ubuntu. https://bugs.launchpad.net/bugs/2039570 Title:

[Kernel-packages] [Bug 2039570] Re: [amdgpu] Fullscreen in any Wayland / Xwayland window shows a black screen (no screen detected)

2023-12-12 Thread Mario Limonciello
Is this happening possibly when there is a resolution change for the eDP? If so, can you please try the latest linux-6.5.y kernel: https://kernel.ubuntu.com/mainline/v6.5.13/ -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in

[Desktop-packages] [Bug 2039570] Re: [amdgpu] Fullscreen in any Wayland / Xwayland window shows a black screen (no screen detected)

2023-12-12 Thread Mario Limonciello
Is this happening possibly when there is a resolution change for the eDP? If so, can you please try the latest linux-6.5.y kernel: https://kernel.ubuntu.com/mainline/v6.5.13/ -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to mutter in

[Bug 2039570] Re: [amdgpu] Fullscreen in any Wayland / Xwayland window shows a black screen (no screen detected)

2023-12-12 Thread Mario Limonciello
Is this happening possibly when there is a resolution change for the eDP? If so, can you please try the latest linux-6.5.y kernel: https://kernel.ubuntu.com/mainline/v6.5.13/ -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to mutter in

[PATCH] drm/amd: Fix a probing order problem on SDMA 2.4

2023-12-12 Thread Mario Limonciello
nit_microcode(). Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3043 Fixes: 751e293f2c99 ("drm/amd: Move microcode init from sw_init to early_init for SDMA v2.4") Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 4 ++-- 1 file changed, 2 insertions(+

Re: [GIT PULL] mmutable branch between pdx86 amd wbrf branch and wifi / amdgpu due for the v6.8 merge window

2023-12-12 Thread Mario Limonciello
On 12/12/2023 03:46, Johannes Berg wrote: On Mon, 2023-12-11 at 12:02 +0100, Hans de Goede wrote: Hi Wifi and AMDGPU maintainers, Here is a pull-request for the platform-drivers-x86 parts of: https://lore.kernel.org/platform-driver-x86/20231211100630.2170152-1-jun@amd.com/ From my pov

Re: [PATCH] Revert "drm/amd/display: Adjust the MST resume flow"

2023-12-12 Thread Mario Limonciello
On 12/5/2023 13:54, Mario Limonciello wrote: This reverts commit ec5fa9fcdeca69edf7dab5ca3b2e0ceb1c08fe9a. Reports are that this causes problems with external monitors after wake up from suspend, which is something it was directly supposed to help. Cc: Linux Regressions Cc: sta...@vger.kernel.or

Re: [GIT PULL] mmutable branch between pdx86 amd wbrf branch and wifi / amdgpu due for the v6.8 merge window

2023-12-11 Thread Mario Limonciello
On 12/11/2023 09:27, Alex Deucher wrote: On Mon, Dec 11, 2023 at 10:20 AM Mario Limonciello wrote: On 12/11/2023 08:47, Christian König wrote: Am 11.12.23 um 12:02 schrieb Hans de Goede: Hi Wifi and AMDGPU maintainers, Here is a pull-request for the platform-drivers-x86 parts of: https

Re: [PATCH] Revert "drm/amd/display: Adjust the MST resume flow"

2023-12-11 Thread Mario Limonciello
Ping on this one. On 12/5/2023 13:54, Mario Limonciello wrote: This reverts commit ec5fa9fcdeca69edf7dab5ca3b2e0ceb1c08fe9a. Reports are that this causes problems with external monitors after wake up from suspend, which is something it was directly supposed to help. Cc: Linux Regressions Cc

Re: [GIT PULL] mmutable branch between pdx86 amd wbrf branch and wifi / amdgpu due for the v6.8 merge window

2023-12-11 Thread Mario Limonciello
On 12/11/2023 08:47, Christian König wrote: Am 11.12.23 um 12:02 schrieb Hans de Goede: Hi Wifi and AMDGPU maintainers, Here is a pull-request for the platform-drivers-x86 parts of: https://lore.kernel.org/platform-driver-x86/20231211100630.2170152-1-jun@amd.com/  From my pov the pdx86

Re: [PATCH] drm/amd/display: Disable PSR-SU on Parade 0803 TCON again

2023-12-11 Thread Mario Limonciello
On 12/9/2023 14:08, Mario Limonciello wrote: When screen brightness is rapidly changed and PSR-SU is enabled the display hangs on panels with this TCON even on the latest DCN 3.1.4 microcode (0x8002a81 at this time). This was disabled previously as commit 072030b17830 ("drm/amd: Disable P

[PATCH] drm/amd/display: Disable PSR-SU on Parade 0803 TCON again

2023-12-10 Thread Mario Limonciello
lly with this TCON, disable PSR-SU again for it until it can be root caused. Cc: sta...@vger.kernel.org Cc: aaron...@canonical.com Cc: bi...@gnome.org Cc: Marc Rossi Cc: Hamza Mahfooz Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 ++ 1 file changed, 2

Re: [PATCH V2] drm/amdgpu/sdma5.2: add begin/end_use ring callbacks

2023-12-09 Thread Mario Limonciello
://gitlab.freedesktop.org/drm/amd/-/issues/2220 Reviewed-by: Mario Limonciello (v1) Tested-by: Mario Limonciello (v1) Signed-off-by: Alex Deucher As SDMA5.2 is supported back to LTS ~5.15 I suggest also: Cc: sta...@vger.kernel.org # 5.15+ --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 16

[Ubuntu-x-swat] [Bug 2043640] Re: amdgpu: GPU Recovery fails, frequent hangs

2023-12-09 Thread Mario Limonciello
This is the same issue as https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2045573 Here is a commit that fixes the issue by changing default pre-emption policy since the kernel can't know about your mesa version.

[Touch-packages] [Bug 2043640] Re: amdgpu: GPU Recovery fails, frequent hangs

2023-12-09 Thread Mario Limonciello
This is the same issue as https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2045573 Here is a commit that fixes the issue by changing default pre-emption policy since the kernel can't know about your mesa version.

[Kernel-packages] [Bug 2043640] Re: amdgpu: GPU Recovery fails, frequent hangs

2023-12-09 Thread Mario Limonciello
This is the same issue as https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2045573 Here is a commit that fixes the issue by changing default pre-emption policy since the kernel can't know about your mesa version.

[Desktop-packages] [Bug 2043640] Re: amdgpu: GPU Recovery fails, frequent hangs

2023-12-09 Thread Mario Limonciello
This is the same issue as https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2045573 Here is a commit that fixes the issue by changing default pre-emption policy since the kernel can't know about your mesa version.

[Kernel-packages] [Bug 2045573] Re: AMDGPU: cp queue preemption timeout

2023-12-08 Thread Mario Limonciello
Here's the fix commit ID to backport to fix this issue. https://github.com/torvalds/linux/commit/d6a57588666301acd9d42d3b00d74240964f07f6 -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.

Re: [PATCH 1/3] drm/amdgpu/sdma: add begin_use/end_use helpers

2023-12-08 Thread Mario Limonciello
. This should not impact power as SDMA usage is pretty minimal and GFXOSS should not be active when SDMA is active anyway, this just makes it explicit. Signed-off-by: Alex Deucher --- For the series: Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2220 Reviewed-by: Mario Limonciello Tested

Re: [PATCH v2] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-07 Thread Mario Limonciello
("drm/amd/display: add FB_DAMAGE_CLIPS support") Reported-by: Kai-Heng Feng Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2952 Tested-by: Kai-Heng Feng Tested-by: Bin Li Signed-off-by: Hamza Mahfooz Reviewed-by: Mario Limonciello --- v2: fix style issues and add tags --- d

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-07 Thread Mario Limonciello
: On Thu, Dec 7, 2023 at 10:10 AM Mario Limonciello wrote: On 12/6/2023 20:07, Kai-Heng Feng wrote: On Thu, Dec 7, 2023 at 9:57 AM Mario Limonciello wrote: On 12/6/2023 19:23, Kai-Heng Feng wrote: On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello wrote: On 12/5/2023 14:17, Hamza Mahfooz wrote

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-06 Thread Mario Limonciello
On 12/6/2023 20:07, Kai-Heng Feng wrote: On Thu, Dec 7, 2023 at 9:57 AM Mario Limonciello wrote: On 12/6/2023 19:23, Kai-Heng Feng wrote: On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello wrote: On 12/5/2023 14:17, Hamza Mahfooz wrote: We currently don't support dirty rectangles

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-06 Thread Mario Limonciello
On 12/6/2023 19:23, Kai-Heng Feng wrote: On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello wrote: On 12/5/2023 14:17, Hamza Mahfooz wrote: We currently don't support dirty rectangles on hardware rotated modes. So, if a user is using hardware rotated modes with PSR-SU enabled, use PSR-SU FFU

[PATCH] drm/amd/display: Restore guard against default backlight value < 1 nit

2023-12-06 Thread Mario Limonciello
Kovac Cc: Hamza Mahfooz Fixes: d9e865826c20 ("drm/amd/display: Simplify brightness initialization") Signed-off-by: Mario Limonciello --- .../amd/display/dc/link/protocols/link_edp_panel_control.c| 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-05 Thread Mario Limonciello
On 12/5/2023 14:17, Hamza Mahfooz wrote: We currently don't support dirty rectangles on hardware rotated modes. So, if a user is using hardware rotated modes with PSR-SU enabled, use PSR-SU FFU for all rotated planes (including cursor planes). Here is the email for the original reporter to

[Kernel-packages] [Bug 2045573] Re: AMDGPU: cp queue preemption timeout

2023-12-05 Thread Mario Limonciello
that patch I linked will go into the next 6.7-fixes PR. I suggest backporting it. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/2045573 Title: AMDGPU: cp queue preemption timeout

[PATCH] Revert "drm/amd/display: Adjust the MST resume flow"

2023-12-05 Thread Mario Limonciello
Reported-by: Oliver Schmidt Link: https://bugzilla.kernel.org/show_bug.cgi?id=218211 Link: https://forum.manjaro.org/t/problems-with-external-monitor-wake-up-after-suspend/151840 Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3023 Signed-off-by: Mario Limonciello --- .../gpu/drm/amd/display

[Kernel-packages] [Bug 2045573] Re: AMDGPU: cp queue preemption timeout

2023-12-04 Thread Mario Limonciello
This will be fixed by this patch: https://lore.kernel.org/amd- gfx/20231201005751.4194154-1-jiadong@amd.com/ Until Canonical pulls it in for now you can use amdgpu.mcbp=0 on kernel command line to avoid it. -- You received this bug notification because you are a member of Kernel Packages,

[Kernel-packages] [Bug 2045382] Re: AMD Lexa PRO graphic card can't work

2023-12-04 Thread Mario Limonciello
That was already CC to stable, so I suggest checking the latest 5.15.y. If that's still not working, you probably need https://github.com/torvalds/linux/commit/2757a848cb0f184850d3e0a33b4a69e8014fdc5d backported too. -- You received this bug notification because you are a member of Kernel

[Kernel-packages] [Bug 2045382] Re: AMD Lexa PRO graphic card can't work

2023-12-04 Thread Mario Limonciello
It's probably a duplicate of the same patches missing for bug 2036742. https://github.com/torvalds/linux/commit/64ffd2f1d00c6235dabe9704bbb0d9ce3e28147f -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux-signed-hwe-5.15 in Ubuntu.

[Kernel-packages] [Bug 2045382] Re: AMD Lexa PRO graphic card can't work

2023-12-02 Thread Mario Limonciello
try amdgpu.aspm=0. If this helps it's because of missing stable backport patches. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux-signed-hwe-5.15 in Ubuntu. https://bugs.launchpad.net/bugs/2045382 Title: AMD Lexa PRO graphic

[PATCH] drm/amd/display: Fix NULL pointer dereference at hibernate

2023-11-29 Thread Mario Limonciello
During hibernate sequence the source context might not have a clk_mgr. So don't use it to look for DML2 support. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2980 Fixes: a2815ada8616 ("drm/amd/display: Introduce DML2") Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/

Re: [PATCH v14 3/9] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing

2023-11-29 Thread Mario Limonciello
work". Otherwise LGTM. Reviewed-by: Mario Limonciello -- v8->v9: - correct typo(Mhz -> MHz) (Johnson) v13: - Fix the format issue (IIpo Jarvinen) --- include/net/cfg80211.h | 9 + net/wireless/chan.c| 3 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --g

Re: [PATCH v14 2/9] platform/x86/amd: Add support for AMD ACPI based Wifi band RFI mitigation feature

2023-11-29 Thread Mario Limonciello
that if no other feedback is needed for the series can be fixed when committing. Reviewed-by: Mario Limonciello -- v11: - fix typo(Simon) v12: - Fix the code logic (Rafael) - Move amd_wbrf.c to drivers/platform/x86/amd/wbrf.c - Updated Evan's email because he's no longer

Re: [PATCH v14 1/9] Documentation/driver-api: Add document about WBRF mechanism

2023-11-29 Thread Mario Limonciello
On 11/29/2023 03:13, Ma Jun wrote: Add documentation about AMD's Wifi band RFI mitigation (WBRF) mechanism explaining the theory and how it is used. Signed-off-by: Ma Jun Reviewed-by: Hans de Goede Reviewed-by: Mario Limonciello -- v14: - Fix the format issue (IIpo Jarvinen

Re: [PATCH] drm/amdgpu: Restrict extended wait to PSP v13.0.6

2023-11-29 Thread Mario Limonciello
On 11/29/2023 06:36, Lijo Lazar wrote: Only PSPv13.0.6 SOCs take a longer time to reach steady state. Other PSPv13 based SOCs don't need extended wait. Also, reduce PSPv13.0.6 wait time. Signed-off-by: Lijo Lazar Thanks! Reviewed-by: Mario Limonciello When you commit can you please add

Re: [PATCH] drm/amdgpu: Add a new module param to disable d3cold

2023-11-29 Thread Mario Limonciello
On 11/29/2023 02:51, Ma Jun wrote: Some platforms can't resume from d3cold state, So add a new module parameter to disable d3cold state for debugging purpose or workaround. Signed-off-by: Ma Jun --- This patch is essentially an 'amdgpu knob' for d3cold on the root port. At least for

[PATCH 3/3] drm/amd: Drop calls for checking "support" for BACO/BOCO/PX

2023-11-28 Thread Mario Limonciello
e variable that is programmed when device is probed. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 34 -- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 +- 3 files changed, 24 insertions(+), 20

[PATCH 2/3] drm/amd: Introduce new enum for BAMACO

2023-11-28 Thread Mario Limonciello
Rather than plumbing module parameter deep into IP declare BAMACO runpm mode at amdgpu_driver_set_runtime_pm_mode() and then detect this mode in consumers. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 2 +- drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h

[PATCH 0/3] Obey amdgpu.runpm even on BOCO systems

2023-11-28 Thread Mario Limonciello
I've found that on a system that supports BOCO when I try to override it that it still uses BOCO. This is because module parameter use is intermingled with automatic detection. This series moves automatic detection after module parameter use and makes all callers obey the result. Mario

[PATCH 1/3] drm/amd: Fix handling of amdgpu.runpm on systems with BOCO

2023-11-28 Thread Mario Limonciello
in the -1 or -2 cases. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 80 +++-- 1 file changed, 48 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c index b5ebafd4a3ad

PSP_VMBX_POLLING_LIMIT too big

2023-11-28 Thread Mario Limonciello
Hi, In amd-staging-drm-next 46fe6312082c ("drm/amdgpu: update retry times for psp BL wait") and upstream a11156ff6f41 ("drm/amdgpu: update retry times for psp BL wait") the number of loops for psp_v13_0_wait_for_bootloader() to try again increased significantly. It went from 10 loops to 20k

[PATCH] drm/amd: Enable PCIe PME from D3

2023-11-27 Thread Mario Limonciello
When dGPU is put into BOCO it may be in D3cold but still able send PME on display hotplug event. For this to work it must be enabled as wake source from D3. When runpm is enabled use pci_wake_from_d3() to mark wakeup as enabled by default. Cc: sta...@vger.kernel.org # 6.1+ Signed-off-by: Mario

<    1   2   3   4   5   6   7   8   9   10   >