Bug#1053856: (no subject)

2023-10-12 Thread Mario Limonciello
The specific issue here is that there is a firmware binary in upstream linux-firwmare.git, also documented in WHENCE upstream but not installed in Debian's package.

Re: [PATCH v4 1/2] selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut

2023-10-12 Thread Mario Limonciello
-off-by: Swapnil Sapkal Reviewed-by: Mario Limonciello --- .../x86/amd_pstate_tracer/amd_pstate_trace.py | 3 +-- tools/testing/selftests/amd-pstate/gitsource.sh | 17 +++-- tools/testing/selftests/amd-pstate/run.sh | 9 ++--- tools/testing/selftests/amd-pstate

[Kernel-packages] [Bug 2038745] Re: NV31 XTX cannot boot into Ubuntu 22.04.3 Desktop with upstream(inbox) driver installed

2023-10-10 Thread Mario Limonciello
Internal team has tested the Jammy update (20220329.git681281e4-0ubuntu3.21) as well on NV31 XTX card and it looks good there as well. ** Changed in: linux-firmware (Ubuntu Lunar) Status: Fix Released => Fix Committed ** Tags added: verification-done-jammy -- You received this bug

Bug#1053764: radeon-amdgpu-firmware-is-required-for-drm-and-kms-on-r600-onward.patch unnecessary for amdgpu now

2023-10-10 Thread Mario Limonciello
Package: linux Version: 6.5.0-1 Hi, The patch carried by the Debian kernel bugfix/all/radeon-amdgpu-firmware-is-required-for-drm-and-kms-on-r600-onward.patch isn't necessary specifically for amdgpu anymore with modern kernels. AMDGPU has been modified to check for the existence of firmware

Bug#1053764: radeon-amdgpu-firmware-is-required-for-drm-and-kms-on-r600-onward.patch unnecessary for amdgpu now

2023-10-10 Thread Mario Limonciello
Package: linux Version: 6.5.0-1 Hi, The patch carried by the Debian kernel bugfix/all/radeon-amdgpu-firmware-is-required-for-drm-and-kms-on-r600-onward.patch isn't necessary specifically for amdgpu anymore with modern kernels. AMDGPU has been modified to check for the existence of firmware

Re: [PATCH v3 04/16] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-10-10 Thread Mario Limonciello
On 10/10/2023 07:59, Shyam Sundar S K wrote: PMF Policy binary is a encrypted and signed binary that will be part of the BIOS. PMF driver via the ACPI interface checks the existence of Smart PC bit. If the advertised bit is found, PMF driver walks the acpi namespace to find out the policy binary

Re: [PATCH v3 04/16] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-10-10 Thread Mario Limonciello
On 10/10/2023 07:59, Shyam Sundar S K wrote: PMF Policy binary is a encrypted and signed binary that will be part of the BIOS. PMF driver via the ACPI interface checks the existence of Smart PC bit. If the advertised bit is found, PMF driver walks the acpi namespace to find out the policy binary

Re: [PATCH v3 08/16] platform/x86/amd/pmf: Add support to update system state

2023-10-10 Thread Mario Limonciello
accordingly using the systemctl. Sample udev rules under Documentation/admin-guide/pmf.rst. Signed-off-by: Shyam Sundar S K One minor nit below. Reviewed-by: Mario Limonciello --- Documentation/admin-guide/index.rst | 1 + Documentation/admin-guide/pmf.rst | 25

Re: [PATCH v3 08/16] platform/x86/amd/pmf: Add support to update system state

2023-10-10 Thread Mario Limonciello
accordingly using the systemctl. Sample udev rules under Documentation/admin-guide/pmf.rst. Signed-off-by: Shyam Sundar S K One minor nit below. Reviewed-by: Mario Limonciello --- Documentation/admin-guide/index.rst | 1 + Documentation/admin-guide/pmf.rst | 25

Re: [PATCH v3 11/16] platform/x86/amd/pmf: dump policy binary data

2023-10-10 Thread Mario Limonciello
before sending that to TA. Signed-off-by: Shyam Sundar S K Reviewed-by: Mario Limonciello --- drivers/platform/x86/amd/pmf/tee-if.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c index 994daf945795

Re: [PATCH v3 11/16] platform/x86/amd/pmf: dump policy binary data

2023-10-10 Thread Mario Limonciello
before sending that to TA. Signed-off-by: Shyam Sundar S K Reviewed-by: Mario Limonciello --- drivers/platform/x86/amd/pmf/tee-if.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c index 994daf945795

Re: [PATCH v3 16/16] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-10-10 Thread Mario Limonciello
function so that this can be called outside of the current file. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K Signed-off-by: Basavaraj Natikar Reviewed-by: Mario Limonciello --- drivers/hid/amd-sfh-hid/amd_sfh_common.h | 1 + drivers/hid/amd-sfh-hid/sfh1_1

Re: [PATCH v3 16/16] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-10-10 Thread Mario Limonciello
function so that this can be called outside of the current file. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K Signed-off-by: Basavaraj Natikar Reviewed-by: Mario Limonciello --- drivers/hid/amd-sfh-hid/amd_sfh_common.h | 1 + drivers/hid/amd-sfh-hid/sfh1_1

[Kernel-packages] [Bug 2038745] Re: NV31 XTX cannot boot into Ubuntu 22.04.3 Desktop with upstream(inbox) driver installed

2023-10-10 Thread Mario Limonciello
** Tags added: verification-done-lunar -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux-firmware in Ubuntu. https://bugs.launchpad.net/bugs/2038745 Title: NV31 XTX cannot boot into Ubuntu 22.04.3 Desktop with upstream(inbox)

[Kernel-packages] [Bug 2038745] Re: NV31 XTX cannot boot into Ubuntu 22.04.3 Desktop with upstream(inbox) driver installed

2023-10-09 Thread Mario Limonciello
@Juerg: Internal team looked at it, VP with Navi31 XTX boards, VNP with the others. So the testing with OEM-6.1/OEM-6.5 on other Navi31 from earlier bug is accurate. Confirmed that upgrading SMU binary (just dropped into /lib/firmware/updates/amdgpu) fixes the issue. Considering the regression

Re: [PATCH] drm/amd/display: Enable fast plane updates on DCN3.2 and above when state->allow_modeset = true

2023-10-09 Thread Mario Limonciello
On 10/7/2023 00:41, Tianci Yin wrote: From: tiancyin [why] When cursor moves across screen boarder, lag cursor observed, since subvp settings need to sync up with vblank, that cause cursor updates being delayed. [how] Enable fast plane updates on DCN3.2 to fix it. Signed-off-by: tiancyin

Re: [PATCH v6 4/7] drm/amd: Capture errors in amdgpu_switcheroo_set_state()

2023-10-09 Thread Mario Limonciello
On 10/9/2023 13:40, Alex Deucher wrote: On Mon, Oct 9, 2023 at 12:52 PM Mario Limonciello wrote: amdgpu_switcheroo_set_state() calls lots of functions that could fail under memory pressure or for other reasons. Don't assume everything can successfully run sequentially, and check return codes

[PATCH v6 6/7] drm/amd/display: Destroy DC context while keeping DML and DML2

2023-10-09 Thread Mario Limonciello
-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/dc/core/dc.c | 37 --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 12 ++ 2 files changed, 12 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers

[PATCH v6 7/7] drm/amd/display: make dc_set_power_state() return type `void` again

2023-10-09 Thread Mario Limonciello
As dc_set_power_state() no longer allocates memory, it's not necessary to have return types and check return code as it can't fail anymore. Change it back to `void`. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17

[PATCH v6 5/7] drm/amd/display: Catch errors from drm_atomic_helper_suspend()

2023-10-09 Thread Mario Limonciello
nig Acked-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index bd6cb8ffd

[PATCH v6 4/7] drm/amd: Capture errors in amdgpu_switcheroo_set_state()

2023-10-09 Thread Mario Limonciello
amdgpu_switcheroo_set_state() calls lots of functions that could fail under memory pressure or for other reasons. Don't assume everything can successfully run sequentially, and check return codes for everything that returns one. Acked-by: Christian König Signed-off-by: Mario Limonciello

[PATCH v6 3/7] drm/amd: Split up UVD suspend into prepare and suspend steps

2023-10-09 Thread Mario Limonciello
amdgpu_uvd_suspend() allocates memory and copies objects into that allocated memory. This fails under memory pressure. Instead move majority of this code into a prepare step when swap can still be allocated. Reviewed-by: Christian König Signed-off-by: Mario Limonciello --- v5->v6: * D

[PATCH v6 2/7] drm/amd: Add concept of running prepare_suspend() sequence for IP blocks

2023-10-09 Thread Mario Limonciello
Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 +++- drivers/gpu/drm/amd/include/amd_shared.h | 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu

[PATCH v6 1/7] drm/amd: Evict resources during PM ops prepare() callback

2023-10-09 Thread Mario Limonciello
() to move evict majority of resources and update all non-pmops callers to call the same callback. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2362 Reviewed-by: Christian König Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1

[PATCH v6 0/7] Better handle memory pressure at suspend

2023-10-09 Thread Mario Limonciello
pend references v2->v3: * Handle adev->in_suspend in prepare() and complete() * Add missing scratch variable in dc_resource_state_destruct() * Revert error code propagation in same series v1->v2: * Handle DC code too * Add prepare callback rather than moving symbol calls Mario Limonciel

[Kernel-packages] [Bug 2038745] Re: NV31 XTX cannot boot into Ubuntu 22.04.3 Desktop with upstream(inbox) driver installed

2023-10-07 Thread Mario Limonciello
** Changed in: linux-firmware (Ubuntu Lunar) Status: New => Confirmed ** Changed in: linux-firmware (Ubuntu Jammy) Status: New => Confirmed ** Changed in: linux-firmware (Ubuntu Jammy) Importance: Undecided => Critical ** Changed in: linux-firmware (Ubuntu Lunar) Importance:

[Kernel-packages] [Bug 2024427] Re: S3 stress issue for amdgpu Navi 31/Navi33

2023-10-07 Thread Mario Limonciello
Let's track the regression in https://bugs.launchpad.net/ubuntu/+source/linux-firmware/+bug/2038745 ** Changed in: linux-firmware (Ubuntu Jammy) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to

[Kernel-packages] [Bug 2038745] Re: NV31 XTX cannot boot into Ubuntu 22.04.3 Desktop with upstream(inbox) driver installed

2023-10-07 Thread Mario Limonciello
I believe the same thing should be done for Navi33 at same time, it upgraded IMU as well. So these two commits are needed in Jammy and Lunar: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux- firmware.git/commit/amdgpu/smu_13_0_0.bin?id=39d6fcc73100ae4aeeec0194bbf102c672673edd

[Kernel-packages] [Bug 2024427] Re: S3 stress issue for amdgpu Navi 31/Navi33

2023-10-07 Thread Mario Limonciello
Instead of reverting the IMU binary can you please upgrade the SMU binary from the same 5.5 release ? Navi31: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/amdgpu/smu_13_0_0.bin?id=39d6fcc73100ae4aeeec0194bbf102c672673edd Navi33:

[Kernel-packages] [Bug 2024427] Re: S3 stress issue for amdgpu Navi 31/Navi33

2023-10-07 Thread Mario Limonciello
Thanks, let me check with others on Monday if that's the right action for your issue. ** Changed in: linux-firmware (Ubuntu Jammy) Status: Fix Released => Triaged -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux-firmware in

[Kernel-packages] [Bug 2024427] Re: S3 stress issue for amdgpu Navi 31/Navi33

2023-10-06 Thread Mario Limonciello
Can you please upload your journal from the failure? Also can you please experiment with rolling back to this one version of this one firmware binary: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-

Re: [PATCH v3 1/2] selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut

2023-10-06 Thread Mario Limonciello
On 10/3/2023 00:10, Swapnil Sapkal wrote: In selftests/amd-pstate, tbench and gitsource microbenchmarks are used to compare the performance with different governors. In Current s/Current/current/ implementation relative path to run `amd_pstate_tracer.py` are broken. The plurality of this

Re: [PATCH v3 2/2] selftests/amd-pstate: Added option to provide perf binary path

2023-10-06 Thread Mario Limonciello
--- One small nit, otherwise: Reviewed-by: Mario Limonciello tools/testing/selftests/amd-pstate/gitsource.sh | 2 +- tools/testing/selftests/amd-pstate/run.sh | 14 ++ tools/testing/selftests/amd-pstate/tbench.sh| 2 +- 3 files changed, 12 insertions(+), 6 deletions

[PATCH v5 6/7] drm/amd/display: Destroy DC context while keeping DML and DML2

2023-10-06 Thread Mario Limonciello
-by: Mario Limonciello --- v4->v5: * Rebase for DML2 --- drivers/gpu/drm/amd/display/dc/core/dc.c | 37 --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 12 ++ 2 files changed, 12 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c

[PATCH v5 7/7] drm/amd/display: make dc_set_power_state() return type `void` again

2023-10-06 Thread Mario Limonciello
As dc_set_power_state() no longer allocates memory, it's not necessary to have return types and check return code as it can't fail anymore. Change it back to `void`. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v4->v5: * Pick up tag --- .../gpu/drm/amd/display/amdgpu

[PATCH v5 5/7] drm/amd/display: Catch errors from drm_atomic_helper_suspend()

2023-10-06 Thread Mario Limonciello
drm_atomic_helper_suspend() can return PTR_ERR(), in which case the error gets stored into `dm->cached_state`. This can cause failures during resume. Catch the error during suspend and fail the suspend instead. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2362 Signed-off-by: Ma

[PATCH v5 3/7] drm/amd: Split up UVD suspend into prepare and suspend steps

2023-10-06 Thread Mario Limonciello
amdgpu_uvd_suspend() allocates memory and copies objects into that allocated memory. This fails under memory pressure. Instead move majority of this code into a prepare step when swap can still be allocated. Signed-off-by: Mario Limonciello --- v4->v5: * New patch --- drivers/gpu/drm/

[PATCH v5 4/7] drm/amd: Capture errors in amdgpu_switcheroo_set_state()

2023-10-06 Thread Mario Limonciello
amdgpu_switcheroo_set_state() calls lots of functions that could fail under memory pressure or for other reasons. Don't assume everything can successfully run sequentially, and check return codes for everything that returns one. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu

[PATCH v5 2/7] drm/amd: Add concept of running prepare() sequence for IP blocks

2023-10-06 Thread Mario Limonciello
If any IP blocks allocate memory during their sw_fini() sequence this can cause the suspend to fail under memory pressure. Introduce a new phase that IP blocks can use to allocate memory before suspend starts so that it can potentially be evicted into swap instead. Signed-off-by: Mario

[PATCH v5 1/7] drm/amd: Evict resources during PM ops prepare() callback

2023-10-06 Thread Mario Limonciello
() to move evict majority of resources and update all non-pmops callers to call the same callback. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2362 Signed-off-by: Mario Limonciello --- v4->v5: * Call amdgpu_device_prepare() from other callers to amdgpu_device_suspend() * 3x evict calls -&

[PATCH v5 0/7] Better handle memory pressure at suspend

2023-10-06 Thread Mario Limonciello
callback rather than moving symbol calls Mario Limonciello (3): drm/amd: Evict resources during PM ops prepare() callback drm/amd/display: Destroy DC context while keeping DML drm/amd/display: make dc_set_power_state() return type `void` again Mario Limonciello (7): drm/amd: Evict resources

Re: [PATCH 2/3] power: supply: Don't count 'unknown' scope power supplies

2023-10-05 Thread Mario Limonciello
On 10/4/2023 18:10, Sebastian Reichel wrote: Hi, On Sun, Oct 01, 2023 at 07:00:11PM -0500, Mario Limonciello wrote: Let me try to add more detail. This is an OEM system that has 3 USB type C ports. It's an Intel system, but this doesn't matter for the issue. * when ucsi_acpi is not loaded

Re: [PATCH v2 2/2] Revert "drm/amd/pm: workaround for the wrong ac power detection on smu 13.0.0"

2023-10-05 Thread Mario Limonciello
On 10/5/2023 14:12, Greg Kroah-Hartman wrote: On Thu, Oct 05, 2023 at 12:52:30PM -0500, Mario Limonciello wrote: This reverts commit 0e5e1a84f0b8c814d502a135824244127fed8f23. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello No explaination as to why this needs to be reverted

[PATCH v2 1/2] usb: typec: ucsi: Use GET_CAPABILITY attributes data to set power supply scope

2023-10-05 Thread Mario Limonciello
") Link: https://www.intel.com/content/www/us/en/products/docs/io/universal-serial-bus/usb-type-c-ucsi-spec.html p28 Signed-off-by: Mario Limonciello --- Cc: Kai-Heng Feng Cc: Alex Deucher > Cc: Richard Gong --- drivers/usb/typec/ucsi/psy.c | 9 + 1 file changed, 9 insertions(+) d

[PATCH v2 2/2] Revert "drm/amd/pm: workaround for the wrong ac power detection on smu 13.0.0"

2023-10-05 Thread Mario Limonciello
This reverts commit 0e5e1a84f0b8c814d502a135824244127fed8f23. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 3 ++- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 1 + 2 files changed, 3 insertions(+), 1 deletion

[PATCH v2 0/2] Fix Navi3x boot and hotplug problems

2023-10-05 Thread Mario Limonciello
fix the problematic power supply driver. v1: https://lore.kernel.org/linux-pm/20230926225955.386553-1-mario.limoncie...@amd.com/ Mario Limonciello (2): usb: typec: ucsi: Use GET_CAPABILITY attributes data to set power supply scope Revert "drm/amd/pm: workaround for the wrong ac power d

Re: [PATCH v4 1/3] drm/amd: Evict resources during PM ops prepare() callback

2023-10-05 Thread Mario Limonciello
On 10/5/2023 09:39, Christian König wrote: Am 04.10.23 um 19:18 schrieb Mario Limonciello: Linux PM core has a prepare() callback run before suspend. If the system is under high memory pressure, the resources may need to be evicted into swap instead.  If the storage backing for swap

[Kernel-packages] [Bug 2036742] Re: amdgpu crash on Mantic

2023-10-05 Thread Mario Limonciello
I don't expect it helps your boot issue, but the UBSAN issue will be fixed by this commit. https://lore.kernel.org/amd- gfx/78abc334-44ed-4632-8796-6bbe9c432...@amd.com/T/#me31ff6b88640b03be1a8edfc6fc8878ac78ca6bb Please redo the test with 5.15. -- You received this bug notification because

Re: [PATCH v4 2/3] drm/amd/display: Destroy DC context while keeping DML

2023-10-05 Thread Mario Limonciello
On 10/5/2023 09:27, Alex Deucher wrote: On Wed, Oct 4, 2023 at 1:37 PM Mario Limonciello wrote: If there is memory pressure at suspend time then dynamically allocating a large structure as part of DC suspend code will fail. Instead re-use the same structure and clear all members except those

Re: [PATCH] drm/amd: Fix UBSAN array-index-out-of-bounds for Polaris and Tonga

2023-10-05 Thread Mario Limonciello
On 10/4/2023 16:50, Alex Deucher wrote: On Wed, Oct 4, 2023 at 5:42 PM Mario Limonciello wrote: For pptable structs that use flexible array sizes, use flexible arrays. Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2036742 Signed-off-by: Mario Limonciello Acked-by: Alex

Re: [PATCH v3 1/4] drm/amd: Add support for prepare() and complete() callbacks

2023-10-05 Thread Mario Limonciello
On 10/5/2023 07:35, Christian König wrote: Am 04.10.23 um 05:39 schrieb Mario Limonciello: On 10/3/2023 16:22, Deucher, Alexander wrote: [Public] -Original Message- From: Limonciello, Mario Sent: Tuesday, October 3, 2023 5:17 PM To: Deucher, Alexander ; amd- g

[Ubuntu-x-swat] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-05 Thread Mario Limonciello
Ok in this case can you please open an upstream mesa bug? ** Changed in: mesa (Ubuntu) Status: Fix Released => Triaged -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to mesa in Ubuntu. https://bugs.launchpad.net/bugs/2037641 Title:

[Touch-packages] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-05 Thread Mario Limonciello
Ok in this case can you please open an upstream mesa bug? ** Changed in: mesa (Ubuntu) Status: Fix Released => Triaged -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to mesa in Ubuntu.

[Desktop-packages] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-05 Thread Mario Limonciello
Ok in this case can you please open an upstream mesa bug? ** Changed in: mesa (Ubuntu) Status: Fix Released => Triaged -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to mesa in Ubuntu. https://bugs.launchpad.net/bugs/2037641

[Kernel-packages] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-05 Thread Mario Limonciello
Ok in this case can you please open an upstream mesa bug? ** Changed in: mesa (Ubuntu) Status: Fix Released => Triaged -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/2037641

[PATCH] drm/amd: Fix UBSAN array-index-out-of-bounds for Polaris and Tonga

2023-10-04 Thread Mario Limonciello
For pptable structs that use flexible array sizes, use flexible arrays. Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2036742 Signed-off-by: Mario Limonciello --- >From this bug report there are more to fix .../gpu/drm/amd/pm/powerplay/hwmgr/pptable_v1_0.h| 12 ++--

[Ubuntu-x-swat] [Bug 2037672] Re: amdgpu: [gfxhub] page fault when switching a video to or from fullscreen

2023-10-04 Thread Mario Limonciello
Also - can you still repro with mesa 23.2.1-1ubuntu2? This just landed right after you reported this issue. ** Changed in: linux (Ubuntu) Status: Confirmed => Invalid ** Changed in: mesa (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you

[Touch-packages] [Bug 2037672] Re: amdgpu: [gfxhub] page fault when switching a video to or from fullscreen

2023-10-04 Thread Mario Limonciello
Also - can you still repro with mesa 23.2.1-1ubuntu2? This just landed right after you reported this issue. ** Changed in: linux (Ubuntu) Status: Confirmed => Invalid ** Changed in: mesa (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you

[Kernel-packages] [Bug 2037672] Re: amdgpu: [gfxhub] page fault when switching a video to or from fullscreen

2023-10-04 Thread Mario Limonciello
Also - can you still repro with mesa 23.2.1-1ubuntu2? This just landed right after you reported this issue. ** Changed in: linux (Ubuntu) Status: Confirmed => Invalid ** Changed in: mesa (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you

[Desktop-packages] [Bug 2037672] Re: amdgpu: [gfxhub] page fault when switching a video to or from fullscreen

2023-10-04 Thread Mario Limonciello
Also - can you still repro with mesa 23.2.1-1ubuntu2? This just landed right after you reported this issue. ** Changed in: linux (Ubuntu) Status: Confirmed => Invalid ** Changed in: mesa (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you

[PATCH 2/2] drm/radeon: Fix UBSAN array-index-out-of-bounds for Radeon HD 5430

2023-10-04 Thread Mario Limonciello
For pptable structs that use flexible array sizes, use flexible arrays. Suggested-by: Felix Held Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2894 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/radeon/pptable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/2] drm/amd: Fix UBSAN array-index-out-of-bounds for SMU7

2023-10-04 Thread Mario Limonciello
For pptable structs that use flexible array sizes, use flexible arrays. Suggested-by: Felix Held Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2874 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/include/pptable.h | 4 ++-- drivers/gpu/drm/amd/pm/powerplay

[PATCH v4 3/3] drm/amd/display: make dc_set_power_state() return type `void` again

2023-10-04 Thread Mario Limonciello
As dc_set_power_state() no longer allocates memory, it's not necessary to have return types and check return code as it can't fail anymore. Change it back to `void`. Signed-off-by: Mario Limonciello --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 + drivers/gpu/drm/amd

[PATCH v4 1/3] drm/amd: Evict resources during PM ops prepare() callback

2023-10-04 Thread Mario Limonciello
() to move evict majority of resources while leaving all existing steps that put the GPU into a low power state in suspend(). Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2362 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu

[PATCH v4 2/3] drm/amd/display: Destroy DC context while keeping DML

2023-10-04 Thread Mario Limonciello
-by: Mario Limonciello --- drivers/gpu/drm/amd/display/dc/core/dc.c | 25 --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 12 + 2 files changed, 12 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc

[PATCH v4 0/3] Better handle memory pressure at suspend

2023-10-04 Thread Mario Limonciello
eries v1->v2: * Handle DC code too * Add prepare callback rather than moving symbol calls Mario Limonciello (3): drm/amd: Evict resources during PM ops prepare() callback drm/amd/display: Destroy DC context while keeping DML drm/amd/display: make dc_set_power_state() return type `void` again

[Touch-packages] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-04 Thread Mario Limonciello
I'd say that's very likely. That mesa upgrade just landed in the archive a few days ago and the trace you reported looks more like how a mesa bug manifests. ** Changed in: linux (Ubuntu) Status: Confirmed => Invalid ** Changed in: mesa (Ubuntu) Status: New => Fix Released -- You

[Desktop-packages] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-04 Thread Mario Limonciello
I'd say that's very likely. That mesa upgrade just landed in the archive a few days ago and the trace you reported looks more like how a mesa bug manifests. ** Changed in: linux (Ubuntu) Status: Confirmed => Invalid ** Changed in: mesa (Ubuntu) Status: New => Fix Released -- You

[Kernel-packages] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-04 Thread Mario Limonciello
I'd say that's very likely. That mesa upgrade just landed in the archive a few days ago and the trace you reported looks more like how a mesa bug manifests. ** Changed in: linux (Ubuntu) Status: Confirmed => Invalid ** Changed in: mesa (Ubuntu) Status: New => Fix Released -- You

[Ubuntu-x-swat] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-04 Thread Mario Limonciello
I'd say that's very likely. That mesa upgrade just landed in the archive a few days ago and the trace you reported looks more like how a mesa bug manifests. ** Changed in: linux (Ubuntu) Status: Confirmed => Invalid ** Changed in: mesa (Ubuntu) Status: New => Fix Released -- You

Re: [PATCH v3 1/4] drm/amd: Add support for prepare() and complete() callbacks

2023-10-03 Thread Mario Limonciello
() and complete() callbacks On 10/3/2023 16:11, Deucher, Alexander wrote: [Public] -Original Message- From: amd-gfx On Behalf Of Mario Limonciello Sent: Tuesday, October 3, 2023 4:55 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Limonciello, Mario Subject: [PATCH v3 1/4] drm/amd

Re: [PATCH v3 1/4] drm/amd: Add support for prepare() and complete() callbacks

2023-10-03 Thread Mario Limonciello
On 10/3/2023 16:11, Deucher, Alexander wrote: [Public] -Original Message- From: amd-gfx On Behalf Of Mario Limonciello Sent: Tuesday, October 3, 2023 4:55 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Limonciello, Mario Subject: [PATCH v3 1/4] drm/amd: Add support

[PATCH v3 4/4] drm/amd/display: make dc_set_power_state() return type `void` again

2023-10-03 Thread Mario Limonciello
As dc_set_power_state() no longer allocates memory, it's not necessary to have return types and check return code as it can't fail anymore. Change it back to `void`. Signed-off-by: Mario Limonciello --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 + drivers/gpu/drm/amd

[PATCH v3 3/4] drm/amd/display: Destroy DC context while keeping DML

2023-10-03 Thread Mario Limonciello
-by: Mario Limonciello --- Cc: harry.wentl...@amd.com --- drivers/gpu/drm/amd/display/dc/core/dc.c | 25 --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 12 + 2 files changed, 12 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b

[PATCH v3 2/4] drm/amd: Move evict resources suspend step to prepare()

2023-10-03 Thread Mario Limonciello
into a low power state in suspend(). Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2362 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers

[PATCH v3 1/4] drm/amd: Add support for prepare() and complete() callbacks

2023-10-03 Thread Mario Limonciello
this call instead of the suspend() callback. By moving the allocations to prepare() the system suspend will be failed before any IP block has done any suspend code. If the suspend fails, then do any cleanups in the complete() callback. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd

[PATCH v3 0/4] Better handle memory pressure at suspend

2023-10-03 Thread Mario Limonciello
cratch variable in dc_resource_state_destruct() * Revert error code propagation in same series v1->v2: * Handle DC code too * Add prepare callback rather than moving symbol calls Mario Limonciello (4): drm/amd: Add support for prepare() and complete() callbacks drm/amd: Move evict resource

[Ubuntu-x-swat] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-03 Thread Mario Limonciello
Are you up to date on the current version of mesa in 23.10? 23.2.1-1ubuntu2? ** Also affects: mesa (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to mesa in Ubuntu.

[Touch-packages] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-03 Thread Mario Limonciello
Are you up to date on the current version of mesa in 23.10? 23.2.1-1ubuntu2? ** Also affects: mesa (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to mesa in Ubuntu.

[Desktop-packages] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-03 Thread Mario Limonciello
Are you up to date on the current version of mesa in 23.10? 23.2.1-1ubuntu2? ** Also affects: mesa (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to mesa in Ubuntu.

[Kernel-packages] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-03 Thread Mario Limonciello
Are you up to date on the current version of mesa in 23.10? 23.2.1-1ubuntu2? ** Also affects: mesa (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.

Re: [PATCH v2 2/3] drm/amd: Move evict resources suspend step to prepare()

2023-10-03 Thread Mario Limonciello
On 10/3/2023 07:58, Deucher, Alexander wrote: [AMD Official Use Only - General] -Original Message- From: amd-gfx On Behalf Of Mario Limonciello Sent: Monday, October 2, 2023 6:45 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Limonciello, Mario Subject: [PATCH v2 2/3] drm

[PATCH v2 3/3] drm/amd/display: Destroy DC context while keeping DML

2023-10-02 Thread Mario Limonciello
-by: Mario Limonciello --- Cc: harry.wentl...@amd.com --- drivers/gpu/drm/amd/display/dc/core/dc.c | 25 --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 11 2 files changed, 11 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b

[PATCH v2 2/3] drm/amd: Move evict resources suspend step to prepare()

2023-10-02 Thread Mario Limonciello
into a low power state in suspend(). Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2362 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b

[PATCH v2 1/3] drm/amd: Add support for prepare() callback

2023-10-02 Thread Mario Limonciello
this call instead of the suspend() callback. By moving the allocations to prepare() the system suspend will be failed before any IP block has done any suspend code. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH v2 0/3] Better handle memory pressure at suspend

2023-10-02 Thread Mario Limonciello
: https://patchwork.freedesktop.org/patch/559270/ v1->v2: * Handle DC code too * Add prepare callback rather than moving symbol calls Mario Limonciello (3): drm/amd: Add support for prepare() callback drm/amd: Move evict resources suspend step to prepare() drm/amd/display: Destroy DC cont

Re: [2/3] drm/amdgpu: fall back to INPUT power for AVG power via INFO IOCTL

2023-10-02 Thread Mario Limonciello
On 10/2/2023 13:49, Alex Deucher wrote: For backwards compatibility with userspace. Fixes: 47f1724db4fe ("drm/amd: Introduce `AMDGPU_PP_SENSOR_GPU_INPUT_POWER`") Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2897 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[Kernel-packages] [Bug 2024427] Re: S3 stress issue for amdgpu Navi 31/Navi33

2023-10-02 Thread Mario Limonciello
AMD internal team has tested this updated firmware package against Navi31 and Navi33 dGPUs on both OEM-6.1 and OEM-6.5 kernels. No new problems introduced. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux-firmware in Ubuntu.

Re: [PATCH 2/3] power: supply: Don't count 'unknown' scope power supplies

2023-10-01 Thread Mario Limonciello
On 9/30/2023 15:18, Sebastian Reichel wrote: Hi, On Tue, Sep 26, 2023 at 05:59:54PM -0500, Mario Limonciello wrote: On some systems AMD Navi3x dGPU triggers RAS errors on startup; but only if the amdgpu kernel module is not part of the initramfs. This is because the hardware is not properly

[PATCH 2/2] drm/amd: Drop all hand-built MIN and MAX macros in the amdgpu base driver

2023-09-29 Thread Mario Limonciello
Several files declare MIN() or MAX() macros that ignore the types of the values being compared. Drop these macros and switch to min() min_t(), and max() from `linux/minmax.h`. Suggested-by: Hamza Mahfooz Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu.h

[PATCH 1/2] drm/amd: Update `update_pcie_parameters` functions to use uint8_t arguments

2023-09-29 Thread Mario Limonciello
The matching values for `pcie_gen_cap` and `pcie_width_cap` when fetched from powerplay tables are 1 byte, so narrow the arguments to match to ensure min() and max() comparisons without casts. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2

[Desktop-packages] [Bug 2016435] Re: amdgpu driver randomly resets

2023-09-29 Thread Mario Limonciello
Random resets are "typically" triggered by mesa or application bugs. Can you still trigger them in the latest mantic (which has a more up to date mesa and kernel)? ** Changed in: xserver-xorg-video-amdgpu (Ubuntu) Status: New => Invalid ** Changed in: mesa (Ubuntu) Status: New =>

[Touch-packages] [Bug 1987792] Re: Totem and VLC crash when playing dvd with VAAPI radeon mesa drivers

2023-09-29 Thread Mario Limonciello
** Changed in: mesa (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to mesa in Ubuntu. https://bugs.launchpad.net/bugs/1987792 Title: Totem and VLC crash when playing dvd with VAAPI

[Desktop-packages] [Bug 1987792] Re: Totem and VLC crash when playing dvd with VAAPI radeon mesa drivers

2023-09-29 Thread Mario Limonciello
** Changed in: mesa (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to mesa in Ubuntu. https://bugs.launchpad.net/bugs/1987792 Title: Totem and VLC crash when playing dvd with VAAPI radeon mesa

[Ubuntu-x-swat] [Bug 1987792] Re: Totem and VLC crash when playing dvd with VAAPI radeon mesa drivers

2023-09-29 Thread Mario Limonciello
** Changed in: mesa (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to mesa in Ubuntu. https://bugs.launchpad.net/bugs/1987792 Title: Totem and VLC crash when playing dvd with VAAPI radeon mesa drivers

[Ubuntu-x-swat] [Bug 2016435] Re: amdgpu driver randomly resets

2023-09-29 Thread Mario Limonciello
Random resets are "typically" triggered by mesa or application bugs. Can you still trigger them in the latest mantic (which has a more up to date mesa and kernel)? ** Changed in: xserver-xorg-video-amdgpu (Ubuntu) Status: New => Invalid ** Changed in: mesa (Ubuntu) Status: New =>

[Touch-packages] [Bug 2016435] Re: amdgpu driver randomly resets

2023-09-29 Thread Mario Limonciello
Random resets are "typically" triggered by mesa or application bugs. Can you still trigger them in the latest mantic (which has a more up to date mesa and kernel)? ** Changed in: xserver-xorg-video-amdgpu (Ubuntu) Status: New => Invalid ** Changed in: mesa (Ubuntu) Status: New =>

[Desktop-packages] [Bug 1094959] Re: package libgl1-mesa-dri 8.0.4-0ubuntu0.2 failed to install/upgrade

2023-09-29 Thread Mario Limonciello
> NonfreeKernelModules: fglrx Nothing that will be done in mesa for an issue with fglrx anyway these days. ** Changed in: mesa (Ubuntu) Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to mesa in

[Ubuntu-x-swat] [Bug 1094959] Re: package libgl1-mesa-dri 8.0.4-0ubuntu0.2 failed to install/upgrade

2023-09-29 Thread Mario Limonciello
> NonfreeKernelModules: fglrx Nothing that will be done in mesa for an issue with fglrx anyway these days. ** Changed in: mesa (Ubuntu) Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to mesa in Ubuntu.

[Touch-packages] [Bug 1094959] Re: package libgl1-mesa-dri 8.0.4-0ubuntu0.2 failed to install/upgrade

2023-09-29 Thread Mario Limonciello
> NonfreeKernelModules: fglrx Nothing that will be done in mesa for an issue with fglrx anyway these days. ** Changed in: mesa (Ubuntu) Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to

<    4   5   6   7   8   9   10   11   12   13   >