[Kernel-packages] [Bug 2037641] Re: amdgpu: [gfxhub0] no-retry page fault

2023-10-03 Thread Mario Limonciello
Are you up to date on the current version of mesa in 23.10? 23.2.1-1ubuntu2? ** Also affects: mesa (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.

Re: [PATCH v2 2/3] drm/amd: Move evict resources suspend step to prepare()

2023-10-03 Thread Mario Limonciello
On 10/3/2023 07:58, Deucher, Alexander wrote: [AMD Official Use Only - General] -Original Message- From: amd-gfx On Behalf Of Mario Limonciello Sent: Monday, October 2, 2023 6:45 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Limonciello, Mario Subject: [PATCH v2 2/3] drm

[PATCH v2 3/3] drm/amd/display: Destroy DC context while keeping DML

2023-10-02 Thread Mario Limonciello
-by: Mario Limonciello --- Cc: harry.wentl...@amd.com --- drivers/gpu/drm/amd/display/dc/core/dc.c | 25 --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 11 2 files changed, 11 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b

[PATCH v2 2/3] drm/amd: Move evict resources suspend step to prepare()

2023-10-02 Thread Mario Limonciello
into a low power state in suspend(). Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2362 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b

[PATCH v2 1/3] drm/amd: Add support for prepare() callback

2023-10-02 Thread Mario Limonciello
this call instead of the suspend() callback. By moving the allocations to prepare() the system suspend will be failed before any IP block has done any suspend code. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH v2 0/3] Better handle memory pressure at suspend

2023-10-02 Thread Mario Limonciello
: https://patchwork.freedesktop.org/patch/559270/ v1->v2: * Handle DC code too * Add prepare callback rather than moving symbol calls Mario Limonciello (3): drm/amd: Add support for prepare() callback drm/amd: Move evict resources suspend step to prepare() drm/amd/display: Destroy DC cont

Re: [2/3] drm/amdgpu: fall back to INPUT power for AVG power via INFO IOCTL

2023-10-02 Thread Mario Limonciello
On 10/2/2023 13:49, Alex Deucher wrote: For backwards compatibility with userspace. Fixes: 47f1724db4fe ("drm/amd: Introduce `AMDGPU_PP_SENSOR_GPU_INPUT_POWER`") Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2897 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[Kernel-packages] [Bug 2024427] Re: S3 stress issue for amdgpu Navi 31/Navi33

2023-10-02 Thread Mario Limonciello
AMD internal team has tested this updated firmware package against Navi31 and Navi33 dGPUs on both OEM-6.1 and OEM-6.5 kernels. No new problems introduced. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux-firmware in Ubuntu.

Re: [PATCH 2/3] power: supply: Don't count 'unknown' scope power supplies

2023-10-01 Thread Mario Limonciello
On 9/30/2023 15:18, Sebastian Reichel wrote: Hi, On Tue, Sep 26, 2023 at 05:59:54PM -0500, Mario Limonciello wrote: On some systems AMD Navi3x dGPU triggers RAS errors on startup; but only if the amdgpu kernel module is not part of the initramfs. This is because the hardware is not properly

[PATCH 2/2] drm/amd: Drop all hand-built MIN and MAX macros in the amdgpu base driver

2023-09-29 Thread Mario Limonciello
Several files declare MIN() or MAX() macros that ignore the types of the values being compared. Drop these macros and switch to min() min_t(), and max() from `linux/minmax.h`. Suggested-by: Hamza Mahfooz Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu.h

[PATCH 1/2] drm/amd: Update `update_pcie_parameters` functions to use uint8_t arguments

2023-09-29 Thread Mario Limonciello
The matching values for `pcie_gen_cap` and `pcie_width_cap` when fetched from powerplay tables are 1 byte, so narrow the arguments to match to ensure min() and max() comparisons without casts. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2

[Desktop-packages] [Bug 2016435] Re: amdgpu driver randomly resets

2023-09-29 Thread Mario Limonciello
Random resets are "typically" triggered by mesa or application bugs. Can you still trigger them in the latest mantic (which has a more up to date mesa and kernel)? ** Changed in: xserver-xorg-video-amdgpu (Ubuntu) Status: New => Invalid ** Changed in: mesa (Ubuntu) Status: New =>

[Touch-packages] [Bug 1987792] Re: Totem and VLC crash when playing dvd with VAAPI radeon mesa drivers

2023-09-29 Thread Mario Limonciello
** Changed in: mesa (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to mesa in Ubuntu. https://bugs.launchpad.net/bugs/1987792 Title: Totem and VLC crash when playing dvd with VAAPI

[Desktop-packages] [Bug 1987792] Re: Totem and VLC crash when playing dvd with VAAPI radeon mesa drivers

2023-09-29 Thread Mario Limonciello
** Changed in: mesa (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to mesa in Ubuntu. https://bugs.launchpad.net/bugs/1987792 Title: Totem and VLC crash when playing dvd with VAAPI radeon mesa

[Ubuntu-x-swat] [Bug 1987792] Re: Totem and VLC crash when playing dvd with VAAPI radeon mesa drivers

2023-09-29 Thread Mario Limonciello
** Changed in: mesa (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to mesa in Ubuntu. https://bugs.launchpad.net/bugs/1987792 Title: Totem and VLC crash when playing dvd with VAAPI radeon mesa drivers

[Ubuntu-x-swat] [Bug 2016435] Re: amdgpu driver randomly resets

2023-09-29 Thread Mario Limonciello
Random resets are "typically" triggered by mesa or application bugs. Can you still trigger them in the latest mantic (which has a more up to date mesa and kernel)? ** Changed in: xserver-xorg-video-amdgpu (Ubuntu) Status: New => Invalid ** Changed in: mesa (Ubuntu) Status: New =>

[Touch-packages] [Bug 2016435] Re: amdgpu driver randomly resets

2023-09-29 Thread Mario Limonciello
Random resets are "typically" triggered by mesa or application bugs. Can you still trigger them in the latest mantic (which has a more up to date mesa and kernel)? ** Changed in: xserver-xorg-video-amdgpu (Ubuntu) Status: New => Invalid ** Changed in: mesa (Ubuntu) Status: New =>

[Desktop-packages] [Bug 1094959] Re: package libgl1-mesa-dri 8.0.4-0ubuntu0.2 failed to install/upgrade

2023-09-29 Thread Mario Limonciello
> NonfreeKernelModules: fglrx Nothing that will be done in mesa for an issue with fglrx anyway these days. ** Changed in: mesa (Ubuntu) Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to mesa in

[Ubuntu-x-swat] [Bug 1094959] Re: package libgl1-mesa-dri 8.0.4-0ubuntu0.2 failed to install/upgrade

2023-09-29 Thread Mario Limonciello
> NonfreeKernelModules: fglrx Nothing that will be done in mesa for an issue with fglrx anyway these days. ** Changed in: mesa (Ubuntu) Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to mesa in Ubuntu.

[Touch-packages] [Bug 1094959] Re: package libgl1-mesa-dri 8.0.4-0ubuntu0.2 failed to install/upgrade

2023-09-29 Thread Mario Limonciello
> NonfreeKernelModules: fglrx Nothing that will be done in mesa for an issue with fglrx anyway these days. ** Changed in: mesa (Ubuntu) Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to

[Ubuntu-x-swat] [Bug 2037672] Re: amdgpu: [gfxhub] page fault when switching a video to or from fullscreen

2023-09-29 Thread Mario Limonciello
In this case the kernel is the "messenger" for the page fault. This is more likely to be a mesa or application issue than a kernel issue. Can you please raise a ticket to the upstream mesa bug tracker? https://gitlab.freedesktop.org/mesa/mesa/ ** Also affects: mesa (Ubuntu) Importance:

[Touch-packages] [Bug 2037672] Re: amdgpu: [gfxhub] page fault when switching a video to or from fullscreen

2023-09-29 Thread Mario Limonciello
In this case the kernel is the "messenger" for the page fault. This is more likely to be a mesa or application issue than a kernel issue. Can you please raise a ticket to the upstream mesa bug tracker? https://gitlab.freedesktop.org/mesa/mesa/ ** Also affects: mesa (Ubuntu) Importance:

[Kernel-packages] [Bug 2037672] Re: amdgpu: [gfxhub] page fault when switching a video to or from fullscreen

2023-09-29 Thread Mario Limonciello
In this case the kernel is the "messenger" for the page fault. This is more likely to be a mesa or application issue than a kernel issue. Can you please raise a ticket to the upstream mesa bug tracker? https://gitlab.freedesktop.org/mesa/mesa/ ** Also affects: mesa (Ubuntu) Importance:

[Desktop-packages] [Bug 2037672] Re: amdgpu: [gfxhub] page fault when switching a video to or from fullscreen

2023-09-29 Thread Mario Limonciello
In this case the kernel is the "messenger" for the page fault. This is more likely to be a mesa or application issue than a kernel issue. Can you please raise a ticket to the upstream mesa bug tracker? https://gitlab.freedesktop.org/mesa/mesa/ ** Also affects: mesa (Ubuntu) Importance:

Re: [PATCH] drm/amd: Fix logic error in sienna_cichlid_update_pcie_parameters()

2023-09-29 Thread Mario Limonciello
On 9/29/2023 10:23, Hamza Mahfooz wrote: On 9/26/23 22:07, Mario Limonciello wrote: While aligning SMU11 with SMU13 implementation an assumption was made that `dpm_context->dpm_tables.pcie_table` was populated in dpm table initialization like in SMU13 but it isn't. So restore s

[PATCH] drm/amd: Fix logic error in sienna_cichlid_update_pcie_parameters()

2023-09-28 Thread Mario Limonciello
rameters implementation with SMU13") Signed-off-by: Mario Limonciello --- .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 41 +++ 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd/p

Re: [PATCH 0/3] Fix Navi3x boot and hotplug problems

2023-09-28 Thread Mario Limonciello
On 9/28/2023 13:00, Alex Deucher wrote: On Thu, Sep 28, 2023 at 12:41 PM Mario Limonciello wrote: On some OEM systems multiple navi3x dGPUS are triggering RAS errors and BACO errors. These errors come from elements of the OEM system that weren't part of original test environment

[PATCH 3/3] Revert "drm/amd/pm: workaround for the wrong ac power detection on smu 13.0.0"

2023-09-28 Thread Mario Limonciello
This workaround is not necessary with the power supply core fixed. This reverts commit 0e5e1a84f0b8c814d502a135824244127fed8f23. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 3 ++- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 1 + 2

[PATCH 0/3] Fix Navi3x boot and hotplug problems

2023-09-28 Thread Mario Limonciello
this all through DRM because there is a workaround in linux-next that I would like to be reverted at the same time as picking up the first two patches. Mario Limonciello (3): drm/amd: Fix detection of _PR3 on the PCIe root port power: supply: Don't count 'unknown' scope power supplies Revert

[PATCH 2/3] power: supply: Don't count 'unknown' scope power supplies

2023-09-28 Thread Mario Limonciello
Signed-off-by: Mario Limonciello --- drivers/power/supply/power_supply_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c index d325e6dbc770..3de6e6d00815 100644 --- a/drivers/po

[PATCH 1/3] drm/amd: Fix detection of _PR3 on the PCIe root port

2023-09-28 Thread Mario Limonciello
BOCO detection logic to fail. Fix the intent of the logic by looking at root port, not the immediate upstream bridge for _PR3. Cc: sta...@vger.kernel.org Suggested-by: Jun Ma Tested-by: David Perry Fixes: b10c1c5b3a4e ("drm/amdgpu: add check for ACPI power resources") Signed-off

[PATCH v2 1/2] drm/amd: Move `enum drm_amdgpu_ta_fw_type` to uapi

2023-09-27 Thread Mario Limonciello
Enum values used by the ioctl `AMDGPU_INFO_FW_VERSION`/`AMDGPU_INFO_FW_TA` are not exported so clients need to keep their own copy of the definitions while looking up firmware versions for the TA. Move this to uapi instead. Signed-off-by: Mario Limonciello -- v1->v2: * Rename while mov

[PATCH v2 2/2] drm/amd: Also export `AMDGPU_TA_FW_TYPE_PSP_ASD` for `AMDGPU_INFO_FW_TA`

2023-09-27 Thread Mario Limonciello
All other `drm_amdgpu_ta_fw_type` enums are exported for `AMDGPU_INFO_FW_TA`. ASD is available via `AMDGPU_INFO_FW_ASD` but for symmetry in other values export as part of `AMDGPU_INFO_FW_TA` as well. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 5 + 1 file

[PATCH] drm/amd: Move `enum drm_amdgpu_ta_fw_type` to uapi

2023-09-27 Thread Mario Limonciello
Enum values used by the ioctl `AMDGPU_INFO_FW_VERSION`/`AMDGPU_INFO_FW_TA` are not exported so clients need to keep their own copy of the definitions while looking up firmware versions for the TA. Move this to uapi instead. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amd: Limit seamless boot by default to APUs

2023-09-26 Thread Mario Limonciello
...@amd.com/T/#m2887e919d7c01b2a4860d2261b366d22e070f309 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 22c0e035de81

[Kernel-packages] [Bug 2036742] Re: amdgpu crash on Mantic

2023-09-26 Thread Mario Limonciello
Thanks for checking. So good to know it hasn't regressed from stable in 5.10. Can you redo your 5.15 test with the firmware in place so we can see if we're OK there or not? -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in

Re: [PATCH v2 4/4] drm/amd: Enable seamless boot by default on newer ASICs

2023-09-25 Thread Mario Limonciello
SDN hash can you reproduce it and then try the module parameter (amdgpu.seamless=0) to disable it and confirm things are fixed? Can I see more complete dmesg? Thanks, Feifei -Original Message- From: amd-gfx On Behalf Of Mario Limonciello Sent: Thursday, September 14, 2023 1:15 AM To:

[PATCH 8/8] drm/amd: Move microcode init from sw_init to early_init for CIK SDMA

2023-09-25 Thread Mario Limonciello
sw_init to early_init. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c index 4193289ae82f..ee5dce6f6043 100644

[PATCH 6/8] drm/amd: Move microcode init from sw_init to early_init for SDMA v3.0

2023-09-25 Thread Mario Limonciello
sw_init to early_init. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c index dc7aab68ed66..c5ea32687eb5 100644

[PATCH 4/8] drm/amd: Move microcode init from sw_init to early_init for SDMA v6.0

2023-09-25 Thread Mario Limonciello
sw_init to early_init. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c index 2c0c2e9f2783..1f8122fd1ad7 100644

[PATCH 0/8] Some cleanups related to missing microcode

2023-09-25 Thread Mario Limonciello
I recently found a noisier experience than I expected with missing microcode. As a result I found that some microcode wasn't being loaded in early_init and some messages were unnecessary. Mario Limonciello (8): drm/amd: Drop error message about failing to load DMUB firmware drm/amd: Drop

[PATCH 7/8] drm/amd: Move microcode init from sw_init to early_init for SDMA v2.4

2023-09-25 Thread Mario Limonciello
sw_init to early_init. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c index 4dd944a93cf1..b58a13bd75db 100644

[PATCH 3/8] drm/amd: Move microcode init from sw_init to early_init for SDMA v5.0

2023-09-25 Thread Mario Limonciello
sw_init to early_init. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c index 7e837acffa6e..c1ff5eda8961 100644

[PATCH 5/8] drm/amd: Move microcode init from sw_init to early_init for SDMA v5.2

2023-09-25 Thread Mario Limonciello
sw_init to early_init. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c index 86661f9653fa..7d1e57189c8c 100644

[PATCH 2/8] drm/amd: Drop error message about failing to load SDMA firmware

2023-09-25 Thread Mario Limonciello
! [drm:amdgpu_device_init [amdgpu]] *ERROR* early_init of IP block failed -19 ``` The error code for the device init is bubbled up already, remove the second one. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/cik_sdma.c| 4 +--- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 4

[PATCH 1/8] drm/amd: Drop error message about failing to load DMUB firmware

2023-09-25 Thread Mario Limonciello
[drm:amdgpu_device_init [amdgpu]] *ERROR* early_init of IP block failed -19 ``` The error code for the device init is bubbled up already, remove the second one. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers

[PATCH] drm/amd/display: Change dc_set_power_state() to bool instead of int

2023-09-25 Thread Mario Limonciello
DC code is reused by other OSes and so Linux return codes don't make sense. Change dc_set_power_state() to boolean and add a wrapper dm_set_power_state() to return a Linux error code for the memory allocation failure. Suggested-by: Harry Wentland Signed-off-by: Mario Limonciello --- drivers

Re: [PATCH] drm/amd: Propagate failures in dc_set_power_state()

2023-09-25 Thread Mario Limonciello
On 9/25/2023 12:50, Harry Wentland wrote: On 2023-09-22 16:12, Mario Limonciello wrote: During the suspend process dc_set_power_state() will use kzalloc to allocate memory, but this potentially fails with memory pressure. If it fails, the suspend should be aborted. Link: https

Re: [PATCH 13/15] platform/x86/amd/pmf: Add PMF-AMDGPU set interface

2023-09-25 Thread Mario Limonciello
level mean for the system when this framework is in place? What if a user manually changes the backlight level? Additional comments below. It's also for the display count. Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/gpu

Re: [PATCH 13/15] platform/x86/amd/pmf: Add PMF-AMDGPU set interface

2023-09-25 Thread Mario Limonciello
level mean for the system when this framework is in place? What if a user manually changes the backlight level? Additional comments below. It's also for the display count. Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/gpu

[PATCH] drm/amd: Move evict resources suspend step to prepare()

2023-09-25 Thread Mario Limonciello
into a low power state in suspend(). Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2362 Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 11 +-- 3

Re: [PATCH v2] selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut

2023-09-22 Thread Mario Limonciello
On 9/19/2023 05:33, Swapnil Sapkal wrote: In selftests/amd-pstate, tbench and gitsource microbenchmarks are used to compare the performance with different governors. In Current implementation relative path to run `amd_pstate_tracer.py` broken. Fixed this by using absolute paths. Also

Re: [PATCH 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-09-22 Thread Mario Limonciello
On 9/22/2023 14:04, Mario Limonciello wrote: On 9/22/2023 12:50, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface

Re: [PATCH 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-09-22 Thread Mario Limonciello
On 9/22/2023 14:04, Mario Limonciello wrote: On 9/22/2023 12:50, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface

[PATCH] drm/amd: Propagate failures in dc_set_power_state()

2023-09-22 Thread Mario Limonciello
During the suspend process dc_set_power_state() will use kzalloc to allocate memory, but this potentially fails with memory pressure. If it fails, the suspend should be aborted. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2362 Signed-off-by: Mario Limonciello --- Cc: harry.wentl

Re: [PATCH 15/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the Ambient light via the Ambient Light Sensor (ALS) which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K

Re: [PATCH 15/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the Ambient light via the Ambient Light Sensor (ALS) which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K

Re: [PATCH 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam

Re: [PATCH 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam

Re: [PATCH 11/15] platform/x86/amd/pmf: dump policy binary data

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: Sometimes policy binary retrieved from the BIOS maybe incorrect that can end up in failing to enable the Smart PC solution feature. Use print_hex_dump_debug() to dump the policy binary in hex, so that we debug the issues related to the binary even

Re: [PATCH 11/15] platform/x86/amd/pmf: dump policy binary data

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: Sometimes policy binary retrieved from the BIOS maybe incorrect that can end up in failing to enable the Smart PC solution feature. Use print_hex_dump_debug() to dump the policy binary in hex, so that we debug the issues related to the binary even

Re: [PATCH 04/15] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: PMF Policy binary is a encrypted and signed binary that will be part of the BIOS. PMF driver via the ACPI interface checks the existence of Smart PC bit. If the advertised bit is found, PMF driver walks the acpi namespace to find out the policy binary

Re: [PATCH 04/15] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: PMF Policy binary is a encrypted and signed binary that will be part of the BIOS. PMF driver via the ACPI interface checks the existence of Smart PC bit. If the advertised bit is found, PMF driver walks the acpi namespace to find out the policy binary

[Kernel-packages] [Bug 2036742] Re: amdgpu crash on Mantic

2023-09-22 Thread Mario Limonciello
> dmesg-ip-block-mask [6.150330] kernel: amdgpu :01:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring vce0 test failed (-110) [6.150581] kernel: [drm:amdgpu_device_ip_init [amdgpu]] *ERROR* hw_init of IP block failed -110 [6.150726] kernel: amdgpu :01:00.0: amdgpu:

[Kernel-packages] [Bug 1965303] Re: Migrate from fbdev drivers to simpledrm and DRM fbdev emulation layer

2023-09-21 Thread Mario Limonciello
The kernel part yes. The bug fix in GDM to prepare for whenever the kernel part happens I would think not. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1965303 Title: Migrate from

[Bug 1965303] Re: Migrate from fbdev drivers to simpledrm and DRM fbdev emulation layer

2023-09-21 Thread Mario Limonciello
The kernel part yes. The bug fix in GDM to prepare for whenever the kernel part happens I would think not. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gdm3 in Ubuntu. https://bugs.launchpad.net/bugs/1965303 Title: Migrate from

[Kernel-packages] [Bug 1965303] Re: Migrate from fbdev drivers to simpledrm and DRM fbdev emulation layer

2023-09-21 Thread Mario Limonciello
changes landing in OEM-6.5, or HWE-6.5. ** Changed in: gdm3 (Ubuntu Jammy) Status: Triaged => In Progress ** Changed in: gdm3 (Ubuntu Jammy) Assignee: (unassigned) => Mario Limonciello (superm1) ** Description changed: - [ Impact ] + [ Impact ] The fbdev subsystem ha

[Bug 1965303] Re: Migrate from fbdev drivers to simpledrm and DRM fbdev emulation layer

2023-09-21 Thread Mario Limonciello
changes landing in OEM-6.5, or HWE-6.5. ** Changed in: gdm3 (Ubuntu Jammy) Status: Triaged => In Progress ** Changed in: gdm3 (Ubuntu Jammy) Assignee: (unassigned) => Mario Limonciello (superm1) ** Description changed: - [ Impact ] + [ Impact ] The fbdev subsystem ha

[Kernel-packages] [Bug 2036742] Re: amdgpu crash on Mantic

2023-09-21 Thread Mario Limonciello
** Changed in: linux (Ubuntu) Status: Incomplete => Confirmed -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/2036742 Title: amdgpu crash on Mantic Status in linux package in

[Kernel-packages] [Bug 1965303] Re: Migrate from fbdev drivers to simpledrm and DRM fbdev emulation layer

2023-09-21 Thread Mario Limonciello
** Description changed: - The fbdev subsystem has been deprecated for a long time. We should drop - it in favour of using simpledrm with fbdev emulation layer. + [ Impact ] + The fbdev subsystem has been deprecated for a long time. We should drop it in favour of using simpledrm with fbdev

[Desktop-packages] [Bug 1965303] Re: Migrate from fbdev drivers to simpledrm and DRM fbdev emulation layer

2023-09-21 Thread Mario Limonciello
** Description changed: - The fbdev subsystem has been deprecated for a long time. We should drop - it in favour of using simpledrm with fbdev emulation layer. + [ Impact ] + The fbdev subsystem has been deprecated for a long time. We should drop it in favour of using simpledrm with fbdev

[Bug 1965303] Re: Migrate from fbdev drivers to simpledrm and DRM fbdev emulation layer

2023-09-21 Thread Mario Limonciello
** Description changed: - The fbdev subsystem has been deprecated for a long time. We should drop - it in favour of using simpledrm with fbdev emulation layer. + [ Impact ] + The fbdev subsystem has been deprecated for a long time. We should drop it in favour of using simpledrm with fbdev

[Kernel-packages] [Bug 1965303] Re: Migrate from fbdev drivers to simpledrm and DRM fbdev emulation layer

2023-09-21 Thread Mario Limonciello
Mantic has 45~beta-1ubuntu1 which picks up the fix for this. Jammy is still open. ** Changed in: gdm3 (Ubuntu Mantic) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.

[Desktop-packages] [Bug 1965303] Re: Migrate from fbdev drivers to simpledrm and DRM fbdev emulation layer

2023-09-21 Thread Mario Limonciello
Mantic has 45~beta-1ubuntu1 which picks up the fix for this. Jammy is still open. ** Changed in: gdm3 (Ubuntu Mantic) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gdm3 in Ubuntu.

[Bug 1965303] Re: Migrate from fbdev drivers to simpledrm and DRM fbdev emulation layer

2023-09-21 Thread Mario Limonciello
Mantic has 45~beta-1ubuntu1 which picks up the fix for this. Jammy is still open. ** Changed in: gdm3 (Ubuntu Mantic) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gdm3 in Ubuntu.

Re: [PATCH V7 0/7] amd-pstate preferred core

2023-09-20 Thread Mario Limonciello
On 9/20/2023 14:34, Oleksandr Natalenko wrote: Hello. On středa 20. září 2023 18:56:09 CEST Mario Limonciello wrote: When applied on top of v6.5.3 this breaks turbo on my 5950X after suspend/resume cycle. Please see the scenario description below. If I boot v6.5.3 + this patchset

[Kernel-packages] [Bug 2036742] Re: amdgpu crash on Mantic

2023-09-20 Thread Mario Limonciello
> [5.134271] kernel: [drm:detect_link_and_local_sink [amdgpu]] *ERROR* No > EDID read. > [5.322247] kernel: [drm:detect_link_and_local_sink [amdgpu]] *ERROR* No > EDID read. > [5.510230] kernel: [drm:detect_link_and_local_sink [amdgpu]] *ERROR* No > EDID read. Is this connected to

[Kernel-packages] [Bug 2036742] Re: amdgpu crash on Mantic

2023-09-20 Thread Mario Limonciello
> It seems related to https://bugs.launchpad.net/ubuntu/+source/linux- firmware/+bug/2029396 . I don't believe these to be related. That issue is specifically with navi3x dGPU, your system has a much older dGPU. Your 6.3 and 6.5 logs both appear to crash similarly; Do you have a point in time

Re: [PATCH V7 0/7] amd-pstate preferred core

2023-09-20 Thread Mario Limonciello
On 9/19/2023 14:01, Oleksandr Natalenko wrote: Meng Li (7): x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion. acpi: cppc: Add get the highest performance cppc control cpufreq: amd-pstate: Enable amd-pstate preferred core supporting. cpufreq: Add a notification message

Re: [PATCH] drm/mst: check connector state before dereference

2023-09-19 Thread Mario Limonciello
well, if everyone is amenable this direction I think it is worth also adding a stable tag when committed. Cc: sta...@vger.kernel.org # 6.1+ Reviewed-by: Mario Limonciello --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

Re: [PATCH V7 0/7] amd-pstate preferred core

2023-09-18 Thread Mario Limonciello
that OS is choosing the cores with highest performance firstly for scheduling the process. When amd-pstate driver receives a message with the highest performance change, it will update the core ranking. For the remaining patches missing my tag: Reviewed-by: Mario Limonciello Changes form V6->

Re: [V11 1/8] ACPI: Add support for AMD ACPI based Wifi band RFI mitigation feature

2023-09-18 Thread Mario Limonciello
On 8/31/2023 01:20, Evan Quan wrote: Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate this, AMD has

Re: [V11 1/8] ACPI: Add support for AMD ACPI based Wifi band RFI mitigation feature

2023-09-18 Thread Mario Limonciello
On 8/31/2023 01:20, Evan Quan wrote: Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate this, AMD has

Re: [PATCH 2/2] tools/power/x86/intel_pstate_tracer: Use pygnuplot package for Gnuplot

2023-09-15 Thread Mario Limonciello
On 9/15/2023 16:15, Doug Smythies wrote: On 2023.09.15 03:41 Swapnil Sapkal wrote: In intel_pstate_tracer.py, Gnuplot is used to generate 2D plots. In current implementation this tracer gives error while importing the module because Gnuplot is imported from package Gnuplot-py which does not

[Desktop-packages] [Bug 2036190] Re: fwupd running in WSL 2 in Ubuntu-22.04 fails to start

2023-09-15 Thread Mario Limonciello
I think that this should be changed in gnome software not to try to start fwupd then when in WSL2. ** Package changed: fwupd (Ubuntu) => gnome-software (Ubuntu) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-software in Ubuntu.

[Bug 2036190] Re: fwupd running in WSL 2 in Ubuntu-22.04 fails to start

2023-09-15 Thread Mario Limonciello
I think that this should be changed in gnome software not to try to start fwupd then when in WSL2. ** Package changed: fwupd (Ubuntu) => gnome-software (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-software in

[Kernel-packages] [Bug 2034103] Re: Missing firmware for AMD GPU GC 11.0.3

2023-09-14 Thread Mario Limonciello
> WARNING This is dGPU with GC 11.0.3 right? The warnings themselves you posted are harmless; they are missing backports in the 6.2 kernel. I believe they're fixed in OEM-6.1 already and as you mentioned in 6.5 kernel. > hotplug blank screen problem By hotplug you mean single display

[PATCH v2 4/4] drm/amd: Enable seamless boot by default on newer ASICs

2023-09-13 Thread Mario Limonciello
Seamless boot can technically be supported as far back as DCN1 but to avoid regressions on older hardware, enable it for DCN3 and later. If users report using the module parameter that it works on older ASICs as well, this can be adjusted. Signed-off-by: Mario Limonciello --- drivers/gpu/drm

[PATCH v2 1/4] drm/amd: Drop special case for yellow carp without discovery

2023-09-13 Thread Mario Limonciello
ove it. Signed-off-by: Mario Limonciello Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c index de7b379a9cc8..c7793db6d098 100

[PATCH v2 3/4] drm/amd: Add a module parameter for seamless boot

2023-09-13 Thread Mario Limonciello
The module parameter can be used to test more easily enabling seamless boot support on additional ASICs. Reviewed-by: Harry Wentland Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 20

[PATCH v2 0/4] Enable seamless boot more widely

2023-09-13 Thread Mario Limonciello
sily force it enabled on other ASICs too, which may be useful to adjust policy. Mario Limonciello (4): drm/amd: Drop special case for yellow carp without discovery drm/amd: Move seamless boot check out of display drm/amd: Add a module parameter for seamless boot drm/amd: Enable sea

[PATCH v2 2/4] drm/amd: Move seamless boot check out of display

2023-09-13 Thread Mario Limonciello
This will allow base driver to dictate whether seamless should be enabled. No intended functional changes. Reviewed-by: Harry Wentland Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 21

[Touch-packages] [Bug 2033967] Re: Laptop screen blinked, no tty works and 200 dmesg errors per second

2023-09-11 Thread Mario Limonciello
** Also affects: mesa (Ubuntu Mantic) Importance: Undecided Status: New ** Also affects: linux-hwe-6.2 (Ubuntu Mantic) Importance: Undecided Status: Invalid ** Also affects: mesa (Ubuntu Lunar) Importance: Undecided Status: New ** Also affects: linux-hwe-6.2

[Ubuntu-x-swat] [Bug 2033967] Re: Laptop screen blinked, no tty works and 200 dmesg errors per second

2023-09-11 Thread Mario Limonciello
** Also affects: mesa (Ubuntu Mantic) Importance: Undecided Status: New ** Also affects: linux-hwe-6.2 (Ubuntu Mantic) Importance: Undecided Status: Invalid ** Also affects: mesa (Ubuntu Lunar) Importance: Undecided Status: New ** Also affects: linux-hwe-6.2

[Kernel-packages] [Bug 2033967] Re: Laptop screen blinked, no tty works and 200 dmesg errors per second

2023-09-11 Thread Mario Limonciello
** Also affects: mesa (Ubuntu Mantic) Importance: Undecided Status: New ** Also affects: linux-hwe-6.2 (Ubuntu Mantic) Importance: Undecided Status: Invalid ** Also affects: mesa (Ubuntu Lunar) Importance: Undecided Status: New ** Also affects: linux-hwe-6.2

[Desktop-packages] [Bug 2033967] Re: Laptop screen blinked, no tty works and 200 dmesg errors per second

2023-09-11 Thread Mario Limonciello
** Also affects: mesa (Ubuntu Mantic) Importance: Undecided Status: New ** Also affects: linux-hwe-6.2 (Ubuntu Mantic) Importance: Undecided Status: Invalid ** Also affects: mesa (Ubuntu Lunar) Importance: Undecided Status: New ** Also affects: linux-hwe-6.2

Re: [V11 3/8] wifi: mac80211: Add support for WBRF features

2023-09-06 Thread Mario Limonciello
register the frequencies in use(or unregister those frequencies no longer used) via the dedicated calls. So that, other drivers responding to the frequencies can take proper actions to mitigate possible interference. Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Co-developed-by:

Re: [V11 3/8] wifi: mac80211: Add support for WBRF features

2023-09-06 Thread Mario Limonciello
register the frequencies in use(or unregister those frequencies no longer used) via the dedicated calls. So that, other drivers responding to the frequencies can take proper actions to mitigate possible interference. Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Co-developed-by:

[Kernel-packages] [Bug 2033967] Re: Laptop screen blinked, no tty works and 200 dmesg errors per second

2023-09-06 Thread Mario Limonciello
I believe this likely needs the VCN fixes from https://gitlab.freedesktop.org/mesa/mesa/-/issues/9728 backported. ** Bug watch added: gitlab.freedesktop.org/mesa/mesa/-/issues #9728 https://gitlab.freedesktop.org/mesa/mesa/-/issues/9728 ** Also affects: mesa (Ubuntu) Importance: Undecided

[Ubuntu-x-swat] [Bug 2033967] Re: Laptop screen blinked, no tty works and 200 dmesg errors per second

2023-09-06 Thread Mario Limonciello
I believe this likely needs the VCN fixes from https://gitlab.freedesktop.org/mesa/mesa/-/issues/9728 backported. ** Bug watch added: gitlab.freedesktop.org/mesa/mesa/-/issues #9728 https://gitlab.freedesktop.org/mesa/mesa/-/issues/9728 ** Also affects: mesa (Ubuntu) Importance: Undecided

<    5   6   7   8   9   10   11   12   13   14   >