Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute

2024-06-11 Thread Michael D Kinney
Hi Oliver, The DXE Core already has a policy to auto convert untested memory to tested memory if the DXE Core runs out of memory. Should we have a different memory type to allocate memory with the EFI_MEMORY_SP attribute? What would be the side effects of performing general allocations from

Re: [edk2-devel] Call for TianoCore Community Meeting topics

2024-06-05 Thread Michael D Kinney
No topics received. Meeting canceled. Mike From: Kinney, Michael D Sent: Tuesday, June 4, 2024 11:19 PM To: edk2-devel-groups-io Cc: Kinney, Michael D Subject: Call for TianoCore Community Meeting topics Hi, Are there any topics for the TianoCore community meeting this month? Thanks,

Re: [edk2-devel] GitHub PR Code Review process now active

2024-06-05 Thread Michael D Kinney
QEMU CI test > Maybe you could refer > https://github.com/slimbootloader/slimbootloader/blob/48a24b87824321c053cccf3 > 67c7c3637ff581fdf/.azurepipelines/azure-pipelines.yml#L38 to check if EDK2 > could use similar check. > > Thanks, > Guo > > -Original Message

Re: [edk2-devel] GitHub PR Code Review process now active

2024-06-05 Thread Michael D Kinney
Review process now active > > On 6/5/2024 4:21 PM, Michael D Kinney via groups.io wrote: > > * Some PRs have been merged using the "Rebase and Merge" button in the > >PR after all required reviews completed and all CI checks pass. Instead, > >the &qu

Re: [edk2-devel] GitHub PR Code Review process now active

2024-06-05 Thread Michael D Kinney
k2-devel] GitHub PR Code Review process now active > > > > Hmm, I don't see a setting for it anymore, maybe that's not a thing > anymore? > > > > I seemingly recall that draft PRs didn't get CI runs, but if that's > > not a thing anymore, then that's fine. > >

[edk2-devel] Call for TianoCore Community Meeting topics

2024-06-05 Thread Michael D Kinney
Hi, Are there any topics for the TianoCore community meeting this month? Thanks, Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119468): https://edk2.groups.io/g/devel/message/119468 Mute This Topic:

Re: [edk2-devel] GitHub PR Code Review process now active

2024-06-03 Thread Michael D Kinney
raft PRs didn't get CI runs, but if that's > not a thing anymore, then that's fine. > > That said, draft PRs cannot be reviewed, so we should not be telling > people to make draft PRs. > > > On Mon, Jun 3, 2024 at 12:26 PM Michael D Kinney via groups.io > > wrote: > >

Re: [edk2-devel] GitHub PR Code Review process now active

2024-06-03 Thread Michael D Kinney
> -Original Message- > From: Neal Gompa > Sent: Monday, June 3, 2024 9:13 AM > To: devel@edk2.groups.io; Kinney, Michael D > Subject: Re: [edk2-devel] GitHub PR Code Review process now active > > On Tue, May 28, 2024 at 2:53 PM Michael D Kinney via groups.io &g

Re: [edk2-devel] GitHub PR Code Review process now active

2024-05-30 Thread Michael D Kinney
; > > >> Mike, > > >> > > >> I agree that automatically adding reviewers would be helpful. > > >> > > >> Do you think we could add a CODEOWNERS file now to assist with this? > > >> > > >> Benefits being: > &g

Re: [edk2-devel] GitHub PR Code Review process now active

2024-05-30 Thread Michael D Kinney
t; >> > >> 1. CODEOWNERS is low overhead in that GitHub already supports it. > >> > >> 2. We do not need to require CODEOWNER enforcement yet. We can simply > >> use it for automating the process of adding maintainers. > >> > >> 3. Maintai

Re: [edk2-devel] GitHub PR Code Review process now active

2024-05-30 Thread Michael D Kinney
All Maintainer.txt rules are matches and all maintainers/reviewers are combined CODEOWNERS only matches the last rule. I do not think your suggestion works. Mike > -Original Message- > From: kra...@redhat.com > Sent: Thursday, May 30, 2024 1:33 AM > To: Kinney, Michael D > Cc:

Re: [edk2-devel] libspdm Breaking Builds

2024-05-29 Thread Michael D Kinney
Hi Pete, https://github.com/tianocore/edk2/pull/5697 was merged and should resolve your issue. Please let us know if it does not. Mike > -Original Message- > From: Pete Batard > Sent: Wednesday, May 29, 2024 3:01 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > Yao, Jiewen ;

Re: [edk2-devel] GitHub PR Code Review process now active

2024-05-29 Thread Michael D Kinney
e and add > the push label. This would add a relevant maintainer(s) with write > access to fulfill that role. > > Thanks, > Michael > > On 5/29/2024 2:27 PM, Michael D Kinney wrote: > > GitHub has notification settings. Maintainers should configure > > GitHub s

Re: [edk2-devel] libspdm Breaking Builds

2024-05-29 Thread Michael D Kinney
Hi Pete, I just tested this config command and it works when cryptomilk is down. git config --global url."https://github.com/tianocore/edk2-cmocka.git".insteadOf "https://git.cryptomilk.org/projects/cmocka.git; I updated edk2-cmocka mirror last week. I tested this with git clone

Re: [edk2-devel] libspdm Breaking Builds

2024-05-29 Thread Michael D Kinney
Hi Pete, There is another option for developers and CI agents. Git supports a URL insteadof option to redirect git requests. https://git-scm.com/docs/git-config#Documentation/git-config.txt-urlltbasegtinsteadOf We can use this to redirect a request from cryptomilk cmocka to the TianoCore

Re: [edk2-devel] GitHub PR Code Review process now active

2024-05-29 Thread Michael D Kinney
> > On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote: > > Hi Gerd, > > > > We can clarify the Wiki. A Maintainer has to be involved in every > > code review. The first action a Maintainer does is verify that the > > code change should be co

Re: [edk2-devel] GitHub PR Code Review process now active

2024-05-29 Thread Michael D Kinney
cess now active > > On Wed, May 29, 2024 at 03:00:13PM GMT, Michael D Kinney wrote: > > Hi Gerd, > > > > You are in the EDK II Reviewers team. > > > > The current settings only allow members of the EDK II Maintainers > > team to assign reviewers. > > T

Re: [edk2-devel] GitHub PR Code Review process now active

2024-05-29 Thread Michael D Kinney
Hi Gerd, You are in the EDK II Reviewers team. The current settings only allow members of the EDK II Maintainers team to assign reviewers. The maintainers of the OvmfPkg are required to add all reviewers to the PR. I have added niruiyu,ajfish to keep this PR moving while we continue the

Re: [edk2-devel] GitHub PR Code Review process now active

2024-05-29 Thread Michael D Kinney
und there is another email thread "Enable > GitHub PR, protected branches, and 'push' label" on edk2-platforms, but no > further discussions then. > > Thanks > Abner > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Michael D > &g

[edk2-devel] GitHub PR Code Review process now active

2024-05-28 Thread Michael D Kinney
Hello, The GitHub PR code review process is now active. Please use the new PR based code review process for all new submissions starting today. * The Wiki has been updated with the process changes. https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Big

Re: [edk2-devel] PR Process Wiki Updates

2024-05-28 Thread Michael D Kinney
Hi Michael, Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Kinney, Michael D > Sent: Thursday, May 23, 2024 1:55 PM > To: Michael Kubacki ; devel@edk2.groups.io; > r...@edk2.groups.io > Cc: quic_llind...@quicinc.com; af...@apple.com; Kinney, Michael

Re: [edk2-devel] PR Process Wiki Updates

2024-05-23 Thread Michael D Kinney
Hi Michael, These updates look good. Can you provide a brief overview/summary of the process changes in email to make sure there are no misunderstandings from the details in the wiki page updates. Thanks, Mike > -Original Message- > From: Michael Kubacki > Sent: Monday, May 20, 2024

Re: [edk2-devel] [edk2-platforms][PATCH 3/3] edk2-platform/Maintainer: Add entries for AMD packages

2024-05-23 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: abner.ch...@amd.com > Sent: Wednesday, May 22, 2024 9:12 PM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Kinney, Michael D > > Subject: [edk2-platforms][PATCH 3/3] edk2-platform/Maintainer: Add entri

Re: [edk2-devel] libspdm Breaking Builds

2024-05-22 Thread Michael D Kinney
>> To: devel@edk2.groups.io; Kinney, Michael D ; > >> Yao, Jiewen > >> Subject: Re: [edk2-devel] libspdm Breaking Builds > >> > >> I don't think that's a very good solution given the diversity of > >> downstream projects dependent on the repo or even fo

Re: [edk2-devel] libspdm Breaking Builds

2024-05-22 Thread Michael D Kinney
r even for the libspdm repo > itself. > > Thanks, > Michael > > On 5/22/2024 5:57 PM, Michael D Kinney wrote: > > This was discussed and the decision was made to no use recursive clone on > libspdm. > > > > Mike > > > >> -Original Me

Re: [edk2-devel] libspdm Breaking Builds

2024-05-22 Thread Michael D Kinney
This was discussed and the decision was made to no use recursive clone on libspdm. Mike > -Original Message- > From: Michael Kubacki > Sent: Wednesday, May 22, 2024 1:40 PM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Kinney, Michael D > Subject: libspdm Breaking Builds > >

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-20 Thread Michael D Kinney
> >> the CLI version. > >> > >> Thanks, > >> Michael > >> > >> On 5/17/2024 7:20 PM, Michael Kubacki wrote: > >>> To ensure CI is unblocked, I am going to add the push tag now. > >>> > >>> On 5/17/2024 6:31 PM, Mi

Re: [edk2-devel] [PATCH] MdePkg:Update UEFI version to 2.10

2024-05-20 Thread Michael D Kinney
Have you verified that every feature from 2.10 is in edk2? That includes both the include file content as well as all the Library/module implementations. A platform can always update this version value in their tables if the platform is using a subset of features that are all 2.10 conformant.

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-17 Thread Michael D Kinney
t; > Thanks, > Michael > > On 5/17/2024 7:20 PM, Michael Kubacki wrote: > > To ensure CI is unblocked, I am going to add the push tag now. > > > > On 5/17/2024 6:31 PM, Michael Kubacki wrote: > >> Thanks Mike. Are you okay with me completing

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-17 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, May 17, 2024 2:09 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Joey Vagedes > ; Liming Gao ; Kinney, > Michael D ; Rebecca Cran ; > Sean Brogan ; Chen

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-15 Thread Michael D Kinney
apple.com) > >>> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code > >>> Review from email to GitHub Pull Requests on 5-24-2024 > >>> > >>> On Wed, May 1, 2024 at 6:44 PM Michael D Kinney via groups.io > >>>

Re: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

2024-05-14 Thread Michael D Kinney
: devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> 代表 gaoliming via groups.io 发送时间: 2024年5月7日 9:25 收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; annou...@edk2.groups.io<mailto:annou...@edk2.groups.io> 抄送: 'Michael D Kinney' mailto:mi

Re: [edk2-devel][edk2-stable202405][PATCH] MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount

2024-05-14 Thread Michael D Kinney
I agree it should catch edk2-stable202405 Mike > -Original Message- > From: gaoliming > Sent: Thursday, May 9, 2024 12:24 AM > To: devel@edk2.groups.io; Pakkirisamy, ShanmugavelX > > Cc: Liu, Zhiguang ; Bi, Dandan ; > 'Leif Lindholm' ; 'Andrew Fish' ; > Kinney, Michael D > Subject:

Re: [edk2-devel] [PATCH v2] MdePkg: Add MmUnblockMemoryLib to MdeLibs.dsc

2024-05-07 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Wu, Jiaxin > Sent: Monday, May 6, 2024 9:55 PM > To: Zhang, Hongbin1 ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Ni, Ray > ; Liming Gao ; Liu, Zhiguang > ; Xie, Yuanhao > Subject: RE

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-06 Thread Michael D Kinney
Hi Ard, Thais is an attribute of Mergify. I do not see a way to change that behavior. I do not know if using the GitHub merge capability or other merge services provides different behavior here or not. This specific request is not related to the change to GitHub PRs for code review. There is

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-06 Thread Michael D Kinney
That information is in GitHub in the PR conversation. If you follow the link from the commit to the PR, the PR conversation shows who set the 'push' label. Mike > -Original Message- > From: r...@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Monday, May 6, 2024 3:01 AM > To:

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-03 Thread Michael D Kinney
l D > > > > > > Cc: r...@edk2.groups.io; Leif Lindholm ; Andrew > > Fish > > > > (af...@apple.com) > > > > Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore > > Code > > > > Review from email to GitHub Pull Requests

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-03 Thread Michael D Kinney
> Sent: Thursday, May 2, 2024 10:51 AM > > > To: devel@edk2.groups.io; Kinney, Michael D > > > > Cc: r...@edk2.groups.io; Leif Lindholm ; Andrew > Fish > > > (af...@apple.com) > > > Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore >

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-03 Thread Michael D Kinney
ocess changes needed? > > For example, could we start with CODEOWNERS manually synced to > Maintainers.txt, Maintainers.txt dropped, and then add REVIEWERS in the > future with additional actions to verify file coverage, etc.? > > Thanks, > Michael > > On 5/2/2024 12:24

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-02 Thread Michael D Kinney
[edk2-devel] Proposal to switch TianoCore Code > Review from email to GitHub Pull Requests on 5-24-2024 > > On Wed, May 1, 2024 at 6:44 PM Michael D Kinney via groups.io > wrote: > > > > Hello, > > > > I would like to propose that TianoCore move all code review

Re: [edk2-devel] Call or topics for May TianoCore Community Meeting

2024-05-02 Thread Michael D Kinney
zone). > > Thanks, > Oliver > > On 5/1/2024 9:45 AM, Michael D Kinney wrote: > > Please let me know if you have any topics for the TianoCore Community > > Meeting this month. > > > > Thanks, > > > > Mike > > > > > > > >

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

2024-05-02 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Jayaprakash, N > Sent: Wednesday, April 24, 2024 11:14 AM > To: devel@edk2.groups.io; Jayaprakash, N ; > Kinney, Michael D > Cc: Rebecca Cran > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] e

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-02 Thread Michael D Kinney
> -Original Message- > From: Leif Lindholm > Sent: Thursday, May 2, 2024 3:57 AM > To: devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, Michael > D ; r...@edk2.groups.io > Cc: Andrew Fish (af...@apple.com) > Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-02 Thread Michael D Kinney
ew Fish (af...@apple.com) > Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code > Review from email to GitHub Pull Requests on 5-24-2024 > > On 5/1/24 18:19, Dionna Glaze via groups.io wrote: > > On Wed, May 1, 2024 at 11:12 AM Leif Lindholm via groups.io > >

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-02 Thread Michael D Kinney
anoCore Code Review from > email to GitHub Pull Requests on 5-24-2024 > > On 5/2/2024 6:34 AM, Leif Lindholm wrote: > > On 2024-05-02 07:33, Marcin Juszkiewicz wrote: > >> W dniu 1.05.2024 o 19:43, Michael D Kinney via groups.io pisze: > >>> I would like to propose

[edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-01 Thread Michael D Kinney
Hello, I would like to propose that TianoCore move all code review from email based code reviews to GitHub Pull Requests based code reviews. The proposed date to switch would be immediately after the next stable tag which is currently scheduled for May 24, 2024. Updates to the following Wiki

[edk2-devel] Call or topics for May TianoCore Community Meeting

2024-05-01 Thread Michael D Kinney
Please let me know if you have any topics for the TianoCore Community Meeting this month. Thanks, Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118467): https://edk2.groups.io/g/devel/message/118467 Mute This Topic:

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Update my email address

2024-04-29 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Anthony > PERARD via groups.io > Sent: Monday, April 29, 2024 9:06 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Anthony PERARD > Subject:

Re: [edk2-devel] [PATCH v4 00/10] Add DeviceSecurity feature based on PFP 1.06 spec

2024-04-28 Thread Michael D Kinney
No objections. For all patches related to adding libspdm submodule: Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Yao, Jiewen > Sent: Sunday, April 28, 2024 5:33 PM > To: Hou, Wenxing ; devel@edk2.groups.io; Andrew > Fish ; Leif Lindholm ; >

Re: [edk2-devel] [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load driver in confidential guests

2024-04-24 Thread Michael D Kinney
Hi Jiewen, Michael Kubacki has been working on a CI issue and a change is being merged now. Mike > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, April 24, 2024 3:57 PM > To: devel@edk2.groups.io; Kinney, Michael D > ; Sean Brogan > Cc: Gerd Hoffmann ; Ard Biesheuvel ; >

Re: [edk2-devel] [PATCH v1 1/1] Update to CodeQL 2.16.1

2024-04-24 Thread Michael D Kinney
t; > For changes between the previous version (2.14.5) and 2.16.1 see: > > > > https://github.com/github/codeql-cli- > binaries/compare/v2.14.5...v2.16.1 > > > > Cc: Bob Feng > > Cc: Joey Vagedes > > Cc: Liming Gao > > Cc: Michael D Kinney &

Re: [edk2-devel] [PATCH edk2-non-osi 1/1] Maintainers.txt: add maintainers for SbsaQemu platform

2024-04-24 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Leif Lindholm > Sent: Tuesday, April 23, 2024 7:40 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Kinney, Michael D > ; Marcin Juszkiewicz > > Subject: [PATCH edk2-non-osi 1/1] Maintain

Re: [edk2-devel] [PATCH v1 1/1] Update to CodeQL 2.16.1

2024-04-24 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, April 24, 2024 10:37 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Joey Vagedes > ; Liming Gao ; Kinney, > Michael D ; Rebecca Cran > ; Sean Br

Re: [edk2-devel] [edk2-libc Patch v3 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected

2024-04-19 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Jayaprakash, N > Sent: Friday, April 19, 2024 2:01 AM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D > Subject: [edk2-libc Patch v3 1/1] ek2-libc: wrmsr function avai

Re: [edk2-devel] [PATCH V3 6/6] Maintainers.txt: Update maintainer for SPI modules

2024-04-19 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Friday, April 19, 2024 12:40 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Andrew Fish > ; Leif Lindholm ; Attar, > A

Re: [edk2-devel] [edk2-libc Patch 2 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected

2024-04-18 Thread Michael D Kinney
> bits > its value will be set to 0. Because of this the higher 32 bits of the > MSR > are always set to 0. This has been fixed by this commit. > > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Jayaprakash N > --- > .../Python/Pyt

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

2024-04-17 Thread Michael D Kinney
read/write cpu specific msrs > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746 > > > > The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr > > APIs supported in edk2 module. These extension APIs makes it > possible > > to read /

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

2024-04-17 Thread Michael D Kinney
t; The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr > APIs supported in edk2 module. These extension APIs makes it possible > to read / write MSRs from specific processors and fills an existing > gap in this area. > > Cc: Rebecca Cran > Cc: Michael D Kinney

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: wrmsr function available in edk2module is not working as expected

2024-04-17 Thread Michael D Kinney
64)vedx) << 32) | veax; > Verified the function by making this change and could see that the > wrmsr is working as expected. > > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Jayaprakash N > --- > .../Python/Python-3.6.8/PyMod-3.6.8/Modul

Re: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI according to UEFI spec

2024-04-16 Thread Michael D Kinney
POLUDOV, FELIX ; Liu, Liqi > ; Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe: > Update UI according to UEFI spec > > Acked-by: Michael D Kinney > > > > -Original Message- > > From: devel@edk2.groups.io

Re: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI according to UEFI spec

2024-04-15 Thread Michael D Kinney
Acked-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Clark- > williams, Zachary > Sent: Wednesday, April 10, 2024 9:03 AM > To: Tan, Ming ; devel@edk2.groups.io > Cc: Kasbekar, Saloni ; Bi, Dandan > ; POLUDOV, FELIX ; Liu,

Re: [edk2-devel] [PATCH 0/9] Add DeviceSecurity feature based on PFP 1.06 spec

2024-04-09 Thread Michael D Kinney
tps://trustedcomputinggroup.org/resource/pc-client-specific- > platform-firmware-profile-specification/ > > The POC branch: > https://github.com/tianocore/edk2-staging/tree/DeviceSecurity > > And the PATCH set has passed the EDKII CI: > https://github.com/tianocore/edk2/pull/550

Re: [edk2-devel] Call or topics for April TianoCore Community Meeting

2024-04-03 Thread Michael D Kinney
] Mike > -Original Message- > From: Oliver Smith-Denny > Sent: Wednesday, April 3, 2024 3:02 PM > To: devel@edk2.groups.io; Kinney, Michael D > ; Ard Biesheuvel > Subject: Re: [edk2-devel] Call or topics for April TianoCore Community > Meeting > > On 4/3/202

Re: [edk2-devel] Call or topics for April TianoCore Community Meeting

2024-04-03 Thread Michael D Kinney
uld be PRs and lack of maintainer response, the proper > process there, etc. > > Thanks, > Oliver > > On 4/2/2024 5:12 PM, Michael D Kinney wrote: > > Please let me know if you have any topics for the TianoCore > Co

Re: [edk2-devel] Call or topics for April TianoCore Community Meeting

2024-04-03 Thread Michael D Kinney
No topics received. Meeting canceled this month. Mike > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, April 2, 2024 5:12 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: Call or topics for April TianoCore Community Meeting > > Please let me know if you

Re: [edk2-devel] [Question] using Flexible Array Member in Structure.

2024-04-03 Thread Michael D Kinney
Yes. Use of flexible array members is supported and encouraged. There are challenges with existing structure definitions that declare arrays of size [1] when a flexible array is really intended. Those were defined before flexible array members were supported by all the compilers. Converting

[edk2-devel] Call or topics for April TianoCore Community Meeting

2024-04-02 Thread Michael D Kinney
Please let me know if you have any topics for the TianoCore Community Meeting this month. Thanks, Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117339): https://edk2.groups.io/g/devel/message/117339 Mute This Topic:

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Maintainers.txt: Update maintainers for Marvell platforms

2024-04-02 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Leif Lindholm > Sent: Tuesday, April 2, 2024 8:40 AM > To: devel@edk2.groups.io > Cc: Marcin Wojtas ; Narinder Dhillon > ; Kinney, Michael D > Subject: [PATCH edk2-platforms 1/1] Maintainers.tx

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

2024-03-29 Thread Michael D Kinney
There are also utilities to partition and format. https://www.intel.com/content/www/us/en/download/714351/uefi-shell-disk-utilities.html Mike From: devel@edk2.groups.io On Behalf Of Andrew Fish via groups.io Sent: Friday, March 29, 2024 3:11 PM To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH v3 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

2024-03-29 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/5505 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Oliver > Smith-Denny > Sent: Friday, March 29, 2024 1:21 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Leif Lindholm > ; Ard Biesheuvel ; > Sami Mujawar ; Taylor Beebe >

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

2024-03-29 Thread Michael D Kinney
y, Michael D ; > Ard Biesheuvel > Cc: Liming Gao ; Ni, Ray ; Leif > Lindholm ; Sami Mujawar ; > Taylor Beebe > Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: > ImagePropertiesRecordLib Fixes > > Thanks Mike! > > Oliver > > On 3/29/2024 10:12 AM, Michael D K

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

2024-03-29 Thread Michael D Kinney
Hi Ard, I have reviewed the discussion on the V1 and V2 versions of the series. For the V2 Series: Acked-by: Michael D Kinney I will add the Rb/Ab tags and get this merged. Mike > -Original Message- > From: Ard Biesheuvel > Sent: Friday, March 29, 2024 1:03 AM > To

Re: [edk2-devel] [PATCH] MdePkg: Add PciVenNameLib to get vendor name.

2024-03-15 Thread Michael D Kinney
ing given the Pci vendor ID > values. > > Signed-off-by: Simon Wang > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > --- > MdePkg/Include/Library/PciVenNameLib.h| 27 + > MdePkg/Library/PciVenNameLib/PciVenNameLib.c | 2394 > + &

Re: [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData function description

2024-03-12 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/5463 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Qingyu > Sent: Sunday, February 25, 2024 7:06 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData > function description >

Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-03-12 Thread Michael D Kinney
wed-by. So for now, for the series: > Acked-by: Leif Lindholm > > > [1] https://edk2.groups.io/g/devel/message/111566 > > > > Cc: Ard Biesheuvel > > Cc: Gerd Hoffmann > > Cc: Jiewen Yao > > Cc: Leif Lindholm > > Cc: Liming Gao > > Cc: Micha

Re: [edk2-devel] EDK II CI issues installing choco dependencies - RESOLVED

2024-03-11 Thread Michael D Kinney
This issue appears to be resolved Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney > Sent: Sunday, March 10, 2024 12:16 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: [edk2-devel] EDK II CI issues installi

[edk2-devel] EDK II CI issues installing choco dependencies

2024-03-10 Thread Michael D Kinney
I am seeing some EDK II CI failures installing choco dependencies on windows CI agents. Here is an example: https://github.com/tianocore/edk2/pull/5454

Re: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

2024-03-09 Thread Michael D Kinney
der to > determine the size of the buffer needed". > > Modify the description of "EFI_INVALID_PARAMETER" return code as "The > ImageInfoSize is not too small and Image is NULL." and add new > descriptions for "EFI_INVALID_PARAMETER" return code. >

Re: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

2024-03-09 Thread Michael D Kinney
and add new > descriptions for "EFI_INVALID_PARAMETER" return code. > > REF: UEFI spec v2.10 23.1.2 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4660 > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Yi Li > Cc: GuoX Xu >

Re: [edk2-devel] [PATCH] NetworkPkg Update Security Patch

2024-03-08 Thread Michael D Kinney
b81-aea3-d574ed7b6a91 Please update patches to address all these failures and resend to mailing list. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney > Sent: Friday, March 8, 2024 1:12 PM > To: Kasbekar, Saloni ; Santhosh Kuma

Re: [edk2-devel] [PATCH] NetworkPkg Update Security Patch

2024-03-08 Thread Michael D Kinney
Acked-by: Michael D Kinney > -Original Message- > From: Kasbekar, Saloni > Sent: Wednesday, February 7, 2024 2:58 PM > To: Santhosh Kumar V ; devel@edk2.groups.io > Cc: Sivaraman Nainar ; Raj V Akilan > ; Kinney, Michael D ; > Mathews, John ; Clark-williams, Zac

Re: [edk2-devel] Topics for March TianoCore Community Meeting

2024-03-06 Thread Michael D Kinney
Meeting canceled this month. No agenda topics received. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney > Sent: Tuesday, March 5, 2024 11:08 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: [edk2-devel] Topic

Re: [edk2-devel] [PATCH v2 07/10] EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl

2024-03-06 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Wednesday, March 6, 2024 1:10 PM > To: edk2-devel-groups-io > Cc: Andrew Fish ; Ni, Ray > Subject: Re: [edk2-devel] [PATCH v2 07/10] EmulatorPkg

Re: [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl

2024-03-06 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Wednesday, March 6, 2024 1:10 PM > To: edk2-devel-groups-io > Cc: Desimone, Nathaniel L ; Chaganty, > Rangasai V > Subject: Re: [edk2-devel] [e

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

2024-03-06 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Wednesday, March 6, 2024 1:06 PM > To: edk2-devel-groups-io > Cc: Andrew Fish ; Ard Biesheuvel > ; Gerd Hoffmann ; Yao, > Jiewen ; Leif Lindho

Re: [edk2-devel] [PATCH v2 01/10] pip-requirements.txt: require edk2-basetools version 0.1.51

2024-03-06 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, March 6, 2024 1:09 PM > To: edk2-devel-groups-io > Cc: Feng, Bob C ; Joey Vagedes > ; Liming Gao ; > Kinney, Michael D ; Rebecca Cran > ; Sean Brogan ; Chen, > Chri

[edk2-devel] Topics for March TianoCore Community Meeting

2024-03-05 Thread Michael D Kinney
Please let me know if you have any topics for the TianoCore Community Meeting this month. Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116424): https://edk2.groups.io/g/devel/message/116424 Mute This Topic:

Re: [edk2-devel] [PATCH v2 1/1] .github/workflows/codeql.yml: Update actions being deprecated

2024-03-01 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, March 1, 2024 3:33 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Joey Vagedes > ; Kinney, Michael D > > Subject: [PATCH v2 1/1] .github/workflows/co

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/DxeCore: Fix stack overflow issue due to nested interrupts

2024-02-29 Thread Michael D Kinney
I think one advantage of this new proposal is to prevent an extra level of nesting and use of stack resources in that extra level. The nesting depth is then both predictable and minimized for a given set of supported TPL levels. Mike > -Original Message- > From: Michael Brown > Sent:

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/DxeCore: Fix stack overflow issue due to nested interrupts

2024-02-29 Thread Michael D Kinney
> -Original Message- > From: Paolo Bonzini > Sent: Thursday, February 29, 2024 11:04 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Laszlo Ersek ; Michael > Brown > Subject: Re: [PATCH 2/2] MdeModulePkg/DxeCore: Fix stack overflow issue > due to nested

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/DxeCore: Fix stack overflow issue due to nested interrupts

2024-02-29 Thread Michael D Kinney
> -Original Message- > From: Michael Brown > Sent: Thursday, February 29, 2024 9:39 AM > To: Kinney, Michael D ; > devel@edk2.groups.io; Ni, Ray > Cc: Liming Gao ; Laszlo Ersek > ; Paolo Bonzini > Subject: Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/DxeCore: Fix stack > overflow issue due

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/DxeCore: Fix stack overflow issue due to nested interrupts

2024-02-29 Thread Michael D Kinney
Hi Paolo, The proposed change does not disable interrupts at TPL below TPL_HIGH_LEVEL when processing event handlers. It only prevents interrupts being enabled in the window from the last event processed in a timer interrupt and the return from the timer interrupt handler. This is a window

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/DxeCore: Fix stack overflow issue due to nested interrupts

2024-02-29 Thread Michael D Kinney
Hi Michael, Can you provide a pointer to the UEFI Spec statement this breaks? Thanks, Mike > -Original Message- > From: Michael Brown > Sent: Thursday, February 29, 2024 5:23 AM > To: devel@edk2.groups.io; Ni, Ray > Cc: Kinney, Michael D ; Liming Gao > ; Laszlo Ersek ; Paolo >

Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

2024-02-27 Thread Michael D Kinney
higuang > ; Oliver Smith-Denny > ; Pop, Aaron > Subject: Re: [edk2-devel] [Patch v2 1/3] > MdePkg/Include/IndustryStandard: Add Operator and Xor field names > > On Tue, Feb 27, 2024 at 11:46 PM Michael D Kinney > wrote: > > > > Hi Pedro, > > > > L

Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

2024-02-27 Thread Michael D Kinney
e- > > > > From: Pedro Falcato > > > > Sent: Wednesday, May 31, 2023 11:17 AM > > > > To: Kinney, Michael D > > > > Cc: devel@edk2.groups.io; Gao, Liming ; > Liu, > > > > Zhiguang ; Oliver Smith-Denny > > > &g

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql.yml: Update actions being deprecated

2024-02-26 Thread Michael D Kinney
> referring to the codeql-action/upload-sarif action which is at v2. > > This change updates all of the actions to the latest releases to > prevent deprecated versions from continuing to be used. > > Cc: Sean Brogan > Cc: Joey Vagedes > Cc: Michael D Kinney > Signed-o

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

2024-02-23 Thread Michael D Kinney
Since this is not a standard PCI visible to PCI Bus Driver, did you consider using MdeModulePkg\Universal\SerialDxe that produces a Serial I/O Protocol from a SerialPortLib instance? That was SerialPortLib can be used for DEBUG() logging and the Serial I/O Protocol produced by SerialDxe can be

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

2024-02-21 Thread Michael D Kinney
DXE env is not UEFI conformant. UEFI Drivers can not be executed until the UEFI env is fully established which is at end of DXE after all DXE Arch Protocols are produced and DXE Core supports the full set of requires UEFI services. Running a UEFI Driver or UEFI Application before all DXE Arch

Re: [edk2-devel] Merge commit in edk2-non-osi

2024-02-21 Thread Michael D Kinney
Thanks for the reminder. "Require Linear History" was not set in edk2-non-osi. It is now. Mike > -Original Message- > From: Marcin Juszkiewicz > Sent: Wednesday, February 21, 2024 12:58 AM > To: devel@edk2.groups.io; Desimone, Nathaniel L > > Cc: Kinney, Michael D > Subject: Re:

Re: [edk2-devel] Merge commit in edk2-non-osi

2024-02-21 Thread Michael D Kinney
Hi Ard, I disagree. We have never allowed a force push to the main branch of TianoCore repos. This has happened before and was discussed and the policy is to not fix. Even the edk2 repo has some merge commits in its history that were discussed and not fixed. We can never know how many

  1   2   3   4   5   6   7   8   9   10   >