[openib-general] [PATCH 2.6.21-rc1 5/5] ehca: query_port() returns LINK_UP instead UNKNOWN

2007-02-15 Thread Hoang-Nam Nguyen
set port phys state as a result of ehca_query_port() to LINK_UP. On pSeries ehca actually represents a logical HCA, whose phys/link state always is LINK_UP. Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_hca.c |3 +++ 1 files changed, 3 insertions(+) diff --git a/drivers

Re: [openib-general] 32-bit build for ppc64 is required

2007-02-15 Thread Hoang-Nam Nguyen
Yuk. I suppose I could write one, but I don't (and can't) use any of the OFED supplied build scripts in our build system, so it's hard for me to test since our build system is the only way I have to access ppc/ppc64 hardware. Oh, well. Other takers? OK, I've no choice to say no. Haven't

Re: [openib-general] [PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-15 Thread Hoang-Nam Nguyen
Hi, So I'm holding off on applying this for now. Please think it over and either tell me the current patch is OK, or fix it up. There's not really too much urgency because a change like this is something I would be comfortable merging between 2.6.21-rc1 and -rc2. You're absolutely right.

[PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-15 Thread Hoang-Nam Nguyen
This patch will add two sysfs attributes to /sys/bus/ibmebus which can be used to notify the ebus driver of added / removed ebus devices in the OF device tree. Echoing the device's location code (as found in the OFDT ibm,loc-code property) into the probe attribute will notify ebus of addition of

Re: [PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-15 Thread Hoang-Nam Nguyen
Looks fine but this patch at least has serious whitespace damage... please resend a fixed version. Sorry for this. Resending the patches 1-5. Nam - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-15 Thread Hoang-Nam Nguyen
reworked irq handler to avoid/reduce missed irq events Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 18 +++- ehca_eq.c |1 ehca_irq.c | 214 +++-- ehca_irq.h |1 ehca_main.c| 28

[PATCH 2.6.21-rc1 2/5] ehca: fix race condition/locking issues in scaling code

2007-02-15 Thread Hoang-Nam Nguyen
fix a race condition in find_next_cpu_online() and some other locking issues in scaling code Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c | 68 + 1 files changed, 33 insertions(+), 35 deletions(-) diff --git

[PATCH 2.6.21-rc1 3/5] ehca: allow en/disabling scaling code via module parameter

2007-02-15 Thread Hoang-Nam Nguyen
allow users to en/disable scaling code when loading ib_ehca module Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- Kconfig|8 ehca_classes.h |1 + ehca_irq.c | 47 +-- ehca_main.c|4 4 files changed

[PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-15 Thread Hoang-Nam Nguyen
remove yield() and use wait_for_completion() in order to wait for running completion handlers finished before destroying associated completion queue Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h |3 +++ ehca_cq.c |5 +++-- ehca_irq.c |6 +- 3

[PATCH 2.6.21-rc1 5/5] ehca: query_port() returns LINK_UP instead UNKNOWN

2007-02-15 Thread Hoang-Nam Nguyen
set port phys state as a result of ehca_query_port() to LINK_UP. On pSeries ehca actually represents a logical HCA, whose phys/link state always is LINK_UP. Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_hca.c |3 +++ 1 files changed, 3 insertions(+) diff --git a/drivers

Re: [PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-15 Thread Hoang-Nam Nguyen
Hi, So I'm holding off on applying this for now. Please think it over and either tell me the current patch is OK, or fix it up. There's not really too much urgency because a change like this is something I would be comfortable merging between 2.6.21-rc1 and -rc2. You're absolutely right.

[PATCH 2.6.21-rc1 5/5] ehca: query_port() returns LINK_UP instead UNKNOWN

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch sets port phys state as a result of ehca_query_port() to LINK_UP. On pSeries ehca actually represents a logical HCA, whose phys/link state always is LINK_UP. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_hca.c |3 +++ 1 files changed, 3 inse

[PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch removes yield() and uses wait_for_completion() in order to wait for running completion handlers finished before destroying associated completion queue. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h |3 +++ ehca_cq.c

[PATCH 2.6.21-rc1 3/5] ehca: allow en/disabling scaling code via module parameter

2007-02-14 Thread Hoang-Nam Nguyen
Hi, here is a patch for ehca that allows users to en/disable scaling code when loading ib_ehca module. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- Kconfig|8 ehca_classes.h |1 + ehca_irq.c

[PATCH 2.6.21-rc1 2/5] ehca: fix race condition/locking issues in scaling code

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch fixes a race condition in find_next_cpu_online() and some other locking issues in scaling code. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_irq.c | 68 + 1 files changed, 33 inse

[PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-14 Thread Hoang-Nam Nguyen
Hi, here is a patch for ehca with the reworked irq handler. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h | 18 +++-- ehca_eq.c |1 ehca_irq.c | 200 - ehca_irq.h

[PATCH 2.6.21-rc1 0/5] ehca patch set for 2.6.21-rc1

2007-02-14 Thread Hoang-Nam Nguyen
Hello Roland! Here is a patch set for ehca with the following changes resp. bug fixes: * Reworked irq handler to avoid/reduce missed irq events * Fix race condition bug in find_next_online_cpu() and other potential locking issue of scaling code * Allow scaling code to be configurable

[openib-general] [PATCH 2.6.21-rc1 0/5] ehca patch set for 2.6.21-rc1

2007-02-14 Thread Hoang-Nam Nguyen
Hello Roland! Here is a patch set for ehca with the following changes resp. bug fixes: * Reworked irq handler to avoid/reduce missed irq events * Fix race condition bug in find_next_online_cpu() and other potential locking issue of scaling code * Allow scaling code to be configurable

[openib-general] [PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-14 Thread Hoang-Nam Nguyen
Hi, here is a patch for ehca with the reworked irq handler. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 18 +++-- ehca_eq.c |1 ehca_irq.c | 200 - ehca_irq.h |1

[openib-general] [PATCH 2.6.21-rc1 2/5] ehca: fix race condition/locking issues in scaling code

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch fixes a race condition in find_next_cpu_online() and some other locking issues in scaling code. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c | 68 + 1 files changed, 33 insertions

[openib-general] [PATCH 2.6.21-rc1 3/5] ehca: allow en/disabling scaling code via module parameter

2007-02-14 Thread Hoang-Nam Nguyen
Hi, here is a patch for ehca that allows users to en/disable scaling code when loading ib_ehca module. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- Kconfig|8 ehca_classes.h |1 + ehca_irq.c | 47

[openib-general] [PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch removes yield() and uses wait_for_completion() in order to wait for running completion handlers finished before destroying associated completion queue. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h |3 +++ ehca_cq.c |3

[openib-general] [PATCH 2.6.21-rc1 5/5] ehca: query_port() returns LINK_UP instead UNKNOWN

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch sets port phys state as a result of ehca_query_port() to LINK_UP. On pSeries ehca actually represents a logical HCA, whose phys/link state always is LINK_UP. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_hca.c |3 +++ 1 files changed, 3 insertions

Re: [openib-general] 32-bit build for ppc64 is required

2007-02-14 Thread Hoang-Nam Nguyen
Hi, Well, this is not by design: AFAIK on x86_64 both types of libraries are installed. So, it seems to be an issue with the build script. Will talk to Vlad. But I still do not see how installing 32 bit binaries alongside the 64 bit ones is useful, and I do not think other packages provide

Re: [openib-general] 32-bit build for ppc64 is required

2007-02-14 Thread Hoang-Nam Nguyen
Hi Vlad, prefix/lib (32bit libraries) should be created on ppc64 as well. Check that you have sysfsutils 32bit RPM installed. I don't have ppc64 here to check. The current ofed-1.2 package does not, while ofed-1.1.1 has done. It looks like that the one fix we did for ofed-1.1.1 were away. If I

Re: [openib-general] 32-bit build for ppc64 is required

2007-02-14 Thread Hoang-Nam Nguyen
Hi, Still, using non-standard hacks like bin32 does not sound like a good idea. I think the actual issue is there is no common approach for this on various platforms. Maybe an option to *only* make 32 bit userspace might make sense though. Something like --disable-32bit, --disable-64bit. This

Re: [openib-general] 32-bit build for ppc64 is required

2007-02-14 Thread Hoang-Nam Nguyen
So, what you suggest is - build 2 types of libraries, but on PPC make binaries 32 bit? That's easy - do others agree to this approach? No, for execs please create 32bit and 64bit on PPC. Another option is to build binaries with whatever type of binary gcc without extra flags generates by

[PATCH 2.6.21-rc1 0/5] ehca patch set for 2.6.21-rc1

2007-02-14 Thread Hoang-Nam Nguyen
Hello Roland! Here is a patch set for ehca with the following changes resp. bug fixes: * Reworked irq handler to avoid/reduce missed irq events * Fix race condition bug in find_next_online_cpu() and other potential locking issue of scaling code * Allow scaling code to be configurable

[PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-14 Thread Hoang-Nam Nguyen
Hi, here is a patch for ehca with the reworked irq handler. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 18 +++-- ehca_eq.c |1 ehca_irq.c | 200 - ehca_irq.h |1

[PATCH 2.6.21-rc1 2/5] ehca: fix race condition/locking issues in scaling code

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch fixes a race condition in find_next_cpu_online() and some other locking issues in scaling code. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c | 68 + 1 files changed, 33 insertions

[PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch removes yield() and uses wait_for_completion() in order to wait for running completion handlers finished before destroying associated completion queue. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h |3 +++ ehca_cq.c |3

[PATCH 2.6.21-rc1 3/5] ehca: allow en/disabling scaling code via module parameter

2007-02-14 Thread Hoang-Nam Nguyen
Hi, here is a patch for ehca that allows users to en/disable scaling code when loading ib_ehca module. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- Kconfig|8 ehca_classes.h |1 + ehca_irq.c | 47

[PATCH 2.6.21-rc1 5/5] ehca: query_port() returns LINK_UP instead UNKNOWN

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch sets port phys state as a result of ehca_query_port() to LINK_UP. On pSeries ehca actually represents a logical HCA, whose phys/link state always is LINK_UP. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_hca.c |3 +++ 1 files changed, 3 insertions

Re: [openib-general] [PATCH ofed-1.2] libehca: fix build error with disable-libcheck option

2007-02-08 Thread Hoang-Nam Nguyen
This patch fix libehca build errors if disable-libcheck option is choosen. Applied ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit

Re: [openib-general] RFC ofed 1 2 kernel file structure

2007-02-07 Thread Hoang-Nam Nguyen
I could clone it: Should be I could not clone it ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Re: [openib-general] RFC ofed 1 2 kernel file structure

2007-02-07 Thread Hoang-Nam Nguyen
Hi Michael, Repost. Could everyone please look at git://git.openfabrics.org/~mst/newofed.git and tell me whether this looks acceptable? I could clone it: $git clone git://git.openfabrics.org/~mst/newofed.git fatal: Unable to look up git.openfabrics.org (Temporary failure in name resolution)

Re: [openib-general] [openfabrics-ewg] Minutes for January 29, 2007 teleconference about OFED 1.2 release integration and build procedures

2007-01-31 Thread Hoang-Nam Nguyen
Hi, 3. Each git maintainer: open ofed_1_2 branch till Feb 1. created branch ofed_1_2 for libehca. Regards Nam ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit

Re: [openib-general] [openfabrics-ewg] [PATCH ofed-1.2 0/6] ehca (kernel space) patches for ofed-1.2

2007-01-30 Thread Hoang-Nam Nguyen
Can someone from iser group please check this? On pseries hvcall.h is placed under include/asm which is a link to include/asm-ppc resp include/asm-powerpc. I don't think that we did anything with this in iSER. Erez Erez, thanks for this info. Vladimir, please remove include/linux/hvcall.h

[openib-general] [PATCH ofed-1.2 alpha rel] ehca: reworked irq handler to support NAPI consistently

2007-01-30 Thread Hoang-Nam Nguyen
: Roland, this patch is aligned with ofed-1.2 only. I'l send this patch for 2.6.21 separately next week. Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 18 +++-- ehca_eq.c |1 ehca_irq.c | 202

Re: [openib-general] OFED 1.2 release - to be reviewed in the meeting today

2007-01-29 Thread Hoang-Nam Nguyen
Hi, This looks pretty similar to ofed-1.1/SVN release procedure. What about discussed idea of per package release by maintainers? I guess there's no conflict: maintainers can make ofed_1_2 point to their release. But I agree we need maintainers' buy-in and commitment to schedule that

Re: [openib-general] [openfabrics-ewg] [PATCH ofed-1.2 0/6] ehca (kernel space) patches for ofed-1.2

2007-01-29 Thread Hoang-Nam Nguyen
[EMAIL PROTECTED] wrote on 27.01.2007 17:11:34: PS2: For backport on 2.6.16 resp. SLES10 I saw that there is a hvcall.h under backport/2.6.16/include/linux. However that one is not sufficient for ehca and include/linux is the wrong place. Hence, I'm patching a new one under include/asm. If

Re: [openib-general] [openfabrics-ewg] [PATCH ofed1.2 2/2] libehca: change path to ehca.driver for make dist

2007-01-29 Thread Hoang-Nam Nguyen
applied both patches ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Re: [openib-general] [Patch ofed1.2 0/3]libehca: cleanup and adjust mmap

2007-01-28 Thread Hoang-Nam Nguyen
This 3 patches changes the libehca coding style to kernel coding and kernel tracing style.The userspace mmap code needs to be adjusted to the changed userspace mapping introduced in kernel patch [PATCH/RFC 2.6.21 0/5] ehca: remove use of do_mmap() from kernel space. Note that ofed 1.2 has

Re: [openib-general] [openfabrics-ewg] modules compilation status for OFED 1.2

2007-01-27 Thread Hoang-Nam Nguyen
Hi Michael! I need to be more specific here: ibmebus requires two symbols in arch/ppc64/kernel/dma.c to be exported, which means one really needs to rebuild and install the patched kernel. As far as I understood from Michael, when we looked at ofed-1.1, that approach is not supported by

[openib-general] [PATCH ofed-1.2 0/6] ehca (kernel space) patches for ofed-1.2

2007-01-26 Thread Hoang-Nam Nguyen
Hello Vladimir! Here is a patch set for ehca device driver with the following changes: * Fix yield with spinlock held (this has been queued for 2.6.20) * Fix mismatched unlock in irq handler (this has been queued for 2.6.20) * Remove mmap (this has been queued for 2.6.21) * Remove obsolete

[openib-general] [PATCH ofed-1.2 1/6] ehca: fix yield with spinlock held and mismatched unlock

2007-01-26 Thread Hoang-Nam Nguyen
ehca_cq.c: fix yield with spinlock held ehca_irq.c: fix mismatched unlock Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_cq.c |5 - ehca_irq.c |3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff -Nurp ofed_1_2_jan26/drivers/infiniband/hw/ehca/ehca_cq.c

[openib-general] [PATCH ofed-1.2 2/6] ehca: remove do_mmap and obsolete prototypes

2007-01-26 Thread Hoang-Nam Nguyen
Remove do_mmap and obsolete prototypes Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 29 +--- ehca_cq.c | 65 ++--- ehca_iverbs.h | 10 - ehca_main.c|8 - ehca_qp.c | 78 ++- ehca_uverbs.c | 395

[openib-general] [PATCH ofed-1.2 3/6] ehca: backport 2.6.16

2007-01-26 Thread Hoang-Nam Nguyen
backport hvcall for 2.6.16 Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- hvcall.h | 142 +++ 1 files changed, 142 insertions(+) diff -Nurp ofed_1_2_jan26/kernel_addons/backport/2.6.16/include/asm/hvcall.h ofed_1_2_nam

[openib-general] [PATCH ofed-1.2 4/6] ehca: backport sles10

2007-01-26 Thread Hoang-Nam Nguyen
backport hvcall for sles10 Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- hvcall.h | 142 +++ 1 files changed, 142 insertions(+) diff -Nurp ofed_1_2_jan26/kernel_addons/backport/2.6.16_sles10/include/asm/hvcall.h

[openib-general] [PATCH ofed-1.2 5/6] ehca: backport 2.6.18

2007-01-26 Thread Hoang-Nam Nguyen
backport hvcall for 2.6.18 Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- hvcall.h | 32 1 files changed, 32 insertions(+) diff -Nurp ofed_1_2_jan26/kernel_addons/backport/2.6.18/include/asm/hvcall.h ofed_1_2_nam/kernel_addons/backport/2.6.18

Re: [openib-general] [openfabrics-ewg] modules compilation status for OFED 1.2

2007-01-24 Thread Hoang-Nam Nguyen
Hi Tziporet! ehca driver (Nam) - SLES9, Redhat EL4 up4, SLES10 SP1, 2.6.19 Backport for SLES9 and RHEL4.4/5 is doable only with a kernel patch in order to get ibmebus running, which is a prereq for ehca. Since ofed-1.1 build process compiles the components out of kernel tree, such one kernel

Re: [openib-general] [openfabrics-ewg] modules compilation status for OFED 1.2

2007-01-24 Thread Hoang-Nam Nguyen
Hi, We stay with same build process but the backport patches give a solution for such cases. Michael Tsirkin can help you how we solved such problems with other kernel code we needed. I need to be more specific here: ibmebus requires two symbols in arch/ppc64/kernel/dma.c to be exported, which

[PATCH 2.6.21 4/4] ehca: remove obsolete prototypes

2007-01-23 Thread Hoang-Nam Nguyen
Here is a patch for ehca_classes.h that removes obsolete prototypes. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h | 14 -- 1 files changed, 14 deletions(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_cla

[PATCH 2.6.21 3/4] ehca: remove do_mmap()

2007-01-23 Thread Hoang-Nam Nguyen
-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_classes.h | 15 +- ehca_cq.c | 65 ++--- ehca_iverbs.h |8 - ehca_main.c|6 ehca_qp.c | 78 ++- ehca_uverbs.c | 395 +++-- 6 files changed, 204 insertions(+

[PATCH 2.6.21 1/4] ehca: fix improper use of yield with spinlock held

2007-01-23 Thread Hoang-Nam Nguyen
Here is a patch for ehca_cq.c that fixes improper use of yield with spinlock held. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_cq.c |5 - 1 files changed, 4 insertions(+), 1 deletion(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehc

[PATCH 2.6.21 2/4] ehca: fix mismatched use of spin_unlock in irq handler

2007-01-23 Thread Hoang-Nam Nguyen
Here is a patch for ehca_irq.c that fixes mismatched use of spin_unlock in irq handler. Thanks Nam Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_irq.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca

[PATCH 2.6.21 0/4] ehca: remove do_mmap() and some bug fixes

2007-01-23 Thread Hoang-Nam Nguyen
Hello Roland! Here is a patch set for ehca as a result of previous disscussions and comments: 1. fix improper use of yield within spinlock context 2. fix mismatched use of spin_unlock in irq handler 3. remove do_mmap() 4. remove obsolete prototypes PS: I've sent the first two recently for 2.6.20,

[openib-general] [PATCH 2.6.21 0/4] ehca: remove do_mmap() and some bug fixes

2007-01-23 Thread Hoang-Nam Nguyen
Hello Roland! Here is a patch set for ehca as a result of previous disscussions and comments: 1. fix improper use of yield within spinlock context 2. fix mismatched use of spin_unlock in irq handler 3. remove do_mmap() 4. remove obsolete prototypes PS: I've sent the first two recently for 2.6.20,

[openib-general] [PATCH 2.6.21 1/4] ehca: fix improper use of yield with spinlock held

2007-01-23 Thread Hoang-Nam Nguyen
Here is a patch for ehca_cq.c that fixes improper use of yield with spinlock held. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_cq.c |5 - 1 files changed, 4 insertions(+), 1 deletion(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_cq.c

[openib-general] [PATCH 2.6.21 2/4] ehca: fix mismatched use of spin_unlock in irq handler

2007-01-23 Thread Hoang-Nam Nguyen
Here is a patch for ehca_irq.c that fixes mismatched use of spin_unlock in irq handler. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_irq.c

[openib-general] [PATCH 2.6.21 3/4] ehca: remove do_mmap()

2007-01-23 Thread Hoang-Nam Nguyen
-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 15 +- ehca_cq.c | 65 ++--- ehca_iverbs.h |8 - ehca_main.c|6 ehca_qp.c | 78 ++- ehca_uverbs.c | 395 +++-- 6 files changed, 204 insertions(+), 363

[PATCH 2.6.21 0/4] ehca: remove do_mmap() and some bug fixes

2007-01-23 Thread Hoang-Nam Nguyen
Hello Roland! Here is a patch set for ehca as a result of previous disscussions and comments: 1. fix improper use of yield within spinlock context 2. fix mismatched use of spin_unlock in irq handler 3. remove do_mmap() 4. remove obsolete prototypes PS: I've sent the first two recently for 2.6.20,

[PATCH 2.6.21 1/4] ehca: fix improper use of yield with spinlock held

2007-01-23 Thread Hoang-Nam Nguyen
Here is a patch for ehca_cq.c that fixes improper use of yield with spinlock held. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_cq.c |5 - 1 files changed, 4 insertions(+), 1 deletion(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_cq.c

[PATCH 2.6.21 2/4] ehca: fix mismatched use of spin_unlock in irq handler

2007-01-23 Thread Hoang-Nam Nguyen
Here is a patch for ehca_irq.c that fixes mismatched use of spin_unlock in irq handler. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_irq.c

[PATCH 2.6.21 3/4] ehca: remove do_mmap()

2007-01-23 Thread Hoang-Nam Nguyen
-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 15 +- ehca_cq.c | 65 ++--- ehca_iverbs.h |8 - ehca_main.c|6 ehca_qp.c | 78 ++- ehca_uverbs.c | 395 +++-- 6 files changed, 204 insertions(+), 363

[PATCH 2.6.21 4/4] ehca: remove obsolete prototypes

2007-01-23 Thread Hoang-Nam Nguyen
Here is a patch for ehca_classes.h that removes obsolete prototypes. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 14 -- 1 files changed, 14 deletions(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_classes.h infiniband_work

Re: [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

2007-01-22 Thread Hoang-Nam Nguyen
> I think the right thing to do is restructure this function so you > don't have lines starting 6 tab stops to the right. Yes. Have reworked this irq handler and still struggling with testing. When we feel comfortable with the test result, we'll post it here (soon) and hopefully it is easier to

Re: [openib-general] [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

2007-01-22 Thread Hoang-Nam Nguyen
I think the right thing to do is restructure this function so you don't have lines starting 6 tab stops to the right. Yes. Have reworked this irq handler and still struggling with testing. When we feel comfortable with the test result, we'll post it here (soon) and hopefully it is easier to

Re: [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

2007-01-22 Thread Hoang-Nam Nguyen
I think the right thing to do is restructure this function so you don't have lines starting 6 tab stops to the right. Yes. Have reworked this irq handler and still struggling with testing. When we feel comfortable with the test result, we'll post it here (soon) and hopefully it is easier to

Re: [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

2007-01-20 Thread Hoang-Nam Nguyen
hmm, code line too long. please ignore the previous patch. here is the one with correct length of code line. Thanks Nam This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock in irq handler. Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_irq.c |4 +

Re: [openib-general] [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

2007-01-20 Thread Hoang-Nam Nguyen
hmm, code line too long. please ignore the previous patch. here is the one with correct length of code line. Thanks Nam This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock in irq handler. Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c |4 +++- 1

Re: [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

2007-01-20 Thread Hoang-Nam Nguyen
hmm, code line too long. please ignore the previous patch. here is the one with correct length of code line. Thanks Nam This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock in irq handler. Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c |4 +++- 1

[PATCH 2.6.20 0/2] ehca: fix yield and spinlock conflicts

2007-01-19 Thread Hoang-Nam Nguyen
Hello Roland! Here is patch set for ehca with the following bug fixes: * Fix unproper use of yield within spinlock context * Fix mismatched spin_unlock in irq handler Thanks Nam ehca_cq.c |5 - ehca_irq.c |2 +- 2 files changed, 5 insertions(+), 2 deletions(-) - To unsubscribe from

[PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

2007-01-19 Thread Hoang-Nam Nguyen
Hello Roland! This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock in irq handler. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_irq.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ehca/ehca_ir

[PATCH 2.6.20 1/2] ehca: ehca_cq.c: fix unproper use of yield within spinlock context

2007-01-19 Thread Hoang-Nam Nguyen
Hello Roland! This is a patch for ehca_cq.c that fixes unproper use of yield within spinlock context. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_cq.c |5 - 1 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ehca/ehc

Re: [openib-general] [PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

2007-01-19 Thread Hoang-Nam Nguyen
[EMAIL PROTECTED] wrote on 18.01.2007 16:26:58: qpnum is actually only required from poll cq if srq is supported. so ehca can just fill in NULL. actually the IB spec requires QPN in the work completion if either SRQ or base queue management extensions are supported. I'm not sure why

[openib-general] [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

2007-01-19 Thread Hoang-Nam Nguyen
Hello Roland! This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock in irq handler. Thanks Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b

[openib-general] [PATCH 2.6.20 1/2] ehca: ehca_cq.c: fix unproper use of yield within spinlock context

2007-01-19 Thread Hoang-Nam Nguyen
Hello Roland! This is a patch for ehca_cq.c that fixes unproper use of yield within spinlock context. Thanks Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_cq.c |5 - 1 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ehca/ehca_cq.c b

[PATCH 2.6.20 1/2] ehca: ehca_cq.c: fix unproper use of yield within spinlock context

2007-01-19 Thread Hoang-Nam Nguyen
Hello Roland! This is a patch for ehca_cq.c that fixes unproper use of yield within spinlock context. Thanks Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_cq.c |5 - 1 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ehca/ehca_cq.c b

[PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

2007-01-19 Thread Hoang-Nam Nguyen
Hello Roland! This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock in irq handler. Thanks Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b

[PATCH 2.6.20 0/2] ehca: fix yield and spinlock conflicts

2007-01-19 Thread Hoang-Nam Nguyen
Hello Roland! Here is patch set for ehca with the following bug fixes: * Fix unproper use of yield within spinlock context * Fix mismatched spin_unlock in irq handler Thanks Nam ehca_cq.c |5 - ehca_irq.c |2 +- 2 files changed, 5 insertions(+), 2 deletions(-) - To unsubscribe from

Re: [PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

2007-01-18 Thread Hoang-Nam Nguyen
No problem. Will resend the full patch set for 2.6.21. Thanks Nam [EMAIL PROTECTED] wrote on 18.01.2007 13:56:01: > I've kind of lost the plot here. How does this patch fit in with the > previous series of patches you posted? Does it replace them or go on > top of them? > > Can please you

Re: [openib-general] [PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

2007-01-18 Thread Hoang-Nam Nguyen
No problem. Will resend the full patch set for 2.6.21. Thanks Nam [EMAIL PROTECTED] wrote on 18.01.2007 13:56:01: I've kind of lost the plot here. How does this patch fit in with the previous series of patches you posted? Does it replace them or go on top of them? Can please you resend me

Re: [PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

2007-01-18 Thread Hoang-Nam Nguyen
No problem. Will resend the full patch set for 2.6.21. Thanks Nam [EMAIL PROTECTED] wrote on 18.01.2007 13:56:01: I've kind of lost the plot here. How does this patch fit in with the previous series of patches you posted? Does it replace them or go on top of them? Can please you resend me

[PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

2007-01-17 Thread Hoang-Nam Nguyen
nd another patch. Thanks! Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_uverbs.c | 266 +++--- 1 file changed, 146 insertions(+), 120 deletions(-) diff -Nurp infiniband/drivers/infiniband/hw/ehca/ehca_uverbs.c infinib

[openib-general] [PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

2007-01-17 Thread Hoang-Nam Nguyen
. Thanks! Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_uverbs.c | 266 +++--- 1 file changed, 146 insertions(+), 120 deletions(-) diff -Nurp infiniband/drivers/infiniband/hw/ehca/ehca_uverbs.c infiniband_work/drivers

[PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

2007-01-17 Thread Hoang-Nam Nguyen
. Thanks! Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_uverbs.c | 266 +++--- 1 file changed, 146 insertions(+), 120 deletions(-) diff -Nurp infiniband/drivers/infiniband/hw/ehca/ehca_uverbs.c infiniband_work/drivers

Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

2007-01-12 Thread Hoang-Nam Nguyen
Hi, > > + if (my_cq->ownpid != cur_pid) { > > + ehca_err(device, "Invalid caller pid=%x ownpid=%x " > > +"cq_num=%x", > > +cur_pid, my_cq->ownpid, my_cq->cq_number); > > + return -EINVAL; > > +

Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

2007-01-12 Thread Hoang-Nam Nguyen
n of yield issue this patch also fixes an unproper use of spin_unlock() in ehca_irq.c. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_cq.c |5 - ehca_irq.c |4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff -Nurp infiniband_orig/drivers/infiniband/h

Re: [openib-general] [openfabrics-ewg] Reminder: OFED 1.2 coordination meeting next Monday at 9am PST

2007-01-12 Thread Hoang-Nam Nguyen
Hello Tziporet and others from ofed board! I wish to know if and how ehca could transition from preview tech to production state for ofed 1.2, especially what do we need to accomplish in order to achieve that. If you could point me to a written procedure for that, it would be great. Thanks! Nam

Re: [openib-general] [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

2007-01-12 Thread Hoang-Nam Nguyen
() in ehca_irq.c. Thanks Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_cq.c |5 - ehca_irq.c |4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_cq.c infiniband_work/drivers/infiniband/hw/ehca/ehca_cq.c

Re: [openib-general] [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

2007-01-12 Thread Hoang-Nam Nguyen
Hi, + if (my_cq-ownpid != cur_pid) { + ehca_err(device, Invalid caller pid=%x ownpid=%x +cq_num=%x, +cur_pid, my_cq-ownpid, my_cq-cq_number); + return -EINVAL; + } (for

Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

2007-01-12 Thread Hoang-Nam Nguyen
() in ehca_irq.c. Thanks Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_cq.c |5 - ehca_irq.c |4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_cq.c infiniband_work/drivers/infiniband/hw/ehca/ehca_cq.c

Re: [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

2007-01-12 Thread Hoang-Nam Nguyen
Hi, + if (my_cq-ownpid != cur_pid) { + ehca_err(device, Invalid caller pid=%x ownpid=%x +cq_num=%x, +cur_pid, my_cq-ownpid, my_cq-cq_number); + return -EINVAL; + } (for

[PATCH/RFC 2.6.21 5/5] ehca: ehca_main.c: version numbering

2007-01-11 Thread Hoang-Nam Nguyen
Hello Roland! This is a patch for ehca_main.c. It mainly updates ehca version appropriately. Also the abi_version is increased in order to distinguish this from earlier releases. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_main.c |6 +++--- 1 files chan

[PATCH/RFC 2.6.21 4/5] ehca: queue pair: remove use of do_mmap()

2007-01-11 Thread Hoang-Nam Nguyen
Hello Roland and Christoph H.! This is a patch for ehca_qp.c. It removes all direct calls of do_mmap()/munmap() when creating and destroying a queue pair respectively. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_qp.c

[PATCH/RFC 2.6.21 2/5] ehca: ehca_uverbs.c: "proper" use of mmap

2007-01-11 Thread Hoang-Nam Nguyen
- The actual mmap() call/trigger is now controlled by user space, ie. libehca, for which I will send a separate patch for later review This patch also removes superfluous resp. obsolete functions. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_uverbs.c

[PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

2007-01-11 Thread Hoang-Nam Nguyen
Hello Roland and Christoph H.! This is a patch for ehca_cq.c. It removes all direct calls of do_mmap()/munmap() when creating and destroying a completion queue respectively. Thanks Nam Signed-off-by Hoang-Nam Nguyen <[EMAIL PROTECTED]> --- ehca_cq.c

[PATCH/RFC 2.6.21 1/5] ehca: declaration of queue structures

2007-01-11 Thread Hoang-Nam Nguyen
Hello Roland and Christoph H.! This is a patch for ehca structs. It enhances completion queue and queue pair with use counters for associated mmap-ed resources, ie. hardware register block and queue pages. Furthermore it removes redundant prototypes. Thanks Nam Signed-off-by Hoang-Nam Nguyen

[PATCH/RFC 2.6.21 0/5] ehca: remove use of do_mmap() from kernel space

2007-01-11 Thread Hoang-Nam Nguyen
Hello Roland and Christoph H.! Here is a set of patches for ehca, whose main purpose is to remove unproper use of do_mmap() in ehca kernel space as suggested by Christoph H. Other "small" changes are: * Remove "dead" prototype declarations (those without code implementation) Now detail on

<    6   7   8   9   10   11   12   >