ftynse wrote:
> 10 separate commits/PRs for the same exact sed costs more in commit noise
> (and effort on the part of @e-kwsm) than one solid, patient, review here
Not unless you subscribe only to a subproject. FWIW, I'm not comfortable
blanket approving changes, however trivial, to
https://github.com/ftynse approved this pull request.
LGTM for the MLIR part. Please seek approval from relevant reviewers for all
other subprojects.
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
ftynse wrote:
This should be included in the actual commit, not GitHub comments.
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ftynse wrote:
Please provide a proper patch description, i.e., why the change is being made.
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/ftynse closed https://github.com/llvm/llvm-project/pull/79626
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ftynse wrote:
Looks like whatever Windows container it runs on is missing a numpy
installation. Not correlated with this patch in any way.
https://github.com/llvm/llvm-project/pull/79626
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/ftynse approved this pull request.
https://github.com/llvm/llvm-project/pull/79626
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ftynse approved this pull request.
https://github.com/llvm/llvm-project/pull/65583
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
