owenca wrote:
Please add unit tests in `clang/unittests/Format/`.
https://github.com/llvm/llvm-project/pull/69859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/69897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/69897
Fixes #69237.
>From 69e39f7e19e7f2538df0b8c6ba89d5efa493dd7b Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 22 Oct 2023 23:15:08 -0700
Subject: [PATCH] [clang-format] Don't alter SpacesRequiredBefore of
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/69814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3191,20 +3198,150 @@ TEST_F(FormatTestComments, DontAlignNamespaceComments)
{
"}\n"
"// Comment";
-#if 0
- // FIXME: The following comment is aligned with the namespace comment.
verifyFormat("namespace A {\n"
" int Foo;\n"
@@ -1118,16 +1121,48 @@ void WhitespaceManager::alignTrailingComments() {
}
}
-// We don't want to align namespace end comments.
-const bool DontAlignThisComment =
-I > 0 && C.NewlinesBefore == 0 &&
-Changes[I -
@@ -5118,10 +5118,6 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine
,
return true;
if (Left.IsUnterminatedLiteral)
return true;
- if (Right.is(tok::lessless) && Right.Next && Left.is(tok::string_literal) &&
owenca wrote:
No, it still
Author: Owen Pan
Date: 2023-10-22T13:46:32-07:00
New Revision: 3e86cc4b864f609720c12cc97ff70a20aabb956f
URL:
https://github.com/llvm/llvm-project/commit/3e86cc4b864f609720c12cc97ff70a20aabb956f
DIFF:
https://github.com/llvm/llvm-project/commit/3e86cc4b864f609720c12cc97ff70a20aabb956f.diff
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/69871
Fixes #44363.
>From fc955bc2730b52093d1e6d2bdd2dbf0400879edf Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 22 Oct 2023 01:36:17 -0700
Subject: [PATCH] [clang-format] Don't break between string literal
@@ -1118,16 +1121,48 @@ void WhitespaceManager::alignTrailingComments() {
}
}
-// We don't want to align namespace end comments.
-const bool DontAlignThisComment =
-I > 0 && C.NewlinesBefore == 0 &&
-Changes[I -
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/69814
>From 78a2661ba7a18ecf8b09be71f6959fbc9fcf70fe Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 20 Oct 2023 23:01:38 -0700
Subject: [PATCH 1/2] [clang-format] Add a new style for the clang-format
source code
owenca wrote:
Yep. Each file will contain only `BasedOnStyle: clang-format`.
https://github.com/llvm/llvm-project/pull/69814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
I was wondering myself. Will undo it before merging.
https://github.com/llvm/llvm-project/pull/69814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
> What is your goal with that style?
It was actually your [idea](https://reviews.llvm.org/D153208#4431239).
https://github.com/llvm/llvm-project/pull/69814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
owenca wrote:
I don't want to "advertise" this new style in the documentation but am willing
to be overruled by the majority.
https://github.com/llvm/llvm-project/pull/69814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/69814
None
>From 78a2661ba7a18ecf8b09be71f6959fbc9fcf70fe Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 20 Oct 2023 23:01:38 -0700
Subject: [PATCH] [clang-format] Add a new style for the clang-format source
code
=?utf-8?q?Bj=C3=B6rn_Sch=C3=A4pers?=
Message-ID:
In-Reply-To:
@@ -3102,7 +3102,9 @@ TEST_F(FormatTestComments, DontAlignNamespaceComments) {
StringRef Input = "namespace A {\n"
" TESTSUITE(B) {\n"
"namespace C {\n"
-
=?utf-8?q?Björn_Schäpers?=
Message-ID:
In-Reply-To:
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/68743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Bj=C3=B6rn_Sch=C3=A4pers?=
Message-ID:
In-Reply-To:
@@ -1118,16 +1121,39 @@ void WhitespaceManager::alignTrailingComments() {
}
}
-// We don't want to align namespace end comments.
-const bool DontAlignThisComment =
-I > 0 &&
=?utf-8?q?Björn_Schäpers?=
Message-ID:
In-Reply-To:
@@ -1118,16 +1121,39 @@ void WhitespaceManager::alignTrailingComments() {
}
}
-// We don't want to align namespace end comments.
-const bool DontAlignThisComment =
-I > 0 && C.NewlinesBefore == 0
=?utf-8?q?Bj=C3=B6rn_Sch=C3=A4pers?=
Message-ID:
In-Reply-To:
@@ -1118,16 +1121,39 @@ void WhitespaceManager::alignTrailingComments() {
}
}
-// We don't want to align namespace end comments.
-const bool DontAlignThisComment =
-I > 0 &&
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/69228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/69473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/69707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Omar Ahmed
Date: 2023-10-20T03:16:28-07:00
New Revision: 7c15dd60ec4549f53f1a51c5302c61f8a025a4a5
URL:
https://github.com/llvm/llvm-project/commit/7c15dd60ec4549f53f1a51c5302c61f8a025a4a5
DIFF:
https://github.com/llvm/llvm-project/commit/7c15dd60ec4549f53f1a51c5302c61f8a025a4a5.diff
@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool
ExpectClassBody) {
SmallVector LBraceStack;
assert(Tok->is(tok::l_brace));
do {
-// Get next non-comment token.
-FormatToken *NextTok;
-do {
- NextTok = Tokens->getNextToken();
-
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool
ExpectClassBody) {
SmallVector LBraceStack;
assert(Tok->is(tok::l_brace));
do {
-// Get next non-comment token.
-FormatToken *NextTok;
-do {
- NextTok = Tokens->getNextToken();
-
owenca wrote:
@mydeveloperday what do you think?
https://github.com/llvm/llvm-project/pull/69228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
> Here's my solution to one of the regressions I caused (#68404)
I don't think it's a regression. On the contrary, it actually exposed another
bug. :)
https://github.com/llvm/llvm-project/pull/69473
___
cfe-commits mailing list
@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool
ExpectClassBody) {
SmallVector LBraceStack;
assert(Tok->is(tok::l_brace));
do {
-// Get next non-comment token.
-FormatToken *NextTok;
-do {
- NextTok = Tokens->getNextToken();
-
Author: Owen Pan
Date: 2023-10-19T13:38:49-07:00
New Revision: b2f50b49a8c45305d27f0393ee6248e3e8851788
URL:
https://github.com/llvm/llvm-project/commit/b2f50b49a8c45305d27f0393ee6248e3e8851788
DIFF:
https://github.com/llvm/llvm-project/commit/b2f50b49a8c45305d27f0393ee6248e3e8851788.diff
Author: Owen Pan
Date: 2023-10-18T17:37:41-07:00
New Revision: 2172eeaa52bec211b255e9cb4d8464a8908ff709
URL:
https://github.com/llvm/llvm-project/commit/2172eeaa52bec211b255e9cb4d8464a8908ff709
DIFF:
https://github.com/llvm/llvm-project/commit/2172eeaa52bec211b255e9cb4d8464a8908ff709.diff
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/69249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1118,16 +1121,35 @@ void WhitespaceManager::alignTrailingComments() {
}
}
-// We don't want to align namespace end comments.
-const bool DontAlignThisComment =
-I > 0 && C.NewlinesBefore == 0 &&
-Changes[I -
@@ -3191,20 +3191,146 @@ TEST_F(FormatTestComments, DontAlignNamespaceComments)
{
"}\n"
"// Comment";
-#if 0
- // FIXME: The following comment is aligned with the namespace comment.
verifyFormat("namespace A {\n"
" int Foo;\n"
@@ -3497,6 +3497,15 @@ void
TokenAnnotator::calculateFormattingInformation(AnnotatedLine ) const {
Tok->setType(TT_TrailingReturnArrow);
break;
}
+if (Tok->isNot(TT_TrailingAnnotation))
owenca wrote:
Before: look for _any_
owenca wrote:
@HazardyKnusperkeks any other concerns?
https://github.com/llvm/llvm-project/pull/69249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
> This allows git-clang-format to be used on a Windows terminal without
> manually needing to find the path and invoke the python interpreter. We have
> a similar script for `scan-build`.
Can you open an issue and link to it from here? It seems `git clang-format`
works in
owenca wrote:
See #69249.
https://github.com/llvm/llvm-project/pull/67780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/69249
>From 25e0a84bd254969fb6930001f6203d4dc56f9871 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 16 Oct 2023 13:38:09 -0700
Subject: [PATCH 1/2] [clang-format] Fix a bug in annotating
TrailingReturnArrow
Skip
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3497,6 +3497,15 @@ void
TokenAnnotator::calculateFormattingInformation(AnnotatedLine ) const {
Tok->setType(TT_TrailingReturnArrow);
break;
}
+if (Tok->isNot(TT_TrailingAnnotation))
owenca wrote:
Because
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/69249
Skip TrailingAnnotation when looking for TrailingReturnArrow.
Fixes #69234.
>From 25e0a84bd254969fb6930001f6203d4dc56f9871 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 16 Oct 2023 13:38:09 -0700
Subject:
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/69052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2268,6 +2265,12 @@ bool UnwrappedLineParser::tryToParseLambda() {
parseRequiresClause(RequiresToken);
break;
}
+case tok::equal:
+ if (InTemplateParameterList) {
+nextToken();
+break;
+ }
+ return true;
@@ -2268,6 +2265,12 @@ bool UnwrappedLineParser::tryToParseLambda() {
parseRequiresClause(RequiresToken);
break;
}
+case tok::equal:
+ if (InTemplateParameterList) {
+nextToken();
+break;
+ }
+ return true;
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/69052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3191,20 +3191,120 @@ TEST_F(FormatTestComments, DontAlignNamespaceComments)
{
"}\n"
"// Comment";
-#if 0
- // FIXME: The following comment is aligned with the namespace comment.
verifyFormat("namespace A {\n"
" int Foo;\n"
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() {
}
}
-// We don't want to align namespace end comments.
-const bool DontAlignThisComment =
-I > 0 && C.NewlinesBefore == 0 &&
-Changes[I -
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() {
}
}
-// We don't want to align namespace end comments.
-const bool DontAlignThisComment =
-I > 0 && C.NewlinesBefore == 0 &&
-Changes[I -
@@ -20794,7 +20794,7 @@ TEST_F(FormatTest,
CatchAlignArrayOfStructuresRightAlignment) {
verifyFormat("int a[][] = {\n"
"{\n"
" {0, 2}, //\n"
- " {1, 2} //\n"
+ " {1, 2} //\n"
owenca wrote:
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() {
}
}
-// We don't want to align namespace end comments.
-const bool DontAlignThisComment =
-I > 0 && C.NewlinesBefore == 0 &&
-Changes[I -
@@ -1118,16 +1121,40 @@ void WhitespaceManager::alignTrailingComments() {
}
}
-// We don't want to align namespace end comments.
-const bool DontAlignThisComment =
-I > 0 && C.NewlinesBefore == 0 &&
-Changes[I -
Author: Jared Grubb
Date: 2023-10-15T15:58:24-07:00
New Revision: 7f881a2abe2c3eceeae0272fc41ba0a237770450
URL:
https://github.com/llvm/llvm-project/commit/7f881a2abe2c3eceeae0272fc41ba0a237770450
DIFF:
https://github.com/llvm/llvm-project/commit/7f881a2abe2c3eceeae0272fc41ba0a237770450.diff
Author: Owen Pan
Date: 2023-10-15T15:52:17-07:00
New Revision: 6c7cf74a75572c3cc5d9979f02b67a7357e9c656
URL:
https://github.com/llvm/llvm-project/commit/6c7cf74a75572c3cc5d9979f02b67a7357e9c656
DIFF:
https://github.com/llvm/llvm-project/commit/6c7cf74a75572c3cc5d9979f02b67a7357e9c656.diff
Author: Jared Grubb
Date: 2023-10-15T15:44:57-07:00
New Revision: 6f46bcc609f14121e6942763ba9871f98541ea0e
URL:
https://github.com/llvm/llvm-project/commit/6f46bcc609f14121e6942763ba9871f98541ea0e
DIFF:
https://github.com/llvm/llvm-project/commit/6f46bcc609f14121e6942763ba9871f98541ea0e.diff
=?utf-8?q?Björn_Schäpers?=
Message-ID:
In-Reply-To:
@@ -182,7 +182,7 @@ TEST_F(FormatTestComments, UnderstandsSingleLineComments) {
"int a; // This is unrelated"));
EXPECT_EQ("class C {\n"
" void f() { // This does something ..\n"
-
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2756,6 +2756,10 @@ FormatToken
*UnwrappedLineParser::parseIfThenElse(IfStmtKind *IfKind,
CompoundStatementIndenter Indenter(this, Style, Line->Level);
parseBlock(/*MustBeDeclaration=*/false, /*AddLevels=*/1u,
/*MunchSemi=*/true, KeepIfBraces, );
+
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/68621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2023-10-09T01:09:45-07:00
New Revision: 42c564df2f479efb38e6f02340e370815b439eb1
URL:
https://github.com/llvm/llvm-project/commit/42c564df2f479efb38e6f02340e370815b439eb1
DIFF:
https://github.com/llvm/llvm-project/commit/42c564df2f479efb38e6f02340e370815b439eb1.diff
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Bj=C3=B6rn_Sch=C3=A4pers?=
Message-ID:
In-Reply-To:
owenca wrote:
See https://github.com/llvm/llvm-project/issues/56636.
https://github.com/llvm/llvm-project/pull/68535
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
=?utf-8?q?Bj=C3=B6rn_Sch=C3=A4pers?=
Message-ID:
In-Reply-To:
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68535
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: Owen Pan
Date: 2023-10-05T19:24:08-07:00
New Revision: 84cbd9f4ffba17a74516d1afa442568dc54eabb1
URL:
https://github.com/llvm/llvm-project/commit/84cbd9f4ffba17a74516d1afa442568dc54eabb1
DIFF:
https://github.com/llvm/llvm-project/commit/84cbd9f4ffba17a74516d1afa442568dc54eabb1.diff
Author: Owen Pan
Date: 2023-10-05T01:18:49-07:00
New Revision: 8902f12e61aa2d3053ad4d536e36569fc8bc9512
URL:
https://github.com/llvm/llvm-project/commit/8902f12e61aa2d3053ad4d536e36569fc8bc9512
DIFF:
https://github.com/llvm/llvm-project/commit/8902f12e61aa2d3053ad4d536e36569fc8bc9512.diff
owenca wrote:
Reverted in d08fcc817eba.
https://github.com/llvm/llvm-project/pull/67955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2023-10-03T18:19:23-07:00
New Revision: d08fcc817eba7f0186620688eee73f6d25fa90e8
URL:
https://github.com/llvm/llvm-project/commit/d08fcc817eba7f0186620688eee73f6d25fa90e8
DIFF:
https://github.com/llvm/llvm-project/commit/d08fcc817eba7f0186620688eee73f6d25fa90e8.diff
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
We should also update [this
line](https://github.com/llvm/llvm-project/pull/68154/files#diff-13a957866eda585a177e1d10139b157956e9d82c40d2275b500c2b1bcb2ad8c0R452)
to:
```
assert(Shift > 0 || Changes[i].NewlinesBefore > 0 ||
```
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/67955
>From 15d37075331311020020c5741e2432cd3fc0be74 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 1 Oct 2023 23:01:30 -0700
Subject: [PATCH 1/2] [clang-format] Annotate ctors/dtors as CtorDtorDeclName
instead
owenca wrote:
> https://buildkite.com/llvm-project/clang-ci/builds/4275#018af20e-3d3c-4344-b92d-88ac8b09b484
> Tests do not pass?
I saw that but don't know why. Did you have the same failures? I'll push
another commit shortly to trigger buildkite again.
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/67955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3447,9 +3447,13 @@ void
TokenAnnotator::calculateFormattingInformation(AnnotatedLine ) const {
Tok = Tok->Next) {
if (Tok->Previous->EndsCppAttributeGroup)
AfterLastAttribute = Tok;
-if (isFunctionDeclarationName(Style.isCpp(), *Tok, Line,
@@ -16339,7 +16345,7 @@ TEST_F(FormatTest, ConfigurableSpaceBeforeParens) {
verifyFormat("int f();", SpaceFuncDef);
verifyFormat("void f (int a, T b) {}", SpaceFuncDef);
- verifyFormat("A::A () : a(1) {}", SpaceFuncDef);
+ verifyFormat("A::A() : a(1) {}", SpaceFuncDef);
@@ -3447,9 +3447,13 @@ void
TokenAnnotator::calculateFormattingInformation(AnnotatedLine ) const {
Tok = Tok->Next) {
if (Tok->Previous->EndsCppAttributeGroup)
AfterLastAttribute = Tok;
-if (isFunctionDeclarationName(Style.isCpp(), *Tok, Line,
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -18525,12 +18525,17 @@ TEST_F(FormatTest, AlignConsecutiveAssignments) {
" a_longer_name_for_wrap}};",
Alignment);
- Alignment.ColumnLimit = 60;
+ Alignment = getLLVMStyleWithColumns(60);
+
@@ -18525,12 +18525,17 @@ TEST_F(FormatTest, AlignConsecutiveAssignments) {
" a_longer_name_for_wrap}};",
Alignment);
- Alignment.ColumnLimit = 60;
+ Alignment = getLLVMStyleWithColumns(60);
+
owenca wrote:
Can you add an issue to show the incorrect format before this patch?
https://github.com/llvm/llvm-project/pull/68029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/67955
>From 15d37075331311020020c5741e2432cd3fc0be74 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 1 Oct 2023 23:01:30 -0700
Subject: [PATCH] [clang-format] Annotate ctors/dtors as CtorDtorDeclName
instead
After
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
@tru np! That was my intention anyways.
https://github.com/llvm/llvm-project/pull/67911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67955
After annotating constructors/destructors as FunctionDeclarationName in commit
08630512088, we have seen several issues because ctors/dtors had been treated
differently than functions in aligning, wrapping, and
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67911
Don't remove the outermost parentheses surrounding a return statement
expression when inside a function/lambda that has the decltype(auto) return
type.
Fixed #67892.
>From
Author: Owen Pan
Date: 2023-09-30T02:09:52-07:00
New Revision: 511662b88c36f8d5d02f0b758b15c1b84d4ee6c1
URL:
https://github.com/llvm/llvm-project/commit/511662b88c36f8d5d02f0b758b15c1b84d4ee6c1
DIFF:
https://github.com/llvm/llvm-project/commit/511662b88c36f8d5d02f0b758b15c1b84d4ee6c1.diff
Author: Owen Pan
Date: 2023-09-30T02:03:14-07:00
New Revision: 36c1e568bb4f8e482e3f713c8cb9460c5cf19863
URL:
https://github.com/llvm/llvm-project/commit/36c1e568bb4f8e482e3f713c8cb9460c5cf19863
DIFF:
https://github.com/llvm/llvm-project/commit/36c1e568bb4f8e482e3f713c8cb9460c5cf19863.diff
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/67780
>From 40d12f082ac712ea4b967db5a981a9fd08ef7c54 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 29 Sep 2023 02:30:47 -0700
Subject: [PATCH] [clang-format] Fix a bug in mis-annotating arrows
Fixed #66923.
---
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67780
Fixed #66923.
>From 4d65ac64140d39edb70ba64d88971819c2602ea7 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 29 Sep 2023 02:30:47 -0700
Subject: [PATCH] [clang-format] Fix a bug in mis-annotating arrows
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67618
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca resolved
https://github.com/llvm/llvm-project/pull/67518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
801 - 900 of 1139 matches
Mail list logo
