[clang] [clang-format] Handle __attribute/__declspec/AttributeMacro consistently (PR #67518)

2023-09-28 Thread Owen Pan via cfe-commits
@@ -633,9 +637,10 @@ struct FormatToken { bool canBePointerOrReferenceQualifier() const { return isOneOf(tok::kw_const, tok::kw_restrict, tok::kw_volatile, - tok::kw___attribute, tok::kw__Nonnull, tok::kw__Nullable, +

[clang] [clang-format] Don't align ctors and dtors with other functions (PR #67618)

2023-09-27 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67618 Fixed #67604. >From dfa92b41b74e554157467ea51f5db9dfcec4fcce Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 27 Sep 2023 16:06:48 -0700 Subject: [PATCH] [clang-format] Don't align ctors and dtors with other

[clang] [clang-format] Correctly annotate keyword operator function name (PR #66904)

2023-09-27 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate keyword operator function name (PR #66904)

2023-09-27 Thread Owen Pan via cfe-commits
owenca wrote: @HazardyKnusperkeks Np! Really appreciate your prompt reviews of so many clang-format patches! https://github.com/llvm/llvm-project/pull/66904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Correctly annotate keyword operator function name (PR #66904)

2023-09-27 Thread Owen Pan via cfe-commits
owenca wrote: Ping @mydeveloperday @HazardyKnusperkeks @rymiel https://github.com/llvm/llvm-project/pull/66904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle __attribute/__declspec/AttributeMacro consistently (PR #67518)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67518 None >From 44165f4df433a668e4f4c2db730a66ce2acbc64b Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 26 Sep 2023 20:43:55 -0700 Subject: [PATCH] [clang-format] Handle __attribute/__declspec/AttributeMacro

[clang] [clang-format] Split TT_AttributeParen (PR #67396)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in NamespaceEndCommentsFixer (PR #67422)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in NamespaceEndCommentsFixer (PR #67422)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67422 Fixed #67407. >From 1c74983f9d2a16ab26d64624448df89e5fff87c4 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 26 Sep 2023 05:17:25 -0700 Subject: [PATCH] [clang-format] Fix a bug in NamespaceEndCommentsFixer

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

2023-09-26 Thread Owen Pan via cfe-commits
owenca wrote: > Pinging @owenca. Waiting for one of @mydeveloperday @HazardyKnusperkeks @rymiel https://github.com/llvm/llvm-project/pull/66893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Split TT_AttributeParen (PR #67396)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/67396 >From 3ae647542b80edb47bb2e47e87118be6a1bdbdec Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 25 Sep 2023 23:21:38 -0700 Subject: [PATCH] [clang-format] Split TT_AttributeParen Replaced TT_AttributeParen

[clang] [clang-format] Split TT_AttributeParen (PR #67396)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67396 Replaced TT_AttributeParen with TT_AttributeLParen and TT_AttributeRParen. >From 32c071771910693e1ba739db32c0de212352e9d8 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 25 Sep 2023 23:21:38 -0700 Subject:

[clang] 38dd67c - [clang-format][NFC] Minor cleanup of the parser and annotator

2023-09-25 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-25T22:20:02-07:00 New Revision: 38dd67c8b3dbce4311e32a68d1100bd9f850c43e URL: https://github.com/llvm/llvm-project/commit/38dd67c8b3dbce4311e32a68d1100bd9f850c43e DIFF: https://github.com/llvm/llvm-project/commit/38dd67c8b3dbce4311e32a68d1100bd9f850c43e.diff

[clang] [clang-format] Fix a bug in aligning trailing comments (PR #67221)

2023-09-24 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in aligning trailing comments (PR #67221)

2023-09-24 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/67221 >From 8f9df29e1fdfdf49d4a420cc7ec7a28d6bba807f Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 22 Sep 2023 23:47:23 -0700 Subject: [PATCH] [clang-format] Fix a bug in aligning trailing comments Fixes #67116.

[clang] [clang-format] Fix a bug in aligning trailing comments (PR #67221)

2023-09-24 Thread Owen Pan via cfe-commits
https://github.com/owenca reopened https://github.com/llvm/llvm-project/pull/67221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7db211b - [clang-format][NFC] Remove the unused separateDefinitionBlocks()

2023-09-24 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-24T19:25:23-07:00 New Revision: 7db211bda791e4326e380a57a882af20a273 URL: https://github.com/llvm/llvm-project/commit/7db211bda791e4326e380a57a882af20a273 DIFF: https://github.com/llvm/llvm-project/commit/7db211bda791e4326e380a57a882af20a273.diff

[clang] [clang-format][NFC] Clean up alignTrailingComments() (PR #67218)

2023-09-24 Thread Owen Pan via cfe-commits
owenca wrote: Fixed in ff7e85402280. https://github.com/llvm/llvm-project/pull/67218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up alignTrailingComments() (PR #67218)

2023-09-24 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-23 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. LGTM, but please wait for @mydeveloperday. https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-23 Thread Owen Pan via cfe-commits
https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-23 Thread Owen Pan via cfe-commits
https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-23 Thread Owen Pan via cfe-commits
https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in aligning trailing comments (PR #67221)

2023-09-23 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67221 Fixes #67116. >From 9fa6ed9430896ee9164260227f0791986c750f0f Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 22 Sep 2023 23:47:23 -0700 Subject: [PATCH] [clang-format] Fix a bug in aligning trailing comments

[clang] [clang-format][NFC] Clean up alignTrailingComments() (PR #67218)

2023-09-22 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67218 None >From b00e6394bb1fe30be40e040b9201c4f3f1b28cd3 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 22 Sep 2023 21:33:02 -0700 Subject: [PATCH] [clang-format][NFC] Clean up alignTrailingComments() ---

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken , if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.g. +

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken , if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.g. +

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const FormatToken , if (State.Stack.back().IsInsideObjCArrayLiteral) return nullptr; +// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports +// cannot be split, e.g. +

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-21 Thread Owen Pan via cfe-commits
https://github.com/owenca requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't split "DPI"/"DPI-C" in Verilog imports (PR #66951)

2023-09-20 Thread Owen Pan via cfe-commits
owenca wrote: Please wait for @sstwcw. IMO it would be better to disable splitting string literals after `import`. https://github.com/llvm/llvm-project/pull/66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-20 Thread Owen Pan via cfe-commits
@@ -22537,10 +22537,12 @@ TEST_F(FormatTest, FormatsLambdas) { " }\n" "}", Style); - verifyFormat("std::sort(v.begin(), v.end(),\n" - " [](const auto , const auto ) {\n" - " return foo.baz <

[clang] [clang-format] Correctly annotate keyword operator function name (PR #66904)

2023-09-20 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66904 Fixes #66890. >From 95780df0571c27453b77e893e5020d9b451b0e6d Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 20 Sep 2023 05:56:27 -0700 Subject: [PATCH] [clang-format] Correctly annotate keyword operator

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

2023-09-20 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66893 Fixes #66857. >From a03878c28110c26c6119f3c5038640b01df3cfe0 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 20 Sep 2023 03:54:09 -0700 Subject: [PATCH] [clang-format] Correctly annotate return type of

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-20 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
@@ -22589,9 +22591,23 @@ TEST_F(FormatTest, FormatsLambdas) { verifyFormat("Namespace::Foo::Foo(LongClassName bar,\n" "AnotherLongClassName baz)\n" ": baz{baz}, func{[&] {\n" - " auto qux = bar;\n" -

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
@@ -1955,7 +1955,8 @@ void ContinuationIndenter::moveStatePastScopeCloser(LineState ) { void ContinuationIndenter::moveStateToNewBlock(LineState ) { if (Style.LambdaBodyIndentation == FormatStyle::LBI_OuterScope && - State.NextToken->is(TT_LambdaLBrace)) { +

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
https://github.com/owenca requested changes to this pull request. Can you add test cases with `BreakConstructorInitializer` set to `AfterColon`? https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
@@ -22537,10 +22537,12 @@ TEST_F(FormatTest, FormatsLambdas) { " }\n" "}", Style); - verifyFormat("std::sort(v.begin(), v.end(),\n" - " [](const auto , const auto ) {\n" - " return foo.baz <

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-19 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
@@ -370,9 +364,9 @@ bool UnwrappedLineParser::parseLevel(const FormatToken *OpeningBrace, else if (FormatTok->getType() == TT_MacroBlockEnd) kind = tok::r_brace; -auto ParseDefault = [this, OpeningBrace, NextLevelLBracesType, IfKind, +auto ParseDefault =

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From bf3160066ae83d43837f18825d00c963d0c29ca8 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH 1/2] [clang-format][NFC] Clean up signatures of some parser functions

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
@@ -1019,10 +1019,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { Tokens = annotate("void f() & requires(true) {}"); EXPECT_EQ(Tokens.size(), 12u) << Tokens; + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause);

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
@@ -1019,10 +1019,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { Tokens = annotate("void f() & requires(true) {}"); EXPECT_EQ(Tokens.size(), 12u) << Tokens; + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause);

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
@@ -1135,6 +1145,14 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresExpressions) { EXPECT_TOKEN(Tokens[3], tok::kw_requires, TT_RequiresExpression); EXPECT_TOKEN(Tokens[4], tok::l_paren, TT_RequiresExpressionLParen); EXPECT_TOKEN(Tokens[14], tok::l_brace,

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca commented: Nits. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From bf3160066ae83d43837f18825d00c963d0c29ca8 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser functions

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From 83b81df954391c38c123a116ab5c39acd29a3a87 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser functions

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-15 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66569 None >From d570d3bb4d0bf9a49b51c25857958988329d398f Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

2023-09-15 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread Owen Pan via cfe-commits
@@ -2237,15 +2237,10 @@ ContinuationIndenter::createBreakableToken(const FormatToken , LineState , bool AllowBreak) { unsigned StartColumn = State.Column - Current.ColumnWidth; if (Current.isStringLiteral()) { -// Strings in

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread Owen Pan via cfe-commits
@@ -2783,17 +2783,17 @@ the configuration (without a prefix: ``Auto``). const char* x = "veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; - In C#, Java, and JavaScript: + In C# and Java: .. code-block:: c++ true: - var x =

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

2023-09-14 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66354: >From 73669f7d04070feade2282384478e96b8bc6d727 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 14 Sep 2023 02:59:43 -0700 Subject: [PATCH] [clang-format] Fix a bug in ContinuationIndenter See

[clang] [clang-format] Fix a bug in ContinuationIndenter (PR #66354)

2023-09-14 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/66354: See https://reviews.llvm.org/D136154#3890747 for context. Fixes part of #58592. >From 9a15ec3256e2d380d5eb70f0751ea1bb457895dd Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 14 Sep 2023 02:59:43 -0700

[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

2023-09-14 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/65933: >From 70aafbc4717264205796fa2ea67d78482f9f2a0d Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 11 Sep 2023 01:00:24 -0700 Subject: [PATCH] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&`

[clang] [clang-format] Fix a bug in annotating `&&` followed by `*` or `&` (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating `&&` enclosed in `<` and `>` (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating '&&' enclosed in '<' and '>' (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/65933: Fixes #65877. >From 86b83692a9f13b8c608190f6abc3111719583730 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 11 Sep 2023 01:00:24 -0700 Subject: [PATCH] [clang-format] Fix a bug in annotating '&&' enclosed

[clang] [clang-format] Fix a bug in annotating '&&' enclosed in '<' and '>' (PR #65933)

2023-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca review_requested https://github.com/llvm/llvm-project/pull/65933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b908123 - [clang-format][NFC] Minor cleanup of token annotator and test cases

2023-09-11 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-11T00:18:57-07:00 New Revision: b908123c3c1934c03b5183318a47d321fb796260 URL: https://github.com/llvm/llvm-project/commit/b908123c3c1934c03b5183318a47d321fb796260 DIFF: https://github.com/llvm/llvm-project/commit/b908123c3c1934c03b5183318a47d321fb796260.diff

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-10 Thread Owen Pan via cfe-commits
@@ -3369,9 +3369,13 @@ bool clang::format::UnwrappedLineParser::parseRequires() { case tok::kw_volatile: case tok::kw_const: case tok::comma: - FormatTok = Tokens->setPosition(StoredPosition); - parseRequiresExpression(RequiresToken); - return

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-10 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-10 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9ae41a1 - [clang-format][doc] Fix a '' (in c669541c969c) that meant to be ``

2023-09-10 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-10T12:52:49-07:00 New Revision: 9ae41a1472b2529a9028d003ca0e8e3812348742 URL: https://github.com/llvm/llvm-project/commit/9ae41a1472b2529a9028d003ca0e8e3812348742 DIFF: https://github.com/llvm/llvm-project/commit/9ae41a1472b2529a9028d003ca0e8e3812348742.diff

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread Owen Pan via cfe-commits
@@ -1599,6 +1600,15 @@ unsigned ContinuationIndenter::moveStateToNextToken(LineState , State.Column += Current.ColumnWidth; State.NextToken = State.NextToken->Next; + // Verilog case labels are are on the same unwrapped lines as the statements + // that follow.

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a serious bug in git-clang-format (PR #65723)

2023-09-08 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/65723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 210e7b3 - [clang-format] Improve line-breaking in LambdaBodyIndentation: OuterScope

2023-09-08 Thread Owen Pan via cfe-commits
Author: Jon Phillips Date: 2023-09-08T14:34:00-07:00 New Revision: 210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc URL: https://github.com/llvm/llvm-project/commit/210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc DIFF: https://github.com/llvm/llvm-project/commit/210e7b3ca773c07c2a8c2fd8f471db5c6724f3bc.diff

[clang] a8fbc16 - Revert "[git-clang-format] Fix typo in help message"

2023-09-07 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-07T15:05:46-07:00 New Revision: a8fbc16ebebedce98d06782680fcafae0cf06e7d URL: https://github.com/llvm/llvm-project/commit/a8fbc16ebebedce98d06782680fcafae0cf06e7d DIFF: https://github.com/llvm/llvm-project/commit/a8fbc16ebebedce98d06782680fcafae0cf06e7d.diff

[clang] c22c0c4 - [clang-format][NFC] Change conjunction of isNot() with one !isOneOf()

2023-09-07 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-07T00:20:02-07:00 New Revision: c22c0c4769da8084378675fe58fd033dfa73ad1e URL: https://github.com/llvm/llvm-project/commit/c22c0c4769da8084378675fe58fd033dfa73ad1e DIFF: https://github.com/llvm/llvm-project/commit/c22c0c4769da8084378675fe58fd033dfa73ad1e.diff

[clang] 4146b30 - Revert "[Format] Modernize SpaceBeforeParensCustom (NFC)"

2023-09-05 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-05T12:03:14-07:00 New Revision: 4146b30785fb5db6fa4da47e6198f7bd961559c5 URL: https://github.com/llvm/llvm-project/commit/4146b30785fb5db6fa4da47e6198f7bd961559c5 DIFF: https://github.com/llvm/llvm-project/commit/4146b30785fb5db6fa4da47e6198f7bd961559c5.diff

[clang] f465a48 - [clang-format] Fix segmentation fault when formatting nested namespaces

2023-09-05 Thread Owen Pan via cfe-commits
Author: Arkadiy Yudintsev Date: 2023-09-05T11:12:14-07:00 New Revision: f465a482caa94d01a2dd74e4c673adeb1f222f2f URL: https://github.com/llvm/llvm-project/commit/f465a482caa94d01a2dd74e4c673adeb1f222f2f DIFF:

[clang] 58c67e7 - [clang-format] Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

2023-08-31 Thread Owen Pan via cfe-commits
Author: Galen Elias Date: 2023-08-31T14:21:19-07:00 New Revision: 58c67e724f718be06ea43c766871135a338c2d55 URL: https://github.com/llvm/llvm-project/commit/58c67e724f718be06ea43c766871135a338c2d55 DIFF: https://github.com/llvm/llvm-project/commit/58c67e724f718be06ea43c766871135a338c2d55.diff

[clang] 77b2fc8 - [clang-format][NFC] Reformat and fix file mode

2023-08-30 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-30T18:35:24-07:00 New Revision: 77b2fc8ad9224bbabcb4a3bc3e97ab3852348aec URL: https://github.com/llvm/llvm-project/commit/77b2fc8ad9224bbabcb4a3bc3e97ab3852348aec DIFF: https://github.com/llvm/llvm-project/commit/77b2fc8ad9224bbabcb4a3bc3e97ab3852348aec.diff

[clang] 14feca5 - [clang-format][NFC] Replace EXPECT_EQ() with verifyFormat()

2023-08-30 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-30T14:55:26-07:00 New Revision: 14feca5d14f1b158f468f01039302da2ca396b14 URL: https://github.com/llvm/llvm-project/commit/14feca5d14f1b158f468f01039302da2ca396b14 DIFF: https://github.com/llvm/llvm-project/commit/14feca5d14f1b158f468f01039302da2ca396b14.diff

[clang] 0863051 - Reland "[clang-format] Annotate constructor/destructor names"

2023-08-29 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-29T13:14:52-07:00 New Revision: 0863051208870b284a1ee899defc0ba2b6e53fc4 URL: https://github.com/llvm/llvm-project/commit/0863051208870b284a1ee899defc0ba2b6e53fc4 DIFF: https://github.com/llvm/llvm-project/commit/0863051208870b284a1ee899defc0ba2b6e53fc4.diff

[clang] 6982f1f - [clang-format][NFC] Test formatting the input before messing it up

2023-08-29 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-29T00:59:33-07:00 New Revision: 6982f1fc2e750cfbb4b0098a6294d341238656ca URL: https://github.com/llvm/llvm-project/commit/6982f1fc2e750cfbb4b0098a6294d341238656ca DIFF: https://github.com/llvm/llvm-project/commit/6982f1fc2e750cfbb4b0098a6294d341238656ca.diff

[clang] 19e3dfa - [clang-format][NFC] Chang some verifyFormat() to verifyNoChange()

2023-08-26 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-26T19:44:05-07:00 New Revision: 19e3dfad58d36ed5aee798fc1b0af2a449002afc URL: https://github.com/llvm/llvm-project/commit/19e3dfad58d36ed5aee798fc1b0af2a449002afc DIFF: https://github.com/llvm/llvm-project/commit/19e3dfad58d36ed5aee798fc1b0af2a449002afc.diff

[clang] c852145 - [clang-format][NFC] Skip stability test if input is pre-formatted

2023-08-26 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-26T14:48:04-07:00 New Revision: c8521451708a49a5a55cf02c28189efac11b779e URL: https://github.com/llvm/llvm-project/commit/c8521451708a49a5a55cf02c28189efac11b779e DIFF: https://github.com/llvm/llvm-project/commit/c8521451708a49a5a55cf02c28189efac11b779e.diff

[clang] 0e63f1a - [clang-format] Annotate constructor/destructor names

2023-08-24 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-24T01:32:52-07:00 New Revision: 0e63f1aacc0040e9a16fa2fab15a140b1686e2ab URL: https://github.com/llvm/llvm-project/commit/0e63f1aacc0040e9a16fa2fab15a140b1686e2ab DIFF: https://github.com/llvm/llvm-project/commit/0e63f1aacc0040e9a16fa2fab15a140b1686e2ab.diff

[clang] 91c4db0 - [clang-format][NFC] Replace !is() with isNot()

2023-08-24 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-24T01:27:24-07:00 New Revision: 91c4db00612b205c6d0f56990b657c5646ad2a3b URL: https://github.com/llvm/llvm-project/commit/91c4db00612b205c6d0f56990b657c5646ad2a3b DIFF: https://github.com/llvm/llvm-project/commit/91c4db00612b205c6d0f56990b657c5646ad2a3b.diff

[clang] d06b923 - [clang-format] Fix a bug that wraps before function arguments

2023-08-23 Thread Owen Pan via cfe-commits
Author: Jon Phillips Date: 2023-08-23T11:18:23-07:00 New Revision: d06b923915137c86e9f281e7fce28240e13665ea URL: https://github.com/llvm/llvm-project/commit/d06b923915137c86e9f281e7fce28240e13665ea DIFF: https://github.com/llvm/llvm-project/commit/d06b923915137c86e9f281e7fce28240e13665ea.diff

[clang] 3364d76 - [clang-format][doc] Don't use the ".0" suffix on version numbers

2023-08-18 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-18T14:57:43-07:00 New Revision: 3364d7620ef78c6e9f04c63e62ac6b0801090ea5 URL: https://github.com/llvm/llvm-project/commit/3364d7620ef78c6e9f04c63e62ac6b0801090ea5 DIFF: https://github.com/llvm/llvm-project/commit/3364d7620ef78c6e9f04c63e62ac6b0801090ea5.diff

[clang] 07181e2 - [clang-format][NFC] Simplify getFirstNonComment() in the annotator

2023-08-18 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-18T13:23:47-07:00 New Revision: 07181e289e3c6296ed5e982dca0764b91acbb8e6 URL: https://github.com/llvm/llvm-project/commit/07181e289e3c6296ed5e982dca0764b91acbb8e6 DIFF: https://github.com/llvm/llvm-project/commit/07181e289e3c6296ed5e982dca0764b91acbb8e6.diff

[clang] e3a7950 - [clang-format] Exclude kw_decltype in RemoveParentheses

2023-08-17 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-17T16:04:44-07:00 New Revision: e3a79503a30f8c9d8fba79f3e5427bb895f320cf URL: https://github.com/llvm/llvm-project/commit/e3a79503a30f8c9d8fba79f3e5427bb895f320cf DIFF: https://github.com/llvm/llvm-project/commit/e3a79503a30f8c9d8fba79f3e5427bb895f320cf.diff

[clang] 063c42e - [clang-format] Handle NamespaceMacro string arg for FixNamespaceComments

2023-08-16 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-16T10:45:54-07:00 New Revision: 063c42e919c01d7e64c1af5a10898fc84b06dfe8 URL: https://github.com/llvm/llvm-project/commit/063c42e919c01d7e64c1af5a10898fc84b06dfe8 DIFF: https://github.com/llvm/llvm-project/commit/063c42e919c01d7e64c1af5a10898fc84b06dfe8.diff

[clang] 2b8542c - [clang-format] Correctly count annoated lines of a namespace body

2023-08-10 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-10T15:55:01-07:00 New Revision: 2b8542ce8e8c24dfcdd0433542cf733556b8 URL: https://github.com/llvm/llvm-project/commit/2b8542ce8e8c24dfcdd0433542cf733556b8 DIFF: https://github.com/llvm/llvm-project/commit/2b8542ce8e8c24dfcdd0433542cf733556b8.diff

[clang] a0b1c23 - [clang-format] Currectly handle PCIS_CurrentLine with no column limit

2023-08-06 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-06T12:14:23-07:00 New Revision: a0b1c235afab4743cf31e4ac4509120d3c156e60 URL: https://github.com/llvm/llvm-project/commit/a0b1c235afab4743cf31e4ac4509120d3c156e60 DIFF: https://github.com/llvm/llvm-project/commit/a0b1c235afab4743cf31e4ac4509120d3c156e60.diff

[clang] 58a71c6 - [clang-format] Handle "// clang-format on" for SeparateDefinitionBlocks

2023-08-05 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-05T12:31:27-07:00 New Revision: 58a71c66db85f65bb6cdefe314f62318b95e9fc4 URL: https://github.com/llvm/llvm-project/commit/58a71c66db85f65bb6cdefe314f62318b95e9fc4 DIFF: https://github.com/llvm/llvm-project/commit/58a71c66db85f65bb6cdefe314f62318b95e9fc4.diff

[clang] 70d7ea0 - [clang-format] Handle goto labels preceded by C++11 attributes

2023-08-02 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-08-02T22:48:48-07:00 New Revision: 70d7ea0cebcf363cd0ddcfb76375fb5fada87dd5 URL: https://github.com/llvm/llvm-project/commit/70d7ea0cebcf363cd0ddcfb76375fb5fada87dd5 DIFF: https://github.com/llvm/llvm-project/commit/70d7ea0cebcf363cd0ddcfb76375fb5fada87dd5.diff

<    5   6   7   8   9   10   11   12   >