Re: [PATCH net-next 2/2] net: bridge: Notify about !added_by_user FDB entries

Nikolay Aleksandrov <niko...@cumulusnetworks.com> writes: > On 01/05/18 20:04, Petr Machata wrote: >> Do not automatically bail out on sending notifications about activity on >> non-user-added FDB entries. Instead, notify about this activity except >> for case

Re: [PATCH net-next 0/2] bridge: FDB: Notify about removal of non-user-added entries

Andrew Lunn <and...@lunn.ch> writes: > On Tue, May 01, 2018 at 07:04:19PM +0200, Petr Machata wrote: >> Device drivers may generally need to keep in sync with bridge's FDB. In >> particular, for its offload of tc mirror action where the mirrored-to >> device is a

[PATCH net-next 2/2] net: bridge: Notify about !added_by_user FDB entries

Do not automatically bail out on sending notifications about activity on non-user-added FDB entries. Instead, notify about this activity except for cases where the activity itself originates in a notification, to avoid sending duplicate notifications. Signed-off-by: Petr Machata <

[PATCH net-next 1/2] switchdev: Add fdb.added_by_user to switchdev notifications

on notifications about non-user-added FDB entries. In case of mlxsw driver, allow a call to mlxsw_sp_span_respin() so that SPAN over bridge catches up with the changed FDB. Signed-off-by: Petr Machata <pe...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 4 drive

[PATCH net-next 0/2] bridge: FDB: Notify about removal of non-user-added entries

ake care not to send notification for bridge updates that itself originate in SWITCHDEV_FDB_*_TO_BRIDGE events. Petr Machata (2): switchdev: Add fdb.added_by_user to switchdev notifications net: bridge: Notify about !added_by_user FDB entries .../ethernet/mellanox/mlxsw/spectrum_switchdev.c

Re: [PATCH net-next v2 1/6] net: bridge: Publish bridge accessor functions

Stephen Hemminger writes: > On Fri, 27 Apr 2018 18:11:06 +0300 > Ido Schimmel wrote: > >> +int br_vlan_pvid_rtnl(const struct net_device *dev, u16 *p_pvid) >> +{ >> +struct net_bridge_vlan_group *vg; >> + >> +ASSERT_RTNL(); >> +if

Re: [Bridge] [PATCH net-next v2 1/6] net: bridge: Publish bridge accessor functions

Stephen Hemminger writes: > On Fri, 27 Apr 2018 18:11:06 +0300 > Ido Schimmel wrote: > >> +int br_vlan_pvid_rtnl(const struct net_device *dev, u16 *p_pvid) >> +{ >> +struct net_bridge_vlan_group *vg; >> + >> +ASSERT_RTNL(); >> +if

Re: [Bridge] [PATCH net-next v2 1/6] net: bridge: Publish bridge accessor functions

Nikolay Aleksandrov <niko...@cumulusnetworks.com> writes: > On 27/04/18 18:11, Ido Schimmel wrote: >> From: Petr Machata <pe...@mellanox.com> >> >> Add a couple new functions to allow querying FDB and vlan settings of a >> bridge. >> >> Signed-

Re: [Bridge] [PATCH net-next 6/6] mlxsw: spectrum_span: Allow bridge for gretap mirror

Nikolay Aleksandrov <niko...@cumulusnetworks.com> writes: > On 26/04/18 12:06, Ido Schimmel wrote: >> From: Petr Machata <pe...@mellanox.com> >> >> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c >> b/drivers/net/ethernet/mellanox/mlxs

Re: [PATCH net-next v2 1/6] net: bridge: Publish bridge accessor functions

Nikolay Aleksandrov <niko...@cumulusnetworks.com> writes: > On 27/04/18 18:11, Ido Schimmel wrote: >> From: Petr Machata <pe...@mellanox.com> >> >> Add a couple new functions to allow querying FDB and vlan settings of a >> bridge. >> >> Signed-

[PATCH net-next 6/7] selftests: forwarding: Test neighbor updates when mirroring to gretap

Test that when a mirror to gretap or ip6gretap netdevice is configured, changes to neighbors are reflected. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> --- .../selftests/net/forwarding/mirror_gre_neigh.sh | 101 +

[PATCH net-next 7/7] selftests: forwarding: Test changes in mirror-to-gretap

These tests set up mirroring in a situation that the configuration is incorrect, i.e. mirrored packets, if any, are not supposed to reach destination tunnel device. Then the configuration is rectified and mirroring is checked to have started working. Signed-off-by: Petr Machata <

[PATCH net-next 4/7] selftests: forwarding: Test mirror to gretap w/ bound dev

Test mirroring to a gretap and an ip6gretap netdevice with a bound device, where the tunnel device and the bound device are in different VRFs (an overlay / underlay configuration). Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> --- .../s

[PATCH net-next 5/7] selftests: forwarding: Test flower mirror to gretap

Add a test for mirroring to a gretap and an ip6gretap netdevices such that the mirroring action is triggered by a flower match. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> --- .../selftests/net/forwarding/mirror_gre_flow

[PATCH net-next 3/7] selftests: forwarding: Test gretap mirror with next-hop remote

Test mirror to a gretap and an ip6gretap netdevice such that the remote address of the tunnel is reachable through a next-hop route. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> --- .../selftests/net/forwarding/mirror_gre_nh.s

[PATCH net-next 2/7] selftests: forwarding: Add test for mirror to gretap

Add a test for basic mirroring to gretap and ip6gretap netdevices. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> --- .../testing/selftests/net/forwarding/mirror_gre.sh | 139 + 1 file changed, 139 insertions(+)

[PATCH net-next 1/7] selftests: forwarding: Add libs for gretap mirror testing

specifically useful for mirror-to-gretap tests, and mirror_gre_topo.sh that primes a given test with a good baseline topology that the test can then tweak to its liking. Signed-off-by: Petr Machata <pe...@mellanox.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> --- tools/testing/s

[PATCH net-next 0/7] selftests: Add tests for mirroring to gretap

tch queue. Petr Machata (7): selftests: forwarding: Add libs for gretap mirror testing selftests: forwarding: Add test for mirror to gretap selftests: forwarding: Test gretap mirror with next-hop remote selftests: forwarding: Test mirror to gretap w/ bound dev selftests: forwarding: T

Re: [PATCH net-next 6/6] mlxsw: spectrum_span: Allow bridge for gretap mirror

Nikolay Aleksandrov <niko...@cumulusnetworks.com> writes: > On 26/04/18 12:06, Ido Schimmel wrote: >> From: Petr Machata <pe...@mellanox.com> >> >> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c >> b/drivers/net/ethernet/mellanox/mlxs

Re: Passing uninitialised local variable

Arend van Spriel writes: > On 3/28/2018 1:20 PM, Himanshu Jha wrote: >> I recently found that a local variable in passed uninitialised to the >> function at >> >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:2950 >> >> u32 var; >>

Re: Passing uninitialised local variable

Arend van Spriel writes: > On 3/28/2018 1:20 PM, Himanshu Jha wrote: >> I recently found that a local variable in passed uninitialised to the >> function at >> >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:2950 >> >> u32 var; >>

Re: linux-next: manual merge of the ipsec tree with the net tree

next time they rebase on top of net...? Let me know what to do, please. Thanks, Petr >From 2c2210e59cd94571ac67d491026d6ea0f4d69ae4 Mon Sep 17 00:00:00 2001 Message-Id: <2c2210e59cd94571ac67d491026d6ea0f4d69ae4.1522155963.git.pe...@mellanox.com> From: Petr Machata <pe...@mellanox.com> Date: Tue,

Re: linux-next: manual merge of the ipsec tree with the net tree

next time they rebase on top of net...? Let me know what to do, please. Thanks, Petr >From 2c2210e59cd94571ac67d491026d6ea0f4d69ae4 Mon Sep 17 00:00:00 2001 Message-Id: <2c2210e59cd94571ac67d491026d6ea0f4d69ae4.1522155963.git.pe...@mellanox.com> From: Petr Machata <pe...@mellanox.com> Date: Tue,

Re: linux-next: manual merge of the ipsec tree with the net tree

ime they rebase on top of net...? Let me know what to do, please. Thanks, Petr >From 2c2210e59cd94571ac67d491026d6ea0f4d69ae4 Mon Sep 17 00:00:00 2001 Message-Id: <2c2210e59cd94571ac67d491026d6ea0f4d69ae4.1522155963.git.pe...@mellanox.com> From: Petr Machata Date: Tue, 27 Mar 2018 16:00:38 +0300 Subject: [PATCH linux-ne

[tip:perf/core] perf python: Reference Py_None before returning it

Commit-ID: 83428f2fad48e16fddff0cb445cb4fedf5afe4ab Gitweb: https://git.kernel.org/tip/83428f2fad48e16fddff0cb445cb4fedf5afe4ab Author: Petr Machata <pe...@mellanox.com> AuthorDate: Thu, 22 Mar 2018 00:57:32 +0100 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitD

[tip:perf/core] perf python: Reference Py_None before returning it

Commit-ID: 83428f2fad48e16fddff0cb445cb4fedf5afe4ab Gitweb: https://git.kernel.org/tip/83428f2fad48e16fddff0cb445cb4fedf5afe4ab Author: Petr Machata AuthorDate: Thu, 22 Mar 2018 00:57:32 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 23 Mar 2018 16:45:20 -0300 perf python

[PATCH] perf: python: Reference Py_None before returning it

Python None objects are handled just like all the other objects with respect to their reference counting. Before returning Py_None, its reference count thus needs to be bumped. Signed-off-by: Petr Machata <pe...@mellanox.com> --- tools/perf/util/python.c | 4 +++- 1 file changed, 3 inse

[PATCH] perf: python: Reference Py_None before returning it

Python None objects are handled just like all the other objects with respect to their reference counting. Before returning Py_None, its reference count thus needs to be bumped. Signed-off-by: Petr Machata --- tools/perf/util/python.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

Re: linux-next: manual merge of the net-next tree with the net tree

Stephen Rothwell writes: > Today's linux-next merge of the net-next tree got conflicts in: > > drivers/net/ethernet/mellanox/mlxsw/spectrum.h > drivers/net/ethernet/mellanox/mlxsw/spectrum.c > > between commit: > > 663f1b26f9c1 ("mlxsw: spectrum: Prevent duplicate

Re: linux-next: manual merge of the net-next tree with the net tree

Stephen Rothwell writes: > Today's linux-next merge of the net-next tree got conflicts in: > > drivers/net/ethernet/mellanox/mlxsw/spectrum.h > drivers/net/ethernet/mellanox/mlxsw/spectrum.c > > between commit: > > 663f1b26f9c1 ("mlxsw: spectrum: Prevent duplicate

Re: linux-next: manual merge of the net-next tree with the net tree

Stephen Rothwell writes: > Today's linux-next merge of the net-next tree got conflicts in: > > drivers/net/ethernet/mellanox/mlxsw/spectrum.h > drivers/net/ethernet/mellanox/mlxsw/spectrum.c > > between commit: > > 663f1b26f9c1 ("mlxsw: spectrum: Prevent duplicate mirrors") > > from the

Re: [patch net-next 15/15] mlxsw: spectrum_span: Support mirror to ip6gretap

David Ahern writes: > On 2/27/18 6:53 AM, Jiri Pirko wrote: >> diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig >> b/drivers/net/ethernet/mellanox/mlxsw/Kconfig >> index 830c3e28505e..93d97b4676eb 100644 >> --- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig >>

Re: linux-next: manual merge of the net-next tree with the net tree

Stephen Rothwell writes: > Today's linux-next merge of the net-next tree got a conflict in: > > net/ipv4/ip_tunnel.c > > between commit: > > 4e994776e7bd ("ip_tunnel: Do not use mark in skb by default") > > from the net tree and commit: > > b0066da52ea5 ("ip_tunnel:

Re: linux-next: manual merge of the net-next tree with the net tree

Stephen Rothwell writes: > Today's linux-next merge of the net-next tree got a conflict in: > > net/ipv4/ip_tunnel.c > > between commit: > > 4e994776e7bd ("ip_tunnel: Do not use mark in skb by default") > > from the net tree and commit: > > b0066da52ea5 ("ip_tunnel:

Re: linux-next: manual merge of the net-next tree with the net tree

Stephen Rothwell writes: > Today's linux-next merge of the net-next tree got a conflict in: > > net/ipv4/ip_tunnel.c > > between commit: > > 4e994776e7bd ("ip_tunnel: Do not use mark in skb by default") > > from the net tree and commit: > > b0066da52ea5 ("ip_tunnel: Rename & publish

Re: [patch net-next 15/15] mlxsw: spectrum_span: Support mirror to ip6gretap

David Ahern writes: > On 2/27/18 6:53 AM, Jiri Pirko wrote: >> diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig >> b/drivers/net/ethernet/mellanox/mlxsw/Kconfig >> index 830c3e28505e..93d97b4676eb 100644 >> --- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig >>

Re: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning

Ido Schimmel writes: > +learning_test() > +{ > + local mac=de:ad:be:ef:13:37 > + local ageing_time > + local br_port1=$2 # Connected to `host1_if`. > + local host1_if=$3 > + local host2_if=$4 > + local bridge=$1 I don't think applying RXT in

Re: [PATCH iproute2-next v2] ip: link_gre6.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag

Serhey Popovych <serhe.popov...@gmail.com> writes: > Petr Machata wrote: >> For IP-in-IP tunnels, one can specify the [no]allow-localremote command >> when configuring a device. Under the hood, this flips the >> IP6_TNL_F_ALLOW_LOCAL_REMOTE flag on the ne

[PATCH iproute2-next v3] ip: link_gre6.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag

there's no way to configure the flag on these netdevices. Therefore introduce the command to link_gre6 as well. The original support was introduced in commit 21440d19d957 ("ip: link_ip6tnl.c/ip6tunnel.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag") Signed-off-by: Petr Machata <pe...

Re: [PATCH iproute2] ip: link_gre6.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag

Serhey Popovych writes: > Maybe it is better to rebase this against iproute2-next? Sure, I sent a v2 rebased on top of iproute2. Thanks, Petr

[PATCH iproute2-next v2] ip: link_gre6.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag

there's no way to configure the flag on these netdevices. Therefore introduce the command to link_gre6 as well. The original support was introduced in commit 21440d19d957 ("ip: link_ip6tnl.c/ip6tunnel.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag") Signed-off-by: Petr Machata <pe...

[PATCH iproute2] ip: link_gre6.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag

there's no way to configure the flag on these netdevices. Therefore introduce the command to link_gre6 as well. The original support was introduced in commit 21440d19d957 ("ip: link_ip6tnl.c/ip6tunnel.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag") Signed-off-by: Petr Machata <pe...

Re: [PATCH] libdw: dwarf_formsdata should return a signed value

2018-01-15 9:23 GMT+01:00 Mark Wielaard <m...@klomp.org>: > On Mon, 2018-01-15 at 00:06 +0100, Petr Machata wrote: >> Ugh, sorry about that. It's been a while since I last posted, I >> forgot the routine! > > No worries at all. This is all mechanics/boilerplate. >

Re: [PATCH] net: vrf: Make add_fib_rules per network namespace flag

David Ahern writes: > Commit 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create") > adds the l3mdev FIB rule the first time a VRF device is created. However, > it only creates the rule once and only in the namespace the first device > is created - which may not

Re: [Ltrace-devel] New ltrace release

2017-02-03 0:27 GMT+01:00 Dima Kogan <d...@secretsauce.net>: > Petr Machata <pmach...@gmail.com> writes: > > I can't devote tons of time to this, but I'm happy to do a release at > least. I think that will be better than the current state. Alioth > username: dkogan I

Re: [Ltrace-devel] New ltrace release

The real reason seems to be lack of resources. I didn't have time to touch ltrace for almost two years now. If somebody else is willing to step in and finalize a release, and the only thing that they are missing is Alioth permissions, I'll be happy to grant those. As things stand, this project

Re: [ovs-dev] [PATCH] ofproto: Always delete rules before deleting a meter.

Jarno Rajahalme writes: > Pushed to master, but not sure if need to backport to earlier > branches, as meters are not really supported by any release yet? Nope, we only hit this because our own ofproto provider actually does support meters. Thanks for this! Petr

Re: [ovs-dev] Deferring ofproto_class::destruct vs. ovs-appctl exit

Petr Machata <pe...@mellanox.com> writes: > We don't actually see a crash, but an AddressSanitizer citation. As I'm > now trying to reproduce on vanilla branch-2.5, I actually can't either > (using the NULL trick). All the rule_delete calls end up being > scheduled befor

Re: [ovs-dev] Deferring ofproto_class::destruct vs. ovs-appctl exit

Jarno Rajahalme writes: > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index 83dcc9c..5b42b7e 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -864,7 +864,7 @@ close_dpif_backer(struct dpif_backer *backer) > free(backer->type); >

Re: [ovs-dev] Deferring ofproto_class::destruct vs. ovs-appctl exit

Jarno Rajahalme writes: > Btw. I don’t see this problem triggered by the testsuite even if I set the > ‘ofproto->backer' pointer > to NULL right after the free() call. Do you see this happening on an > unmodified OVS 2.5? If so, > could you send the steps to reproduce. Just need

[ovs-dev] Deferring ofproto_class::destruct vs. ovs-appctl exit

Hi, On 2.5, we are seeing the following problem when removing a bridge: - ofproto_destroy calls ofproto_flush__, which eventually calls ovsrcu_postpone(remove_rules_rcu) - ofproto_destroy also calls p->ofproto_class->destruct, which eventually leads to release of DPIF backer

[ovs-dev] [PATCH] Destroy rules before destroying meters

resources to forward-port our provider and actually observe the issue in practice. Thank you, Petr Machata --8< An ofproto that's being destroyed could include rules with meters. Each meter in turn holds a list of rules where that mete

Re: [ovs-dev] SAI ofproto provider for OvS

Ben Pfaff writes: >> > want to make sure that the additional providers can be built without >> > installing code that is available only under NDA. >> >> That is understood. The SAI backend will be optional. > > That's not exactly what I mean. I mean, there must be a way for

Re: [ovs-dev] SAI ofproto provider for OvS

Ben Pfaff writes: > We would be pleased to take additional ofproto pr oviders as long as > they are clean and maintainable (and actually maintained). We would We will want to put forward code that is up to snuff. Regarding the "actually maintained" bit--that is the intention.

[ovs-dev] SAI ofproto provider for OvS

Hello, Mellanox would like to implement an OvS ofproto provider for SAI[1], a vendor-neutral C API for programming switch ASIC's. Would there be interest in merging this work upstream eventually? We are not asking for a blank check here, but are trying to figure out the general stance of the

Re: [Ltrace-devel] [PATCH] ltrace: update s390 system call tables

2015-11-06 13:28 GMT+01:00 Heiko Carstens : > just a simple patch for ltrace to add update and fix the system call tables > on s390. In addition this also slightly improves the script to generate > the tables. Thanks, applied. There was some trickery with the

Re: [Ltrace-devel] patch : disable broken printf length

2015-11-11 14:34 GMT+01:00 Mike Dupont : > Attached a dirty patch to disable the broken printf max string length > code. The patch, cleaned up, would make sense to me. > Take a look at _doprnt from libiberty for an implementation. I am We parse the formatting

Bug#804494: [Ltrace-devel] patch : disable broken printf length

2015-11-11 14:34 GMT+01:00 Mike Dupont : > Attached a dirty patch to disable the broken printf max string length > code. The patch, cleaned up, would make sense to me. > Take a look at _doprnt from libiberty for an implementation. I am We parse the formatting

Re: [Ltrace-devel] Infinite stream of breakpoint events

2015-07-25 0:14 GMT+02:00 Andreas Schwab : > When running the attach-process-dlopen test on ppc64 or ppc64le ltrace > is receiving an endless stream of breakpoint events: > > DEBUG: events.c:336: event: BREAKPOINT: pid=17899, addr=0x3fff88d28c04 > > The last line is repeated

Re: [Ltrace-devel] [PATCH] Fix libunwind support for MIPS

Faraz Shahbazker writes: > On 10/22/2015 02:43 AM, Vicente Olivert Riera wrote: >> ping >> >> On 10/08/2015 04:59 PM, Vicente Olivert Riera wrote: >>> /* Verify that we can safely cast arch_addr_t* to unw_word_t*. */ >>> (void)sizeof(char[1 - 2*(sizeof(unw_word_t) !=

Re: [Ltrace-devel] [PATCH v3] Fix libunwind support for MIPS

Vicente Olivert Riera <vincent.ri...@imgtec.com> writes: > On 24/07/15 08:38, Petr Machata wrote: >> Vicente Olivert Riera <vincent.ri...@imgtec.com> writes: >> >>> >>> rc = unw_get_proc_name(, fn_name, &g

Re: [Ltrace-devel] [PATCH v5] Fix libunwind support for MIPS

2015-08-06 12:08 GMT+02:00 Vicente Olivert Riera : > Tweak the code to make sure the unwind pointers point to the same > address as the arch ones. The patch looks good to me overall. The one outstanding objection that we have is the one regarding the runtime overhead of

Re: [Ltrace-devel] [RFC][PATCH] Add support for mips64 n32/n64

2015-08-04 22:12 GMT+02:00 Faraz Shahbazker <faraz.shahbaz...@imgtec.com>: > On 07/15/2015 03:24 PM, Petr Machata wrote: >> It seems like e_machine and e_class should be /replaced/ with some sort >> of ABI identifier that the backend produces, given an ELF header. The >&

Re: [PATCH] For clang use Blocks instead of nested functions.

2015-09-05 1:54 GMT+02:00 Chih-Hung Hsieh : > * Clang has Blocks like closures that can serve similar > purpose as the nested functions in gnu99. > Syntax of Blocks is similar to nested functions that > *NESTED_FUNC macro can be used for the function/block > declarations.

Re: [Ltrace-devel] ltrace on ppc64

Andreas Schwab sch...@linux-m68k.org writes: Petr Machata pmach...@gmail.com writes: It probably should ignore section symbols. I can't decide on the account of object symbols. I don't know off hand if anything that ltrace can actually trace might be represented as STT_OBJECT and we

Re: [Ltrace-devel] [PATCH v2] Fix libunwind support for MIPS

Vicente Olivert Riera vincent.ri...@imgtec.com writes: - int rc = unw_get_reg(cursor, UNW_REG_IP, - (unw_word_t *) ip); + int rc = unw_get_reg(cursor, UNW_REG_IP, uw_ip); + ip = (arch_addr_t)

Re: [Ltrace-devel] [PATCH] Fix libunwind support for MIPS

Vicente Olivert Riera vincent.ri...@imgtec.com writes: /* Verify that we can safely cast arch_addr_t* to unw_word_t*. */ (void)sizeof(char[1 - 2*(sizeof(unw_word_t) != sizeof(arch_addr_t))]); This check will always fail for MIPS 32-bit architectures (the only ones supported by ltrace)

[ltrace-commits] branch master updated (be0c687 - c22d359)

This is an automated email from the git hooks/post-receive script. pmachata-guest pushed a change to branch master in repository ltrace. from be0c687 Add a way to force a line to be interpreted as a function prototype new c22d359 Install lib*-types.conf The 1 revisions

Re: [Ltrace-devel] [PATCH] Install lib*-types.conf

dist_pkgdata_DATA = etc/syscalls.conf etc/libc.so.conf \ - etc/libm.so.conf etc/libacl.so.conf etc/libpthread.so.conf + etc/libm.so.conf etc/libacl.so.conf etc/libpthread.so.conf \ + etc/libpthread.so-types.conf etc/libc.so-types.conf Pushed. Thanks, Petr

Re: [Ltrace-devel] [RFC][PATCH] Add support for mips64 n32/n64

Faraz Shahbazker faraz.shahbaz...@imgtec.com writes: diff --git a/proc.h b/proc.h index a611456..00094e1 100644 --- a/proc.h +++ b/proc.h @@ -117,6 +117,7 @@ struct process { * nauseam. */ short e_machine; char e_class; + char e_abi; So the part that the diff

[ltrace-commits] 01/02: The return value of process_line is never used, so make it void

This is an automated email from the git hooks/post-receive script. pmachata-guest pushed a commit to branch master in repository ltrace. commit 9d41810320b7def13f1408dcc8bba7375e4633c7 Author: Роман Донченко d...@corrigendum.ru Date: Sun May 10 19:08:17 2015 +0300 The return value of

Re: [Ltrace-devel] [PATCH 1/2] The return value of process_line is never used, so make it void

Pushed. Thanks, Petr ___ Ltrace-devel mailing list Ltrace-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/ltrace-devel

Re: [Ltrace-devel] [PATCH 2/2] Add a way to force a line to be interpreted as a function prototype

Роман Донченко d...@corrigendum.ru writes: Since import is not a keyword in C, it might be used as a type name. However, a function prototype with import as the return type would be interpreted as an import directive. So provide a new keyword, function, that can be used to force a line to be

[ltrace-commits] branch master updated (e79efce - be0c687)

This is an automated email from the git hooks/post-receive script. pmachata-guest pushed a change to branch master in repository ltrace. from e79efce Add more libpthread.so definitions new 9d41810 The return value of process_line is never used, so make it void new

Re: [PATCH 6/6] Provide assert_perror when it's not defined

Mark Wielaard m...@redhat.com writes: [...] this is in the tests a simple assert (errno) would IMHO also be fine Agreed. Petr

Re: [Ltrace-devel] [PATCH] Fix a memory leak in parse_typedef_name

Роман Донченко d...@corrigendum.ru writes: --- a/read_config_file.c +++ b/read_config_file.c @@ -387,6 +387,7 @@ parse_typedef_name(struct protolib *plib, struct locus *loc, char **str) return NULL; struct named_type *nt = protolib_lookup_type(plib, buf, true); +

Re: [Ltrace-devel] [PATCH] Add more libpthread.so definitions

Роман Донченко d...@corrigendum.ru writes: Enclosing as an attachment due to potential line wrapping issues. Pushed. Thanks, Petr ___ Ltrace-devel mailing list Ltrace-devel@lists.alioth.debian.org

Re: [PATCH 6/6] Provide assert_perror when it's not defined

Max Filippov jcmvb...@gmail.com writes: assert_perror is a GNU extension and is not provided by uClibc. Provide definition when that macro is not available. It looks like it would pay off to have a dedicated header file for this macro. Similarly in the 3/6 patch for utimes/futimes, it would

[ltrace-commits] 01/01: Split type definitions from the bundled configs into their own files

This is an automated email from the git hooks/post-receive script. pmachata-guest pushed a commit to branch master in repository ltrace. commit 5ba9e10d2228eca49f7756f1f4078e27c799a08d Author: Роман Донченко d...@corrigendum.ru Date: Mon Apr 20 02:05:04 2015 +0300 Split type definitions

[ltrace-commits] 01/01: Improve pthread call logging

This is an automated email from the git hooks/post-receive script. pmachata-guest pushed a commit to branch master in repository ltrace. commit db0f2e0b4e276764bf3ac3fdb59704e7a4ffc501 Author: Роман Донченко d...@corrigendum.ru Date: Mon Apr 20 03:39:26 2015 +0300 Improve pthread call

Re: [Ltrace-devel] [PATCH 4/6] Split type definitions from the bundled configs into their own files

Роман Донченко d...@corrigendum.ru writes: http://lists.alioth.debian.org/pipermail/ltrace-devel/2015-April/001298.html. Pushed. Thanks, Petr ___ Ltrace-devel mailing list Ltrace-devel@lists.alioth.debian.org

[ltrace-commits] branch master updated (5ba9e10 - db0f2e0)

This is an automated email from the git hooks/post-receive script. pmachata-guest pushed a change to branch master in repository ltrace. from 5ba9e10 Split type definitions from the bundled configs into their own files new db0f2e0 Improve pthread call logging The 1 revisions

Re: [PATCH] libdw: Don't overflow stack with user defined macro attributes array.

Mark Wielaard m...@redhat.com writes: Fixed patch attached. Looks good. Thanks, Petr

Re: [Ltrace-devel] [PATCH 1/6] Fix a memory leak in protolib_cache_maybe_load

Роман Донченко d...@corrigendum.ru writes: - if (DICT_FIND_VAL(cache-protolibs, key, retp) == 0) + if (DICT_FIND_VAL(cache-protolibs, key, retp) == 0) { + if (*retp != NULL own_key) + free((void *) key); return 0; + } if (strdup_if(key,

Re: [PATCH] libdw: Don't overflow stack with user defined macro attributes array.

Mark Wielaard m...@redhat.com writes: - Dwarf_Attribute attributes[proto-nforms]; + Dwarf_Attribute *attributes; + Dwarf_Attribute *attributesp = NULL; + Dwarf_Attribute nattributes[8]; + if (unlikely (proto-nforms 8)) + { + attributesp = malloc (sizeof

Re: [Ltrace-devel] [PATCH 2/6] Make sure there's at least one space after typedef when parsing

Роман Донченко d...@corrigendum.ru writes: For the record, I thought this was okay, because eat_spaces doesn't recognize tabs either. You might want to fix that, too. Good point. I think that's an omission. I changed it to use isspace. Thanks, Petr

[ltrace-commits] 01/01: In config files, skip over all whitespace instead of only spaces

This is an automated email from the git hooks/post-receive script. pmachata-guest pushed a commit to branch master in repository ltrace. commit 0453961c891509bc8a61ae51511c7b3f931e5247 Author: Petr Machata pmach...@gmail.com Date: Tue Apr 21 23:33:14 2015 +0200 In config files, skip over

Re: [Ltrace-devel] [PATCH 6/6] Document import directives

Pushed. Thanks, Petr ___ Ltrace-devel mailing list Ltrace-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/ltrace-devel

Re: [Ltrace-devel] [PATCH 1/6] Fix a memory leak in protolib_cache_maybe_load

Роман Донченко d...@corrigendum.ru writes: When a non-NULL protolib is returned and own_key is true, the key must be freed. --- prototype.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/prototype.c b/prototype.c index fa52ff3..22e54c4 100644 --- a/prototype.c

Re: [PATCH 2/2] Add C++ iterators

Mark Wielaard m...@redhat.com writes: On Thu, 2015-04-16 at 17:42 +0200, Petr Machata wrote: Mark Wielaard m...@redhat.com writes: The only disadvantage of that seems to be that it would immediately introduce a v2 variant if we do it after a public release. I don't even think it would

Re: [PATCH 2/2] Add C++ iterators

Mark Wielaard m...@redhat.com writes: Is that a common use case? I would have imagined that you would iterate over just the Dwarf_Dies of one particular unit separately or given a That would be along these lines: for (die_tree_iterator it (uit), end (++uit); it != end; ++it) ;

Re: [PATCH 2/2] Add C++ iterators

Mark Wielaard m...@redhat.com writes: But given the nice idea above of defining a next iterator as end for another. Would adding that functionality just be introducing a new constructor that takes a Dwarf_Die and a next_sibling () method that returns an iterator that one can use as above in a

[PATCH 2/2] Add C++ iterators

in a new library called libdwpp. Signed-off-by: Petr Machata pmach...@redhat.com --- ChangeLog | 4 + NEWS| 5 +- libdw/ChangeLog | 19 +++ libdw/Makefile.am | 59 - libdw/c

[PATCH 1/2] Enable C++

infrastructure to eu.am. Signed-off-by: Petr Machata pmach...@redhat.com --- ChangeLog| 4 config/ChangeLog | 6 ++ config/eu.am | 21 - configure.ac | 28 4 files changed, 58 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 2/2] Add C++ iterators

Petr Machata pmach...@redhat.com writes: Ping. Sorry, pinging the wrong patch. Petr

Re: [PATCH 2/2] Add C++ iterators

Ping.

Re: [Ltrace-devel] [PATCH] Fix an uninitialized memory access in parse_lens

I decided name2lens is not really adding much value (it's very simple and with one call site only), so I inlined the loop to parse_lens. That's now on master. Thanks, Petr ___ Ltrace-devel mailing list Ltrace-devel@lists.alioth.debian.org

Re: [Ltrace-devel] [PATCH] Fix XDG_CONFIG_DIRS.exp failing when ltrace needs LD_LIBRARY_PATH to run

Pushed. Thanks, Petr ___ Ltrace-devel mailing list Ltrace-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/ltrace-devel

Re: [Ltrace-devel] [PATCH] Fix spurious failures in attach-process.exp

Pushed. Thanks, Petr ___ Ltrace-devel mailing list Ltrace-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/ltrace-devel

Re: [Ltrace-devel] ltrace overhead

yogender nerella ynere...@gmail.com writes: I have googled a lot and dont really find any great c++ profiling tools ( free), do you recommend any? Check out perf and oprofile. ltrace suggests most of our application is spent on memcmp, but by looking at our code, we don't see that as a

<    1   2   3   4   5   6   7   8   9   10   >