Re: build: Use of cargo not yet supported here in Canadian cross configurations

2024-04-15 Thread Pierre-Emmanuel Patry
Hello, On 4/15/24 2:44 PM, Thomas Schwinge wrote: On top of that, OK to push the attached "build: Use of cargo not yet supported here in Canadian cross configurations"? This additional patch looks good. I wonder whether we should enable canadian cross in the future with cargo or simply wait

Re: build: Use of cargo not yet supported here in Canadian cross configurations

2024-04-15 Thread Pierre-Emmanuel Patry
Hello, On 4/15/24 2:44 PM, Thomas Schwinge wrote: On top of that, OK to push the attached "build: Use of cargo not yet supported here in Canadian cross configurations"? This additional patch looks good. I wonder whether we should enable canadian cross in the future with cargo or simply wait

Re: build: Don't check for host-prefixed 'cargo' program

2024-04-15 Thread Pierre-Emmanuel Patry
Hi, On 4/15/24 1:50 PM, Thomas Schwinge wrote: I now wonder: instead of 'AC_CHECK_TOOL', shouldn't this use 'AC_CHECK_PROG'? (We always want plain 'cargo', not host-prefixed 'aarch64-linux-gnu-cargo' etc., right?) I'll look into changing this. This is a mistake, we should use

Re: build: Don't check for host-prefixed 'cargo' program

2024-04-15 Thread Pierre-Emmanuel Patry
Hi, On 4/15/24 1:50 PM, Thomas Schwinge wrote: I now wonder: instead of 'AC_CHECK_TOOL', shouldn't this use 'AC_CHECK_PROG'? (We always want plain 'cargo', not host-prefixed 'aarch64-linux-gnu-cargo' etc., right?) I'll look into changing this. This is a mistake, we should use

[PATCH] build: Check for cargo when building rust language

2024-04-08 Thread pierre-emmanuel . patry
From: Pierre-Emmanuel Patry Hello, The rust frontend requires cargo to build some of it's components, it's presence was not checked during configuration. Best regards, Pierre-Emmanuel -- Prevent rust language from building when cargo is missing. config/ChangeLog: * acx.m4

[PATCH] build: Check for cargo when building rust language

2024-04-08 Thread pierre-emmanuel . patry
From: Pierre-Emmanuel Patry Hello, The rust frontend requires cargo to build some of it's components, it's presence was not checked during configuration. Best regards, Pierre-Emmanuel -- Prevent rust language from building when cargo is missing. config/ChangeLog: * acx.m4

Re: libgrust: 'AM_ENABLE_MULTILIB' only for target builds [PR113056]

2024-01-04 Thread Pierre-Emmanuel Patry
Hello Thomas, On 12/18/23 17:58, Thomas Schwinge wrote: --- a/libgrust/configure.ac +++ b/libgrust/configure.ac -# AM_ENABLE_MULTILIB(, ..) +AM_ENABLE_MULTILIB(, ..) Such a change was applied eventually, and is necessary for target builds -- but potentially harmful for host builds. OK to

Re: libgrust: 'AM_ENABLE_MULTILIB' only for target builds [PR113056]

2024-01-04 Thread Pierre-Emmanuel Patry
Hello Thomas, On 12/18/23 17:58, Thomas Schwinge wrote: --- a/libgrust/configure.ac +++ b/libgrust/configure.ac -# AM_ENABLE_MULTILIB(, ..) +AM_ENABLE_MULTILIB(, ..) Such a change was applied eventually, and is necessary for target builds -- but potentially harmful for host builds. OK to