Re: [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper

Hi Thomas, Thank you for submitting your patch, it looks fine to me. Reviewed-by: Robin van der Gracht On Wed, 13 Mar 2024 16:45:00 +0100 Thomas Zimmermann wrote: > Replace the use of struct backlight_properties.fb_blank with a > call to backlight_get_brightness(). The helper imp

Re: [PATCH 02/10] auxdisplay/ht16k33: Remove struct backlight_ops.check_fb

acklight_ops. > > Signed-off-by: Thomas Zimmermann > Cc: Robin van der Gracht > --- > drivers/auxdisplay/ht16k33.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c > index a90430b7d07ba..0a858db32486b 1006

Re: [PATCH] regmap: clarify struct regmap::max_register value some more

Thanks! Acked-by: Robin van der Gracht On Thu, 11 Jan 2024 08:34:12 +0100 Ahmad Fatoum wrote: > We already have documentation for the member that was taken from Linux, > but still managed to use it wrongly at multiple places that were > recently fixed. To prevent such issues from re

Re: [PATCH master 2/7] nvmem: bsec: correct regmap's max_register

On Mon, 8 Jan 2024 12:17:09 +0100 Robin van der Gracht wrote: ... > > > > barebox@Linux Automation MC-1 board:/ ls -l /dev/stm32-bsec > > crw---384 /dev/stm32-bsec > > Thats more like it. I'll apply the full series and recheck. This works as expec

Re: [PATCH master 2/7] nvmem: bsec: correct regmap's max_register

Hello Ahmad, On Mon, 8 Jan 2024 11:44:00 +0100 Ahmad Fatoum wrote: > Hello Robin, > > On 08.01.24 11:29, Robin van der Gracht wrote: > > Hi Ahmad, > > > > Comments are below. > > > > On Tue, 2 Jan 2024 18:00:55 +0100 > > Ahmad Fatoum wrote: &g

Re: [PATCH master 2/7] nvmem: bsec: correct regmap's max_register

s: 094ce0ee7cdf ("nvmem: bsec: correct regmap's max_register") > Reported-by: Robin van der Gracht > Signed-off-by: Ahmad Fatoum > --- > drivers/nvmem/bsec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvmem/bsec.c b/drivers/n

Re: [PATCH v2] nvmem: regmap: Fix nvmem size

Hi Ahmad, On 2023-12-20 10:00, Ahmad Fatoum wrote: Hello Robin, Thanks for the fix. On 20.12.23 09:29, Robin van der Gracht wrote: - if (roffset + rbytes > stride * regmap_get_max_register(map)) + if (roffset + rbytes > regmap_size_bytes(map) * stride) Shouldn't

[PATCH v2] nvmem: regmap: Fix nvmem size

that. Signed-off-by: Robin van der Gracht --- v2: Fix the size calculation in nvmem_regmap_read() as well. drivers/nvmem/regmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvmem/regmap.c b/drivers/nvmem/regmap.c index fa5405d7a8..b923c5787d 100644

Re: [PATCH] nvmem: regmap: Fix nvmem size

/stm32-bsec 0x017c+4 read: Invalid argument On 2023-12-19 15:14, Robin van der Gracht wrote: We should add 1 to the max_register index since counting is zero based. i.e. the stm32mp151 bsec has registers 0 - 95 with reg_stride 4. Size should be (95 + 1) * 4 = 384 bytes otherwise we can't access

[PATCH] nvmem: regmap: Fix nvmem size

We should add 1 to the max_register index since counting is zero based. i.e. the stm32mp151 bsec has registers 0 - 95 with reg_stride 4. Size should be (95 + 1) * 4 = 384 bytes otherwise we can't access bsec register 95 (last one). Signed-off-by: Robin van der Gracht --- drivers/nvmem/regmap.c

Re: [PATCH 10/32] auxdisplay/ht16k33: Initialize fb_ops with fbdev macros

systems that do not use these functions. Signed-off-by: Thomas Zimmermann Cc: Miguel Ojeda Cc: Robin van der Gracht --- drivers/auxdisplay/Kconfig | 5 + drivers/auxdisplay/ht16k33.c | 7 ++- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/auxdisplay/Kconfig b

Re: [PATCH 09/32] auxdisplay/ht16k33: Set FBINFO_VIRTFB flag

On 2023-11-15 11:19, Thomas Zimmermann wrote: The ht16k33 driver operates on system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann Cc: Miguel Ojeda Cc: Robin van der Gracht

[ptxdist] [PATCH] optee: Add missing dependency on host-dtc

Signed-off-by: Robin van der Gracht --- platforms/optee.in | 1 + 1 file changed, 1 insertion(+) diff --git a/platforms/optee.in b/platforms/optee.in index 4e2b4eb25..371f5b237 100644 --- a/platforms/optee.in +++ b/platforms/optee.in @@ -6,6 +6,7 @@ menuconfig OPTEE select

Re: [ptxdist] [PATCH 1/3] rules: opensc: Version bumb to 0.23.0

On 13-04-2023 15:57, Michael Olbrich wrote: On Thu, Apr 13, 2023 at 09:25:54AM +0200, Robin van der Gracht wrote: ... +From 9294183e07ff4944e3f5e590f343f5727636767e Mon Sep 17 00:00:00 2001 +From: Jakub Jelen +Date: Thu, 1 Dec 2022 20:08:53 +0100 +Subject: [PATCH] pkcs11-tool: Fix private key

Re: [ptxdist] [PATCH 1/3] rules: opensc: Version bumb to 0.23.0

Hi Michael, On 12-04-2023 08:28, Michael Olbrich wrote: On Thu, Apr 06, 2023 at 04:50:14PM +0200, Robin van der Gracht wrote: Signed-off-by: Robin van der Gracht With this update pkcs11-tool (from host-opensc) does not work correctly any more. I'm getting "error: OpenSSL error durin

Re: [ptxdist] [PATCH 3/3] rules: pcsc-lite: Add option for building with USB support

On 12-04-2023 08:32, Michael Olbrich wrote: On Thu, Apr 06, 2023 at 04:50:16PM +0200, Robin van der Gracht wrote: Signed-off-by: Robin van der Gracht --- rules/pcsc-lite.in | 5 + rules/pcsc-lite.make | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/rules/pcsc

[ptxdist] [PATCH 2/3] rules: pcsc-lite: Version bumb to 1.9.8

Signed-off-by: Robin van der Gracht --- rules/pcsc-lite.make | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules/pcsc-lite.make b/rules/pcsc-lite.make index 128489aa6..d773a8bb6 100644 --- a/rules/pcsc-lite.make +++ b/rules/pcsc-lite.make @@ -15,8 +15,8 @@ PACKAGES

[ptxdist] [PATCH 3/3] rules: pcsc-lite: Add option for building with USB support

Signed-off-by: Robin van der Gracht --- rules/pcsc-lite.in | 5 + rules/pcsc-lite.make | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/rules/pcsc-lite.in b/rules/pcsc-lite.in index 016a70037..de1c288c3 100644 --- a/rules/pcsc-lite.in +++ b/rules/pcsc-lite.in @@ -18,6

[ptxdist] [PATCH 1/3] rules: opensc: Version bumb to 0.23.0

Signed-off-by: Robin van der Gracht --- rules/host-opensc.make | 2 +- rules/opensc.make | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/rules/host-opensc.make b/rules/host-opensc.make index 0319064fd..24488de38 100644 --- a/rules/host-opensc.make +++ b/rules/host

[ptxdist] [PATCH v2 1/5] python3: Version bumb to 3.11.2

Signed-off-by: Robin van der Gracht --- ...-leak-host-path-into-target-binaries.patch | 23 -- ...02-python3-prevent-host-path-leakage.patch | 43 --- patches/Python-3.10.4/series | 5 --- rules/python3.make| 7 +-- 4 files

[ptxdist] [PATCH v2 5/5] python3-yarl: Version bumb to 1.8.2

Current version has no Python3.11 support. yarl/_quoting_c.c:196:12: fatal error: longintrepr.h: No such file or directory 196 | #include "longintrepr.h" |^~~ compilation terminated. Signed-off-by: Robin van der Gracht --- rules/python3-yarl.make |

[ptxdist] [PATCH v2 4/5] python3-aiohttp: Version bumb to 3.8.4

Current version has no Python3.11 support. aiohttp/_websocket.c:198:12: fatal error: longintrepr.h: No such file or directory 198 | #include "longintrepr.h" |^~~ compilation terminated. Signed-off-by: Robin van der Gracht --- rules/python3-aiohtt

[ptxdist] [PATCH v2 2/5] python3-aiofiles: Version bumb to 0.8.0

iles/threadpool/binary.py", line 1, in File "/usr/lib/python3.11/site-packages/aiofiles/base.py", line 7, in File "/usr/lib/python3.11/site-packages/aiofiles/base.py", line 14, in AsyncBase AttributeError: module 'asyncio' has no attribute 'coroutine'. Did you mean:

[ptxdist] [PATCH v2 3/5] python3-frozenlist: Version bumb 1.3.3

Current version has no Python3.11 support. Signed-off-by: Robin van der Gracht --- rules/python3-frozenlist.make | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules/python3-frozenlist.make b/rules/python3-frozenlist.make index 68367a499..6a7114274 100644 --- a/rules

[ptxdist] [PATCH v2 0/5] Update to Python3.11

This patchset contains an update for the Python package and several Python modules for compatibility weith the new Python version. Was able to update and test several Python modules but not all of them. v2: - Remove the patches in patches/Python-3.10.4/* Signed-off-by: Robin van der Gracht

Re: [ptxdist] [PATCH 1/5] python3: Version bumb to 3.11.2

Hi Michael, On 22-03-2023 20:14, Michael Olbrich wrote: On Wed, Mar 22, 2023 at 11:13:54AM +0100, Robin van der Gracht wrote: Signed-off-by: Robin van der Gracht There are two patches for the old Python version. The second one is obsolete with the latest toolchain wrapper changes

[ptxdist] [PATCH 5/5] python3-yarl: Version bumb to 1.8.2

Current version has no Python3.11 support. yarl/_quoting_c.c:196:12: fatal error: longintrepr.h: No such file or directory 196 | #include "longintrepr.h" |^~~ compilation terminated. Signed-off-by: Robin van der Gracht --- rules/python3-yarl.make |

[ptxdist] [PATCH 3/5] python3-frozenlist: Version bumb 1.3.3

Current version has no Python3.11 support. Signed-off-by: Robin van der Gracht --- rules/python3-frozenlist.make | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules/python3-frozenlist.make b/rules/python3-frozenlist.make index 68367a499..6a7114274 100644 --- a/rules

[ptxdist] [PATCH 2/5] python3-aiofiles: Version bumb to 0.8.0

iles/threadpool/binary.py", line 1, in File "/usr/lib/python3.11/site-packages/aiofiles/base.py", line 7, in File "/usr/lib/python3.11/site-packages/aiofiles/base.py", line 14, in AsyncBase AttributeError: module 'asyncio' has no attribute 'coroutine'. Did you mean:

[ptxdist] [PATCH 1/5] python3: Version bumb to 3.11.2

Signed-off-by: Robin van der Gracht --- rules/python3.make | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/rules/python3.make b/rules/python3.make index b8cffc190..d3f872206 100644 --- a/rules/python3.make +++ b/rules/python3.make @@ -15,8 +15,8 @@ PACKAGES

[ptxdist] [PATCH 4/5] python3-aiohttp: Version bumb to 3.8.4

Current version has no Python3.11 support. aiohttp/_websocket.c:198:12: fatal error: longintrepr.h: No such file or directory 198 | #include "longintrepr.h" |^~~ compilation terminated. Signed-off-by: Robin van der Gracht --- rules/python3-aiohtt

[ptxdist] [PATCH 0/5] Update to Python3.11

This patchset contains an update for the Python package and several Python modules for compatibility weith the new Python version. Was able to update and test several Python modules but not all of them. Signed-off-by: Robin van der Gracht Robin van der Gracht (5): python3: Version bumb

Re: [PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness()

Hi Sam, On 2023-01-08 10:29, Sam Ravnborg wrote: Hi Robin. On Sat, Jan 07, 2023 at 10:02:38PM +0100, Miguel Ojeda wrote: On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint wrote: > > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to

Re: [PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness()

Hi Sam, On 2023-01-08 10:29, Sam Ravnborg wrote: Hi Robin. On Sat, Jan 07, 2023 at 10:02:38PM +0100, Miguel Ojeda wrote: On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint wrote: > > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to

[PATCH] ARM: mach-imx: Add missing ocotp dependency to protonic-imx6 platform

The protonic-imx6 board code calls imx_ocotp_read/write_field functions. Compiling without IMX_OCOTP results in a build failure. Signed-off-by: Robin van der Gracht --- arch/arm/mach-imx/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx

[PATCH] mci: imx-esdhc-common: Don't clear unhandled status bits

. Since it's not evaluated a second time, clearing it at the start of the function is sufficient so we can just remove the erroneous status write. Signed-off-by: Robin van der Gracht --- drivers/mci/imx-esdhc-common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mci/imx-esdhc

Re: Boot hangs during sdhci_transfer_data_dma

On 2022-06-21 09:46, Sascha Hauer wrote: Hi Robin, ... We should only ever clear the bits we have handled, like sdhci_transfer_data_dma() does with sdhci_write32(sdhci, SDHCI_INT_STATUS, SDHCI_INT_DMA); I just noticed that the tegra-sdmmc mci driver might have the same issue.

Re: Boot hangs during sdhci_transfer_data_dma

Hi Sascha, On 2022-06-21 09:46, Sascha Hauer wrote: Hi Robin, On Mon, Jun 20, 2022 at 04:33:02PM +0200, Robin van der Gracht wrote: Hi, Today I tried to run barebox with CONFIG_KEYBOARD_GPIO=y added to my config. and noticed my board hangs during boot. When I modify the probe function

Re: [PATCH 1/9] ARM: boards: protonic-imx6: prtvt7 hardkey inputs are active low

Hello Ahmad, On 2022-06-20 09:51, Ahmad Fatoum wrote: Hello, On 17.06.22 10:44, Marco Felsch wrote: On 22-06-17, Sascha Hauer wrote: Or, it is active low and your patch is correct :D If they are, can we add a comment or _N suffix to the names? Does barebox not have gpiod? The board code

Boot hangs during sdhci_transfer_data_dma

Hi, Today I tried to run barebox with CONFIG_KEYBOARD_GPIO=y added to my config. and noticed my board hangs during boot. When I modify the probe function to run without registering the poller[1] it boots as expected. I started digging into the code to see how far the boot gets when I do

Re: [PATCH 1/9] ARM: boards: protonic-imx6: prtvt7 hardkey inputs are active low

Hi Ahmand, On 2022-06-20 09:51, Ahmad Fatoum wrote: Hello, On 17.06.22 10:44, Marco Felsch wrote: On 22-06-17, Sascha Hauer wrote: Or, it is active low and your patch is correct :D If they are, can we add a comment or _N suffix to the names? Does barebox not have gpiod? The board code

Re: [PATCH 1/9] ARM: boards: protonic-imx6: prtvt7 hardkey inputs are active low

On 2022-06-16 18:38, Oleksij Rempel wrote: Am 16.06.22 um 18:28 schrieb Oleksij Rempel: Hi Robin, On Thu, Jun 16, 2022 at 03:11:06PM +0200, Robin van der Gracht wrote: The usb check needs to be skipped unless both keys are pressed simultaneously. Signed-off-by: Robin van der Gracht

Re: [PATCH 2/9] ARM: boards: protonic-imx6: Update comment to match a recent code update

On 2022-06-17 09:00, Sascha Hauer wrote: On Thu, Jun 16, 2022 at 03:11:07PM +0200, Robin van der Gracht wrote: Fixes: 1e817b64bc45968320597344e6b05463edd9c5e5 We don't have this commit in mainline, could you reference the corresponding upstream commit instead? Please write as aabbccddeeff

Re: [PATCH] lib: parameter: Free previous string value in param_string_set

On 2022-06-16 15:50, Sascha Hauer wrote: On Thu, Jun 16, 2022 at 02:50:40PM +0200, Robin van der Gracht wrote: When the parameter has no set function the previous (saved_value) is not freed up on completion. Signed-off-by: Robin van der Gracht --- lib/parameter.c | 4 +++- 1 file changed, 3

[PATCH 6/9] ARM: boards: protonic-imx6: Register prt-usb boot entry

it to boot.default it will always run first when the autoboot timeout expires. If the usb boot entry fails boot will just fallback to the next entry (i.e. bootchooser). Signed-off-by: Robin van der Gracht --- arch/arm/boards/protonic-imx6/board.c | 108 +++--- 1 file changed, 79

[PATCH 2/9] ARM: boards: protonic-imx6: Update comment to match a recent code update

Fixes: 1e817b64bc45968320597344e6b05463edd9c5e5 Signed-off-by: Robin van der Gracht --- arch/arm/boards/protonic-imx6/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boards/protonic-imx6/board.c b/arch/arm/boards/protonic-imx6/board.c index 8f8a0c745e

[PATCH 8/9] ARM: boards: protonic-imx6: Read serial and mac from fuses if available

Read board serial number from GP1 fuses if available and fall-back to the i2c RFID eeprom (current method) otherwise. Signed-off-by: Robin van der Gracht --- arch/arm/boards/protonic-imx6/board.c | 44 ++- 1 file changed, 37 insertions(+), 7 deletions(-) diff --git

[PATCH 3/9] ARM: boards: protonic-imx6: Free allocated autoboot_timeout string

Signed-off-by: Robin van der Gracht --- arch/arm/boards/protonic-imx6/board.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boards/protonic-imx6/board.c b/arch/arm/boards/protonic-imx6/board.c index 3116f3ac42..76c26fe296 100644 --- a/arch/arm/boards/protonic-imx6/board.c +++ b

[PATCH 0/9] ARM: boards: protonic-imx6: Updates

to avoid the race condition we now have. The patchstack also includes some minor fixes/changes I found during implementation of the above. - Robin Robin van der Gracht (9): ARM: boards: protonic-imx6: prtvt7 hardkey inputs are active low ARM: boards: protonic-imx6: Update comment to match

[PATCH 9/9] ARM: boards: protonic-imx6: Register serial_number parameter with ocotp

Signed-off-by: Robin van der Gracht --- arch/arm/boards/protonic-imx6/board.c | 39 --- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/arch/arm/boards/protonic-imx6/board.c b/arch/arm/boards/protonic-imx6/board.c index dd2c041e07..8436903fd8 100644

[PATCH 7/9] ARM: boards: protonic-imx6: Remove usb_delay from the priv struct

It's only used in one function right now. Signed-off-by: Robin van der Gracht --- arch/arm/boards/protonic-imx6/board.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/arch/arm/boards/protonic-imx6/board.c b/arch/arm/boards/protonic-imx6/board.c index 2c4f323799

[PATCH 1/9] ARM: boards: protonic-imx6: prtvt7 hardkey inputs are active low

The usb check needs to be skipped unless both keys are pressed simultaneously. Signed-off-by: Robin van der Gracht --- arch/arm/boards/protonic-imx6/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boards/protonic-imx6/board.c b/arch/arm/boards/protonic-imx6

[PATCH 4/9] ARM: boards: protonic-imx6: Always free allocated alias string

The memory required to store the string needs to be freed on success as well since it's no longer used. Signed-off-by: Robin van der Gracht --- arch/arm/boards/protonic-imx6/board.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/arm/boards/protonic-imx6

[PATCH 5/9] ARM: boards: protonic-imx6: Remove unsused argument from prt_imx6_usb_mount

Removing this unused pointer pointer relieves the caller from freeing the memory afterwards. Signed-off-by: Robin van der Gracht --- arch/arm/boards/protonic-imx6/board.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/arch/arm/boards/protonic-imx6/board.c b

[PATCH] lib: parameter: Free previous string value in param_string_set

When the parameter has no set function the previous (saved_value) is not freed up on completion. Signed-off-by: Robin van der Gracht --- lib/parameter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/parameter.c b/lib/parameter.c index adc3c7cdea..fe7e7b1ba4 100644

[ptxdist] [PATCH v2] kernel-fit: Fix dtb file inclusion

KERNEL_DTB is not set. This results in a FIT image without dtb files. Signed-off-by: Robin van der Gracht --- changes for v2: - use 'addprefix' instead of 'foreach'. rules/kernel-fit.make | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/kernel-fit.make b/rules/kernel

Re: [ptxdist] PTXCONF_RAUC_COMPATIBLE location

+%FT%T%z) \ > RAUC_BUNDLE_DESCRIPTION=$(PTXCONF_IMAGE_RAUC_DESCRIPTION) \ > RAUC_KEY="$(shell cs_get_uri update)" \ > > Upstream and in your configuration: > > PTXCONF_RAUC_COMPATIBLE="${PTXCONF_IMAGE_RAUC_COMPATIBLE}" > > and in your platformconfigs:

Re: [ptxdist] PTXCONF_RAUC_COMPATIBLE location

e time now. But recently I had to rename my platforms but I'd like to keep the compatible string the same. That is when I starded questioning the location. Kind regards, Robin van der Gracht ___ ptxdist mailing list ptxdist@pengutronix.de To unsubsc

[ptxdist] [PATCH] kernel-fit: Fix dtb file inclusion

KERNEL_DTB is not set. This results in a FIT image without device tree inclusion. Signed-off-by: Robin van der Gracht --- rules/kernel-fit.make | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/kernel-fit.make b/rules/kernel-fit.make index ffead846b..fd1ffe707 100644

Re: [ptxdist] PTXCONF_RAUC_COMPATIBLE location

Hi Bastian, On 2021-08-18 15:52, Bastian Krause wrote: Hi Robin, On 8/18/21 3:17 PM, Robin van der Gracht wrote: We're building an OS for multiple platforms. The platforms aren't compatible. Is the system.conf supposed to be identical on both platforms - apart from the compatible? If you

[ptxdist] PTXCONF_RAUC_COMPATIBLE location

in the ptxconfig (menuconfig) or would it be fine to move it to the platformconfig (next to the platform specific description PTXCONF_IMAGE_RAUC_DESCRIPTION)? Best regards, Robin van der Gracht -- Protonic Holland Factorij 36 1689AL Zwaag +31 (0)229 212928 https://www.protonic.nl

Re: [PATCH 16/17] auxdisplay: ht16k33: Add support for segment displays

On 2021-03-29 09:15, Geert Uytterhoeven wrote: Hoi Robin, On Mon, Mar 29, 2021 at 9:09 AM Robin van der Gracht wrote: On 2021-03-22 15:48, Geert Uytterhoeven wrote: > The Holtek HT16K33 LED controller is not only used for driving > dot-matrix displays, but also for driving segment di

Re: [PATCH 16/17] auxdisplay: ht16k33: Add support for segment displays

err = linedisp_register(>linedisp, dev, 4, seg->curr, + ht16k33_linedisp_update); + if (err) + goto err_remove_map_file; + + return 0; Groetjes/Kind regards, Robin van der Gracht

Re: [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support

ight device in the fbdev case and register a led device for both. This makes the code cleaner and drops a dependency but will break backwards compatibility. I'd prefer a single solution that covers both use cases, but I'm not sure about the 'breaking backwards compatibility' consequence... Groetjes / Kind regards, Robin van der Gracht

[ptxdist] [PATCH v2 2/2] optee-client: Make RPMB emulation configurable

Enabled by default for backwards compatibility. The added patch was pulled from the optee-client git repository. It will be included in the next optee-client release. Signed-off-by: Robin van der Gracht --- v2: Added the missing optee-client.in changes. ...ake-RPMB_EMU-a-conditional

[ptxdist] [PATCH 2/2] optee-client: Make RPMB emulation configurable

Enabled by default for backwards compatibility. The added patch was pulled from the optee-client git repository. It will be included in the next optee-client release. Signed-off-by: Robin van der Gracht --- ...ake-RPMB_EMU-a-conditional-assignmen.patch | 36 +++ rules/optee

[ptxdist] [PATCH 1/2] optee-client: version bump 3.5.0 -> 3.11.0

Signed-off-by: Robin van der Gracht --- rules/optee-client.make | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rules/optee-client.make b/rules/optee-client.make index 7fbebf1f1..dc76773c7 100644 --- a/rules/optee-client.make +++ b/rules/optee-client.make @@ -14,8 +14,8

[ptxdist] [PATCH] rules: optee-client: Allow enabling/disabling the rpmb emulator

Its enabled by default for backwards compatibility. Signed-off-by: Robin van der Gracht --- rules/optee-client.in | 5 + rules/optee-client.make | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/rules/optee-client.in b/rules/optee-client.in index be97b36..e5758ef

[PATCH] hab: habv4: Don't reset index when checking for more events

if there are more events of a single type than the event buffer (data) can hold. Telling the user to recompile with an incomplete additional size suggestion seems useless so I changed it to something more generic. Signed-off-by: Robin van der Gracht --- drivers/hab/habv4.c | 11 ++- 1 file

[PATCH] nvmem: ocotp: fix fusing on fsl, imx6q-ocotp compatible boards

The imx6q_ocotp_data struct is incomplete resulting in a crash when trying to read/blow fuses. Signed-off-by: Robin van der Gracht --- drivers/nvmem/ocotp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvmem/ocotp.c b/drivers/nvmem/ocotp.c index 356e9bf11..cee50955e 100644

[PATCH] media: i2c: tvp5150: Fix horizontal crop stop boundry

The value for AVID stop is relative to the width of the active video area, not the maximum register value. Zero means equal and a negative value means we're cropping on the right side. Signed-off-by: Robin van der Gracht --- drivers/media/i2c/tvp5150.c | 4 ++-- 1 file changed, 2 insertions

[PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

power key with the older SoCs, we need to send a keypress AND release when we get the power down request irq. Signed-off-by: Robin van der Gracht --- Changes v2 -> v3: - Drop alt compatible string for identifying first revision snvs hardware, read minor revision from register instead. - D

[PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

power key with the older SoCs, we need to send a keypress AND release when we get the power down request irq. Signed-off-by: Robin van der Gracht --- .../devicetree/bindings/crypto/fsl-sec4.txt | 16 -- drivers/input/keyboard/Kconfig| 2 +- drivers/input/keyboard/snvs_pwrkey.c

[PATCH v2 2/2] arm: dts: imx6qdl: snvs-pwrkey: Change compatible string

The older imx6 SoCs do not send a power key press interrupt, instead it sends a power down request interrupt when the key is released between 750ms and 5 seconds. The driver uses a different compatible string to ID the older SoCs. Signed-off-by: Robin van der Gracht --- arch/arm/boot/dts

[PATCH] input: keyboard: snvs_pwrkey: Send press and release event for i.MX6 S,DL and Q

AND release when we get the powerdown request interrupt. Signed-off-by: Robin van der Gracht --- arch/arm/boot/dts/imx6qdl.dtsi | 2 +- arch/arm/boot/dts/imx6sll.dtsi | 2 +- arch/arm/boot/dts/imx6sx.dtsi| 2 +- arch/arm/boot/dts/imx6ul.dtsi| 2 +- arch/arm/boot/dts

Re: [PATCH] auxdisplay: ht16k33: Make ht16k33_fb_fix and ht16k33_fb_var constant

On 2019-08-19 09:51, Nishka Dasgupta wrote: The static structures ht16k33_fb_fix and ht16k33_fb_var, of types fb_fix_screeninfo and fb_var_screeninfo respectively, are not used except to be copied into other variables. Hence make both of them constant to prevent unintended modification. Issue

simplefb question

.framebuffer failed with error -12 If I understand correctly, this is due to the use of ioremap_wc on a RAM region. I was hoping you could tell me what I'm doing wrong here, or if I'm looking at a bug. My mtype = MT_DEVICE_WC. (Due to the in kernel use of ioremap_wc()) My pfn = 0x19ca9 In my kernel .config i have: CONFIG_HAVE_ARCH_PFN_VALID=y Kind regards, Robin van der Gracht ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero()

gt; - return vm_insert_page(vma, vma->vm_start, > - virt_to_page(priv->fbdev.buffer)); > + return vm_map_pages_zero(vma, , 1); > } > > static struct fb_ops ht16k33_fb_ops = { Acked-by: Robin van der Gracht

Re: [PATCH] auxdisplay: ht16k33: fix potential user-after-free on module unload

> > - cancel_delayed_work(>work); > + cancel_delayed_work_sync(>work); > unregister_framebuffer(fbdev->info); > framebuffer_release(fbdev->info); > free_page((unsigned long) fbdev->buffer); Looks good Acked-by: Robin van der Gracht

Re: [PATCH v4] mmc: mxs-mmc: Introduce regulator support

On Thu, 31 Jan 2019 13:17:23 +0100 Ulf Hansson wrote: > On Thu, 31 Jan 2019 at 09:20, Robin van der Gracht wrote: > > > > On Mon, 28 Jan 2019 22:15:23 +0100 > > Ulf Hansson wrote: > > > > > On Mon, 28 Jan 2019 at 15:41, Martin Kepplinger > &g

Re: [PATCH v4] mmc: mxs-mmc: Introduce regulator support

_mmc_free; > > } > > > > ssp->clk = devm_clk_get(>dev, NULL); > > -- > > 2.20.1 > > > > BTW, you didn't really answer my earlier question about the TI WiFi > chip. Doesn't you need a special clock for WiFi chip as well? How do > you intend to manage that? I used an external 32K oscillator (SLOW_CLK) for my wl1271. Other clocks ware generated on the module. I had to supply a 'vmmc-supply' in your wl1271 devicetree node, which will be used to power on/off the wlan module. The supply should be a (delayed) GPIO controlled 'fixed-regulator' attached to the wlan_en pin on the module. 1: Documentation/devicetree/bindings/net/wireless/ti,wlcore.txt Kind regards, -- Robin van der Gracht Protonic Holland tel.: +31 (0) 229 212928 fax.: +31 (0) 229 210930 Factorij 36 / 1689 AL Zwaag

Re: [PATCH v2] mmc: mxs-mmc: Introduce regulator support

nput! > > revision history > > v1: was just a question why this hasn't gone in earlier. Not sure why it never made it. I created it for use with a wl1271 which wan't properly reset in case of a fault. Also combined with imx28. Regards, Robin van der Gracht

Re: [PATCH] mmc: mxs-mmc: Introduce regulator support

ulator_enable(reg_vmmc); > - if (ret) { > - dev_err(>dev, > - "Failed to enable vmmc regulator: %d\n", ret); > - goto out_mmc_free; > - } > - } > + if (!IS_ERR(reg_vmmc)) > + host->vmmc = reg_vmmc; what about mmc_regulator_get_supply(mmc)? If we use that the vmmc will be made available under mmv->supply->vmmc if probe was successfull instead of storing it in the drivers private struct. > > ssp->clk = devm_clk_get(>dev, NULL); > if (IS_ERR(ssp->clk)) { Robin van der Gracht

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Mon, 19 Feb 2018 08:44:17 +0100 Robin van der Gracht <ro...@protonic.nl> wrote: > On Sat, 17 Feb 2018 20:39:55 +0100 > Miguel Ojeda <miguel.ojeda.sando...@gmail.com> wrote: > > > Cc: Willy Tarreau <w...@1wt.eu> > > Cc: Geert Uytterhoeven <ge...

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Mon, 19 Feb 2018 08:44:17 +0100 Robin van der Gracht wrote: > On Sat, 17 Feb 2018 20:39:55 +0100 > Miguel Ojeda wrote: > > > Cc: Willy Tarreau > > Cc: Geert Uytterhoeven > > Cc: Linus Walleij > > Cc: Robin van der Gracht > > Cc: Paul

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Sat, 17 Feb 2018 20:39:55 +0100 Miguel Ojeda <miguel.ojeda.sando...@gmail.com> wrote: > Cc: Willy Tarreau <w...@1wt.eu> > Cc: Geert Uytterhoeven <ge...@linux-m68k.org> > Cc: Linus Walleij <tr...@df.lth.se> > Cc: Robin van der Gracht <ro...@protonic.nl&g

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Sat, 17 Feb 2018 20:39:55 +0100 Miguel Ojeda wrote: > Cc: Willy Tarreau > Cc: Geert Uytterhoeven > Cc: Linus Walleij > Cc: Robin van der Gracht > Cc: Paul Burton > Signed-off-by: Miguel Ojeda > --- > Please let me know if you agree for your files and I wi

[PATCH] auxdisplay: ht16k33: Use generic device properties function

matrix_keypad_parse_of_params() was replaced early this year. Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- Early this year Dmitry Torokhov introduced a switch to using generic device properties instead of being OF-specific. Somehow this driver wasn't included in the

[PATCH] auxdisplay: ht16k33: Use generic device properties function

matrix_keypad_parse_of_params() was replaced early this year. Signed-off-by: Robin van der Gracht --- Early this year Dmitry Torokhov introduced a switch to using generic device properties instead of being OF-specific. Somehow this driver wasn't included in the update. For reference: https

[PATCH] auxdisplay: ht16k33: Use unique prefixed i2c client device name

Static naming causes problems when multiple devices are registered. Reported-by: Michael Kaplan <m.kap...@evva.com> Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- Michael Kaplan <m.kap...@evva.com> reported the issue with his multiple ht16k33 controller setup. [

[PATCH] auxdisplay: ht16k33: Use unique prefixed i2c client device name

Static naming causes problems when multiple devices are registered. Reported-by: Michael Kaplan Signed-off-by: Robin van der Gracht --- Michael Kaplan reported the issue with his multiple ht16k33 controller setup. [ 472.124385] sysfs: cannot create duplicate filename '/class/backlight

[PATCH] auxdisplay: ht16k33: Keyscan function should be optional

keyscan should be optional to support simple LED matrix displays (output only). Reported-by: Michael Kaplan <m.kap...@evva.com> Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- Documentation/devicetree/bindings/display/ht16k33.txt | 15 +-- drivers/auxdispl

[PATCH] auxdisplay: ht16k33: Keyscan function should be optional

keyscan should be optional to support simple LED matrix displays (output only). Reported-by: Michael Kaplan Signed-off-by: Robin van der Gracht --- Documentation/devicetree/bindings/display/ht16k33.txt | 15 +-- drivers/auxdisplay/ht16k33.c | 14

Re: [PATCH] auxdisplay: ht16k33: use le16_to_cpup() to fetch LE16 data

On Wed, 29 Mar 2017 00:42:08 -0700 Dmitry Torokhov wrote: > The data read from the device is 3 little-endian words, so let's annotate > them as such and use le16_to_cpu() to convert them to host endianness - it > might turn out to be a bit more performant, and it

Re: [PATCH] auxdisplay: ht16k33: use le16_to_cpup() to fetch LE16 data

On Wed, 29 Mar 2017 00:42:08 -0700 Dmitry Torokhov wrote: > The data read from the device is 3 little-endian words, so let's annotate > them as such and use le16_to_cpu() to convert them to host endianness - it > might turn out to be a bit more performant, and it expresses the conversion > more

Re: [PATCH] auxdisplay: ht16k33: don't access uninitialized data

Signed-off-by: Arnd Bergmann <a...@arndb.de> Reviewed-by: Robin van der Gracht <ro...@protonic.nl> > --- > drivers/auxdisplay/ht16k33.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdispl

Re: [PATCH] auxdisplay: ht16k33: don't access uninitialized data

ad the data, but we are better > off not doing this, so this changes the code to only copy the data > that was actually initialized. To make sure we don't overflow the > stack with an incorrect DT, we also need to add a sanity checkin the > probe function. > > Signed-off-by: A

Re: [PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock

On Fri, 3 Mar 2017 15:14:05 +0100 Robin van der Gracht <ro...@protonic.nl> wrote: > The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register. > > Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> > Signed-off-by: Robin van der Gracht <ro...@protonic.nl>

Re: [PATCH v3] clk: imx: clk-imx6ul: The i.mx6ul has no aips_tz3 clock

On Fri, 3 Mar 2017 15:14:05 +0100 Robin van der Gracht wrote: > The clock was mapped on CG15 (gpio2_clocks) in the CCRG0 register. > > Reviewed-by: Fabio Estevam > Signed-off-by: Robin van der Gracht Sasha or Shawn would you mind pushing this patch upstream? I don't have a

[PATCH v2] clk: imx: correct uart4_serial clock name in driver for i.MX6UL

Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> Signed-off-by: Robin van der Gracht <ro...@protonic.nl> --- v2: Rebased on latest mainline drivers/clk/imx/clk-imx6ul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers

  1   2   3   >