@@ -11,6 +11,8 @@
//
//===--===//
+#include "clang/Config/config.h"
perry-ca wrote:
That was my preference too except clang/Config/config.h has a clause that it
can only be included once
@@ -11,6 +11,8 @@
//
//===--===//
+#include "clang/Config/config.h"
perry-ca wrote:
This is needed for the change in SystemZ.h to replace the hard coded `"z10"`
string with the
perry-ca wrote:
@MaskRay no worries. This brittle test issue was a reason I trying to keep the
default for zLinux unchanged by this.
I have posted a new commit that eliminates the cmake variable for z/OS.
https://github.com/llvm/llvm-project/pull/89854
perry-ca wrote:
I removed the ability to make z/OS default arch configurable at build time. We
don't really need it and this makes the code simpler.
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/89854
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 23 Apr 2024 20:16:15 -0500
Subject: [PATCH 1/2] Set the default arch for z/OS to be arch10
---
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/89854
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 23 Apr 2024 20:16:15 -0500
Subject: [PATCH] Set the default arch for z/OS to be arch10
---
perry-ca wrote:
ping @MaskRay ^^^
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/90990
These test cases are testing features not available when either targeting the
s390x-ibm-zos target or use tools/features not available on the z/OS operating
system. In a couple cases the lit test had a number
perry-ca wrote:
@MaskRay Got it.
The problem with that solution is that if you use --target you won't get the
correct arch. This would be a problem for any cross compilation. For example,
say you cross compile from zLinux (which wouldn't have the config file), the
arch would be arch8.
perry-ca wrote:
@owenca @mydeveloperday Thanks for testing on Windows and taking the time to
review the PR.
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
perry-ca wrote:
ping @MaskRay. Thanks
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
perry-ca wrote:
> We don't normally commit in clang-format with a unit test
I assume you mean "without a unit test". In this case the unit test is the
existing test cases. Some fail on z/OS because the files are not read in as
text. It's not really possible to detect this issue on other
@@ -413,8 +413,9 @@ static bool format(StringRef FileName, bool
ErrorOnIncompleteFormat = false) {
// On Windows, overwriting a file with an open file mapping doesn't work,
// so read the whole file into memory when formatting in-place.
ErrorOr> CodeOrErr =
-
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/90128
>From bf3ed6819301d9fcc7e001b9e6676d5f4ce66c4d Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Thu, 25 Apr 2024 15:58:05 -0500
Subject: [PATCH] treat text files as text files so autoconversion is done
---
perry-ca wrote:
Failed at `FAIL: BOLT :: RISCV/fake-label-no-entry.c` this time. I'll give it
a day or so and try again.
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
perry-ca wrote:
> LGTM, but check why the following test in checks failed: `FAIL: BOLT ::
> RISCV/unnamed-sym-no-entry.c`
Looks unrelated. I'm kicking off another build.
https://github.com/llvm/llvm-project/pull/90128
___
cfe-commits mailing list
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/90128
>From 2d7034366547b176f89b076eb60bcb44424fae11 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Thu, 25 Apr 2024 15:58:05 -0500
Subject: [PATCH] treat text files as text files so autoconversion is done
---
https://github.com/perry-ca edited
https://github.com/llvm/llvm-project/pull/89995
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca edited
https://github.com/llvm/llvm-project/pull/89854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/90128
To support auto-conversion on z/OS text files need to be opened as text files.
These changes will fix a number of LIT failures due to text files not being
converted to the internal code page.
- update a
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/89995
Update the wrappers for the C std headers so that they always forward to the
z/OS system headers.
>From 3c947fb397b8d5fa3744aa9eb130eac4894bd300 Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Wed, 24 Apr
perry-ca wrote:
> We are trying to remove such cmake variables in favor of configuration file.
I'm not sure which configuration file(s) you are referring to. I assume you
mean the cache files in clang/cmake/caches. If so, I don't think we want to
put it there because
https://github.com/perry-ca created
https://github.com/llvm/llvm-project/pull/89854
The default arch level on z/OS is arch10. Update the code so z/OS has arch10
without changing the default for zLinux.
>From 85da4a229ddeeb6c86ecfb0ba19ac921494a2b40 Mon Sep 17 00:00:00 2001
From: Sean Perry
perry-ca wrote:
Was this PR meant to change the behaviour for c++11/14?
https://github.com/llvm/llvm-project/pull/73018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -374,10 +376,10 @@ static __inline fp_t __compiler_rt_fmax(fp_t x, fp_t y) {
#endif
}
-#elif defined(QUAD_PRECISION) && defined(CRT_HAS_TF_MODE)
+#elif defined(QUAD_PRECISION)
perry-ca wrote:
I've put up #77981 for review.
perry-ca wrote:
Thanks. I don't have write access yet. Would you be able to merge this.
https://github.com/llvm/llvm-project/pull/77554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/77554
>From 7ba4d61bd2beda03ba0fcefc9ca5c1ff08ffd48e Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 9 Jan 2024 20:59:28 -0600
Subject: [PATCH 1/6] Generate __multc3 for z/OS
---
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/77554
>From 7ba4d61bd2beda03ba0fcefc9ca5c1ff08ffd48e Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 9 Jan 2024 20:59:28 -0600
Subject: [PATCH 1/5] Generate __multc3 for z/OS
---
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/77554
>From 7ba4d61bd2beda03ba0fcefc9ca5c1ff08ffd48e Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 9 Jan 2024 20:59:28 -0600
Subject: [PATCH 1/4] Generate __multc3 for z/OS
---
https://github.com/perry-ca updated
https://github.com/llvm/llvm-project/pull/77554
>From 7ba4d61bd2beda03ba0fcefc9ca5c1ff08ffd48e Mon Sep 17 00:00:00 2001
From: Sean Perry
Date: Tue, 9 Jan 2024 20:59:28 -0600
Subject: [PATCH 1/3] Generate __multc3 for z/OS
---
@@ -976,6 +976,46 @@ void CodeGenModule::Release() {
Context.getTypeSizeInChars(Context.getWideCharType()).getQuantity();
getModule().addModuleFlag(llvm::Module::Error, "wchar_size", WCharWidth);
+ if (getTriple().isOSzOS()) {
+
https://github.com/perry-ca approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/72906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
32 matches
Mail list logo
