[Yahoo-eng-team] [Bug 1860560] [NEW] [ovn] lsp_set_address Exception possible when passed empty list of addresses

2020-01-22 Thread Terry Wilson
futurist.periodics TypeError: address must be router/unknown/dynamic/ethaddr ipaddr... ** Affects: neutron Importance: Undecided Assignee: Terry Wilson (otherwiseguy) Status: In Progress -- You received this bug notification because you are a member of Yahoo! Engineering Team, w

[Yahoo-eng-team] [Bug 1843269] Re: Nova notifier called even if set to False

2019-09-16 Thread Terry Wilson
** Also affects: networking-ovn Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1843269 Title: Nova notifier called even if set to False

[ovs-dev] [PATCH] Add a __str__ method to idl.Row

2019-09-03 Thread Terry Wilson
It's sometimes handy to log an entire Row object, so this just adds a string representation of the object as: Tablename(col1=val1, col2=val2, ..., coln=valn) Signed-off-by: Terry Wilson --- python/ovs/db/idl.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/python/ovs/db/idl.py b

Re: [ovs-dev] [PATCH v2] Shutdown SSL connection before closing socket

2019-07-25 Thread Terry Wilson
Thanks! Could I get a backport to whatever branches backports are still available for? I tested that it applied cleanly on 2.9 and passed tests there. That code hasn't changed in a while. On Tue, Jul 16, 2019 at 12:20 PM Ben Pfaff wrote: > On Thu, Jul 11, 2019 at 08:00:20AM -0500, Terry Wil

Re: [ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

2019-07-17 Thread Terry Wilson
Is this just waiting on a couple of line length issues to be fixed? Or do those really matter? On Tue, Jul 9, 2019 at 3:10 AM 0-day Robot wrote: > Bleep bloop. Greetings Michele Baldessari, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some

Re: [ovs-dev] [PATCH] Shutdown SSL connection before closing socket

2019-07-11 Thread Terry Wilson
; On Wed, Jul 10, 2019 at 11:07:16AM -0500, Terry Wilson wrote: > > Without shutting down the SSL connection, log messages like: > > > > stream_ssl|WARN|SSL_read: unexpected SSL connection close > > jsonrpc|WARN|ssl:127.0.0.1:47052: receive error: Protocol error > > rec

[ovs-dev] [PATCH v2] Shutdown SSL connection before closing socket

2019-07-11 Thread Terry Wilson
. This just adds an SSLStream.close() that calls shutdown() and ignores SSL errors, the same way that lib/stream-ssl.c does in ssl_close(). Signed-off-by: Terry Wilson --- python/ovs/stream.py | 8 1 file changed, 8 insertions(+) diff --git a/python/ovs/stream.py b/python/ovs/stream.py

Re: [ovs-dev] [PATCH] Shutdown SSL connection before closing socket

2019-07-10 Thread Terry Wilson
wrote: > On 7/10/19 12:11 PM, Terry Wilson wrote: > > An example of a reproducer script attached. If you enable SSL and OVN w/ > > the sandbox and run it, looking in the sandbox/nb1.log you'll see the > > disconnect errors that the patch makes go away. > > > > Hi

Re: [ovs-dev] [PATCH] Shutdown SSL connection before closing socket

2019-07-10 Thread Terry Wilson
An example of a reproducer script attached. If you enable SSL and OVN w/ the sandbox and run it, looking in the sandbox/nb1.log you'll see the disconnect errors that the patch makes go away. On Wed, Jul 10, 2019 at 11:07 AM Terry Wilson wrote: > Without shutting down the SSL connection,

[ovs-dev] [PATCH] Shutdown SSL connection before closing socket

2019-07-10 Thread Terry Wilson
. This just adds an SSLStream.close() that calls shutdown() and ignores read/write errors. Signed-off-by: Terry Wilson --- python/ovs/stream.py | 8 1 file changed, 8 insertions(+) diff --git a/python/ovs/stream.py b/python/ovs/stream.py index c15be4b..fd1045e 100644 --- a/python/ovs

[ovs-dev] [PATCH] Un-revert Work around Python/C JSON unicode differences

2019-01-14 Thread Terry Wilson
. The pure Python JSON parser currently operates on unicode, so it expects that Parser.feed() returns a number of characters. This difference leads to parsing errors when unicode characters are passed to the C JSON parser from Python. Signed-off-by: Terry Wilson --- python/ovs/json.py| 10

Re: [ovs-dev] [PATCH] Revert "Test the Python C JSON extension"

2018-12-13 Thread Terry Wilson
Sorry I missed this...thanks for the in-depth analysis! On Tue, Oct 16, 2018 at 3:16 AM Lam, Tiago wrote: > > On 15/10/2018 17:44, Ilya Maximets wrote: > > This reverts commit a7be68a4d77791bbe02c37f7ad8ae60b02e5679e > > and a subsequent commit 4617d1f6bd24c543f533f6485b42ebca6b0a8371. > > There

[ovs-dev] [PATCH] Correct documentation for getting DB's cid

2018-12-13 Thread Terry Wilson
Signed-off-by: Terry Wilson --- Documentation/ref/ovsdb.7.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/ref/ovsdb.7.rst b/Documentation/ref/ovsdb.7.rst index f891309..c43fe17 100644 --- a/Documentation/ref/ovsdb.7.rst +++ b/Documentation/ref/ovsdb.7.rst

[ovs-dev] Point releases

2018-10-11 Thread Terry Wilson
Just curious what the schedule/process for doing point releases was? I noticed that there are 100 patches in branch-2.9 after 2.9.2 and 70 in branch-2.10 after 2.10.0. Is it just kind of "when it seems right?" I ask because there was python-ovs patch that we'd like to get into a release (it's been

[Yahoo-eng-team] [Bug 1796898] Re: db_get_val can return None which isn't iterable

2018-10-10 Thread Terry Wilson
Going to mark as invalid because in the case we are hitting, it's probably good that an exception is raised. ** Changed in: neutron Status: In Progress => Invalid -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron.

Re: [ovs-dev] [PATCH 2/2 v2] Work around Python/C JSON unicode differences

2018-10-09 Thread Terry Wilson
On Tue, Oct 9, 2018 at 11:28 AM Terry Wilson wrote: > > Anyone have time to look at these? Huh, apparently they hadn't shown up due to being marked as spam or something. Re-sent. ___ dev mailing list d...@openvswitch.org https://mail.openvswit

[ovs-dev] [PATCH 2/2 v2] Work around Python/C JSON unicode differences

2018-10-09 Thread Terry Wilson
unicode characters are passed to the C JSON parser from Python. Signed-off-by: Terry Wilson --- python/ovs/jsonrpc.py | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/python/ovs/jsonrpc.py b/python/ovs/jsonrpc.py index 4873cff..1323ba7 100644 --- a/python/ovs/jsonrpc.py

[ovs-dev] [PATCH 1/2 v2] Test the Python C JSON extension

2018-10-09 Thread Terry Wilson
/python directory and makes the tests configurable to use both JSON backends. There are some unicode failures in the C JSON extension that I left unfixed in this patch to make it easy to show run the new tests on broken code. The next patch in this set works around the issue. Signed-off-by: Terry

Re: [ovs-dev] [PATCH 2/2 v2] Work around Python/C JSON unicode differences

2018-10-09 Thread Terry Wilson
Anyone have time to look at these? On Mon, Oct 1, 2018 at 11:24 AM Terry Wilson wrote: > > The OVS C-based JSON parser operates on bytes, so the parser_feed > function returns the number of bytes that are processed. The pure > Python JSON parser currently operates on unicode, s

[Yahoo-eng-team] [Bug 1796898] [NEW] db_get_val can return None which isn't iterable

2018-10-09 Thread Terry Wilson
d() tries to iterate over this and throws an Exception. ** Affects: neutron Importance: Undecided Assignee: Terry Wilson (otherwiseguy) Status: In Progress -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscrib

[ovs-dev] [PATCH 2/2] Work around Python/C JSON unicode differences

2018-09-19 Thread Terry Wilson
unicode characters are passed to the C JSON parser from Python. Signed-off-by: Terry Wilson --- python/ovs/jsonrpc.py | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/python/ovs/jsonrpc.py b/python/ovs/jsonrpc.py index 4873cff..1323ba7 100644 --- a/python/ovs/jsonrpc.py

[ovs-dev] [PATCH 1/2] Test the Python C JSON extension

2018-09-19 Thread Terry Wilson
/python directory and makes the tests configurable to use both JSON backends. There are some unicode failures in the C JSON extension that I left unfixed in this patch to make it easy to show run the new tests on broken code. The next patch in this set works around the issue. Signed-off-by: Terry

[ovs-dev] [PATCH] Add ovs.compat module to python package

2018-08-31 Thread Terry Wilson
Signed-off-by: Terry Wilson Signed-off-by: Ben Pfaff Acked-by: Timothy Redaelli (cherry picked from commit 2360464d629de3acacabd960ffc02fbb5081028d) --- python/setup.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/setup.py b/python/setup.py index 0e86834

[ovs-dev] [PATCH][backport] Add ovs.compat module to python package

2018-08-31 Thread Terry Wilson
The Python multi-column index patch also made it into 2.9, so the setup.py fix needs backported there as well. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Fix socket permissions on Linux

2018-08-16 Thread Terry Wilson
>> It doesn't (and never has) on my Centos 7 machine. I ran into this a >> couple of years ago and ended up just working around it. As an example >> after make rpm-fedora and installing: >> [centos@test x86_64]$ ls -al /var/run/openvswitch/db.sock >> srwxr-x---. 1 openvswitch openvswitch0 Aug

Re: [ovs-dev] [PATCH] Fix socket permissions on Linux

2018-08-16 Thread Terry Wilson
> Gather 'round folks, and let me tell you the tale of a series long > ago posted: > > https://mail.openvswitch.org/pipermail/ovs-dev/2016-August/321866.html > > Something... something ... black magic... > I think the fchmod needs to happen after the bind for the permissions > to actually be

Re: [ovs-dev] [PATCH] Fix socket permissions on Linux

2018-08-16 Thread Terry Wilson
>> Surely there's a better way to do this. > > I *hope* so. I mean it certainly seems like something one would want > to be able to do, but I remember looking for a couple of days 2 years > ago and giving up. umask seemed like the only reliable option. > Whatever the solution is, fchmod is *not*

Re: [ovs-dev] [PATCH] Fix socket permissions on Linux

2018-08-16 Thread Terry Wilson
On Thu, Aug 16, 2018 at 4:57 PM, Ben Pfaff wrote: > On Thu, Aug 16, 2018 at 07:55:09PM +0000, Terry Wilson wrote: >> Unix sockets were not being created with the permission 0770, >> instead using the current umask value. The manpage for fchmod() >> states that that if filed

[ovs-dev] [PATCH] Add ovs.compat module to python package

2018-08-10 Thread Terry Wilson
Signed-off-by: Terry Wilson --- python/setup.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/setup.py b/python/setup.py index 0e86834..b52657d 100644 --- a/python/setup.py +++ b/python/setup.py @@ -63,7 +63,8 @@ setup_args = dict( url='http

Re: [ovs-dev] [PATCH v2 1/2] table: append newline when printing tables

2018-08-08 Thread Terry Wilson
ot;table: New function table_format() for formatting a > table as a string.") > Cc: Ben Pfaff > Cc: Jakub Sitnicki > Reported-by: Terry Wilson > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1608508 > Signed-off-by: Aaron Conole > Suggested-by: Ben Pfaff > -

[tosdr:4607] Change.org

2018-05-28 Thread Terry Wilson
https://www.change.org/policies/privacy Holy crap, it's huge. -- [!!] Please see https://edit.tosdr.org -- this is where new contributions should be submitted and discussed tosdr.org | twitter.com/tosdr | github.com/tosdr --- You received this message because you are subscribed to the Google

[Yahoo-eng-team] [Bug 1687074] Re: Sometimes ovsdb fails with "tcp:127.0.0.1:6640: error parsing stream"

2018-04-18 Thread Terry Wilson
I guess incomplete is still "open", so invalid it is. ** Changed in: ovsdbapp Status: Incomplete => Invalid -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1687074 Title:

Re: [ovs-dev] [PATCH v2] Add multi-column index support for the Python IDL

2018-04-13 Thread Terry Wilson
One could argue that if if distro packaging is the issue, then distros could patch in the simple try/except ImportError and add the sortedcontainer code like I did above. But, if this works for the ovs team and distro folks, I'm happy with it. Terry ___

Re: [ovs-dev] [RFC] [PATCH] 1/1 Add multi-column index support for the Python IDL

2018-04-11 Thread Terry Wilson
03:03:03PM -0500, twil...@redhat.com wrote: >> > > From: Terry Wilson <twil...@redhat.com> >> > > >> > > This adds multi-column index support for the Python IDL that is >> > > similar to the feature in the C IDL. >> > > >> > >

Re: [ovs-dev] [PATCH v2] python: avoid useless JSON conversion to enhance performance

2018-02-28 Thread Terry Wilson
...@redhat.com> > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2018-February/046263.html > Signed-off-by: Daniel Alvarez <dalva...@redhat.com> > Acked-by: Terry Wilson <twil...@redhat.com> > Acked-by: Han Zhou <hzh...@ebay.com> > --- > pytho

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-02-27 Thread Terry Wilson
On Tue, Feb 27, 2018 at 9:25 AM, Daniel Alvarez wrote: > This patch removes a useless conversion to/from JSON in the > processing of any 'modify' operations inside the process_update2 > method in Python IDL implementation. > > Previous code will make resources creation take

Re: [openstack-dev] [release][requirements][FFE] Release ovsdbapp 0.9.1

2018-02-02 Thread Terry Wilson
On Fri, Feb 2, 2018 at 4:30 PM, Matthew Thode <prometheanf...@gentoo.org> wrote: > On 18-02-02 15:59:42, Terry Wilson wrote: >> ovsdbapp 0.9.1 (review https://review.openstack.org/#/c/539489/) has a >> gate-fixing one-line fix (https://review.openstack.org/#/c/537241

[openstack-dev] [release][requirements][FFE] Release ovsdbapp 0.9.1

2018-02-02 Thread Terry Wilson
ovsdbapp 0.9.1 (review https://review.openstack.org/#/c/539489/) has a gate-fixing one-line fix (https://review.openstack.org/#/c/537241). Can I get a FFE for bumping the requirements to ovsdbapp 0.9.1 once the package is built? Terry

[Yahoo-eng-team] [Bug 1741889] Re: functional: DbAddCommand sometimes times out after 10 seconds

2018-01-23 Thread Terry Wilson
** Also affects: ovsdbapp Importance: Undecided Status: New -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1741889 Title: functional: DbAddCommand sometimes times out after 10

[ovs-dev] OVS no longer compiles on Centos 7 (gcc 4.8.5)

2017-11-30 Thread Terry Wilson
As of the ETH_ADDR_C patch (https://patchwork.ozlabs.org/patch/842364/), ovs won't compile on gcc 4.8.5 which ships with Centos 7. It works fine on 7.2.1 which ships in Fedora 27. lots of: ../include/openvswitch/types.h:186:47: error: initializer element is not constant #define

Re: [openstack-dev] [Neutron] Denver Team Dinner

2017-09-12 Thread Terry Wilson
+1 On Tue, Sep 12, 2017 at 6:23 PM, Miguel Lavalle wrote: > Dear Neutrinos, > > Our social event will take place on Thursday September 12th at 7:30pm. The > venue is going to be https://www.famousdaves.com/Denver-Stapleton. It is > located 0.4 miles from the Renaissance

[ovs-dev] [PATCH v1 1/1] Build the JSON C extension for the Python lib

2017-08-17 Thread Terry Wilson
The JSON C extensions performs much better than the pure Python version, so build it when producing RPMs. Signed-off-by: Terry Wilson <twil...@redhat.com> --- rhel/openvswitch-fedora.spec.in | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff

[ovs-dev] [PATCH] Fix flake8 check

2017-05-18 Thread Terry Wilson
Stop occluding the previous definition of filename. Signed-off-by: Terry Wilson <twil...@redhat.com> --- Documentation/conf.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/conf.py b/Documentation/conf.py index d70ee6b..62531dd 100644 --- a/Documen

[Yahoo-eng-team] [Bug 1684277] [NEW] Use ovsdbapp for Neutron OVSDB API

2017-04-19 Thread Terry Wilson
Public bug reported: The OVSDB API has been split out into its own project: ovsdbapp. Neutron should use ovsdbapp, but still provide a deprecated ability to import the OVSDB API for projects that have not yet been switched over to using ovsdbapp. ** Affects: neutron Importance: Undecided

Re: [ovs-dev] [PATCH v2] python: Allow tuning the session probe_interval from IDL

2017-04-10 Thread Terry Wilson
ovsdb-server has the ability to create additional servers based on a DB contents. For the Open_vSwitch schema, that's the Manager table and the Open_vSwitch table's manager_options column. The ovsdb-server code refers to these as "remotes". If these remotes have a max_backoff/inactivity_probe

[Bug 1672522] [NEW] The python-openvswitch package should build the json C extension

2017-03-13 Thread Terry Wilson
Public bug reported: The C extension wrapping OVS's own json parser is 60x faster than the pure-python version currently being used. Profiling shows JSON parsing to be the biggest bottleneck using python-openvswitch IDL library. setuptools can build the extension as long as the python-dev

Re: [openstack-dev] [neutron] - Neutron team social in Atlanta on Thursday

2017-02-20 Thread Terry Wilson
+1 On Mon, Feb 20, 2017 at 12:57 PM, Lihi Wish wrote: > +1 > > On Feb 20, 2017 1:13 PM, "Omer Anson" wrote: >> >> +1 >> >> On 20 February 2017 at 19:34, Bhatia, Manjeet S >> wrote: >>> >>> +1 >>> >>> >>> >>> From: Kevin Benton

Re: [openstack-dev] [neutron] - Neutron team social in Atlanta on Thursday

2017-02-17 Thread Terry Wilson
+1 On Feb 17, 2017 1:22 PM, "Kevin Benton" wrote: > Hi all, > > I'm organizing a Neutron social event for Thursday evening in Atlanta > somewhere near the venue for dinner/drinks. If you're interested, please > reply to this email with a "+1" so I can get a general count for a

[ovs-dev] [PATCH 1/1] python: Fix logic resulting in too many unexpected replies Fix logic resulting in too many unexpected replies

2017-02-17 Thread Terry Wilson
. Signed-off-by: Terry Wilson <twil...@redhat.com> --- python/ovs/db/idl.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py index e43457c..b7b5e1c 100644 --- a/python/ovs/db/idl.py +++ b/python/ovs/db/idl.py @@ -649,6 +649,7 @@ class Idl(

[Yahoo-eng-team] [Bug 1665061] [NEW] keepalived sanity check tries to disable process monitoring, but doesn't

2017-02-15 Thread Terry Wilson
Public bug reported: KeepalivedIPv6Test.start_keepalived_process overrides AGENT.check_child_processes_interval to 0 in an attempt to disable process monitoring. The default value is 60 and the decision on whether to spawn the process monitoring thread is made in ProcessMonitor.__init__(), which

[Yahoo-eng-team] [Bug 1642764] [NEW] db_add() as part of transaction in new object fails native interface

2016-11-17 Thread Terry Wilson
', constants.OPENFLOW10)) the native interface fails due to the 'protocols' column not yet existing on the temporary ovsdb object. ** Affects: neutron Importance: Undecided Assignee: Terry Wilson (otherwiseguy) Status: In Progress -- You received this bug notification because you

[ovs-dev] Proposal to move the Python lib to its own repo

2016-11-15 Thread Terry Wilson
/6766131b42807829ea78dbc43d164db8926030e7 commit 6766131b42807829ea78dbc43d164db8926030e7 Author: Terry Wilson <twil...@redhat.com> Date: Mon Nov 14 16:03:43 2016 -0600 Move python dir to a submodule diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 000..db21481 --- /dev/null +++ b/.gitm

[Yahoo-eng-team] [Bug 1634258] [NEW] Errors in the upstream OVS Python IDL lib are not logged anywhere

2016-10-17 Thread Terry Wilson
debugging difficult. ** Affects: neutron Importance: Undecided Assignee: Terry Wilson (otherwiseguy) Status: In Progress -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs

Re: [openstack-dev] [all][python3] use of six.iteritems()

2016-09-14 Thread Terry Wilson
On Sep 13, 2016 10:42 PM, "Kevin Benton" wrote: > > >All performance matters. All memory consumption matters. Being wasteful over a purely aesthetic few extra characters of code is silly. > > Isn't the logical conclusion of this to write everything in a different language? :)

Re: [openstack-dev] [all][python3] use of six.iteritems()

2016-09-13 Thread Terry Wilson
On Tue, Sep 13, 2016 at 6:31 PM, Jay Pipes <jaypi...@gmail.com> wrote: > On 09/13/2016 01:40 PM, Terry Wilson wrote: >> >> On Thu, Jun 11, 2015 at 8:33 AM, Sean Dague <s...@dague.net> wrote: >>> >>> On 06/11/2015 09:02 AM, Jay Pipes wrote: >>&

Re: [openstack-dev] [all][python3] use of six.iteritems()

2016-09-13 Thread Terry Wilson
On Thu, Jun 11, 2015 at 8:33 AM, Sean Dague wrote: > On 06/11/2015 09:02 AM, Jay Pipes wrote: >> On 06/11/2015 01:16 AM, Robert Collins wrote: >>> But again - where in OpenStack does this matter the slightest? >> >> Precisely. I can't think of a single case where we are iterating

Re: [openstack-dev] [all][python3] use of six.iteritems()

2016-09-13 Thread Terry Wilson
On Wed, Jun 10, 2015 at 4:41 AM, Robert Collins wrote: > On 10 June 2015 at 21:30, Ihar Hrachyshka wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA256 >> >> On 06/10/2015 02:15 AM, Robert Collins wrote: >>> I'm very glad folk are working

[Yahoo-eng-team] [Bug 1615105] [NEW] ovsdb's db_create results not uniform across vsctl and native implementations

2016-08-19 Thread Terry Wilson
of it. ** Affects: neutron Importance: Undecided Assignee: Terry Wilson (otherwiseguy) Status: In Progress -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1615105 Title

Re: [ovs-dev] [PATCH v3 0/3] vhost-user: Add the ability to control ownership/permissions

2016-08-12 Thread Terry Wilson
On Thu, Aug 11, 2016 at 8:53 PM, Aaron Conole wrote: > I've been working on a better solution - it occurred to me that since > this is being done for linux-only anyway, I might as well do this with > systemd. I can get almost everything done with no C code changes, thus >

Re: [ovs-dev] [PATCH v5] JSON serialization via Python's json lib

2016-07-29 Thread Terry Wilson
On Fri, Jul 29, 2016 at 12:27 AM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Jul 25, 2016 at 06:55:49PM -0500, Terry Wilson wrote: >> Sigh. And of course I had libopenvswitch installed on the system as >> well and removing it breaks building the extensions with the above >&

Re: [openstack-dev] [Neutron] Proposing Jakub Libosvar for testing core

2016-07-27 Thread Terry Wilson
On Tue, Jul 26, 2016 at 10:04 AM, Jakub Libosvar wrote: > On 26/07/16 16:56, Assaf Muller wrote: >> >> We've hit critical mass from cores interesting in the testing area. >> >> Welcome Jakub to the core reviewer team. May you enjoy staring at the >> Gerrit interface and

[ovs-dev] [PATCH] JSON serialization via Python's json lib

2016-07-25 Thread Terry Wilson
-by: Terry Wilson <twil...@redhat.com> --- python/ovs/json.py | 106 + tests/json.at | 26 ++--- 2 files changed, 30 insertions(+), 102 deletions(-) diff --git a/python/ovs/json.py b/python/ovs/json.py index ea0400a..ddf5dd2

[ovs-dev] [PATCH] JSON serialization via Python's json lib

2016-07-25 Thread Terry Wilson
This patch removes the json extension build system changes since they aren't even related to the serialization change, which is pure-Python. Terry Wilson (1): JSON serialization via Python's json lib python/ovs/json.py | 106 + tests/json.at

Re: [ovs-dev] [PATCH v5] JSON serialization via Python's json lib

2016-07-25 Thread Terry Wilson
On Fri, Jul 22, 2016 at 9:57 PM, Terry Wilson <twil...@redhat.com> wrote: > There is no particularly good reason to use our own Python JSON > serialization implementation when serialization can be done faster > with Python's built-in JSON library. > > A few tests were changed du

[ovs-dev] [PATCH v5] JSON serialization via Python's json lib

2016-07-25 Thread Terry Wilson
-by: Terry Wilson <twil...@redhat.com> --- configure.ac | 2 + m4/openvswitch.m4 | 47 python/automake.mk | 27 +- python/ovs/json.py | 106 + tests/json.at | 26 ++--- 5 files c

[ovs-dev] [PATCH] JSON serialization via Python's json lib

2016-07-25 Thread Terry Wilson
I noticed that with the previous patch, in testing 'make install' with patch to move json.h, I had forgotten to remove the installed headers. Removing the installed headers revealed that this patch still didn't build properly from a separate build directory. This time it *should* work. Terry

[ovs-dev] [PATCH 1/2] Move lib/json.h to include/openvswitch

2016-07-12 Thread Terry Wilson
id not use anything from there, but rather from include/openvswitch/util.h. Fixing that required including util.h in several C files mostly due to OVS_NOT_REACHED and things like xmalloc. Signed-off-by: Terry Wilson <twil...@redhat.com> --- include/openvswitch/automake.mk | 3 + include/op

[ovs-dev] [PATCH 2/2] JSON serialization via Python's json lib

2016-07-12 Thread Terry Wilson
-by: Terry Wilson <twil...@redhat.com> --- configure.ac | 2 + m4/openvswitch.m4 | 47 python/automake.mk | 26 - python/ovs/json.py | 106 + tests/json.at | 26 ++--- 5 files c

[ovs-dev] [PATCH 0/2] Python JSON parser improvements

2016-07-12 Thread Terry Wilson
These patches should address the previous issue with building the Python wrapper when builddir != srcdir. It also ensures that the wrapper can be properly built by pip from out-of-tree by ensuring that json.h is added to include/openvswitch/json.h. Terry Wilson (2): Move lib/json.h to include

Re: [openstack-dev] [neutron][ovs] The way we deal with MTU

2016-06-13 Thread Terry Wilson
> So basically, as long as we try to plug ports with different MTUs into the > same bridge, we are utilizing a bug in Open vSwitch, that may break us any > time. > > I guess our alternatives are: > - either redesign bridge setup for openvswitch to e.g. maintain a bridge per > network; > - or

Bug#826780: [ovs-dev] Bug#826780: Please package OVS >= 2.6.0.dev1

2016-06-10 Thread Terry Wilson
On Thu, Jun 9, 2016 at 10:04 PM, Joe Stringer wrote: >> On Thu, Jun 9, 2016 at 3:07 AM, Russell Bryant wrote: >>> The real solution to making this less awkward would be to split the Python >>> library out of the OVS git tree so that it can be released independently

[ovs-dev] Bug#826780: Bug#826780: Please package OVS >= 2.6.0.dev1

2016-06-10 Thread Terry Wilson
On Thu, Jun 9, 2016 at 10:04 PM, Joe Stringer wrote: >> On Thu, Jun 9, 2016 at 3:07 AM, Russell Bryant wrote: >>> The real solution to making this less awkward would be to split the Python >>> library out of the OVS git tree so that it can be released independently

[ovs-dev] [PATCH v5] JSON serialization via Python's json lib

2016-06-10 Thread Terry Wilson
-by: Terry Wilson <twil...@redhat.com> --- configure.ac | 2 + m4/openvswitch.m4 | 47 python/automake.mk | 26 - python/ovs/json.py | 106 + tests/json.at | 26 ++--- 5 files c

[ovs-dev] [PATCH v4] JSON serialization via Python's json lib

2016-06-09 Thread Terry Wilson
-by: Terry Wilson <twil...@redhat.com> --- configure.ac | 2 + m4/openvswitch.m4 | 47 python/automake.mk | 22 +++ python/ovs/json.py | 106 + tests/json.at | 26 ++--- 5 files c

[ovs-dev] Bug#826780: Bug#826780: Please package OVS >= 2.6.0.dev1

2016-06-09 Thread Terry Wilson
On Thu, Jun 9, 2016 at 3:07 AM, Russell Bryant wrote: > The real solution to making this less awkward would be to split the Python > library out of the OVS git tree so that it can be released independently of > OVS itself. That way a proper verison could be released that

Bug#826780: [ovs-dev] Bug#826780: Please package OVS >= 2.6.0.dev1

2016-06-09 Thread Terry Wilson
On Thu, Jun 9, 2016 at 3:07 AM, Russell Bryant wrote: > The real solution to making this less awkward would be to split the Python > library out of the OVS git tree so that it can be released independently of > OVS itself. That way a proper verison could be released that

[ovs-dev] [PATCH 3/3] JSON serialization via Python's json lib

2016-06-08 Thread Terry Wilson
-by: Terry Wilson <twil...@redhat.com> --- configure.ac | 2 + m4/openvswitch.m4 | 47 python/automake.mk | 22 +++ python/ovs/json.py | 106 + tests/json.at | 26 ++--- 5 files c

[ovs-dev] [PATCH 2/3] Add optional C extension wrapper for Python JSON parsing

2016-06-08 Thread Terry Wilson
-off-by: Terry Wilson <twil...@redhat.com> --- Makefile.am| 2 +- python/automake.mk | 3 + python/ovs/_json.c | 268 + python/ovs/json.py | 11 +++ python/setup.py| 51 +- 5 files changed, 332 insertions(+), 3 del

[ovs-dev] [PATCH 1/3] Ensure significand remains an integer in Python3 json parser

2016-06-08 Thread Terry Wilson
in Python 2 and 11.0 in Python 3. Switching to the // operator resolves this difference. The JSON tests do not catch this difference because the built-in serializer prints floats with the %.15g format which will convert floats with no fractional part to an integer representation. Signed-off-by

[ovs-dev] [PATCH v4 0/3] Python JSON improvements

2016-06-08 Thread Terry Wilson
, the build system changes are resolved in this version. Terry Wilson (3): Ensure significand remains an integer in Python3 json parser Add optional C extension wrapper for Python JSON parsing JSON serialization via Python's json lib Makefile.am| 2 +- configure.ac | 2 + m4

[ovs-dev] [PATCH v3 0/3] Python JSON improvements

2016-05-31 Thread Terry Wilson
, the build system changes are resolved in this version. Terry Wilson (3): Ensure significand remains an integer in Python3 json parser Add optional C extension wrapper for Python JSON parsing JSON serialization via Python's json lib Makefile.am| 2 +- configure.ac | 2 + m4

[ovs-dev] [PATCH 3/3] JSON serialization via Python's json lib

2016-05-31 Thread Terry Wilson
There is no particularly good reason to use our own Python JSON serialization implementation when serialization can be done faster with Python's built-in JSON library. A few tests were changed due to Python's default JSON library returning slightly more precise floating point numbers. ---

[ovs-dev] [PATCH 1/3] Ensure significand remains an integer in Python3 json parser

2016-05-31 Thread Terry Wilson
The / operation in Python 2 is "floor division" for int/long types while in Python 3 is "true division". This means that the significand can become a float with the existing code in Python 3. This, in turn, can result in a parse of something like [1.10e1] returning 11 in Python 2 and 11.0 in

[ovs-dev] [PATCH 2/3] Add optional C extension wrapper for Python JSON parsing

2016-05-31 Thread Terry Wilson
The pure Python in-tree JSON parser is *much* slower than the in-tree C JSON parser. A local test parsing a 100Mb JSON file showed the Python version taking 270 seconds. With the C wrapper, it took under 4 seconds. The C extension will be used automatically if it can be built. If the extension

Re: [ovs-dev] [PATCH v2 0/2] Python JSON improvements

2016-05-23 Thread Terry Wilson
On Wed, May 18, 2016 at 8:12 PM, Ben Pfaff wrote: > These patches apply cleanly but they cause test failures for me, see > below. Maybe that is because of the issue you mentioned above? Yeah, these test issues are because the C extension ends up not getting built automatically.

[ovs-dev] [PATCH v2 2/2] JSON serialization via Python's json lib

2016-05-10 Thread Terry Wilson
There is no particularly good reason to use our own Python JSON serialization implementation when serialization can be done faster with Python's built-in JSON library. A few tests were changed due to Python's default JSON library returning slightly more precise floating point numbers and

[ovs-dev] [PATCH v2 1/2] Add optional C extension wrapper for Python JSON parsing

2016-05-10 Thread Terry Wilson
The pure Python in-tree JSON parser is *much* slower than the in-tree C JSON parser. A local test parsing a 100Mb JSON file showed the Python version taking 270 seconds. With the C wrapper, it took under 4 seconds. The C extension will be used automatically if it can be built. If the extension

[ovs-dev] [PATCH v2 0/2] Python JSON improvements

2016-05-10 Thread Terry Wilson
and wrapped versions, so theoretically I'd need tests to handle both cases. Anyone have any ideas? Terry Wilson (2): Add optional C extension wrapper for Python JSON parsing JSON serialization via Python's json lib Makefile.am| 2 +- python/automake.mk | 3 + python/ovs/_json.c | 266

[ovs-dev] [PATCH 2/2] JSON serialization via Python's json lib

2016-05-09 Thread Terry Wilson
There is no particularly good reason to use our own Python JSON serialization implementation when serialization can be done faster with Python's built-in JSON library. A few tests were changed due to Python's default JSON library returning slightly more precise floating point numbers and

[ovs-dev] [PATCH 1/2] Add optional C extension wrapper for Python JSON parsing

2016-05-09 Thread Terry Wilson
The pure Python in-tree JSON parser is *much* slower than the in-tree C JSON parser. A local test parsing a 100Mb JSON file showed the Python version taking 270 seconds. With the C wrapper, it took 4 seconds. The C extension will be used automatically if it can be built. If the extension fails to

[ovs-dev] [PATCH 2/2] JSON serialization via Python's json lib

2016-05-09 Thread Terry Wilson
There is no particularly good reason to use our own Python JSON serialization implementation when serialization can be done faster with Python's built-in JSON library. A few tests were changed due to Python's default JSON library returning slightly more precise floating point numbers and

[ovs-dev] [PATCH 1/2] Add optional C extension wrapper for Python JSON parsing

2016-05-09 Thread Terry Wilson
The pure Python in-tree JSON parser is *much* slower than the in-tree C JSON parser. A local test parsing a 100Mb JSON file showed the Python version taking 270 seconds. With the C wrapper, it took 4 seconds. The C extension will be used automatically if it can be built. If the extension fails to

Re: [ovs-dev] Working on C wrapper for Python JSON parsing

2016-05-06 Thread Terry Wilson
On Fri, May 6, 2016 at 10:30 AM, Ben Pfaff wrote: >> I'd like to avoid having to wrap the serialization stuff when there is >> something else that already works and is better, but if I have to I >> will. Just looking for opinions on what I should do. Here's the test >> failure

[ovs-dev] Working on C wrapper for Python JSON parsing

2016-05-04 Thread Terry Wilson
I currently have a patch that adds a C extension module to wrap the in-tree JSON parser. It works with both Python 2 and 3. The performance increase is quite large. For example, parsing a 100Mb JSON file: Without extension: 273 seconds With extension: 3.7 seconds On the object->string side,

Re: [ovs-dev] [PATCH] python: Allow specifying the iterations in Idl.run

2016-03-24 Thread Terry Wilson
On Wed, Mar 23, 2016 at 2:31 PM, Jason Kölker wrote: > On Wed, Mar 23, 2016 at 6:29 PM, Ben Pfaff wrote: >> On Sun, Mar 20, 2016 at 03:29:06AM +, Jason Kölker wrote: >>> Callers to Idl.run() should be able to specify the number of iterations >>> to run in one

[Yahoo-eng-team] [Bug 1561152] [NEW] neutron-sanity-check generates invalid bridge names

2016-03-23 Thread Terry Wilson
Importance: Undecided Assignee: Terry Wilson (otherwiseguy) Status: In Progress -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1561152 Title: neutron-sanity-check generates

[Yahoo-eng-team] [Bug 1532273] [NEW] datapath_type not updated for physical and tunnel bridges

2016-01-08 Thread Terry Wilson
Public bug reported: If neutron is originally run with datapath_type=system, then re-started after setting datapath_type=netdev, the physical and tunnel bridges' datapth_type is not updated. This is because OVSBridge.create() is not always called. In the tunnel bridge case, we only call create()

[Yahoo-eng-team] [Bug 1515280] Re: db_create in impl_vsctl.py throws run-time exception

2015-11-12 Thread Terry Wilson
** Changed in: neutron Status: New => Invalid -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1515280 Title: db_create in impl_vsctl.py throws run-time exception Status in

[Yahoo-eng-team] [Bug 1501090] [NEW] OVSDB wait_for_change waits for a change that has already happened

2015-09-29 Thread Terry Wilson
Public bug reported: The idlutils wait_for_change() function calls idl.run(), but doesn't check to see if it caused a change before calling poller.block. ** Affects: neutron Importance: Undecided Assignee: Terry Wilson (otherwiseguy) Status: In Progress -- You received

[ovs-dev] [PATCH v2] Start fixing some Python 3 compatibility issues

2015-07-30 Thread Terry Wilson
This patch fixes just the Python 3 problems found by running python3 setup.py install There are still many other issues to be fixed, but this is a start. Signed-off-by: Terry Wilson twil...@redhat.com --- python/ovs/daemon.py | 31 --- python/ovs/db/idl.py

<    1   2   3   4   5   >