[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/15556

[kudu-CR] Add core algorithms for columnar serialization

2020-03-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/15556

[kudu-CR] Add core algorithms for columnar serialization

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 ) Change subject: Add core algorithms for columnar serialization .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/15556

[kudu-CR] Add core algorithms for columnar serialization

2020-03-25 Thread Todd Lipcon (Code Review)
556 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] rowblock: improve GetSelectedRows API

2020-03-25 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/15559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I34630c7bb854cca572ec081acbc05f3dac4db931 Gerrit-Change-Number: 15559 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit

[kudu-CR] Add functionality to serialize a RowBlock into columnar format

2020-03-25 Thread Todd Lipcon (Code Review)
-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke

[kudu-CR] Add core algorithms for columnar serialization

2020-03-25 Thread Todd Lipcon (Code Review)
556 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] Fix loop unroll pragma for GCC < 8

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15558 ) Change subject: Fix loop unroll pragma for GCC < 8 .. Patch Set 1: Verified+1 java test failure -- To view, visit h

[kudu-CR] Fix loop unroll pragma for GCC < 8

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Fix loop unroll pragma for GCC < 8 .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15558 To unsubscribe, visit h

[kudu-CR] Fix loop unroll pragma for GCC < 8

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Fix loop unroll pragma for GCC < 8 .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15558 To unsubscribe, visit h

[kudu-CR] Fix loop unroll pragma for GCC < 8

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Fix loop unroll pragma for GCC < 8 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15558 To unsubscribe, visit h

[kudu-CR] Add core algorithms for columnar serialization

2020-03-25 Thread Todd Lipcon (Code Review)
atchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] Fix loop unroll pragma for GCC < 8

2020-03-25 Thread Todd Lipcon (Code Review)
50a12c Gerrit-Change-Number: 15558 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15550 ) Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. wire_protocol: some simplification

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. Removed -Verified by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15550 ) Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. Patch Set 3: Verified+1 k, skipping IWYU

Re: Linux futex_wait() bug... [Yes. You read that right. UPDATE to LATEST PATCHES NOW].

2020-03-25 Thread Todd Lipcon
Yes, per my earlier email in this thread, the fix went into RHEL in kernel 2.6.32-504.14.1.el6 which is newer than the one you're reporting. -Todd On Wed, Mar 25, 2020 at 12:44 AM Vishal Sharma wrote: > Hi, > I seem to be hitting this issue on RHEL 6.5. Is that possible? > I've attached strace

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-25 Thread Todd Lipcon (Code Review)
-Change-Id: I24dfb1bd036fde514ca6494bae0ddc171dd225dd Gerrit-Change-Number: 15550 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Add core algorithms for columnar serialization

2020-03-25 Thread Todd Lipcon (Code Review)
oudera.org:8080/15556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I16f2993081aac54609aab4d8219ef0bf6c7708c2 Gerrit-Change-Number: 15556 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerri

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15550 ) Change subject: wire_protocol: some simplification and optimization for rowwise encoding .. Patch Set 2: (2 comments) http

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-24 Thread Todd Lipcon (Code Review)
-Change-Id: I24dfb1bd036fde514ca6494bae0ddc171dd225dd Gerrit-Change-Number: 15550 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] Fix some gcc warnings

2020-03-24 Thread Todd Lipcon (Code Review)
: I881d7cd078b79eabec40c85f8ec665483bd05b7c Gerrit-Change-Number: 15553 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo

[kudu-CR] Use popcnt instruction for Bits::Count

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15549 ) Change subject: Use popcnt instruction for Bits::Count .. Use popcnt instruction for Bits::Count I found Bits::Count

[kudu-CR] rpc: relax limit on number of sidecars

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15547 ) Change subject: rpc: relax limit on number of sidecars .. rpc: relax limit on number of sidecars Following the example

[kudu-CR] wire protocol: some simplification and optimization for rowwise encoding

2020-03-24 Thread Todd Lipcon (Code Review)
rit-Change-Number: 15550 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke

[kudu-CR] Use popcnt instruction for Bits::Count

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15549 ) Change subject: Use popcnt instruction for Bits::Count .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15549/1/src

[kudu-CR] Use popcnt instruction for Bits::Count

2020-03-24 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/15549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iad045e8b77e7baf65c42366eea3e107900eb4a64 Gerrit-Change-Number: 15549 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit

[kudu-CR] Use popcnt instruction for Bits::Count

2020-03-24 Thread Todd Lipcon (Code Review)
http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iad045e8b77e7baf65c42366eea3e107900eb4a64 Gerrit-Change-Number: 15549 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[kudu-CR] rpc: relax limit on number of sidecars

2020-03-24 Thread Todd Lipcon (Code Review)
0/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8e53d5b50753e4aa57d885718ad5b24558636f82 Gerrit-Change-Number: 15547 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Review

[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15548 ) Change subject: Replace 'null_bitmap' variable names with 'non_null_bitmap' .. Replace 'null_bitmap' variable names

[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15548 ) Change subject: Replace 'null_bitmap' variable names with 'non_null_bitmap' .. Patch Set 1: Verified+1 I'm gonna override IWYU for now

[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Replace 'null_bitmap' variable names with 'non_null_bitmap' .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15548

[kudu-CR] Replace 'null bitmap' variable names with 'non null bitmap'

2020-03-24 Thread Todd Lipcon (Code Review)
-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[kudu-CR] rpc: relax limit on number of sidecars

2020-03-24 Thread Todd Lipcon (Code Review)
udu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8e53d5b50753e4aa57d885718ad5b24558636f82 Gerrit-Change-Number: 15547 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Thomas Tauber-Marshall

[kudu-CR] iwyu: standardize on libc++

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: iwyu: standardize on libc++ .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/15492/7//COMMIT_MSG Commit

[kudu-CR] bitmap: faster implementation of iteration over a bitmap

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15539 ) Change subject: bitmap: faster implementation of iteration over a bitmap .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080

[kudu-CR] bitmap: faster implementation of iteration over a bitmap

2020-03-23 Thread Todd Lipcon (Code Review)
ch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibe772a7dd92faf9f99115148ad4cc7df542d1c76 Gerrit-Change-Number: 15539 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (2

[kudu-CR] bitmap: faster implementation of iteration over a bitmap

2020-03-23 Thread Todd Lipcon (Code Review)
ch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibe772a7dd92faf9f99115148ad4cc7df542d1c76 Gerrit-Change-Number: 15539 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] bitmap: faster implementation of iteration over a bitmap

2020-03-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15539 ) Change subject: bitmap: faster implementation of iteration over a bitmap .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080

[kudu-CR] bitmap: faster implementation of iteration over a bitmap

2020-03-23 Thread Todd Lipcon (Code Review)
539 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo

[kudu-CR] gutil: add CPU detection flags for carryless multiplication, BMI

2020-03-23 Thread Todd Lipcon (Code Review)
errit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I89a0c6eab5e37dc8ce59fe1a048670c6c79c692a Gerrit-Change-Number: 15536 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize result batch cell getters by outlining cold path .. client: micro-optimize result batch

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: client: micro-optimize result batch cell getters by outlining cold path .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize result batch cell getters by outlining cold path .. Patch Set 2: Verified+1 failed tests seem

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15502 ) Change subject: tserver: avoid spinlock in scanners hot path .. tserver: avoid spinlock in scanners hot path This replaces

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. client: micro-optimizations to reduce CPU

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: client: micro-optimizations to reduce CPU and allocations .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15439

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 4: Verified+1 Test failures seem unrelated (two

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-19 Thread Todd Lipcon (Code Review)
s Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5838576b3e18cbe8e093bf1e9ce6418ce922de63 Gerrit-Change-Number: 15503 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15502 ) Change subject: tserver: avoid spinlock in scanners hot path .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15502/1

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-19 Thread Todd Lipcon (Code Review)
rit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If3c32e94ada847076580e20571440833a8544c57 Gerrit-Change-Number: 15502 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15501 ) Change subject: client: avoid an extra construction of ColumnSchema .. client: avoid an extra construction of ColumnSchema

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15501 ) Change subject: client: avoid an extra construction of ColumnSchema .. Patch Set 1: Verified+1 I'm skipping the IWYU fix here since I

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: client: avoid an extra construction of ColumnSchema .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15501

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. rpc: use a lighter weight completion for sync RPCs

[jira] [Commented] (KUDU-2432) isolate race creating directory via dist_test.py

2020-03-19 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063083#comment-17063083 ] Todd Lipcon commented on KUDU-2432: --- I pushed a fix for this: https://github.com/cloudera/dist_test

[jira] [Commented] (KUDU-2432) isolate race creating directory via dist_test.py

2020-03-19 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063080#comment-17063080 ] Todd Lipcon commented on KUDU-2432: --- I looked into this a bit tonight since it's happening a lot lately

[jira] [Updated] (KUDU-2432) isolate race creating directory via dist_test.py

2020-03-19 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated KUDU-2432: -- Attachment: logs.txt > isolate race creating directory via dist_test

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
: 15439 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. rpc: reduce context switches and receive calls * When

[kudu-CR] client: micro-optimize getters by outlining cold path

2020-03-19 Thread Todd Lipcon (Code Review)
Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-19 Thread Todd Lipcon (Code Review)
nge Gerrit-Change-Id: If3c32e94ada847076580e20571440833a8544c57 Gerrit-Change-Number: 15502 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Todd Lipcon (Code Review)
Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I695d760837fb529a549e83b5385a1df79f358697 Gerrit-Change-Number: 15501 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Todd Lipcon (Code Review)
visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1b65cce8bd48ee7edf6b2d08e96d00681c32aa97 Gerrit-Change-Number: 15441 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Revie

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Todd Lipcon (Code Review)
oudera.org:8080/15440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I32c5e4d146c25be8e90665a0cb8385fcd017b15c Gerrit-Change-Number: 15440 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerri

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. Patch Set 1: (4 comments) > Patch Set 1: > > (2 comments)

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
: 15439 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-18 Thread Todd Lipcon (Code Review)
: 15439 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080

Re: Switching time source to the built-in NTP client

2020-03-18 Thread Todd Lipcon
ient with --time_source=builtin, of course. > > I'll document options 3 and 4 in upstream JIRAs. If we see more value for > Kudu users in making 'builtin' the default time source, we can reconsider > and move forward with option 3 or 4 (or some other option). > > Let me know

Re: Switching time source to the built-in NTP client

2020-03-17 Thread Todd Lipcon
lease notes > for > > > 1.12 release, of course. Also, there is some risk of hitting a not-yet > > > detected bug in the built-in NTP client. > > > > > > Do you think the benefits of removing the requirement to have the local > > > clock synchronized by local NTP server outweighs the drawbacks of > adding an > > > extra configuration step during 1.12 upgrade for Kudu clusters isolated > > > from the Internet? > > > > > > Your feedback is highly appreciated! > > > > > > > > > Thanks, > > > > > > Alexey > > > > > > > > > P.S. I sent the original message one week ago, but it seems it went > into > > > spam box or alike, so I'm re-sending it. > > > > > > > > > -- > > Grant Henke > > Software Engineer | Cloudera > > gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke > -- Todd Lipcon Software Engineer, Cloudera

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-15 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I705aef9f2e57d44f387b58650279130ff329666d Gerrit-Change-Number: 15439 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-15 Thread Todd Lipcon (Code Review)
visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I32c5e4d146c25be8e90665a0cb8385fcd017b15c Gerrit-Change-Number: 15440 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-15 Thread Todd Lipcon (Code Review)
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1b65cce8bd48ee7edf6b2d08e96d00681c32aa97 Gerrit-Change-Number: 15441 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo

Re: data node reads blocks sequentially from disk

2020-03-11 Thread Todd Lipcon
We also issue explicit readahead via fadvise since 2011 or so, so the typical io sizes hitting the device are large enough to max out the throughput, at least for typical spinning disks. Todd On Wed, Mar 11, 2020, 9:46 AM Kihwal Lee wrote: > When Datanode was initially designed, Linux AIO was

[kudu-CR] rpc: allow a sidecar to append multiple slices

2020-02-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15221 ) Change subject: rpc: allow a sidecar to append multiple slices .. rpc: allow a sidecar to append multiple slices This adds

[kudu-CR] rpc: allow a sidecar to append multiple slices

2020-02-13 Thread Todd Lipcon (Code Review)
set Gerrit-Change-Id: I05b4d5e5243735db943e315268d837f662891b1a Gerrit-Change-Number: 15221 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] rpc: allow a sidecar to append multiple slices

2020-02-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15221 ) Change subject: rpc: allow a sidecar to append multiple slices .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/15221

[kudu-CR] rpc: allow a sidecar to append multiple slices

2020-02-13 Thread Todd Lipcon (Code Review)
set Gerrit-Change-Id: I05b4d5e5243735db943e315268d837f662891b1a Gerrit-Change-Number: 15221 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] rpc: allow a sidecar to append multiple slices

2020-02-13 Thread Todd Lipcon (Code Review)
-Change-Id: I05b4d5e5243735db943e315268d837f662891b1a Gerrit-Change-Number: 15221 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] rpc: allow a sidecar to append multiple slices

2020-02-13 Thread Todd Lipcon (Code Review)
: I05b4d5e5243735db943e315268d837f662891b1a Gerrit-Change-Number: 15221 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[Impala-ASF-CR] WIP: Asynchronous code generation

2020-02-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: WIP: Asynchronous code generation .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/15105/9/be/src

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. schema: use dense_hash_map instead of std

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-21 Thread Todd Lipcon (Code Review)
: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15058 ) Change subject: build: restrict clang version, prefer lld, enable thinlto .. build: restrict clang version, prefer lld, enable

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
: newpatchset Gerrit-Change-Id: I8e8f80229b2dcfad05e204a6f6e50ce7dc3f4c73 Gerrit-Change-Number: 15064 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. Patch Set 3: Hit a gcc 4.8 compatibility bug. Added

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
: newpatchset Gerrit-Change-Id: I8e8f80229b2dcfad05e204a6f6e50ce7dc3f4c73 Gerrit-Change-Number: 15064 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-21 Thread Todd Lipcon (Code Review)
: I09ded0c44c9f7a6839489f0abf5baa4eaf1971f0 Gerrit-Change-Number: 15058 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] memrowset: small optimizations for scanning

2020-01-17 Thread Todd Lipcon (Code Review)
ype: newpatchset Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3 Gerrit-Change-Number: 14874 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15058 ) Change subject: build: restrict clang version, prefer lld, enable thinlto .. Patch Set 3: (12 comments) http://gerrit.cloudera.org

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-17 Thread Todd Lipcon (Code Review)
: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] webserver: use faster gzip compression

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15059 ) Change subject: webserver: use faster gzip compression .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] webserver: use faster gzip compression

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15059 ) Change subject: webserver: use faster gzip compression .. webserver: use faster gzip compression If an HTTP client indicates

<    1   2   3   4   5   6   7   8   9   10   >