[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-17 Thread Todd Lipcon (Code Review)
: I09ded0c44c9f7a6839489f0abf5baa4eaf1971f0 Gerrit-Change-Number: 15058 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-17 Thread Todd Lipcon (Code Review)
: I09ded0c44c9f7a6839489f0abf5baa4eaf1971f0 Gerrit-Change-Number: 15058 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] memrowset: small optimizations for scanning

2020-01-17 Thread Todd Lipcon (Code Review)
ype: newpatchset Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3 Gerrit-Change-Number: 14874 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] memrowset: small optimizations for scanning

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14874 ) Change subject: memrowset: small optimizations for scanning .. Patch Set 4: (1 comment) fixed nit and rebased to master http

[kudu-CR] webserver: use faster gzip compression

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15059 ) Change subject: webserver: use faster gzip compression .. Patch Set 1: (1 comment) > Patch Set 1: Code-Review+2 > > (1 comme

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-17 Thread Todd Lipcon (Code Review)
/15064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8e8f80229b2dcfad05e204a6f6e50ce7dc3f4c73 Gerrit-Change-Number: 15064 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-17 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8e8f80229b2dcfad05e204a6f6e50ce7dc3f4c73 Gerrit-Change-Number: 15064 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo

[kudu-CR] client: use dense hash set in Batcher

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14869 ) Change subject: client: use dense_hash_set in Batcher .. client: use dense_hash_set in Batcher The Batcher implementation keeps

[kudu-CR] client: use dense hash set in Batcher

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14869 ) Change subject: client: use dense_hash_set in Batcher .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] webserver: use faster gzip compression

2020-01-16 Thread Todd Lipcon (Code Review)
http://gerrit.cloudera.org:8080/15059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If97d883483a7313bd5496af68b17e968a5223b1a Gerrit-Change-Number: 15059 Gerrit-PatchSet: 1 Gerrit-Owner: Todd

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-16 Thread Todd Lipcon (Code Review)
: I09ded0c44c9f7a6839489f0abf5baa4eaf1971f0 Gerrit-Change-Number: 15058 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 2: (2 comments) http://gerrit.cloudera.org

[kudu-CR] memrowset: small optimizations for scanning

2020-01-16 Thread Todd Lipcon (Code Review)
06439625fbbbcc83e3652455a8894a0b3 Gerrit-Change-Number: 14874 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] memrowset: small optimizations for scanning

2020-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14874 ) Change subject: memrowset: small optimizations for scanning .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14874/1

[kudu-CR] tools: avoid extra 100ms sleep at end of table scan

2020-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15040 ) Change subject: tools: avoid extra 100ms sleep at end of table scan .. tools: avoid extra 100ms sleep at end of table scan

[kudu-CR] encoding-test: clean up bitshuffle tests a little

2020-01-15 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/15043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8b7bee1f952c46c09df5102ac1916141c6935284 Gerrit-Change-Number: 15043 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-15 Thread Todd Lipcon (Code Review)
: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-01-15 Thread Todd Lipcon (Code Review)
: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [build] Make IWYU scipts compatible with Python 3

2020-01-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15031 ) Change subject: [build] Make IWYU scipts compatible with Python 3 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] encoding-test: clean up bitshuffle tests a little

2020-01-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: clean up bitshuffle tests a little .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 1: (9 comments) http://gerrit.cloudera.org

[kudu-CR] tools: avoid extra 100ms sleep at end of table scan

2020-01-15 Thread Todd Lipcon (Code Review)
http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic7dcd8408b1dbd5322a2f5e8f4889f5f5660ece0 Gerrit-Change-Number: 15040 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer

[kudu-CR] tools: avoid extra 100ms sleep at end of table scan

2020-01-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15040 ) Change subject: tools: avoid extra 100ms sleep at end of table scan .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-15 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/15042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc7a5f148a4a43cedac2428f4c1a18d0f93a10db Gerrit-Change-Number: 15042 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-01-15 Thread Todd Lipcon (Code Review)
http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iba4464c2ea41107df96c68ea61576a0ea269277a Gerrit-Change-Number: 15044 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin

[kudu-CR] encoding-test: clean up bitshuffle tests a little

2020-01-15 Thread Todd Lipcon (Code Review)
:8080/15043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8b7bee1f952c46c09df5102ac1916141c6935284 Gerrit-Change-Number: 15043 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer

[kudu-CR] tools: avoid extra 100ms sleep at end of table scan

2020-01-15 Thread Todd Lipcon (Code Review)
/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic7dcd8408b1dbd5322a2f5e8f4889f5f5660ece0 Gerrit-Change-Number: 15040 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>

[jira] [Updated] (KUDU-3036) RPC size multiplication for DDL operations might hit maximum RPC size limit

2020-01-08 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated KUDU-3036: -- Issue Type: Bug (was: Improvement) > RPC size multiplication for DDL operations might hit maximum

[jira] [Created] (KUDU-3032) key columns unnecessarily selected when predicate is converted to range

2019-12-20 Thread Todd Lipcon (Jira)
Todd Lipcon created KUDU-3032: - Summary: key columns unnecessarily selected when predicate is converted to range Key: KUDU-3032 URL: https://issues.apache.org/jira/browse/KUDU-3032 Project: Kudu

[jira] [Commented] (KUDU-3032) key columns unnecessarily selected when predicate is converted to range

2019-12-20 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001233#comment-17001233 ] Todd Lipcon commented on KUDU-3032: --- The issue is that we seem to determine the "missing co

[jira] [Commented] (KUDU-3030) Crash in tcmalloc stack unwinder

2019-12-19 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000454#comment-17000454 ] Todd Lipcon commented on KUDU-3030: --- I investigated this a bit. We do already install libunwind, and use

[jira] [Created] (KUDU-3030) Crash in tcmalloc stack unwinder

2019-12-19 Thread Todd Lipcon (Jira)
Todd Lipcon created KUDU-3030: - Summary: Crash in tcmalloc stack unwinder Key: KUDU-3030 URL: https://issues.apache.org/jira/browse/KUDU-3030 Project: Kudu Issue Type: Bug Components

[jira] [Created] (KUDU-3022) C++ Client does not retry CreateTable on "new table name is already reserved" error

2019-12-16 Thread Todd Lipcon (Jira)
Todd Lipcon created KUDU-3022: - Summary: C++ Client does not retry CreateTable on "new table name is already reserved" error Key: KUDU-3022 URL: https://issues.apache.org/jira/browse/KUDU-3022

[jira] [Commented] (KUDU-3019) Kudu client hangs in Deffered.join()

2019-12-12 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995364#comment-16995364 ] Todd Lipcon commented on KUDU-3019: --- What version are you seeing this on and what did you set

[kudu-CR] memrowset: small optimizations for scanning

2019-12-10 Thread Todd Lipcon (Code Review)
nge-Number: 14874 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong

[kudu-CR] client: use dense hash set in Batcher

2019-12-10 Thread Todd Lipcon (Code Review)
://gerrit.cloudera.org:8080/14869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieb2d190b9445b49ed752c5991146477fd793099a Gerrit-Change-Number: 14869 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit

[kudu-CR] client: optimize destruction of WriteRpc

2019-12-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14868 ) Change subject: client: optimize destruction of WriteRpc .. Patch Set 2: Verified+1 Strange python packaging issue (unable to find

[kudu-CR] client: optimize destruction of WriteRpc

2019-12-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: client: optimize destruction of WriteRpc .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14868 To unsubscribe, visit

[kudu-CR] client: optimize destruction of WriteRpc

2019-12-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14868 ) Change subject: client: optimize destruction of WriteRpc .. client: optimize destruction of WriteRpc When writing batches

[kudu-CR] client: optimize destruction of WriteRpc

2019-12-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14868 ) Change subject: client: optimize destruction of WriteRpc .. Patch Set 2: > Patch Set 2: Code-Review+2 > > > not a race, I

[kudu-CR] Improve SIMD code generation for primitive predicates

2019-12-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14855 ) Change subject: Improve SIMD code generation for primitive predicates .. Improve SIMD code generation for primitive predicates

[kudu-CR] client: optimize destruction of WriteRpc

2019-12-09 Thread Todd Lipcon (Code Review)
: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I538f995f7ec161e746885c6b31cd1dccd72139b0 Gerrit-Change-Number: 14868 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer

[kudu-CR] Improve SIMD code generation for primitive predicates

2019-12-09 Thread Todd Lipcon (Code Review)
4 -- To view, visit http://gerrit.cloudera.org:8080/14855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1772584c1d0c53128608ea26248dd4ab069b8108 Gerrit-Change-Number: 14855 Gerrit-PatchSet: 4

[kudu-CR] client: optimize destruction of WriteRpc

2019-12-09 Thread Todd Lipcon (Code Review)
Gerrit-MessageType: newchange Gerrit-Change-Id: I538f995f7ec161e746885c6b31cd1dccd72139b0 Gerrit-Change-Number: 14868 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong

[kudu-CR] client: use dense hash set in Batcher

2019-12-09 Thread Todd Lipcon (Code Review)
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb2d190b9445b49ed752c5991146477fd793099a Gerrit-Change-Number: 14869 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit

[kudu-CR] Improve SIMD code generation for primitive predicates

2019-12-06 Thread Todd Lipcon (Code Review)
era.org:8080/14855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1772584c1d0c53128608ea26248dd4ab069b8108 Gerrit-Change-Number: 14855 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Revi

[jira] [Commented] (IMPALA-3189) Address scalability issue with N^2 KDC requests on cluster startup

2019-12-06 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/IMPALA-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990091#comment-16990091 ] Todd Lipcon commented on IMPALA-3189: - This should be largely better with KRPC since we maintain

[kudu-CR] Improve SIMD code generation for primitive predicates

2019-12-05 Thread Todd Lipcon (Code Review)
era.org:8080/14855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1772584c1d0c53128608ea26248dd4ab069b8108 Gerrit-Change-Number: 14855 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Revi

[kudu-CR] Improve SIMD code generation for primitive predicates

2019-12-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14855 Change subject: Improve SIMD code generation for primitive predicates .. Improve SIMD code generation for primitive predicates This adds

[jira] [Commented] (KUDU-1644) Simplify IN-list predicate values based on tablet partition key or rowset PK bounds

2019-12-03 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987613#comment-16987613 ] Todd Lipcon commented on KUDU-1644: --- Looks like those images are in a private jira. Can you upload them

[kudu-CR] [java] KUDU-1644 Simplify IN-list predicate values during token building

2019-12-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14706 ) Change subject: [java] KUDU-1644 Simplify IN-list predicate values during token building .. Patch Set 5: (1 comment) http

[kudu-CR] Update to LLVM 9.0.0

2019-12-03 Thread Todd Lipcon (Code Review)
-Change-Number: 14817 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Update to LLVM 9.0.0

2019-12-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14817 ) Change subject: Update to LLVM 9.0.0 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14817/2/thirdparty/build

[kudu-CR] Update to LLVM 9.0.0

2019-12-03 Thread Todd Lipcon (Code Review)
: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Update to LLVM 9.0.0

2019-12-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14817 ) Change subject: Update to LLVM 9.0.0 .. Patch Set 1: (1 comment) Looks like we need something like

[kudu-CR] Update to LLVM 9.0.0

2019-12-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14817 Change subject: Update to LLVM 9.0.0 .. Update to LLVM 9.0.0 This bumps to the latest LLVM release. I checked codegen-test for any

[kudu-CR] Import Impala's blocked based BloomFilter

2019-11-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 ) Change subject: Import Impala's blocked based BloomFilter .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/14745/5/src

[jira] [Commented] (KUDU-38) bootstrap should not replay logs that are known to be fully flushed

2019-11-19 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1695#comment-1695 ] Todd Lipcon commented on KUDU-38: - bq. Guaranteeing that every complete segment has a fully sync'ed index

[kudu-CR] [java] fixed bug in the connection negotiation code

2019-11-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14713 ) Change subject: [java] fixed bug in the connection negotiation code .. Patch Set 5: Code-Review+2 -- To view, visit http

Re: Impala Column Masking Behavior Design

2019-11-12 Thread Todd Lipcon
-L155 > > > and some experiments I did: > > > > > > > > > https://docs.google.com/document/d/1LYk2wxT3GMw4ur5y9JBBykolfAs31P3gWRStk21PomM/edit?usp=sharing > > > > > > Kurt mentions that traditional dbs like DB2 are in behavior (b). I > think > > we > > > need to decide which behavior we'd like to support. The pros for > behavior > > > (a) is no security leak. Because user X can't guess whether there are > > some > > > customers with phone number '123456789'. The pros for behavior (b) is > > users > > > don't need to rewrite their existing queries after admin applies column > > > masking policies. > > > > > > What do you think? > > > > > > Thanks, > > > Quanlong > > > > > > -- Todd Lipcon Software Engineer, Cloudera

Re: JIRA integration with gitbox

2019-11-08 Thread Todd Lipcon
ions by next Wednesday I’ll go > ahead and file an INFRA ticket. > -- Todd Lipcon Software Engineer, Cloudera

[kudu-CR] [cfile] Improve the hash function of pair

2019-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14644 ) Change subject: [cfile] Improve the hash function of pair .. Patch Set 3: did you see this being a perf hotspot anywhere? if so we

[kudu-CR] KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime

2019-11-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14620 ) Change subject: KUDU-2990: remove memkind/libnuma and dynamically link memkind at runtime .. Patch Set 3: Code-Review+2 (2 comments

[kudu-CR] KUDU-2989. Work around SASL bug when FQDN is >d characters

2019-11-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14609 ) Change subject: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. KUDU-2989. Work around SASL bug when F

[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters

2019-11-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Patch Set 1: Code-Review+2 -- To v

[kudu-CR] KUDU-2989. Work around SASL bug when FQDN is >d characters

2019-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14609 ) Change subject: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Patch Set 1: (1 comment) http://gerrit.cloudera.

[kudu-CR] KUDU-2989. Work around SASL bug when FQDN is >d characters

2019-10-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14609 Change subject: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. KUDU-2989. Work around SASL bug when FQDN is &

[jira] [Created] (KUDU-2989) SASL server fails when FQDN is greater than 63 characters long

2019-10-31 Thread Todd Lipcon (Jira)
Todd Lipcon created KUDU-2989: - Summary: SASL server fails when FQDN is greater than 63 characters long Key: KUDU-2989 URL: https://issues.apache.org/jira/browse/KUDU-2989 Project: Kudu Issue

[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode

2019-10-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Patch Set 8: (3 comments) I generally like

[jira] [Commented] (KUDU-2452) Prevent follower from causing pre-elections when UpdateConsensus is slow

2019-10-22 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957339#comment-16957339 ] Todd Lipcon commented on KUDU-2452: --- Another idea here that would be more complicated but have a much

[jira] [Commented] (KUDU-2975) Spread WAL across multiple data directories

2019-10-17 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953946#comment-16953946 ] Todd Lipcon commented on KUDU-2975: --- agreed this would be good to do. I think [~awong] had done some

[jira] [Created] (RANGER-2611) Ranger should fall back to default TrustManagers if no trust store is specified

2019-10-08 Thread Todd Lipcon (Jira)
Todd Lipcon created RANGER-2611: --- Summary: Ranger should fall back to default TrustManagers if no trust store is specified Key: RANGER-2611 URL: https://issues.apache.org/jira/browse/RANGER-2611

[Impala-ASF-CR] IMPALA-9001: Fix SPNEGO for requests with no 'Authorization'

2019-10-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14352 ) Change subject: IMPALA-9001: Fix SPNEGO for requests with no 'Authorization' .. Patch Set 1: Code-Review+2 I suppose adding a test

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 11: Code-Review+1 -- To view, visit http

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/14106

[jira] [Commented] (KUDU-2932) Unix domain socket could speed up data transmission

2019-08-28 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917942#comment-16917942 ] Todd Lipcon commented on KUDU-2932: --- bq. kudu doesn't support data locality What do you mean by that? I

[jira] [Resolved] (KUDU-2847) Optimize iteration over selection vector in SerializeRowBlock

2019-08-27 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/KUDU-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon resolved KUDU-2847. --- Fix Version/s: 1.11.0 Resolution: Fixed > Optimize iteration over selection vec

[jira] [Created] (HADOOP-16526) Support LDAP authenticaition (bind) via GSSAPI

2019-08-21 Thread Todd Lipcon (Jira)
Todd Lipcon created HADOOP-16526: Summary: Support LDAP authenticaition (bind) via GSSAPI Key: HADOOP-16526 URL: https://issues.apache.org/jira/browse/HADOOP-16526 Project: Hadoop Common

[jira] [Created] (HADOOP-16526) Support LDAP authenticaition (bind) via GSSAPI

2019-08-21 Thread Todd Lipcon (Jira)
Todd Lipcon created HADOOP-16526: Summary: Support LDAP authenticaition (bind) via GSSAPI Key: HADOOP-16526 URL: https://issues.apache.org/jira/browse/HADOOP-16526 Project: Hadoop Common

[jira] [Commented] (HADOOP-16525) LDAP group mapping should include primary posix group

2019-08-21 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912735#comment-16912735 ] Todd Lipcon commented on HADOOP-16525: -- Worth noting that this case isn't handled properly

[jira] [Commented] (HADOOP-16525) LDAP group mapping should include primary posix group

2019-08-21 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912726#comment-16912726 ] Todd Lipcon commented on HADOOP-16525: -- One potential wrinkle in this patch: do we currently

[jira] [Commented] (HADOOP-16525) LDAP group mapping should include primary posix group

2019-08-21 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912723#comment-16912723 ] Todd Lipcon commented on HADOOP-16525: -- Attached a preliminary patch here -- missing unit tests

[jira] [Updated] (HADOOP-16525) LDAP group mapping should include primary posix group

2019-08-21 Thread Todd Lipcon (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated HADOOP-16525: - Attachment: hadoop-16525.txt > LDAP group mapping should include primary posix gr

[jira] [Created] (HADOOP-16525) LDAP group mapping should include primary posix group

2019-08-21 Thread Todd Lipcon (Jira)
Todd Lipcon created HADOOP-16525: Summary: LDAP group mapping should include primary posix group Key: HADOOP-16525 URL: https://issues.apache.org/jira/browse/HADOOP-16525 Project: Hadoop Common

[jira] [Created] (HADOOP-16525) LDAP group mapping should include primary posix group

2019-08-21 Thread Todd Lipcon (Jira)
Todd Lipcon created HADOOP-16525: Summary: LDAP group mapping should include primary posix group Key: HADOOP-16525 URL: https://issues.apache.org/jira/browse/HADOOP-16525 Project: Hadoop Common

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-08-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 ) Change subject: KUDU-2921: Exposing the table statistics to spark relation. .. Patch Set 1: > Patch Set 1: > > Did you consid

[Impala-ASF-CR] [WIP] IMPALA-8228: Ownership support for Ranger authz

2019-08-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: [WIP] IMPALA-8228: Ownership support for Ranger authz .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-8869: Fix handling of HTTP keep-alive when returning 401

2019-08-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14076 ) Change subject: IMPALA-8869: Fix handling of HTTP keep-alive when returning 401 .. Patch Set 1: Code-Review+2 -- To view, visit http

[jira] [Commented] (HDFS-916) Rewrite DFSOutputStream to use a single thread with NIO

2019-08-12 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905664#comment-16905664 ] Todd Lipcon commented on HDFS-916: -- I doubt anyone is working on this at this point (I certainly am

[kudu-CR] [tserver] Move cell and probe key size checking to prepare phase

2019-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13470 ) Change subject: [tserver] Move cell and probe key size checking to prepare phase .. Patch Set 10: Code-Review+2 Took a quick look

[kudu-CR] KUDU-2915 Support to delete dead tservers from CLI

2019-08-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14048 ) Change subject: KUDU-2915 Support to delete dead tservers from CLI .. Patch Set 1: Have we considered alternatives here? eg

[jira] [Commented] (KUDU-2906) Don't allow elections when server clocks are too out of sync

2019-07-26 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/KUDU-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894190#comment-16894190 ] Todd Lipcon commented on KUDU-2906: --- So in this case, the serve'rs NTP reported that it was in TIME_OK

[Impala-ASF-CR] IMPALA-8661 : Add randomized tests to stress MetastoreEventsProcessor

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13932 ) Change subject: IMPALA-8661 : Add randomized tests to stress MetastoreEventsProcessor .. Patch Set 2: I'm out the next two weeks

[Impala-ASF-CR] IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13918 ) Change subject: IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server .. Patch Set 7: Code-Review+2 k, seems like

[kudu-CR] KUDU-1938 Add non-copy setters to partial row pt 3

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13928 ) Change subject: KUDU-1938 Add non-copy setters to partial row pt 3 .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13918 ) Change subject: IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server .. Patch Set 6: (3 comments) http

[Impala-ASF-CR] IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13918 ) Change subject: IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server .. Patch Set 3: (2 comments) http

[Impala-ASF-CR] IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server

2019-07-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13918 ) Change subject: IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server .. Patch Set 1: (2 comments) http

[kudu-CR] Deprecated TabletLocationsPB.ReplicaPB message

2019-07-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 ) Change subject: Deprecated TabletLocationsPB.ReplicaPB message .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13908/1

<    1   2   3   4   5   6   7   8   9   10   >