[kudu-CR] rpc-test: deflake TestClientConnectionMetrics

2019-06-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13543 ) Change subject: rpc-test: deflake TestClientConnectionMetrics .. Patch Set 1: Code-Review+2 -- To view, visit http

[kudu-CR] Add seek before mode for CBTree to accelerate CheckRowDeleted in dms.

2019-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13516 ) Change subject: Add seek before mode for CBTree to accelerate CheckRowDeleted in dms. .. Patch Set 1: (4 comments) Nice performance

[ANNOUNCE] Welcoming Yingchun Lai as a Kudu committer and PMC member

2019-06-05 Thread Todd Lipcon
Hi Kudu community, I'm happy to announce that the Kudu PMC has voted to add Yingchun Lai as a new committer and PMC member. Yingchun has been contributing to Kudu for the last 6-7 months and contributed a number of bug fixes, improvements, and features, including: - new CLI tools (eg 'kudu table

[ANNOUNCE] Welcoming Yingchun Lai as a Kudu committer and PMC member

2019-06-05 Thread Todd Lipcon
Hi Kudu community, I'm happy to announce that the Kudu PMC has voted to add Yingchun Lai as a new committer and PMC member. Yingchun has been contributing to Kudu for the last 6-7 months and contributed a number of bug fixes, improvements, and features, including: - new CLI tools (eg 'kudu table

[kudu-CR] Support SPNEGO for web server

2019-06-05 Thread Todd Lipcon (Code Review)
-Change-Id: I9449ac610aa7d11bbf320d9178a6d73684ff15f7 Gerrit-Change-Number: 13341 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-06-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 19: Code-Review+2 -- To view, visit http

[jira] [Resolved] (HDFS-14535) The default 8KB buffer in requestFileDescriptors#BufferedOutputStream is causing lots of heap allocation in HBase when using short-circut read

2019-06-04 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon resolved HDFS-14535. Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0 > The default 8KB buf

[jira] [Resolved] (HDFS-14535) The default 8KB buffer in requestFileDescriptors#BufferedOutputStream is causing lots of heap allocation in HBase when using short-circut read

2019-06-04 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon resolved HDFS-14535. Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0 > The default 8KB buf

[jira] [Commented] (HDFS-14535) The default 8KB buffer in requestFileDescriptors#BufferedOutputStream is causing lots of heap allocation in HBase when using short-circut read

2019-06-04 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855848#comment-16855848 ] Todd Lipcon commented on HDFS-14535: bq. OK, I considered something wrong here. It's a big HFile

[kudu-CR] Support SPNEGO for web server

2019-06-03 Thread Todd Lipcon (Code Review)
-Change-Id: I9449ac610aa7d11bbf320d9178a6d73684ff15f7 Gerrit-Change-Number: 13341 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer

[jira] [Commented] (HDFS-14535) The default 8KB buffer in requestFileDescriptors#BufferedOutputStream is causing lots of heap allocation in HBase when using short-circut read

2019-06-03 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855018#comment-16855018 ] Todd Lipcon commented on HDFS-14535: +1, Seems like an improvement to me. One thing I wonder, though

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-03 Thread Todd Lipcon (Code Review)
-Change-Id: I2302c19abb5db19f1d3d1cd727a82977a9e2ba9c Gerrit-Change-Number: 13425 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Todd Lipcon

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 18: (1 comment) http://gerrit.cloudera.org

[kudu-CR] docs: update docs for heap sampling

2019-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13459 ) Change subject: docs: update docs for heap sampling .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13459/1/docs

[Impala-ASF-CR] IMPALA-8509. Lazily evaluate LOAD sections during data load

2019-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13252 ) Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load .. Patch Set 4: yea, Joe and I looked at it and it seems

[jira] [Commented] (KUDU-749) Improve performance for zipfian update

2019-06-03 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/KUDU-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854764#comment-16854764 ] Todd Lipcon commented on KUDU-749: -- Hi [~ZhangYao]. That makes sense to me -- maybe the POC will expose

[jira] [Commented] (IMPALA-8459) Cannot delete impala/kudu table if backing kudu table dropped with local catalog

2019-05-31 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/IMPALA-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853445#comment-16853445 ] Todd Lipcon commented on IMPALA-8459: - One possibility for a workaround: could you alter the storage

[Impala-ASF-CR] IMPALA-8600 : Reload partition does not work for transactional tables

2019-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13467 ) Change subject: IMPALA-8600 : Reload partition does not work for transactional tables .. Patch Set 1: (1 comment) http

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 14: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] WIP: IMPALA-8586: Support download URLs for CDP

2019-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13432 ) Change subject: WIP: IMPALA-8586: Support download URLs for CDP .. Patch Set 1: Code-Review+1 Seems like a fine direction to me

[Impala-ASF-CR] IMPALA-8604: Improve authorization test coverage for update/upsert/delete statements

2019-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13480 ) Change subject: IMPALA-8604: Improve authorization test coverage for update/upsert/delete statements .. Patch Set 1: Code-Review+2

[kudu-CR] [tserver] Move cell size checking to prepare phase

2019-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13470 ) Change subject: [tserver] Move cell size checking to prepare phase .. Patch Set 2: Does this change user-facing behavior? Previously

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-05-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 13: (3 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-05-29 Thread Todd Lipcon (Code Review)
-MessageType: newchange Gerrit-Change-Id: I4d90a5f075b05d2dc96692b3349abe35ce24b8b8 Gerrit-Change-Number: 13463 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar

[jira] [Updated] (IMPALA-8489) TestRecoverPartitions.test_post_invalidate fails with IllegalStateException when HMS polling is enabled

2019-05-29 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/IMPALA-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated IMPALA-8489: Summary: TestRecoverPartitions.test_post_invalidate fails with IllegalStateException when HMS

[jira] [Commented] (IMPALA-8489) TestRecoverPartitions.test_post_invalidate fails with IllegalStateException with local catalog

2019-05-29 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/IMPALA-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851376#comment-16851376 ] Todd Lipcon commented on IMPALA-8489: - Ah, it seems this is due to --hms_event_polling_interval_s=1

[kudu-CR] docs: update docs for heap sampling

2019-05-29 Thread Todd Lipcon (Code Review)
Gerrit-Change-Number: 13459 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Will Berkeley

[jira] [Commented] (KUDU-2826) Add redo tail for mutation list to accelerate UPDATE in memrowset

2019-05-29 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/KUDU-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851097#comment-16851097 ] Todd Lipcon commented on KUDU-2826: --- Yea, it seems fine to make this optimization and follow up

[jira] [Commented] (HIVE-21796) ArrayWritableObjectInspector.equals can take O(2^nesting_depth) time

2019-05-29 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851089#comment-16851089 ] Todd Lipcon commented on HIVE-21796: I looked through this code and it wasn't obvious to me how

[kudu-CR] KUDU-2348: Pick a random replica in RemoteTablet.java

2019-05-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12158 ) Change subject: KUDU-2348: Pick a random replica in RemoteTablet.java .. Patch Set 9: Thinking about this a bit, I wonder what behavior

[jira] [Commented] (IMPALA-8594) Support drop table for external kudu tables that are dropped in kudu

2019-05-29 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/IMPALA-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851017#comment-16851017 ] Todd Lipcon commented on IMPALA-8594: - Did you hit this with LocalCatalog enabled or without? IMPALA

[kudu-CR] apply ustat removal patch from llvm

2019-05-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13447 ) Change subject: apply ustat removal patch from llvm .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13447/1

[jira] [Commented] (KUDU-2826) Add redo tail for mutation list to accelerate UPDATE in memrowset

2019-05-28 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/KUDU-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850482#comment-16850482 ] Todd Lipcon commented on KUDU-2826: --- [~ZhangYao] please check out KUDU-749 as well. I think your

[kudu-CR] Patch bison 3.0.4 and gnulib > 2.28

2019-05-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13446 ) Change subject: Patch bison 3.0.4 and gnulib > 2.28 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/1344

[kudu-CR] Apply gcc 9x patch to lss dependency

2019-05-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13448 ) Change subject: Apply gcc 9x patch to lss dependency .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13448/1

[jira] [Resolved] (IMPALA-8383) Bump toolchain version

2019-05-28 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/IMPALA-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon resolved IMPALA-8383. - Resolution: Won't Fix > Bump toolchain version > -- > >

[kudu-CR] Apply gcc 9x patch to lss dependency

2019-05-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13448 ) Change subject: Apply gcc 9x patch to lss dependency .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13448/1

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-05-28 Thread Todd Lipcon (Code Review)
-Change-Id: I2302c19abb5db19f1d3d1cd727a82977a9e2ba9c Gerrit-Change-Number: 13425 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho

[Impala-ASF-CR] WIP: IMPALA-8542. Add an access trace for the data cache

2019-05-24 Thread Todd Lipcon (Code Review)
-Change-Id: I2302c19abb5db19f1d3d1cd727a82977a9e2ba9c Gerrit-Change-Number: 13425 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho

[kudu-CR] KUDU-2670: Part 1: Build ScanToken by KeyRange

2019-05-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12323 ) Change subject: KUDU-2670: Part 1: Build ScanToken by KeyRange .. Patch Set 34: BTW the source for dist-test is open if you want to run

[Impala-ASF-CR] IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13299 ) Change subject: IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13299 ) Change subject: IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint .. Patch Set 4: (1 comment) http

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 ) Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests .. Patch Set 6: Code-Review+2 -- To v

[Impala-ASF-CR] IMPALA-8400: Implement Ranger audit event handler

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13309 ) Change subject: IMPALA-8400: Implement Ranger audit event handler .. Patch Set 12: Code-Review+2 Thanks for the patience

[Impala-ASF-CR] IMPALA-8369: Add HIVE MAJOR VERSION section to planner tests + some fixes

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13414 ) Change subject: IMPALA-8369: Add HIVE_MAJOR_VERSION section to planner tests + some fixes .. Patch Set 2: seems like the test failure

[kudu-CR] KUDU-2826: Add tail for mutation list to accelerate update in memrowset

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13412 ) Change subject: KUDU-2826: Add tail for mutation list to accelerate update in memrowset .. Patch Set 2: (1 comment) Would be good

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 ) Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests .. Patch Set 5: Verified+1 Bui

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cl

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 20: Code-Review+2 (2 comments) http

[Impala-ASF-CR] IMPALA-8559 : Support config validation for event processor on HMS-3

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13372 ) Change subject: IMPALA-8559 : Support config validation for event processor on HMS-3 .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8559 : Support config validation for event processor on HMS-3

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13372 ) Change subject: IMPALA-8559 : Support config validation for event processor on HMS-3 .. Patch Set 5: (4 comments) Just a few nits

[Impala-ASF-CR] IMPALA-8369: Add HIVE MAJOR VERSION section to planner tests + some fixes

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13414 ) Change subject: IMPALA-8369: Add HIVE_MAJOR_VERSION section to planner tests + some fixes .. Patch Set 1: Code-Review+2 -- To view

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 18: Looks like some of the test failures from patch set

[jira] [Commented] (HIVE-21667) Bad error message when non-ACID files are put in an insert_only ACID table

2019-05-23 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846505#comment-16846505 ] Todd Lipcon commented on HIVE-21667: [~vgumashta] any thoughts on this? I was under the impression

[jira] [Commented] (HIVE-21757) ACID: use a new write id for compaction's output instead of the visibility id

2019-05-23 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846500#comment-16846500 ] Todd Lipcon commented on HIVE-21757: [~gopalv] what do you think about allocating a writeID

[Impala-ASF-CR] IMPALA-8559 : Support config validation for event processor on HMS-3

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13372 ) Change subject: IMPALA-8559 : Support config validation for event processor on HMS-3 .. Patch Set 3: (16 comments) http

[Impala-ASF-CR] IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13299 ) Change subject: IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint .. Patch Set 3: (13 comments) http

[Impala-ASF-CR] IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13299 ) Change subject: IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint .. Patch Set 3: (1 comment) http

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 8: (12 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8400: Implement Ranger audit event handler

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13309 ) Change subject: IMPALA-8400: Implement Ranger audit event handler .. Patch Set 11: (6 comments) Thanks for making that refactor

[Impala-ASF-CR] IMPALA-8450: Add support for zstd and lz4 in parquet

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13396 ) Change subject: IMPALA-8450: Add support for zstd and lz4 in parquet .. Patch Set 7: (4 comments) Didn't look through the whole thing

[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 ) Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS .. Patch Set 2: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 15: (3 comments) Did a bit of restructuring to avoid

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#15) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. acid: Filter

[jira] [Resolved] (IMPALA-8458) Can't set numNull/maxSize/avgSize column stats with local catalog without also setting NDV

2019-05-22 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/IMPALA-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon resolved IMPALA-8458. - Resolution: Fixed Fix Version/s: Impala 3.3.0 > Can't set numNull/maxSize/avgSize col

[jira] [Resolved] (IMPALA-8458) Can't set numNull/maxSize/avgSize column stats with local catalog without also setting NDV

2019-05-22 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/IMPALA-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon resolved IMPALA-8458. - Resolution: Fixed Fix Version/s: Impala 3.3.0 > Can't set numNull/maxSize/avgSize col

[jira] [Resolved] (IMPALA-8215) Don't set numTrue = 1

2019-05-22 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/IMPALA-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon resolved IMPALA-8215. - Resolution: Fixed Assignee: Todd Lipcon (was: wuchang) Fix Version/s: Impala

[Impala-ASF-CR] IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13382 ) Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode .. IMPALA-8215, IMPALA

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 14: (4 comments) I think Sudhanshu's AFK this afternoon

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#14) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. acid: Filter

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#13) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. acid: Filter

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: IMPALA-8435. Prohibit operations on transactional table. .. Removed Code-Review-2 by Todd Lipcon -- To view, visit http://gerrit.cloudera.org:8080/13311

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13311 ) Change subject: IMPALA-8435. Prohibit operations on transactional table. .. IMPALA-8435. Prohibit operations on transactional

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13311 ) Change subject: IMPALA-8435. Prohibit operations on transactional table. .. Patch Set 14: Code-Review-2 -- To view, visit http

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13311 ) Change subject: IMPALA-8435. Prohibit operations on transactional table. .. Patch Set 14: Code-Review+2 -- To view, visit http

Re: Ubuntu 18.04 in pre-merge tests?

2019-05-22 Thread Todd Lipcon
sonally I don't develop on Ubuntu 18 and in my day job it's not a particularly important deployment platform, so I personally don't think I'll spend much time triaging that build. Todd > > On Mon, May 20, 2019 at 9:09 AM Todd Lipcon wrote: > > > Adding a build-only job for 18.04 makes

[Impala-ASF-CR] IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13382 ) Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode .. Patch Set 5: Verified+1

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: IMPALA-8435. Prohibit operations on transactional table. .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/13311

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13311 ) Change subject: IMPALA-8435. Prohibit operations on transactional table. .. Patch Set 14: Verified+1 Test failures are due

[Impala-ASF-CR] IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13382 ) Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode .. Patch Set 5: Tim, can you

[Impala-ASF-CR] IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http

[kudu-CR] [tool] Add cluster name resolver for CLI tools

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13354 ) Change subject: [tool] Add cluster name resolver for CLI tools .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13354/1

[kudu-CR] KUDU-2802 [java] tableExists API optimizations

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13401 ) Change subject: KUDU-2802 [java] tableExists API optimizations .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13401/1

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 11: Made some changes/fixes and updated the commit

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#13) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13311 ) Change subject: IMPALA-8435. Prohibit operations on transactional table. .. IMPALA

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#11) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. acid: Filter

[Impala-ASF-CR] [IMPALA-8435] Prohibit operations on transactional table.

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#12) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13311 ) Change subject: [IMPALA-8435] Prohibit operations on transactional table. .. [IMPALA

[Impala-ASF-CR] IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-21 Thread Todd Lipcon (Code Review)
rit-Change-Number: 13382 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon

[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 ) Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS .. Patch Set 2: Does this end up increasing the exhaustive

[jira] [Created] (IMPALA-8569) Periodically scrub deleted files from the file handle cache

2019-05-21 Thread Todd Lipcon (JIRA)
Todd Lipcon created IMPALA-8569: --- Summary: Periodically scrub deleted files from the file handle cache Key: IMPALA-8569 URL: https://issues.apache.org/jira/browse/IMPALA-8569 Project: IMPALA

[jira] [Created] (IMPALA-8569) Periodically scrub deleted files from the file handle cache

2019-05-21 Thread Todd Lipcon (JIRA)
Todd Lipcon created IMPALA-8569: --- Summary: Periodically scrub deleted files from the file handle cache Key: IMPALA-8569 URL: https://issues.apache.org/jira/browse/IMPALA-8569 Project: IMPALA

[jira] [Commented] (IMPALA-8544) Expose additional S3A / S3Guard metrics

2019-05-21 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/IMPALA-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845479#comment-16845479 ] Todd Lipcon commented on IMPALA-8544: - I think the problem with using the global metrics

[Impala-ASF-CR] Fix bin/set-classpath.sh error handling when sourced

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13391 ) Change subject: Fix bin/set-classpath.sh error handling when sourced .. Fix bin/set-classpath.sh error handling when sourced

[Impala-ASF-CR] Fix bin/set-classpath.sh error handling when sourced

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13391 ) Change subject: Fix bin/set-classpath.sh error handling when sourced .. Patch Set 2: Verified+1 Unrelated test failures in the Java

[Impala-ASF-CR] Fix bin/set-classpath.sh error handling when sourced

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Fix bin/set-classpath.sh error handling when sourced .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/13391

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 5: The config template changes look

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c

<    4   5   6   7   8   9   10   11   12   13   >