[kudu-CR] bitmap: faster implementation of iteration over a bitmap

2020-03-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15539 ) Change subject: bitmap: faster implementation of iteration over a bitmap .. Patch Set 3: (3 comments)

[kudu-CR] bitmap: faster implementation of iteration over a bitmap

2020-03-23 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15539 to look at the new patch set (#3). Change subject: bitmap: faster implementation of iteration over a bitmap

[kudu-CR] bitmap: faster implementation of iteration over a bitmap

2020-03-23 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15539 to look at the new patch set (#2). Change subject: bitmap: faster implementation of iteration over a bitmap

[kudu-CR] bitmap: faster implementation of iteration over a bitmap

2020-03-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15539 ) Change subject: bitmap: faster implementation of iteration over a bitmap .. Patch Set 1: (10 comments)

[kudu-CR] bitmap: faster implementation of iteration over a bitmap

2020-03-23 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15539 to review the following change. Change subject: bitmap: faster implementation of iteration over a bitmap .. bitmap:

[kudu-CR] gutil: add CPU detection flags for carryless multiplication, BMI

2020-03-23 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15536 to review the following change. Change subject: gutil: add CPU detection flags for carryless multiplication, BMI ..

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize result batch cell getters by outlining cold path .. client: micro-optimize result batch

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: client: micro-optimize result batch cell getters by outlining cold path .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15503 ) Change subject: client: micro-optimize result batch cell getters by outlining cold path .. Patch Set 2: Verified+1 failed tests seem

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15502 ) Change subject: tserver: avoid spinlock in scanners hot path .. tserver: avoid spinlock in scanners hot path This replaces a

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. client: micro-optimizations to reduce CPU and

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: client: micro-optimizations to reduce CPU and allocations .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15439 To

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 4: Verified+1 Test failures seem unrelated (two

[kudu-CR] client: micro-optimize result batch cell getters by outlining cold path

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15503 to look at the new patch set (#2). Change subject: client: micro-optimize result batch cell getters by

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15502 ) Change subject: tserver: avoid spinlock in scanners hot path .. Patch Set 2: (1 comment)

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15502 to look at the new patch set (#2). Change subject: tserver: avoid spinlock in scanners hot path

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15501 ) Change subject: client: avoid an extra construction of ColumnSchema .. client: avoid an extra construction of ColumnSchema

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15501 ) Change subject: client: avoid an extra construction of ColumnSchema .. Patch Set 1: Verified+1 I'm skipping the IWYU fix here since I

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: client: avoid an extra construction of ColumnSchema .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15501 To

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. rpc: use a lighter weight completion for sync RPCs This

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15439 to look at the new patch set (#4). Change subject: client: micro-optimizations to reduce CPU and allocations

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 3: (2 comments)

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. rpc: reduce context switches and receive calls * When

[kudu-CR] client: micro-optimize getters by outlining cold path

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15503 to review the following change. Change subject: client: micro-optimize getters by outlining cold path .. client:

[kudu-CR] tserver: avoid spinlock in scanners hot path

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15502 to review the following change. Change subject: tserver: avoid spinlock in scanners hot path .. tserver: avoid

[kudu-CR] client: avoid an extra construction of ColumnSchema

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15501 to review the following change. Change subject: client: avoid an extra construction of ColumnSchema .. client: avoid

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15441 to look at the new patch set (#2). Change subject: rpc: use a lighter weight completion for sync RPCs

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 1: (4 comments)

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 1: (1 comment)

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15440 to look at the new patch set (#2). Change subject: rpc: reduce context switches and receive calls

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. Patch Set 1: (4 comments) > Patch Set 1: > > (2 comments) > > Would

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15439 to look at the new patch set (#3). Change subject: client: micro-optimizations to reduce CPU and allocations

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 2: (1 comment)

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-18 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15439 to look at the new patch set (#2). Change subject: client: micro-optimizations to reduce CPU and allocations

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 1: (6 comments)

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-15 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15439 to review the following change. Change subject: client: micro-optimizations to reduce CPU and allocations .. client:

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-15 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15440 to review the following change. Change subject: rpc: reduce context switches and receive calls .. rpc: reduce context

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-15 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15441 to review the following change. Change subject: rpc: use a lighter weight completion for sync RPCs .. rpc: use a

[kudu-CR] rpc: allow a sidecar to append multiple slices

2020-02-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15221 ) Change subject: rpc: allow a sidecar to append multiple slices .. rpc: allow a sidecar to append multiple slices This adds

[kudu-CR] rpc: allow a sidecar to append multiple slices

2020-02-13 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15221 to look at the new patch set (#4). Change subject: rpc: allow a sidecar to append multiple slices

[kudu-CR] rpc: allow a sidecar to append multiple slices

2020-02-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15221 ) Change subject: rpc: allow a sidecar to append multiple slices .. Patch Set 4: (4 comments)

[kudu-CR] rpc: allow a sidecar to append multiple slices

2020-02-13 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15221 to look at the new patch set (#3). Change subject: rpc: allow a sidecar to append multiple slices

[kudu-CR] rpc: allow a sidecar to append multiple slices

2020-02-13 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15221 to look at the new patch set (#2). Change subject: rpc: allow a sidecar to append multiple slices ..

[kudu-CR] rpc: allow a sidecar to append multiple slices

2020-02-13 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15221 to review the following change. Change subject: rpc: allow a sidecar to append multiple slices .. rpc: allow a

[Impala-ASF-CR] WIP: Asynchronous code generation

2020-02-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: WIP: Asynchronous code generation .. Patch Set 9: (1 comment)

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. schema: use dense_hash_map instead of

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15042 to look at the new patch set (#4). Change subject: cfile: change BlockBuilder API to yield a vector of Slices

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15058 ) Change subject: build: restrict clang version, prefer lld, enable thinlto .. build: restrict clang version, prefer lld, enable

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15064 to look at the new patch set (#5). Change subject: schema: use dense_hash_map instead of std::unordered_map

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. Patch Set 4: (1 comment)

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. Patch Set 3: Hit a gcc 4.8 compatibility bug. Added a

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15064 to look at the new patch set (#4). Change subject: schema: use dense_hash_map instead of std::unordered_map

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-21 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15058 to look at the new patch set (#4). Change subject: build: restrict clang version, prefer lld, enable thinlto

[kudu-CR] memrowset: small optimizations for scanning

2020-01-17 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14874 to look at the new patch set (#5). Change subject: memrowset: small optimizations for scanning

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15058 ) Change subject: build: restrict clang version, prefer lld, enable thinlto .. Patch Set 3: (12 comments)

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-17 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15064 to look at the new patch set (#3). Change subject: schema: use dense_hash_map instead of std::unordered_map

[kudu-CR] webserver: use faster gzip compression

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15059 ) Change subject: webserver: use faster gzip compression .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] webserver: use faster gzip compression

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15059 ) Change subject: webserver: use faster gzip compression .. webserver: use faster gzip compression If an HTTP client indicates

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-17 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15058 to look at the new patch set (#3). Change subject: build: restrict clang version, prefer lld, enable thinlto

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-17 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15058 to look at the new patch set (#2). Change subject: build: restrict clang version, prefer lld, enable thinlto

[kudu-CR] memrowset: small optimizations for scanning

2020-01-17 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14874 to look at the new patch set (#3). Change subject: memrowset: small optimizations for scanning

[kudu-CR] memrowset: small optimizations for scanning

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14874 ) Change subject: memrowset: small optimizations for scanning .. Patch Set 4: (1 comment) fixed nit and rebased to master

[kudu-CR] webserver: use faster gzip compression

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15059 ) Change subject: webserver: use faster gzip compression .. Patch Set 1: (1 comment) > Patch Set 1: Code-Review+2 > > (1 comment)

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15064 ) Change subject: schema: use dense_hash_map instead of std::unordered_map .. Patch Set 2: (2 comments)

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-17 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15064 to look at the new patch set (#2). Change subject: schema: use dense_hash_map instead of std::unordered_map

[kudu-CR] schema: use dense hash map instead of std::unordered map

2020-01-17 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15064 to review the following change. Change subject: schema: use dense_hash_map instead of std::unordered_map .. schema:

[kudu-CR] client: use dense hash set in Batcher

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14869 ) Change subject: client: use dense_hash_set in Batcher .. client: use dense_hash_set in Batcher The Batcher implementation keeps

[kudu-CR] client: use dense hash set in Batcher

2020-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14869 ) Change subject: client: use dense_hash_set in Batcher .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] webserver: use faster gzip compression

2020-01-16 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15059 to review the following change. Change subject: webserver: use faster gzip compression .. webserver: use faster gzip

[kudu-CR] build: restrict clang version, prefer lld, enable thinlto

2020-01-16 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15058 to review the following change. Change subject: build: restrict clang version, prefer lld, enable thinlto .. build:

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 2: (2 comments)

[kudu-CR] memrowset: small optimizations for scanning

2020-01-16 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14874 to look at the new patch set (#2). Change subject: memrowset: small optimizations for scanning

[kudu-CR] memrowset: small optimizations for scanning

2020-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14874 ) Change subject: memrowset: small optimizations for scanning .. Patch Set 1: (3 comments)

[kudu-CR] tools: avoid extra 100ms sleep at end of table scan

2020-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15040 ) Change subject: tools: avoid extra 100ms sleep at end of table scan .. tools: avoid extra 100ms sleep at end of table scan

[kudu-CR] encoding-test: clean up bitshuffle tests a little

2020-01-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15043 to look at the new patch set (#2). Change subject: encoding-test: clean up bitshuffle tests a little

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15042 to look at the new patch set (#2). Change subject: cfile: change BlockBuilder API to yield a vector of Slices

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-01-15 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15044 to look at the new patch set (#2). Change subject: cfile: clean up encoding-test to use fewer templates

[kudu-CR] [build] Make IWYU scipts compatible with Python 3

2020-01-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15031 ) Change subject: [build] Make IWYU scipts compatible with Python 3 .. Patch Set 2: (1 comment)

[kudu-CR] encoding-test: clean up bitshuffle tests a little

2020-01-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15043 ) Change subject: encoding-test: clean up bitshuffle tests a little .. Patch Set 1: (3 comments)

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 ) Change subject: cfile: change BlockBuilder API to yield a vector of Slices .. Patch Set 1: (9 comments)

[kudu-CR] tools: avoid extra 100ms sleep at end of table scan

2020-01-15 Thread Todd Lipcon (Code Review)
Hello Yingchun Lai, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15040 to look at the new patch set (#2). Change subject: tools: avoid extra 100ms sleep at end of table scan

[kudu-CR] tools: avoid extra 100ms sleep at end of table scan

2020-01-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15040 ) Change subject: tools: avoid extra 100ms sleep at end of table scan .. Patch Set 1: (1 comment)

[kudu-CR] cfile: change BlockBuilder API to yield a vector of Slices

2020-01-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15042 to review the following change. Change subject: cfile: change BlockBuilder API to yield a vector of Slices ..

[kudu-CR] cfile: clean up encoding-test to use fewer templates

2020-01-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15044 to review the following change. Change subject: cfile: clean up encoding-test to use fewer templates .. cfile:

[kudu-CR] encoding-test: clean up bitshuffle tests a little

2020-01-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15043 to review the following change. Change subject: encoding-test: clean up bitshuffle tests a little ..

[kudu-CR] tools: avoid extra 100ms sleep at end of table scan

2020-01-15 Thread Todd Lipcon (Code Review)
Hello Yingchun Lai, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15040 to review the following change. Change subject: tools: avoid extra 100ms sleep at end of table scan .. tools: avoid

[kudu-CR] memrowset: small optimizations for scanning

2019-12-10 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14874 to review the following change. Change subject: memrowset: small optimizations for scanning .. memrowset: small

[kudu-CR] client: use dense hash set in Batcher

2019-12-10 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14869 to look at the new patch set (#3). Change subject: client: use dense_hash_set in Batcher

[kudu-CR] client: optimize destruction of WriteRpc

2019-12-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14868 ) Change subject: client: optimize destruction of WriteRpc .. Patch Set 2: Verified+1 Strange python packaging issue (unable to find

[kudu-CR] client: optimize destruction of WriteRpc

2019-12-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: client: optimize destruction of WriteRpc .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14868 To unsubscribe, visit

[kudu-CR] client: optimize destruction of WriteRpc

2019-12-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14868 ) Change subject: client: optimize destruction of WriteRpc .. client: optimize destruction of WriteRpc When writing batches with

[kudu-CR] client: optimize destruction of WriteRpc

2019-12-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14868 ) Change subject: client: optimize destruction of WriteRpc .. Patch Set 2: > Patch Set 2: Code-Review+2 > > > not a race, I just didn't

[kudu-CR] Improve SIMD code generation for primitive predicates

2019-12-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14855 ) Change subject: Improve SIMD code generation for primitive predicates .. Improve SIMD code generation for primitive predicates

[kudu-CR] client: optimize destruction of WriteRpc

2019-12-09 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14868 to look at the new patch set (#2). Change subject: client: optimize destruction of WriteRpc

[kudu-CR] Improve SIMD code generation for primitive predicates

2019-12-09 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14855 to look at the new patch set (#4). Change subject: Improve SIMD code generation for primitive predicates

[kudu-CR] client: optimize destruction of WriteRpc

2019-12-09 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14868 to review the following change. Change subject: client: optimize destruction of WriteRpc .. client:

[kudu-CR] client: use dense hash set in Batcher

2019-12-09 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14869 to review the following change. Change subject: client: use dense_hash_set in Batcher .. client: use

[kudu-CR] Improve SIMD code generation for primitive predicates

2019-12-06 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14855 to look at the new patch set (#3). Change subject: Improve SIMD code generation for primitive predicates

[kudu-CR] Improve SIMD code generation for primitive predicates

2019-12-05 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14855 to look at the new patch set (#2). Change subject: Improve SIMD code generation for primitive predicates

[kudu-CR] Improve SIMD code generation for primitive predicates

2019-12-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14855 Change subject: Improve SIMD code generation for primitive predicates .. Improve SIMD code generation for primitive predicates This adds

<    1   2   3   4   5   6   7   8   9   10   >