[kudu-CR] WIP: support SPNEGO for web server

2019-05-15 Thread Todd Lipcon (Code Review)
Hello Lars Volker, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13341 to review the following change. Change subject: WIP: support SPNEGO for web server .. WIP: support

[Impala-ASF-CR] WIP: temporal query support for Kudu tables

2019-05-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13342 Change subject: WIP: temporal query support for Kudu tables .. WIP: temporal query support for Kudu tables This adds support for 'table

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 14: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 7: Code-Review+2 Forwarding

[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support .. IMPALA-8369 (part 3): Hive 3:

[Impala-ASF-CR] IMPALA-8121: part 3: invalidate on memory pressure

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13302 ) Change subject: IMPALA-8121: part 3: invalidate on memory pressure .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8369 : Skip test owner privileges test when running against Hive-3

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13339 ) Change subject: IMPALA-8369 : Skip test_owner_privileges test when running against Hive-3 .. Patch Set 2: Code-Review+2 -- To view,

[kudu-CR] system ntp: wait for sync via kernel

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13323 ) Change subject: system_ntp: wait for sync via kernel .. Patch Set 2: (1 comment)

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. fe: set classpath using maven dependency resolution This

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 6: Code-Review+2 Forwarding +2 -- To view, visit

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-14 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13251 to look at the new patch set (#5). Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-8509. Lazily evaluate LOAD sections during data load

2019-05-13 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13252 to look at the new patch set (#4). Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13251 to look at the new patch set (#4). Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-13 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13259 to look at the new patch set (#3). Change subject: Improve output for generate-schema-statements.py

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-8509. Lazily evaluate LOAD sections during data load

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13252 ) Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8528: Refactor authorization check in AnalysisContext

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13285 ) Change subject: IMPALA-8528: Refactor authorization check in AnalysisContext .. Patch Set 7: Code-Review+2 -- To view, visit

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 1: I don't think that's right. Looking at the CMakeLists.txt file, it has:

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Todd Lipcon (Code Review)
Hello Laszlo Gaal, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13286 to look at the new patch set (#2). Change subject: Update cmake to 3.14.3 .. Update cmake to 3.14.3

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13286 ) Change subject: Update cmake to 3.14.3 .. Patch Set 1: Oh, looks like maybe it's a bug in the CMakeLists.txt. the if() statement uses

[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13322 ) Change subject: Exclude kafka dependency from ranger-plugins-audit .. Patch Set 1: Merged that one, guess we can rebase this one and

[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13276 ) Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3 .. IMPALA-8369 [Test fixes] More test

[Impala-ASF-CR] IMPALA-8369 : Fix for tests failing with incompatible column changes

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13254 ) Change subject: IMPALA-8369 : Fix for tests failing with incompatible column changes .. IMPALA-8369 : Fix for tests failing

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 8: (13 comments)

[Impala-ASF-CR] Exclude kafka dependency from ranger-plugins-audit

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13322 ) Change subject: Exclude kafka dependency from ranger-plugins-audit .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] system ntp: wait for sync via kernel and shorten wait time

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13323 ) Change subject: system_ntp: wait for sync via kernel and shorten wait time .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8528: Refactor authorization check in AnalysisContext

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13285 ) Change subject: IMPALA-8528: Refactor authorization check in AnalysisContext .. Patch Set 6: (2 comments) Not quite following the

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 ) Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config .. Patch Set 3: > We can include information about

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: fe: set classpath using maven dependency resolution .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/13185 To

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 5: Verified+1 Test failure was an unrelated apparent

[Impala-ASF-CR] IMPALA-8072: addendum: don't require fe rebuild for config

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13288 ) Change subject: IMPALA-8072: addendum: don't require fe rebuild for config .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6042: Allow Impala shell to use a global impalarc config

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 ) Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config .. Patch Set 1: One question about the usability of

[Impala-ASF-CR] IMPALA-8369 : Fix for tests failing with incompatible column changes

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13254 ) Change subject: IMPALA-8369 : Fix for tests failing with incompatible column changes .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8530: Return more user friendly error messages on unsupported SQL

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 ) Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8369 [Test fixes] More test fixes when running against Hive-3

2019-05-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13276 ) Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3 .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution

2019-05-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution .. IMPALA-8369 (part 2): Hive 3: switch to

[Impala-ASF-CR] IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution

2019-05-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8516. Update maven for Jenkins builds

2019-05-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13268 ) Change subject: IMPALA-8516. Update maven for Jenkins builds .. IMPALA-8516. Update maven for Jenkins builds This changes Maven

[Impala-ASF-CR] IMPALA-8516. Update maven for Jenkins builds

2019-05-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13268 ) Change subject: IMPALA-8516. Update maven for Jenkins builds .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.7.x) KUDU-2395 (part 1): cache logged-in user

2019-05-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13250 ) Change subject: KUDU-2395 (part 1): cache logged-in user .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8121: part 2: use local catalog in containers

2019-05-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13226 ) Change subject: IMPALA-8121: part 2: use local catalog in containers .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8121: part 2: use local catalog in containers

2019-05-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13226 ) Change subject: IMPALA-8121: part 2: use local catalog in containers .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-8527: disable apache.snapshots.https repo

2019-05-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13296 ) Change subject: IMPALA-8527: disable apache.snapshots.https repo .. Patch Set 1: Code-Review+2 Does 'mvn dependency:list-repositories'

[Impala-ASF-CR] IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution

2019-05-09 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13224 to look at the new patch set (#9). Change subject: IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN

[Impala-ASF-CR] IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution

2019-05-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution .. Patch Set 8: went with a single NM as you suggested,

[Impala-ASF-CR] IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution

2019-05-09 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13224 to look at the new patch set (#8). Change subject: IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN

[Impala-ASF-CR] IMPALA-8516. Update maven for Jenkins builds

2019-05-09 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13268 to look at the new patch set (#4). Change subject: IMPALA-8516. Update maven for Jenkins builds

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-08 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13289 to look at the new patch set (#2). Change subject: expr-test: use gtest parameterization ..

[Impala-ASF-CR] Allow running backend tests sharded and in parallel

2019-05-08 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13290 to look at the new patch set (#2). Change subject: Allow running backend tests sharded and in parallel

[Impala-ASF-CR] expr-test: use gtest parameterization

2019-05-08 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13289 to review the following change. Change subject: expr-test: use gtest parameterization .. expr-test: use gtest

[Impala-ASF-CR] WIP: Allow running tests sharded and in parallel

2019-05-08 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13290 to review the following change. Change subject: WIP: Allow running tests sharded and in parallel .. WIP: Allow

[Impala-ASF-CR] IMPALA-2029. Implement our own getJNIEnv equivalent

2019-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13275 ) Change subject: IMPALA-2029. Implement our own getJNIEnv equivalent .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-2029. Implement our own getJNIEnv equivalent

2019-05-08 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13275 to look at the new patch set (#2). Change subject: IMPALA-2029. Implement our own getJNIEnv equivalent

[native-toolchain-CR] Update cmake to 3.14.3

2019-05-08 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13286 to review the following change. Change subject: Update cmake to 3.14.3 .. Update cmake to 3.14.3 This updates to

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 2: (2 comments)

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-08 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Fredy Wijaya, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13185 to look at the new patch set (#2). Change subject: fe: set classpath using maven dependency resolution

[Impala-ASF-CR] IMPALA-8527: prune maven repo dependencies

2019-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13279 ) Change subject: IMPALA-8527: prune maven repo dependencies .. Patch Set 6: Code-Review+2 Let's get this in as soon as we see the

[Impala-ASF-CR] IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution

2019-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution .. Patch Set 7: > Patch Set 7: > > I ran this (without

[Impala-ASF-CR] IMPALA-8516. Update maven for Jenkins builds

2019-05-08 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13268 to look at the new patch set (#2). Change subject: IMPALA-8516. Update maven for Jenkins builds

[Impala-ASF-CR] IMPALA-8516. Update maven for Jenkins builds

2019-05-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13268 ) Change subject: IMPALA-8516. Update maven for Jenkins builds .. Patch Set 1: Apparently Maven 3.6.1 doesn't build Impala because it

[Impala-ASF-CR] IMPALA-2029. Implement our own getJNIEnv equivalent

2019-05-07 Thread Todd Lipcon (Code Review)
Hello Joe McDonnell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13275 to review the following change. Change subject: IMPALA-2029. Implement our own getJNIEnv equivalent ..

[Impala-ASF-CR] IMPALA-8516. Update maven for Jenkins builds

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13268 ) Change subject: IMPALA-8516. Update maven for Jenkins builds .. Patch Set 1: Do we need to change bin/bootstrap_build.sh as well? Just

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-07 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13251 to look at the new patch set (#3). Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-07 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13259 to look at the new patch set (#2). Change subject: Improve output for generate-schema-statements.py

[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-07 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13236 to look at the new patch set (#5). Change subject: IMPALA-8369 (part 3): Hive 3: fix

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 2: (3 comments)

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8516. Update maven for Jenkins builds

2019-05-07 Thread Todd Lipcon (Code Review)
Hello Joe McDonnell, Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13268 to review the following change. Change subject: IMPALA-8516. Update maven for Jenkins builds ..

[Impala-ASF-CR] IMPALA-8369 : Fix for tests failing with incompatible column changes

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13254 ) Change subject: IMPALA-8369 : Fix for tests failing with incompatible column changes .. Patch Set 3: Code-Review+2 -- To view, visit

[native-toolchain-CR] Fix issues with toolchain Python and bump version

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13249 ) Change subject: Fix issues with toolchain Python and bump version .. Patch Set 1: Code-Review+2 (1 comment)

[native-toolchain-CR] Fix issues with toolchain Python and bump version

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13249 ) Change subject: Fix issues with toolchain Python and bump version .. Patch Set 1: (3 comments)

[Impala-ASF-CR] Drop statestore update frequency during data loading

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13260 ) Change subject: Drop statestore update frequency during data loading .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 6: (5 comments)

[Impala-ASF-CR] [IMPALA-8435] Prohibit operations on full transactional table.

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13253 ) Change subject: [IMPALA-8435] Prohibit operations on full transactional table. .. Patch Set 2: (9 comments) What about ALTER? Both in

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-07 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13259 to review the following change. Change subject: Improve output for generate-schema-statements.py .. Improve

[Impala-ASF-CR] IMPALA-8369 : Fix for tests failing with incompatible column changes

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13254 ) Change subject: IMPALA-8369 : Fix for tests failing with incompatible column changes .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Drop statestore update frequency during data loading

2019-05-07 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13260 to review the following change. Change subject: Drop statestore update frequency during data loading .. Drop

[Impala-ASF-CR] WIP: nice progress bars for data loading

2019-05-07 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13261 to review the following change. Change subject: WIP: nice progress bars for data loading .. WIP: nice

[Impala-ASF-CR] IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution

2019-05-07 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13224 to look at the new patch set (#6). Change subject: IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN

[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-07 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13236 to look at the new patch set (#4). Change subject: IMPALA-8369 (part 3): Hive 3: fix

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-06 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13251 to review the following change. Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

[Impala-ASF-CR] IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution

2019-05-06 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13224 to look at the new patch set (#5). Change subject: IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN

[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-06 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13236 to look at the new patch set (#3). Change subject: IMPALA-8369 (part 3): Hive 3: fix

[Impala-ASF-CR] IMPALA-8509. Lazily evaluate LOAD sections during data load

2019-05-06 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13252 to review the following change. Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load

[Impala-ASF-CR] Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-8499: avoid datetime.total seconds() in test insert events

2019-05-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13245 ) Change subject: IMPALA-8499: avoid datetime.total_seconds() in test_insert_events .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13224 to look at the new patch set (#4). Change subject: Hive 3: switch to Tez-on-YARN execution

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: Hive 3: switch to Tez-on-YARN execution .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13236 Change subject: Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Hive 3: fix test_permanent_udfs.py for Hive 3 support This

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13224 to look at the new patch set (#3). Change subject: Hive 3: switch to Tez-on-YARN execution

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: Hive 3: switch to Tez-on-YARN execution .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-8472: Fix the refresh privilege workaround in Ranger

2019-05-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13229 ) Change subject: IMPALA-8472: Fix the refresh privilege workaround in Ranger .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Todd Lipcon (Code Review)
Hello Yongzhi Chen, Vihang Karajgaonkar, Sudhanshu Arora, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13224 to look at the new patch set (#2). Change subject: Hive 3: switch to Tez-on-YARN execution

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: Hive 3: switch to Tez-on-YARN execution .. Patch Set 1: (6 comments)

<    3   4   5   6   7   8   9   10   11   12   >