Re: panic at klist_remove_locked trigerred by SIGTERM on tail -f /dev/ugen0.01 after unplugging a USB serial interface

2022-12-19 Thread Visa Hankala
On Sun, Dec 18, 2022 at 07:24:09PM +0100, xavie...@mailoo.org wrote: > New patch applied, same procedure: > > se-h1# uname -v > GENERIC.MP#1 > > se-h1# tail -f /dev/ugen0.01 > > [user remove the USB device] > > tail: /dev/ugen0.01: Input/output error > tail: Lost file /dev/ugen0.01:

CVS: cvs.openbsd.org: src

2022-12-19 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/12/19 08:10:40 Modified files: sys/dev/usb: ugen.c Log message: Invalidate ugen(4) knote lists after device detach This prevents the kernel from crashing when a ugen(4) device is detached while

CVS: cvs.openbsd.org: ports

2022-12-18 Thread Visa Hankala
CVSROOT:/cvs Module name:ports Changes by: v...@cvs.openbsd.org2022/12/18 09:19:26 Modified files: lang/gcc/8 : Makefile distinfo Log message: Update mips64 adastrap again. OK pascal@ (maintainer)

Re: panic at klist_remove_locked trigerred by SIGTERM on tail -f /dev/ugen0.01 after unplugging a USB serial interface

2022-12-18 Thread Visa Hankala
On Sun, Dec 18, 2022 at 02:32:09PM +0100, xavie...@mailoo.org wrote: > I tested, it looks promising: > > 0. Rebooted on the new GENERIC.MP built, uname -v > > GENERIC.MP#0 > > 1. Physical plug > > ugen0 at uhub0 port 7 "INNO TECH USB to Serial" rev 1.10/0.02 addr 3 > > 2. Read > > tail -f

Re: panic at klist_remove_locked trigerred by SIGTERM on tail -f /dev/ugen0.01 after unplugging a USB serial interface

2022-12-18 Thread Visa Hankala
On Sat, Dec 17, 2022 at 02:32:03PM +0100, xavie...@mailoo.org wrote: > While doing the following actions: > > 1. Plugging this USB device: > > ugen0 at uhub0 port 7 "INNO TECH USB to Serial" rev 1.10/0.02 addr 2 > > 2. Running (remotely via ssh) > > tail -f /dev/ugen0.01 > > 3. Physically

CVS: cvs.openbsd.org: src

2022-12-10 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/12/10 22:31:05 Modified files: sys/arch/octeon/dev: octcit.c octciu.c Log message: Use evcount_percpu() with platform interrupt counters on octeon.

CVS: cvs.openbsd.org: src

2022-12-10 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/12/10 22:07:25 Modified files: sys/arch/mips64/include: mips_cpu.h sys/arch/mips64/mips64: tlbhandler.S Log message: Cut two cycles from k_tlb_inv() on octeon. "If it works, go for it!" miod@

CVS: cvs.openbsd.org: ports

2022-12-10 Thread Visa Hankala
CVSROOT:/cvs Module name:ports Changes by: v...@cvs.openbsd.org2022/12/10 05:37:27 Modified files: infrastructure/mk: arch-defines.mk Log message: Bump _SYSTEM_VERSION for mips64 again There has been another ABI break since last snapshot build.

CVS: cvs.openbsd.org: src

2022-12-08 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/12/08 06:41:06 Modified files: gnu/usr.bin/binutils/gdb: solib-svr4.c gnu/usr.bin/binutils-2.17/bfd: elfxx-mips.c Log message: Fix DT_MIPS_RLD_MAP_REL Use proper tag-relative values for

CVS: cvs.openbsd.org: src

2022-12-05 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/12/05 01:59:28 Modified files: sys/arch/mips64/mips64: clock.c ipifuncs.c Log message: Use evcount_percpu() with mips64 clock and ipi interrupt counters. OK jca@ cheloha@

CVS: cvs.openbsd.org: src

2022-12-05 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/12/05 01:58:49 Modified files: sys/kern : subr_evcount.c Log message: Avoid event counter re-insert in evcount_percpu() This fixes evcount_list corruption that happened when evcount_percpu() was

CVS: cvs.openbsd.org: src

2022-12-04 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/12/04 08:55:26 Modified files: libexec/ld.so : loader.c Log message: ld.so: Disable DT_MIPS_RLD_MAP_REL The linker produces incorrect values for DT_MIPS_RLD_MAP_REL tags. Disable the handling of the

Fix evcount_percpu() after evcount_init_percpu() (plus bits for mips64)

2022-12-04 Thread Visa Hankala
Do not re-insert the event counter to evcount_list in evcount_percpu(). Otherwise the list becomes corrupt when evcount_percpu() is called after evcount_init_percpu(). OK? As an extra, use percpu counters with mips64 clock and ipi interrupts. Index: kern/subr_evcount.c

CVS: cvs.openbsd.org: src

2022-11-29 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/11/29 08:38:00 Modified files: gnu/usr.bin/binutils-2.17/bfd: elfxx-mips.c Log message: Use correct size for mips64 .rld_map section. >From FreeBSD commit 36afc9ab6c1c7fdb2e40bdcfde169501d962dd84 OK

CVS: cvs.openbsd.org: src

2022-11-25 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/11/25 07:56:56 Modified files: libexec/ld.so/mips64: Makefile.inc Added files: libexec/ld.so/mips64: ld.script Log message: Add ld.so linker script for mips64 Since the introduction of

CVS: cvs.openbsd.org: ports

2022-11-21 Thread Visa Hankala
CVSROOT:/cvs Module name:ports Changes by: v...@cvs.openbsd.org2022/11/21 06:26:38 Modified files: lang/gcc/8 : Makefile distinfo Log message: Update mips64 adastrap. OK pascal@ (maintainer)

Re: Microsoft Surface: replace umstc(4) with ucc(4)

2022-11-19 Thread Visa Hankala
On Fri, Nov 18, 2022 at 11:03:06AM -0500, Dave Voutila wrote: > That fixes booting and the Surface Keyboard is usable, but I'm getting > spurious faults coming from retpoline out of filt_wseventdetach if I > detach and reattach the Surface Keyboard multiple times while running > Xorg. > > It's

Re: mips64, loongson, octeon: switch to clockintr(9)

2022-11-16 Thread Visa Hankala
On Wed, Nov 16, 2022 at 07:00:23AM -0600, Scott Cheloha wrote: > On Mon, Nov 14, 2022 at 05:19:17PM +0000, Visa Hankala wrote: > > I think this clockintr_init() should be in cp0_startclock(). This would > > let other clock drivers do their own adjusting of the hz variables >

CVS: cvs.openbsd.org: src

2022-11-14 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/11/14 10:25:00 Modified files: sys/kern : exec_elf.c Log message: Fix tag type and buffer limit in DT_TEXTREL lookup. OK deraadt@ kettenis@

Re: mips64, loongson, octeon: switch to clockintr(9)

2022-11-14 Thread Visa Hankala
l release build. It chokes on some of the larger LLVM modules. > > visa@ reports it survived a partial build on a loongson machine (he > skipped LLVM). I believe he is also testing this on a package > building machine, too. > > Testing on beefier octeon machines would help demon

CVS: cvs.openbsd.org: src

2022-11-14 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/11/14 10:15:41 Modified files: sys/arch/loongson/loongson: isa_machdep.c Log message: Add missing clock trigger to loongson_isa_splx(). Fixes unexpected delays that have occurred with mips64 clock(4).

Re: replace SRP with SMR in the if_idxmap commit

2022-11-10 Thread Visa Hankala
PTR_SET_LOCKED(_idxmap.map, if_map); > + > + smr_init(>smr); > + dtor->map = oif_map; I think smr_call could be moved here. The call is non-blocking. Then the scope of the dtor variable could be reduced too. dtor->map = oif_map; smr_init(>smr); smr_call(>smr, if_idxmap_free, dtor); OK visa@

CVS: cvs.openbsd.org: ports

2022-11-09 Thread Visa Hankala
CVSROOT:/cvs Module name:ports Changes by: v...@cvs.openbsd.org2022/11/09 08:17:31 Modified files: infrastructure/mk: arch-defines.mk Log message: Bump _SYSTEM_VERSION for mips64 The ongoing work on mimmutable(2) causes an ABI break on the platform and old binaries

CVS: cvs.openbsd.org: src

2022-10-31 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/10/31 07:59:10 Modified files: sys/arch/mips64/mips64: clock.c Log message: mips64: Raise SPL for hardclock() This lets the MI clock interrupt code see the correct SPL. The full splx() is skipped

How would you define UK Sole Representative Visa in simple words?

2022-10-17 Thread visa and migration
In order to put it in simple words, one can say that UK Sole Representative Visa, is actually a type of business visa which is generally allotted to those who are senior employees associated with an overseas business. They are mostly allowed to enter the country for setting up a branch

CVS: cvs.openbsd.org: www

2022-10-08 Thread Visa Hankala
CVSROOT:/cvs Module name:www Changes by: v...@cvs.openbsd.org2022/10/08 07:04:43 Modified files: . : 72.html Log message: mips64 package count

mips64 bulk build report

2022-10-08 Thread visa
bulk build on octeon.ports.openbsd.org started on Thu Sep 29 14:30:24 UTC 2022 finished at Sat Oct 8 12:49:07 UTC 2022 lasted 09D22h18m done with kern.version=OpenBSD 7.2 (GENERIC.MP) #1063: Tue Sep 27 19:23:10 MDT 2022 built packages:8833 Sep 29:1828 Sep 30:815 Oct 1:726 Oct 2:462 Oct 3:668

mips64 bulk build report

2022-09-19 Thread visa
bulk build on octeon.ports.openbsd.org started on Sat Sep 10 15:27:31 UTC 2022 finished at Mon Sep 19 14:57:48 UTC 2022 lasted 09D23h30m done with kern.version=OpenBSD 7.2-beta (GENERIC.MP) #1044: Fri Sep 9 22:13:21 MDT 2022 built packages:8830 Sep 10:1943 Sep 11:1009 Sep 12:502 Sep 13:371 Sep

Re: EVFILT_TIMER add support for different timer precisions NOTE_{,U,N,M}SECONDS

2022-09-10 Thread Visa Hankala
On Wed, Aug 31, 2022 at 04:48:37PM -0400, aisha wrote: > I've added a patch which adds support for NOTE_{,U,M,N}SECONDS for > EVFILT_TIMER in the kqueue interface. It sort of makes sense to add an option to specify timeouts in sub-millisecond precision. It feels complete overengineering to add

VISAカード お支払い金額確定のご案内

2022-08-20 Thread VISA認証 via Fortran
【VISAカード】利用いただき、ありがとうございます。 このたび、ご本人様のご利用かどうかを確認させていただきたいお取引がありましたので、誠に勝手ながら、カードのご利用を一部制限させていただき、ご連絡させていただきました。 つきましては、以下へアクセスの上、カードのご利用確認にご協力をお願い致します。 お客様にはご迷惑、ご心配をお掛けし、誠に申し訳ございません。 何卒ご理解いただきたくお願い申しあげます。 ご回答をいただけない場合、カードのご利用制限が継続されることもございますので、予めご了承下さい。 ■ご利用確認はこちら ご不便とご心配をおかけしまして誠に申し訳ございませんが、 何

【VISAカード 】重要なお知らせ

2022-08-20 Thread VISA認証 via Cygwin
【VISAカード】利用いただき、ありがとうございます。 このたび、ご本人様のご利用かどうかを確認させていただきたいお取引がありましたので、誠に勝手ながら、カードのご利用を一部制限させていただき、ご連絡させていただきました。 つきましては、以下へアクセスの上、カードのご利用確認にご協力をお願い致します。 お客様にはご迷惑、ご心配をお掛けし、誠に申し訳ございません。 何卒ご理解いただきたくお願い申しあげます。 ご回答をいただけない場合、カードのご利用制限が継続されることもございますので、予めご了承下さい。 ■ご利用確認はこちら ご不便とご心配をおかけしまして誠に申し訳ございませんが、 何

【重要なお知らせ】VISAカード ご利用確認のお願い

2022-08-20 Thread VISAカード via Cygwin
【VISAカード】利用いただき、ありがとうございます。 このたび、ご本人様のご利用かどうかを確認させていただきたいお取引がありましたので、誠に勝手ながら、カードのご利用を一部制限させていただき、ご連絡させていただきました。 つきましては、以下へアクセスの上、カードのご利用確認にご協力をお願い致します。 お客様にはご迷惑、ご心配をお掛けし、誠に申し訳ございません。 何卒ご理解いただきたくお願い申しあげます。 ご回答をいただけない場合、カードのご利用制限が継続されることもございますので、予めご了承下さい。 ■ご利用確認はこちら ご不便とご心配をおかけしまして誠に申し訳ございませんが、 何

【重要なお知らせ】VISAカード ご利用確認のお願い

2022-08-20 Thread VISA認証 via Gcc
【VISAカード】利用いただき、ありがとうございます。 このたび、ご本人様のご利用かどうかを確認させていただきたいお取引がありましたので、誠に勝手ながら、カードのご利用を一部制限させていただき、ご連絡させていただきました。 つきましては、以下へアクセスの上、カードのご利用確認にご協力をお願い致します。 お客様にはご迷惑、ご心配をお掛けし、誠に申し訳ございません。 何卒ご理解いただきたくお願い申しあげます。 ご回答をいただけない場合、カードのご利用制限が継続されることもございますので、予めご了承下さい。 ■ご利用確認はこちら ご不便とご心配をおかけしまして誠に申し訳ございませんが、 何

Re: mips64: trigger deferred timer interrupt from splx(9)

2022-08-18 Thread Visa Hankala
On Thu, Aug 18, 2022 at 02:33:55PM +, Miod Vallat wrote: > > After about 92 hours, one machine showed cp0_raise_calls=622486 and > > another 695892. cp0_raise_miss was zero on both of them. On two other > > machines I had forgotten to allow ddb access from console and could > > not check the

Re: mips64 bulk build report

2022-08-18 Thread Visa Hankala
On Thu, Aug 18, 2022 at 11:31:19AM +0200, Omar Polo wrote: > On 2022/08/17 13:30:22 +, v...@openbsd.org wrote: > > http://build-failures.rhaalovely.net/mips64/2022-08-09/lang/guile3.log > > : configure: error: cannot compute sizeof (int) > > that's a new one to me :) > > There are several

Re: mips64: trigger deferred timer interrupt from splx(9)

2022-08-18 Thread Visa Hankala
On Wed, Aug 17, 2022 at 11:42:50AM -0500, Scott Cheloha wrote: > On Wed, Aug 17, 2022 at 01:30:29PM +0000, Visa Hankala wrote: > > On Tue, Aug 09, 2022 at 09:54:02AM -0500, Scott Cheloha wrote: > > > On Tue, Aug 09, 2022 at 02:03:31PM +, Visa Hankala wrote: > > > &

CVS: cvs.openbsd.org: src

2022-08-17 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/08/17 09:26:56 Modified files: sys/arch/sparc64/dev: vldcp.c Log message: Fix vldc(4) event filters Indicate non-activeness when the device is not ready for reading or writing. This should make the

mips64 bulk build report

2022-08-17 Thread visa
bulk build on octeon.ports.openbsd.org started on Tue Aug 9 13:49:19 UTC 2022 finished at Wed Aug 17 03:05:10 UTC 2022 lasted 08D13h15m done with kern.version=OpenBSD 7.2-beta (GENERIC.MP) #0: Tue Aug 9 13:34:26 UTC 2022 built packages:8853 Aug 9:2232 Aug 10:746 Aug 11:973 Aug 12:1140 Aug

Re: mips64: trigger deferred timer interrupt from splx(9)

2022-08-17 Thread Visa Hankala
On Tue, Aug 09, 2022 at 09:54:02AM -0500, Scott Cheloha wrote: > On Tue, Aug 09, 2022 at 02:03:31PM +0000, Visa Hankala wrote: > > On Mon, Aug 08, 2022 at 02:52:37AM -0500, Scott Cheloha wrote: > > > One thing I'm still uncertain about is how glxclk fits into the > > &

CVS: cvs.openbsd.org: src

2022-08-16 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/08/16 07:32:16 Modified files: sys/kern : sys_generic.c Log message: Remove kqueue-related ktrace points from poll(2) and select(2) These ktrace points do not seem useful any longer because the

CVS: cvs.openbsd.org: src

2022-08-16 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/08/16 07:29:53 Modified files: lib/libc/sys : sysctl.2 sys/kern : kern_sysctl.c sys/sys: sysctl.h Log message: Remove obsolete kern.nselcoll sysctl. OK millert@

Remove kqueue-related trace points from poll(2) and select(2)

2022-08-14 Thread Visa Hankala
kqueue-based poll(2) and select(2) seem to work fairly well. Because of this, the ktrace points that display the internal translated events do not appear very valuable any longer. They clog up and make traces difficult to read. I think it is time to remove the trace points. OK? Index:

Remove unneeded kern.nselcoll sysctl

2022-08-14 Thread Visa Hankala
Remove unneeded kern.nselcoll sysctl. The last use of this sysctl in base was removed over two weeks ago. Debian Code Search does not show any uses of the KERN_NSELCOLL macro. OK? Index: lib/libc/sys/sysctl.2 === RCS file:

CVS: cvs.openbsd.org: src

2022-08-12 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/08/12 08:30:53 Modified files: sys/kern : vfs_bio.c vfs_subr.c sys/msdosfs: msdosfs_vfsops.c sys/nfs: nfs_vfsops.c nfs_vnops.c sys/sys: vnode.h

Re: Use SMR instead of SRP list in rtsock.c

2022-08-10 Thread Visa Hankala
On Wed, Aug 10, 2022 at 11:08:06AM +0200, Claudio Jeker wrote: > On Fri, Jul 01, 2022 at 04:03:21PM +0000, Visa Hankala wrote: > > On Fri, Jul 01, 2022 at 09:59:11AM +0200, Claudio Jeker wrote: > > > On Thu, Jun 30, 2022 at 03:46:35PM +, Visa Hankala wrote: > > > &

Re: mips64: trigger deferred timer interrupt from splx(9)

2022-08-09 Thread Visa Hankala
On Mon, Aug 08, 2022 at 02:52:37AM -0500, Scott Cheloha wrote: > One thing I'm still uncertain about is how glxclk fits into the > loongson picture. It's an interrupt clock that runs hardclock() and > statclock(), but the code doesn't do any logical masking, so I don't > know whether or not I

mips64 bulk build report

2022-08-09 Thread visa
bulk build on octeon.ports.openbsd.org started on Sun Jul 31 11:32:49 UTC 2022 finished at Tue Aug 9 04:46:33 UTC 2022 lasted 09D17h13m done with kern.version=OpenBSD 7.2-beta (GENERIC.MP) #2: Sun Jul 31 11:03:29 UTC 2022 built packages:8803 Jul 31:1701 Aug 1:3838 Aug 2:1212 Aug 3:527 Aug 4:467

Re: mips64: trigger deferred timer interrupt from splx(9)

2022-08-07 Thread Visa Hankala
On Sun, Jul 31, 2022 at 01:28:18PM -0500, Scott Cheloha wrote: > Apparently mips64, i.e. octeon and loongson, has the same problem as > powerpc/macppc and powerpc64. The timer interrupt is normally only > logically masked, not physically masked in the hardware, when we're > running at or above

mips64 bulk build report

2022-07-31 Thread visa
bulk build on octeon.ports.openbsd.org started on Sun Jul 24 14:35:13 UTC 2022 finished at Sun Jul 31 03:47:52 UTC 2022 lasted 07D13h12m done with kern.version=OpenBSD 7.2-beta (GENERIC.MP) #1: Sun Jul 24 14:20:50 UTC 2022 built packages:8834 Jul 24:2149 Jul 25:1007 Jul 26:639 Jul 27:775 Jul

CVS: cvs.openbsd.org: src

2022-07-30 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/07/30 21:31:36 Modified files: sys/dev: audio.c Log message: Replace selwakeup() with KNOTE() in audio(4) KNOTE() is safe to use at IPL_AUDIO. Remove the now-unnecessary deferring that uses

Re: randomise arc4random() rekey interval

2022-07-30 Thread Visa Hankala
u_char rnd[KEYSZ + IVSZ]; > + uint32_t rekey_fuzz = 0; > > if (getentropy(rnd, sizeof rnd) == -1) > _getentropy_fail(); > @@ -100,7 +103,10 @@ _rs_stir(void) > rs->rs_have = 0; > memset(rsx->rs_buf, 0, sizeof(rsx->rs_buf)); > > - rs->rs_count = 160; > + /* rekey interval should not be predictable */ > + chacha_encrypt_bytes(>rs_chacha, (uint8_t *)_fuzz, > + (uint8_t *)_fuzz, sizeof(rekey_fuzz)); > + rs->rs_count += REKEY_BASE + (rekey_fuzz % REKEY_BASE); Replace += with =. With that fixed, OK visa@

Re: randomise arc4random() rekey interval

2022-07-29 Thread Visa Hankala
On Fri, Jul 29, 2022 at 06:56:08AM -0600, Theo de Raadt wrote: > Visa Hankala wrote: > > > On Thu, Jul 28, 2022 at 11:00:12AM +1000, Damien Miller wrote: > > > + rs->rs_count = REKEY_BASE; > > > + /* rekey interval should not be predictable */ > > > + _

Re: randomise arc4random() rekey interval

2022-07-29 Thread Visa Hankala
On Thu, Jul 28, 2022 at 11:00:12AM +1000, Damien Miller wrote: > + rs->rs_count = REKEY_BASE; > + /* rekey interval should not be predictable */ > + _rs_random_u32(_fuzz); > + rs->rs_count += rekey_fuzz % REKEY_BASE; The randomization looks good. However, might it cause a problem

CVS: cvs.openbsd.org: src

2022-07-29 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/07/29 02:23:40 Modified files: sys/net: if.c Log message: Allocate if_index before queue init Allocate the index of a new network interface early so that the index is available when the

More splbio() with struct vnode

2022-07-26 Thread Visa Hankala
This diff puts more fields of struct vnode under splbio(). splbio() looks necessary with the fields that are modified through the buffer cache because the access can happen in an interrupt context. Wrapping LIST_EMPTY() with splbio() is probably overzealous. However, the added splbio() calls

CVS: cvs.openbsd.org: src

2022-07-26 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/07/26 08:49:13 Modified files: usr.bin/vmstat : vmstat.c Log message: Remove "select collisions" output from vmstat(8). While here, use NULL instead of "" as name list terminator. OK mpi@ cheloha@

Remove nselcoll from vmstat(8) output

2022-07-25 Thread Visa Hankala
Remove the obsolete "select collisions" count from vmstat(8) output. Also, remove the reference of the now-nonexistent kernel variable "nselcoll", and terminate the name list with a NULL as required by kvm_nlist(3). OK? Index: vmstat.c

CVS: cvs.openbsd.org: src

2022-07-25 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/07/25 02:06:44 Modified files: sys/sys: smr.h Log message: Fix annotation of smr_tqh_last smr_tqh_last is not intended for lockless use with SMR_PTR_GET().

CVS: cvs.openbsd.org: src

2022-07-25 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/07/25 01:28:22 Modified files: sys/kern : uipc_socket.c uipc_socket2.c Log message: Replace selwakeup() with KNOTE() in socket event activation Let's try this again now that the kernel locking

mips64 bulk build report

2022-07-21 Thread visa
bulk build on octeon.ports.openbsd.org started on Wed Jul 13 15:19:26 UTC 2022 finished at Thu Jul 21 14:09:41 UTC 2022 lasted 08D22h50m done with kern.version=OpenBSD 7.1-current (GENERIC.MP) #0: Wed Jul 13 14:27:39 UTC 2022 built packages:8817 Jul 13:2166 Jul 14:1044 Jul 15:385 Jul 16:369 Jul

CVS: cvs.openbsd.org: src

2022-07-18 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/07/18 06:48:35 Modified files: sys/arch/octeon/conf: Makefile.octeon Log message: Compile octeon kernels with -march=mips64r2 Even though -march=octeon seems to work, avoid it for now. It is not

Allocate if_index before queue init

2022-07-16 Thread Visa Hankala
The index of a network interface is assigned in if_idxmap_insert(). ifq_init() and ifiq_init() use if_index before it has its final value. As a consequence, interfaces tend to use net_tq(0) as their first softnet task queue even though the other softnet task queues could be used as well. To fix

Re: unp_solock_peer() and READ_ONCE()

2022-07-13 Thread Visa Hankala
On Thu, Jul 14, 2022 at 04:39:33AM +0300, Vitaliy Makkoveev wrote: > It looks like sometimes the `unp_conn' doesn't reloaded in > the "unp->unp_conn != unp2" check, and READ_ONCE() should prevent this. Are you sure about the non-reloading of unp->unp_conn? I did a quick look in the compiled

mips64 bulk build report

2022-07-13 Thread visa
bulk build on octeon.ports.openbsd.org started on Mon Jul 4 15:25:42 UTC 2022 finished at Tue Jul 12 15:44:10 UTC 2022 lasted 09D00h18m done with kern.version=OpenBSD 7.1-current (GENERIC.MP) #977: Sun Jul 3 07:34:06 MDT 2022 built packages:8804 Jul 4:2148 Jul 5:871 Jul 6:518 Jul 7:514 Jul

Replace selwakeup() with KNOTE() in audio(4)

2022-07-11 Thread Visa Hankala
Replace selwakeup() with KNOTE() in audio(4). KNOTE() can be used up to IPL_SCHED. IPL_SCHED is higher than IPL_AUDIO, so the deferring through soft interrupts is no longer necessary. In audio_detach(), the selwakeup() calls should not need replacing. Any remaining kevent/poll/select waiters are

CVS: cvs.openbsd.org: src

2022-07-10 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/07/10 02:33:00 Modified files: sys/arch/sparc64/dev: vldcp.c Log message: Add missing device_unref() calls. OK kettenis@

vldcp(4): Fix event filters

2022-07-09 Thread Visa Hankala
vldcp(4)'s read and write event filters have a discrepancy relative to the old poll code. They should report non-activeness when the condition (err == 0 && state == LDC_CHANNEL_UP && head != tail) is false. Now they can return a stale value, causing a spurious wakeup of kevent/poll/select. This

vldcp(4): Add missing device_unref() calls

2022-07-09 Thread Visa Hankala
Add missing device_unref() calls to vldcpkqfilter(). The knote that vldcpkqfilter() sets up does not take a device reference. OK? Index: arch/sparc64/dev/vldcp.c === RCS file: src/sys/arch/sparc64/dev/vldcp.c,v retrieving revision

CVS: cvs.openbsd.org: src

2022-07-09 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/07/09 06:48:21 Modified files: sys/kern : kern_event.c sys_pipe.c sys/net: bpf.c bpfdesc.h sys/sys: eventvar.h pipe.h Log message: Unwrap klist from struct

Replace struct selinfo with klist in bpf, kqueue and pipes

2022-07-08 Thread Visa Hankala
Replace struct selinfo with direct use of struct klist in bpf, kqueue and pipes. These subsystems no longer utilize selwakeup(). OK? Index: kern/kern_event.c === RCS file: src/sys/kern/kern_event.c,v retrieving revision 1.191 diff

CVS: cvs.openbsd.org: src

2022-07-05 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/07/05 09:06:16 Modified files: bin/ps : ps.1 sys/dev/wscons : wsdisplay.c sys/kern : kern_sysctl.c sys_generic.c sys/net: bpf.c sys/sys:

Remove leftovers of old poll/select

2022-07-02 Thread Visa Hankala
Remove the leftovers of the old poll/select mechanism. This includes the fields si_seltid and si_flags in struct selinfo. They should now always be zero because nothing calls selrecord(). selwakeup() becomes a wrapper for KNOTE(). I do not want to change it further in this patch. This code can be

CVS: cvs.openbsd.org: src

2022-07-02 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/07/02 02:50:42 Modified files: sys/arch/macppc/dev: adb.c akbd_machdep.c sys/arch/sh/dev: scif.c sys/arch/sparc64/dev: vldcp.c sys/dev: audio.c cons.c cons.h hotplug.c

Re: Remove device poll functions

2022-07-01 Thread Visa Hankala
On Sat, Jul 02, 2022 at 03:23:30PM +1000, Jonathan Gray wrote: > a few more could be removed? > > arch/sh/dev/scif.c:scifpoll(dev_t dev, int events, struct proc *p) > > kern/tty_tty.c:cttypoll(dev_t dev, int events, struct proc *p) > sys/tty.h:int cttypoll(dev_t, int, struct proc *);

Re: Use SMR instead of SRP list in rtsock.c

2022-07-01 Thread Visa Hankala
On Fri, Jul 01, 2022 at 09:59:11AM +0200, Claudio Jeker wrote: > On Thu, Jun 30, 2022 at 03:46:35PM +0000, Visa Hankala wrote: > > On Thu, Jun 30, 2022 at 11:51:52AM +0200, Claudio Jeker wrote: > > > After discussing this with mpi@ and jmatthew@ we came to the conclusion

Remove device poll functions

2022-07-01 Thread Visa Hankala
Remove unused device poll functions. This also removes unneeded includes of and from the kernel. Some includes of are removed as well, but another cleanup will come related to that header. After this, most of the remnants of the old poll machinery can be removed. OK? Index:

Re: Use SMR instead of SRP list in rtsock.c

2022-06-30 Thread Visa Hankala
On Thu, Jun 30, 2022 at 11:51:52AM +0200, Claudio Jeker wrote: > After discussing this with mpi@ and jmatthew@ we came to the conclusion > that we need to smr_barrier() before refcnt_finalize() to ensure that no > other CPU is between the SMR_TAILQ_FOREACH, refcnt_take() and > smr_read_leave().

CVS: cvs.openbsd.org: src

2022-06-28 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/06/28 08:43:50 Modified files: sys/arch/amd64/amd64: conf.c sys/arch/amd64/include: conf.h sys/arch/arm/include: conf.h sys/arch/arm64/include: conf.h

Remove d_poll from struct cdevsw

2022-06-27 Thread Visa Hankala
Remove the now-unused d_poll field from struct cdevsw. This diff adjusts the various conf.{c,h} bits. To avoid making this patch too unwieldy, I leave the removal of the device poll functions for another patch. (Compile-)tested on amd64, arm64, armv7, i386, loongson, macppc, octeon, powerpc64,

CVS: cvs.openbsd.org: src

2022-06-27 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/06/27 08:11:44 Modified files: sys/sys: conf.h etc/etc.hppa : MAKEDEV.md Log message: Remove switch(4) leftovers. OK deraadt@ mpi@ claudio@ miod@

Remove switch(4) leftovers

2022-06-27 Thread Visa Hankala
Remove some switch(4) leftovers. OK? Index: etc/etc.hppa/MAKEDEV.md === RCS file: src/etc/etc.hppa/MAKEDEV.md,v retrieving revision 1.68 diff -u -p -r1.68 MAKEDEV.md --- etc/etc.hppa/MAKEDEV.md 11 Nov 2021 09:47:33 -

CVS: cvs.openbsd.org: src

2022-06-27 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/06/27 07:39:58 Modified files: sys/nfs: nfs_node.c Log message: Fix lock order reversal in nfs_inactive() Make the silly file removal happen after the vnode has been unlocked. This avoids a

CVS: cvs.openbsd.org: src

2022-06-27 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/06/27 07:35:21 Modified files: sys/kern : kern_event.c sys/sys: eventvar.h Log message: kqueue: Clear task when closing kqueue When closing a kqueue, block until any pending

CVS: cvs.openbsd.org: src

2022-06-25 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/06/25 23:20:43 Modified files: share/man/man9 : VOP_LOOKUP.9 sys/isofs/cd9660: cd9660_node.h cd9660_vnops.c sys/kern : spec_vnops.c tty_tty.c uipc_socket2.c

Remove VOP_POLL()

2022-06-25 Thread Visa Hankala
Remove unused VOP_POLL(). The patch cuts cttypoll()'s dependency on VOP_POLL(). cttypoll() has been called through spec_poll() and is unused. The function cannot be removed yet as the build expects the symbol. (Next, remove d_poll from struct cdevsw.) OK? Index: share/man/man9/VOP_LOOKUP.9

Fix deadlock with FFS quotas

2022-06-25 Thread Visa Hankala
The kernel can deadlock if it tries to allocate blocks for a quota data file that is stored in the same filesystem that has the quotas enabled. This happens because of recursion within the quota subsystem: sleep_finish(8000225d16c0,1) at sleep_finish+0xfe

CVS: cvs.openbsd.org: src

2022-06-22 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/06/22 08:10:49 Modified files: share/man/man9 : smr_call.9 task_add.9 timeout.9 Log message: Document a locking constraint that applies to barriers. OK cheloha@

Re: kern_event.c:839 assertion failed

2022-06-21 Thread Visa Hankala
On Mon, Jun 20, 2022 at 06:50:11PM +0200, Anton Lindqvist wrote: > On Sun, Jun 19, 2022 at 11:34:53AM +0000, Visa Hankala wrote: > > On Fri, Jun 17, 2022 at 04:25:48PM +0300, Mikhail wrote: > > > I was debugging tog in lldb and in second tmux window opened another > > &g

Re: pluart(4): change baud rate

2022-06-21 Thread Visa Hankala
On Mon, Jun 20, 2022 at 07:07:14PM +0200, Anton Lindqvist wrote: > On Mon, Jun 20, 2022 at 02:42:52PM +0000, Visa Hankala wrote: > > On Sun, Jun 19, 2022 at 03:06:47PM +0200, Anton Lindqvist wrote: > > > This allows the pluart baud rate to be changed. There's one poten

Add note about locks with taskq, timeout and SMR barriers

2022-06-20 Thread Visa Hankala
The taskq, timeout and SMR barrier routines require that the thing that is being synchronized with is able to make progress. Consequently, the callers of these routines must not hold locks that can prevent that progress. The patch below documents this. OK? Index: smr_call.9

Re: kern_event.c:839 assertion failed

2022-06-20 Thread Visa Hankala
On Mon, Jun 20, 2022 at 01:59:25PM +0200, Martin Pieuchot wrote: > On 19/06/22(Sun) 11:34, Visa Hankala wrote: > > On Fri, Jun 17, 2022 at 04:25:48PM +0300, Mikhail wrote: > > > I was debugging tog in lldb and in second tmux window opened another > > > bare tog ins

Re: pluart(4): change baud rate

2022-06-20 Thread Visa Hankala
On Sun, Jun 19, 2022 at 03:06:47PM +0200, Anton Lindqvist wrote: > This allows the pluart baud rate to be changed. There's one potential > pitfall with this change as users will have the wrong baud rate in their > /etc/ttys if not installed after revision 1.11 of dev/ic/pluart.c which > landed

CVS: cvs.openbsd.org: src

2022-06-19 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/06/19 19:39:44 Modified files: sys/dev/pci/drm: drm_linux.c sys/kern : kern_event.c sys_pipe.c sys_socket.c vfs_vnops.c sys/sys: eventvar.h

mips64 bulk build report

2022-06-19 Thread visa
bulk build on octeon.ports.openbsd.org started on Mon Jun 6 15:50:47 UTC 2022 finished at Wed Jun 15 14:39:45 UTC 2022 lasted 09D22h48m done with kern.version=OpenBSD 7.1-current (GENERIC.MP) #956: Sun Jun 5 17:59:43 MDT 2022 built packages:8631 Jun 6:2119 Jun 7:925 Jun 8:580 Jun 9:649 Jun

Re: kern_event.c:839 assertion failed

2022-06-19 Thread Visa Hankala
On Fri, Jun 17, 2022 at 04:25:48PM +0300, Mikhail wrote: > I was debugging tog in lldb and in second tmux window opened another > bare tog instance, after a second I got this panic: > > panic: kernel diagnostic assetion "p->p_kq->kq_refcnt.r_refs == 1" > failed file

Re: Fix lock order reversal in nfs_inactive()

2022-06-19 Thread Visa Hankala
On Sun, Jun 19, 2022 at 11:05:38AM +0200, Jeremie Courreges-Anglas wrote: > On Fri, Jun 17 2022, Jeremie Courreges-Anglas wrote: > > On Thu, Jun 16 2022, Visa Hankala wrote: > >> nfs_inactive() has a lock order reversal. When it removes the silly > >> file, it lock

Re: pluart(4): hardware console baudrate

2022-06-19 Thread Visa Hankala
a problem > as of now since pluart does not support changing the baudrate just yet, > I have another subsequent diff for that. > > Instead, honor and propagate the baudrate given to pluartcnattach() > while attaching the hardware console. Similar to what com(4) already > does. > > Comments? OK? OK visa@

Fix lock order reversal in nfs_inactive()

2022-06-16 Thread Visa Hankala
nfs_inactive() has a lock order reversal. When it removes the silly file, it locks the directory vnode while it already holds the lock of the argument file vnode. This clashes for example with name lookups where directory vnodes are locked before file vnodes. The reversal can cause a deadlock

CVS: cvs.openbsd.org: src

2022-06-12 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/06/12 04:36:04 Modified files: sys/kern : kern_synch.c Log message: Allow sleeping while clearing a sleep timeout Since sys/kern/kern_timeout.c r1.84, timeout_barrier() has used sleeping with

CVS: cvs.openbsd.org: src

2022-06-12 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2022/06/12 04:34:36 Modified files: sys/kern : kern_event.c Log message: kqueue: Fix missing wakeup While one thread is running kqueue_scan(), another thread can begin scanning the same kqueue,

<    1   2   3   4   5   6   7   8   9   10   >