Change knote list head type

2020-04-04 Thread Visa Hankala
Below is a mostly mechanical patch that wraps the SLIST head of knotes inside another struct. The patch also introduces functions for adding and removing knotes from these lists. My intent is to extend the list struct so that the system can assert when the knote list should be locked. The idea is

Constify pledgenames[]

2020-04-03 Thread Visa Hankala
This diff makes pledgenames[] const. OK? Index: sys/kern/kern_pledge.c === RCS file: src/sys/kern/kern_pledge.c,v retrieving revision 1.261 diff -u -p -r1.261 kern_pledge.c --- sys/kern/kern_pledge.c 15 Feb 2020 09:35:48 -

Avoid selwakeup() in kqueue_wakeup()

2020-04-02 Thread Visa Hankala
selwakeup(sip) calls KNOTE(>si_note, 0), which implies that kqueue_wakeup() should not call selwakeup() directly. Otherwise, a contrived program can trigger deep recursion. The diff below moves selwakeup() from kqueue_wakeup() to kqueue_task(). In addition to preventing the recursion, this change

CVS: cvs.openbsd.org: src

2020-04-02 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/04/02 21:36:57 Modified files: sys/kern : kern_smr.c sys/sys: smr.h Log message: Adjust SMR_ASSERT_CRITICAL() and SMR_ASSERT_NONCRITICAL() so that the panic message shows the

CVS: cvs.openbsd.org: src

2020-04-02 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/04/02 21:20:12 Modified files: sys/kern : kern_ktrace.c Log message: Take an explicit write reference when associating a thread with a ktrace vnode. This lets other parts of the kernel see the

mips64 bulk build report

2020-04-02 Thread visa
bulk build on octeon.ports.openbsd.org started on Tue Mar 17 17:14:48 UTC 2020 finished at Thu Mar 26 17:46:26 UTC 2020 lasted 10D00h31m done with kern.version=OpenBSD 6.6-current (GENERIC.MP) #21: Mon Mar 23 15:09:05 UTC 2020 built packages:9430 Mar 17:1434 Mar 18:1270 Mar 19:706 Mar 20:604

Re: panic on vm hosted with VMM - missing dquot

2020-04-01 Thread Visa Hankala
On Tue, Mar 31, 2020 at 10:19:36PM +, Bryan Stenson wrote: > I started "doas ktrace -p " after boot. > > However, your clue about "...quotaon(8) could miss the trace file > vnode..." seems relevant here. I did use "doas quotaoff /home" and > "doas quotaon -u /home" while proving to myself

Re: panic on vm hosted with VMM - missing dquot

2020-03-31 Thread Visa Hankala
On Tue, Mar 31, 2020 at 07:01:52AM +, Bryan Stenson wrote: > yes, but for an unrelated issue (lots of learning in these isolated times). > > On Tue, Mar 31, 2020 at 7:00 AM Theo de Raadt wrote: > > > > Were you really performing a ktrac of pflogd? > > > > Bryan Stenson wrote: > > > > >

CVS: cvs.openbsd.org: src

2020-03-29 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/29 09:14:28 Modified files: sys/arch/amd64/amd64: db_trace.c sys/arch/arm64/arm64: db_trace.c sys/arch/i386/i386: db_trace.c Log message: Prevent stack trace saving from inspecting

CVS: cvs.openbsd.org: src

2020-03-23 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/23 09:45:39 Modified files: sys/kern : kern_ktrace.c Log message: Check the outcome of ktrstart() and skip tracing if the trace file header could not be written. OK anton@ mpi@

CVS: cvs.openbsd.org: src

2020-03-23 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/23 09:42:10 Modified files: sys/kern : kern_synch.c Log message: Prevent tsleep(9) with PCATCH from returning immediately without error when called during execve(2). This was a caused by

Check ktrstart() error in doktrace()

2020-03-21 Thread Visa Hankala
This diff makes doktrace() check the outcome of ktrstart() and skip tracing if the trace file header cannot be written. OK? Index: kern/kern_ktrace.c === RCS file: src/sys/kern/kern_ktrace.c,v retrieving revision 1.101 diff -u -p

Fix tsleep(9) during execve(2)

2020-03-21 Thread Visa Hankala
The recent change of initializing sls_sig = 0 in sleep_setup() (r1.164 of kern_synch.c) has introduced a regression with execve(2). execve(2) sets the current process in single thread mode for replacing the program image. In this mode, sleep_setup_signal() cancels a sleep, making tsleep(9) with

CVS: cvs.openbsd.org: src

2020-03-19 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/19 10:35:39 Modified files: sys/arch/arm/arm: vm_machdep.c sys/arch/arm64/arm64: vm_machdep.c Log message: Remove an unnecessary type cast. OK kettenis@

CVS: cvs.openbsd.org: src

2020-03-18 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/18 09:48:22 Modified files: sys/kern : kern_exit.c kern_sig.c sys/sys: proc.h Log message: Restart child process scan in dowait4() if single_thread_wait() sleeps. This ensures

mips64 bulk build report

2020-03-17 Thread visa
bulk build on octeon.ports.openbsd.org started on Sun Mar 8 16:24:11 UTC 2020 finished at Mon Mar 16 10:42:52 UTC 2020 lasted 08D18h18m done with kern.version=OpenBSD 6.6-current (GENERIC.MP) #19: Sun Mar 8 16:03:37 UTC 2020 built packages:9331 Mar 8:1508 Mar 9:1451 Mar 10:648 Mar 11:748 Mar

CVS: cvs.openbsd.org: src

2020-03-14 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/14 23:58:48 Modified files: sys/kern : subr_witness.c Log message: Fix memory corruption with kern.witness.locktrace. The allocating of lock stacks does not handle correctly the case where

CVS: cvs.openbsd.org: src

2020-03-14 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/14 23:34:14 Modified files: sys/netinet: in.c ip_mroute.c sys/netinet6 : in6.c ip6_mroute.c Log message: Guard SIOCDELMULTI if_ioctl calls with KERNEL_LOCK() where the call is made

CVS: cvs.openbsd.org: src

2020-03-12 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/12 11:38:03 Modified files: sys/kern : vfs_bio.c Log message: Revert previous. Something in it causes unexpected slowdown.

CVS: cvs.openbsd.org: src

2020-03-12 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/12 09:40:39 Modified files: regress/sys/dev: Makefile Added files: regress/sys/dev/vnd: Makefile Log message: Add a regression test for vnd(4).

CVS: cvs.openbsd.org: src

2020-03-12 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/12 09:38:59 src/regress/sys/dev/vnd Update of /cvs/src/regress/sys/dev/vnd In directory cvs.openbsd.org:/tmp/cvs-serv30230/vnd Log Message: Directory /cvs/src/regress/sys/dev/vnd added to the repository

CVS: cvs.openbsd.org: src

2020-03-12 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/12 09:29:47 Modified files: sys/kern : vfs_bio.c Log message: Enable caching when turning a synchronous write into a delayed write. Otherwise the write will be discarded, which would prevent

Fix a panic with unlocked soclose()

2020-03-11 Thread Visa Hankala
jcs@ has reported the following panic which started appearing as a consequence of the recent file close unlocking: panic: kernel diagnostic assertion "timo || _kernel_lock_held()" failed: file "/usr/src/sys/kern/kern_synch.c", line 123 panic __assert tsleep usbd_transfer usbd_do_request_flags

mips64 bulk build report

2020-03-08 Thread visa
bulk build on octeon.ports.openbsd.org started on Sun Feb 23 17:21:52 UTC 2020 finished at Wed Mar 4 18:01:37 UTC 2020 lasted 11D00h39m done with kern.version=OpenBSD 6.6-current (GENERIC.MP) #18: Sun Feb 23 16:58:48 UTC 2020 built packages:9379 Feb 23:1448 Feb 24:1311 Feb 25:566 Feb 26:697 Feb

CVS: cvs.openbsd.org: src

2020-03-08 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/08 03:40:53 Modified files: regress/sys/kern/kqueue: Makefile kqueue-regress.c Log message: Add a regression test for kqueue recursion. Also check that select(2) and poll(2) work with kqueue.

CVS: cvs.openbsd.org: src

2020-03-02 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/02 10:07:50 Modified files: sys/kern : kern_rwlock.c Log message: Fix use of WITNESS_UNLOCK() in rw_exit_read() and rw_exit_write(). WITNESS_UNLOCK() has to be called before the actual lock

CVS: cvs.openbsd.org: src

2020-03-02 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/03/02 09:30:39 Modified files: sys/dev/usb: xhci.c Log message: Fix endian swapping of trb_flags and trb_status in xhci(4). This corrects computation of xfer->actlen, allowing xhci(4) to work

Re: octeon - panic: _dmamap_sync: ran off map

2020-03-01 Thread Visa Hankala
On Sat, Feb 29, 2020 at 12:06:17PM -0700, Allen Smith wrote: > umass0: using SCSI over Bulk-Only > scsibus0 at umass0: 2 targets, initiator 0 > sd0 at scsibus0 targ 1 lun 0: removable > serial.090c1000418120001168 > panic: _dmamap_sync: ran off map! This is caused by wrong endianess. The diff

Fix use of WITNESS_UNLOCK() in rw_exit_{read,write}()

2020-02-29 Thread Visa Hankala
There is a bug in how rw_exit_read() and rw_exit_write() use WITNESS_UNLOCK(). The fast paths call WITNESS_UNLOCK() after releasing the actual lock. This leads to a use-after-free in the checker if the lock is dynamically allocated and another thread happens to free it too early. The following

CVS: cvs.openbsd.org: src

2020-02-26 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/02/26 07:23:15 Modified files: sys/lib/libkern: libkern.h Log message: Remove non-__STDC__ assert macros from . The macros are defined in a part of the header where a C compiler is required. In

CVS: cvs.openbsd.org: src

2020-02-26 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/02/26 06:54:52 Modified files: sys/kern : kern_descrip.c Log message: Release the file descriptor table lock before calling closef() in finishdup(). This makes the order of operations similar to

CVS: cvs.openbsd.org: src

2020-02-25 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/02/25 09:55:33 Modified files: sys/kern : init_main.c kern_smr.c sys/sys: smr.h Log message: Start the SMR thread when all CPUs are ready for scheduling. This prevents the

CVS: cvs.openbsd.org: src

2020-02-25 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/02/25 09:53:25 Modified files: share/man/man9 : smr_call.9 Log message: Fix a mistake in context documentation of smr_barrier() and smr_flush(). The barriers cannot be used during autoconf. The current

mips64 bulk build report

2020-02-23 Thread visa
bulk build on octeon.ports.openbsd.org started on Sat Feb 15 13:28:04 UTC 2020 finished at Sun Feb 23 13:52:26 UTC 2020 lasted 09D00h24m done with kern.version=OpenBSD 6.6-current (GENERIC.MP) #17: Sat Feb 15 11:58:07 UTC 2020 built packages:9455 Feb 15:2204 Feb 16:760 Feb 17:698 Feb 18:711 Feb

CVS: cvs.openbsd.org: src

2020-02-20 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/02/20 09:56:53 Modified files: sys/arch/arm64/dev: apm.c sys/arch/i386/i386: apm.c sys/arch/loongson/dev: apm.c sys/arch/macppc/dev: apm.c sys/dev: hotplug.c

Generic flags field in struct filterops

2020-02-19 Thread Visa Hankala
Eventually, it will become necessary to add new properties to struct filterops. One such property is whether the filter is safe to use without the kernel lock. The diff below replaces the f_isfd field with a generic flags field in struct filterops, to allow adding new properties without

Release fdplock before closef() in finishdup()

2020-02-18 Thread Visa Hankala
The following diff makes finishdup() release the file descriptor table lock before calling closef(). This makes the order of operations similar to that of fdrelease(). The dup* code still has an issue with file closing that this diff does not address. If fdalloc() fails in dodup3(), sys_dup() or

CVS: cvs.openbsd.org: src

2020-02-17 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/02/17 20:47:19 Modified files: sys/kern : kern_descrip.c Log message: Move setting of UF_EXCLOSE file descriptor flag inside finishdup(). This makes it easier to release fdplock before calling

CVS: cvs.openbsd.org: src

2020-02-16 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/02/16 21:07:01 Modified files: sys/kern : kern_event.c Log message: Raise SPL when updating kn_status. Otherwise the field can become inconsistent if knote_acquire() or knote_release() is

Set UF_EXCLOSE inside finishdup()

2020-02-16 Thread Visa Hankala
The closing of a file can be a complex operation, and hence it would be good to hold as few locks as possible when calling closef(). In particular, the code behind close(2) already releases the file descriptor table lock before closef(). This might not be strictly necessary when the type of the

Re: Raise spl for updating kn_status

2020-02-16 Thread Visa Hankala
On Sat, Feb 15, 2020 at 09:42:53PM +0100, Martin Pieuchot wrote: > On 15/02/20(Sat) 16:56, Visa Hankala wrote: > > When I added the knote_acquire() call in kqueue_register(), I overlooked > > the fact that the knote could be modified by a (soft) interrupt. > > Interrupts ha

Raise spl for updating kn_status

2020-02-15 Thread Visa Hankala
When I added the knote_acquire() call in kqueue_register(), I overlooked the fact that the knote could be modified by a (soft) interrupt. Interrupts have to be blocked when changing kn_status. Otherwise the state could become confused. The diff below adds splhigh() where kn_status is modified.

Re: const*ify cfattach

2020-02-15 Thread Visa Hankala
On Fri, Feb 14, 2020 at 06:08:31PM +0100, Martin Pieuchot wrote: > On 13/02/20(Thu) 17:23, Visa Hankala wrote: > > On Thu, Feb 13, 2020 at 06:07:01PM +0100, Martin Pieuchot wrote: > > > On 13/02/20(Thu) 16:53, Visa Hankala wrote: > > > [...] > > > > I wo

mips64 bulk build report

2020-02-15 Thread visa
bulk build on octeon.ports.openbsd.org started on Tue Feb 4 18:34:50 UTC 2020 finished at Thu Feb 13 07:00:22 UTC 2020 lasted 09D12h25m done with kern.version=OpenBSD 6.6-current (GENERIC.MP) #16: Tue Feb 4 18:22:27 UTC 2020 built packages:9338 Feb 4:1489 Feb 5:1302 Feb 6:329 Feb 7:567 Feb

CVS: cvs.openbsd.org: src

2020-02-14 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/02/14 09:50:25 Modified files: sys/kern : kern_event.c sys/sys: eventvar.h Log message: Defer chained activation of kqueues. This makes easier to introduce new locks. The

Re: const*ify cfattach

2020-02-13 Thread Visa Hankala
On Thu, Feb 13, 2020 at 06:07:01PM +0100, Martin Pieuchot wrote: > On 13/02/20(Thu) 16:53, Visa Hankala wrote: > > On Thu, Feb 13, 2020 at 12:00:35PM +0100, Martin Pieuchot wrote: > > > These structures are only used by autoconf(9) and don't need to be > > > modifie

Re: const*ify cfattach

2020-02-13 Thread Visa Hankala
On Thu, Feb 13, 2020 at 12:00:35PM +0100, Martin Pieuchot wrote: > These structures are only used by autoconf(9) and don't need to be > modified. Some subsystems already define most of them as 'const'. > Diff below turn all the remaining one as such. > > Only a single driver, de(4), needed a

Re: Push KERNEL_LOCK() down in pgsigio() and selwakeup()

2020-02-09 Thread Visa Hankala
On Tue, Feb 04, 2020 at 02:21:02PM +0100, Martin Pieuchot wrote: > void > selwakeup(struct selinfo *sip) > { > + KERNEL_LOCK(); > + KNOTE(>si_note, NOTE_SUBMIT); > + doselwakeup(sip); > + KERNEL_UNLOCK(); > +} There is a problem with audio code. Audio interrupt handlers

CVS: cvs.openbsd.org: src

2020-02-09 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/02/09 07:09:08 Modified files: sys/kern : kern_event.c Log message: Zero struct knote on allocation. This makes the code less prone to errors. OK deraadt@, cheloha@, anton@

Remove non-__STDC__ asserts from

2020-02-08 Thread Visa Hankala
The header defines two sets of assert macros, one for standard C and another for the traditional cpp. As the header requires the use of a C compiler (that is, no inclusion from an assembly file), it looks that the non-__STDC__ parts could be removed. OK? Index: lib/libkern/libkern.h

Zero knotes on allocation

2020-02-08 Thread Visa Hankala
Zero knotes on allocation. Parts of struct knote, such as kn_tqe, can retain their old value quite long, which is not good in this complex piece of code. OK? Index: kern/kern_event.c === RCS file: src/sys/kern/kern_event.c,v

CVS: cvs.openbsd.org: src

2020-02-08 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/02/08 07:52:07 Modified files: sys/kern : tty.c Log message: Replace ttkqflush() with klist_invalidate() to handle knote list invalidation in one place. Store struct tty pointer in kn_hook

Re: Push KERNEL_LOCK() down in pgsigio() and selwakeup()

2020-02-08 Thread Visa Hankala
s all the more so. > It is unclear to me if this change of behavior degrades latency in a > noticeable way. If it does and people report it, we should consider > keeping a single KERNEL_LOCK/UNLOCK() dance in the affected subsystem. > > Comments? Oks? OK visa@

CVS: cvs.openbsd.org: src

2020-02-05 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/02/05 10:03:13 Modified files: sys/kern : kern_descrip.c kern_event.c Log message: Move kernel locking inside knote_fdclose() from finishdup() and fdrelease(). This makes the upper layer of file

Re: Replace ttkqflush() with klist_invalidate()

2020-02-04 Thread Visa Hankala
On Tue, Feb 04, 2020 at 01:04:24PM +0100, Martin Pieuchot wrote: > On 02/02/20(Sun) 09:58, Visa Hankala wrote: > > tty(4) uses custom code for revoking knotes. It should be changed to use > > klist_invalidate() to handle the revocation in one place. The following > > diff

mips64 bulk build report

2020-02-02 Thread visa
bulk build on octeon.ports.openbsd.org started on Sat Jan 18 14:33:05 UTC 2020 finished at Wed Jan 29 07:52:02 UTC 2020 lasted 11D17h18m done with kern.version=OpenBSD 6.6-current (GENERIC.MP) #13: Sat Jan 18 13:45:36 UTC 2020 built packages:9424 Jan 18:2257 Jan 19:1337 Jan 20:719 Jan 21:708

Replace ttkqflush() with klist_invalidate()

2020-02-02 Thread Visa Hankala
tty(4) uses custom code for revoking knotes. It should be changed to use klist_invalidate() to handle the revocation in one place. The following diff does that. In addition, the patch makes the code store the tty context pointer in kn_hook directly. This simplifies the code. Unlike ttkqflush(),

CVS: cvs.openbsd.org: src

2020-01-30 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/30 08:36:11 Modified files: sys/kern : vfs_syscalls.c Log message: Acquire fdplock when updating fd_cmask. This moves the code toward MP-safety. OK mpi@, anton@

CVS: cvs.openbsd.org: src

2020-01-30 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/30 08:33:04 Modified files: sys/sys: filedesc.h Log message: Update lock annotations of struct filedesc. Requested by and OK mpi@ OK anton@

CVS: cvs.openbsd.org: src

2020-01-30 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/30 08:24:55 Modified files: sys/kern : init_sysent.c syscalls.c sys/sys: syscall.h syscallargs.h Log message: regen

CVS: cvs.openbsd.org: src

2020-01-30 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/30 08:24:06 Modified files: sys/kern : syscalls.master Log message: Unlock close*(2) and dup*(2). Tested by krw@, anton@ OK mpi@, anton@

CVS: cvs.openbsd.org: src

2020-01-28 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/28 09:26:10 Modified files: sys/net: if_pppx.c if_tun.c switchctl.c Log message: Simplify filterops routines where klist_invalidate() is used. klist_invalidate() detaches knotes from the

CVS: cvs.openbsd.org: src

2020-01-27 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/27 10:13:33 Modified files: sys/dev/dt : dt_dev.c Log message: Improve use of SMR in dt(4) by changing the time when smr_barrier() is invoked. This enables threads to continue gathering events

CVS: cvs.openbsd.org: src

2020-01-21 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/21 08:21:42 Modified files: sys/kern : init_sysent.c syscalls.c sys/sys: syscall.h syscallargs.h Log message: regen

CVS: cvs.openbsd.org: src

2020-01-21 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/21 08:20:47 Modified files: sys/kern : kern_fork.c kern_synch.c syscalls.master sys/sys: proc.h Log message: Make __thrsleep(2) and __thrwakeup(2) MP-safe Threads in

CVS: cvs.openbsd.org: src

2020-01-20 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/20 08:58:23 Modified files: sys/arch/amd64/amd64: db_trace.c sys/arch/arm64/arm64: db_trace.c sys/arch/hppa/hppa: db_interface.c sys/arch/i386/i386: db_trace.c

mips64 bulk build report

2020-01-18 Thread visa
bulk build on octeon.ports.openbsd.org started on Wed Jan 8 18:23:28 UTC 2020 finished at Thu Jan 16 01:33:43 UTC 2020 lasted 08D07h10m done with kern.version=OpenBSD 6.6-current (GENERIC.MP) #12: Wed Jan 8 17:51:08 UTC 2020 built packages:9313 Jan 8:1543 Jan 9:1321 Jan 10:851 Jan 11:574 Jan

CVS: cvs.openbsd.org: src

2020-01-18 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/18 02:00:52 Modified files: sys/dev/usb: uhid.c Log message: Invalidate knote list of uhid(4) after device detach. This prevents a crash that can happen if a uhid(4) device is detached while

CVS: cvs.openbsd.org: src

2020-01-18 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/18 01:59:48 Modified files: sys/kern : kern_event.c Log message: Make klist_invalidate() more careful and general. Acquire knotes before changing them, to synchronize with kqueue_register()

CVS: cvs.openbsd.org: src

2020-01-18 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/18 01:40:20 Modified files: sys/kern : vfs_syscalls.c sys/sys: mount.h Log message: Clear mount operation argument flags from mnt_flag after mount. OK bluhm@

CVS: cvs.openbsd.org: src

2020-01-13 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/13 07:02:24 Modified files: sys/kern : init_sysent.c syscalls.c sys/sys: syscall.h syscallargs.h Log message: regen

CVS: cvs.openbsd.org: src

2020-01-13 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/13 07:01:18 Modified files: sys/kern : syscalls.master Log message: Unlock a tiny part of the kqueue subsystem: kqueue(2). Tested by and OK anton@ OK mpi@, kettenis@

CVS: cvs.openbsd.org: src

2020-01-13 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/13 06:57:19 Modified files: sys/kern : kern_event.c Log message: Allocate kqueue instance outside fdplock to avoid sleeping with the lock held. This also shortens the critical section.

CVS: cvs.openbsd.org: src

2020-01-10 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/10 08:49:37 Modified files: sys/kern : kern_event.c sys/sys: eventvar.h Log message: Use atomic operations with kq_refs, to nudge the code toward MP-safety. While here,

CVS: cvs.openbsd.org: src

2020-01-08 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/08 09:45:28 Modified files: sys/kern : kern_descrip.c kern_event.c Log message: Skip fdplock when freeing a file descriptor table. The lock is not necessary because other threads cannot access

CVS: cvs.openbsd.org: src

2020-01-08 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/08 09:27:42 Modified files: regress/sys/dev/wscons: sigio.c share/man/man9 : sigio_init.9 sys/dev/wscons : wskbd.c wsmouse.c wsmux.c sys/kern : kern_descrip.c

mips64 bulk build report

2020-01-08 Thread visa
bulk build on octeon.ports.openbsd.org started on Mon Dec 30 06:02:44 UTC 2019 finished at Tue Jan 7 18:53:19 UTC 2020 lasted 09D12h50m done with kern.version=OpenBSD 6.6-current (GENERIC.MP) #11: Mon Dec 30 05:03:16 UTC 2019 built packages:9327 Dec 30:2816 Dec 31:602 Jan 1:462 Jan 2:716 Jan

Re: Null pointer crash in filt_uhidrdetach

2020-01-06 Thread Visa Hankala
On Fri, Jan 03, 2020 at 11:37:22PM -0800, Greg Steuck wrote: > While playing with chromium u2f support[1] I managed to induce kernel > crashes in filt_uhidrdetach. It takes a few attempts of plugging/unplugging > the fido key while trying to authenticate at demo.yubico.com/playground. > Eventually

CVS: cvs.openbsd.org: src

2020-01-06 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/06 03:28:32 Modified files: sys/kern : kern_event.c Log message: Use type M_KEVENT instead of M_TEMP when allocating kqueue-related data buffers. OK bluhm@, mpi@, anton@

CVS: cvs.openbsd.org: src

2020-01-06 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/06 03:25:10 Modified files: sys/kern : kern_descrip.c kern_event.c kern_fork.c sys/sys: eventvar.h filedesc.h proc.h Log message: Make kqlist part of filedesc and serialize

CVS: cvs.openbsd.org: src

2020-01-05 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/05 06:46:02 Modified files: sys/dev/pci/drm: drm_linux.c sys/kern : kern_event.c sys_pipe.c sys_socket.c uipc_syscalls.c vfs_vnops.c sys/sys:

CVS: cvs.openbsd.org: src

2020-01-04 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/04 21:29:11 Modified files: sys/dev/pci/drm: drm_drv.c drm_ioctl.c Log message: Remove unneeded #include . OK jsg@

CVS: cvs.openbsd.org: src

2020-01-02 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/02 22:37:00 Modified files: share/man/man9 : file.9 sys/kern : kern_descrip.c kern_event.c sys/sys: filedesc.h Log message: Fix a file descriptor close race in

CVS: cvs.openbsd.org: src

2020-01-02 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/02 09:00:54 Modified files: sys/arch/mips64/mips64: db_disasm.c Log message: Use newabi register names in disassembly. OK miod@

CVS: cvs.openbsd.org: src

2019-12-31 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2020/01/01 00:31:44 Modified files: distrib/notes/octeon: features Log message: Acknowledge SMP kernels in INSTALL.octeon >From miod@

CVS: cvs.openbsd.org: src

2019-12-31 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2019/12/31 09:59:35 Modified files: share/man/man9 : file.9 Log message: Document fd_getfile_mode(9). OK mpi@

CVS: cvs.openbsd.org: src

2019-12-31 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2019/12/31 07:09:56 Modified files: sys/kern : kern_event.c Log message: Fix some races in kqueue_register(). Mark knote with KN_PROCESSING before calling .f_event() in kqueue_register(). This

CVS: cvs.openbsd.org: src

2019-12-31 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2019/12/31 06:48:33 Modified files: sys/arch/arm64/dev: apm.c sys/arch/i386/i386: apm.c sys/arch/loongson/dev: apm.c sys/arch/macppc/dev: apm.c sys/dev: hotplug.c

Re: SMR question

2019-12-29 Thread Visa Hankala
On Sun, Dec 29, 2019 at 05:23:43PM -0600, Amit Kulkarni wrote: > I was preparing a diff and wanted to know if it is safe to disable the > SMR kthread by commenting it out for testing purposes on amd64. Just a > simple yes/no would do! no

CVS: cvs.openbsd.org: src

2019-12-28 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2019/12/29 00:14:06 Modified files: sys/kern : kern_event.c Log message: Wake up knote waiters in knote_drop(). This lets the blocked knote_acquire() calls resume immediately instead of waiting for

mips64 bulk build report

2019-12-28 Thread visa
bulk build on octeon.ports.openbsd.org started on Thu Dec 19 04:26:21 UTC 2019 finished at Fri Dec 27 16:44:12 UTC 2019 lasted 09D12h17m done with kern.version=OpenBSD 6.6-current (GENERIC.MP) #8: Thu Dec 26 05:04:41 UTC 2019 built packages:9409 Dec 19:2839 Dec 20:577 Dec 21:444 Dec 22:335 Dec

CVS: cvs.openbsd.org: src

2019-12-25 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2019/12/25 08:04:44 Modified files: sys/kern : kern_event.c Log message: Replace macros knote_alloc() and knote_free() with direct use of pool_get() and pool_put(). This makes it clearer that the

CVS: cvs.openbsd.org: src

2019-12-23 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2019/12/23 21:24:38 Modified files: sys/kern : init_sysent.c syscalls.c sys/sys: syscall.h syscallargs.h Log message: regen

CVS: cvs.openbsd.org: src

2019-12-23 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2019/12/23 21:23:43 Modified files: sys/kern : syscalls.master Log message: Unlock nanosleep(2). OK cheloha@, anton@, mpi@

CVS: cvs.openbsd.org: src

2019-12-20 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2019/12/20 06:34:41 Modified files: sys/arch/loongson/loongson: bus_dma.c loongson2_machdep.c sys/arch/mips64/mips64: mem.c sys_machdep.c vm_machdep.c sys/arch/octeon/octeon: bus_dma.c

CVS: cvs.openbsd.org: src

2019-12-20 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2019/12/20 06:29:23 Modified files: sys/arch/sgi/sgi: ip27_machdep.c Log message: Replace a lonely TRUE. OK mpi@

CVS: cvs.openbsd.org: src

2019-12-20 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2019/12/20 06:27:41 Modified files: sys/arch/mips64/mips64: pmap.c Log message: Convert boolean_t/TRUE/FALSE to int/1/0 in mips64 pmap. Rename variables for clarity while here. OK mpi@

CVS: cvs.openbsd.org: src

2019-12-20 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2019/12/20 06:25:03 Modified files: sys/arch/loongson/loongson: conf.c Log message: Fix build.

mips64 bulk build report

2019-12-18 Thread visa
bulk build on octeon.ports.openbsd.org started on Fri Dec 13 15:16:49 UTC 2019 finished at Thu Dec 19 03:06:49 UTC 2019 lasted 06D11h50m done with kern.version=OpenBSD 6.6-current (GENERIC.MP) #3: Sat Dec 14 16:12:41 UTC 2019 built packages:8051 Dec 13:2045 Dec 14:1071 Dec 15:599 Dec 16:448 Dec

CVS: cvs.openbsd.org: src

2019-12-18 Thread Visa Hankala
CVSROOT:/cvs Module name:src Changes by: v...@cvs.openbsd.org2019/12/18 06:33:29 Modified files: sys/uvm: uvm_km.c uvm_map.c uvm_map.h Log message: Set vm_map's pmap in uvm_map_setup(). OK guenther@, kettenis@, mpi@

<    5   6   7   8   9   10   11   12   13   14   >