Author: Vlad Serebrennikov
Date: 2024-05-20T20:03:42+03:00
New Revision: d71f30a7f45c5a73fe551ea4ca48b11191e7b0e8
URL:
https://github.com/llvm/llvm-project/commit/d71f30a7f45c5a73fe551ea4ca48b11191e7b0e8
DIFF:
Author: Vlad Serebrennikov
Date: 2024-05-20T20:02:38+03:00
New Revision: 4f5bc4bb55a8091ca9eb6dd016dcb2be82bf917a
URL:
https://github.com/llvm/llvm-project/commit/4f5bc4bb55a8091ca9eb6dd016dcb2be82bf917a
DIFF:
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
Endilll wrote:
>
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/92740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
I'd like to merge this after @tstellar or @lnihlen give their approval.
https://github.com/llvm/llvm-project/pull/92740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/92740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1459,11 +1460,11 @@ static AccessResult CheckEffectiveAccess(Sema ,
llvm_unreachable("invalid access result");
}
-static Sema::AccessResult CheckAccess(Sema , SourceLocation Loc,
- AccessTarget ) {
+static SemaAccess::AccessResult
@@ -0,0 +1,112 @@
+//===- SemaAccess.h - C++ Access Control
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92689
>From 9c89a7b451221d79f96fd1fc1d015c6a22b9f66e Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sun, 19 May 2024 15:00:38 +0300
Subject: [PATCH] [clang][NFC] Refactor `Sema::TagUseKind`
This patch makes
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92740
>From d306d06f7f5455788016f985b44fdf9672c90b86 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 20 May 2024 14:22:20 +0300
Subject: [PATCH 1/3] Disable compiling Flang and running its tests on Clang
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92740
>From d306d06f7f5455788016f985b44fdf9672c90b86 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 20 May 2024 14:22:20 +0300
Subject: [PATCH 1/3] Disable compiling Flang and running its tests on Clang
Endilll wrote:
Windows CI has finished with an unrelated failure.
https://buildkite.com/llvm-project/github-pull-requests/builds/65498 confirms
that this patch is working as intended, i.e. Flang is not tested on Clang
changes on both Linux and Windows.
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
Endilll wrote:
The
@@ -72,7 +72,7 @@ class PrintFunctionsConsumer : public ASTConsumer {
*sema.LateParsedTemplateMap.find(FD)->second;
sema.LateTemplateParser(sema.OpaqueParser, LPT);
llvm::errs() << "late-parsed-decl: \"" << FD->getNameAsString() <<
"\"\n";
-}
+
Endilll wrote:
> Given the concerns raised here, it might make sense to put this change on
> hold, do a few more similar experiments for other parts of C++, and see what
> sort of principled design approach makes sense to take here.
It's not clear to me what do we want to clarify or try out
https://github.com/Endilll ready_for_review
https://github.com/llvm/llvm-project/pull/92740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
https://buildkite.com/llvm-project/github-pull-requests/builds/65498#018f95c2-a52b-4d95-97ac-ea7e0c7be9ae
confirms that Flang is no longer compiler, and Flang tests are no longer
executed.
https://github.com/llvm/llvm-project/pull/92740
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92740
>From d306d06f7f5455788016f985b44fdf9672c90b86 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Mon, 20 May 2024 14:22:20 +0300
Subject: [PATCH 1/2] Disable compiling Flang and running its tests on Clang
Endilll wrote:
> While I am not against the idea about splitting Sema, the implementation
> detail makes me slightly concerning. What I had in mind is to split SemaC,
> SemaCXX (this can be derived class of SemaCXX), SemaObjC and other dialects
> (e.g., ACC or CUDA) out of Sema.
Inheritance
Endilll wrote:
It is, but I guess significant enough to not be disguised by labeling as NFC.
https://github.com/llvm/llvm-project/pull/92682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Endilll wrote:
> Was there ever an RFC on this whole 'splitting up Sema' project?
It was quite extensively discussed in #84184, but it wasn't deemed necessary to
go through RFC process for a non-functional change that doesn't affect stable
interfaces.
> I think starting up from the easier
Endilll wrote:
I'll merge this when CI passes.
https://github.com/llvm/llvm-project/pull/92689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/92689
This patch makes `TagUseKind` a scoped enumeration, and moves it outside of
`Sema` class, making it eligible for forward declaring.
>From 9c89a7b451221d79f96fd1fc1d015c6a22b9f66e Mon Sep 17 00:00:00 2001
From:
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92645
>From 4fe09a3411e54561857d2f9d8c1808cb2728e299 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sat, 18 May 2024 13:33:04 +0300
Subject: [PATCH 1/3] [clang] Introduce `SemaCoroutine`
---
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92646
>From 81b2c7dbb6fb9cb24d560b6069f60ba3452bbf2a Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sat, 18 May 2024 14:20:43 +0300
Subject: [PATCH 1/2] [clang] Introduce `SemaPseudoObject`
---
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92645
>From 4fe09a3411e54561857d2f9d8c1808cb2728e299 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sat, 18 May 2024 13:33:04 +0300
Subject: [PATCH 1/3] [clang] Introduce `SemaCoroutine`
---
Endilll wrote:
> What is the goal here? there is a lot of code reuse in C++ and C. and having
> a file per feature is going to make thing worse (maintenance, unboarding,
> compile times).
Maintenance: one big blob of code which is `Sema` makes it virtually impossible
to approach
https://github.com/Endilll commented:
LGTM, but wait for more reviews.
https://github.com/llvm/llvm-project/pull/92654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
As @erichkeane described it, we're clearing the woods of "core" C++
functionality before dealing with the hard parts, like `SemaDeclCXX.cpp` or
`SemaChecking.cpp`.
Actual LoC wins are secondary, as they have been all along.
https://github.com/llvm/llvm-project/pull/92645
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/92646
This patch moves `Sema` functions that handle pseudo-objects into the new
`SemaPseudoObject` class. This continues previous efforts to split `Sema` up.
Additional context can be found in #84184.
As usual, in
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92645
>From 4fe09a3411e54561857d2f9d8c1808cb2728e299 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sat, 18 May 2024 13:33:04 +0300
Subject: [PATCH 1/3] [clang] Introduce `SemaCoroutine`
---
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/92645
This patch moves coroutines-specific `Sema` functions into the new
`SemaCoroutine` class. This continues previous efforts to split `Sema` up.
Additional context can be found in #84184.
As usual, in order to
Author: Vlad Serebrennikov
Date: 2024-05-18T12:10:39+03:00
New Revision: f7b0b99c52ee36ed6ca8abcce74a752e483768d6
URL:
https://github.com/llvm/llvm-project/commit/f7b0b99c52ee36ed6ca8abcce74a752e483768d6
DIFF:
Author: Vlad Serebrennikov
Date: 2024-05-17T23:10:12+03:00
New Revision: df575be9d864886684e536cd76c5a96bb0d443a6
URL:
https://github.com/llvm/llvm-project/commit/df575be9d864886684e536cd76c5a96bb0d443a6
DIFF:
Endilll wrote:
> It might violate https://eel.is/c++draft/temp.inst#11 to attempt to
> instantiate the unused S::operator int?
I don't think this clause of the standard is violated: you need to instantiate
a declaration of the conversion function to at the end of definition of `M`,
otherwise
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/92311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2024-05-17T19:10:34+03:00
New Revision: 8aa6511f4209bba33a74c4ef6e208fda5c0f3d27
URL:
https://github.com/llvm/llvm-project/commit/8aa6511f4209bba33a74c4ef6e208fda5c0f3d27
DIFF:
Author: Vlad Serebrennikov
Date: 2024-05-17T18:11:49+03:00
New Revision: 84aee95124549c5d13e22053af254e3fcc02bc84
URL:
https://github.com/llvm/llvm-project/commit/84aee95124549c5d13e22053af254e3fcc02bc84
DIFF:
Author: Vlad Serebrennikov
Date: 2024-05-17T17:15:44+03:00
New Revision: 30d0850e0f780b17a37522e6503c98ebe197c5fa
URL:
https://github.com/llvm/llvm-project/commit/30d0850e0f780b17a37522e6503c98ebe197c5fa
DIFF:
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/92500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2024-05-17T16:41:20+03:00
New Revision: d3d5a30021b8df26ac4b2b01e659ab8487fb4080
URL:
https://github.com/llvm/llvm-project/commit/d3d5a30021b8df26ac4b2b01e659ab8487fb4080
DIFF:
@@ -85,7 +85,7 @@ void f(int x, int y, int z) {
if ((ayyhttps://github.com/llvm/llvm-project/pull/92200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/92295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/92436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/92500
This patch remove const-qualification from pointee type of
`FunctionTemplateSpecializationInfo::TemplateArguments`, because it's
(eventually) used to initialize `MultiLevelTemplateArgumentList`, which can
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92295
>From a0d5a234431f3db2f0283ffa0909bf8c254aa611 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 15 May 2024 20:20:43 +0300
Subject: [PATCH 1/9] [clang] Implement CWG2428 "Deprecating a concept"
---
@@ -167,9 +167,11 @@ Parser::DeclGroupPtrTy
Parser::ParseTemplateDeclarationOrSpecialization(
LastParamListWasEmpty);
// Parse the actual template declaration.
- if (Tok.is(tok::kw_concept))
-return Actions.ConvertDeclToDeclGroup(
-
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92295
>From a0d5a234431f3db2f0283ffa0909bf8c254aa611 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 15 May 2024 20:20:43 +0300
Subject: [PATCH 1/8] [clang] Implement CWG2428 "Deprecating a concept"
---
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/92436
This patch adds several const-qualified variants of existing member functions
to `SourceManager`.
I started with removing const qualification from `setNumCreatedFIDsForFileID`,
and removing `const_cast` in the
Author: Vlad Serebrennikov
Date: 2024-05-16T17:53:14+03:00
New Revision: d1f96d4cfe25770827b5f819b6a9de6fef142c9c
URL:
https://github.com/llvm/llvm-project/commit/d1f96d4cfe25770827b5f819b6a9de6fef142c9c
DIFF:
@@ -45,6 +45,34 @@ void fallthrough(int n) {
#endif
}
+namespace cwg2428 { // cwg2428: 19
+#if __cplusplus >= 202002L
+template
+concept C [[deprecated]] = true; // #C
Endilll wrote:
(MSVC spelling was removed.)
@@ -8092,6 +8092,18 @@ void Sema::checkCall(NamedDecl *FDecl, const
FunctionProtoType *Proto,
diagnoseArgDependentDiagnoseIfAttrs(FD, ThisArg, Args, Loc);
}
+void Sema::CheckConstrainedAuto(TypeSourceInfo *TS) {
+ if (getLangOpts().CPlusPlus20) {
@@ -8092,6 +8092,18 @@ void Sema::checkCall(NamedDecl *FDecl, const
FunctionProtoType *Proto,
diagnoseArgDependentDiagnoseIfAttrs(FD, ThisArg, Args, Loc);
}
+void Sema::CheckConstrainedAuto(TypeSourceInfo *TS) {
+ if (getLangOpts().CPlusPlus20) {
+if (const AutoType
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92295
>From a0d5a234431f3db2f0283ffa0909bf8c254aa611 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 15 May 2024 20:20:43 +0300
Subject: [PATCH 1/7] [clang] Implement CWG2428 "Deprecating a concept"
---
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92295
>From a0d5a234431f3db2f0283ffa0909bf8c254aa611 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 15 May 2024 20:20:43 +0300
Subject: [PATCH 1/6] [clang] Implement CWG2428 "Deprecating a concept"
---
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/92295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -316,7 +318,8 @@ Parser::ParseConceptDefinition(const ParsedTemplateInfo
,
const IdentifierInfo *Id = Result.Identifier;
SourceLocation IdLoc = Result.getBeginLoc();
- DiagnoseAndSkipCXX11Attributes();
+ ParsedAttributes Attrs(AttrFactory);
+
Endilll wrote:
> Despite CWG2398 not being voted in yet, the status in
>
> https://github.com/llvm/llvm-project/blob/e3f42b02a4129947ca2dd820bfb63ffed83027b7/clang/www/cxx_dr_status.html#L14195-L14200
>
> should be updated.
The only way to update it is to add a test to `clang/test/CXX/drs`.
@@ -45,6 +45,34 @@ void fallthrough(int n) {
#endif
}
+namespace cwg2428 { // cwg2428: 19
+#if __cplusplus >= 202002L
+template
+concept C [[deprecated]] = true; // #C
Endilll wrote:
I added support for GNU and MSVC spellings.
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92295
>From a0d5a234431f3db2f0283ffa0909bf8c254aa611 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 15 May 2024 20:20:43 +0300
Subject: [PATCH 1/5] [clang] Implement CWG2428 "Deprecating a concept"
---
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92295
>From a0d5a234431f3db2f0283ffa0909bf8c254aa611 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 15 May 2024 20:20:43 +0300
Subject: [PATCH 1/4] [clang] Implement CWG2428 "Deprecating a concept"
---
@@ -45,6 +45,34 @@ void fallthrough(int n) {
#endif
}
+namespace cwg2428 { // cwg2428: 19
+#if __cplusplus >= 202002L
+template
+concept C [[deprecated]] = true; // #C
Endilll wrote:
Non-standard spellings of this attribute are out of scope of the Core
@@ -45,6 +45,38 @@ void fallthrough(int n) {
#endif
}
+namespace cwg2428 { // cwg2428: 19
+#if __cplusplus >= 202002L
+template
+concept C [[deprecated]] = true; // #cwg2428-C
+
+template
+[[deprecated]] concept C2 = true;
+// expected-error@-1 {{expected unqualified-id}}
+
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92295
>From a0d5a234431f3db2f0283ffa0909bf8c254aa611 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 15 May 2024 20:20:43 +0300
Subject: [PATCH 1/3] [clang] Implement CWG2428 "Deprecating a concept"
---
https://github.com/Endilll commented:
`Sema.h` changes look good to me.
https://github.com/llvm/llvm-project/pull/92318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -45,6 +45,34 @@ void fallthrough(int n) {
#endif
}
+namespace cwg2428 { // cwg2428: 19
+#if __cplusplus >= 202002L
+template
+concept C [[deprecated]] = true; // #C
Endilll wrote:
I added test with alternative attribute placing.
> It would also be good
@@ -10698,7 +10698,7 @@ C++ defect report implementation
status
https://cplusplus.github.io/CWG/issues/1815.html;>1815
CD4
Lifetime extension in aggregate initialization
-Clang 19
+Yes
Endilll wrote:
I updated the branch from `main`, now
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92295
>From a0d5a234431f3db2f0283ffa0909bf8c254aa611 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 15 May 2024 20:20:43 +0300
Subject: [PATCH 1/2] [clang] Implement CWG2428 "Deprecating a concept"
---
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/92113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/92295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10698,7 +10698,7 @@ C++ defect report implementation
status
https://cplusplus.github.io/CWG/issues/1815.html;>1815
CD4
Lifetime extension in aggregate initialization
-Clang 19
+Yes
Endilll wrote:
This particular one is an unfortunate
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/92295
This patch allows attributes to be attached to C++20 concepts, implementing
[CWG2428](https://cplusplus.github.io/CWG/issues/2428.html).
>From a0d5a234431f3db2f0283ffa0909bf8c254aa611 Mon Sep 17 00:00:00 2001
Endilll wrote:
`clang-tidy/checkers/modernize/make-unique.cpp` is failing for whatever reason.
Otherwise LGTM.
https://github.com/llvm/llvm-project/pull/92266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92113
>From 1ae4b4e9c6b76269b7e279f798057900b5d39a0c Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 14 May 2024 15:45:30 +0300
Subject: [PATCH 1/6] [clang] Add tests for CWG issues regarding completeness
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92113
>From 1ae4b4e9c6b76269b7e279f798057900b5d39a0c Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 14 May 2024 15:45:30 +0300
Subject: [PATCH 1/5] [clang] Add tests for CWG issues regarding completeness
@@ -67,6 +63,27 @@ void B::g() requires true;
} // namespace cwg2847
+namespace cwg2857 { // cwg2857: 2.7
+struct A {};
+struct B {
+ int operator+(A);
+};
+template
+struct D;
+
+void f(A* a, D* d) {
+ *d + *a;
Endilll wrote:
Thank you! I used one of
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92113
>From 1ae4b4e9c6b76269b7e279f798057900b5d39a0c Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 14 May 2024 15:45:30 +0300
Subject: [PATCH 1/4] [clang] Add tests for CWG issues regarding completeness
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92113
>From 1ae4b4e9c6b76269b7e279f798057900b5d39a0c Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 14 May 2024 15:45:30 +0300
Subject: [PATCH 1/3] [clang] Add tests for CWG issues regarding completeness
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/92113
This patch covers the following Core issues:
[CWG930](https://cplusplus.github.io/CWG/issues/930.html) "`alignof` with
incomplete array type"
[CWG1110](https://cplusplus.github.io/CWG/issues/1110.html)
Endilll wrote:
@ZequanWu thank you for your help, but next time you should disable renaming
passes as specified in
https://github.com/llvm/llvm-project/pull/89807#issuecomment-2102760018.
C-Reduce output can be typically reduced further manually, but it's a pain
without names.
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/89086
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/91765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/91765
[P1787R6](https://wg21.link/p1787r6):
> [CWG1820](https://cplusplus.github.io/CWG/issues/1820.html) is resolved by
> requiring that a qualified declarator-id declare an entity.
P1787R6 changes wording of
Author: Vlad Serebrennikov
Date: 2024-05-10T19:03:21+03:00
New Revision: ef71c79d85fb3f94f19a92a84ab44719d112c1bd
URL:
https://github.com/llvm/llvm-project/commit/ef71c79d85fb3f94f19a92a84ab44719d112c1bd
DIFF:
Author: Vlad Serebrennikov
Date: 2024-05-10T19:00:20+03:00
New Revision: d358b2de458e0611a3f474a9c3e3deff926c07c4
URL:
https://github.com/llvm/llvm-project/commit/d358b2de458e0611a3f474a9c3e3deff926c07c4
DIFF:
Endilll wrote:
To be clear, we're asking for a reproducer with normal names first and
foremost. I'm thankful for @bgra8 help running `creduce` over what they had,
but we wouldn't had this particular conversation if they also provided full
original reproducer that we could run `creduce` on
Endilll wrote:
> but not having a convenient reproducer is not a good reason to keep the ToT
> Clang in a broken state
As someone who worked on a different reduction of Sam's reproducer yesterday,
and spent whopping 8 hours of work time to get
Endilll wrote:
It'd also be nice if someone can share a reproducer that crashes on trunk but
not on 18.1.0 without names reduced to 1-2 letters. Definitely would speed up
the work towards the fix.
https://github.com/llvm/llvm-project/pull/89807
___
https://github.com/Endilll approved this pull request.
LGTM
You should leave a link in the description to the buildbot failure you're
addressing.
https://github.com/llvm/llvm-project/pull/91718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Endilll approved this pull request.
LGTM, but someone else should take a look as well.
https://github.com/llvm/llvm-project/pull/91692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/91435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
If you're using `creduce`, this set of arguments disables all renaming passes:
`--remove-pass pass_clang rename-fun --remove-pass pass_clang rename-param
--remove-pass pass_clang rename-var --remove-pass pass_clang rename-class
--remove-pass pass_clang rename-cxx-method
Endilll wrote:
@bgra8 Your reduction has names replaced by the tool. This is quite hard to
work with. Can you reduce again, but with renaming passes disabled?
I uploaded your reproducer to CE: https://godbolt.org/z/9PK1oPoPW
https://github.com/llvm/llvm-project/pull/89807
@@ -137,17 +137,16 @@ namespace InhCtor {
int n = b.T(); // expected-error {{'T' is a protected member of
'InhCtor::A'}}
// expected-note@-15 {{declared protected here}}
- // FIXME: EDG and GCC reject this too, but it's not clear why it would be
- //
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/91435
>From 32e3c974d5f3f5651c5805210a7215af4d6df24b Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Wed, 8 May 2024 09:31:32 +0300
Subject: [PATCH] [clang] Add examples from [dcl.init.aggr] to C++ conformance
@@ -137,17 +137,16 @@ namespace InhCtor {
int n = b.T(); // expected-error {{'T' is a protected member of
'InhCtor::A'}}
// expected-note@-15 {{declared protected here}}
- // FIXME: EDG and GCC reject this too, but it's not clear why it would be
- //
@@ -0,0 +1,294 @@
+// RUN: %clang_cc1 -std=c++2c -verify %s
+
Endilll wrote:
Any reference would become outdated the moment this file is touched next time,
so I added one to the PR description, so it makes it into the commit message.
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/91435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/91435
This patch adds examples from
[[dcl.init.aggr]](http://eel.is/c++draft/dcl.init.aggr) to C++ conformance
tests. Testing is done via constant evaluation and static asserts. As far as I
can see, the rest of the
https://github.com/Endilll commented:
`Sema.h` changes look good.
https://github.com/llvm/llvm-project/pull/89565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 200 of 1246 matches
Mail list logo
