Reset_link() callback function (named with reset_subordinates()
in pcie_do_recovery() function) was called before mmio_enabled(),
so exchange the sequence between step 2 MMIO Enabled and step 3
Link Reset accordingly.
Signed-off-by: Wesley Sheng
---
Documentation/PCI/pci-error-recovery.rst | 25
On Thu, Jul 01, 2021 at 05:22:31PM -0500, Bjorn Helgaas wrote:
> Please make the subject a little more specific. "rearrange the
> general sequence" doesn't say anything about what was affected.
>
> On Fri, Jun 18, 2021 at 02:04:46PM +0800, Wesley Sheng wrote:
> > Re
On Fri, Jun 18, 2021 at 05:21:32PM +1000, Oliver O'Halloran wrote:
> On Fri, Jun 18, 2021 at 4:05 PM Wesley Sheng wrote:
> >
> > Reset_link() callback function was called before mmio_enabled() in
> > pcie_do_recovery() function actually, so rearrange the general
>
From: Wesley Sheng
AQA (Admin Queue Attributes) register is a dword size with
lower word of ASQS, and higher word of ACQS.
The code set the variable aqa twice, but it is redundant.
Signed-off-by: Wesley Sheng
---
drivers/nvme/nvme.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
From: Wesley Sheng
Each prp is 8 bytes, calculate the number of prps
per page should just divide page size by 8
there is no need to minus 1
Signed-off-by: Wesley Sheng
---
drivers/nvme/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/nvme.c b/drivers
Reset_link() callback function was called before mmio_enabled() in
pcie_do_recovery() function actually, so rearrange the general
sequence betwen step 2 and step 3 accordingly.
Signed-off-by: Wesley Sheng
---
Documentation/PCI/pci-error-recovery.rst | 23 ---
1 file changed
From: wesleywesley
AQA (Admin Queue Attributes) register is a dword size with
lower word of ASQS, and higher word of ACQS.
The code set the variable aqa twice, but it is redundant.
Signed-off-by: wesleywesley
---
drivers/nvme/nvme.c | 1 -
1 file changed, 1 deletion(-)
diff --git
From: wesleywesley
Each prp is 8 bytes, calculate the number of prps
per page should just divide page size by 8
there is no need to minus 1
Signed-off-by: wesleywesley
---
drivers/nvme/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/nvme.c
Replace "It" with "If", since it is a conditional statement.
Signed-off-by: Wesley Sheng
---
Documentation/PCI/pci-error-recovery.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/PCI/pci-error-recovery.rst
b/Documentation/PCI/pci-erro
In config PCIE_TEGRA194_EP the mode incorrectly referred to
host mode.
Signed-off-by: Wesley Sheng
---
drivers/pci/controller/dwc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/Kconfig
b/drivers/pci/controller/dwc/Kconfig
index
Add function to build prefetch iommu pages command
Signed-off-by: Wesley Sheng
---
drivers/iommu/amd/amd_iommu_types.h | 2 ++
drivers/iommu/amd/iommu.c | 19 +++
2 files changed, 21 insertions(+)
diff --git a/drivers/iommu/amd/amd_iommu_types.h
b/drivers/iommu/amd
Add function to build prefetch iommu pages command
Signed-off-by: Wesley Sheng
---
drivers/iommu/amd/amd_iommu_types.h | 2 ++
drivers/iommu/amd/iommu.c | 19 +++
2 files changed, 21 insertions(+)
diff --git a/drivers/iommu/amd/amd_iommu_types.h
b/drivers/iommu/amd
Add function to build prefetch iommu pages command
Signed-off-by: Wesley Sheng
---
drivers/iommu/amd/amd_iommu_types.h | 2 ++
drivers/iommu/amd/iommu.c | 19 +++
2 files changed, 21 insertions(+)
diff --git a/drivers/iommu/amd/amd_iommu_types.h
b/drivers/iommu/amd
Per <>
ga_tag member is only available when IRTE[GuestMode]=1, this field
should be reserved when IRTE[GuestMode]=0. So change the ga_tag
to rsvd_1 in struct of fields_remap.
Signed-off-by: Wesley Sheng
---
drivers/iommu/amd/amd_iommu_types.h | 2 +-
1 file changed, 1 insertion(+), 1 de
Unify reserved member naming convention to rsvd_x in struct
Signed-off-by: Wesley Sheng
---
drivers/iommu/amd/amd_iommu_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/amd/amd_iommu_types.h
b/drivers/iommu/amd/amd_iommu_types.h
index 30a5d412255a
Add function to build prefetch iommu pages command
Signed-off-by: Wesley Sheng
---
drivers/iommu/amd/amd_iommu_types.h | 2 ++
drivers/iommu/amd/iommu.c | 19 +++
2 files changed, 21 insertions(+)
diff --git a/drivers/iommu/amd/amd_iommu_types.h
b/drivers/iommu/amd
Unify reserved member naming convention to rsvd_x in struct
Signed-off-by: Wesley Sheng
---
drivers/iommu/amd/amd_iommu_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/amd/amd_iommu_types.h
b/drivers/iommu/amd/amd_iommu_types.h
index 30a5d412255a
Per <>
ga_tag member is only available when IRTE[GuestMode]=1, this field
should be reserved when IRTE[GuestMode]=0. So change the ga_tag
to rsvd_1 in struct of fields_remap.
Signed-off-by: Wesley Sheng
---
drivers/iommu/amd/amd_iommu_types.h | 2 +-
1 file changed, 1 insertion(+), 1 de
The comment for ntb_peer_spad_addr and ntb_peer_spad_read
incorrectly referred to peer doorbell register and local
scratchpad register.
Signed-off-by: Wesley Sheng
---
include/linux/ntb.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/ntb.h b/include/linux
The comment for ntb_dev_ops and ntb_dev incorrectly referred to
ntb_ctx_ops and ntb_device.
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
include/linux/ntb.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/ntb.h b/include/linux/ntb.h
index
. Remove the redundant steps from
switchtec_ntb_reinit_peer() function.
Signed-off-by: Joey Zhang
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/ntb/hw/mscc
In case of NTB crosslink topology, the setting of shared memory window in
the virtual partition doesn't reset on peer's reboot. So skip the
unnecessary re-setup of shared memory window for that case.
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
drivers/ntb/hw/mscc
in a work queue and
signal the client once it's done.
Signed-off-by: Joey Zhang
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 66 --
1 file changed, 39 insertions(+), 27 deletions(-)
diff --git a/drivers/ntb
initialization in a work
queue and signal the client once it's done.
Regard,
Wesley
--
Changed since v1:
- It's a resend of v1
--
Joey Zhang (2):
ntb_hw_switchtec: Remove redundant steps of
switchtec_ntb_reinit_peer() function
ntb_hw_switchtec: Fix setup MW with failure bug
Wesley Sheng (1
The hardware supports up to 255 PFFs and the driver only supports 48, so
this patch updates the driver to support them all. To be backward
compatible, a new ioctl and corresponding data structure are created,
while keep the deprecated one.
Signed-off-by: Wesley Sheng
---
drivers/pci/switch
:
- rewrapped the commit message of [PATCH 1/2] into one paragraph
--
Wesley Sheng (2):
switchtec: Fix false maximum supported PCIe function number issue
switchtec: Fix unintended mask of MRPC event
drivers/pci/switch/switchtec.c | 42 +---
include/linux/switchtec.h
we already do for LINK event.
Fixes: 52eabba5bcdb ("switchtec: Add IOCTLs to the Switchtec driver")
Signed-off-by: Wesley Sheng
---
drivers/pci/switch/switchtec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/s
. Remove the redundant steps from
switchtec_ntb_reinit_peer() function.
Signed-off-by: Joey Zhang
Signed-off-by: Wesley Sheng
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
b/drivers
In case of NTB crosslink topology, the setting of shared memory window in
the virtual partition doesn't reset on peer's reboot. So skip the
unnecessary re-setup of shared memory window for that case.
Signed-off-by: Wesley Sheng
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 3 +++
1 file changed
in a work queue and
signal the client once it's done.
Signed-off-by: Joey Zhang
Signed-off-by: Wesley Sheng
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 66 --
1 file changed, 39 insertions(+), 27 deletions(-)
diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
b
initialization in a work
queue and signal the client once it's done.
Regard,
Wesley
Joey Zhang (2):
ntb_hw_switchtec: Remove redundant steps of
switchtec_ntb_reinit_peer() function
ntb_hw_switchtec: Fix setup MW with failure bug
Wesley Sheng (1):
ntb_hw_switchtec: Skip unnecessary re-setup
and corresponding data structure are created,
while keep the deprecated one.
The second is MRPC event unintentionally masked at corner case.
Fix this bug by skipping the mask operation for MRPC event in event ISR
like what we already do for LINK event.
Regard,
Wesley
Wesley Sheng (2):
switchtec
we already do for LINK event.
Fixes: 52eabba5bcdb ("switchtec: Add IOCTLs to the Switchtec driver")
Signed-off-by: Wesley Sheng
---
drivers/pci/switch/switchtec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/s
The hardware supports up to 255 PFFs and the driver only supports 48, so
this patch updates the driver to support them all.
To be backward compatible, a new ioctl and corresponding data
structure are created, while keep the deprecated one.
Signed-off-by: Wesley Sheng
---
drivers/pci/switch
and a proper fix of
this should be done in firmware.
Fixes: 080b47def5e5 ("MicroSemi Switchtec management interface driver")
Signed-off-by: Kelvin Cao
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
drivers/pci/switch/switchtec.c | 4
1 file changed, 4 deletions(-)
From: Boris Glimcher
Switchtec hardware supports 64-bit DMA, set the correct DMA mask.
This allows the CMA to allocate larger buffers for memory windows.
Signed-off-by: Boris Glimcher
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
drivers/pci/switch/switchtec.c | 4
1
seeing reads to this
register are processed by low latency hardware.
Signed-off-by: Kelvin Cao
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
drivers/pci/switch/switchtec.c | 41 +++--
1 file changed, 35 insertions(+), 6 deletions(-)
diff --git
combining
Wesley Sheng (1):
switchtec: MRPC DMA mode implementation
drivers/pci/switch/switchtec.c | 154 -
include/linux/switchtec.h | 16 +
2 files changed, 153 insertions(+), 17 deletions(-)
--
2.7.4
by two readl/writel on systems that do not support it.
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
drivers/pci/switch/switchtec.c | 108 +
include/linux/switchtec.h | 16 ++
2 files changed, 114 insertions(+), 10 deletions(-)
diff
: 52eabba5bcdb ("switchtec: Add IOCTLs to the Switchtec driver")
Signed-off-by: Joey Zhang
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
drivers/pci/switch/switchtec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switcht
nge to between 4K and 2^63.
Reported-by: Boris Glimcher
Signed-off-by: Paul Selles
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 9 +++--
include/linux/switchtec.h | 6 +-
2 files changed, 12 insertions(+), 3 deletions(-)
d
The number of available NT req id mapping table entries per NTB control
register is 512. The driver mistakenly limits the number to 256.
Fix the array size of NT req id mapping table.
Fixes: c082b04c9d40 ("NTB: switchtec: Add NTB hardware register definitions")
Signed-off-by: We
first and add a "Fixes"
line to the commit messages
--
Paul Selles (2):
ntb_hw_switchtec: debug print 64bit aligned crosslink BAR Numbers
ntb_hw_switchtec: Added support of >=4G memory windows
Wesley Sheng (1):
ntb_hw_switchtec: NT req id mapping table register entry numbe
nge to between 4K and 2^63.
Reported-by: Boris Glimcher
Signed-off-by: Paul Selles
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 9 +++--
include/linux/switchtec.h | 6 +-
2 files changed, 12 insertions(+), 3 deletions(-)
d
The number of available NT req id mapping table entries per NTB control
register is 512. The driver mistakenly limits the number to 256.
Fix the array size of NT req id mapping table.
Fixes: c082b04c9d40 ("NTB: switchtec: Add NTB hardware register definitions")
Signed-off-by: We
first and add a "Fixes"
line to the commit messages
--
Paul Selles (2):
ntb_hw_switchtec: debug print 64bit aligned crosslink BAR Numbers
ntb_hw_switchtec: Added support of >=4G memory windows
Wesley Sheng (1):
ntb_hw_switchtec: NT req id mapping table register entry numbe
Signed-off-by: Paul Selles
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
index 5ee5f40..9916
Signed-off-by: Paul Selles
Signed-off-by: Wesley Sheng
Reviewed-by: Logan Gunthorpe
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
index 5ee5f40..9916
nge to between 4K and 2^63.
Reported-by: Boris Glimcher
Signed-off-by: Paul Selles
Signed-off-by: Wesley Sheng
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 9 +++--
include/linux/switchtec.h | 6 +-
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/ntb/hw/m
From: Paul Selles
Switchtec NTB crosslink BARs are 64bit addressed but they are printed as
32bit addressed BARs. Fix debug log to increment the BAR numbers by 2 to
reflect the 64bit address alignment.
Signed-off-by: Paul Selles
Signed-off-by: Wesley Sheng
---
drivers/ntb/hw/mscc
thorpe at
https://github.com/sbates130272/linux-p2pmem on branch of
ntb_multiport_fixes
Regards,
Wesley
Paul Selles (2):
ntb_hw_switchtec: debug print 64bit aligned crosslink BAR Numbers
ntb_hw_switchtec: Added support of >=4G memory windows
Wesley Sheng (1):
ntb_hw_switchtec:
The number of available NT req id mapping table entries per NTB control
register is 512. The driver mistakenly limits the number to 256.
Fix the array size of NT req id mapping table.
Signed-off-by: Wesley Sheng
---
include/linux/switchtec.h | 4 ++--
1 file changed, 2 insertions(+), 2
nge to between 4K and 2^63.
Reported-by: Boris Glimcher
Signed-off-by: Paul Selles
Signed-off-by: Wesley Sheng
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 9 +++--
include/linux/switchtec.h | 6 +-
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/ntb/hw/m
From: Paul Selles
Switchtec NTB crosslink BARs are 64bit addressed but they are printed as
32bit addressed BARs. Fix debug log to increment the BAR numbers by 2 to
reflect the 64bit address alignment.
Signed-off-by: Paul Selles
Signed-off-by: Wesley Sheng
---
drivers/ntb/hw/mscc
thorpe at
https://github.com/sbates130272/linux-p2pmem on branch of
ntb_multiport_fixes
Regards,
Wesley
Paul Selles (2):
ntb_hw_switchtec: debug print 64bit aligned crosslink BAR Numbers
ntb_hw_switchtec: Added support of >=4G memory windows
Wesley Sheng (1):
ntb_hw_switchtec:
The number of available NT req id mapping table entries per NTB control
register is 512. The driver mistakenly limits the number to 256.
Fix the array size of NT req id mapping table.
Signed-off-by: Wesley Sheng
---
include/linux/switchtec.h | 4 ++--
1 file changed, 2 insertions(+), 2
seeing reads to this
register are processed by low latency hardware.
Signed-off-by: Kelvin Cao
Signed-off-by: Wesley Sheng
---
drivers/pci/switch/switchtec.c | 41 +++--
1 file changed, 35 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/switch/switchtec.c
by two readl/writel on systems that do not support it.
Signed-off-by: Wesley Sheng
---
drivers/pci/switch/switchtec.c | 108 +
include/linux/switchtec.h | 16 ++
2 files changed, 114 insertions(+), 10 deletions(-)
diff --git a/drivers/pci/switch
: 52eabba5bcdb ("switchtec: Add IOCTLs to the Switchtec driver")
Signed-off-by: Joey Zhang
Signed-off-by: Wesley Sheng
---
drivers/pci/switch/switchtec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index 480107e..a908
by two readl/writel on systems that do not support it.
Signed-off-by: Wesley Sheng
---
drivers/pci/switch/switchtec.c | 108 +
include/linux/switchtec.h | 16 ++
2 files changed, 114 insertions(+), 10 deletions(-)
diff --git a/drivers/pci/switch
: 52eabba5bcdb ("switchtec: Add IOCTLs to the Switchtec driver")
Signed-off-by: Joey Zhang
Signed-off-by: Wesley Sheng
---
drivers/pci/switch/switchtec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index 480107e..a908
seeing reads to this
register are processed by low latency hardware.
Signed-off-by: Kelvin Cao
Signed-off-by: Wesley Sheng
---
drivers/pci/switch/switchtec.c | 41 +++--
1 file changed, 35 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/switch/switchtec.c
Zhang (1):
switchtec: A temporary variable should be used for the flags of
switchtec_ioctl_event_ctl
Kelvin Cao (2):
switchtec: Remove immediate status check after submit a MRPC command
switchtec: Improve MRPC efficiency by leveraging write combining
Wesley Sheng (1):
switchtec: MRPC
From: Boris Glimcher
Switchtec hardware supports 64-bit DMA, set the correct DMA mask.
This allows the CMA to allocate larger buffers for memory windows.
Signed-off-by: Boris Glimcher
Signed-off-by: Wesley Sheng
---
drivers/pci/switch/switchtec.c | 4
1 file changed, 4 insertions
Zhang (1):
switchtec: A temporary variable should be used for the flags of
switchtec_ioctl_event_ctl
Kelvin Cao (2):
switchtec: Remove immediate status check after submit a MRPC command
switchtec: Improve MRPC efficiency by leveraging write combining
Wesley Sheng (1):
switchtec: MRPC
From: Boris Glimcher
Switchtec hardware supports 64-bit DMA, set the correct DMA mask.
This allows the CMA to allocate larger buffers for memory windows.
Signed-off-by: Boris Glimcher
Signed-off-by: Wesley Sheng
---
drivers/pci/switch/switchtec.c | 4
1 file changed, 4 insertions
and a proper fix of
this should be done in firmware.
Fixes: 080b47def5e5 ("MicroSemi Switchtec management interface driver")
Signed-off-by: Kelvin Cao
Signed-off-by: Wesley Sheng
---
drivers/pci/switch/switchtec.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/pci/switch/swi
and a proper fix of
this should be done in firmware.
Fixes: 080b47def5e5 ("MicroSemi Switchtec management interface driver")
Signed-off-by: Kelvin Cao
Signed-off-by: Wesley Sheng
---
drivers/pci/switch/switchtec.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/pci/switch/swi
68 matches
Mail list logo
