[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-10-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r226874142 --- Diff: R/pkg/tests/fulltests/test_eager_execution.R --- @@ -0,0 +1,52 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-10-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r226874309 --- Diff: R/pkg/tests/fulltests/test_eager_execution.R --- @@ -0,0 +1,52 @@ +# --- End diff -- one thing to note, since test runs

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-10-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r226874251 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -3731,6 +3731,7 @@ test_that("catalog APIs, listTables, listColumns, listFunc

[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-21 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22668 @shivusondur what's your account name on https://issues.apache.org? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #22668: [SPARK-25675] [Spark Job History] Job UI page does not s...

2018-10-21 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22668 merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

spark git commit: [SPARK-25675][SPARK JOB HISTORY] Job UI page does not show pagination with one page

2018-10-21 Thread felixcheung
Repository: spark Updated Branches: refs/heads/master ffe256ce1 -> 4c6c6711d [SPARK-25675][SPARK JOB HISTORY] Job UI page does not show pagination with one page ## What changes were proposed in this pull request? Currently in PagedTable.scala pageNavigation() method, if it is having only one

[GitHub] spark issue #22720: [SPARK-25730][K8S] Delete executor pods from kubernetes ...

2018-10-21 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22720 merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

spark git commit: [SPARK-25730][K8S] Delete executor pods from kubernetes after figuring out why they died

2018-10-21 Thread felixcheung
Repository: spark Updated Branches: refs/heads/master c77aa42f5 -> ffe256ce1 [SPARK-25730][K8S] Delete executor pods from kubernetes after figuring out why they died ## What changes were proposed in this pull request? `removeExecutorFromSpark` tries to fetch the reason the executor exited

[GitHub] spark pull request #22771: [SPARK-25773][Core]Cancel zombie tasks in a resul...

2018-10-20 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22771#discussion_r226818782 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1364,6 +1385,16 @@ private[spark] class DAGScheduler

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-20 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3206 is this going to break, say spark 2.3 with scala 2.11.8? ---

[GitHub] spark pull request #22753: [SPARK-25754][DOC] Change CDN for MathJax

2018-10-17 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22753#discussion_r225792435 --- Diff: docs/_layouts/global.html --- @@ -184,7 +184,8 @@ {{ page.title

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-10-17 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3013 ok, let's go ahead then? ---

[GitHub] spark issue #22608: [SPARK-23257][K8S][TESTS] Kerberos Support Integration T...

2018-10-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22608 I think the suggestion is to go to master & 2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache

[GitHub] spark pull request #22608: [SPARK-23257][K8S][TESTS] Kerberos Support Integr...

2018-10-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r225615864 --- Diff: bin/docker-image-tool.sh --- @@ -71,18 +71,29 @@ function build { --build-arg base_img=$(image_ref spark

[GitHub] spark issue #22730: [SPARK-16775][CORE] Remove deprecated accumulator v1 API...

2018-10-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22730 no accumulator in R --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #22721: [SPARK-25403][SQL] Refreshes the table after inse...

2018-10-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22721#discussion_r225418234 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -189,6 +189,7 @@ case

[GitHub] spark issue #22720: [SPARK-25730][K8S] Delete executor pods from kubernetes ...

2018-10-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22720 cool, any more comment? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #22727: [SPARK-25735][CORE][MINOR]Improve start-thriftser...

2018-10-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22727#discussion_r225417566 --- Diff: sbin/start-thriftserver.sh --- @@ -39,6 +39,10 @@ function usage { pattern+="\|Spark Command: "

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-10-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3013 possibly? any objection from reviewers of this change/PR? ---

[GitHub] spark issue #22720: [K8S] Delete executor pods from kubernetes after figurin...

2018-10-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22720 can you open a JIRA --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22720: [K8S] Delete executor pods from kubernetes after figurin...

2018-10-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22720 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22714: [SPARK-25720][WEBUI] Support auto refresh page for the W...

2018-10-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22714 can this be passed in as a param in the url? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-10-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3013 any update? ---

[GitHub] spark pull request #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-10-12 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22379#discussion_r224949068 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3854,6 +3854,38 @@ object functions { @scala.annotation.varargs

[GitHub] spark pull request #22668: [SPARK-25675] [Spark Job History] Job UI page doe...

2018-10-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22668#discussion_r224316034 --- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala --- @@ -123,10 +123,9 @@ private[ui] trait PagedTable[T

[GitHub] spark issue #22689: [SPARK-25697][CORE]When zstd compression enabled, InProg...

2018-10-10 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22689 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #22681: [SPARK-25682][k8s] Package example jars in same t...

2018-10-10 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22681#discussion_r224314585 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile --- @@ -18,6 +18,7 @@ FROM openjdk:8-alpine ARG

[GitHub] spark pull request #21710: [SPARK-24207][R]add R API for PrefixSpan

2018-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21710#discussion_r223574367 --- Diff: R/pkg/R/mllib_fpm.R --- @@ -154,3 +160,74 @@ setMethod("write.ml", signature(object = "FPGrowthModel"

[GitHub] spark pull request #21710: [SPARK-24207][R]add R API for PrefixSpan

2018-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21710#discussion_r223574019 --- Diff: R/pkg/R/mllib_fpm.R --- @@ -154,3 +160,74 @@ setMethod("write.ml", signature(object = "FPGrowthModel"

[GitHub] spark pull request #21710: [SPARK-24207][R]add R API for PrefixSpan

2018-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21710#discussion_r223573856 --- Diff: R/pkg/R/mllib_fpm.R --- @@ -154,3 +160,74 @@ setMethod("write.ml", signature(object = "FPGrowthModel"

[GitHub] spark pull request #21710: [SPARK-24207][R]add R API for PrefixSpan

2018-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21710#discussion_r223572974 --- Diff: R/pkg/R/mllib_fpm.R --- @@ -154,3 +160,74 @@ setMethod("write.ml", signature(object = "FPGrowthModel"

[GitHub] spark pull request #21710: [SPARK-24207][R]add R API for PrefixSpan

2018-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21710#discussion_r223572694 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/PrefixSpanWrapper.scala --- @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22645 @shahidki31 ^^ --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #22615: [SPARK-25016][BUILD][CORE] Remove support for Had...

2018-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22615#discussion_r223571584 --- Diff: docs/index.md --- @@ -30,9 +30,6 @@ Spark runs on Java 8+, Python 2.7+/3.4+ and R 3.1+. For the Scala API, Spark {{s uses Scala

[GitHub] spark pull request #22615: [SPARK-25016][BUILD][CORE] Remove support for Had...

2018-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22615#discussion_r223571106 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala --- @@ -71,7 +71,7 @@ class HadoopTableReader( // Hadoop

[GitHub] spark pull request #22615: [SPARK-25016][BUILD][CORE] Remove support for Had...

2018-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22615#discussion_r223570946 --- Diff: dev/create-release/release-build.sh --- @@ -191,9 +191,17 @@ if [[ "$1" == "package" ]]; then make_binary_release(

[GitHub] spark issue #22615: [SPARK-25016][BUILD][CORE] Remove support for Hadoop 2.6

2018-10-09 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22615 I think we all know enough to not to make changes (merge changes) to these config, should be safe. --- - To unsubscribe, e

[GitHub] spark issue #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pagination...

2018-10-09 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22645 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22675: [SPARK-25347][ML][DOC] Spark datasource for image/libsvm...

2018-10-09 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22675 we need this for 2.4? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21710: [SPARK-24207][R]add R API for PrefixSpan

2018-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21710#discussion_r223568243 --- Diff: R/pkg/R/mllib_fpm.R --- @@ -154,3 +160,74 @@ setMethod("write.ml", signature(object = "FPGrowthModel"

[GitHub] spark pull request #21710: [SPARK-24207][R]add R API for PrefixSpan

2018-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21710#discussion_r223568592 --- Diff: docs/ml-frequent-pattern-mining.md --- @@ -85,3 +85,56 @@ Refer to the [R API docs](api/R/spark.fpGrowth.html) for more details

[GitHub] spark pull request #21710: [SPARK-24207][R]add R API for PrefixSpan

2018-10-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21710#discussion_r223568708 --- Diff: examples/src/main/python/ml/prefixspan_example.py --- @@ -0,0 +1,48 @@ +# --- End diff -- ditto for java and scala and python

[GitHub] spark pull request #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pag...

2018-10-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22645#discussion_r223198079 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala --- @@ -121,74 +122,257 @@ private[ui] class

[GitHub] spark issue #22608: [SPARK-23257][K8S][TESTS] Kerberos Support Integration T...

2018-10-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22608 > calling an external docker-image like: ifilonenko/hadoop-base:latest for now for now it's probably ok, but is there a solution before the next rele

[GitHub] spark pull request #22275: [SPARK-25274][PYTHON][SQL] In toPandas with Arrow...

2018-10-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22275#discussion_r223197940 --- Diff: python/pyspark/sql/tests.py --- @@ -4434,6 +4434,12 @@ def test_timestamp_dst(self): self.assertPandasEqual(pdf

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-10-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r223197863 --- Diff: R/pkg/R/DataFrame.R --- @@ -246,30 +248,38 @@ setMethod("showDF", #' @note show(SparkDataFrame) since 1.4.0 setMe

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-10-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r223197875 --- Diff: R/pkg/R/DataFrame.R --- @@ -246,30 +248,38 @@ setMethod("showDF", #' @note show(SparkDataFrame) since 1.4.0 setMe

[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

2018-10-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22145 @shaneknapp could we do this soon? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22645: [SPARK-25566][SPARK-25567][WEBUI][SQL]Support pag...

2018-10-06 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22645#discussion_r223174258 --- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala --- @@ -31,7 +31,7 @@ import org.apache.spark.util.Utils * * @param

[GitHub] spark issue #22639: [SPARK-25647][k8s] Add spark streaming compatibility sui...

2018-10-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22639 @liyinan926 @mccheah --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #22625: [SPARK-25637][CORE] SparkException: Could not fin...

2018-10-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22625#discussion_r222550195 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -98,6 +98,8 @@ class

[GitHub] spark pull request #22615: [SPARK-25016][BUILD][CORE] Remove support for Had...

2018-10-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22615#discussion_r222549104 --- Diff: dev/appveyor-install-dependencies.ps1 --- @@ -95,7 +95,7 @@ $env:MAVEN_OPTS = "-Xmx2g -XX:ReservedCodeCacheSize=512m" Po

[GitHub] spark issue #21710: [SPARK-24207][R]add R API for PrefixSpan

2018-10-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21710 actually, as of 2 hrs ago seems like we are skipping 2.5, to 3.0. we could wait a bit until that is merged

[GitHub] zeppelin issue #3200: ZEPPELIN-3804. Separate log file for each interpreter ...

2018-10-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3200 how to find out which log file is for which? ---

[GitHub] zeppelin issue #3132: [ZEPPELIN-3701].Missing first several '0' and losing d...

2018-10-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3132 this should be in 0.9. as for release date plan, please ask on dev@zeppelin.apache.org ---

[GitHub] spark issue #20405: [SPARK-23229][SQL] Dataset.hint should use planWithBarri...

2018-10-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20405 probably. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22527: [SPARK-17952][SQL] Nested Java beans support in createDa...

2018-09-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22527 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] zeppelin issue #3197: docs: fix punctuation

2018-09-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3197 can you also check other .md? it's probably best to have one PR ---

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21669 like it, but we could also first support cluster mode and add client mode after. --- - To unsubscribe, e-mail: reviews

spark git commit: [SPARK-25572][SPARKR] test only if not cran

2018-09-29 Thread felixcheung
ava 10, which unfortunately Spark does not start on. For 2.4, lets attempt skipping all tests ## How was this patch tested? manual, jenkins, appveyor Author: Felix Cheung Closes #22589 from felixcheung/ralltests. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-

[GitHub] spark issue #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22589 merged to master/2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

spark git commit: [SPARK-25572][SPARKR] test only if not cran

2018-09-29 Thread felixcheung
run on Java 10, which unfortunately Spark does not start on. For 2.4, lets attempt skipping all tests ## How was this patch tested? manual, jenkins, appveyor Author: Felix Cheung Closes #22589 from felixcheung/ralltests. (cherry picked from commit f4b138082ff91be74b0f5bbe19cdb90dd9e5f131) Signed-

[GitHub] spark pull request #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-29 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22589#discussion_r221440760 --- Diff: R/pkg/tests/run-all.R --- @@ -18,50 +18,55 @@ library(testthat) library(SparkR) -# Turn all warnings into errors

[GitHub] spark issue #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22589 We are tryin this now - we can clean it up if this works

[GitHub] spark issue #21710: [SPARK-24207][R]add R API for PrefixSpan

2018-09-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21710 @huaxingao do you want to bring this up to 2.5.0? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22589 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #22588: [SPARK-25262][DOC][FOLLOWUP] Fix link tags in html table

2018-09-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22588 @ifilonenko @liyinan926 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22589 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22589 really odd error, not sure if it's related to an earlier change? @HyukjinKwon what do you think? ``` . Error: Test correct concurrency of RRDD.compute() (@test_rdd.R#800

[GitHub] spark issue #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22589 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22589 diff w/o whitespace for actual change --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-28 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/22589 [SPARK-25572][SPARKR] test only if not cran ## What changes were proposed in this pull request? CRAN doesn't seem to respect the system requirements as running tests - we have seen

[GitHub] spark pull request #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22379#discussion_r221415711 --- Diff: R/pkg/R/functions.R --- @@ -2203,6 +2209,23 @@ setMethod("from_json", signature(x = "Column", schema = &q

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r221416198 --- Diff: R/pkg/tests/fulltests/test_eager_execution.R --- @@ -21,11 +21,7 @@ context("Show SparkDataFrame when eager execution is en

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r221416164 --- Diff: R/pkg/tests/fulltests/test_eager_execution.R --- @@ -21,11 +21,7 @@ context("Show SparkDataFrame when eager execution is en

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r221415826 --- Diff: R/pkg/R/DataFrame.R --- @@ -246,30 +248,38 @@ setMethod("showDF", #' @note show(SparkDataFrame) since 1.4.0 setMe

[GitHub] zeppelin issue #3185: Copy-editing overview.md

2018-09-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3185 this was merged? is github not syncing? ---

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r220034035 --- Diff: R/pkg/R/DataFrame.R --- @@ -244,11 +246,25 @@ setMethod("showDF", #' @note show(SparkDataFrame) since 1.4.0 setMe

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r220033577 --- Diff: R/pkg/R/DataFrame.R --- @@ -244,11 +246,31 @@ setMethod("showDF", #' @note show(SparkDataFrame) since 1.4.0 setMe

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r220033775 --- Diff: docs/sparkr.md --- @@ -450,6 +450,48 @@ print(model.summaries) {% endhighlight %} +### Eager execution

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r220033684 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1491,9 +1491,10 @@ object SQLConf { val

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r220030686 --- Diff: R/pkg/tests/fulltests/test_eager_execution.R --- @@ -0,0 +1,60 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark issue #22537: [SPARK-21291][R] add R partitionBy API in DataFrame

2018-09-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22537 could you kick off appveyor again by close/re-open this PR? also might need to split the JIRA - since it's referring to both partition and bucket

zeppelin git commit: Copy-editing overview.md

2018-09-24 Thread felixcheung
Repository: zeppelin Updated Branches: refs/heads/master 86ee813e4 -> 6c623d323 Copy-editing overview.md Extensive grammar revisions for zeppelin/docs/usage/interpreter/overview.md ### What is this PR for? The documentation at zeppelin/docs/usage/interpreter/overview.md contained numerous

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-09-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22455 > Looks like the test was terminated in the middle, not likely related to the any code change. Could someone please ask for retest? Thanks. appveyor one? you need to close and re-o

[GitHub] zeppelin issue #3185: Copy-editing overview.md

2018-09-23 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3185 LGTM merging if no more comment ---

[GitHub] zeppelin issue #3185: Copy-editing overview.md

2018-09-23 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3185 great, thx! ---

[GitHub] spark pull request #22227: [SPARK-25202] [SQL] Implements split with limit s...

2018-09-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/7#discussion_r219714851 --- Diff: R/pkg/R/functions.R --- @@ -3404,19 +3404,27 @@ setMethod("collect_set", #' Equivalent to \code{split} SQ

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r219689581 --- Diff: R/pkg/tests/fulltests/test_eager_execution.R --- @@ -0,0 +1,61 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r219689697 --- Diff: R/pkg/R/DataFrame.R --- @@ -244,11 +246,25 @@ setMethod("showDF", #' @note show(SparkDataFrame) since 1.4.0 setMe

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r219689694 --- Diff: R/pkg/R/DataFrame.R --- @@ -244,11 +246,25 @@ setMethod("showDF", #' @note show(SparkDataFrame) since 1.4.0 setMe

[GitHub] spark issue #22305: [SPARK-24561][SQL][Python] User-defined window aggregati...

2018-09-21 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22305 @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #22275: [SPARK-25274][PYTHON][SQL] In toPandas with Arrow...

2018-09-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22275#discussion_r219404072 --- Diff: python/pyspark/sql/tests.py --- @@ -4434,6 +4434,12 @@ def test_timestamp_dst(self): self.assertPandasEqual(pdf

[GitHub] spark issue #22275: [SPARK-25274][PYTHON][SQL] In toPandas with Arrow send o...

2018-09-21 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22275 got it. so the size of the each batch could grow. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r219402870 --- Diff: R/pkg/R/DataFrame.R --- @@ -244,11 +245,15 @@ setMethod("showDF", #' @note show(SparkDataFrame) since 1.4.0 setMe

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r219402281 --- Diff: R/pkg/R/DataFrame.R --- @@ -244,11 +245,15 @@ setMethod("showDF", #' @note show(SparkDataFrame) since 1.4.0 setMe

[GitHub] spark issue #22227: [SPARK-25202] [SQL] Implements split with limit sql func...

2018-09-19 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/7 long thread, are we all good with this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21649: [SPARK-23648][R][SQL]Adds more types for hint in SparkR

2018-09-19 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21649 merged to master, thx --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

spark git commit: [SPARK-23648][R][SQL] Adds more types for hint in SparkR

2018-09-19 Thread felixcheung
Repository: spark Updated Branches: refs/heads/master 76399d75e -> 95b177c8f [SPARK-23648][R][SQL] Adds more types for hint in SparkR ## What changes were proposed in this pull request? Addition of numeric and list hints for SparkR. ## How was this patch tested? Add test in test_sparkSQL.R

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r219030775 --- Diff: R/pkg/R/DataFrame.R --- @@ -244,11 +244,15 @@ setMethod("showDF", #' @note show(SparkDataFrame) since 1.4.0 setMe

<    1   2   3   4   5   6   7   8   9   10   >