Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219030350
--- Diff: docs/sparkr.md ---
@@ -450,6 +450,42 @@ print(model.summaries)
{% endhighlight %}
+### Eager execution
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219030512
--- Diff: R/pkg/tests/fulltests/test_eager_execution.R ---
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219030211
--- Diff: docs/sparkr.md ---
@@ -450,6 +450,42 @@ print(model.summaries)
{% endhighlight %}
+### Eager execution
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219030277
--- Diff: docs/sparkr.md ---
@@ -450,6 +450,42 @@ print(model.summaries)
{% endhighlight %}
+### Eager execution
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219029847
--- Diff: docs/sparkr.md ---
@@ -450,6 +450,42 @@ print(model.summaries)
{% endhighlight %}
+### Eager execution
--- End diff
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219030474
--- Diff: R/pkg/tests/fulltests/test_eager_execution.R ---
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219030085
--- Diff: docs/sparkr.md ---
@@ -450,6 +450,42 @@ print(model.summaries)
{% endhighlight %}
+### Eager execution
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219030537
--- Diff: R/pkg/tests/fulltests/test_eager_execution.R ---
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22379
think maybe someone to review the SQL stuff more?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r217953294
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -1803,6 +1803,18 @@ test_that("string operators", {
collect(select(df4, split_
Repository: spark
Updated Branches:
refs/heads/branch-2.4 60af706b4 -> 1cb1e4301
[MINOR][DOCS] Axe deprecated doc refs
Continuation of #22370. Summary of discussion there:
There is some inconsistency in the R manual w.r.t. supercedent functions
linking back to deprecated functions.
-
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22393
thx. merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Repository: spark
Updated Branches:
refs/heads/master bfcf74260 -> a1dd78255
[MINOR][DOCS] Axe deprecated doc refs
Continuation of #22370. Summary of discussion there:
There is some inconsistency in the R manual w.r.t. supercedent functions
linking back to deprecated functions.
-
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22393
yes please - please double the doc created looks correct - there is no
automatic test for that
---
-
To unsubscribe, e-mail
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21515
UID already exists?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r217901635
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -1803,6 +1803,10 @@ test_that("string operators", {
collect(select(df4, split_
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r217901558
--- Diff: R/pkg/NAMESPACE ---
@@ -275,6 +275,7 @@ exportMethods("%<=>%",
"format_number",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r217901588
--- Diff: R/pkg/R/functions.R ---
@@ -2202,6 +2208,24 @@ setMethod("from_json", signature(x = "Column",
schema = &q
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22393
could you check the doc output manually for registerTempTable and
createTable?
---
-
To unsubscribe, e-mail: reviews
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22379
see comment above/
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r216875875
--- Diff: R/pkg/R/functions.R ---
@@ -3720,3 +3720,22 @@ setMethod("current_timestamp",
jc <
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r216875804
--- Diff: R/pkg/R/functions.R ---
@@ -3720,3 +3720,22 @@ setMethod("current_timestamp",
jc <
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22376
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21710
I think we missed the windows before the branch, I'll review in a few days
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22192
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21649#discussion_r216539767
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3939,7 +3929,15 @@ setMethod("hint",
signature(x = "SparkDataFrame"
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22370#discussion_r216539411
--- Diff: R/pkg/R/catalog.R ---
@@ -69,7 +69,6 @@ createExternalTable <- function(x, ...) {
#' @param ... additional named parameters as opti
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r216538924
--- Diff: R/pkg/R/functions.R ---
@@ -3720,3 +3720,22 @@ setMethod("current_timestamp",
jc <
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22357
if recall, parquet reader can have filter pushdown? only not so in spark
parquet data source?
---
-
To unsubscribe, e-mail
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22376
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22370
I donât feel strongly either way.
I do think this is very minor since there are still many other ways to the
doc page for createExternalTable (eg the index page) or via ? search
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21649
Right - I think we could inline it or simplify it further
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22372
do we have jenkins tests for 3.1 profile?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22371
+ @srowen @squito @JoshRosen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22358#discussion_r216165218
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -398,10 +398,10 @@ object SQLConf
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22298
+1 for 2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21649#discussion_r216122842
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3905,6 +3905,16 @@ setMethod("rollup",
group
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21649#discussion_r216122804
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3905,6 +3905,16 @@ setMethod("rollup",
group
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22144
hey, this looks important, could someone review this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22362#discussion_r216122659
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -199,8 +199,8 @@ private[deploy] class SparkSubmitArguments
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r216122621
--- Diff: R/pkg/R/functions.R ---
@@ -3404,19 +3404,24 @@ setMethod("collect_set",
#' Equivalent to \code{split} SQ
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22335
please fix the description for this PR - the top part contains the
truncated title
---
-
To unsubscribe, e-mail: reviews
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22145
what's the latest on this, btw?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22274
merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Repository: spark
Updated Branches:
refs/heads/master 64bbd134e -> 39d3d6cc9
[SPARK-25167][SPARKR][TEST][MINOR] Minor fixes for R sql tests (timestamp
comparison)
## What changes were proposed in this pull request?
The "date function on DataFrame" test fails consistently on my laptop. In
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22274
possible - but since this passes for you and in jenkins/appveyor you change
seem to work both ways, which is good enough for me
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214550394
--- Diff: examples/src/main/python/worker_memory_check.py ---
@@ -0,0 +1,47 @@
+#
--- End diff --
I think the concern here is shipping
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22274
interesting. maybe something to do with newer R release - I scanned through
the rel note though but didn't find what might be related
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22291
merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Repository: spark
Updated Branches:
refs/heads/master a3dccd24c -> a481794ca
[SPARK-25007][R] Add array_intersect/array_except/array_union/shuffle to SparkR
## What changes were proposed in this pull request?
Add the R version of array_intersect/array_except/array_union/shuffle
## How was
Repository: zeppelin
Updated Branches:
refs/heads/master 26b554d64 -> 57601f819
[ZEPPELIN-3753] Fix indent with TAB
### What is this PR for?
Now when you select multiline text and press TAB, text replaces with "\t" char.
With this PR text just shift right if TAB have been pressed.
### What
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22274
maybe also your laptop's system time zone? could you also check that?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r214530177
--- Diff: python/pyspark/sql/session.py ---
@@ -252,6 +252,16 @@ def newSession(self):
"""
return self.__c
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214530079
--- Diff: examples/src/main/python/worker_memory_check.py ---
@@ -0,0 +1,47 @@
+#
--- End diff --
shouldn't this be in python tests
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r214529571
--- Diff: python/pyspark/sql/functions.py ---
@@ -1669,20 +1669,36 @@ def repeat(col, n):
return Column(sc._jvm.functions.repeat
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3168
merging if no more comment
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21743
also, I don't recall anywhere in spark that depends/sets MDC...
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18877
yes @danelkotev `asfgit closed this in cba826d on Aug 15, 2017`
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r214244981
--- Diff: python/pyspark/sql/functions.py ---
@@ -1669,20 +1669,36 @@ def repeat(col, n):
return Column(sc._jvm.functions.repeat
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r214244918
--- Diff: R/pkg/R/functions.R ---
@@ -3410,13 +3410,14 @@ setMethod("collect_set",
#' \dontrun{
#' head(select(df, split_str
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22274#discussion_r214244580
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -3633,7 +3633,8 @@ test_that("catalog APIs, currentDatabase,
setCurrentDatabase, listData
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22291#discussion_r214244359
--- Diff: R/pkg/R/generics.R ---
@@ -799,10 +807,18 @@ setGeneric("array_sort", function(x) {
standardGeneric("array_sort") }
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/6#discussion_r214243115
--- Diff: R/pkg/R/functions.R ---
@@ -1697,8 +1697,8 @@ setMethod("to_date",
})
#' @details
-#' \code{to_json}
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20146
seems like this was a thumbs-up from @WeichenXu123 @jkbradley?
@dbtsai ?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3158
ok
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22192
Jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3158
I see. might be good to get some consensus first - we seem to be doing
quite a bit of style changes in the last few months, it would make maintenance
or backporting harder, for example.
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3158
what's wrong with `maven-checkstyle-plugin`?
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20838
Or that Bryan opens a PR on your branch? that usually would be easier to
get *this* PR through, just my 2c
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22161#discussion_r211487544
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -3613,11 +3613,11 @@ test_that("Collect on DataFrame when NAs exists at
the top of a time
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3153
LGTM
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21584
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22107
merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Repository: spark
Updated Branches:
refs/heads/master c1ffb3c10 -> 162326c0e
[SPARK-25117][R] Add EXEPT ALL and INTERSECT ALL support in R
## What changes were proposed in this pull request?
[SPARK-21274](https://issues.apache.org/jira/browse/SPARK-21274) added support
for EXCEPT ALL and
Repository: zeppelin
Updated Branches:
refs/heads/master 09d44d504 -> 1267e33a0
[ZEPPELIN-3701].Missing first several '0' and losing digital accuracy in result
table
### What is this PR for?
Improvements:
-Datas like '00058806' will be displayed correctly instead of '58806'.
-Datas like
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21221
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r210492311
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -216,8 +217,7 @@ private[spark] class Executor(
def stop
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r210492513
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -69,6 +69,11 @@ package object config {
.bytesConf
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21835#discussion_r210489980
--- Diff: R/pkg/R/functions.R ---
@@ -3320,7 +3321,7 @@ setMethod("explode",
#' @aliases sequence sequence,Column-method
#' @not
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210488842
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2848,6 +2848,35 @@ setMethod("intersect",
dataFrame(i
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210488890
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2876,6 +2905,37 @@ setMethod("except",
dataFram
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210488754
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2848,6 +2848,35 @@ setMethod("intersect",
dataFrame(i
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210488641
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2876,6 +2905,37 @@ setMethod("except",
dataFram
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3139
LGTM
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22095
@mccheah btw, please add a comment (say "merged to master") after you merge
a PR - just a convention in this project
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22095
@mccheah @foxish
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22071
in this case maybe ok. perhaps just rel note this iff there's another 2.2.x
or 2.1.x releases?
---
-
To unsubscribe, e-mail
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3087
this is just for syntax highlighting, there is no interpreter code here.
also even for syntax the ACE editor should be set with the language of
choice - this PR does not have either
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3132
merging if no more comment
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3136
Paragraph or REST API.
though looks like it will break all existing notebook saved since it
changes the persistent json. is there a way to make them compatible?
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22109
@vanzin @squito
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22084#discussion_r209507960
--- Diff: dev/make-distribution.sh ---
@@ -188,6 +190,23 @@ if [ -f
"$SPARK_HOME"/common/network-yarn/target/scala*/spark-*-yarn-shuffle.jar
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22081#discussion_r209443568
--- Diff: pom.xml ---
@@ -984,24 +987,15
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3118
I'd agree, this seems like the intent of the report mode. maybe you can add
a option to report mode instead to keep the frame for the chart?
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21027
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22071
@tnachen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22072
jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22072
```
* checking CRAN incoming feasibility ...Error in
.check_package_CRAN_incoming(pkgdir) :
dims [product 26] do not match the length of object [0
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3107
I think there is significant risk that some users are just running all
âsampleâ notebook to check them out not fully aware that some might be
modifying system state.
Agreed
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21927#discussion_r208123913
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1946,4 +1990,11 @@ private[spark] object DAGScheduler
301 - 400 of 6371 matches
Mail list logo
