[GitHub] zeppelin issue #2891: ZEPPELIN-1070: Inject Credentials in any Interpreter-C...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2891 thanks, sounds like that could be useful. what do you think about "secret" management? also for template I think we should match the other way, where we have a longer discussion: #2834 ---

[GitHub] zeppelin issue #2831: ZEPPELIN-3281. Apply getRelativePath when it is LocalC...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2831 of course, let's do the right thing. feel free to ping me in all PR, but generally I should get to it within a day, at least for the next few months. :) ---

[GitHub] zeppelin issue #2587: [ZEPPELIN-2909]. Support shared SparkContext across la...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2587 ok thanks, didn't realize it's been 7 months... :) ---

[GitHub] zeppelin issue #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2892 seems like test fail for unrelated reason - is it out of date or something? ``` [WARNING] The requested profile "hadoop2" could not be activated because it does not exist.

[GitHub] zeppelin issue #2893: ZEPPELIN-3161. Fixed Checkstyle issues in lens module

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2893 merging if no more comment ---

[GitHub] spark issue #20900: [SPARK-23645][MINOR][DOCS][PYTHON] Add docs RE `pandas_u...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20900 > One general question: how do we tend to think about the py2/3 split for api quirks/features? Must everything that is added for py3 also be functional in py2? idea

[GitHub] zeppelin issue #2587: [ZEPPELIN-2909]. Support shared SparkContext across la...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2587 still, I think this feature is distinctive enough that we should document and bring some visibility (even if it just works) ---

[GitHub] zeppelin issue #2793: ZEPPELIN-3226. Fail to launch IPySparkInterpreter in e...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2793 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2831: ZEPPELIN-3281. Apply getRelativePath when it is LocalC...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2831 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2837: ZEPPELIN-3279. [FlakyTest] NotebookTest.testPerSession...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2837 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2836: ZEPPELIN-3291. Throw exception instead of return null ...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2836 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2843: ZEPPELIN-3299. Combine spark integration test with its...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2843 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2838: ZEPPELIN-3277. NotebookServerTest.testMakeSureNoAngula...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2838 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2844: ZEPPELIN-3296. Reorg livy integration test to minimize...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2844 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2861: ZEPPELIN-3322. Update interpreterBind when restarting ...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2861 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2846: ZEPPELIN-3302. Update SparkVersion.java to support Spa...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2846 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2865: [HOTFIX] More proper error message when interpreter is...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2865 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2866: ZEPPELIN-3328. Add plotting test for LivyInterpreter

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2866 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2869: ZEPPELIN-3330. Add more test for RemoteInterpreterServ...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2869 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2874: ZEPPELIN-3339. Add more test for ZeppelinContext

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2874 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2871: ZEPPELIN-3337. Add more test to SparkRInterpreter

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2871 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2875: ZEPPELIN-3343. Interpreter Hook is broken

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2875 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2877: ZEPPELIN-3345. Don't load interpreter setting when it ...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2877 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2878: ZEPPELIN-3331. Use NullLifecycleManager by default

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2878 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2882: ZEPPELIN-3290. Unnecessary message 'IPython is availab...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2882 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] zeppelin issue #2887: ZEPPELIN-3357. Livy security mode is broken

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2887 hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? @Leemoonsoo ---

[GitHub] spark pull request #20267: [SPARK-23068][BUILD][RELEASE][WIP] doc build erro...

Github user felixcheung closed the pull request at: https://github.com/apache/spark/pull/20267 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2834 @zjffdu do we still merge commits to branch-0.8? ---

[GitHub] spark pull request #20787: [MINOR][DOCS] Documenting months_between directio...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20787#discussion_r176925831 --- Diff: R/pkg/R/functions.R --- @@ -1957,8 +1958,12 @@ setMethod("levenshtein", signature(y = "Column"), })

[GitHub] spark pull request #20787: [MINOR][DOCS] Documenting months_between directio...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20787#discussion_r176925842 --- Diff: R/pkg/R/functions.R --- @@ -1957,8 +1958,12 @@ setMethod("levenshtein", signature(y = "Column"), })

[GitHub] spark issue #20897: [MINOR][DOC] Fix a few markdown typos

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20897 jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #20896: [SPARK-23788][SS] Fix race in StreamingQuerySuite

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20896#discussion_r176902181 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQuerySuite.scala --- @@ -550,22 +550,22 @@ class StreamingQuerySuite extends

[GitHub] spark issue #20003: [SPARK-22817][R] Use fixed testthat version for SparkR t...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20003 yea, I started doing some work but was staled, let me check.. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20889 @Lemonjing you need to close the PR from github.com - we don't have access to close it --- - To unsubscribe, e-mail

[GitHub] spark issue #20897: [MINOR][DOC] Fix a few markdown typos

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20897 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20889 can you check if we have other typo in the md file? or similar type of typo in other md files? --- - To unsubscribe, e

[GitHub] spark issue #20864: [SPARK-23745][SQL]Remove the directories of the “hive....

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20864 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #20860: [SPARK-23743][SQL] Changed a comparison logic fro...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20860#discussion_r176646535 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala --- @@ -179,7 +179,7 @@ private[hive] class

[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20879 thanks! those are on me then. are we not running lintr? or these checks are on the newer version only

[GitHub] zeppelin issue #2880: [ZEPPELIN-3351] Fix to build for spark 2.3

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2880 I think we should try to fix the build profile as in this PR. But we must fix the download source - otherwise given what I’ve seen recently, we cannot release (its not up to me) ---

[GitHub] zeppelin issue #2854: ZEPPELIN-3310. Scio interpreter layout is broken

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2854 thanks - sorry about the delay ---

zeppelin git commit: ZEPPELIN-3310. Scio interpreter layout is broken

Repository: zeppelin Updated Branches: refs/heads/master 7dc4dbea5 -> 2a5960bd5 ZEPPELIN-3310. Scio interpreter layout is broken ### What is this PR for? Fix scio interpreter layout. The current scio interpreter layout is broken because there is not a newline between %table part and %text

[GitHub] zeppelin issue #2867: ZEPPELIN-3332

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2867 @herval @Leemoonsoo ---

[GitHub] zeppelin issue #2870: [ZEPPELIN-3335] trim property name of interpreter sett...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2870 can you check https://travis-ci.org/rockiee281/zeppelin/builds/353672192 ---

[GitHub] spark issue #20788: [SPARK-23647][PYTHON][SQL] Adds more types for hint in p...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20788 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #20788: [SPARK-23647][PYTHON][SQL] Adds more types for hi...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20788#discussion_r175008195 --- Diff: python/pyspark/sql/dataframe.py --- @@ -437,10 +437,11 @@ def hint(self, name, *parameters): if not isinstance(name, str

[GitHub] spark issue #20822: [SPARK-23680] Fix entrypoint.sh to properly support Arbi...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20822 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] zeppelin issue #2412: [ZEPPELIN-2641] Change encoding to UTF-8 when sending ...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2412 Should this be fixed in Livy? ---

[GitHub] spark issue #17774: [SPARK-18371][Streaming] Spark Streaming backpressure ge...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17774 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20791: [SPARK-23618][K8s][BUILD] Initialize BUILD_ARGS in docke...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20791 Hi @jooseong do you have a ASF JIRA user account? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20754: [SPARK-23287][CORE] Spark scheduler does not remove init...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20754 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #20788: [SPARK-23647][PYTHON][SQL] Adds more types for hi...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20788#discussion_r174367197 --- Diff: python/pyspark/sql/dataframe.py --- @@ -437,10 +437,11 @@ def hint(self, name, *parameters): if not isinstance(name, str

[GitHub] spark pull request #20807: SPARK-23660: Fix exception in yarn cluster mode w...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20807#discussion_r174027869 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -496,7 +497,7 @@ private[yarn] class

[GitHub] zeppelin issue #2854: ZEPPELIN-3310. Scio interpreter layout is broken

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2854 merging if no more comment ---

[GitHub] spark issue #20791: [SPARK-23618][BUILD] Initialize BUILD_ARGS in docker-ima...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20791 @foxish --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20791: [SPARK-23618][BUILD] Initialize BUILD_ARGS in docker-ima...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20791 could you add [K8s] into PR title --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #20791: [SPARK-23618][BUILD] Initialize BUILD_ARGS in docker-ima...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20791 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20793: [SPARK-23643] Shrinking the buffer in hashSeed up to siz...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20793 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #20788: [WIP][SPARK-21030][PYTHON][SQL] Adds more types f...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20788#discussion_r173612651 --- Diff: python/pyspark/sql/dataframe.py --- @@ -437,10 +437,11 @@ def hint(self, name, *parameters): if not isinstance(name, str

[GitHub] spark issue #20754: [SPARK-23287][CORE] Spark scheduler does not remove init...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20754 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #20759: Added description of checkpointInterval parameter

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20759#discussion_r173379554 --- Diff: docs/ml-collaborative-filtering.md --- @@ -19,6 +19,7 @@ by a small set of latent factors that can be used to predict missing entries

zeppelin git commit: [ZEPPELIN-3180] BUGFIX - save operation on interpreter add whitespace to permissions

Repository: zeppelin Updated Branches: refs/heads/branch-0.8 5f2a69a5f -> bea86c650 [ZEPPELIN-3180] BUGFIX - save operation on interpreter add whitespace to permissions ### What is this PR for? This PR fixes a bug when unnecessary spaces are added to the permissions. ### What type of PR is

zeppelin git commit: [ZEPPELIN-3180] BUGFIX - save operation on interpreter add whitespace to permissions

Repository: zeppelin Updated Branches: refs/heads/master 0267ecf76 -> 4fc048238 [ZEPPELIN-3180] BUGFIX - save operation on interpreter add whitespace to permissions ### What is this PR for? This PR fixes a bug when unnecessary spaces are added to the permissions. ### What type of PR is it?

[GitHub] spark issue #20754: [SPARK-23287][CORE] Spark scheduler does not remove init...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20754 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20464: [SPARK-23291][SQL][R] R's substr should not reduce start...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20464 merged to master, thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

spark git commit: [SPARK-23291][SQL][R] R's substr should not reduce starting position by 1 when calling Scala API

Repository: spark Updated Branches: refs/heads/master aff7d81cb -> 53561d27c [SPARK-23291][SQL][R] R's substr should not reduce starting position by 1 when calling Scala API ## What changes were proposed in this pull request? Seems R's substr API treats Scala substr API as zero based and so

[GitHub] spark issue #20754: [SPARK-23287][MESOS] Spark scheduler does not remove ini...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20754 @devaraj-kavali can you add test for this? cc @susanxhuynh --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #20678: [SPARK-23380][PYTHON] Adds a conf for Arrow fallb...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20678#discussion_r172751054 --- Diff: docs/sql-programming-guide.md --- @@ -1689,6 +1689,10 @@ using the call `toPandas()` and when creating a Spark DataFrame from a Pandas Da

[GitHub] spark pull request #20678: [SPARK-23380][PYTHON] Adds a conf for Arrow fallb...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20678#discussion_r172751164 --- Diff: docs/sql-programming-guide.md --- @@ -1800,6 +1800,7 @@ working with timestamps in `pandas_udf`s to get the best performance, see

[GitHub] spark pull request #20464: [SPARK-23291][SQL][R] R's substr should not reduc...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20464#discussion_r172750404 --- Diff: docs/sparkr.md --- @@ -663,3 +663,7 @@ You can inspect the search path in R with [`search()`](https://stat.ethz.ch/R-ma

[GitHub] spark issue #20464: [SPARK-23291][SQL][R] R's substr should not reduce start...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20464 appveyor tests failed, could you close and reopen this PR to trigger it. strange, I haven't seen anything like this on appveyor a long time. ``` 1. Error: create DataFrame

[GitHub] spark pull request #20742: [SPARK-23572][docs] Bring "security.md" up to dat...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20742#discussion_r172409490 --- Diff: R/pkg/DESCRIPTION --- @@ -57,6 +57,6 @@ Collate: 'types.R' 'utils.R' 'window.R' -RoxygenNote: 5.0.1

[2/3] spark git commit: [SPARK-22430][R][DOCS] Unknown tag warnings when building R docs with Roxygen 6.0.1

http://git-wip-us.apache.org/repos/asf/spark/blob/4586eada/R/pkg/R/generics.R -- diff --git a/R/pkg/R/generics.R b/R/pkg/R/generics.R index e0dde33..6fba4b6 100644 --- a/R/pkg/R/generics.R +++ b/R/pkg/R/generics.R @@ -19,7 +19,6

[GitHub] spark issue #20501: [SPARK-22430][R][Docs] Unknown tag warnings when buildin...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20501 merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[1/3] spark git commit: [SPARK-22430][R][DOCS] Unknown tag warnings when building R docs with Roxygen 6.0.1

Repository: spark Updated Branches: refs/heads/master 947b4e6f0 -> 4586eada4 http://git-wip-us.apache.org/repos/asf/spark/blob/4586eada/R/pkg/R/mllib_tree.R -- diff --git a/R/pkg/R/mllib_tree.R b/R/pkg/R/mllib_tree.R index

[3/3] spark git commit: [SPARK-22430][R][DOCS] Unknown tag warnings when building R docs with Roxygen 6.0.1

[SPARK-22430][R][DOCS] Unknown tag warnings when building R docs with Roxygen 6.0.1 ## What changes were proposed in this pull request? Removed export tag to get rid of unknown tag warnings ## How was this patch tested? Existing tests Author: Rekha Joshi Author: rjoshi2

spark-website git commit: update committer

Repository: spark-website Updated Branches: refs/heads/asf-site 32ff6fa97 -> 8bd24fb6d update committer Author: Felix Cheung <felixcheun...@hotmail.com> Closes #103 from felixcheung/fc. Project: http://git-wip-us.apache.org/repos/asf/spark-website/repo Commit: http://git-wip-us.a

[GitHub] spark issue #20737: [SPARK-23601][BUILD] Remove .md5 files from release

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20737 The last part with publishing to staging repo (“publish-release”) might not work? When I did I added a new file .sha512 and it failed the publish, so I wonder if it is specifically

[GitHub] zeppelin issue #2749: [ZEPPELIN-3180] BUGFIX - save operation on interpreter...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2749 merging if no more comment ---

[GitHub] spark issue #20501: [SPARK-22430][Docs] Unknown tag warnings when building R...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20501 ping @rekhajoshm ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #20464: [SPARK-23291][SQL][R] R's substr should not reduc...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20464#discussion_r172033021 --- Diff: R/pkg/R/column.R --- @@ -169,7 +169,7 @@ setMethod("alias", #' @note substr since 1.4.0 setMethod("substr", s

[GitHub] spark pull request #20464: [SPARK-23291][SQL][R] R's substr should not reduc...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20464#discussion_r172033037 --- Diff: docs/sparkr.md --- @@ -663,3 +663,7 @@ You can inspect the search path in R with [`search()`](https://stat.ethz.ch/R-ma

[GitHub] spark pull request #20681: [SPARK-23518][SQL] Avoid metastore access when th...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20681#discussion_r171910649 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -67,6 +67,8 @@ sparkSession <- if (windows_with_hadoop()) { sparkR.session(mas

spark git commit: [SPARKR][DOC] fix link in vignettes

0711 from felixcheung/rvigmean. (cherry picked from commit 0b6ceadeb563205cbd6bd03bc88e608086273b5b) Signed-off-by: Felix Cheung <felixche...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/8fe20e15 Tree:

spark git commit: [SPARKR][DOC] fix link in vignettes

0711 from felixcheung/rvigmean. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/0b6ceade Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/0b6ceade Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/0b6ceade Branch: refs/hea

[GitHub] spark pull request #20711: [SPARKR][DOC] fix link in vignettes

GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/20711 [SPARKR][DOC] fix link in vignettes ## What changes were proposed in this pull request? Fix doc link that was changed in 2.3 @shivaram You can merge this pull request

[GitHub] spark pull request #20681: [SPARK-23518][SQL] Avoid metastore access when th...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20681#discussion_r171750940 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -67,6 +67,8 @@ sparkSession <- if (windows_with_hadoop()) { sparkR.session(mas

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20681 looks like test failures are related? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20295: [SPARK-23011] Support alternative function form w...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20295#discussion_r171466325 --- Diff: python/pyspark/sql/types.py --- @@ -1725,6 +1737,29 @@ def _get_local_timezone(): return os.environ.get('TZ', 'dateutil

[GitHub] spark pull request #20295: [SPARK-23011] Support alternative function form w...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20295#discussion_r171465908 --- Diff: python/pyspark/sql/functions.py --- @@ -2253,6 +2253,30 @@ def pandas_udf(f=None, returnType=None, functionType=None): | 2

[GitHub] spark issue #20695: [SPARK-21741][ML][PySpark] Python API for DataFrame-base...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20695 2.4.0? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20501: [SPARK-22430][Docs] Unknown tag warnings when building R...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20501 can you reopen this PR and add [R] in the title? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #20618: [SPARK-23329][SQL] Fix documentation of trigonome...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20618#discussion_r171167374 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala --- @@ -512,7 +529,11 @@ case class Rint(child

[GitHub] spark issue #20682: [SPARK-23522][Python] always use sys.exit over builtin e...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20682 @HyukjinKwon @ueshin @holdenk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #20665: [SPARK-23499][MESOS] Support for priority queues in Meso...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20665 @susanxhuynh --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20681: [SPARK-23518][SQL] Avoid metastore access when th...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20681#discussion_r170862425 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -885,24 +894,24 @@ test_that("collect() and take() on a DataFrame return the same number of

[GitHub] zeppelin issue #2817: [ZEPPELIN-3264] Notebook Snapshot feature.

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2817 hmm, interesting. how is this different or work with notebook revision on storage like git? ---

[GitHub] zeppelin issue #2749: [ZEPPELIN-3180] BUGFIX - save operation on interpreter...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2749 doesn't seem like the test failure is related https://api.travis-ci.org/v3/job/339570673/log.txt @Savalek could you rebase this PR? ---

[GitHub] spark issue #20618: [SPARK-23329][SQL] Fix documentation of trigonometric fu...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20618 @misutoth what exactly is the problem you are running into? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #20681: [SPARK-23518][SQL] Avoid metastore access when the users...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20681 thx, let's wait for tests --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

<    5   6   7   8   9   10   11   12   13   14   >