Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22746
Thanks! Merged to master/2.4. For 2.4 branch, I manually removed the
migration guide from 2.4 to 3.0.
---
-
To unsubscribe
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22746
We might miss something in the code review. Let us play the new doc and see
whether we miss anything in the code review
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22746
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226424308
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +42,29 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226382186
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -39,29 +42,29 @@ import
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22761
I would merge https://github.com/apache/spark/pull/22746 to 2.4 release,
since the doc changes are not restricted by our RC. Maybe we can hold this PR
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20433
@maropu Thanks! This is great to make our Spark SQL parser fully compatible
with ANSI SQL. Please continue the efforts!
cc @cloud-fan
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r225784123
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -335,6 +335,12 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r225783980
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -335,6 +335,12 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22219
cc @srinathshankar @yuchenhuo
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22746#discussion_r225780740
--- Diff: docs/sql-getting-started.md ---
@@ -0,0 +1,369 @@
+---
+layout: global
+title: Getting Started
+displayTitle: Getting Started
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225655290
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -81,11 +81,11 @@ case class UserDefinedFunction
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225651483
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala
---
@@ -179,7 +179,8 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r225654592
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -81,11 +81,11 @@ case class UserDefinedFunction
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/22719
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/22718
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22706
LGTM
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22731#discussion_r225333576
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala
---
@@ -106,15 +106,16 @@ class FileScanRDD
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22728#discussion_r225299298
--- Diff: sql/core/src/test/resources/sql-tests/inputs/count.sql ---
@@ -0,0 +1,21 @@
+-- Test data.
+CREATE OR REPLACE TEMPORARY VIEW testData
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22728#discussion_r225298840
--- Diff: sql/core/src/test/resources/sql-tests/inputs/count.sql ---
@@ -0,0 +1,21 @@
+-- Test data.
+CREATE OR REPLACE TEMPORARY VIEW testData
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22718
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22719
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22560
Sorry for the late reply. Could we hold this PR since we are actively
working on the data source API V2? Will revisit it after that. Also cc
@gengliangwang @cloud-fan
FYI, I just
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22731
cc @10110346 @srowen @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22731
[SPARK-25674][FOLLOW-UP] Update the stats for each ColumnarBatch
## What changes were proposed in this pull request?
This PR is a follow-up of https://github.com/apache/spark/pull/22594
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22719
[SPARK-25714] [BACKPORT-2.2] Fix Null Handling in the Optimizer rule
BooleanSimplification
This PR is to backport https://github.com/apache/spark/pull/22702 to branch
2.2
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22718
[SPARK-25714] [BACKPORT-2.3] Fix Null Handling in the Optimizer rule
BooleanSimplification
This PR is to backport https://github.com/apache/spark/pull/22702 to branch
2.3
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22717
[SPARK-25372][YARN][K8S][FOLLOW-UP] Deprecate and generalize keytab /
principal config
## What changes were proposed in this pull request?
Update the next version of Spark from 2.5 to 3.0
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21993
Backlisting case-when statements looks good to me.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22711
LGTM
Thanks! Merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22713
I do not want to take any risk unless you can have a test case to show the
benefit of each change.
---
-
To unsubscribe, e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22715
@mgaido91 Anything is missing in LogicalRDD?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20560#discussion_r224969136
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -64,7 +64,8 @@ case class InMemoryRelation
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22715
[SPARK-23375][FOLLOW-UP] Add outputOrdering to otherCopyArgs
## What changes were proposed in this pull request?
Add `outputOrdering ` to `otherCopyArgs` so that this field will be copied
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22706
cc @maryannxue
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22706
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22706#discussion_r224966692
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -152,10 +152,10 @@ abstract class UnaryNode
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22713
Could we just hold this PR until we can ensure the expression ID are unique
in the whole tree?
---
-
To unsubscribe, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22711#discussion_r224951558
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -276,31 +276,37 @@ object BooleanSimplification
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22702#discussion_r224950875
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -276,15 +276,31 @@ object BooleanSimplification
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22702
Thanks! Merged to master/2.4/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22597
Yes. Please add a test case.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22654
LGTM
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22696
LGTM
Thanks! Merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22701
LGTM
Thanks! Merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21364
cc @srinathshankar @yuchenhuo
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22702
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r224631648
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -3854,6 +3854,38 @@ object functions {
@scala.annotation.varargs
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r224631037
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVUtils.scala
---
@@ -40,16 +40,6 @@ object CSVUtils
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r224629618
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVUtils.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r224630712
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExprUtils.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r224629829
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExprUtils.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r224629713
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVUtils.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22654#discussion_r224626882
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -1826,4 +1826,13 @@ class CSVSuite extends
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22702
[SPARK-25714] Fix Null Handling in the Optimizer rule BooleanSimplification
## What changes were proposed in this pull request?
```Scala
val df1 = Seq(("abc", 1), (null
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22259#discussion_r224597357
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -47,7 +48,8 @@ case class ScalaUDF
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22701#discussion_r224596662
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2151,7 +2151,7 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22696#discussion_r224590852
--- Diff: docs/sql-programming-guide.md ---
@@ -1894,6 +1894,8 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22696
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22696#discussion_r224588988
--- Diff: docs/sql-programming-guide.md ---
@@ -1894,6 +1894,8 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22614
Based on my understanding, the solution of FB team is to retry the
following commands multiple times:
```
getPartitionsByFilterMethod.invoke(hive, table,
filter).asInstanceOf[JArrayList
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22679
cc @dbtsai @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22679
[SPARK-25559] [FOLLOW-UP] Add comments for partial pushdown of conjuncts in
Parquet
## What changes were proposed in this pull request?
This is a follow up of https://github.com/apache
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22671
cc @zsxwing @tdas @jose-torres
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22654#discussion_r223581611
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVUtils.scala
---
@@ -97,23 +97,21 @@ object CSVUtils
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22654#discussion_r223579444
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVUtils.scala
---
@@ -97,23 +97,21 @@ object CSVUtils
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22466
The major comments are in the test cases. Could you help clean up the
existing test cases?
---
-
To unsubscribe, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r223570144
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -207,6 +207,16 @@ class SessionCatalog
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r223569270
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -407,6 +407,7 @@ abstract class DDLSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r223569182
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -53,6 +53,7 @@ class HiveCatalogedDDLSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r223568531
--- Diff: python/pyspark/sql/tests.py ---
@@ -351,7 +351,7 @@ def tearDown(self):
super(SQLTests, self).tearDown()
# tear
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22635
How about pandas UDF? How about using RDD APIs? Do we face the same issues?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22614
Also, https://github.com/apache/spark/pull/22614#discussion_r223172392
proposes a better and safer solution by introducing `exponential backoff with
retries`. @kmanamcheri Could you update your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22614
As @tejasapatil suggested above, this fallback is not suggested to be on in
a prod setting. It could also impact the system health (e.g., the other
concurrent queries that are querying the same
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22643
LGTM
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21102#discussion_r223460909
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3965,6 +4034,248 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22545#discussion_r223415446
--- Diff: python/pyspark/sql/session.py ---
@@ -156,7 +156,7 @@ def getOrCreate(self):
default.
>&g
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22545#discussion_r223397858
--- Diff: python/pyspark/sql/session.py ---
@@ -156,7 +156,7 @@ def getOrCreate(self):
default.
>&g
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22658
Thanks! Merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22658
Locale.ROOT has been fixed as a hot-fix.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22658
Also cc @yhuai @liancheng @srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22658
cc @zsxwing @cloud-fan @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22658
```
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/external/spark-ganglia-lgpl/src/main/scala/org/apache/spark/metrics/sink/GangliaSink.scala:72:
value xyz is not a member of object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22647#discussion_r223188166
--- Diff:
external/spark-ganglia-lgpl/src/main/scala/org/apache/spark/metrics/sink/GangliaSink.scala
---
@@ -64,11 +64,12 @@ class GangliaSink(val
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22658
[WIP] Build external/spark-ganglia-lgpl in Jenkins Test
## What changes were proposed in this pull request?
Currently, we do not build external/spark-ganglia-lgpl in Jenkins tests
when
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22636
The time reduction is not obvious. Let us keep this unchanged?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22047#discussion_r223164281
--- Diff: python/pyspark/sql/functions.py ---
@@ -403,6 +403,28 @@ def countDistinct(col, *cols):
return Column(jc)
+def every
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20832
@efimpoberezkin Could you please close this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20832#discussion_r223164144
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -1208,85 +1208,172 @@ class ColumnName(name: String) extends
Column(name
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22642
LGTM
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22642#discussion_r223163190
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -33,11 +33,13 @@ import
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22622
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22648
[MINOR] Clean up the joinCriteria in SQL parser
## What changes were proposed in this pull request?
Clean up the joinCriteria parsing in the parser by directly using
identifierList
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22642#discussion_r223148975
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -33,11 +33,13 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22643#discussion_r223146731
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala
---
@@ -760,23 +775,27 @@ abstract class HadoopFsRelationTest
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22532
Thanks for submitting the PR! I quickly scan the code changes. It sounds
like the general direction is right but the quality is not ready.
I would suggest to write the test plan before
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22614#discussion_r223139984
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -544,6 +544,15 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22614#discussion_r223137994
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala
---
@@ -87,6 +90,18 @@ class HiveClientSuite(version: String
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22614#discussion_r223134564
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -544,6 +544,15 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22647
cc @zsxwing @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
201 - 300 of 14035 matches
Mail list logo
