GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22647
[SPARK-25655] [BUILD] Add Pspark-ganglia-lgpl to the scala style check.
## What changes were proposed in this pull request?
Our lint failed due to the following errors:
```
[INFO
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22622#discussion_r222911645
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -115,6 +116,69 @@ abstract class OrcSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22622#discussion_r222911529
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -115,6 +116,69 @@ abstract class OrcSuite
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22399
It sounds like the build is broken after merging this PR
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22399
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-compile-maven-hadoop-2.6/8432
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22399
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-compile-maven-hadoop-2.7/8521
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22605#discussion_r222877184
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/BloomFilterBenchmark.scala
---
@@ -0,0 +1,87 @@
+/*
+ * Licensed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22622#discussion_r222876905
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -115,6 +116,69 @@ abstract class OrcSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22594#discussion_r222875551
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala
---
@@ -104,12 +104,14 @@ class FileScanRDD
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r222874417
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CsvExpressionsSuite.scala
---
@@ -0,0 +1,145
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22622#discussion_r222855990
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -115,6 +116,69 @@ abstract class OrcSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r222855301
--- Diff: python/pyspark/sql/tests.py ---
@@ -351,7 +351,7 @@ def tearDown(self):
super(SQLTests, self).tearDown()
# tear
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r222855237
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -407,6 +407,7 @@ abstract class DDLSuite extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22466
@sandeep-katta Can you update the PR title?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r222777373
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r222776820
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r222773963
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r222774540
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r222774199
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r222772770
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CsvExpressionsSuite.scala
---
@@ -0,0 +1,145
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r222771917
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22621
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21688
cc @dbkerkela @gengliangwang
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22620#discussion_r222487117
--- Diff: python/pyspark/sql/udf.py ---
@@ -310,9 +319,11 @@ def register(self, name, f, returnType=None):
"Invalid retur
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22480#discussion_r222486276
--- Diff: python/pyspark/sql/tests.py ---
@@ -1962,6 +1962,9 @@ def __getstate__(self):
def __setstate__(self, state
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22620#discussion_r222452544
--- Diff: python/pyspark/sql/udf.py ---
@@ -310,9 +319,11 @@ def register(self, name, f, returnType=None):
"Invalid retur
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22614
Yes. Let us add a conf for controlling the fallback. Please also add the
test cases for verifying it. Thanks
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22614
Let us add a conf to control it? Failing fast is better than hanging. If
users want to get all partitions, they can change the conf by themselves
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22619
Any behavior change? Test cases?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22614#discussion_r222190138
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -746,34 +746,20 @@ private[client] class Shim_v0_13 extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22047
Let me post something I wrote recently. Could you add test cases to ensure
that we do not break the "Ignore NULLs" policy
> All the set/aggregate functions ignore NULLs
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22614#discussion_r222134301
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -746,34 +746,20 @@ private[client] class Shim_v0_13 extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22614#discussion_r222122774
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -746,34 +746,20 @@ private[client] class Shim_v0_13 extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22614#discussion_r222122400
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -746,34 +746,20 @@ private[client] class Shim_v0_13 extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22606
Yes. Let us wait for the release of 2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22606
@dongjoon-hyun Could you help me fix the website?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22606
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22606
cc @yhuai @rxin @cloud-fan @srowen @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22606
[SPARK-25592] Setting version to 3.0.0-SNAPSHOT
## What changes were proposed in this pull request?
This patch is to bump the master branch version to 3.0.0-SNAPSHOT.
## How
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22602
@mgaido91 Could you change the title to [WIP] before you add the test case?
Also cc @hvanhovell @kiszk who are the best person to review these code
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22461
Thanks! Merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22573
Updating `Filter` APIs sounds reasonable to me. This should be part of our
data source API v2. cc @cloud-fan @rxin @rdblue
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21221
@mccheah When you merged the code, could you also leave the comments about
which branches you did the merge
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21221
For the other reviewers, this was merged to master (not 2.4)
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r221449056
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -520,7 +520,10 @@ object FunctionRegistry
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22586
Thanks! Merged to master/2.4/2.3/2.2
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22528
We should stop returning a wrong result. Please fix it. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22586
This was introduced by AccumulatorV2. It might be a blocker issue for Spark
2.4, since this could return an incorrect result
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22586
LGTM
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22586#discussion_r221415820
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -1880,6 +1880,26 @@ class DAGSchedulerSuite extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22566
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22420
@wangyum Could you take it over and submit a new PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22060
@maropu Are you willing to take this over?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22519
Thanks! Merged to 2.4 and master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22566
LGTM except a few minor comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r221158906
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -653,6 +653,49 @@ class StatisticsSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r221158556
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -48,9 +52,13 @@ case class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22566
@dilipbiswal Thanks for working on this! Also cc @juliuszsompolski
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r220979068
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -33,11 +33,13 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r220978815
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -50,7 +52,26 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r220978327
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -70,25 +91,9 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r220978087
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -50,7 +52,26 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r220977575
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -50,7 +52,26 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22419#discussion_r220973430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -1245,3 +1245,27 @@ case class BRound
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22560
Could you please post the example you deleted in the PR description? If we
merge it, it can be part of our commit message. We can easily understand the
context of this PR.
Let me think
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22361
Nico will give a talk in the upcoming spark summit:
https://databricks.com/session/a-framework-for-evaluating-the-performance-and-the-correctness-of-the-spark-sql-engine
If possible
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r220795973
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -66,6 +66,19 @@ case class CreateDatabaseCommand
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r220795446
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -66,6 +66,19 @@ case class CreateDatabaseCommand
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r220795176
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -66,6 +66,19 @@ case class CreateDatabaseCommand
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22198
cc @maryannxue
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22528
Generally, this is useful for reading the zip archives containing a single
CSV. The extra support JSON file is not very useful.
The major limitation is we have to read the zipped CSV
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22545
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22540#discussion_r220363870
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowUtils.scala
---
@@ -131,11 +131,8 @@ object ArrowUtils {
} else
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21816
cc @srinathshankar @ericl
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22540#discussion_r220065589
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowUtils.scala
---
@@ -131,11 +131,8 @@ object ArrowUtils {
} else
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22540#discussion_r220065308
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1295,15 +1295,15 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22455
Great feature! cc @falaki
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22540#discussion_r219973059
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowUtils.scala
---
@@ -131,11 +131,8 @@ object ArrowUtils {
} else
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22540#discussion_r219972870
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1915,8 +1915,8 @@ class SQLConf extends Serializable
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22540
[SPARK-24324] [PYTHON] [FOLLOW-UP] Add legacy prefix in
spark.sql.execution.pandas.groupedMap.assignColumnsByPosition
## What changes were proposed in this pull request?
Add the legacy
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22366#discussion_r219943808
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -517,12 +517,10 @@ case class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22511
Also cc @zsxwing @JoshRosen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r219729921
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -250,5 +265,22 @@ class QueryExecution(val sparkSession
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r219729889
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -250,5 +265,22 @@ class QueryExecution(val sparkSession
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r219729210
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -668,11 +670,19 @@ case class WholeStageCodegenExec
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22458#discussion_r219727730
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -2348,4 +2348,17 @@ class HiveDDLSuite
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21999
Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22523
cc @ueshin @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22523
[MINOR] Always Close the tempFile in _serialize_to_jvm
## What changes were proposed in this pull request?
Always close the tempFile after `serializer.dump_stream(data, tempFile
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22461#discussion_r219546151
--- Diff: docs/sql-programming-guide.md ---
@@ -1489,7 +1489,7 @@ See the [Apache Avro Data Source
Guide](avro-data-source-guide.html
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22461#discussion_r219542061
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -462,6 +464,9 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22461#discussion_r219392779
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -462,6 +464,9 @@ class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22506
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22461#discussion_r219359831
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -442,6 +442,8 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22461#discussion_r219359638
--- Diff:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
@@ -442,6 +442,8 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22467#discussion_r219356330
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveParquetSourceSuite.scala
---
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22505
cc @rxin @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22505
Revert "[SPARK-23715][SQL] the input of to/from_utc_timestamp can not have
timezone
## What changes were proposed in this pull request?
This reverts c
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22458
This is reasonable to me. cc @jiangxb1987 @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22458
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
301 - 400 of 14035 matches
Mail list logo
