Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21005
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20043
I am going to merge this after this successfully passes tests
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20043
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21005
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21005
@maropu it seems a bit of overkill to add a separate trait for this, it
also kinda nullifies the effect of this PR.
As for the `CalendarInterval`'s support for `divide` and `multiply
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180008583
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -119,4 +119,25 @@ object InternalRow {
case v
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180008527
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -33,28 +33,14 @@ case class BoundReference
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/21005
[SPARK-23898][SQL] Simplify add & subtract code generation
## What changes were proposed in this pull request?
Code generation for the `Add` and `Subtract` expressions was not done u
Repository: spark
Updated Branches:
refs/heads/master 710a68cec -> 8d40a79a0
[SPARK-23893][CORE][SQL] Avoid possible integer overflow in multiplication
## What changes were proposed in this pull request?
This PR avoids possible overflow at an operation `long = (long)(int * int)`.
The
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21002
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Repository: spark
Updated Branches:
refs/heads/master 6a734575a -> 710a68cec
[SPARK-23892][TEST] Improve converge and fix lint error in UTF8String-related
tests
## What changes were proposed in this pull request?
This PR improves test coverage in `UTF8StringSuite` and code efficiency in
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21000
LGTM - merging to master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20986#discussion_r179867664
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java
---
@@ -103,42 +106,27 @@ protected final void
Repository: spark
Updated Branches:
refs/heads/master d766ea2ff -> c926acf71
[SPARK-23882][CORE] UTF8StringSuite.writeToOutputStreamUnderflow() is not
expected to be supported
## What changes were proposed in this pull request?
This PR excludes an existing UT
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20995
LGTM - merging to master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20978
Yeah, I got distracted. Thanks for merging.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20978
Merging to master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20978
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20978
it makes very little sense that this keeps failing
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20986
@kiszk @cloud-fan I made all code generation in `GenerateUnsafeProjection`
follow the code template standard of using pipes as a margin and `stripmargin`
at the end. The only downside
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20995
@kiszk let's just remove the test. It should have never been added in the
first place.
---
-
To unsubscribe, e-mail: reviews
Repository: spark
Updated Branches:
refs/heads/master b2329fb1f -> d9ca1c906
[SPARK-23593][SQL] Add interpreted execution for InitializeJavaBean expression
## What changes were proposed in this pull request?
Add interpreted execution for `InitializeJavaBean` expression.
## How was this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20985
Merging to master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20986
cc @kiszk @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/20986
[SPARL-23864][SQL] Add unsafe object writing to UnsafeWriter
## What changes were proposed in this pull request?
This PR moves writing of `UnsafeRow`, `UnsafeArrayData` & `UnsafeMap
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20978#discussion_r179467893
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala ---
@@ -33,6 +33,10 @@ import org.apache.spark.sql.catalyst.expressions
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20756
Yes that would effectively be the same.
Do you think we should always call setters for reference types
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20778#discussion_r179464207
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -392,8 +392,44 @@ case class NewInstance
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20756
I think the semantic should be that we do not invoke the setter if the
input is null.
---
-
To unsubscribe, e-mail: reviews
Repository: spark
Updated Branches:
refs/heads/master 1822ecda5 -> b2329fb1f
Revert "[SPARK-23593][SQL] Add interpreted execution for InitializeJavaBean
expression"
This reverts commit c5c8b544047a83cb6128a20d31f1d943a15f9260.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20756
@viirya I thought it passed tests, but your last change is causing errors.
I am going to revert this for now. Can you reopen? Sorry about
port org.apache.spark.sql.types._
+import org.apache.spark.unsafe.types.UTF8String
class InvokeTargetClass extends Serializable {
def filterInt(e: Any): Any = e.asInstanceOf[Int] > 0
@@ -93,6 +97,66 @@ class ObjectExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
Repository: spark
Updated Branches:
refs/heads/master d3bd0435e -> c5c8b5440
[SPARK-23593][SQL] Add interpreted execution for InitializeJavaBean expression
## What changes were proposed in this pull request?
Add interpreted execution for `InitializeJavaBean` expression.
## How was this
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20979#discussion_r179430079
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -988,8 +988,20 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r179420439
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -277,4 +278,31 @@ class
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20981
A few minor comments. Looks good otherwise.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r179418102
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -550,11 +550,33 @@ case class
l.SQLConf
import org.apache.spark.sql.types._
+class InvokeTargetClass extends Serializable {
+ def filterInt(e: Any): Any = e.asInstanceOf[Int] > 0
+ def filterPrimitiveInt(e: Int): Boolean = e > 0
+ def binOp(e1: Int, e2: Double): Double = e1 + e2
+}
+
+class InvokeTargetSubClass extends Invoke
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20797
LGTM - merging to master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20961
Can you add a test? Just show that origin is still the same after you
transform the node.
---
-
To unsubscribe, e-mail
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20756#discussion_r179132793
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1261,8 +1261,42 @@ case class
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20966
@Fokko you are kind of making my point here. Those dependencies rely on
unshaded guava, if we upgrade our dependency then we might have to update those
dependencies as well, which is probably
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20771
@viirya to be clear: let's do this into two separate JIRA's/PRs.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20797
LGTM @kiszk can you update your branch so we can merge?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20771
@viirya can you also file a ticket for the `UnsafeArrayData.array` issue?
We should just provide an `IndexedSeq` for `ArrayData
Repository: spark
Updated Branches:
refs/heads/master 66a3a5a2d -> 1035aaa61
[SPARK-23587][SQL] Add interpreted execution for MapObjects expression
## What changes were proposed in this pull request?
Add interpreted execution for `MapObjects` expression.
## How was this patch tested?
Added
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20797#discussion_r178756215
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -263,11 +295,21 @@ case class Invoke
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20966
@Fokko upgrading guava has been notoriously hard to do, it is used in a lot
Spark's dependencies and the guava developers aggressively remove deprecated
APIs; updating can easily break stuff
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20797#discussion_r178670249
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -263,11 +295,21 @@ case class Invoke
Repository: spark
Updated Branches:
refs/heads/master fe2b7a456 -> a7c19d9c2
[SPARK-23713][SQL] Cleanup UnsafeWriter and BufferHolder classes
## What changes were proposed in this pull request?
This PR implemented the following cleanups related to `UnsafeWriter` class:
- Remove code
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20850
Merging to master. Thanks for your hard work and patience.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20850
@kiszk can you rerun the `UnsafeProjectionBenchmark` to make sure we didn't
regress anywhere?
Otherwise LGTM
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r178469520
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/GenerateColumnAccessor.scala
---
@@ -212,11 +210,11 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r178469079
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -32,141 +30,123
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20932
@wangtao605 AFAIK we donât support dfs.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r178025700
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -32,141 +30,133
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r178025468
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java
---
@@ -17,17 +17,86 @@
package
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r177680097
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java
---
@@ -17,17 +17,91 @@
package
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20913
@mshtelma can you add a unit test?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20913
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20912
wow that only took 8 hours
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20914
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20914
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r177480722
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -188,8 +189,30 @@ case class StaticInvoke
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20912
The workflow is that we merge to apache git, and that the commit get pushed
to github via some synchronization. Apparently the latter is broken
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20912
Hmmm - I did merge this:
https://git-wip-us.apache.org/repos/asf?p=spark.git;a=commit;h=35997b59f3116830af06b3d40a7675ef0dbf7091
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20797#discussion_r177420831
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -266,8 +266,31 @@ case class Invoke
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20797#discussion_r177419935
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -266,8 +266,31 @@ case class Invoke
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r177413074
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -188,8 +189,30 @@ case class StaticInvoke
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20753#discussion_r177411749
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -188,8 +189,30 @@ case class StaticInvoke
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20756#discussion_r177411427
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1261,8 +1261,42 @@ case class
Repository: spark
Updated Branches:
refs/heads/master 3e778f5a9 -> 35997b59f
[SPARK-23794][SQL] Make UUID as stateful expression
## What changes were proposed in this pull request?
The UUID() expression is stateful and should implement the `Stateful` trait
instead of the `Nondeterministic`
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20912
Merging to master. Thanks for the quick turnaround!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Repository: spark
Updated Branches:
refs/heads/branch-2.3 328dea6f8 -> 1c39dfaef
[SPARK-23599][SQL][BACKPORT-2.3] Use RandomUUIDGenerator in Uuid expression
## What changes were proposed in this pull request?
As stated in Jira, there are problems with current `Uuid` expression which uses
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20903
Merging to 2.3. Thanks! Can you close?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20771#discussion_r177022135
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -599,8 +610,86 @@ case class MapObjects
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20771#discussion_r177021865
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -599,8 +610,86 @@ case class MapObjects
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20771#discussion_r177021309
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -599,8 +610,86 @@ case class MapObjects
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20771#discussion_r177020985
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -599,8 +610,86 @@ case class MapObjects
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20771#discussion_r177016698
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -599,8 +610,86 @@ case class MapObjects
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20771#discussion_r177015279
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -599,8 +610,86 @@ case class MapObjects
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20756#discussion_r176956857
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -68,6 +68,23 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20756#discussion_r176956802
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1261,8 +1261,42 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20756#discussion_r176956651
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1261,8 +1261,39 @@ case class
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20835
I have cherry-picked this into branch-2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Repository: spark
Updated Branches:
refs/heads/branch-2.3 57026a185 -> 2fd7acabf
[HOT-FIX] Fix SparkOutOfMemoryError: Unable to acquire 262144 bytes of memory,
got 224631
## What changes were proposed in this pull request?
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20861
@viirya I have backported #20817 to 2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Repository: spark
Updated Branches:
refs/heads/branch-2.3 523fcafc5 -> 57026a185
[SPARK-23599][SQL] Add a UUID generator from Pseudo-Random Numbers
## What changes were proposed in this pull request?
This patch adds a UUID generator from Pseudo-Random Numbers. We can use it
later to have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20861
@viirya can you create a backport for 2.3?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Repository: spark
Updated Branches:
refs/heads/master 5c9eaa6b5 -> 4d37008c7
[SPARK-23599][SQL] Use RandomUUIDGenerator in Uuid expression
## What changes were proposed in this pull request?
As stated in Jira, there are problems with current `Uuid` expression which uses
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20861#discussion_r175727781
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolvedUuidExpressionsSuite.scala
---
@@ -0,0 +1,79
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20861#discussion_r175727739
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolvedUuidExpressionsSuite.scala
---
@@ -0,0 +1,79
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20861#discussion_r175725276
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -98,6 +99,8 @@ class Analyzer(
this(catalog
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175608496
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -86,11 +88,39 @@ public void grow(int
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175407382
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java
---
@@ -36,8 +90,92 @@
public abstract
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175407178
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeRowWriter.java
---
@@ -40,29 +37,45
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175393443
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -31,24 +31,24 @@
* for each
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175393169
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -47,126 +40,119 @@ private void
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175392909
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -86,11 +86,17 @@ public void grow(int
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20850
@kiszk this is a good start! This is very performance critical code, can
you please extend/update/run the existing `UnsafeProjectionBenchmark
701 - 800 of 5056 matches
Mail list logo
