Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22337#discussion_r215881992
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/WideSchemaBenchmark.scala
---
@@ -54,8 +54,11 @@ class WideSchemaBenchmark
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22337#discussion_r215874969
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ExchangeCoordinatorSuite.scala
---
@@ -31,6 +31,7 @@ class ExchangeCoordinatorSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22348#discussion_r215860694
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -154,8 +159,6 @@ public void
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22347
Thank you for your update.
Is it better to add test case to confirm the state of the internal
structures is as you expected? @maropu
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22345
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22337
cc @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22347
It is fine with me for separation since this is not only for ThriftServer.
It does not seem to be just refactoring. Could you please update the title
of PR appropriately
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22337
Sure, I just focused on files under `external`. Let me address other files,
too.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22335#discussion_r215452975
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -646,8 +646,17 @@ private[spark] class AppStatusListener
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22167
I like to add description for metrics.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22167#discussion_r215315965
--- Diff: docs/monitoring.md ---
@@ -388,6 +388,163 @@ value triggering garbage collection on jobs, and
`spark.ui.retainedStages` that
Note
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22167#discussion_r215315657
--- Diff: docs/monitoring.md ---
@@ -388,6 +388,163 @@ value triggering garbage collection on jobs, and
`spark.ui.retainedStages` that
Note
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22167#discussion_r215315711
--- Diff: docs/monitoring.md ---
@@ -388,6 +388,163 @@ value triggering garbage collection on jobs, and
`spark.ui.retainedStages` that
Note
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22167#discussion_r215314710
--- Diff: docs/monitoring.md ---
@@ -388,6 +388,163 @@ value triggering garbage collection on jobs, and
`spark.ui.retainedStages` that
Note
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22167#discussion_r215314527
--- Diff: docs/monitoring.md ---
@@ -388,6 +388,163 @@ value triggering garbage collection on jobs, and
`spark.ui.retainedStages` that
Note
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22322
Thank you for adding a description for the conf. Would it be possible to
add missing descriptions for other confs in `spark.network.crypto
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22318
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22338
While I say these performance differences, I do not understand why these
difference occurs completely. That is why I said "I have not found the root
cause".
Let us narrow down t
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22338
In addition to [your
commit](https://github.com/apache/spark/pull/22338/commits/91adce590461dda885d88319a700a775e63f9ce6),
I applied the following change, basically use `MemoryBlock
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22338
@mgaido91 thanks, interestingly I did experiments with similar code in my
box.
While I am using the linux box, I can confirm the performance improvement
(or performance recover
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22336
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22337
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22335#discussion_r215149786
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -646,8 +646,17 @@ private[spark] class AppStatusListener
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22335#discussion_r215147974
--- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala ---
@@ -33,7 +29,9 @@ import org.apache.spark.storage.RDDInfo
import
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/22337
[SPARK-25338][Test][kafka][kinesis][flume] Ensure to call super.afterAll()
in afterAll method in test cases
## What changes were proposed in this pull request?
This PR ensures to call
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22336
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22306
cc @gatorsmile @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22306
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22321
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22321
Good catch. IIUC, the following files also have the similar problem
regarding
`http://spark.apache.org/docs/latest/building-spark.html#building-with-buildmvn`.
Would it be possible to address them
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22317#discussion_r214559736
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1623,12 +1623,13 @@ case class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22306
Good changes. Why don't we apply this changes to test cases?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22317
cc @mgaido91@ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/22317
ArraysOverlap may throw a CompilationException
## What changes were proposed in this pull request?
ArraysOverlap may throw a CompilationException
This PR fixes a problem
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21912
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22315
Thank you
LGTM except one comment.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22315#discussion_r214542052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1464,17 +1464,27 @@ case class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22313
General question: Why do we use `time` instead of `entry size` to control
cache? I am neutral on this decision. I would like to hear the reason of this
decision
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22314
Good catch, LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22219
@Dooyoung-Hwang Would it possible to add a test case to verify result with
and without incrementalCollects by changing a value of
`spark.sql.thriftServer.batchDeserializeLimit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/1
@pgandhi999 thank you for your comments.
LGTM, then let me ask @zsxwing and @JoshRosen for their comments
---
-
To unsubscribe
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22218#discussion_r214505265
--- Diff:
core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala ---
@@ -73,6 +75,29 @@ class ExecutorSource(threadPool: ThreadPoolExecutor
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22048
LGTM, then let me ask @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r214392521
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -463,23 +463,35 @@ public static UnsafeArrayData
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
I see. Let me remove the change regarding `asNullable` from this PR. I will
create another PR after this PR is merged
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
We need to detect the correctly written test with a wrong result. Let us
think about the following `map_zip_with` without #22126.
In the following example, `map_zip_with` without #22126
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22300
SGTM. can we use this utility function in `StreamSuite`, too?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
I believe we still need this change.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22048
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22240#discussion_r214229966
--- Diff: core/src/main/scala/org/apache/spark/BarrierTaskContext.scala ---
@@ -145,20 +143,77 @@ class BarrierTaskContext
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22292
For future, let us keep a connection with #22233 that is the original one
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r214145047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -385,107 +385,124 @@ case class MapEntries
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r213977445
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala
---
@@ -35,6 +35,24 @@ class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22269
cc @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/22269
[SPARK-23997][SQL][Followup] Update exception message
## What changes were proposed in this pull request?
This PR is an follow-up PR of #21087 based on [a discussion
thread](https
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r213707288
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -385,107 +385,120 @@ case class MapEntries
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r213689187
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala
---
@@ -35,6 +35,24 @@ class
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22240
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22219#discussion_r213645236
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -329,49 +329,52 @@ abstract class SparkPlan extends QueryPlan
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21087
@gatorsmile I see. I will open the PR today.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21912
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22240#discussion_r213377591
--- Diff: core/src/main/scala/org/apache/spark/BarrierTaskContext.scala ---
@@ -68,7 +74,7 @@ class BarrierTaskContext(
*
* CAUTION
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22246
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22233#discussion_r213371098
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -671,7 +674,7 @@ case class AlterTableRecoverPartitionsCommand
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22233#discussion_r213322084
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -671,7 +674,7 @@ case class AlterTableRecoverPartitionsCommand
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20965#discussion_r213273861
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -950,6 +950,15 @@ object SQLConf {
.booleanConf
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22048
@xuejianbest thank you for your update. Would it be possible to commit test
cases, too?
---
-
To unsubscribe, e-mail: reviews
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22233#discussion_r213138024
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -671,7 +674,7 @@ case class AlterTableRecoverPartitionsCommand
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22162
Would someone please take it?
I have less bandwidth next two days since I will be in a training session
at my office
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r213013507
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22233#discussion_r213009058
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -671,7 +674,7 @@ case class AlterTableRecoverPartitionsCommand
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r213005226
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -465,7 +465,7 @@ private[spark] class TaskSchedulerImpl(
var
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22243
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22241
Adding tests looks good.
Probably beyond the purpose of this PR, is the following difference
intentionally designed?
```
// If the data type is in @specialized annotation
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22242
@ArunkumarRamanan would it be possible to close this? probably something is
wrong.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21968#discussion_r212909243
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -164,9 +164,8 @@ private[joins] class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22219#discussion_r212857783
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -3237,6 +3237,20 @@ class Dataset[T] private[sql](
files.toSet.toArray
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22219
Would it possible to prepare test cases? IIUC, this feature can be enabled
without thriftServer by writing some test code
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22219#discussion_r212834287
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -3237,6 +3237,20 @@ class Dataset[T] private[sql](
files.toSet.toArray
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/1
We would appreciate it if you would describe some detail on `further
analysis` for removing lock on the whole object.
> On further analysis of the heartbeat receiver method, it turns
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r212833953
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -465,7 +465,7 @@ private[spark] class TaskSchedulerImpl(
var
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22218#discussion_r212833235
--- Diff:
core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala ---
@@ -17,11 +17,13 @@
package org.apache.spark.executor
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22162#discussion_r212832846
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22162#discussion_r212832850
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22162#discussion_r212832795
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22162#discussion_r212832804
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -815,6 +815,24 @@ class Dataset[T] private[sql](
println(showString
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22162#discussion_r212832734
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -815,6 +815,24 @@ class Dataset[T] private[sql](
println(showString
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212832157
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22233#discussion_r212831774
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -671,7 +674,7 @@ case class AlterTableRecoverPartitionsCommand
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212805339
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21931
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21087
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21087
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21087
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21912
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22219#discussion_r212706680
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -348,30 +350,30 @@ abstract class SparkPlan extends QueryPlan
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212683385
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22219#discussion_r212664629
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
---
@@ -289,6 +289,19 @@ private
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22219#discussion_r212664660
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
---
@@ -289,6 +289,19 @@ private
301 - 400 of 3585 matches
Mail list logo
