Re: [TLS] What is the TLS WG plan for quantum-resistant algorithms?

2023-11-06 Thread Yoav Nir
> On 6 Nov 2023, at 21:44, Watson Ladd wrote: > > > > On Mon, Nov 6, 2023, 10:07 AM Kris Kwiatkowski > wrote: >> So, based on FIPS 140-3 I.G., section C.K., resolution 5, [1]. "SP800-186 >> does not impact the curves permitted under SP 800-56Arev3. Curves that

Re: Is it normal to get bigger qcow2 image after blockcopy?

2023-11-06 Thread Nir Soffer
size":10737418240,"cluster-size":65536}},"id":"libvirt-430"} >>  ❓ >> >> {"execute":"job-dismiss","arguments":{"id":"create-libvirt-2-format"},"id":"libvirt-432"} >>  ❓ >> >> {"execute":"blockdev-add","arguments":{"node-name":"libvirt-2-format","read-only":false,"driver":"qcow2","file":"libvirt-2-storage","backing":null},"id":"libvirt-433"} >>  ❓ >> >> {"execute":"blockdev-mirror","arguments":{"job-id":"copy-vda-libvirt-1-format","device":"libvirt-1-format","target":"libvirt-2-format","sync":"full","auto-finalize":true,"auto-dismiss":false},"id":"libvirt-434"} >>  ❓ >> >> {"execute":"transaction","arguments":{"actions":[{"type":"block-dirty-bitmap-add","data":{"node":"libvirt-2-format","name":"libvirt-tmp-activewrite","persistent":false,"disabled":false}}]},"id":"libvirt-443"} >>  ❓ >> >> {"execute":"job-complete","arguments":{"id":"copy-vda-libvirt-1-format"},"id":"libvirt-444"} >>  ❓ >> > Nir

Re: RFR: 8301302: Platform preferences API [v20]

2023-11-02 Thread Nir Lisker
On Thu, 2 Nov 2023 19:11:39 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/PlatformPreferences.java >> line 198: >> >>> 196: * @throws NullPointerException if {@code preferences} is {@code >>> null} >>> 197: */ >>> 198:

Re: RFR: 8301302: Platform preferences API [v20]

2023-11-02 Thread Nir Lisker
On Wed, 1 Nov 2023 17:36:21 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v18]

2023-11-02 Thread Nir Lisker
On Tue, 31 Oct 2023 17:28:35 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance

Re: RFR: 8223298: SVG patterns are drawn wrong [v2]

2023-11-02 Thread Nir Lisker
On Wed, 15 Apr 2020 13:35:11 GMT, Kevin Rushforth wrote: >> Arun Joseph has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year > > As discussed offline, please add a test for this. @kevinrushforth Looks like the

Re: RFR: 8301302: Platform preferences API [v18]

2023-11-01 Thread Nir Lisker
On Wed, 1 Nov 2023 03:25:50 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line >> 636: >> >>> 634: * if no mapping exists for the specified key >>> 635: */ >>> 636: Optional getDouble(String key); >> >>

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread Nir Lisker
On Tue, 31 Oct 2023 20:35:47 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - formatting >> - Javadoc change > >

Re: RFR: 8301302: Platform preferences API [v18]

2023-10-31 Thread Nir Lisker
On Tue, 31 Oct 2023 17:28:35 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance

Re: RFR: 8301302: Platform preferences API [v14]

2023-10-31 Thread Nir Lisker
On Wed, 6 Sep 2023 23:03:46 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text

2023-10-30 Thread Nir Lisker
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote: > There are a number of tickets open related to text rendering: > > https://bugs.openjdk.org/browse/JDK-8314215 > > https://bugs.openjdk.org/browse/JDK-8145496 > > https://bugs.openjdk.org/browse/JDK-8129014 > > They have in common that

Re: RFR: 8319079: Missing range checks in decora

2023-10-30 Thread Nir Lisker
On Mon, 30 Oct 2023 06:55:11 GMT, Jayathirth D V wrote: > In SW pipeline path of Box/Gaussian Blur/Shadow effects we are not checking > for range when we read data from the source/destination buffers in native > code. > > We need to add appropriate range checks in native JNI code also apart

Re: [External] : Re: Question: bidi navigation

2023-10-19 Thread Nir Lisker
By the way, the dual caret can be transformed into the jumping caret by rendering only one of the split halves. If I'm in an LTR language, only the LTR caret is rendered, and same for RTL. This will look like a jumping caret. On Fri, Oct 20, 2023 at 5:40 AM Nir Lisker wrote: > The split ca

Re: [External] : Re: Question: bidi navigation

2023-10-19 Thread Nir Lisker
MonkeyTester TextArea page because it has > Window -> RTL menu option for switching the orientation. > > https://github.com/andy-goryachev-oracle/MonkeyTest > > > > What do you think? > > > > Thank you > > -andy > > > > > > > > *Fr

Re: [External] : Re: Question: bidi navigation

2023-10-19 Thread Nir Lisker
or). A jumping caret with a visual direction indicator solves 100% of the ambiguity and the surprise factor without needing to look outside of the text control to check which language is selected. - Nir On Wed, Oct 18, 2023 at 10:31 PM Philip Race wrote: > So it seems Swi

Re: [External] : Re: Question: bidi navigation

2023-10-18 Thread Nir Lisker
: > Dear Nir: > > > > Thank you so much for the information. I spoke to several people none of > whom, unfortunately, use an environment configured for RTL mode (but who > have keyboard settings for RTL languages). Based on the very small sample, > it appears that logical n

Re: RFR: 8318204: Use new EventTarget methods in ListenerHelper

2023-10-18 Thread Nir Lisker
On Tue, 17 Oct 2023 14:27:19 GMT, Andy Goryachev wrote: > it's a functional interface, so no gadgets at all. Both are functional interfaces. I think that `Subscription` can replace it, but isn't critical. - PR Comment: https://git.openjdk.org/jfx/pull/1262#issuecomment-1768249992

Re: RFR: 8318204: Use new EventTarget methods in ListenerHelper

2023-10-17 Thread Nir Lisker
On Tue, 17 Oct 2023 04:46:12 GMT, Michael Strauß wrote: > As of OpenJFX 21, `EventTarget` has methods to add and remove event listeners. > The `instanceof` checks in `com.sun.javafx.scene.control.ListenerHelper` > should be removed and replaced by a simple call to the respective interface >

Re: [External] : Re: Question: bidi navigation

2023-10-17 Thread Nir Lisker
, but it will make life easier because you will easily know in which direction you're about to type. On Mon, Oct 16, 2023 at 6:16 PM Andy Goryachev wrote: > Nir, thank you for responding! > > > > The behavior you describe (“logical” navigation) is what can be seen in > many, but no

Re: Question: bidi navigation

2023-10-16 Thread Nir Lisker
This is a tricky one. All applications I have seen, and I think that's what people expect, is that the cursor changes direction during traversal. A key point is where the paragraph is aligned to (in Windows adjusted with left CTRL+SHIFT and right CTRL+SHIFT). This sets the forward and backward

Re: [PATCH 1/1] block: improve alignment detection and fix 271 test

2023-10-14 Thread Nir Soffer
the test to reflect real world usage? _reset_img 2083k I guess it works with: _reset_img 2084k Commits > commit a6b257a08e3d72219f03e461a52152672fec0612 > Author: Nir Soffer > Date: Tue Aug 13 21:21:03 2019 +0300 > file-posix: Handle undetectable alignme

Re: [PATCH 1/1] block: improve alignment detection and fix 271 test

2023-10-14 Thread Nir Soffer
the test to reflect real world usage? _reset_img 2083k I guess it works with: _reset_img 2084k Commits > commit a6b257a08e3d72219f03e461a52152672fec0612 > Author: Nir Soffer > Date: Tue Aug 13 21:21:03 2019 +0300 > file-posix: Handle undetectable alignme

[ovirt-users] Re: How to obtain vm snapshots status

2023-10-03 Thread Nir Soffer
e check here how to use the ovirt python sdk to create/delete/backup and wait for events: https://github.com/ovirt/ovirt-stress Nir ___ Users mailing list -- users@ovirt.org To unsubscribe send an email to users-le...@ovirt.org Privacy Statement: https://

Re: Fix Scene colors for the colorblind

2023-09-28 Thread Nir Lisker
impairments. - Nir On Thu, Sep 28, 2023 at 6:21 PM Thiago Milczarek Sayão < thiago.sa...@gmail.com> wrote: > Hi, > > Wild question coming. > > Has anyone dealt with Scene colors for people that are color blind? > > We have some warning icons that are red that sometimes end

Re: RFR: 8316135: Create release notes for JavaFX 21 [v4]

2023-09-16 Thread Nir Lisker
On Sat, 16 Sep 2023 13:48:17 GMT, Kevin Rushforth wrote: >> Release notes for JavaFX 21, including four important changes, and the list >> of enhancements and bugs fixed in this release. >> >> I plan to integrate this on Monday, Sep 18th, and backport it to `jfx21` in >> time for Tuesday's

Re: RFR: 8316135: Create release notes for JavaFX 21 [v4]

2023-09-16 Thread Nir Lisker
On Sat, 16 Sep 2023 13:48:17 GMT, Kevin Rushforth wrote: >> Release notes for JavaFX 21, including four important changes, and the list >> of enhancements and bugs fixed in this release. >> >> I plan to integrate this on Monday, Sep 18th, and backport it to `jfx21` in >> time for Tuesday's

Re: [External] : Re: Enabling debug messages

2023-09-14 Thread Nir Lisker
There is some bad news too though. The D3D debug runtime seems to only be available on Windows 7 and older because D3D9 is EOL. That means that detailed messages from the D3D runtime are not available. On Fri, Sep 15, 2023 at 12:54 AM Nir Lisker wrote: > This works, thanks. Needed to run cl

Re: [External] : Re: Enabling debug messages

2023-09-14 Thread Nir Lisker
This works, thanks. Needed to run clean first. On Thu, Sep 14, 2023 at 6:09 PM Kevin Rushforth wrote: > In that case, my guess is that those really are enabled only for debug > builds. You can build a debug build using "gradle -PCONF=DebugNative". > > -- Kevin > >

Re: Enabling debug messages

2023-09-14 Thread Nir Lisker
on builds as well. > > -- Kevin > > > On 9/14/2023 4:27 AM, Nir Lisker wrote: > > Hi, > > I see that the D3D c++ files can output debug info via various > DebugPrintD3DError and TraceLn functions. How can this output be enabled? > > - Nir > > >

Enabling debug messages

2023-09-14 Thread Nir Lisker
Hi, I see that the D3D c++ files can output debug info via various DebugPrintD3DError and TraceLn functions. How can this output be enabled? - Nir

Re: [asterisk-dev] AstriCon 2024: February 15th, 2024 - Fort Lauderdale, Florida

2023-09-14 Thread Nir Simionovich
What you mean is seeing only 80% of me. :-) On Wed, Sep 13, 2023 at 1:10 PM Joshua C. Colp wrote: > Glad to hear it, and look forward to seeing you there! > > On Wed, Sep 13, 2023 at 7:04 AM Nir Simionovich > wrote: > >> Hi All, >> >> After a relatively l

Re: [asterisk-dev] AstriCon 2024: February 15th, 2024 - Fort Lauderdale, Florida

2023-09-13 Thread Nir Simionovich
Hi All, After a relatively long hiatus and a very brief visit last year, Eric and I are going to be back at ITExpo in full force. Looking forward to meeting everybody. On Tue, Sep 5, 2023 at 7:37 PM Joshua C. Colp wrote: > On Tue, Sep 5, 2023 at 12:41 PM Fred Posner wrote: > >> +1 regarding

Re: RFR: 8316135: Create release notes for JavaFX 21 [v2]

2023-09-12 Thread Nir Lisker
On Tue, 12 Sep 2023 22:42:10 GMT, Kevin Rushforth wrote: >> Release notes for JavaFX 21, including four important changes, and the list >> of enhancements and bugs fixed in this release. >> >> I plan to integrate this on Monday, Sep 18th, and backport it to `jfx21` in >> time for Tuesday's

Re: RFR: 8313651: Add 'final' keyword to public property methods in controls [v8]

2023-09-08 Thread Nir Lisker
On Fri, 8 Sep 2023 18:32:18 GMT, Andy Goryachev wrote: >> In the Control hierarchy, all property accessor methods must be declared >> `final`. >> >> Added a test to check for missing `final` keyword and added the said keyword >> where required. > > Andy Goryachev has updated the pull request

Re: RFR: 8313651: Add 'final' keyword to public property methods in controls [v7]

2023-09-08 Thread Nir Lisker
On Fri, 8 Sep 2023 15:01:34 GMT, Andy Goryachev wrote: >> In the Control hierarchy, all property accessor methods must be declared >> `final`. >> >> Added a test to check for missing `final` keyword and added the said keyword >> where required. > > Andy Goryachev has updated the pull request

Re: [jfx-tests] RFR: 8315842: 3D tests fail because of edge pixel differences

2023-09-08 Thread Nir Lisker
On Thu, 7 Sep 2023 10:17:28 GMT, Jayathirth D V wrote: > Out of 62 3D tests, 26 tests fail because of minute color differences in edge > pixels. > These tests are used to verify 3D rendering with different parameters like > translation, rotation. > > So adding little color tolerance will not

Re: JavaFX object traits

2023-09-07 Thread Nir Lisker
I do something very similar in my own projects where I "decompose" my entities into such interfaces. I find it beneficial. We do need to figure out which makes sense and for what purpose. On Wed, Sep 6, 2023, 22:41 Andy Goryachev wrote: > I think this proposal makes a lot of sense. > > > >

Re: [JavaFX 3D ( | Feature Request)] Setting Texture Nearest-Sampling on PhongMaterial

2023-08-29 Thread Nir Lisker
and hook up OpenGL. Not sure what the situation in Metal is. On Sun, Aug 27, 2023 at 1:15 PM Nir Lisker wrote: > Thanks for the ideas, > >> Could you subclass Image? I'm not that well versed with Textures in >> modern gfx systems, but I do know that a texture is often just a

Re: [JavaFX 3D ( | Feature Request)] Setting Texture Nearest-Sampling on PhongMaterial

2023-08-27 Thread Nir Lisker
ropyStrength; List mipMaps; WrapMode wrapMode; // enum with wrap modes like REPEAT, CLAMP... this exists in some form already etc. On Sun, Aug 27, 2023 at 6:45 AM John Hendrikx wrote: > Hi Nir, > > I added some inline questions/comments for your consideration. > > --John &g

Re: [JavaFX 3D ( | Feature Request)] Setting Texture Nearest-Sampling on PhongMaterial

2023-08-25 Thread Nir Lisker
extures [7] https://gregs-blog.com/2008/01/17/opengl-texture-filter-parameters-explained/ On Sun, Jun 25, 2023 at 9:03 PM Nir Lisker wrote: > Perhaps Jay and Kevin can weigh in on this. > > By the way, I see that the com.sun.prism.Texture interface already defines > get/setL

Re: RFR: 8313651: Add 'final' keyword to public property methods in controls [v4]

2023-08-22 Thread Nir Lisker
On Mon, 21 Aug 2023 23:11:49 GMT, Andy Goryachev wrote: >> In the Control hierarchy, all property accessor methods must be declared >> `final`. >> >> Added a test to check for missing `final` keyword and added the said keyword >> where required. > > Andy Goryachev has updated the pull request

Re: RFR: 8313651: Add 'final' keyword to public property methods in controls [v2]

2023-08-21 Thread Nir Lisker
On Mon, 21 Aug 2023 22:16:50 GMT, Andy Goryachev wrote: >>> these classes (in javafx.scene.control.cell) are public and in the Control >>> hierarchy, so are subject of the 'final' limitation. >> >> I'm confused. Which classes should appear in this list exactly (what are the >> rules to

Re: RFR: 8313651: Add 'final' keyword to public property methods in controls [v2]

2023-08-21 Thread Nir Lisker
On Mon, 21 Aug 2023 15:27:44 GMT, Andy Goryachev wrote: > these classes (in javafx.scene.control.cell) are public and in the Control > hierarchy, so are subject of the 'final' limitation. I'm confused. Which classes should appear in this list exactly (what are the rules to determine that)? >

Re: RFR: JDK-8312058: Documentation improvements for subscription based listeners [v6]

2023-08-21 Thread Nir Lisker
On Fri, 11 Aug 2023 22:03:28 GMT, John Hendrikx wrote: >> Incorporates documentation review comments from #1069. >> >> This PR should be kept minimal so it can be backported to JFX21; it should >> only contain documentation changes. > > John Hendrikx has updated the pull request incrementally

Re: RFR: 8313651: Add 'final' keyword to public property methods in controls [v2]

2023-08-20 Thread Nir Lisker
On Fri, 18 Aug 2023 22:17:15 GMT, Andy Goryachev wrote: >> In the Control hierarchy, all property accessor methods must be declared >> `final`. >> >> Added a test to check for missing `final` keyword and added the said keyword >> where required. > > Andy Goryachev has updated the pull request

Re: RFR: 8314589: javadoc build only shows the first 100 warnings and errors

2023-08-19 Thread Nir Lisker
On Fri, 18 Aug 2023 17:17:06 GMT, Kevin Rushforth wrote: > This PR bumps the limit for the number of javadoc warnings and error from 100 > to 1000. > > We currently use the default setting of javadoc which only shows 100 warnings > and errors. This is too small, especially for warnings, and

Re: RFR: JDK-8312058: Documentation improvements for subscription based listeners [v5]

2023-08-17 Thread Nir Lisker
On Mon, 14 Aug 2023 02:01:20 GMT, Nir Lisker wrote: >>> Looks good now. Do you still prefer to repeat the behavior of the >>> subscription in each of the new methods over the centralized one in [#1069 >>> (comment)](https://github.com/openjdk/jfx/pull/1069#discussi

Re: [Libguestfs] [libnbd PATCH] golang: Bump minimum Go version to 1.17

2023-08-17 Thread Nir Soffer
On Tue, Aug 15, 2023 at 9:53 PM Eric Blake wrote: > On Mon, Aug 14, 2023 at 01:43:37PM -0500, Eric Blake wrote: > > > > +++ b/golang/configure/test.go > > > > @@ -25,8 +25,19 @@ > > > > import ( > > > > "fmt" > > > > "runtime" > > > > + "unsafe" > > > > ) > > > > > > > >

Re: RFR: JDK-8199216: Quadratic layout time with nested nodes and pseudo-class in style sheet [v8]

2023-08-16 Thread Nir Lisker
On Tue, 15 Aug 2023 19:33:20 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/css/ImmutablePseudoClassSetsCache.java >> line 61: >> >>> 59: CACHE.put(copy, copy); >>> 60: >>> 61: return copy; >> >> Isn't this just `return

Re: RFR: JDK-8199216: Quadratic layout time with nested nodes and pseudo-class in style sheet [v8]

2023-08-16 Thread Nir Lisker
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote: >> This fix introduces immutable sets of `PseudoClass` almost everywhere, as >> they are rarely modified. These are re-used by caching them in a new class >> `ImmutablePseudoClassSetsCache`. >> >> In order to make this work, `BitSet` had

Re: RFR: JDK-8199216: Quadratic layout time with nested nodes and pseudo-class in style sheet [v8]

2023-08-15 Thread Nir Lisker
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote: >> This fix introduces immutable sets of `PseudoClass` almost everywhere, as >> they are rarely modified. These are re-used by caching them in a new class >> `ImmutablePseudoClassSetsCache`. >> >> In order to make this work, `BitSet` had

Re: RFR: JDK-8312058: Documentation improvements for subscription based listeners [v5]

2023-08-13 Thread Nir Lisker
On Fri, 11 Aug 2023 21:40:08 GMT, John Hendrikx wrote: > > Looks good now. Do you still prefer to repeat the behavior of the > > subscription in each of the new methods over the centralized one in [#1069 > > (comment)](https://github.com/openjdk/jfx/pull/1069#discussion_r1261873147)? > > I'm

Re: [Libguestfs] [libnbd PATCH] golang: Bump minimum Go version to 1.17

2023-08-13 Thread Nir Soffer
upport, but is relatively old these days. All other > systems appear unaffected by this bump in requirements, at least if > they can be configured to use developer backports. > > Suggested-by: Nir Soffer > Signed-off-by: Eric Blake > --- > > This replaces > https://l

Re: RFR: JDK-8312058: Documentation improvements for subscription based listeners [v4]

2023-08-11 Thread Nir Lisker
On Fri, 11 Aug 2023 12:12:28 GMT, John Hendrikx wrote: >> Incorporates documentation review comments from #1069. >> >> This PR should be kept minimal so it can be backported to JFX21; it should >> only contain documentation changes. > > John Hendrikx has updated the pull request incrementally

Re: RFR: JDK-8312058: Documentation improvements for subscription based listeners [v4]

2023-08-11 Thread Nir Lisker
On Fri, 11 Aug 2023 12:12:28 GMT, John Hendrikx wrote: >> Incorporates documentation review comments from #1069. >> >> This PR should be kept minimal so it can be backported to JFX21; it should >> only contain documentation changes. > > John Hendrikx has updated the pull request incrementally

Re: [Libguestfs] [libnbd PATCH v4 05/25] golang: Change logic of copy_uint32_array

2023-08-08 Thread Nir Soffer
ly just panic if the count is oversized: our > state machine guarantees that the server's response fits within 64M > bytes (count will be smaller than that, since it is multiple bytes per > extent entry). Good to check this, but not related to changing the way we copy the array. > S

Re: RFR: JDK-8312058: Documentation improvements for subscription based listeners [v3]

2023-08-06 Thread Nir Lisker
On Sun, 6 Aug 2023 09:16:32 GMT, John Hendrikx wrote: >> Incorporates documentation review comments from #1069. >> >> This PR should be kept minimal so it can be backported to JFX21; it should >> only contain documentation changes. > > John Hendrikx has updated the pull request incrementally

Re: RFR: JDK-8312058: Documentation improvements for subscription based listeners [v2]

2023-07-31 Thread Nir Lisker
On Mon, 31 Jul 2023 11:51:24 GMT, John Hendrikx wrote: >> Incorporates documentation review comments from #1069. >> >> This PR should be kept minimal so it can be backported to JFX21; it should >> only contain documentation changes. > > John Hendrikx has updated the pull request with a new

[jfx21] Integrated: 8313227: Correct attenuation indicator for removed lights

2023-07-28 Thread Nir Lisker
On Fri, 28 Jul 2023 00:13:16 GMT, Nir Lisker wrote: > Backport of commit > [b323db26](https://github.com/openjdk/jfx/commit/b323db262906853afbdec7a747f3b2f5b6593b9b) > (PR https://github.com/openjdk/jfx/pull/1186) This pull request has now been integrated. Changeset: 86e71094 Autho

[jfx21] RFR: 8313227: Correct attenuation indicator for removed lights

2023-07-27 Thread Nir Lisker
Backport of commit [b323db26](https://github.com/openjdk/jfx/commit/b323db262906853afbdec7a747f3b2f5b6593b9b) (PR https://github.com/openjdk/jfx/pull/1186) - Commit messages: - Backport b323db262906853afbdec7a747f3b2f5b6593b9b Changes: https://git.openjdk.org/jfx/pull/1187/files

Integrated: 8313227: Correct attenuation indicator for removed lights

2023-07-27 Thread Nir Lisker
On Thu, 27 Jul 2023 03:39:06 GMT, Nir Lisker wrote: > A simple fix of changing the attenuation toggle from 1 to 0 for removed > lights. This pull request has now been integrated. Changeset: b323db26 Author: Nir Lisker URL: https://git.openjdk.org/jfx/

Re: RFR: 8313227: Correct attenuation indicator for removed lights

2023-07-26 Thread Nir Lisker
On Thu, 27 Jul 2023 03:39:06 GMT, Nir Lisker wrote: > A simple fix of changing the attenuation toggle from 1 to 0 for removed > lights. @kevinrushforth I think that this is simple enough to be able to get into RDP1. There is some performance improvement regained here that was lost

RFR: 8313227: Correct attenuation indicator for removed lights

2023-07-26 Thread Nir Lisker
A simple fix of changing the attenuation toggle from 1 to 0 for removed lights. - Commit messages: - Initial commit Changes: https://git.openjdk.org/jfx/pull/1186/files Webrev: https://webrevs.openjdk.org/?repo=jfx=1186=00 Issue: https://bugs.openjdk.org/browse/JDK-8313227

bug#64785: Package: coreutils Version: 8.32-4+b1 program=mv

2023-07-22 Thread Nir Oren
I agree with Paul suggestion for an error message. In any case, Coreutils 5.93 message was better than the current one On Sat, Jul 22, 2023 at 8:37 PM Paul Eggert wrote: > On 2023-07-22 03:19, Pádraig Brady wrote: > > Given the subtleties in this area, > > I'd be reluctant to adjust diagnostics

bug#64785: Package: coreutils Version: 8.32-4+b1 program=mv

2023-07-22 Thread Nir Oren
*mv: error message "Directory not empty" is confusing * description: when you try to move a directory to a location already containing a directory with the same name it would just write "mv: cannot move 'A' to 'B': Directory not empty" first, this is technically a wrong error message because

Re: RFR: JDK-8312528: Move Subscription interface from javafx.beans to javafx.util

2023-07-21 Thread Nir Lisker
On Fri, 21 Jul 2023 22:15:03 GMT, John Hendrikx wrote: > The Subscription interface is independent from FX beans and has uses > unrelated to beans, it should therefore be placed in javafx.util. > > This should be fixed before > [JDK-8311123](https://bugs.openjdk.org/browse/JDK-8311123) is

Re: CSS heisenbug

2023-07-21 Thread Nir Lisker
I added the info to the ticket. On Fri, Jul 21, 2023 at 2:00 AM Alessandro Mercier < administra...@codedead.com> wrote: > Hello, > > I possibly have some new information in regards to: > https://bugs.openjdk.org/browse/JDK-8268657 > > It seems the bug is predominantly active on Linux Wayland

[ovirt-users] Re: python sdk4 ovirt 4.5.5.0 master

2023-07-19 Thread Nir Soffer
On Mon, Jul 17, 2023 at 6:29 PM Jorge Visentini wrote: > > Hi. > > I am testing oVirt 4.5.5-0.master.20230712143502.git07e865d650.el8. > > I missed the python scripts to download and upload discs and images... Will > it still be possible to use them or should I consider using Ansible? See

[sr-dev] [kamailio/kamailio] Add 2 new options to dispatcher management in kamctl (PR #3512)

2023-07-16 Thread Nir Simionovich
kamctl: added new options to dispatcher interface - added a new `rmip` option to delete a specific gateway `ip` in a predefined `setid` - added a new `rmset` option to delete a specific `setid` completely You can view, comment on, or merge this pull request online at:

Re: RFR: JDK-8304439: Subscription based listeners [v13]

2023-07-13 Thread Nir Lisker
On Thu, 13 Jul 2023 21:21:32 GMT, John Hendrikx wrote: >> I put your changes (that we agree upon so far) in #1177 >> >> As I said I'm not sure about the description for the Subscription class, and >> it's not included yet, and so I also haven't yet removed the duplicated >> texts about

Re: RFR: JDK-8312058: Documentation improvements for subscription based listeners

2023-07-13 Thread Nir Lisker
On Thu, 13 Jul 2023 21:13:06 GMT, John Hendrikx wrote: > Incorporates documentation review comments from #1069. > > This PR should be kept minimal so it can be backported to JFX21; it should > only contain documentation changes. modules/javafx.base/src/main/java/javafx/beans/Subscription.java

Re: RFR: JDK-8304439: Subscription based listeners [v13]

2023-07-12 Thread Nir Lisker
On Thu, 13 Jul 2023 00:01:23 GMT, John Hendrikx wrote: >> Makes `Subscription` public (removing some of its methods that are >> unnecessary), and adds methods that can provide `Subscription`s in >> `ObservableValue`. > > John Hendrikx has updated the pull request incrementally with one

Re: RFR: JDK-8304439: Subscription based listeners [v12]

2023-07-12 Thread Nir Lisker
On Tue, 11 Jul 2023 23:19:21 GMT, John Hendrikx wrote: >> Makes `Subscription` public (removing some of its methods that are >> unnecessary), and adds methods that can provide `Subscription`s in >> `ObservableValue`. > > John Hendrikx has updated the pull request incrementally with one

Re: RFR: JDK-8304439: Subscription based listeners [v13]

2023-07-12 Thread Nir Lisker
On Thu, 13 Jul 2023 00:01:23 GMT, John Hendrikx wrote: >> Makes `Subscription` public (removing some of its methods that are >> unnecessary), and adds methods that can provide `Subscription`s in >> `ObservableValue`. > > John Hendrikx has updated the pull request incrementally with one

Re: [Libguestfs] Libnbd asynchronous API with epoll

2023-07-09 Thread Nir Soffer
On Fri, Jul 7, 2023 at 11:59 AM Tage Johansson wrote: > On 7/6/2023 7:06 PM, Nir Soffer wrote: > > - After calling for example aio_notify_read(3), can I know that the next > reading from the file descriptor would block? > > No, you have to call again aio_get_direction() an

Re: [Libguestfs] Libnbd asynchronous API with epoll

2023-07-06 Thread Nir Soffer
descriptor would block? > No, you have to call again aio_get_direction() and poll again until the event happens. Nir ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs

Re: [JavaFX 3D ( | Feature Request)] Setting Texture Nearest-Sampling on PhongMaterial

2023-06-25 Thread Nir Lisker
at 8:54 PM Matija Brown wrote: > This is a good point you’re bringing up Nir! > > > > I’m really not sure on that. On the one hand your interpretation seems the > most sensible, but on the other hand I can’t see any use case of NEAREST > filtering in specular or s

Re: [JavaFX 3D ( | Feature Request)] Setting Texture Nearest-Sampling on PhongMaterial

2023-06-25 Thread Nir Lisker
considering there is only this one > single parameter we’re trying to add, > > thus maybe just a flag in PhongMaterial would suffice? > > > > Have a nice day, > > Matija. > > *From: *Matija Brown > *Sent: *Thursday, 22 June 2023 18:37 > *To: *Jayathirt

Re: Vulkan

2023-06-22 Thread Nir Lisker
The Vulkan pipeline option has been brought up several times over the past years. It's a good addition, but it's a lot of work and there aren't enough people who volunteered to work on it. Even "upgrading" the DirectX implementation from 9 to 11 hasn't taken off for the same reason. On Thu, Jun

Re: [JavaFX 3D ( | Feature Request)] Setting Texture Nearest-Sampling on PhongMaterial

2023-06-21 Thread Nir Lisker
ender call. However it shouldn’t make any > > API difference really, as we can just have a field somewhere and the parse > it along when needed. > > > > Cheers, > > Matija. > > > > *From: *Jayathirth Rao Daarapuram Venkatesh Murthy > > *Sent: *Wednesday, 21 June

Re: [JavaFX 3D ( | Feature Request)] Setting Texture Nearest-Sampling on PhongMaterial

2023-06-21 Thread Nir Lisker
uld probably be sensible to add this as a parameter to the > PhonMaterial-class. > > Alternatively it might make sense to add a “Texture” class that is used a > a DiffuseMap in the PhonMaterial. But that seems slightly overkill. > > > > As I am not very well acquainted with c

Re: [JavaFX 3D ( | Feature Request)] Setting Texture Nearest-Sampling on PhongMaterial

2023-06-20 Thread Nir Lisker
mpatible with both Direct3D and OpenGL (not sure how the work on Metal is going), so this can be a challenge. For the D3D side, see this issue in JBS [1]. The relevant code is at [2]. I didn't look at the OpenGL side. - Nir [1] https://bugs.openjdk.org/browse/JDK-8092272 [2] https://github.co

Re: RFR: 8306021: Add event handler management to EventTarget [v5]

2023-06-12 Thread Nir Lisker
On Mon, 12 Jun 2023 18:17:17 GMT, Michael Strauß wrote: >> This PR adds the following methods to the `EventTarget` interface: >> 1. `addEventHandler` >> 2. `removeEventHandler` >> 3. `addEventFilter` >> 4. `removeEventFilter` > > Michael Strauß has updated the pull request incrementally with two

Integrated: 8306648: Update the JavaDocs to show the NEW section and DEPRECATED versions

2023-06-12 Thread Nir Lisker
On Fri, 21 Apr 2023 13:18:31 GMT, Nir Lisker wrote: > Adds the javadoc commands to generate the NEW page and to be able to select > versions in the DEPRECATED page. This pull request has now been integrated. Changeset: 9913b23a Author: Nir Lisker URL: https://git.openjdk.o

[sqlalchemy] Sql constructor

2023-06-06 Thread Nir Assaraf
. This was used to automate query building for a projects with thousands of different logics that where defined by the client. I was just wondering if you think there is a place for something like that in SQLAlchemy or related projects. Best regards, Nir -- SQLAlchemy - The Python SQL Toolkit

Re: Implementation not following documentation regarding when event handler gets called

2023-05-29 Thread Nir Lisker
Didn't look too deep, but seems like a bug or incorrect doc. I don't see such specifications in other "setOnX" methods. On Sun, May 28, 2023 at 1:02 PM John Hendrikx wrote: > When looking at the code for Scene#setOnKeyPressed, I noticed that it > calls Scene#setEventHandler. This is documented

Re: RFR: 8306648: Update the JavaDocs to show the NEW section and DEPRECATED versions

2023-05-25 Thread Nir Lisker
On Thu, 27 Apr 2023 09:02:43 GMT, Nir Lisker wrote: >> Notes to reviewers: >> >> 1. The `-since` option does not play well with the javafx one: if >> documentation was added on a `private` property field with the `@since` tag, >> it will not be included in t

Re: RFR: 8091153: Customize the Table Button Menu [v5]

2023-05-25 Thread Nir Lisker
On Wed, 24 May 2023 16:55:11 GMT, Marius Hanl wrote: >> This PR implements a way to override the table column menu. >> When the `cornerRegion` is pressed, it will now call the `showColumnMenu` >> method. This new method is protected and therefore can be overidden by >> developers. If not

Re: RFR: 8091153: Customize the Table Button Menu [v5]

2023-05-24 Thread Nir Lisker
On Wed, 24 May 2023 16:55:11 GMT, Marius Hanl wrote: >> This PR implements a way to override the table column menu. >> When the `cornerRegion` is pressed, it will now call the `showColumnMenu` >> method. This new method is protected and therefore can be overidden by >> developers. If not

Re: CFV: New OpenJFX Committer: Lukasz Kostyra

2023-05-24 Thread Nir Lisker
Vote: YES On Wed, May 24, 2023 at 4:24 PM Marius Hanl wrote: > Vote: YES > > -- Marius > Am 24.05.23, 13:49 schrieb Kevin Rushforth : > >> I hereby nominate Lukasz Kostyra [1] to OpenJFX Committer. >> >> Lukasz is a member of the JavaFX team at Oracle who has contributed 12 >> commits [2] to

Re: RFR: 8091153: Customize the Table Button Menu [v4]

2023-05-24 Thread Nir Lisker
On Wed, 17 May 2023 19:29:13 GMT, Marius Hanl wrote: >> This PR implements a way to override the table column menu. >> When the `cornerRegion` is pressed, it will now call the `showColumnMenu` >> method. This new method is protected and therefore can be overidden by >> developers. If not

Re: [Lsr] Secdir last call review of draft-ietf-lsr-ip-flexalgo-11

2023-05-17 Thread Yoav Nir
> On 16 May 2023, at 10:25, Peter Psenak wrote: > > Yoav, > > thanks for comments, please see inline: > > > On 15/05/2023 21:36, Yoav Nir via Datatracker wrote: >> Reviewer: Yoav Nir >> Review result: Has Nits >> Hi. >> I have reviewed thi

[Lsr] Secdir last call review of draft-ietf-lsr-ip-flexalgo-11

2023-05-15 Thread Yoav Nir via Datatracker
Reviewer: Yoav Nir Review result: Has Nits Hi. I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the security area directors. Document editors

Re: RFR: JDK-8308028 Replace more uses of System.getProperty("os.name") with PlatformUtil calls [v4]

2023-05-13 Thread Nir Lisker
On Sat, 13 May 2023 17:36:59 GMT, Carl Döbbelin wrote: >> replaced implementation of OS checks in HostUtils with calls of PlatformUtil > > Carl Döbbelin has updated the pull request incrementally with one additional > commit since the last revision: > > removed HostUtils Marked as reviewed

Re: RFR: JDK-8308028 Replace more uses of System.getProperty("os.name") with PlatformUtil calls [v3]

2023-05-13 Thread Nir Lisker
On Sat, 13 May 2023 17:23:55 GMT, Carl Döbbelin wrote: >> replaced implementation of OS checks in HostUtils with calls of PlatformUtil > > Carl Döbbelin has updated the pull request incrementally with one additional > commit since the last revision: > > refactored HostUtils `isEmbedded()`

Re: RFR: JDK-8308028 Replace more uses of System.getProperty("os.name") with PlatformUtil calls [v2]

2023-05-13 Thread Nir Lisker
On Sat, 13 May 2023 16:42:33 GMT, Marius Hanl wrote: >> Carl Döbbelin has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added isEmbedded > > modules/javafx.media/src/main/java/com/sun/media/jfxmediaimpl/HostUtils.java > line 60: > >>

Re: RFR: JDK-8307807 Replace use of System.getProperty("os.name") with PlatformUtil calls [v5]

2023-05-11 Thread Nir Lisker
On Thu, 11 May 2023 17:59:48 GMT, Carl Döbbelin wrote: >> Replaced querying of `System.getProperty("os.name")` to check for OS with >> the use of the methods provided by `PlatformUtils` > > Carl Döbbelin has updated the pull request incrementally with one additional > commit since the last

Re: RFR: JDK-8307807 Replace use of System.getProperty("os.name") with PlatformUtil calls

2023-05-11 Thread Nir Lisker
On Thu, 11 May 2023 14:57:31 GMT, Carl Döbbelin wrote: > I cannot use the PlatformUtils in the `com.sun.webkit.network.URLLoader` > class, as the PlatformUtils are not Exported to the corresponding module. I wonder if this was done on purpose. - PR Comment:

Re: RFR: JDK-8307807 Replace use of System.getProperty("os.name") with PlatformUtil calls

2023-05-10 Thread Nir Lisker
On Wed, 10 May 2023 18:47:16 GMT, Carl Döbbelin wrote: > Replaced querying of `System.getProperty("os.name")` to check for OS with the > use of the methods provided by `PlatformUtils` Found an occurrences: * `com.sun.javafx.application.LauncherImpl` line 386. *

Re: RFR: JDK-8306490: Fix raw type warnings in graphics

2023-05-10 Thread Nir Lisker
On Tue, 18 Apr 2023 16:17:52 GMT, John Hendrikx wrote: > Focused only on raw type problems, and removing casts that were no longer > needed because of the changes. I started reviewing but there are too many files, which makes the GitHub interface unresponsive. Can you break it into 4 PRs of

<    1   2   3   4   5   6   7   8   9   10   >