Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of [v2]

2023-02-01 Thread Nir Lisker
On Wed, 1 Feb 2023 23:38:57 GMT, Glavo wrote: >> `List.of` is cleaner, and can slightly reduce the memory footprint for lists >> of one or two elements. >> >> Because `List.of` can only store non-null elements, I have only replaced a >> few usage. >> >> Can someone open an Issue on JBS for

Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of

2023-02-01 Thread Nir Lisker
On Wed, 1 Feb 2023 16:54:30 GMT, John Hendrikx wrote: >> modules/javafx.media/src/main/java/com/sun/media/jfxmedia/Media.java line >> 103: >> >>> 101: } >>> 102: } >>> 103: return returnValue; >> >> This method can be reduced to >> >> public List getTracks() {

Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of

2023-02-01 Thread Nir Lisker
On Wed, 1 Feb 2023 15:11:57 GMT, Glavo wrote: > I have considered this, but I didn't make this change because I was worried > that there would be less descriptive information when null was encountered. I think it's fine. The method is documented to throw and it happens immediately on entry.

Re: [External] : Re: Some classes could be sealed

2023-02-01 Thread Nir Lisker
e. So this doesn't seem > feasible. > > We could still seal Shape, Shape3D, LightBase, and Material, since all > permitted implementation are in the javafx.graphics module. It may or may > not be worth doing that. > > -- Kevin > > > On 2/1/2023 9:45 AM, Nir Lisker

Re: [External] : Re: Some classes could be sealed

2023-02-01 Thread Nir Lisker
bout the > tests that extend Node and run in the unnamed module. So this doesn't seem > feasible. > > We could still seal Shape, Shape3D, LightBase, and Material, since all > permitted implementation are in the javafx.graphics module. It may or may > not be worth doing that. > > -

Re: Some classes could be sealed

2023-02-01 Thread Nir Lisker
I'll add that internal classes, mostly NG___ peers, can also benefit from sealing. NGLightBase is an example. Material is another public class that can be sealed. On Wed, Feb 1, 2023 at 7:37 PM Kevin Rushforth wrote: > I agree that we should only seal existing classes that could not have been

Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of

2023-02-01 Thread Nir Lisker
On Thu, 26 Jan 2023 05:30:56 GMT, Glavo wrote: > `List.of` is cleaner, and can slightly reduce the memory footprint for lists > of one or two elements. > > Because `List.of` can only store non-null elements, I have only replaced a > few usage. > > Can someone open an Issue on JBS for me?

Re: RFR: 8301604: Replace Collections.unmodifiableList with List.of

2023-02-01 Thread Nir Lisker
On Wed, 1 Feb 2023 11:21:04 GMT, Glavo wrote: >> Filed: https://bugs.openjdk.org/browse/JDK-8301604. Please let me know if >> the issue is not reported correctly. > > @theaoqi Thank you very much! @Glavo If you can't access JBS, you can submit a report via bugreport.java.com. @theaoqi If you

Re: RFR: 8138842: TableViewSelectionModel.selectIndices does not select index 0 [v2]

2023-02-01 Thread Nir Lisker
On Wed, 1 Feb 2023 09:17:33 GMT, Karthik P K wrote: >> I think it is also pretty clear the original author intended to check >> `rows.length == 0` and made the mistake that it would be called with `rows >> == null` when there are no further indices specified, which is incorrect. > > I believe

Re: RFR: 8138842: TableViewSelectionModel.selectIndices does not select index 0

2023-01-31 Thread Nir Lisker
On Tue, 31 Jan 2023 14:40:00 GMT, Karthik P K wrote: > In `selectIndices` method, zero length array is not considered while ignoring > row number given as parameter. > > Updated the code to consider both null and zero length array in the condition > before ignoring the row value given as

Re: RFR: 8138842: TableViewSelectionModel.selectIndices does not select index 0

2023-01-31 Thread Nir Lisker
On Tue, 31 Jan 2023 14:40:00 GMT, Karthik P K wrote: > In `selectIndices` method, zero length array is not considered while ignoring > row number given as parameter. > > Updated the code to consider both null and zero length array in the condition > before ignoring the row value given as

Re: [Libguestfs] [libnbd PATCH v2 3/3] nbdsh: Improve --help and initial banner contents.

2023-01-31 Thread Nir Soffer
when it breaks? I'm not sure what is the issue, but usually if you have a global variable created only in some flows, adding: thing = None At the start of the module makes sure that the name exists later, regardless of the flow taken. Code can take the ri

Re: [Libguestfs] [PATCH v2v v2] -o rhv-upload: Improve error message for invalid or missing -os parameter

2023-01-28 Thread Nir Soffer
detaches the domain from the data center in the window after the precheck completes and before the transfer starts. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1986386 > Reported-by: Junqin Zhou > Thanks: Nir Soffer > --- > output/rhv-upload-precheck.py | 27

Re: [Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain does not exist

2023-01-27 Thread Nir Soffer
On Fri, Jan 27, 2023 at 1:18 PM Nir Soffer wrote: > > On Thu, Jan 26, 2023 at 2:31 PM Richard W.M. Jones wrote: > > > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1986386 > > Reported-by: Junqin Zhou > > --- > > output/rhv-upload-precheck.py | 7 +

Re: [Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain does not exist

2023-01-27 Thread Nir Soffer
t; +raise RuntimeError("The storage domain ‘%s’ does not exist" % > + params['output_storage']) The fix is safe and makes sense. Not sure why we list all storage domains when we already know the name, maybe Albert would like to clean up this mess later. Nir ___

Re: [Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain

2023-01-27 Thread Nir Soffer
t; As I say above, I don't especially care about any of this. I'm not working on RHV since August 2022. Adding Albert who is current RHV storage maintainer. Nir ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list [v3]

2023-01-24 Thread Nir Lisker
On Tue, 24 Jan 2023 09:59:48 GMT, Ajit Ghaisas wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/ListView.java >> line 152: >> >>> 150: * Warning: Nodes should not be inserted directly into the items >>> list >>> 151: * ListView allows for the items list to contain

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list [v4]

2023-01-24 Thread Nir Lisker
On Tue, 24 Jan 2023 10:35:36 GMT, Ajit Ghaisas wrote: > > > > @nlisker, Can you please file an issue explaining how exactly you would like > `ListView` documentation to be restructured? Yes, I'll probably work on it during RDP 2. It's not the only control I want to go over. -

Re: TableViewBuilder idea

2023-01-22 Thread Nir Lisker
Isn't this something that an external library can do? I would think that writing an adapter that can read JPA annotations is the way to go. After all, most entities are not written with JavaFX properties. On Sun, Jan 22, 2023 at 2:08 AM Thiago Milczarek Sayão < thiago.sa...@gmail.com> wrote: >

Re: RFC: new property in ToggleGroup

2023-01-21 Thread Nir Lisker
We already have ToggleButton: Unlike RadioButtons, ToggleButtons in a ToggleGroup do not attempt to force > at least one selected ToggleButton in the group. That is, if a ToggleButton is selected, clicking on it will cause it to > become unselected. With RadioButton, clicking on the selected

Re: RFC: new property in ToggleGroup

2023-01-21 Thread Nir Lisker
I don't see it being especially useful. GUI's tend to work this way. I remember it was the same in Swing. On Sat, Jan 21, 2023 at 1:41 AM Kevin Rushforth wrote: > > > On 1/20/2023 2:57 PM, Andy Goryachev wrote: > > I just want to add one thing - the initial state of RadioMenuItems added > to a

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list [v3]

2023-01-20 Thread Nir Lisker
On Wed, 18 Jan 2023 09:25:08 GMT, Ajit Ghaisas wrote: >> This PR adds a warning about inserting Nodes directly into the virtualized >> containers such as ListView, TreeView, TableView and TreeTableView. It also >> adds code snippets showing the recommended pattern of using a custom cell >>

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list [v4]

2023-01-20 Thread Nir Lisker
On Fri, 20 Jan 2023 11:16:04 GMT, Ajit Ghaisas wrote: >> This PR adds a warning about inserting Nodes directly into the virtualized >> containers such as ListView, TreeView, TableView and TreeTableView. It also >> adds code snippets showing the recommended pattern of using a custom cell >>

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list

2023-01-14 Thread Nir Lisker
On Fri, 13 Jan 2023 12:32:53 GMT, Ajit Ghaisas wrote: > This PR adds a warning about inserting Nodes directly into the virtualized > containers such as ListView, TreeView, TableView and TreeTableView. It also > adds code snippets showing the recommended pattern of using a custom cell >

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list

2023-01-14 Thread Nir Lisker
On Fri, 13 Jan 2023 12:32:53 GMT, Ajit Ghaisas wrote: > This PR adds a warning about inserting Nodes directly into the virtualized > containers such as ListView, TreeView, TableView and TreeTableView. It also > adds code snippets showing the recommended pattern of using a custom cell >

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v11]

2023-01-11 Thread Nir Lisker
On Sun, 25 Dec 2022 04:04:40 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time i

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v11]

2023-01-10 Thread Nir Lisker
On Sun, 25 Dec 2022 04:04:40 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time i

Integrated: 8217853: Cleanup in the D3D native pipeline

2023-01-10 Thread Nir Lisker
On Mon, 2 May 2022 16:05:08 GMT, Nir Lisker wrote: > Refactoring and renaming changes to some of the D3D pipeline files and a few > changes on the Java side. These are various "leftovers" from previous issues > that we didn't want to touch at the time in order t

Re: CheckBoxTreeItem behavior - independent property

2023-01-04 Thread Nir Lisker
code that makes it not worth doing this? To me it looks like a bug, but the docs don't say anything about this point. On Sat, Nov 19, 2022 at 9:28 AM Nir Lisker wrote: > Hi, > > Another issue I stumbled across is the usage of the Independent property > on CheckBoxTreeItem. T

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v11]

2023-01-04 Thread Nir Lisker
On Sun, 25 Dec 2022 04:04:40 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time i

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v11]

2023-01-04 Thread Nir Lisker
On Sun, 25 Dec 2022 04:04:40 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time i

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v3]

2023-01-04 Thread Nir Lisker
On Tue, 3 Jan 2023 23:56:12 GMT, Nir Lisker wrote: >> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after >> expand/collapse events. The graphics node needs to be released from the >> previous checkbox so that it doesn't serve as the graphics of more tha

Integrated: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-04 Thread Nir Lisker
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote: > A simple fix for the graphics of a `CheckBoxTreeCell` not showing after > expand/collapse events. The graphics node needs to be released from the > previous checkbox so that it doesn't serve as the graphics of more than one &

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages [v2]

2023-01-03 Thread Nir Lisker
On Sun, 1 Jan 2023 16:08:15 GMT, John Hendrikx wrote: >> Packages fixed: >> - com.sun.javafx.binding >> - com.sun.javafx.collections >> - javafx.beans >> - javafx.beans.binding >> - javafx.collections >> - javafx.collections.transformation > > John Hendrikx has updated the pull request

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v3]

2023-01-03 Thread Nir Lisker
simply expand and collapse the root note repeatedly > while it has a child. Before the fix the graphic will disappear after a few > tries, after the fix it won't. You can test other hierarchies as well by > adding children to the tree. Nir Lisker has updated the pull request incremental

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v2]

2023-01-03 Thread Nir Lisker
On Tue, 3 Jan 2023 23:39:36 GMT, Andy Goryachev wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added copyright header and changed package name > > tests/performance/check

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing [v2]

2023-01-03 Thread Nir Lisker
simply expand and collapse the root note repeatedly > while it has a child. Before the fix the graphic will disappear after a few > tries, after the fix it won't. You can test other hierarchies as well by > adding children to the tree. Nir Lisker has updated the pull request incremental

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-03 Thread Nir Lisker
On Tue, 3 Jan 2023 23:11:08 GMT, John Hendrikx wrote: > Looks good to me, releasing the graphic for empty cells. I'm left wondering > if it should also be releasing the bindings it makes in that case, although > that's less likely to cause (visible) issues. I could make that change. I don't

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-03 Thread Nir Lisker
On Tue, 3 Jan 2023 23:07:19 GMT, Andy Goryachev wrote: >> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after >> expand/collapse events. The graphics node needs to be released from the >> previous checkbox so that it doesn't serve as the graphics of more than one >>

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-03 Thread Nir Lisker
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote: > A simple fix for the graphics of a `CheckBoxTreeCell` not showing after > expand/collapse events. The graphics node needs to be released from the > previous checkbox so that it doesn't serve as the graphics of more than one &

Re: CFV: New OpenJFX Committer: John Hendrikx

2023-01-03 Thread Nir Lisker
Vote: YES On Tue, Jan 3, 2023 at 5:18 PM Kevin Rushforth wrote: > Vote: YES > > On 1/3/2023 7:17 AM, Kevin Rushforth wrote: > > I hereby nominate John Hendrikx [1] to OpenJFX Committer. > >

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages [v2]

2023-01-02 Thread Nir Lisker
On Sun, 1 Jan 2023 15:04:17 GMT, John Hendrikx wrote: >> modules/javafx.base/src/main/java/com/sun/javafx/binding/BidirectionalContentBinding.java >> line 81: >> >>> 79: if ((obj1 instanceof ObservableList list1) && (obj2 >>> instanceof ObservableList list2)) { >>> 80:

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages [v2]

2023-01-02 Thread Nir Lisker
On Sun, 1 Jan 2023 15:23:16 GMT, John Hendrikx wrote: >> modules/javafx.base/src/main/java/javafx/collections/FXCollections.java line >> 709: >> >>> 707: private static class EmptyObservableList extends >>> AbstractList implements ObservableList { >>> 708: >>> 709: private static

Re: RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-01 Thread Nir Lisker
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote: > A simple fix for the graphics of a `CheckBoxTreeCell` not showing after > expand/collapse events. The graphics node needs to be released from the > previous checkbox so that it doesn't serve as the graphics of more than one &

RFR: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing

2023-01-01 Thread Nir Lisker
A simple fix for the graphics of a `CheckBoxTreeCell` not showing after expand/collapse events. The graphics node needs to be released from the previous checkbox so that it doesn't serve as the graphics of more than one checkbox at once. If it does, only one checkbox (its skin) can actually use

Re: Concatenated observable list

2022-12-31 Thread Nir Lisker
We can do better than that. Instead of introducing methods for specific operations, like concat and retain, we can offer bulk operations on collections. When John H. proposed the fluent bindings additions, we discussed doing the same for collections after that. At the very least, we can have a

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages

2022-12-30 Thread Nir Lisker
On Sun, 11 Dec 2022 20:12:17 GMT, John Hendrikx wrote: > Packages fixed: > - com.sun.javafx.binding > - com.sun.javafx.collections > - javafx.beans > - javafx.beans.binding > - javafx.collections > - javafx.collections.transformation Second part of the review. I'm still looking at the changes

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages

2022-12-30 Thread Nir Lisker
On Mon, 26 Dec 2022 14:32:52 GMT, John Hendrikx wrote: >> modules/javafx.base/src/main/java/javafx/beans/binding/ListExpression.java >> line 238: >> >>> 236: public Iterator iterator() { >>> 237: final ObservableList list = get(); >>> 238: return (list == null)? >>>

Re: RTOS inmate misses interrupts

2022-12-29 Thread Nir Geller
. What would be the implications on performance? Thanks a lot, Nir. On Wed, Dec 14, 2022 at 11:09 AM Rasty Slutsker wrote: > Hi, > Exactly I reference to 'jailhouse cell stats' > We enabled TSC in Hypervisor init, and printed value to dmsg. > But *after* start of Linux it gets di

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages

2022-12-28 Thread Nir Lisker
On Sun, 11 Dec 2022 20:12:17 GMT, John Hendrikx wrote: > Packages fixed: > - com.sun.javafx.binding > - com.sun.javafx.collections > - javafx.beans > - javafx.beans.binding > - javafx.collections > - javafx.collections.transformation This is the first half of the review. Will finish the classes

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v7]

2022-12-28 Thread Nir Lisker
On Thu, 1 Sep 2022 15:03:18 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed review comment > > LGTM, > suggested a minor correction in comment. > I

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v11]

2022-12-24 Thread Nir Lisker
oved the ambient color interpolation, which frees a register (no > change in performance). > * Simplified the structure (what is `LocalBumpOut` and why is it called > `light` and contains `LocalBump`?). > * `Mtl1PS` and `psMath` > * Moved the shader variant constants (`#ifndef`)

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v10]

2022-12-24 Thread Nir Lisker
oved the ambient color interpolation, which frees a register (no > change in performance). > * Simplified the structure (what is `LocalBumpOut` and why is it called > `light` and contains `LocalBump`?). > * `Mtl1PS` and `psMath` > * Moved the shader variant constants (`#ifndef`)

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v9]

2022-12-24 Thread Nir Lisker
On Sun, 25 Dec 2022 03:28:27 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time i

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v9]

2022-12-24 Thread Nir Lisker
oved the ambient color interpolation, which frees a register (no > change in performance). > * Simplified the structure (what is `LocalBumpOut` and why is it called > `light` and contains `LocalBump`?). > * `Mtl1PS` and `psMath` > * Moved the shader variant constants (`#ifndef`)

Re: [Puppet Users] Create a variable out of a bash command and notify it

2022-12-18 Thread Nir Fishler
2022 at 10:02:09 AM UTC+2 Nir Fishler wrote: > Thanks a lot guys for your prompt reply! > > Gonna try it out later on. > > On Monday, December 5, 2022 at 9:47:52 AM UTC+2 dhei...@opentext.com > wrote: > >> Am Sonntag, dem 04.12.2022 um 07:43 -0800 schrieb Nir Fishler: &

Re: [Puppet Users] Puppet filters

2022-12-18 Thread Nir Fishler
Perfect! Thanks Martin. On Sunday, December 18, 2022 at 10:35:59 AM UTC+2 Martin Alfke wrote: > Hi Nir, > > do you only need the capacity from the root file system? > > You can access the data hash directly: > $facts['mountpoints']['/']['capacity'] > > hth, > Mar

[Puppet Users] Puppet filters

2022-12-17 Thread Nir Fishler
evice => /dev/mapper/ubuntu--vg-ubuntu--lv, filesystem => ext4, options => [rw, relatime], size_bytes => 262901354496, available_bytes => 240302788608, used_bytes => 11734274048, capacity => 4.66%, size => 244.85 GiB, available => 223.80 GiB, used => 10.93 GiB}}' Wha

Re: Setting graphics of a Labeled does not show the Label correctly

2022-12-17 Thread Nir Lisker
://bugs.openjdk.org/browse/JDK-8119175 On Mon, Dec 12, 2022 at 6:10 PM Nir Lisker wrote: > Another idea is to use a static map that maps a node to its "graphic > parent". That will save on memory at the expense of a lookup. > > On Thu, Dec 1, 2022 at 11:53 PM Nir Lisker wrote:

Re: [PATCH v2 2/5] Support format or cache specific out file

2022-12-13 Thread Nir Soffer
On Tue, Dec 13, 2022 at 8:09 PM Hanna Reitz wrote: > > On 13.12.22 16:56, Nir Soffer wrote: > > On Mon, Dec 12, 2022 at 12:38 PM Hanna Reitz wrote: > >> On 28.11.22 15:15, Nir Soffer wrote: > >>> Extend the test finder to find tests with format (*.o

Re: [PATCH v2 2/5] Support format or cache specific out file

2022-12-13 Thread Nir Soffer
On Tue, Dec 13, 2022 at 8:09 PM Hanna Reitz wrote: > > On 13.12.22 16:56, Nir Soffer wrote: > > On Mon, Dec 12, 2022 at 12:38 PM Hanna Reitz wrote: > >> On 28.11.22 15:15, Nir Soffer wrote: > >>> Extend the test finder to find tests with format (*.o

Re: [PATCH v2 2/5] Support format or cache specific out file

2022-12-13 Thread Nir Soffer
On Mon, Dec 12, 2022 at 12:38 PM Hanna Reitz wrote: > > On 28.11.22 15:15, Nir Soffer wrote: > > Extend the test finder to find tests with format (*.out.qcow2) or cache > > specific (*.out.nocache) out file. This worked before only for the > > numbered tests. > >

Re: [PATCH v2 2/5] Support format or cache specific out file

2022-12-13 Thread Nir Soffer
On Mon, Dec 12, 2022 at 12:38 PM Hanna Reitz wrote: > > On 28.11.22 15:15, Nir Soffer wrote: > > Extend the test finder to find tests with format (*.out.qcow2) or cache > > specific (*.out.nocache) out file. This worked before only for the > > numbered tests. > >

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v8]

2022-12-12 Thread Nir Lisker
oved the ambient color interpolation, which frees a register (no > change in performance). > * Simplified the structure (what is `LocalBumpOut` and why is it called > `light` and contains `LocalBump`?). > * `Mtl1PS` and `psMath` > * Moved the shader variant constants (`#ifndef`)

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v7]

2022-12-12 Thread Nir Lisker
On Thu, 1 Sep 2022 11:23:44 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time i

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v14]

2022-12-12 Thread Nir Lisker
On Mon, 12 Dec 2022 22:42:16 GMT, John Hendrikx wrote: >> This PR adds a new (lazy*) property on `Node` which provides a boolean which >> indicates whether or not the `Node` is currently part of a `Scene`, which in >> turn is part of a currently showing `Window`. >> >> It also adds a new

Re: Setting graphics of a Labeled does not show the Label correctly

2022-12-12 Thread Nir Lisker
Another idea is to use a static map that maps a node to its "graphic parent". That will save on memory at the expense of a lookup. On Thu, Dec 1, 2022 at 11:53 PM Nir Lisker wrote: > Are we convinced that a node can't be both a graphic and a clip, or > something else? The docs

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v12]

2022-12-11 Thread Nir Lisker
On Sun, 11 Dec 2022 20:31:24 GMT, John Hendrikx wrote: >> This PR adds a new (lazy*) property on `Node` which provides a boolean which >> indicates whether or not the `Node` is currently part of a `Scene`, which in >> turn is part of a currently showing `Window`. >> >> It also adds a new

Re: RFR: JDK-8298200 Clean up raw type warnings in javafx.beans.property.* and com.sun.javafx.property.* [v4]

2022-12-11 Thread Nir Lisker
On Sun, 11 Dec 2022 14:30:22 GMT, John Hendrikx wrote: >> - Added generics (to package private or internal classes only) >> - Minor clean-ups of code I touched (naming) >> - Fixed incorrect use of generics >> - Fixed raw type warnings >> >> Note: some raw types have leaked into public API.

Re: RFR: JDK-8298200 Clean up raw type warnings in javafx.beans.property.* and com.sun.javafx.property.* [v3]

2022-12-10 Thread Nir Lisker
On Sat, 10 Dec 2022 08:23:07 GMT, John Hendrikx wrote: >> - Added generics (to package private or internal classes only) >> - Minor clean-ups of code I touched (naming) >> - Fixed incorrect use of generics >> - Fixed raw type warnings >> >> Note: some raw types have leaked into public API.

Re: RFR: JDK-8298200 Clean up raw type warnings in javafx.beans.property.* and com.sun.javafx.property.* [v2]

2022-12-10 Thread Nir Lisker
On Sat, 10 Dec 2022 08:18:34 GMT, John Hendrikx wrote: >>> So... it's also a list. >> >> I think it's a big mess, you can already see that in the hierarchy, >> extending both `ObservableObjectValue>` (which is >> `ObservableValue`) but also being a `ObservableList`. One or the >> other is

Re: RFR: JDK-8298200 Clean up raw type warnings in javafx.beans.property.* and com.sun.javafx.property.* [v2]

2022-12-09 Thread Nir Lisker
On Fri, 9 Dec 2022 20:11:24 GMT, John Hendrikx wrote: >> I suggest the following method: >> >> >> @Override >> public boolean equals(Object obj) { >> if (this == obj) { >> return true; >> } >> if (!(obj instanceof List otherList)) { >>

Re: RFR: JDK-8298200 Clean up raw type warnings in javafx.beans.property.* and com.sun.javafx.property.* [v2]

2022-12-09 Thread Nir Lisker
On Fri, 9 Dec 2022 18:35:57 GMT, John Hendrikx wrote: >> It's safe as you're never actually using the type `E`, but I suppose the 2nd >> list can also be `List` as only `equals` is called on it. The 2nd >> `ListIterator` would then also be `ListIterator`. >> >> Casting to a specific generic

Re: RFR: JDK-8298200 Clean up raw type warnings in javafx.beans.property.* and com.sun.javafx.property.* [v2]

2022-12-09 Thread Nir Lisker
On Thu, 8 Dec 2022 14:21:45 GMT, John Hendrikx wrote: >> - Added generics (to package private or internal classes only) >> - Minor clean-ups of code I touched (naming) >> - Fixed incorrect use of generics >> - Fixed raw type warnings >> >> Note: some raw types have leaked into public API.

Re: [Gen-art] Genart last call review of draft-ietf-cdni-additional-footprint-types-04

2022-12-07 Thread Nir Sopher
Thanks David for reviewing the document :) Cheers, Sanjay and Nir On Thu, Dec 1, 2022 at 6:16 PM David Schinazi via Datatracker < nore...@ietf.org> wrote: > Reviewer: David Schinazi > Review result: Ready > > I am the assigned Gen-ART reviewer for this draft. The General Area

Re: RFR: JDK-8298200 Clean up raw type warnings in javafx.beans.property.* and com.sun.javafx.property.*

2022-12-07 Thread Nir Lisker
On Wed, 7 Dec 2022 13:25:47 GMT, Kevin Rushforth wrote: >> - Added generics (to package private or internal classes only) >> - Minor clean-ups of code I touched (naming) >> - Fixed incorrect use of generics >> - Fixed raw type warnings >> >> Note: some raw types have leaked into public API.

Re: RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v4]

2022-12-05 Thread Nir Lisker
On Wed, 30 Nov 2022 12:55:08 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/UploadingPainter.java >> line 41: >> >>> 39: * The PresentingPainter is used when we are rendering to the main >>> screen. >>> 40: */ >>> 41: final class

Re: RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v2]

2022-12-05 Thread Nir Lisker
On Wed, 30 Nov 2022 12:48:10 GMT, Kevin Rushforth wrote: >> If the casts in the numerator actually matter, then the cast in the >> denominator can be removed. The latter are the ones that Eclipse flags for >> me as unnecessary. > > I still think that any change here would be a very low value

Re: RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v4]

2022-12-05 Thread Nir Lisker
On Mon, 5 Dec 2022 22:20:59 GMT, John Hendrikx wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix indentations and merge short lines > >> This is one giant pull request, somewhat difficult on the reviewers, >>

Re: RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v4]

2022-12-05 Thread Nir Lisker
On Tue, 6 Dec 2022 03:03:13 GMT, Andy Goryachev wrote: >> The code was already broken (since 2014 apparently when the new Base64 >> decoder was used). Had the author turned on these handy warnings, they >> would have noticed that something was amiss. Now they unwittingly changed >> the

Re: RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v4]

2022-12-05 Thread Nir Lisker
On Mon, 5 Dec 2022 20:17:04 GMT, Andy Goryachev wrote: >> I do agree with @kevinrushforth here. >> >> It might be borderline useful to enable the warning once just to see if >> there are any bugs or perhaps to clean up the most obvious cases, but it >> probably makes little sense to enable

Re: RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v4]

2022-12-05 Thread Nir Lisker
On Mon, 5 Dec 2022 21:40:40 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFile.java >> line 586: >> >>> 584: ascent = -(float)hhea.getShort(4); >>> 585: descent = -(float)hhea.getShort(6); >>> 586:

Re: RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v4]

2022-12-05 Thread Nir Lisker
On Mon, 5 Dec 2022 21:46:12 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/javafx/css/CssParser.java line 2579: >> >>> 2577: term = nextLayer(lastTerm); >>> 2578: } >>> 2579: return new ParsedValueImpl<>(layers, >>>

Re: Warnings

2022-12-05 Thread Nir Lisker
I have been working with John on the effort to remove warnings, so obviously I agree with these. I'd like to add a few points: * There is flexibility in how to tell the comp[iler to mark these possible problems. Some warnings can be turned into errors for stricter standards, and I think that this

Re: RFR: 8238968: Inconsisent formatting of Rectangle2D toString method

2022-12-05 Thread Nir Lisker
On Mon, 5 Dec 2022 10:50:56 GMT, Lukasz Kostyra wrote: > The string was fixed to match other parameters' formatting. > > There was a PR submitted for this change a long time ago, but there were some > issue with its previous author. Today I found the issue being assigned to me, > so I figured

Re: [Puppet Users] Create a variable out of a bash command and notify it

2022-12-05 Thread Nir Fishler
Thanks a lot guys for your prompt reply! Gonna try it out later on. On Monday, December 5, 2022 at 9:47:52 AM UTC+2 dhei...@opentext.com wrote: > Am Sonntag, dem 04.12.2022 um 07:43 -0800 schrieb Nir Fishler: > > Main goal: get a list of upgrade-able packages and notify the u

Re: RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v4]

2022-12-04 Thread Nir Lisker
On Sat, 3 Dec 2022 20:54:04 GMT, John Hendrikx wrote: >> - Remove unsupported/unnecessary SuppressWarning annotations >> - Remove reduntant type specifications (use diamond operator) >> - Remove unused or duplicate imports >> - Remove unnecessary casts (type is already correct type or can be

[Puppet Users] Create a variable out of a bash command and notify it

2022-12-04 Thread Nir Fishler
Hello, I'd like to store an output of a bash command into a variable, and then print it to stdout using notify in Puppet. Main goal: get a list of upgrade-able packages and notify the user about it. I have tried the below but it doesn't seem to work: $pkgs_list = $("/usr/bin/apt --simulate

[ovirt-users] Re: How does ovirt handle disks across multiple iscsi LUNs

2022-12-04 Thread Nir Soffer
al volume /dev/mapper/0QEMU_QEMU_HARDDISK_data-fc-01 Physical extents 177 to 205 Logical extents 1649 to 1679: Type linear Physical volume /dev/mapper/0QEMU_QEMU_HARDDISK_data-fc-01 Physical extents 531 to 561 I hope it helps. Nir ___ Users

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v9]

2022-12-02 Thread Nir Lisker
On Fri, 2 Dec 2022 09:10:34 GMT, John Hendrikx wrote: >> I didn't look too far for alternative names after I discovered `showing` >> would not be possible. The name comes from `isTreeShowing` which is used >> for a similar purpose (inside `Node`) and from `conditionOnShowing` in >> ReactFX.

Re: Setting graphics of a Labeled does not show the Label correctly

2022-12-01 Thread Nir Lisker
ralize the clipParent field to function for both (the ownedBy or owner > field that I suggested earlier)? > > --John > On 01/12/2022 20:26, Nir Lisker wrote: > > Michael's idea could solve the problem if it's about more than just > traversing, it needs to set rules for allowing a nod

Re: Setting graphics of a Labeled does not show the Label correctly

2022-12-01 Thread Nir Lisker
can do a quick fix for now that can be reverted later if needed. From what I gather, I will need to add a graphicsParent field like clipParent does. On Thu, Dec 1, 2022 at 8:47 PM Nir Lisker wrote: > By the way, these issues are caused by this inconsistent behavior (they > are probably dupl

Re: Setting graphics of a Labeled does not show the Label correctly

2022-12-01 Thread Nir Lisker
By the way, these issues are caused by this inconsistent behavior (they are probably duplicates): https://bugs.openjdk.org/browse/JDK-8209017 https://bugs.openjdk.org/browse/JDK-8190331 The graphic of the checkbox of a CheckBoxTreeItem is not set correctly on the new CheckBox that is provided

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v9]

2022-12-01 Thread Nir Lisker
On Thu, 1 Dec 2022 17:38:01 GMT, John Hendrikx wrote: >> This PR adds a new (lazy*) property on `Node` which provides a boolean which >> indicates whether or not the `Node` is currently part of a `Scene`, which in >> turn is part of a currently showing `Window`. >> >> It also adds a new

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-01 Thread Nir Lisker
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. It requires only 1 reviewer with the tole of Reviewer. One of you can be the second reviewer.

Re: Setting graphics of a Labeled does not show the Label correctly

2022-12-01 Thread Nir Lisker
in the scene graph, otherwise > * the {@code IllegalArgumentException} is thrown. See the class > * description of {@link Node} for more detail. > > --John > On 01/12/2022 13:38, Nir Lisker wrote: > > That's my point. Currently, a node can serve as the graphics property for

Re: Setting graphics of a Labeled does not show the Label correctly

2022-12-01 Thread Nir Lisker
; > I think things are probably getting out of sync, where the graphics > property may think it still has a certain node as its graphics, but it > is no longer a child of the label. > > --John > > On 01/12/2022 11:23, Nir Lisker wrote: > > Hi, > > > > Given

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v8]

2022-12-01 Thread Nir Lisker
On Wed, 26 Oct 2022 07:56:52 GMT, John Hendrikx wrote: >> This PR adds a new (lazy*) property on `Node` which provides a boolean which >> indicates whether or not the `Node` is currently part of a `Scene`, which in >> turn is part of a currently showing `Window`. >> >> It also adds a new

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v6]

2022-12-01 Thread Nir Lisker
On Wed, 26 Oct 2022 06:52:17 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 1426: >> >>> 1424: if (s == null) return false; >>> 1425: Window w = s.getWindow(); >>> 1426: return w != null && w.isShowing(); >> >> Are you

Setting graphics of a Labeled does not show the Label correctly

2022-12-01 Thread Nir Lisker
aphics for multiple Labeled nodes, but it will appear only in 1. Is this intentional? - Nir

<    1   2   3   4   5   6   7   8   9   10   >