On Tue, 22 Nov 2022 21:30:09 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
> line 418:
On Tue, 29 Nov 2022 17:11:51 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
> line 422:
On Tue, 29 Nov 2022 21:58:38 GMT, John Hendrikx wrote:
>> Note: I ran into a `javac` compiler bug while replacing types with diamond
>> operators (ecj has no issues). I had two options, add a
>> `SuppressWarnings("unused")` or to use a lambda instead of a method
>> reference to make `javac`
On Tue, 29 Nov 2022 18:37:23 GMT, Kevin Rushforth wrote:
>> interesting - there is technically no change, as `TableColumnBase`
>> implements `EventTarget`.
>> @hjohn does javadoc produce a different result?
>
> I checked, and yes it does produce a different result:
>
> Current:
>
>
> public
On Mon, 28 Nov 2022 17:04:17 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be
5s ±0.183s | 1.808s ±0.016s | x1.36 |
| nbd | 6g | direct| 3.540s ±0.020s | 1.749s ±0.018s | x2.02 |
[1] raw image full of zeroes
[2] raw fedora 35 image with additional random data, 50% full
[3] image [2] exported by qemu-nbd via unix socket
Signed-off-by: Nir Soffer
---
qemu-i
This macro is used by various commands (compare, convert, rebase) but it
is defined somewhere in the middle of the file. I'm going to use it in
the new checksum command so lets clean up a bit before that.
---
qemu-img.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
debugging in case of failures, the output includes a json map of
the test image.
Signed-off-by: Nir Soffer
---
tests/qemu-iotests/tests/qemu-img-checksum| 63 +++
.../tests/qemu-img-checksum.out.qcow2 | 11
.../tests/qemu-img-checksum.out.raw | 10 +++
3
ng checksum for 8T empty image: qemu-img checksum: 3.7s,
sha256sum (estimate): 17,749s
Signed-off-by: Nir Soffer
---
docs/tools/qemu-img.rst | 24 ++
meson.build | 10 ++-
meson_options.txt | 2 +
qemu-img-cmds.hx| 8 ++
qemu-img.c | 183 +
Extend the test finder to find tests with format (*.out.qcow2) or cache
specific (*.out.nocache) out file. This worked before only for the
numbered tests.
---
tests/qemu-iotests/findtests.py | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
tml
- https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00171.html
- https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00173.html
Nir Soffer (5):
qemu-img.c: Move IO_BUF_SIZE to the top of the file
Support format or cache specific out file
qemu-img: Add checksum command
iote
tml
- https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00171.html
- https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00173.html
Nir Soffer (5):
qemu-img.c: Move IO_BUF_SIZE to the top of the file
Support format or cache specific out file
qemu-img: Add checksum command
iote
5s ±0.183s | 1.808s ±0.016s | x1.36 |
| nbd | 6g | direct| 3.540s ±0.020s | 1.749s ±0.018s | x2.02 |
[1] raw image full of zeroes
[2] raw fedora 35 image with additional random data, 50% full
[3] image [2] exported by qemu-nbd via unix socket
Signed-off-by: Nir Soffer
---
qemu-i
debugging in case of failures, the output includes a json map of
the test image.
Signed-off-by: Nir Soffer
---
tests/qemu-iotests/tests/qemu-img-checksum| 63 +++
.../tests/qemu-img-checksum.out.qcow2 | 11
.../tests/qemu-img-checksum.out.raw | 10 +++
3
Extend the test finder to find tests with format (*.out.qcow2) or cache
specific (*.out.nocache) out file. This worked before only for the
numbered tests.
---
tests/qemu-iotests/findtests.py | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
ng checksum for 8T empty image: qemu-img checksum: 3.7s,
sha256sum (estimate): 17,749s
Signed-off-by: Nir Soffer
---
docs/tools/qemu-img.rst | 24 ++
meson.build | 10 ++-
meson_options.txt | 2 +
qemu-img-cmds.hx| 8 ++
qemu-img.c | 183 +
This macro is used by various commands (compare, convert, rebase) but it
is defined somewhere in the middle of the file. I'm going to use it in
the new checksum command so lets clean up a bit before that.
---
qemu-img.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
On Mon, Nov 7, 2022 at 1:41 PM Hanna Reitz wrote:
> On 30.10.22 18:38, Nir Soffer wrote:
> > On Wed, Oct 26, 2022 at 4:31 PM Hanna Reitz wrote:
> >
> > On 01.09.22 16:32, Nir Soffer wrote:
> > > Add simple tests creating an image with all kinds
On Mon, Nov 7, 2022 at 1:41 PM Hanna Reitz wrote:
> On 30.10.22 18:38, Nir Soffer wrote:
> > On Wed, Oct 26, 2022 at 4:31 PM Hanna Reitz wrote:
> >
> > On 01.09.22 16:32, Nir Soffer wrote:
> > > Add simple tests creating an image with all kinds
On Mon, Nov 7, 2022 at 12:20 PM Hanna Reitz wrote:
> On 30.10.22 18:37, Nir Soffer wrote:
> > On Wed, Oct 26, 2022 at 4:00 PM Hanna Reitz wrote:
> >
> > On 01.09.22 16:32, Nir Soffer wrote:
> [...]
> > > ---
> > > docs/tools/qemu-i
On Mon, Nov 7, 2022 at 12:20 PM Hanna Reitz wrote:
> On 30.10.22 18:37, Nir Soffer wrote:
> > On Wed, Oct 26, 2022 at 4:00 PM Hanna Reitz wrote:
> >
> > On 01.09.22 16:32, Nir Soffer wrote:
> [...]
> > > ---
> > > docs/tools/qemu-i
On Tue, 22 Nov 2022 22:33:49 GMT, Kevin Rushforth wrote:
>> (long) width * height * 4;
>> is dangerous if one does not remember the precedence rules - is typecast
>> applied to width or the end result?
>> 4L * w * h; is unambiguous.
>
> I'm not sure I like either of the two choices you listed.
On Wed, 23 Nov 2022 07:26:31 GMT, John Hendrikx wrote:
>> Actually, I think the new code correct, though less clear, since `(long)` is
>> applied to `physicalWidth` before the multiplication. The fact that we had
>> to scratch our head and discuss it highlights the point I was trying to
>>
On Tue, 22 Nov 2022 18:39:43 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Wed, 23 Nov 2022 23:06:45 GMT, John Hendrikx wrote:
>> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/ControlSkinFactory.java
>> line 287:
>>
>>> 285: .map(d -> new Object[] {d, })
>>> 286: .collect(toList());
>>> 287:
On Thu, 24 Nov 2022 00:12:04 GMT, Andy Goryachev wrote:
> It makes no sense to enable the warning and not fix all the warnings in the
> code. I would like to see 0 warnings in the problem list.
The warning is for all unnecessary casts, which removes a lot of clutter. If,
in some special
On Tue, 22 Nov 2022 18:39:43 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx wrote:
>> Note: I ran into a `javac` compiler bug while replacing types with diamond
>> operators (ecj has no issues). I had two options, add a
>> `SuppressWarnings("unused")` or to use a lambda instead of a method
>> reference to make `javac`
On Tue, 22 Nov 2022 19:04:00 GMT, Kevin Rushforth wrote:
>> Not needed in the setup, if it is `null` later or throws an exception the
>> test failure is clear enough.
>>
>> Also a bit out of scope of this PR.
>
> Yes, adding an assert does seem out of scope of this PR, although Andy
> comment
On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx wrote:
>> Note: I ran into a `javac` compiler bug while replacing types with diamond
>> operators (ecj has no issues). I had two options, add a
>> `SuppressWarnings("unused")` or to use a lambda instead of a method
>> reference to make `javac`
On Tue, 22 Nov 2022 18:48:41 GMT, John Hendrikx wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/FXVKSkin.java
>> line 858:
>>
>>> 856: protected void sendKeyEvents() {
>>> 857: Node target = fxvk.getAttachedNode();
>>> 858:
>>
>> same
On Tue, 22 Nov 2022 18:52:32 GMT, John Hendrikx wrote:
>> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
>>
>>> 1444: @Override
>>> 1445: public void processEndElement() throws IOException {
>>> 1446: super.processEndElement();
>>
>> I
On Tue, 22 Nov 2022 16:43:06 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be
On Tue, 22 Nov 2022 16:49:52 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be
On Tue, 22 Nov 2022 11:13:40 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 22:28:15 GMT, Kevin Rushforth wrote:
> treating certain categories of warnings as errors at compilation time is
> quite feasible. The JDK does this.
I have "missing override annotations" set to errors in my projects. I think
it's a good candidate here.
-
PR:
My proposal in the PR was 'updateWhen', which I prefer over observedWhen
and activeWhen. Just 'when' is also fine by me and prefered over 'when'.
My only problem with 'when'/'whenever' is that they don't say what happens
"when"/"whenever". However, since these are bindings, and what bindings do
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 20:49:07 GMT, Andy Goryachev wrote:
>> but the ticket specifies (javafx.)base, right?
>
> let's create a followup ticket - the messed up statements in Disposer and
> especially in PrismFontFactory:1401 are worrying.
>
> cc: @prrace
All of the bugs in the list are not in
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
On Mon, 21 Nov 2022 15:19:24 GMT, Kevin Rushforth wrote:
> The main thing to be careful of is that we don't touch any public API
> signatures, since some of these sort of automated changes can have impact
> that we would need to consider.
This set of warnings doesn't change method signatures.
On Mon, 21 Nov 2022 11:53:30 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be
by other
selections. I find it odd because this doesn't make the item really
independent, and I can't think of a use case for this one-sided independent
behavior.
In any case, I think that the documentation should clarify these points, so
I would like to know what the behavior should be.
- Nir
I think that even if a node is set to indeterminate programmatically, its
parents should be updated at the very least (unless it's set to be
independent). Not updating the children seems reasonable.
On Fri, Nov 18, 2022 at 11:12 AM John Hendrikx
wrote:
>
> On 18/11/2022 00:10, Nir Lisker
nt doesn't.
- Nir
.org/display/OpenJFX/Building+OpenJFX, or at least
should be, as it isn't an Eclipse-specific step. There is a mention of this
in the Using Eclipse section.
On Tue, Nov 15, 2022 at 6:54 PM Andy Goryachev
wrote:
> Nir, thank you so much!
>
>
>
> A few minor corrections might be need
On Sun, 13 Nov 2022 02:27:55 GMT, John Hendrikx wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix controls classpath
I updated
Is https://bugs.openjdk.org/browse/JDK-8275033 related?
On Tue, Nov 15, 2022 at 2:14 AM Thiago Milczarek Sayão <
thiago.sa...@gmail.com> wrote:
> I took a look at it, and It seems "by design".
> Child stages can be larger, it just can't cover the desktop bar.
> If you run in a kiosk style setup
On Sun, 13 Nov 2022 02:27:55 GMT, John Hendrikx wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix controls classpath
Marked as reviewed by nlisker (Reviewer).
On Sun, 13 Nov 2022 01:43:30 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary add-exports attribute from Eclipse files
>
> tests/manual/deskto
On Sat, 12 Nov 2022 20:38:49 GMT, John Hendrikx wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove unnecessary add-exports attribute from Eclipse files
On Mon, 7 Nov 2022 08:32:22 GMT, John Hendrikx wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update Eclipse classpath files
>
> - Stripped dependencies to a
On Mon, 7 Nov 2022 16:29:42 GMT, Ambarish Rapte wrote:
>> This issue was uncovered when running the test added in PR:
>> https://github.com/openjdk/jfx/pull/910
>> The JUnit5 tests using Params API fails to compile.
>>
>> Fix:
>> Change dependency of `junit-jupiter-params` from runtime to
Vote: YES
On Mon, Nov 7, 2022 at 11:19 AM Ajit Ghaisas
wrote:
> Vote : Yes
>
> Regards,
> Ajit
>
> > On 03-Nov-2022, at 10:35 PM, Kevin Rushforth
> wrote:
> >
> > I hereby nominate Andy Goryachev [1] to OpenJFX Committer.
> >
> > Andy is a member of the JavaFX team at Oracle who has
On Sat, 22 Oct 2022 07:49:12 GMT, John Hendrikx wrote:
> See https://bugs.openjdk.org/browse/JDK-8221708
The new changes look good. I get a bogus error marker on the apps folder in
Project Explorer, but in Package Explorer there is no error. Looks like some
Eclipse hiccup.
My only comment is
On Sat, 22 Oct 2022 07:49:12 GMT, John Hendrikx wrote:
> See https://bugs.openjdk.org/browse/JDK-8221708
Alright, we'll go with option 2 then and keep option 3 for further research.
The new changes look fine, I'll do a formal review soon.
-
PR:
ing a closed
> build, but I doubt this change will cause problems. Maybe Andy can check? As
> Nir mentioned, people can (and do) name the root directory whatever they want
> and it doesn't seem to matter to Eclipse other than it looks a little odd. I
> agree with the general point that
On Fri, 28 Oct 2022 21:18:54 GMT, Nir Lisker wrote:
>>> but that's another issue for another time.
>>
>> I respectfully disagree - the initial import (with all the documented extra
>> steps) should result in a clean state - as it is currently with the master
&
On Fri, 28 Oct 2022 20:49:47 GMT, Andy Goryachev wrote:
> > but that's another issue for another time.
>
> I respectfully disagree - the initial import (with all the documented extra
> steps) should result in a clean state - as it is currently with the master
> branch.
But this patch just
On Wed, 26 Oct 2022 23:34:39 GMT, Kevin Rushforth wrote:
> The swt-debug.jar library is copied to build/libs as part of gradle sdk, so
> it's at least available (maybe just needs to be pointed to)?
I previously added it to the project's classpath and the error wasn't being
resolved so I
the current discrepancy, I gather, is that the current
project file in the repo was checked in when the project was on Mercurial with
a different folder name, and now that the folder name has changed in GitHub we
get this "conflict".
> (also, Nir, you have some .classpath modified in yo
On Wed, 26 Oct 2022 11:16:19 GMT, Kevin Rushforth wrote:
>> I've rebased this on master. For some reason I mistakenly based this on
>> some old version of master.
>>
>> I do notice the same kind of problems Andy experienced. Eclipse can give
>> many errors when switching branches. Closing
ntral Plugin Repository
If the artifacts are trustworthy, you will need to update the
gradle/verification-metadata.xml file by following the instructions at
https://docs.gradle.org/7.3/userguide/dependency_verification.html#sec:troubleshooting-verification
Open this report for more details:
file:///C:/U
On Sat, 22 Oct 2022 07:49:12 GMT, John Hendrikx wrote:
> See https://bugs.openjdk.org/browse/JDK-8221708
This is the review for /apps.
apps itself is a gradle project as specific in the root project build.gradle
file. I think that a gradle file should be generated there and the gradle
nature
orted.")
> blank()
> example("h = nbd.NBD()", "Create a new handle.")
> -if False: # args.uri is None:
>
Good that this was removed, but it will be better to remove in the previous
patch.
Nir
___
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs
t; example("h = nbd.NBD()", "Create a new handle.")
> -if args.uri is None:
> +if False: # args.uri is None:
>
If False will never run, so why not remove the entire branch?
Is this leftover from debugging?
Nir
__
tdb and puppetserver?
> On Open Source we usually recommend the puppetlabs-puppetdb module.
>
>
> On 31. Oct 2022, at 10:39, Nir Fishler wrote:
>
> Hey Martin,
>
> Thanks for your reply.
>
> There are three files underneath that directory:
>
>- puppetdb-access.
Very nice! Was the technical session recorded? Were there any interesting
questions in the Q?
On Tue, Nov 1, 2022 at 11:16 PM Kevin Rushforth
wrote:
> JavaOne 2022 was the week of Oct 17-20, and there were two sessions of
> interest to JavaFX:
>
> * During the technical keynote [1], I announced
Hey Martin,
Thanks for your reply.
There are three files underneath that directory:
- puppetdb-access.log
- puppetdb.log
- puppetdb-status.log
but all seem to be empty - 0kb
what does that mean?
On Monday, October 10, 2022 at 11:03:05 AM UTC+3 Martin Alfke wrote:
> Hi
Hi, folks.
As you know, we have a 90-minute session on Wednesday, November 9th at 15:00.
In addition to all the document status and solemn recitation of the Note Well,
we have so far received 4 requests for agenda time:
From Hang Shi about draft-ls-6man-ipcomp-exclude-transport-layer, a
On Sun, Oct 30, 2022 at 7:38 PM Nir Soffer wrote:
> On Wed, Oct 26, 2022 at 4:54 PM Hanna Reitz wrote:
>
>> On 01.09.22 16:32, Nir Soffer wrote:
>>
> [...]
> > +/* The current chunk. */
>> > +int64_t offset;
>> > +int64_t length;
>>
On Sun, Oct 30, 2022 at 7:38 PM Nir Soffer wrote:
> On Wed, Oct 26, 2022 at 4:54 PM Hanna Reitz wrote:
>
>> On 01.09.22 16:32, Nir Soffer wrote:
>>
> [...]
> > +/* The current chunk. */
>> > +int64_t offset;
>> > +int64_t length;
>>
On Wed, Oct 26, 2022 at 4:00 PM Hanna Reitz wrote:
> On 01.09.22 16:32, Nir Soffer wrote:
> > The checksum command compute a checksum for disk image content using the
> > blkhash library[1]. The blkhash library is not packaged yet, but it is
> > available via copr[2]
On Wed, Oct 26, 2022 at 4:54 PM Hanna Reitz wrote:
> On 01.09.22 16:32, Nir Soffer wrote:
> > Add coroutine based loop inspired by `qemu-img convert` design.
> >
> > Changes compared to `qemu-img convert`:
> >
> > - State for the entire image is kept in
On Wed, Oct 26, 2022 at 4:54 PM Hanna Reitz wrote:
> On 01.09.22 16:32, Nir Soffer wrote:
> > Add coroutine based loop inspired by `qemu-img convert` design.
> >
> > Changes compared to `qemu-img convert`:
> >
> > - State for the entire image is kept in
On Wed, Oct 26, 2022 at 4:31 PM Hanna Reitz wrote:
> On 01.09.22 16:32, Nir Soffer wrote:
> > Add simple tests creating an image with all kinds of extents, different
> > formats, different backing chain, different protocol, and different
> > image options. Since all image
On Wed, Oct 26, 2022 at 4:31 PM Hanna Reitz wrote:
> On 01.09.22 16:32, Nir Soffer wrote:
> > Add simple tests creating an image with all kinds of extents, different
> > formats, different backing chain, different protocol, and different
> > image options. Since all image
On Wed, Oct 26, 2022 at 4:00 PM Hanna Reitz wrote:
> On 01.09.22 16:32, Nir Soffer wrote:
> > The checksum command compute a checksum for disk image content using the
> > blkhash library[1]. The blkhash library is not packaged yet, but it is
> > available via copr[2]
://github.com/nirs/userstorage/pull/29/checks?check_run_id=9125092601
Looks like very little effort to improve all projects!
If you wandered what signed-off-by means, this is explained here:
https://wiki.linuxfoundation.org/dco
Nir
___
Devel
e advances on the implementation.
[1] https://openjdk.org/jeps/431
[2] https://bugs.openjdk.org/browse/JDK-8266572
On Tue, May 31, 2022 at 12:02 AM Nir Lisker wrote:
> Then maybe a solution would be around adding new methods like
> observableKeySet(). These will need to be default methods, and the
On Tue, 25 Oct 2022 21:06:15 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains ten commits:
>>
>> - Merge remote-tracking branch 'origin/master' into
>>
On Thu, 29 Sep 2022 15:02:13 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
On Thu, 29 Sep 2022 15:02:13 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
unrelated to the development here:
Gradle variant - https://github.com/openjfx/javafx-gradle-plugin
Maven variant - https://github.com/openjfx/javafx-maven-plugin
On Fri, Oct 21, 2022 at 1:29 AM Thomas Reinhardt
wrote:
> Thanks Nir for the links to the other discussions. I got the thing to
f them for
> all platforms (dll for windows, so for linux, dylib for mac). I'm
> pretty sure I used this exact same jar to run my software on windows and
> linux. Never tested mac as I don't own one.
>
> My pom therefore includes all three, like Nir Lisker has, and my shaded
&g
:
>
> Hi Nir,
>
> Does not work (I testet it) and it can not work (see below).
>
> Also, this is exactly what my naive test was (I did not use maven to
> copy the artifacts, but the result obviously is the same).
>
> It can not work as the implementation classes have the same
Hi Thomas,
Did you try to just specify the platform-specific dependencies in the POM?
org.openjfx
javafx-graphics
19
win
org.openjfx
javafx-graphics
19
linux
org.openjfx
javafx-graphics
On Wed, 19 Oct 2022 20:45:41 GMT, Andy Goryachev wrote:
>> I actually like `asLongAs` that was mentioned in another comment, but it
>> looks odd :)
>>
>> Lately, as I was reading some unrelated codebases and I came up with
>> `updateWhile` (or `updateWhen`). The reason is that names like
On Fri, 14 Oct 2022 16:19:02 GMT, Andy Goryachev wrote:
>> Changing the documentation for `When` should not be part of this PR I think.
>> What we should do maybe is add a note that this method should not be
>> confused with `Bindings.when`. I'll let others weigh in.
>
> I like `conditionOn`.
On Tue, 18 Oct 2022 18:44:58 GMT, Andy Goryachev wrote:
>>> I'd respectfully disagree: in a large application, there might be hundreds
>>> (a thousand?) Nodes, and only a handful (10-20?) Nodes with this property
>>> (2%), so it's a waste of RAM. One may think it's only 8Kb on a 64 bit
>>>
On Wed, 19 Oct 2022 12:51:21 GMT, Douglas Held wrote:
>> The JavaDoc for equals had a copy/paste error. I normalized the text based
>> on the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting
>> in the method signatures of equals(), hashCode() and toString().~~
>>
>> For
On Wed, 19 Oct 2022 12:46:03 GMT, Douglas Held wrote:
> I think there's something else of quality worth discussing here. Is `==`
> appropriate given the values under comparison are `double`?
It's not. I have mentioned this exact case in
https://bugs.openjdk.org/browse/JDK-8226930. I can
On Wed, 19 Oct 2022 12:38:54 GMT, Douglas Held wrote:
>> modules/javafx.graphics/src/main/java/javafx/geometry/Point3D.java line 417:
>>
>>> 415: * {@code getX}, {@code getY}, and {@code getZ} methods are equal.
>>> 416: *
>>> 417: * @param {@code obj} the reference object with
On Wed, 19 Oct 2022 12:33:37 GMT, Douglas Held wrote:
> I thought the code tags produced hyperlinks.
Those would be the `@link` tags, or `@linkplain`.
-
PR: https://git.openjdk.org/jfx/pull/913
On Wed, 19 Oct 2022 12:34:15 GMT, Douglas Held wrote:
>> The JavaDoc for equals had a copy/paste error. I normalized the text based
>> on the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting
>> in the method signatures of equals(), hashCode() and toString().~~
>>
>> For
Dear Sunny and SIG members
Firstly, I would like to thank outgoing Zhen Yu for his contribution on the NIR
SIG forum. He contributed much for NIR SIG Forum for many years, and hope that
Zhen will keep supporting the NIR SIG forum in the future.
Secondly, Congratulations to Gaurav Kansal
On Tue, 18 Oct 2022 22:15:35 GMT, Douglas Held wrote:
>> The JavaDoc for equals had a copy/paste error. I normalized the text based
>> on the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting
>> in the method signatures of equals(), hashCode() and toString().~~
>>
>> For
On Tue, 18 Oct 2022 17:47:38 GMT, Michael Strauß wrote:
>> I'd respectfully disagree: in a large application, there might be hundreds
>> (a thousand?) Nodes, and only a handful (10-20?) Nodes with this property
>> (2%), so it's a waste of RAM. One may think it's only 8Kb on a 64 bit
>>
On Sun, Sep 18, 2022 at 12:35 PM Nir Soffer wrote:
> ping
>
> Kevin, Hanna, I hope you have time to take a look.
>
> https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00021.html
Ping again, hopefully someone has time to look at this :-)
>
>
>
> On Thu,
501 - 600 of 10085 matches
Mail list logo
