On Sun, Sep 18, 2022 at 12:35 PM Nir Soffer wrote:
> ping
>
> Kevin, Hanna, I hope you have time to take a look.
>
> https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00021.html
Ping again, hopefully someone has time to look at this :-)
>
>
>
> On Thu,
On Thu, 1 Sep 2022 11:23:44 GMT, Nir Lisker wrote:
>> Refactoring and renaming changes to some of the D3D pipeline files and a few
>> changes on the Java side. These are various "leftovers" from previous issues
>> that we didn't want to touch at the time i
On Tue, 18 Oct 2022 04:47:38 GMT, Ambarish Rapte wrote:
>> I think that we should explain what makes 2 objects equal. Even if we don't
>> explicitly name the methods used for comparison, we could say "2 points are
>> equals if their coordinates are equal".
>>
>> By the way, I have
On Mon, 17 Oct 2022 15:24:48 GMT, Ambarish Rapte wrote:
>> ...correction, found in toString() as well.
>
> It would be suitable to align with our existing doc comment in other classes,
> for example as here,
>
> 1.
>
On Fri, 14 Oct 2022 15:08:24 GMT, Douglas Held wrote:
>> Not strictly enforced, but adding a blank line does aid readability (of the
>> source code...the generated docs don't care).
>
> If I were to add empty lines before JavaDoc tags such as @param etc, then for
> consistency I think I should
On Wed, 12 Oct 2022 17:28:42 GMT, Douglas Held wrote:
> The JavaDoc for equals had a copy/paste error. I normalized the text based on
> the JavaDoc for method java.awt.Point#equals. I also changed formatting in
> the method signatures of equals(), hashCode() and toString().
>
> For good
(), value
> -> { ... } );
>
> They can then be released all at once by doing:
>
> subscription.unsubscribe();
>
> Reading your proposal I see you might be looking to support weak
> listeners as well. Personally, I believe these are better replaced with
> lazy list
rmat conversion.
Example usage:
ovirt-img upload-disk --engine-url https://example.com \
--username username \
--password-file /path/to/password-file \
--cafile ca.pem \
--storage-domain mydomain \
/path/to/iso
See ovirt-im upload-disk --help for more op
wice.
Looks like improper behavior to me.
- Nir
On Thu, 22 Sep 2022 11:04:46 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
On Thu, 22 Sep 2022 20:33:44 GMT, Andy Goryachev wrote:
>> Adding a tests/.classpath file to include tests/manual/controls source
>> folder so Eclipse could see/execute manual tests there.
>>
>> Also, I would rather move the sources there to a specific package
>> (test.manual ?) instead of a
On Thu, 15 Sep 2022 21:55:20 GMT, Andy Goryachev wrote:
> Adding a tests/.classpath file to include tests/manual/controls source folder
> so Eclipse could see/execute manual tests there.
>
> Also, I would rather move the sources there to a specific package
> (test.manual ?) instead of a
On Thu, 15 Sep 2022 21:55:20 GMT, Andy Goryachev wrote:
> Adding a tests/.classpath file to include tests/manual/controls source folder
> so Eclipse could see/execute manual tests there.
>
> Also, I would rather move the sources there to a specific package
> (test.manual ?) instead of a
On Sun, 4 Sep 2022 19:49:42 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
ping
Kevin, Hanna, I hope you have time to take a look.
https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00021.html
On Thu, Sep 1, 2022 at 5:32 PM Nir Soffer wrote:
>
> Since blkhash is available only via copr now, the new command is added as
> optional feature, b
ping
Kevin, Hanna, I hope you have time to take a look.
https://lists.nongnu.org/archive/html/qemu-block/2022-09/msg00021.html
On Thu, Sep 1, 2022 at 5:32 PM Nir Soffer wrote:
>
> Since blkhash is available only via copr now, the new command is added as
> optional feature, b
On Thu, 15 Sep 2022 11:52:00 GMT, Jens Lidestrom wrote:
>> Prior to this change it was not clear from the documentation if callers of
>> Platform#runLater must perform
>> any synchronisation to have writes of the calling thread be visible in the
>> JavaFX Application
>> Thread. It is important
Hi Mike,
Nir from Meta and Noah's peer.
would it be possible to give an estimate or a guideline on the permissible
magnitude of usage for the Opt-In trial (the one that forces the full
reduction of the UserAgent) available?
As we would like to conduct an experiment on that, and not deviate
On Thu, 1 Sep 2022 13:51:21 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
On Thu, 1 Sep 2022 13:10:49 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java
>> line 266:
>>
>>> 264: * {@code condition} evaluates to {@code true}. This allows this
>>> {@code ObservableValue}
>>> 265: * and the conditional
On Thu, 1 Sep 2022 13:38:46 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java
>> line 274:
>>
>>> 272: *
>>> 273: * Returning {@code null} from the given condition is treated the
>>> same as
>>> 274: * returning {@code
5s ±0.183s | 1.808s ±0.016s | x1.36 |
| nbd | 6g | direct| 3.540s ±0.020s | 1.749s ±0.018s | x2.02 |
[1] raw image full of zeroes
[2] raw fedora 35 image with additional random data, 50% full
[3] image [2] exported by qemu-nbd via unix socket
Signed-off-by: Nir Soffer
---
qemu-i
ng checksum for 8T empty image: qemu-img checksum: 3.7s,
sha256sum (estimate): 17,749s
Signed-off-by: Nir Soffer
---
docs/tools/qemu-img.rst | 22 +
meson.build | 10 ++-
meson_options.txt | 2 +
qemu-img-cmds.hx| 8 ++
qemu-img.c | 191 +
Since blkhash is available only via copr now, the new command is added as
optional feature, built only if blkhash-devel package is installed.
Nir Soffer (3):
qemu-img: Add checksum command
iotests: Test qemu-img checksum
qemu-img: Speed up checksum
docs/tools/qemu-img.rst
includes a json map of
every test image.
Signed-off-by: Nir Soffer
---
tests/qemu-iotests/tests/qemu-img-checksum| 149 ++
.../qemu-iotests/tests/qemu-img-checksum.out | 74 +
2 files changed, 223 insertions(+)
create mode 100755 tests/qemu-iotests/tests/qemu-img
ng checksum for 8T empty image: qemu-img checksum: 3.7s,
sha256sum (estimate): 17,749s
Signed-off-by: Nir Soffer
---
docs/tools/qemu-img.rst | 22 +
meson.build | 10 ++-
meson_options.txt | 2 +
qemu-img-cmds.hx| 8 ++
qemu-img.c | 191 +
5s ±0.183s | 1.808s ±0.016s | x1.36 |
| nbd | 6g | direct| 3.540s ±0.020s | 1.749s ±0.018s | x2.02 |
[1] raw image full of zeroes
[2] raw fedora 35 image with additional random data, 50% full
[3] image [2] exported by qemu-nbd via unix socket
Signed-off-by: Nir Soffer
---
qemu-i
includes a json map of
every test image.
Signed-off-by: Nir Soffer
---
tests/qemu-iotests/tests/qemu-img-checksum| 149 ++
.../qemu-iotests/tests/qemu-img-checksum.out | 74 +
2 files changed, 223 insertions(+)
create mode 100755 tests/qemu-iotests/tests/qemu-img
Since blkhash is available only via copr now, the new command is added as
optional feature, built only if blkhash-devel package is installed.
Nir Soffer (3):
qemu-img: Add checksum command
iotests: Test qemu-img checksum
qemu-img: Speed up checksum
docs/tools/qemu-img.rst
On Thu, 1 Sep 2022 05:35:09 GMT, Ambarish Rapte wrote:
>> I still don't understand. What is `VertexType`? I see a comment on `VsInput`
>> "// this is a .hlsl mirror of the vertex format, see VertexTypes.h". If the
>> gradle file has `"/DVertexType=VsInput"`, shouldn't it be fine with
>>
oved the ambient color interpolation, which frees a register (no
> change in performance).
> * Simplified the structure (what is `LocalBumpOut` and why is it called
> `light` and contains `LocalBump`?).
> * `Mtl1PS` and `psMath`
> * Moved the shader variant constants (`#ifndef`)
On Fri, 15 Jul 2022 09:27:00 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
On Fri, 15 Jul 2022 09:07:07 GMT, John Hendrikx wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename showing property to shown as it is already used in subclasses
>
>
On Tue, 30 Aug 2022 20:35:17 GMT, Andy Goryachev wrote:
> it might affect the initial 'import as a gradle project', and associated
> testing.
I removed it and didn't have any issue with this. The classpath file is not
used when importing a project, just when it's configured, and in this case
On Tue, 30 Aug 2022 19:09:40 GMT, Andy Goryachev wrote:
> I wouldn't do it - it is convenient for git operations via context menu and
> also gives access to other non-java parts (doc-files for instance).
>
> But the main issue is that it is has a
>
On Tue, 23 Aug 2022 18:38:48 GMT, Andy Goryachev wrote:
> This change affects eclipse projects only - all eclipse projects are
> configured to use JUnit5.
Marked as reviewed by nlisker (Reviewer).
Please submit an issue for removing the root project's classpath file.
The 2 future changes to
On Fri, 26 Aug 2022 17:34:41 GMT, Ambarish Rapte wrote:
>> What do you mean by "revert the type function parameter here"? Doesn't the
>> type parameter match after a change to the gradle file?
>
>> What do you mean by "revert the type function parameter here"?
>
> `VsOutput main(VsInput
On Thu, 25 Aug 2022 22:18:44 GMT, Michael Strauß wrote:
>> `Node` adds InvalidationListeners to its parent's `disabled` and
>> `treeVisible` properties and calls its own `updateDisabled()` and
>> `updateTreeVisible(boolean)` methods when the property values change.
>>
>> These listeners are
On Thu, 25 Aug 2022 13:46:26 GMT, Kevin Rushforth wrote:
>> Since `getChildren()` is not final, one can easily override it and return
>> null.
>> Therefore, this check should still be done here.
>> Maybe we even need to check that every child is not null, since again I can
>> override
On Thu, 21 Jul 2022 04:43:15 GMT, Michael Strauß wrote:
> `Node` adds InvalidationListeners to its parent's `disabled` and
> `treeVisible` properties and calls its own `updateDisabled()` and
> `updateTreeVisible(boolean)` methods when the property values change.
>
> These listeners are not
On Tue, 23 Aug 2022 18:38:48 GMT, Andy Goryachev wrote:
> This change affects eclipse projects only - all eclipse projects are
> configured to use JUnit5.
Not the `base` module, the root one, called "jfx" or "rt".
-
PR: https://git.openjdk.org/jfx/pull/883
On Tue, 23 Aug 2022 18:38:48 GMT, Andy Goryachev wrote:
> This change affects eclipse projects only - all eclipse projects are
> configured to use JUnit5.
I don't see why the base project needs a `.classpath` file at all considering
that it doesn't contain sources.
-
PR:
On Tue, 2 Aug 2022 17:38:06 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed method
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/vs2ps.h line 2
oved the ambient color interpolation, which frees a register (no
> change in performance).
> * Simplified the structure (what is `LocalBumpOut` and why is it called
> `light` and contains `LocalBump`?).
> * `Mtl1PS` and `psMath`
> * Moved the shader variant constants (`#ifndef`)
On Tue, 2 Aug 2022 15:10:50 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed method
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/Mtl1VS.hl
On Thu, 18 Aug 2022 23:52:48 GMT, Nir Lisker wrote:
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
This pull request has now been integrated.
Changeset: 8b967765
Author: Nir Lisker
URL:
https://git.openjdk.org/jfx/com
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comment
-
Changes:
- all: https://git.openjdk.org/jfx/pull/880/files
-
On Tue, 23 Aug 2022 15:36:35 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review c
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/880/fi
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/880/fi
On Mon, 22 Aug 2022 22:21:29 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>
> modules/javafx.graphics/src/main/java/javafx/concurrent/ScheduledServi
On Fri, 19 Aug 2022 00:18:37 GMT, Nir Lisker wrote:
> Added docs for inherited methods in `Bindings` subclasses.
This pull request has now been integrated.
Changeset: 5c007833
Author: Nir Lisker
URL:
https://git.openjdk.org/jfx/commit/5c00783352940b08f6254d2250524ef804984267
St
On Sat, 20 Aug 2022 00:27:32 GMT, Kevin Rushforth wrote:
>> Added docs for inherited methods in `Bindings` subclasses.
>
> modules/javafx.base/src/main/java/javafx/beans/binding/Bindings.java line 174:
>
>> 172: /**
>> 173: * Returns an immutable list of the
On Fri, 19 Aug 2022 00:18:37 GMT, Nir Lisker wrote:
> Added docs for inherited methods in `Bindings` subclasses.
I don't mind either way. I initially bundled it with the issue for fixing API
docs, but decoupled it later and just thought it would be fine to do them both.
The changes are v
On Fri, 19 Aug 2022 14:54:11 GMT, Andy Goryachev wrote:
> Would these changes require a CSR? Or, since they are just corrections, the
> API did not really change? Otherwise, looks good. Thank you for cleaning up
> the docs!
Usually they don't since there are no spec changes.
-
On Thu, 18 Aug 2022 19:21:39 GMT, Nir Lisker wrote:
> Simple fixes for the inherited method docs.
Closed in favor of #881.
-
PR: https://git.openjdk.org/jfx/pull/878
> Simple fixes for the inherited method docs.
Nir Lisker has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains 19 new commits
since the l
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Fix typo
-
Changes:
- all: https://git.openjdk.org/jfx/pull/880/files
- new: ht
Simple fixes for the inherited method docs.
-
Commit messages:
- Initial commit
- 8290473: update Eclipse .classpath in apps, buildSrc
- 8181084: JavaFX show big icons in system menu on macOS with Retina display
- 8291908: VirtualFlow creates unneeded empty cells
- 8291630:
Fixes the mistakes in the JBS ticket and some additional minor corrections.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jfx/pull/880/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=880=00
Issue: https://bugs.openjdk.org/browse/JDK-8286678
Stats: 30
On Thu, 18 Aug 2022 23:43:33 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differen
On Thu, 18 Aug 2022 19:08:19 GMT, Nir Lisker wrote:
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jfx/pull/877
On Thu, 18 Aug 2022 23:43:33 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has refreshed the contents of this pull request, and previous
> commits have been removed. Incremental views are not available.
`g
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains
On Thu, 18 Aug 2022 19:08:19 GMT, Nir Lisker wrote:
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Looks like the rebase missed a few commits. Not sure why.
-
PR: https://git.openjdk.org/jfx/pull/877
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains
On Thu, 18 Aug 2022 19:08:19 GMT, Nir Lisker wrote:
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
It's a PR against the javafx19 branch. I think I forked the master branch
though, which is why it is showing all the commits. I might need to reb
On Wed, 17 Aug 2022 22:22:02 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
On Wed, 17 Aug 2022 22:22:02 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
On Wed, 17 Aug 2022 22:17:30 GMT, Kevin Rushforth wrote:
>> For lucene, you'd need to run
>
>> For lucene, you'd need to run
>>
>> ```
>> /bin/sh gradlew getLucene
>> ```
>>
>> to bring in the dependencies which are not a part of the repository.
>
> Btw, `gradle apps` will also work.
If
On Tue, 9 Aug 2022 21:43:04 GMT, Andy Goryachev wrote:
> Thank you all! If there are no more objections, I'd like to get this
> integrated, as it will save me from duplicate branches and continuous
> cherry-picking.
You don't need to do that. Unless 2 branches work on the same code, there
On Tue, 16 Aug 2022 15:58:38 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
On Mon, 15 Aug 2022 10:03:11 GMT, Nir Lisker wrote:
>> Command to run the system test:
>> `gradle -PFULL_TEST=true -PUSE_ROBOT=true systemTests:test --tests
>> test.robot.test3d.PointLightIlluminationTest`
>>
>> I ran all the tests, only above test failed:
&g
Nodejs, Rust, F sharp, Selenium... those are indeed some questionable
entries for JavaFX.
On Tue, Aug 16, 2022 at 6:25 PM John Neffenger wrote:
> On 8/15/22 10:18 PM, Nir Lisker wrote:
> > I also have entries there that don't exist. I suspect they have to do
> > with building We
at 1:26 AM John Neffenger wrote:
> On 8/15/22 12:32 AM, Nir Lisker wrote:
> > (I have '%SystemRoot%\system32' which is exported to Cygwin correctly).
>
> That works, too. I have to admit, my troubles on Windows at the time
> were self-inflicted. I was trying to reduce my PATH to it
On Tue, 2 Aug 2022 10:57:25 GMT, Ambarish Rapte wrote:
>> I'll have a look. What command did you run this test with?
>>
>> Can you also test the point light attenuation under
>> `tests\system\src\test\java\test\javafx\scene\lighting3D\PointLightAttenuationTest.java`?
>> (I think there's a bit
is exported to Cygwin correctly). The
properties file was still wrong and caused errors.
I also run gradle builds from Eclipse, so Cygwin isn't always used.
On Sun, Aug 14, 2022 at 8:13 PM John Neffenger wrote:
> On 8/13/22 7:29 AM, Nir Lisker wrote:
> > I figured out that that err
VS150COMNTOOLS: "C:\\Program Files\\Microsoft Visual
> Studio\\2022\\Enterprise\\VC\\Auxiliary\\Build"
>
> -- Kevin
>
>
> On 8/12/2022 8:06 PM, Nir Lisker wrote:
>
> Kevin, can you update the windows_tools.properties file for the build page
> on the wiki [1] for
Kevin, can you update the windows_tools.properties file for the build page
on the wiki [1] for VS 2022 since I see that we updated to use that version?
[1] https://wiki.openjdk.org/pages/viewpage.action?pageId=66650334
On Sat, Aug 13, 2022 at 2:06 AM Nir Lisker wrote:
> I see the file un
n
>
>
> On 8/12/2022 2:12 PM, Nir Lisker wrote:
> > Hi,
> >
> > I have just run gradle clean and gradle build, and I'm getting an error:
> >
> > C:/Program Files (x86)/Windows
> > Kits/10/include/10.0.17763.0/ucrt\corecrt.h(10): fatal error C108
to update something,
like VS?
- Nir
[
https://issues.apache.org/jira/browse/FLINK-28933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nir Tsruya updated FLINK-28933:
---
Summary: Support ON CONFLICT DO NOTHING in flink-jdbc-connector for
Postgresql dialect
Nir Tsruya created FLINK-28933:
--
Summary: Support ON CONFLICT DO NOTHING in flink-jdbc-connector
Key: FLINK-28933
URL: https://issues.apache.org/jira/browse/FLINK-28933
Project: Flink
Issue
Nir Tsruya created FLINK-28933:
--
Summary: Support ON CONFLICT DO NOTHING in flink-jdbc-connector
Key: FLINK-28933
URL: https://issues.apache.org/jira/browse/FLINK-28933
Project: Flink
Issue
On Tue, 2 Aug 2022 18:01:06 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed method
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/vs2ps.h
On Tue, 9 Aug 2022 15:11:49 GMT, Kevin Rushforth wrote:
>> This is up to Kevin. It's changing the build file specifically to remove a
>> warning for Eclipse Mac users. I don't mind. Might need to do the same for
>> the other OS-specific folders.
>
> While not ideal, I suppose it's OK. I'm
On Mon, 8 Aug 2022 15:38:35 GMT, Andy Goryachev wrote:
>> On Linux there is no such warning., neither is there on Windows if I add a
>> non-existing folder (to simulate the ones for other OS's). I posted the
>> screenshots on the mailing list. If Eclipse for Mac is the only one
>> producing
On Mon, 8 Aug 2022 15:21:58 GMT, Andy Goryachev wrote:
>> I agree that an optional dependency for a platform-specific generated source
>> directory is a much better solution than creating an empty dir.
>
> @kevinrushforth :
> Eclipse does not support conditionals in the .classpath files. The
On Sat, 6 Aug 2022 13:22:17 GMT, Kevin Rushforth wrote:
>> As @kleopatra noted below, you need to add the hlsl folders that are built
>> on Windows. Add them as an optional source to avoid errors on other OS's:
>>
>>
>>
>>
>>
>>
>>
>> And the same for
>> ``
>>
On Mon, 1 Aug 2022 19:34:11 GMT, Andy Goryachev wrote:
>> buildSrc/.classpath line 10:
>>
>>> 8: >> path="../build/libs/antlr-runtime-3.1.3.jar"/>
>>> 9: >> path="../build/libs/stringtemplate-3.2.jar"/>
>>> 10: >> path="../build/libs/swt-debug.jar"/>
>>
>> Why does buildSrc need to be a
On Mon, 1 Aug 2022 19:30:28 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/.classpath line 5:
>>
>>> 3:
>>> 4:
>>> 5:
>>
>> How do you not get errors on these on Mac/Linux if they are not declared
>> optional?
>>
>> Additionally, you need the hlsl folders as shown in the mailing
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in
On Tue, 2 Aug 2022 07:36:11 GMT, Ambarish Rapte wrote:
>> Yes, in `PsMath.h::computeLight`, there is a check if the light requests
>> attenuation. In general, this is done only for directional lights (that are
>> not attenuated), but in this case we know that this point light is not
>>
oved the ambient color interpolation, which frees a register (no
> change in performance).
> * Simplified the structure (what is `LocalBumpOut` and why is it called
> `light` and contains `LocalBump`?).
> * `Mtl1PS` and `psMath`
> * Moved the shader variant constants (`#ifndef`)
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
I'm don't think that this is the right approach with the apps. I think that
each app should be its own project. See the branch I linked in the previous PR.
I
But that has no effect on previous JavaFX builds, I don't see a retroactive
value here.
>
oved the ambient color interpolation, which frees a register (no
> change in performance).
> * Simplified the structure (what is `LocalBumpOut` and why is it called
> `light` and contains `LocalBump`?).
> * `Mtl1PS` and `psMath`
> * Moved the shader variant constants (`#ifndef`)
On Fri, 29 Jul 2022 21:48:00 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/native-p
On Fri, 17 Jun 2022 14:27:58 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/mai
On Fri, 17 Jun 2022 09:04:41 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/nativ
601 - 700 of 10085 matches
Mail list logo
