Re: [Libguestfs] [PATCH libnbd 8/8] copy: Adaptive queue size

On Wed, Feb 23, 2022 at 3:29 PM Richard W.M. Jones wrote: > > On Wed, Feb 23, 2022 at 02:53:47PM +0200, Nir Soffer wrote: > > I'll send more patches for the suggested improvements next week. > > I'd like to an upstream stable release early next week, ideally Monday > if poss

Re: [Libguestfs] [PATCH libnbd 8/8] copy: Adaptive queue size

On Tue, Feb 22, 2022 at 1:48 PM Nir Soffer wrote: > > On Mon, Feb 21, 2022 at 5:41 PM Eric Blake wrote: > > > > On Sun, Feb 20, 2022 at 02:14:03PM +0200, Nir Soffer wrote: > > > Limit the size of the copy queue also by the number of queued bytes. > > > Thi

Re: [Libguestfs] [PATCH libnbd 8/8] copy: Adaptive queue size

On Mon, Feb 21, 2022 at 5:41 PM Eric Blake wrote: > > On Sun, Feb 20, 2022 at 02:14:03PM +0200, Nir Soffer wrote: > > Limit the size of the copy queue also by the number of queued bytes. > > This allows using many concurrent small requests, required to get good > > p

Re: [Libguestfs] [PATCH libnbd 4/8] copy: Separate finishing a command from freeing it

On Mon, Feb 21, 2022 at 5:08 PM Eric Blake wrote: > > On Sun, Feb 20, 2022 at 02:13:59PM +0200, Nir Soffer wrote: > > free_command() was abused as a completion callback. Introduce > > finish_command() completion callback, so code that want to free a > > command does not

Re: [Libguestfs] [PATCH libnbd 3/8] copy: Extract create_command and create_buffer helpers

On Mon, Feb 21, 2022 at 5:03 PM Eric Blake wrote: > > On Sun, Feb 20, 2022 at 02:13:58PM +0200, Nir Soffer wrote: > > Creating a new command requires lot of boilerplate that makes it harder > > to focus on the interesting code. Extract a helpers to create a command, > &g

Re: [Libguestfs] [PATCH libnbd 2/8] copy: Rename copy_subcommand to create_subcommand

On Mon, Feb 21, 2022 at 4:52 PM Eric Blake wrote: > > On Sun, Feb 20, 2022 at 02:13:57PM +0200, Nir Soffer wrote: > > copy_subcommand creates a new command without copying the original > > command. Rename the function to make this more clear. > > > > Signed-off-by:

Re: [Libguestfs] [PATCH libnbd 1/8] copy: Remove wrong references to holes

On Mon, Feb 21, 2022 at 4:51 PM Eric Blake wrote: > > On Sun, Feb 20, 2022 at 02:13:56PM +0200, Nir Soffer wrote: > > In the past nbdcopy was looking for hole extents instead of zero > > extents. When we fixed this, we forgot to update some comments and > > variable names

Re: [TLS] tlsflags and "responses"

I have just submitted PR #20 to allow unacknowledged flags. It is a rewrite of section 3 (rules) https://github.com/tlswg/tls-flags/pull/20 It still requires that the flag extension not be sent when empty. Let me know if that’s a problem as well.

Re: [Libguestfs] [PATCH libnbd 7/8] copy: Track worker queue size

On Mon, Feb 21, 2022 at 12:17 PM Richard W.M. Jones wrote: > > On Mon, Feb 21, 2022 at 08:28:54AM +0200, Nir Soffer wrote: > > On Sun, Feb 20, 2022 at 8:53 PM Richard W.M. Jones > > wrote: > > > > > > On Sun, Feb 20, 2022 at 02:14:02PM +0200, Nir Soffe

Re: [Libguestfs] [PATCH libnbd 7/8] copy: Track worker queue size

On Sun, Feb 20, 2022 at 8:53 PM Richard W.M. Jones wrote: > > On Sun, Feb 20, 2022 at 02:14:02PM +0200, Nir Soffer wrote: > > +static inline void > > +increase_queue_size(struct worker *worker, size_t len) > > ^ space > > and the same in the

[Libguestfs] [PATCH libnbd 8/8] copy: Adaptive queue size

16m-2% --- fedora/ro laptop 2.0401.663 1m +23% fedora/ro server 1.5851.393 2m +14% Signed-off-by: Nir Soffer --- copy/main.c | 52 +++

[Libguestfs] [PATCH libnbd 7/8] copy: Track worker queue size

be faster with lower number of requests. Signed-off-by: Nir Soffer --- copy/multi-thread-copying.c | 33 + copy/nbdcopy.h | 6 ++ 2 files changed, 39 insertions(+) diff --git a/copy/multi-thread-copying.c b/copy/multi-thread-copying.c index 8ba721fe

[Libguestfs] [PATCH libnbd 6/8] copy: Keep worker pointer in command

Replace the command index with a worker pointer. The nbd-ops access the index via the worker pointer. This allows commands to modify worker state during processing. Signed-off-by: Nir Soffer --- copy/multi-thread-copying.c | 12 ++-- copy/nbd-ops.c | 6 +++--- copy

[Libguestfs] [PATCH libnbd 2/8] copy: Rename copy_subcommand to create_subcommand

copy_subcommand creates a new command without copying the original command. Rename the function to make this more clear. Signed-off-by: Nir Soffer --- copy/multi-thread-copying.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/copy/multi

[Libguestfs] [PATCH libnbd 4/8] copy: Separate finishing a command from freeing it

free_command() was abused as a completion callback. Introduce finish_command() completion callback, so code that want to free a command does not have to add dummy errors. This will make it easier to manage worker state when a command completes. Signed-off-by: Nir Soffer --- copy/multi-thread

[Libguestfs] [PATCH libnbd 3/8] copy: Extract create_command and create_buffer helpers

simpler. This change is a refactoring except fixing perror() message for calloc() failure. Signed-off-by: Nir Soffer --- copy/multi-thread-copying.c | 87 +++-- 1 file changed, 54 insertions(+), 33 deletions(-) diff --git a/copy/multi-thread-copying.c b/copy/multi

[Libguestfs] [PATCH libnbd 0/8] nbdcopy: Adaptive queue size

, and cleaned up the completion flow and other stuff. I think these cleanups are a good idea even if we do not add adaptive queue size. Nir Soffer (8): copy: Remove wrong references to holes copy: Rename copy_subcommand to create_subcommand copy: Extract create_command and create_buffer

[Libguestfs] [PATCH libnbd 5/8] copy: Introduce worker struct

* pointer. The worker struct is used only by the multi-threading-copy module, but in future patch I want to keep the worker pointer in the command, to allow commands to update worker state when they finish. Signed-off-by: Nir Soffer --- copy/file-ops.c | 4 +-- copy/main.c

[Libguestfs] [PATCH libnbd 1/8] copy: Remove wrong references to holes

In the past nbdcopy was looking for hole extents instead of zero extents. When we fixed this, we forgot to update some comments and variable names referencing hole instead of zero. Signed-off-by: Nir Soffer --- copy/multi-thread-copying.c | 34 +- 1 file changed

[ovirt-users] Re: Random reboots

On Thu, Feb 17, 2022 at 11:58 AM Nir Soffer wrote: > > On Thu, Feb 17, 2022 at 11:20 AM Pablo Olivera wrote: > > > > Hi Nir, > > > > > > Thank you very much for your detailed explanations. > > > > The pid 6398 looks like it's HostedEngine: >

[ovirt-users] Re: Random reboots

On Thu, Feb 17, 2022 at 11:20 AM Pablo Olivera wrote: > > Hi Nir, > > > Thank you very much for your detailed explanations. > > The pid 6398 looks like it's HostedEngine: > > audit/audit.log:type=VIRT_CONTROL msg=audit(1644587639.935:7895): pid=3629 > uid=0 auid=429

[ovirt-users] Re: Random reboots

On Wed, Feb 16, 2022 at 9:18 PM Nir Soffer wrote: > > On Wed, Feb 16, 2022 at 5:12 PM Nir Soffer wrote: > > > > On Wed, Feb 16, 2022 at 10:10 AM Pablo Olivera wrote: > > > > > > Hi community, > > > > > > We're dealing with an issue as w

[ovirt-users] Re: Random reboots

On Wed, Feb 16, 2022 at 5:12 PM Nir Soffer wrote: > > On Wed, Feb 16, 2022 at 10:10 AM Pablo Olivera wrote: > > > > Hi community, > > > > We're dealing with an issue as we occasionally have random reboots on > > any of our hosts. > > We're using

Re: [PATCH v2] nbd/server: Allow MULTI_CONN for shared writable exports

On Wed, Feb 16, 2022 at 10:08 AM Vladimir Sementsov-Ogievskiy wrote: > > 16.02.2022 02:24, Eric Blake wrote: > > On Tue, Feb 15, 2022 at 09:23:36PM +0200, Nir Soffer wrote: > >> On Tue, Feb 15, 2022 at 7:22 PM Eric Blake wrote: > >> > >>> Accor

Re: [PATCH v2] nbd/server: Allow MULTI_CONN for shared writable exports

On Wed, Feb 16, 2022 at 10:08 AM Vladimir Sementsov-Ogievskiy wrote: > > 16.02.2022 02:24, Eric Blake wrote: > > On Tue, Feb 15, 2022 at 09:23:36PM +0200, Nir Soffer wrote: > >> On Tue, Feb 15, 2022 at 7:22 PM Eric Blake wrote: > >> > >>> Accor

[ovirt-users] Re: Random reboots

PM. I guess this host was running the hosted engine vm, which uses a storage lease. If you lose access to storage, sanlcok will kill the hosted engine vm, so the system can start it elsewhere. If the hosted engine vm is stuck on storage, sanlock can

Re: [PATCH v2] nbd/server: Allow MULTI_CONN for shared writable exports

nce that timestamp was updated. Additionally we keep and report the number of inflight requests, so we can tell the case when requests are blocked on inaccessible storage (e.g. non responsive NFS). We don't have a way to do this with qemu-nbd, but I guess that using qemu-storage-daemon when we have qmp access will make such monitoring possible. Nir

Re: [PATCH v2] nbd/server: Allow MULTI_CONN for shared writable exports

nce that timestamp was updated. Additionally we keep and report the number of inflight requests, so we can tell the case when requests are blocked on inaccessible storage (e.g. non responsive NFS). We don't have a way to do this with qemu-nbd, but I guess that using qemu-storage-daemon when we have qmp access will make such monitoring possible. Nir

Re: [PATCH v2] nbd/server: Allow MULTI_CONN for shared writable exports

sec and XXX ops/sec) > +{"execute":"qmp_capabilities"} > +{"return": {}} > +{"execute":"blockdev-add", > + "arguments":{"driver":"IMGFMT", "node-name":"n", > +"file":{"driver":"file", "filename":"TEST_DIR/t.IMGFMT"}}} > +{"return": {}} > + > +=== Default nbd server settings === > + > +{"execute":"nbd-server-start", > + "arguments":{"addr":{"type":"unix", > +"data":{"path":"SOCK_DIR/qemu-nbd.sock" > +{"return": {}} > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"r", "node-name":"n", > +"name":"r"}} > +{"return": {}} > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"w", "node-name":"n", > +"name":"w", "writable":true}} > +{"return": {}} > +nbdsh passed > +nbdsh passed > +{"execute":"block-export-del", > + "arguments":{"id":"r"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "r"}} > +{"execute":"block-export-del", > + "arguments":{"id":"w"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "w"}} > + > +=== Per-export overrides of defaults === > + > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"r", "node-name":"n", > +"name":"r", "multi-conn":"off"}} > +{"return": {}} > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"w", "node-name":"n", > +"name":"w", "multi-conn":"on", "writable":true}} > +{"return": {}} > +nbdsh passed > +nbdsh passed > +{"execute":"block-export-del", > + "arguments":{"id":"r"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "r"}} > +{"execute":"block-export-del", > + "arguments":{"id":"w"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "w"}} > +{"execute":"nbd-server-stop"} > +{"return": {}} > + > +=== Limit nbd server max-connections === > + > +{"execute":"nbd-server-start", > + "arguments":{"max-connections":1, "addr":{"type":"unix", > +"data":{"path":"SOCK_DIR/qemu-nbd.sock" > +{"return": {}} > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"r", "node-name":"n", > +"name":"r", "multi-conn":"on"}} > +{"return": {}} > +nbdsh passed > +{"execute":"block-export-del", > + "arguments":{"id":"r"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "r"}} > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"w", "node-name":"n", > +"name":"w", "multi-conn":"on", "writable":true}} > +{"return": {}} > +nbdsh passed > +{"execute":"block-export-del", > + "arguments":{"id":"w"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "w"}} > +{"execute":"nbd-server-stop"} > +{"return": {}} > + > +=== Demonstrate parallel writers === > + > +{"execute":"nbd-server-start", > + "arguments":{"addr":{"type":"unix", > +"data":{"path":"SOCK_DIR/qemu-nbd.sock" > +{"return": {}} > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"w", "node-name":"n", > +"name":"", "multi-conn":"on", "writable":true}} > +{"return": {}} > +Flush appears to be consistent across connections > +{"execute":"block-export-del", > + "arguments":{"id":"w"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "w"}} > +{"execute":"nbd-server-stop"} > +{"return": {}} > +{"execute":"quit"} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "SHUTDOWN", "data": {"guest": false, "reason": "host-qmp-quit"}} > Nothing about the contents here says anything about the actual test except the "Flush appears..." line. > +*** done > -- > 2.35.1 > Looks good, feel free to ignore the style comments and suggestion to rewrite the test in python. Nir

Re: [PATCH v2] nbd/server: Allow MULTI_CONN for shared writable exports

sec and XXX ops/sec) > +{"execute":"qmp_capabilities"} > +{"return": {}} > +{"execute":"blockdev-add", > + "arguments":{"driver":"IMGFMT", "node-name":"n", > +"file":{"driver":"file", "filename":"TEST_DIR/t.IMGFMT"}}} > +{"return": {}} > + > +=== Default nbd server settings === > + > +{"execute":"nbd-server-start", > + "arguments":{"addr":{"type":"unix", > +"data":{"path":"SOCK_DIR/qemu-nbd.sock" > +{"return": {}} > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"r", "node-name":"n", > +"name":"r"}} > +{"return": {}} > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"w", "node-name":"n", > +"name":"w", "writable":true}} > +{"return": {}} > +nbdsh passed > +nbdsh passed > +{"execute":"block-export-del", > + "arguments":{"id":"r"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "r"}} > +{"execute":"block-export-del", > + "arguments":{"id":"w"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "w"}} > + > +=== Per-export overrides of defaults === > + > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"r", "node-name":"n", > +"name":"r", "multi-conn":"off"}} > +{"return": {}} > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"w", "node-name":"n", > +"name":"w", "multi-conn":"on", "writable":true}} > +{"return": {}} > +nbdsh passed > +nbdsh passed > +{"execute":"block-export-del", > + "arguments":{"id":"r"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "r"}} > +{"execute":"block-export-del", > + "arguments":{"id":"w"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "w"}} > +{"execute":"nbd-server-stop"} > +{"return": {}} > + > +=== Limit nbd server max-connections === > + > +{"execute":"nbd-server-start", > + "arguments":{"max-connections":1, "addr":{"type":"unix", > +"data":{"path":"SOCK_DIR/qemu-nbd.sock" > +{"return": {}} > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"r", "node-name":"n", > +"name":"r", "multi-conn":"on"}} > +{"return": {}} > +nbdsh passed > +{"execute":"block-export-del", > + "arguments":{"id":"r"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "r"}} > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"w", "node-name":"n", > +"name":"w", "multi-conn":"on", "writable":true}} > +{"return": {}} > +nbdsh passed > +{"execute":"block-export-del", > + "arguments":{"id":"w"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "w"}} > +{"execute":"nbd-server-stop"} > +{"return": {}} > + > +=== Demonstrate parallel writers === > + > +{"execute":"nbd-server-start", > + "arguments":{"addr":{"type":"unix", > +"data":{"path":"SOCK_DIR/qemu-nbd.sock" > +{"return": {}} > +{"execute":"block-export-add", > + "arguments":{"type":"nbd", "id":"w", "node-name":"n", > +"name":"", "multi-conn":"on", "writable":true}} > +{"return": {}} > +Flush appears to be consistent across connections > +{"execute":"block-export-del", > + "arguments":{"id":"w"}} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "BLOCK_EXPORT_DELETED", "data": {"id": "w"}} > +{"execute":"nbd-server-stop"} > +{"return": {}} > +{"execute":"quit"} > +{"return": {}} > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, > "event": "SHUTDOWN", "data": {"guest": false, "reason": "host-qmp-quit"}} > Nothing about the contents here says anything about the actual test except the "Flush appears..." line. > +*** done > -- > 2.35.1 > Looks good, feel free to ignore the style comments and suggestion to rewrite the test in python. Nir

Re: [Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

On Tue, Feb 15, 2022 at 12:18 AM Nir Soffer wrote: > On Mon, Feb 14, 2022 at 3:22 PM Eric Blake wrote: > >> On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: >> > Add unit tests and benchmarks for AioBuffer. The tests are trivial but >> > they s

Re: [Libguestfs] [PATCH v2v 2/2] -o rhv-upload: Change the default to direct connection

On Tue, Feb 15, 2022 at 6:49 PM Richard W.M. Jones wrote: > To connect via a proxy you must now use “-oo rhv-proxy”. This is > usually slower and not needed. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2033096 > Thanks: Nir Soffer > --- > output/output_rhv_up

Re: [Libguestfs] [PATCH v2v 1/2] -o rhv-upload: Replace -oo rhv-direct with -oo rhv-proxy

t is > still to use the proxy. > > Related: https://bugzilla.redhat.com/show_bug.cgi?id=2033096 > Thanks: Nir Soffer > --- > docs/virt-v2v-output-rhv.pod | 12 +--- > docs/virt-v2v.pod | 15 ++- > output/output_rhv_upload.ml| 8 +--- &g

Re: [Libguestfs] [PATCH v2v] v2v/v2v.ml: Choose nbdcopy max requests for implicit buffer of 64M

On Tue, Feb 15, 2022 at 7:01 PM Richard W.M. Jones wrote: > On Tue, Feb 15, 2022 at 06:38:55PM +0200, Nir Soffer wrote: > > On Tue, Feb 15, 2022 at 5:54 PM Richard W.M. Jones > wrote: > > > > Pick the nbdcopy --requests parameter to target an implicit buffer &g

Re: [Libguestfs] [PATCH v2v] v2v/v2v.ml: Choose nbdcopy max requests for implicit buffer of 64M

.redhat.com/show_bug.cgi?id=2039255#c33 Looks like in https://bugzilla.redhat.com/show_bug.cgi?id=2039255#c32 We introduced 2 changes at the same time, which makes it impossible to tell the effect of any single change. Nir > --- > v2v/v2v.ml | 13 + > 1 file changed, 1

[ovirt-users] Re: How I'd like to contribute

r:/target/mytarget lun_count: 10 lun_size: 100 GiB cache: False exists:False Create target? [N/y]: You may find the tool source interesting, explaining why we configure the target in a certain way. Nir ___ Users m

Re: [Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

On Mon, Feb 14, 2022 at 3:22 PM Eric Blake wrote: > On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: > > Add unit tests and benchmarks for AioBuffer. The tests are trivial but > > they server as running documentation, and they point out important > > serve >

[ovirt-users] Re: oVirt 4.3 - Fibre Channel Data Domain as ISO dump.

n in 4.3. You should upgrade to 4.4 at this point. > I guess I could present the LUN to a VM and run NFS from there as an > alternative option. Yes NFS works for ISO on data domain in 4.3. Nir ___ Users mailing list -- users@ovirt.org To unsubscribe s

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

or more > data, nbdkit-vddk-plugin makes larger VixDiskLib_ReadAsynch requests, > which at some point breaks the VMware server. (This is fairly easy to > solve in nbdkit-vddk-plugin or with a filter.) > > But nbdcopy needs to be reworked to make the input and output requests > sepa

[ovirt-users] Re: ERROR (mailbox-spm) [storage.MailBox.SpmMailMonitor] mailbox 65 checksum failed, not clearing mailbox, clearing new mail

bad checksum and drop the messages in the mailbox. Processes that sent mail to the SPM will resed dropped mail in 2-3 seconds, so the issue should be recovered automatically. I would monitor your logs to check if this is a common issue, or one time incident. If this error is repeating, plea

Re: [Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

server. Testing such changes should be done on a real server with real storage. I'll try to get a server in our scale lab to do more real testing. Nir ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs

[Libguestfs] [PATCH v2] v2v/v2v.ml: Use larger request size for -o rhv-upload

Output modules can specify now request_size to override the default request size in nbdcopy. The rhv-upload plugin is translating every NBD command to HTTP request, translated back to NBD command on imageio server. The HTTP client and server, and the NBD client on the imageio server side are

Re: [Libguestfs] [PATCH] v2v/v2v.ml: Use larger request size for -o rhv-upload

On Sun, Feb 13, 2022 at 5:13 PM Nir Soffer wrote: > > On Sun, Feb 13, 2022 at 11:41 AM Richard W.M. Jones wrote: > > > > On Sat, Feb 12, 2022 at 10:49:42PM +0200, Nir Soffer wrote: > > > rhv-upload plugin is translating every NBD command to HTTP request, > >

Re: [Libguestfs] [PATCH] v2v/v2v.ml: Use larger request size for -o rhv-upload

On Sun, Feb 13, 2022 at 11:41 AM Richard W.M. Jones wrote: > > On Sat, Feb 12, 2022 at 10:49:42PM +0200, Nir Soffer wrote: > > rhv-upload plugin is translating every NBD command to HTTP request, > > translated back to NBD command on imageio server. The HTTP client and >

[Libguestfs] [PATCH] v2v/v2v.ml: Use larger request size for -o rhv-upload

rhv-upload plugin is translating every NBD command to HTTP request, translated back to NBD command on imageio server. The HTTP client and server, and the NBD client on the imageio server side are synchronous and implemented in python, so they have high overhead per request. To get good performance

Re: Mention of the CSS properties in JavaDocs

action. > > -- Kevin > > > On 2/9/2022 7:11 AM, Nir Lisker wrote: > > Hi, > > > > When reviewing the docs changes to TabPane, I saw that some properties > > mention the CSS that is related to them. I was wondering if we could > > standardize it thro

[ovirt-users] Re: How I'd like to contribute

If I knew > more I could debug what was happening more myself. > > > How did I do for an introduction? Great! Do you have some specific areas you would like to improve? Nir ___ Users mailing list -- users@ovirt.org To unsubscribe send

Re: [Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

On Fri, Feb 11, 2022 at 1:22 PM Richard W.M. Jones wrote: > > On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: > > Add unit tests and benchmarks for AioBuffer. The tests are trivial but > > they server as running documentation, and they point out important > >

[Libguestfs] [PATCH libnbd v2 6/9] golang: tests: Use AioBuffer.Slice()

Slice() is easier to use and faster than Get() or Bytes(). Let's use the new way. Signed-off-by: Nir Soffer --- golang/libnbd_020_aio_buffer_test.go | 8 +--- golang/libnbd_500_aio_pread_test.go | 2 +- golang/libnbd_510_aio_pwrite_test.go | 8 +--- 3 files changed, 11 insertions(+), 7

[Libguestfs] [PATCH libnbd v2 5/9] golang: aio_buffer.go: Add Slice()

System: 76.6 ms] Range (min … max): 450.6 ms … 476.0 ms3 runs Summary './aio_copy-slice nbd+unix:///?socket=/tmp/src.sock >/dev/null' ran 2.62 ± 0.09 times faster than './aio_copy-bytes nbd+unix:///?socket=/tmp/src.sock >/dev/null' Signed-off-by: Nir Soffer --- golang/aio

[Libguestfs] [PATCH libnbd v2 9/9] golang: examples: aio_copy: Simplify using AioBuffer

, and free it when the request is finished. Signed-off-by: Nir Soffer --- golang/examples/aio_copy/aio_copy.go | 29 +--- 1 file changed, 5 insertions(+), 24 deletions(-) diff --git a/golang/examples/aio_copy/aio_copy.go b/golang/examples/aio_copy/aio_copy.go index

[Libguestfs] [PATCH libnbd v2 7/9] golang: aio_buffer.go: Speed up FromBytes()

-by: Nir Soffer --- golang/aio_buffer.go | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/golang/aio_buffer.go b/golang/aio_buffer.go index 008d9ae0..52ea54de 100644 --- a/golang/aio_buffer.go +++ b/golang/aio_buffer.go @@ -47,25 +47,22 @@ func MakeAioBuffer(size uint

[Libguestfs] [PATCH libnbd v2 8/9] golang: aio_buffer.go: Benchmark copy flows

5320 ns/op BenchmarkAioBufferCopyMakeZero-12 728940 8218 ns/op Signed-off-by: Nir Soffer --- golang/libnbd_020_aio_buffer_test.go | 32 1 file changed, 32 insertions(+) diff --git a/golang/libnbd_020_aio_buffer_test.go b/golang

[Libguestfs] [PATCH libnbd v2 4/9] golang: aio_buffer.go: Add MakeAioBufferZero()

[]byte slice: BenchmarkMakeAioBufferZero-12 247710 4440 ns/op BenchmarkMakeByteSlice-12 84117 13733 ns/op Signed-off-by: Nir Soffer --- golang/aio_buffer.go | 6 ++ golang/libnbd_020_aio_buffer_test.go | 16

[Libguestfs] [PATCH libnbd v2 3/9] golang: aio_buffer.go: Add missing documentation

Add standard function documentation comments. The documentation should be available here: https://pkg.go.dev/libguestfs.org/libnbd#AioBuffer Signed-off-by: Nir Soffer --- golang/aio_buffer.go | 12 1 file changed, 12 insertions(+) diff --git a/golang/aio_buffer.go b/golang

[Libguestfs] [PATCH libnbd v2 0/9] golang: Safer, easier to use, and faster AioBuffer

typos in comments and commit messages (Eric) v1 was here: https://listman.redhat.com/archives/libguestfs/2022-January/msg00218.html Nir Soffer (9): golang: tests: Add test for AioBuffer golang: aio_buffer.go: Make it safer to use golang: aio_buffer.go: Add missing documentation golang

[Libguestfs] [PATCH libnbd v2 2/9] golang: aio_buffer.go: Make it safer to use

in the program. Trying to use AioBuffer with libnbd API will likely segfault and panic. I did not try to test this. Signed-off-by: Nir Soffer --- golang/aio_buffer.go | 5 +++- golang/libnbd_020_aio_buffer_test.go | 41 2 files changed, 45 insertions

[Libguestfs] [PATCH libnbd v2 1/9] golang: tests: Add test for AioBuffer

ith a very short timeout. For actual performance testing run "go test" directly. Signed-off-by: Nir Soffer --- golang/Makefile.am | 1 + golang/libnbd_020_aio_buffer_test.go | 104 +++ golang/run-tests.sh | 5 ++ 3 files cha

Re: [Libguestfs] [PATCH libnbd 5/9] golang: aio_buffer.go: Add Slice()

On Tue, Feb 1, 2022 at 3:12 PM Eric Blake wrote: > > On Sun, Jan 30, 2022 at 01:33:33AM +0200, Nir Soffer wrote: > > AioBuffer.Bytes() cannot be used for coping images from NBD to other > > copying > > > APis because it copies the entire image. Add a new Slice() fun

Re: [Libguestfs] [PATCH libnbd 4/9] golang: aio_buffer.go: Add MakeAioBufferZero()

On Tue, Feb 8, 2022 at 10:45 PM Eric Blake wrote: > > On Sun, Jan 30, 2022 at 01:33:32AM +0200, Nir Soffer wrote: > > Make it easy to create a zeroed buffer via calloc(), preventing leaking > > sensitive info from the heap. > > > > Benchmarking show that creating

Re: [Libguestfs] [PATCH libnbd 3/9] golang: aio_buffer.go: Add missing documentation

On Tue, Feb 1, 2022 at 3:09 PM Eric Blake wrote: > > On Sun, Jan 30, 2022 at 01:33:31AM +0200, Nir Soffer wrote: > > Add standard function documentation comments. > > > > The documentation should be available here: > > https://pkg.go.dev/libguestfs.org/libnbd#AioBuf

Re: [Libguestfs] [PATCH libnbd 1/9] golang: tests: Add test for AioBuffer

On Tue, Feb 8, 2022 at 9:33 PM Eric Blake wrote: > > On Sun, Jan 30, 2022 at 01:33:29AM +0200, Nir Soffer wrote: > > Add unit tests and benchmarks for AioBuffer. The tests are trivial but > > they server as running documentation, and they point out important > >

Re: [Libguestfs] [PATCH libnbd] generator/Go.ml: Simplify copy_uint32_array

On Tue, Feb 8, 2022 at 9:23 PM Eric Blake wrote: > > On Sun, Feb 06, 2022 at 07:45:20PM +0200, Nir Soffer wrote: > > Create a slice backed up by the entries pointer, and copy the data with > > builtin copy(). This can be 3x times faster but I did not measure it. > > &

Re: [Libguestfs] [PATCH 5/5] output/rhv-upload-plugin: Keep connections alive

On Tue, Feb 8, 2022 at 5:24 PM Richard W.M. Jones wrote: ... > > ACK 4 & 5. Push series without patch 2 as 99b6e31b output/rhv-upload-plugin: Keep connections alive 02d2236b output/rhv-upload-plugin: Track http last request time a436a0dc output/rhv-upload-plugin: Extract send_flush() helper

[ovirt-users] Re: hosted engine deployment (v4.4.10) - TASK Check engine VM health - fatal FAILED

On Wed, Feb 9, 2022 at 5:06 PM Gilboa Davara wrote: > > > On Wed, Feb 9, 2022 at 3:35 PM Nir Soffer wrote: >> >> On Wed, Feb 9, 2022 at 12:47 PM Gilboa Davara wrote: >> > >> > On Wed, Feb 9, 2022 at 1:05 AM Strahil Nikolov >> > wrote: >>

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v3]

On Wed, 9 Feb 2022 18:27:55 GMT, Ajit Ghaisas wrote: >> This is a Javadoc cleanup and correction fix for the TabPane as described in >> the JBS. >> >> Changes done for all the Properties of the TabPane - >> - Moved the property description to be over the property field. >> - Removed the

Mention of the CSS properties in JavaDocs

Hi, When reviewing the docs changes to TabPane, I saw that some properties mention the CSS that is related to them. I was wondering if we could standardize it through something like a @css tag that is given the css string constant, or read automatically through the CssMetaData. As an example:

Re: [Libguestfs] [PATCH v2v v2] output: -o rhv-upload: Kill nbdkit instances before finalizing

See-also: > https://listman.redhat.com/archives/libguestfs/2022-February/msg00111.html > Thanks: Nir Soffer > --- > output/output_rhv_upload.ml | 39 - > 1 file changed, 30 insertions(+), 9 deletions(-) > > diff --git a/output/output_rhv_upload.ml b/output/

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v2]

On Wed, 9 Feb 2022 13:17:14 GMT, Kevin Rushforth wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line >> 738: >> >>> 736: >>> 737: /** >>> 738: * This specifies how the {@code TabPane} handles tab closing >>> from an end-user's >> >> Since you are

[ovirt-users] Re: hosted engine deployment (v4.4.10) - TASK Check engine VM health - fatal FAILED

emu* > It allows ovirt-4.4* repos to push a new qemu release, without letting CentOS > stream break things... But new libvirt versions may require a newer qemu version, and oVirt itself may require a new libvirt version. These kind of excludes are frag

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v2]

On Wed, 9 Feb 2022 07:32:20 GMT, Ajit Ghaisas wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line >> 295: >> >>> 293: * >>> 294: * This value can also be set via CSS using {@code >>> -fx-tab-min-width}. >>> 295: * >> >> I would write >> >>

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v2]

On Wed, 9 Feb 2022 09:39:46 GMT, Ajit Ghaisas wrote: >> This is a Javadoc cleanup and correction fix for the TabPane as described in >> the JBS. >> >> Changes done for all the Properties of the TabPane - >> - Moved the property description to be over the property field. >> - Removed the

Re: [Libguestfs] [PATCH libnbd] golang: make-dist.sh: Generate the list file

On Mon, Feb 7, 2022 at 3:13 PM Eric Blake wrote: > > On Sun, Feb 06, 2022 at 07:21:02PM +0200, Nir Soffer wrote: > > Generated the list file when creating the distribution. Since the Go > > tool treat the list file on the proxy server as the source of truth, we > > do the

Re: [Libguestfs] Performance regression in -o rhv-upload questions

On Tue, Feb 8, 2022 at 3:27 PM Richard W.M. Jones wrote: > > Hi Nir, > > https://bugzilla.redhat.com/show_bug.cgi?id=2039255#c4 > > I'm looking for some advice/help with a performance regression in > virt-v2v between 1.44.2 and the latest version. It's very obvious and >

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs

On Mon, 7 Feb 2022 10:53:00 GMT, Ajit Ghaisas wrote: > This is a Javadoc cleanup and correction fix for the TabPane as described in > the JBS. > > Changes done for all the Properties of the TabPane - > - Moved the property description to be over the property field. > - Removed the unnecessary

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs

On Mon, 7 Feb 2022 10:53:00 GMT, Ajit Ghaisas wrote: > This is a Javadoc cleanup and correction fix for the TabPane as described in > the JBS. > > Changes done for all the Properties of the TabPane - > - Moved the property description to be over the property field. > - Removed the unnecessary

[jfx18] Integrated: 8279345: Realign class docs of LightBase and subclasses

On Sun, 16 Jan 2022 22:54:22 GMT, Nir Lisker wrote: > Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation a

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations o

[ovirt-users] Re: RHGS and RHV closing down: could you please put that on the home page?

k on it in the future. HCI was designed and maintained by Gluster folks. Our contribution for HCI was adding 4k support, enabling usage of VDO. Improving on the HCI side is unlikely to come from Red Hat, but nothing blocks other companies or contributors from working on this. Our focus for 4.5 is M

[jira] [Commented] (FLINK-25965) Add a Couchbase sink

[ https://issues.apache.org/jira/browse/FLINK-25965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488104#comment-17488104 ] Nir Tsruya commented on FLINK-25965: I see, thank you very much for the heads up [~MartijnVisser

[jira] [Commented] (FLINK-25965) Add a Couchbase sink

[ https://issues.apache.org/jira/browse/FLINK-25965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488045#comment-17488045 ] Nir Tsruya commented on FLINK-25965: Thanks [~MartijnVisser] , I see. Does it mean that in order

Re: [Libguestfs] [libnbd PATCH v2 1/5] python: tests: Fix error handling

On Fri, Feb 4, 2022 at 10:37 AM Laszlo Ersek wrote: > > On 02/03/22 23:49, Nir Soffer wrote: > > On Thu, Feb 3, 2022 at 10:26 PM Eric Blake wrote: > >> > >> Like a lot of the C examples, the aio copy test ignores read and write > >> errors in the completio

Re: [Libguestfs] [libguestfs/libguestfs] guestfs_copy_in fails with error: copy_in: tar subprocess failed: tar: .: file changed as we read it: errno 0 (Issue #75)

configuration: cluster.consistent-metadata on but the old configuration cluster.consistent-metadata no is still the default in some cases. Nir ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] [PATCH libnbd] golang: make-dist.sh: Generate the list file

On Sun, Feb 6, 2022 at 9:13 PM Richard W.M. Jones wrote: > > On Sun, Feb 06, 2022 at 07:21:02PM +0200, Nir Soffer wrote: > > Generated the list file when creating the distribution. Since the Go > > tool treat the list file on the proxy server as the source of truth, we > &

[jira] [Created] (FLINK-25965) Add a Couchbase sink

Nir Tsruya created FLINK-25965: -- Summary: Add a Couchbase sink Key: FLINK-25965 URL: https://issues.apache.org/jira/browse/FLINK-25965 Project: Flink Issue Type: New Feature

[jira] [Created] (FLINK-25965) Add a Couchbase sink

Nir Tsruya created FLINK-25965: -- Summary: Add a Couchbase sink Key: FLINK-25965 URL: https://issues.apache.org/jira/browse/FLINK-25965 Project: Flink Issue Type: New Feature

[Libguestfs] [PATCH libnbd] generator/Go.ml: Simplify copy_uint32_array

/libguestfs/2021-December/msg00065.html Signed-off-by: Nir Soffer --- generator/GoLang.ml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/generator/GoLang.ml b/generator/GoLang.ml index eb3aa263..73838199 100644 --- a/generator/GoLang.ml +++ b/generator/GoLang.ml @@ -1,13

[Libguestfs] [PATCH libnbd] golang: make-dist.sh: Generate the list file

tarball requires now access to download.libguestfs.org. With this change the distribution tarball can be extract on the server without any additional manual process. Signed-off-by: Nir Soffer --- golang/make-dist.sh | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git

[jira] [Commented] (FLINK-24477) Add MongoDB sink

[ https://issues.apache.org/jira/browse/FLINK-24477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487689#comment-17487689 ] Nir Tsruya commented on FLINK-24477: [~MartijnVisser] sure. [~RocMarshal] I think that the first

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

On Thu, 27 Jan 2022 19:01:32 GMT, Kevin Rushforth wrote: >> I think the description should focus on the meaning of the respective term >> in the lighting equation, and not on a non-technical analogy. In this case, >> the analogy is a bit misleading on several aspects, including the fact that

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

it > mentioned the properties it has. > * Added examples of real-world applications for each light type. > * Consolidated the writing style for all the subclasses. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:

[ovirt-users] Re: Unclear how to add local (POSIX) storage

On Fri, Feb 4, 2022 at 3:18 PM Richard W.M. Jones wrote: > > On Fri, Feb 04, 2022 at 03:09:02PM +0200, Nir Soffer wrote: > > On Fri, Feb 4, 2022 at 11:16 AM Richard W.M. Jones > > wrote: > > > > > > On Fri, Feb 04, 2022 at 08:42:08AM +, Richard W.M. Jones

[ovirt-users] Re: Unclear how to add local (POSIX) storage

On Fri, Feb 4, 2022 at 3:49 PM Richard W.M. Jones wrote: > > On Fri, Feb 04, 2022 at 03:47:11PM +0200, Nir Soffer wrote: > > Can be fixed with: > > > > $ sudo chcon -R -t nfs_t mnt > > Yes that did work, thanks. Warning: that this configuration is a trap - if you a

[ovirt-users] Re: Unclear how to add local (POSIX) storage

On Fri, Feb 4, 2022 at 3:49 PM Richard W.M. Jones wrote: > > On Fri, Feb 04, 2022 at 03:47:11PM +0200, Nir Soffer wrote: > > Can be fixed with: > > > > $ sudo chcon -R -t nfs_t mnt > > Yes that did work, thanks. > > Is this still a bug? For NFS this works out

[ovirt-users] Re: Unclear how to add local (POSIX) storage

On Fri, Feb 4, 2022 at 3:18 PM Richard W.M. Jones wrote: > > On Fri, Feb 04, 2022 at 03:09:02PM +0200, Nir Soffer wrote: > > On Fri, Feb 4, 2022 at 11:16 AM Richard W.M. Jones > > wrote: > > > > > > On Fri, Feb 04, 2022 at 08:42:08AM +, Richard W.M. Jones

[ovirt-users] Re: Unclear how to add local (POSIX) storage

On Fri, Feb 4, 2022 at 3:18 PM Richard W.M. Jones wrote: > > On Fri, Feb 04, 2022 at 03:09:02PM +0200, Nir Soffer wrote: > > On Fri, Feb 4, 2022 at 11:16 AM Richard W.M. Jones > > wrote: > > > > > > On Fri, Feb 04, 2022 at 08:42:08AM +, Richard W.M. Jones

[ovirt-users] Re: Unclear how to add local (POSIX) storage

On Fri, Feb 4, 2022 at 11:16 AM Richard W.M. Jones wrote: > > On Fri, Feb 04, 2022 at 08:42:08AM +, Richard W.M. Jones wrote: > > On Thu, Feb 03, 2022 at 06:31:52PM +0200, Nir Soffer wrote: > > > This is expected on oVirt, our multipath configuration is intentionally >

Re: [Libguestfs] [libnbd PATCH v2 5/5] copy: CVE-2022-0485: Fail nbdcopy if NBD read or write fails

and others which > showcase ways in which sparse images can bypass errors. > > Once backports are complete, a followup patch on the main branch will > edit docs/libnbd-security.pod with the mailing list announcement of > the stable branch commit ids and release versions that incorpor

Re: [Libguestfs] [libnbd PATCH v2 4/5] copy: Pass in dummy variable rather than to callback

,5 @@ > > /* NBD client library in userspace. > > - * Copyright (C) 2020-2021 Red Hat Inc. > > + * Copyright (C) 2020-2022 Red Hat Inc. > > * > > * This library is free software; you can redistribute it and/or > >

Re: [Libguestfs] [libnbd PATCH v2 3/5] docs: Clarify how callbacks should handle errors

gt; +completed. Furthermore, the contents of C are undefined if the > +C parameter to C is set, or if > +L reports failure. Other parameters behave > +as documented in L." > ^ strict_call_description; > example = Some "examples/aio-connect-read.c"; > see_also = [SectionLink

<    5   6   7   8   9   10   11   12   13   14   >