[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

2015-11-19 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/9826#issuecomment-158229760 @mengxr based on our discussions, here is a slightly updated version: - menu is fixed - menu disappears under the page (but it looks half covered

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

2015-11-19 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/9826#issuecomment-158220169 @andrewor14 this is a different issue: the SIPs show the table of contents within one document, which we already have with the `{:toc}` directive. This PR adds

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

2015-11-18 Thread thunterdb
GitHub user thunterdb opened a pull request: https://github.com/apache/spark/pull/9826 [SPARK-11835] Adds a sidebar menu to MLlib's documentation This PR adds a sidebar menu when browsing the user guide of MLlib. It uses a YAML file to describe the structure of the documentation

[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...

2015-11-17 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/9697#issuecomment-157523631 Thank you @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...

2015-11-16 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/9697#discussion_r44972401 --- Diff: tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala --- @@ -72,7 +72,10 @@ object GenerateMIMAIgnore { val

[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...

2015-11-16 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/9697#discussion_r44972207 --- Diff: tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala --- @@ -72,7 +72,10 @@ object GenerateMIMAIgnore { val

[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...

2015-11-16 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/9697#issuecomment-157149737 @srowen sorry the delay. comments addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...

2015-11-13 Thread thunterdb
GitHub user thunterdb opened a pull request: https://github.com/apache/spark/pull/9697 [SPARK-11732] Removes some MiMa false positives This adds an extra filter for private or protected classes. We only filter for package private right now. You can merge this pull request

[GitHub] spark pull request: [SPARK-11732] Removes some MiMa false positive...

2015-11-13 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/9697#issuecomment-156507620 cc @pwendell @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Added support for :cp jar that was broken in...

2014-08-14 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/1929#issuecomment-52208640 I believe @mateiz is concerned about compatibility with other scala 2.10.x versions. We would have to make sure this works for all supported scala versions

[GitHub] spark pull request: Added support for :cp jar that was broken in...

2014-08-13 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/1929#discussion_r16207973 --- Diff: repl/src/main/scala/org/apache/spark/repl/SparkIMain.scala --- @@ -130,6 +131,9 @@ import org.apache.spark.util.Utils private var

[GitHub] spark pull request: [SPARK-2762] SparkILoop leaks memory in multi-...

2014-07-31 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/1674#issuecomment-50790820 Thanks Matei! On Thu, Jul 31, 2014 at 10:26 AM, Matei Zaharia notificati...@github.com wrote: Alright, merged this. Thanks! รข

[GitHub] spark pull request: SparkILoop - simplify recovery procedure

2014-07-30 Thread thunterdb
GitHub user thunterdb opened a pull request: https://github.com/apache/spark/pull/1674 SparkILoop - simplify recovery procedure This pull request is a small refactor so that a partial function (hence a closure) is not created. Instead, a regular function is used. The behavior

[GitHub] spark pull request: SparkILoop - simplify recovery procedure

2014-07-30 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/1674#discussion_r15618694 --- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala --- @@ -557,29 +557,27 @@ class SparkILoop(in0: Option[BufferedReader], protected val

<    1   2   3   4