Re: [PR] Improve `ParquetExec` and related documentation [datafusion]

2024-05-25 Thread via GitHub
alamb commented on code in PR #10647: URL: https://github.com/apache/datafusion/pull/10647#discussion_r1614666750 ## datafusion/core/src/datasource/physical_plan/parquet/mod.rs: ## @@ -642,11 +714,22 @@ fn should_enable_page_index( .unwrap_or(false) } -///

Re: [PR] HDDS-10914. Bump maven-gpg-plugin to 3.2.4 [ozone]

2024-05-25 Thread via GitHub
adoroszlai merged PR #6728: URL: https://github.com/apache/ozone/pull/6728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support Substrait's VirtualTables [datafusion]

2024-05-25 Thread via GitHub
jonahgao commented on code in PR #10531: URL: https://github.com/apache/datafusion/pull/10531#discussion_r1614666495 ## datafusion/substrait/src/logical_plan/producer.rs: ## @@ -512,6 +572,62 @@ pub fn to_substrait_rel( } } +fn to_substrait_named_struct(schema: ) ->

Re: [PR] Add `mssql` integration tests [airflow]

2024-05-25 Thread via GitHub
shahar1 commented on code in PR #39831: URL: https://github.com/apache/airflow/pull/39831#discussion_r1614658686 ## scripts/ci/docker-compose/integration-mssql.yml: ## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[PR] Refactor : remove container id variable [shardingsphere]

2024-05-25 Thread via GitHub
taojintianxia opened a new pull request, #31391: URL: https://github.com/apache/shardingsphere/pull/31391 Changes proposed in this pull request: - Remove useles code --- Before committing this PR, I'm sure that I have checked the following options: - [ ] My code

Re: [I] [Task] Supports sending alarm notifications to designated personnel on DingTalk and Feishu [hertzbeat]

2024-05-25 Thread via GitHub
Yanshuming1 commented on issue #2016: URL: https://github.com/apache/hertzbeat/issues/2016#issuecomment-2131265882 Hello, is this requirement still being done? If there is no time, you can arrange it for me @zhangshenghang -- This is an automated message from the Apache Git Service. To

Re: [I] [Epic] Unify `AggregateFunction` Interface (remove built in list of `AggregateFunction` s), improve the system [datafusion]

2024-05-25 Thread via GitHub
jayzhan211 commented on issue #8708: URL: https://github.com/apache/datafusion/issues/8708#issuecomment-2131265763 > After #10648 and #10389 I think we have a pretty good set of examples of how to move aggregates out of the core (thanks to all the foundations layed by @jayzhan211 ) >

[Github-comments] Re: [geany/geany] Windows: Add glib-compile-schemas.exe to GTK bundle (PR #3885)

2024-05-25 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. Not tested, but looks good and makes sense :+1: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3885#pullrequestreview-2078987956 You are receiving this because you are subscribed to this thread. Message ID:

Re: [PR] Add `mssql` integration tests [airflow]

2024-05-25 Thread via GitHub
shahar1 commented on code in PR #39831: URL: https://github.com/apache/airflow/pull/39831#discussion_r1614658686 ## scripts/ci/docker-compose/integration-mssql.yml: ## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [I] DAG support [age]

2024-05-25 Thread via GitHub
spbnick commented on issue #1821: URL: https://github.com/apache/age/issues/1821#issuecomment-2131265122 Thank you @jrgemignani, I'll consider looking at that structure. However, so far my attempts at using Apache AGE with my dataset were mostly a failure :( So for now I'm building my own

[PR] Add `mssql` integration tests [airflow]

2024-05-25 Thread via GitHub
shahar1 opened a new pull request, #39831: URL: https://github.com/apache/airflow/pull/39831 closes: #38577 related: #39768 - Creates a Docker Compose integration yaml file to `mssql`. - Add an integration test to `mssql` hook. - Adds integration tests for:

[Github-comments] Re: [geany/geany] #!/bin/busybox ash (Issue #3884)

2024-05-25 Thread Colomban Wendling via Github-comments
FWIW, patching is likely as easy as this (untested): ```diff diff --git a/src/filetypes.c b/src/filetypes.c index b1913e368..f773f1a2b 100644 --- a/src/filetypes.c +++ b/src/filetypes.c @@ -632,6 +632,10 @@ static GeanyFiletype *find_shebang(const gchar *utf8_filename, const gchar *line

Re: [PR] Make the build work on more recent JDKs [sling-org-apache-sling-scripting-sightly-compiler]

2024-05-25 Thread via GitHub
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/13#issuecomment-2131264743 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png

Re: [PR] Add reference visitor `TreeNode` APIs, change `ExecutionPlan::children()` and `PhysicalExpr::children()` return references [datafusion]

2024-05-25 Thread via GitHub
peter-toth commented on code in PR #10543: URL: https://github.com/apache/datafusion/pull/10543#discussion_r1614657172 ## datafusion/physical-plan/src/work_table.rs: ## @@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec { } -fn children() -> Vec> { +

[PR] [Bug] [Connector-kudu]correct the typo of kudu kerberos config [seatunnel]

2024-05-25 Thread via GitHub
JackeyLee007 opened a new pull request, #6905: URL: https://github.com/apache/seatunnel/pull/6905 ### Purpose of this pull request Correct the typo, messsion by issue https://github.com/apache/seatunnel/issues/6903 ### Does this PR introduce _any_ user-facing

Re: [PR] RATIS-2093. Decouple metadata and configuration entries from appendEntries buffer for stateMachineCache' [ratis]

2024-05-25 Thread via GitHub
szetszwo commented on PR #1096: URL: https://github.com/apache/ratis/pull/1096#issuecomment-2131264368 @duongkame , deployed `3.1.0-640749b-SNAPSHOT`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

2024-05-25 Thread via GitHub
jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1614656536 ## datafusion/sqllogictest/test_files/joins.slt: ## @@ -1778,7 +1778,7 @@ AS VALUES ('BB', 6, 1); query TII -select col1, col2, coalesce(sum_col3, 0) as

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

2024-05-25 Thread via GitHub
jayzhan211 commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1614656536 ## datafusion/sqllogictest/test_files/joins.slt: ## @@ -1778,7 +1778,7 @@ AS VALUES ('BB', 6, 1); query TII -select col1, col2, coalesce(sum_col3, 0) as

Re: [PR] Minor: Remove `GetFieldAccessSchema` [datafusion]

2024-05-25 Thread via GitHub
alamb merged PR #10665: URL: https://github.com/apache/datafusion/pull/10665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Minor: Use slice in `ConcreteTreeNode` [datafusion]

2024-05-25 Thread via GitHub
peter-toth opened a new pull request, #10666: URL: https://github.com/apache/datafusion/pull/10666 The idea of using slices to return a node's children came up here: https://github.com/apache/datafusion/pull/10543#discussion_r1614057653. While it is not possible in all `TreeNode`

Re: [I] Support `date_bin` on timestamps with timezone, properly accounting for Daylight Savings Time [datafusion]

2024-05-25 Thread via GitHub
alamb commented on issue #10602: URL: https://github.com/apache/datafusion/issues/10602#issuecomment-2131254591 Thank you @tustvold and @Abdullahsab3 and @mhilton and @appletreeisyellow for the thoughts. From my perspective, the current (non timezone aware) `date_bin` function has

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

2024-05-25 Thread via GitHub
alamb commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1614654486 ## datafusion/sqllogictest/test_files/joins.slt: ## @@ -1778,7 +1778,7 @@ AS VALUES ('BB', 6, 1); query TII -select col1, col2, coalesce(sum_col3, 0) as

Re: [PR] [Bug] [Connector-kudu] Correct the typo in kudu kerberos config [seatunnel]

2024-05-25 Thread via GitHub
JackeyLee007 closed pull request #6904: [Bug] [Connector-kudu] Correct the typo in kudu kerberos config URL: https://github.com/apache/seatunnel/pull/6904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] How to update configuration modifications [openwhisk]

2024-05-25 Thread via GitHub
Hyzheng-WHU commented on issue #5350: URL: https://github.com/apache/openwhisk/issues/5350#issuecomment-2131250838 遇到了同样的问题,改了还是256m -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] GH-40933: [Java] Enhance the copyFrom* functionality in StringView [arrow]

2024-05-25 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #41752: URL: https://github.com/apache/arrow/pull/41752#issuecomment-2131247946 After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 54dfb82a401fa4c1e53fccb2f152b04f7bb85f4d. There were

Re: [PR] CAMEL-20794: AWS2 Kinesis producer supports sending batch [camel]

2024-05-25 Thread via GitHub
fanyang commented on code in PR #14238: URL: https://github.com/apache/camel/pull/14238#discussion_r1614645768 ## components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/Kinesis2Producer.java: ## @@ -47,11 +53,28 @@ public Kinesis2Endpoint

Re: [PR] [fix](auto-partition) fix auto partition load lost data in multi sender [doris]

2024-05-25 Thread via GitHub
doris-robot commented on PR #35287: URL: https://github.com/apache/doris/pull/35287#issuecomment-2131245871 ClickBench: Total hot run time: 30.23 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] HBASE-28473 Add 2.4.18 to download page [hbase]

2024-05-25 Thread via GitHub
Apache9 merged PR #5945: URL: https://github.com/apache/hbase/pull/5945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix(6509): improve the test case coverage of [saga] module to 70% [incubator-seata]

2024-05-25 Thread via GitHub
codecov-commenter commented on PR #6519: URL: https://github.com/apache/incubator-seata/pull/6519#issuecomment-2131245075 ##

Re: [PR] Rename V2 spec names [iceberg-rust]

2024-05-25 Thread via GitHub
liurenjie1024 merged PR #380: URL: https://github.com/apache/iceberg-rust/pull/380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [fix](auto-partition) fix auto partition load lost data in multi sender [doris]

2024-05-25 Thread via GitHub
doris-robot commented on PR #35287: URL: https://github.com/apache/doris/pull/35287#issuecomment-2131244679 TPC-DS: Total hot run time: 172524 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] CAMEL-20794: AWS2 Kinesis producer supports sending batch [camel]

2024-05-25 Thread via GitHub
fanyang commented on code in PR #14238: URL: https://github.com/apache/camel/pull/14238#discussion_r1614642796 ## components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/Kinesis2Producer.java: ## @@ -47,11 +53,28 @@ public Kinesis2Endpoint

Re: [PR] Fix typo in Cargo.toml (unused manifest key: dependencies.regex.worksapce) [datafusion]

2024-05-25 Thread via GitHub
alamb commented on PR #10662: URL: https://github.com/apache/datafusion/pull/10662#issuecomment-2131244635 > oops.. my mistake. :P Many thanks. No worries! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] fix(6509): improve the test case coverage of [saga] module to 70% [incubator-seata]

2024-05-25 Thread via GitHub
xjlgod commented on code in PR #6519: URL: https://github.com/apache/incubator-seata/pull/6519#discussion_r1614640585 ## saga/seata-saga-processctrl/src/test/java/org/apache/seata/saga/proctrl/handler/DefaultRouterHandlerTest.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the

Re: [PR] build(deps): bump syn from 2.0.63 to 2.0.64 [datafusion-python]

2024-05-25 Thread via GitHub
dependabot[bot] commented on PR #706: URL: https://github.com/apache/datafusion-python/pull/706#issuecomment-2131243514 Superseded by #717. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] build(deps): bump syn from 2.0.63 to 2.0.66 [datafusion-python]

2024-05-25 Thread via GitHub
dependabot[bot] opened a new pull request, #717: URL: https://github.com/apache/datafusion-python/pull/717 Bumps [syn](https://github.com/dtolnay/syn) from 2.0.63 to 2.0.66. Release notes Sourced from https://github.com/dtolnay/syn/releases;>syn's releases. 2.0.66

Re: [PR] build(deps): bump syn from 2.0.63 to 2.0.64 [datafusion-python]

2024-05-25 Thread via GitHub
dependabot[bot] closed pull request #706: build(deps): bump syn from 2.0.63 to 2.0.64 URL: https://github.com/apache/datafusion-python/pull/706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Move Median to `functions-aggregate` and Introduce Numeric signature [datafusion]

2024-05-25 Thread via GitHub
jayzhan211 commented on code in PR #10644: URL: https://github.com/apache/datafusion/pull/10644#discussion_r1614640283 ## datafusion/functions-aggregate/Cargo.toml: ## @@ -39,6 +39,7 @@ path = "src/lib.rs" [dependencies] arrow = { workspace = true } +arrow-schema = {

Re: [PR] change version to 38.0.1 [datafusion-python]

2024-05-25 Thread via GitHub
andygrove merged PR #716: URL: https://github.com/apache/datafusion-python/pull/716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix: Only delegate to DataFusion cast when we know that it is compatible with Spark [datafusion-comet]

2024-05-25 Thread via GitHub
andygrove commented on code in PR #461: URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1614639502 ## core/src/execution/datafusion/expressions/cast.rs: ## @@ -622,14 +590,89 @@ impl Cast { self.eval_mode,

Re: [PR] Create a geoparquet module and add dependencies [incubator-baremaps]

2024-05-25 Thread via GitHub
Drabble commented on PR #855: URL: https://github.com/apache/incubator-baremaps/pull/855#issuecomment-2131242523 I did a little bit of reading on the spec of geoparquet. https://github.com/opengeospatial/geoparquet/blob/main/format-specs/geoparquet.md I have a feeling that in our

Re: [PR] fix: Only delegate to DataFusion cast when we know that it is compatible with Spark [datafusion-comet]

2024-05-25 Thread via GitHub
andygrove commented on code in PR #461: URL: https://github.com/apache/datafusion-comet/pull/461#discussion_r1614638361 ## core/src/execution/datafusion/expressions/cast.rs: ## @@ -622,14 +590,89 @@ impl Cast { self.eval_mode,

Re: [PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-25 Thread via GitHub
xiangfu0 commented on code in PR #13217: URL: https://github.com/apache/pinot/pull/13217#discussion_r1614638087 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java: ## @@ -162,7 +162,17 @@ public Object getValue() { public boolean

Re: [PR] [Bug] [Connector-kudu] Correct the typo in kudu kerberos config [seatunnel]

2024-05-25 Thread via GitHub
JackeyLee007 commented on PR #6904: URL: https://github.com/apache/seatunnel/pull/6904#issuecomment-2131242265 @ruanwenjun @hailin0, take a review, please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [fix](auto-partition) fix auto partition load lost data in multi sender [doris]

2024-05-25 Thread via GitHub
doris-robot commented on PR #35287: URL: https://github.com/apache/doris/pull/35287#issuecomment-2131242102 TPC-H: Total hot run time: 40230 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] Revert #28614: Add UseDataStreamForBatch option to Flink runner [beam]

2024-05-25 Thread via GitHub
github-actions[bot] commented on PR #29993: URL: https://github.com/apache/beam/pull/29993#issuecomment-2131242056 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] add ExternalTransformProvider example [beam]

2024-05-25 Thread via GitHub
github-actions[bot] commented on PR #30666: URL: https://github.com/apache/beam/pull/30666#issuecomment-2131242047 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] [HUDI-7797] Use HoodieIOFactory to return pluggable FileFormatUtils i… [hudi]

2024-05-25 Thread via GitHub
codope commented on code in PR #11302: URL: https://github.com/apache/hudi/pull/11302#discussion_r1614632735 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkParquetReader.java: ## @@ -69,7 +69,7 @@ public

[PR] [Bug] [Connector-kudu] Correct the typo in kudu kerberos config [seatunnel]

2024-05-25 Thread via GitHub
JackeyLee007 opened a new pull request, #6904: URL: https://github.com/apache/seatunnel/pull/6904 ### Purpose of this pull request Correct the typo, messsion by issue #6903 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested?

Re: [PR] Bump commons-cli:commons-cli from 1.7.0 to 1.8.0 [axis-axis2-java-core]

2024-05-25 Thread via GitHub
veithen merged PR #665: URL: https://github.com/apache/axis-axis2-java-core/pull/665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-25 Thread via GitHub
xiangfu0 commented on code in PR #13217: URL: https://github.com/apache/pinot/pull/13217#discussion_r1614636247 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java: ## @@ -162,7 +162,17 @@ public Object getValue() { public boolean

[PR] Remove `GetFieldAccessSchema` [datafusion]

2024-05-25 Thread via GitHub
jayzhan211 opened a new pull request, #10665: URL: https://github.com/apache/datafusion/pull/10665 ## Which issue does this PR close? Closes #. ## Rationale for this change ## What changes are included in this PR? ## Are these changes

Re: [PR] Bump spring.version from 5.3.35 to 5.3.36 [ws-axiom]

2024-05-25 Thread via GitHub
veithen merged PR #474: URL: https://github.com/apache/ws-axiom/pull/474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org

[I] [Bug] [connector-kudu] Wrong kerberos config for kudu connector [seatunnel]

2024-05-25 Thread via GitHub
JackeyLee007 opened a new issue, #6903: URL: https://github.com/apache/seatunnel/issues/6903 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues. ### What

Re: [I] [C++] Create Meson WrapDB Entry for Arrow [arrow]

2024-05-25 Thread via GitHub
WillAyd commented on issue #41816: URL: https://github.com/apache/arrow/issues/41816#issuecomment-2131239638 Thanks for the feedback - those names make sense to me. As far as the build definition files go, I don't think they have to be created in the Arrow repo itself, but can be

Re: [PR] Support creating tags by adding `set_ref_snapshot` API [iceberg-python]

2024-05-25 Thread via GitHub
chinmay-bhat commented on code in PR #728: URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1614633223 ## pyiceberg/table/__init__.py: ## @@ -277,6 +279,50 @@ def __init__(self, table: Table, autocommit: bool = False): self._autocommit = autocommit

Re: [PR] Support WAL Compression [iotdb]

2024-05-25 Thread via GitHub
codecov[bot] commented on PR #12476: URL: https://github.com/apache/iotdb/pull/12476#issuecomment-2131239379 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12476?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Use Duration instead of long+TimeUnit in ReadOnlyTStore.unreserve [accumulo]

2024-05-25 Thread via GitHub
cshannon commented on PR #4371: URL: https://github.com/apache/accumulo/pull/4371#issuecomment-2131238795 This change does not merge forward into elasticity because the code for dealing with Fate has drastically changed and trying to resolve conflicts doesn't really work as the code has

Re: [PR] GH-41810: [C++] Support cast kernel from (dense or sparse) union to (large) string [arrow]

2024-05-25 Thread via GitHub
github-actions[bot] commented on PR #41827: URL: https://github.com/apache/arrow/pull/41827#issuecomment-2131238275 :warning: GitHub issue #41810 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the

[PR] GH-41810: [C++] Support cast kernel from (dense or sparse) union to (large) string [arrow]

2024-05-25 Thread via GitHub
llama90 opened a new pull request, #41827: URL: https://github.com/apache/arrow/pull/41827 ### Rationale for this change Support `cast` kernel from (`dense` or `sparse`) union to (large) string ### What changes are included in this PR? - Support `cast`

Re: [PR] ci: add typo ci check and fix typos [bookkeeper]

2024-05-25 Thread via GitHub
shoothzj commented on PR #4375: URL: https://github.com/apache/bookkeeper/pull/4375#issuecomment-2131238083 @eolivelli @hangc0276 @merlimat @nicoloboschi @wenbingshen @zhaijack PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Remove duplicate function name in its aliases list [datafusion]

2024-05-25 Thread via GitHub
goldmedal commented on PR #10661: URL: https://github.com/apache/datafusion/pull/10661#issuecomment-2131238078 Thanks, @alamb! Actually, I tried to add some tests for `MemoryFunctionRegistry` before I fixed it, but I found everything was fine. I guess the reason is that we don't

Re: [PR] remove stale sleep code in BookieServer [bookkeeper]

2024-05-25 Thread via GitHub
shoothzj merged PR #4336: URL: https://github.com/apache/bookkeeper/pull/4336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[Github-comments] Re: [geany/geany] Make Custom Target should have a directory combo box (Issue #3883)

2024-05-25 Thread elextr via Github-comments
We all know you should only run make in the top level (he says subtly referencing "Recursive Make considered harmful" [Miller, 1997, PDF](https://aegis.sourceforge.net/auug97.pdf)) so its not just as simple as parent if your project has more than one level, so something like project top level

Re: [PR] Minor: Add tests showing aggregate behavior for NaNs [datafusion]

2024-05-25 Thread via GitHub
alamb commented on code in PR #10634: URL: https://github.com/apache/datafusion/pull/10634#discussion_r1614628009 ## datafusion/sqllogictest/test_files/aggregate.slt: ## @@ -4374,6 +4374,42 @@ GROUP BY dummy text1, text1, text1 +# Tests for aggregating with NaN values

Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]

2024-05-25 Thread via GitHub
codecov-commenter commented on PR #232: URL: https://github.com/apache/commons-beanutils/pull/232#issuecomment-2131236494 ##

Re: [PR] [WIP] Bump jetcd from 0.7.7 to 0.8.0 [bookkeeper]

2024-05-25 Thread via GitHub
shoothzj commented on PR #4368: URL: https://github.com/apache/bookkeeper/pull/4368#issuecomment-2131236475 @lhotari BookKeeper's client and server in one module and the fat client makes thing complicated. I would like to separate client and server module first. But the client module will

[PR] refactor: rename blocking and async operator [opendal]

2024-05-25 Thread via GitHub
tisonkun opened a new pull request, #4641: URL: https://github.com/apache/opendal/pull/4641 See the commit message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] More properly handle nullability of types/literals in Substrait [datafusion]

2024-05-25 Thread via GitHub
alamb commented on PR #10640: URL: https://github.com/apache/datafusion/pull/10640#issuecomment-2131235829 Thanks @Blizzara and @jonahgao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] PerChannelBookieClient Enhancement: Self-Recovery Support in Corrupte… [bookkeeper]

2024-05-25 Thread via GitHub
shoothzj closed pull request #4020: PerChannelBookieClient Enhancement: Self-Recovery Support in Corrupte… URL: https://github.com/apache/bookkeeper/pull/4020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [WIP] Bump jetcd from 0.7.7 to 0.8.0 [bookkeeper]

2024-05-25 Thread via GitHub
shoothzj closed pull request #4368: [WIP] Bump jetcd from 0.7.7 to 0.8.0 URL: https://github.com/apache/bookkeeper/pull/4368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] PerChannelBookieClient Enhancement: Self-Recovery Support in Corrupte… [bookkeeper]

2024-05-25 Thread via GitHub
shoothzj commented on PR #4020: URL: https://github.com/apache/bookkeeper/pull/4020#issuecomment-2131235762 Recently, I have no time to work on this, closed for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Implement a dialect-specific rule for unparsing an identifier with or without quotes [datafusion]

2024-05-25 Thread via GitHub
alamb commented on PR #10573: URL: https://github.com/apache/datafusion/pull/10573#issuecomment-2131235504 > This shouldn't have passed checks. > > ``` > + cargo fmt --all -- --check > `cargo metadata` exited with an error: error: failed to load manifest for workspace member

Re: [I] Determine if scan server tablet metadata cache blocks on refresh [accumulo]

2024-05-25 Thread via GitHub
cshannon closed issue #4544: Determine if scan server tablet metadata cache blocks on refresh URL: https://github.com/apache/accumulo/issues/4544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] build: fix JAVA_HOME not properly set in docker image [bookkeeper]

2024-05-25 Thread via GitHub
shoothzj commented on PR #4333: URL: https://github.com/apache/bookkeeper/pull/4333#issuecomment-2131235213 >> +1 for not hard-coding the path. >> Can we merge these two changed command into the previous one? The new one will generate more layers in docker Thank you for raising

Re: [PR] Minor: Csv Options Clean-up [datafusion]

2024-05-25 Thread via GitHub
alamb commented on PR #10650: URL: https://github.com/apache/datafusion/pull/10650#issuecomment-2131235103 > Maybe we can do the following: Instead of making every TableProviderFactory responsible for implementing this behavior in create, we can add some general mechanism at the trait

Re: [PR] (chores) multiple small cleanups [camel]

2024-05-25 Thread via GitHub
orpiske merged PR #14239: URL: https://github.com/apache/camel/pull/14239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support creating tags by adding `set_ref_snapshot` API [iceberg-python]

2024-05-25 Thread via GitHub
chinmay-bhat commented on code in PR #728: URL: https://github.com/apache/iceberg-python/pull/728#discussion_r1614623487 ## tests/table/test_init.py: ## @@ -652,6 +652,58 @@ def test_update_metadata_add_snapshot(table_v2: Table) -> None: assert

Re: [I] Library Guide: Building LogicalPlans [datafusion]

2024-05-25 Thread via GitHub
alamb commented on issue #7306: URL: https://github.com/apache/datafusion/issues/7306#issuecomment-2131234075 > What do you think we should do? I can add that paragraph, but maybe we also want to link the examples? What else do you think it's needed to close this Those both sound

Re: [PR] Enable background refresh for the scan server tablet metadata cache [accumulo]

2024-05-25 Thread via GitHub
cshannon merged PR #4551: URL: https://github.com/apache/accumulo/pull/4551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug] parseMessageMetadata error when broker entry metadata enable with high loading [pulsar]

2024-05-25 Thread via GitHub
semistone commented on issue #22601: URL: https://github.com/apache/pulsar/issues/22601#issuecomment-2131233568 I write repproduce steps and some investigate history in https://github.com/semistone/personal_notes/blob/main/pulsar_issue_22601/Test.md -- This is an automated

[Github-comments] Re: [geany/geany] Make Custom Target should have a directory combo box (Issue #3883)

2024-05-25 Thread Enrico Tröger via Github-comments
But why not, the combo box could be empty by default and so is not used. If the user wants to adds something, then it will be used. OTOH, this can also be achieved by using "-C src all" (or whatever target is desired) using the existing functionality. -- Reply to this email directly or view

Re: [PR] Create a geoparquet module and add dependencies [incubator-baremaps]

2024-05-25 Thread via GitHub
bchapuis commented on code in PR #855: URL: https://github.com/apache/incubator-baremaps/pull/855#discussion_r1614617900 ## baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/hadoop/GeoParquetGroupWriteSupport.java: ## Review Comment: Yes, I kept them with

Re: [PR] [WebGPU] Update error messages to be more user-friendly [tvm]

2024-05-25 Thread via GitHub
tqchen merged PR #17021: URL: https://github.com/apache/tvm/pull/17021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Allow using 'serverReturnFinalResult' to optimize server partitioned table [pinot]

2024-05-25 Thread via GitHub
xiangfu0 commented on code in PR #13208: URL: https://github.com/apache/pinot/pull/13208#discussion_r1614617114 ## pinot-core/src/main/java/org/apache/pinot/core/data/table/IndexedTable.java: ## @@ -38,6 +38,7 @@ @SuppressWarnings({"rawtypes", "unchecked"}) public abstract

Re: [PR] [CALCITE-5737] Support jdk21 and jdk22 [calcite]

2024-05-25 Thread via GitHub
snuyanzin commented on PR #3793: URL: https://github.com/apache/calcite/pull/3793#issuecomment-2131231175 I will merge tomorrow if there is no objections -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Fix code inspections for db-protocol modules [shardingsphere]

2024-05-25 Thread via GitHub
strongduanmu merged PR #31390: URL: https://github.com/apache/shardingsphere/pull/31390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Allow using 'serverReturnFinalResult' to optimize server partitioned table [pinot]

2024-05-25 Thread via GitHub
xiangfu0 commented on code in PR #13208: URL: https://github.com/apache/pinot/pull/13208#discussion_r1614606818 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/funnel/FunnelCountAggregationFunction.java: ## @@ -164,13 +174,12 @@ public LongArrayList

Re: [PR] Allow using 'serverReturnFinalResult' to optimize server partitioned table [pinot]

2024-05-25 Thread via GitHub
xiangfu0 commented on PR #13208: URL: https://github.com/apache/pinot/pull/13208#issuecomment-2131230970 Overall LGTM. I feel those are good function level annotations, maybe we can try to annotate aggregation functions to allow return Final if aggregate column or groupBy key is server

Re: [PR] fix(6509): improve the test case coverage of [saga] module to 70% [incubator-seata]

2024-05-25 Thread via GitHub
lightClouds917 commented on code in PR #6519: URL: https://github.com/apache/incubator-seata/pull/6519#discussion_r1614615477 ## saga/seata-saga-processctrl/src/test/java/org/apache/seata/saga/proctrl/handler/DefaultRouterHandlerTest.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed

[Github-comments] Re: [geany/geany] #!/bin/busybox ash (Issue #3884)

2024-05-25 Thread Enrico Tröger via Github-comments
Alternative and already working, you can add a header line to hint Geany what filetype to use: ```sh #!/bin/busybox ash # -*- Sh -*- ``` It is roughly described in https://geany.org/manual/#various-preferences (search for "extract_filetype_regex"). -- Reply to this email directly or

Re: [PR] fix(6502): supplement the store unit test cases in the [core] module. [incubator-seata]

2024-05-25 Thread via GitHub
lightClouds917 commented on PR #6524: URL: https://github.com/apache/incubator-seata/pull/6524#issuecomment-2131230441 add the change log please,You can refer to others -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] fix(6502): supplement the store unit test cases in the [core] module. [incubator-seata]

2024-05-25 Thread via GitHub
lightClouds917 commented on PR #6524: URL: https://github.com/apache/incubator-seata/pull/6524#issuecomment-2131229997 Finished or in progress? If possible, increase the overall coverage of the core package -- This is an automated message from the Apache Git Service. To respond to

Re: [I] [Bug] [UI] pagination query cannot be used [dolphinscheduler]

2024-05-25 Thread via GitHub
SbloodyS commented on issue #16070: URL: https://github.com/apache/dolphinscheduler/issues/16070#issuecomment-2131229637 This will be fixed in #15619. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Bug] [UI] pagination query cannot be used [dolphinscheduler]

2024-05-25 Thread via GitHub
SbloodyS closed issue #16070: [Bug] [UI] pagination query cannot be used URL: https://github.com/apache/dolphinscheduler/issues/16070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[Github-comments] Re: [geany/www.geany.org] Try to more explicit state SEPA only for bank transfers (PR #50)

2024-05-25 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -16,7 +16,7 @@ More than financial support, the Geany project needs help > with: If you want to donate money to the Geany project, it will be used to support further development of Geany, to pay running costs for hosting and domains and support

Re: [I] Selecting struct field within field produces unexpected results [datafusion-python]

2024-05-25 Thread via GitHub
timsaucer commented on issue #715: URL: https://github.com/apache/datafusion-python/issues/715#issuecomment-2131229316 My statement above about testing on rust side is likely incorrect. I ran the same test above but loading the dataframe from a parquet file instead of creating in memory

Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]

2024-05-25 Thread via GitHub
doublep commented on PR #232: URL: https://github.com/apache/commons-beanutils/pull/232#issuecomment-2131229026 @garydgregory I just pushed some Javadoc changes. Feel free to rewrite or adjust as you prefer, easier this way than negotiating in advance. -- This is an automated message

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-25 Thread via GitHub
emkornfield commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1614611250 ## src/main/thrift/parquet.thrift: ## @@ -1165,6 +1317,62 @@ struct FileMetaData { 9: optional binary footer_signing_key_metadata } +/** Metadata for a

[PR] Fix code inspections for db-protocol modules [shardingsphere]

2024-05-25 Thread via GitHub
terrymanu opened a new pull request, #31390: URL: https://github.com/apache/shardingsphere/pull/31390 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

  1   2   3   4   5   6   7   8   9   10   >