https://github.com/ilovepi requested changes to this pull request.
I'm not completely sure we want to use absolute paths, but since this mostly
seems related to URLs and not file system paths, its probably fine.
Please add some tests for this. It's preferable if we can pre-commit tests with
@@ -1,48 +1,22 @@
-// Append using posix-style a file name or directory to Base
-function append(Base, New) {
- if (!New)
-return Base;
- if (Base)
-Base += "/";
- Base += New;
- return Base;
-}
-
-// Get relative path to access FilePath from CurrentDirectory
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/93281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -290,3 +294,295 @@ void SemaHLSL::DiagnoseAttrStageMismatch(
<< A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage)
<< (AllowedStages.size() != 1) << join(StageStrings, ", ");
}
+
+namespace {
+
+/// This class implements HLSL availability diagnostics for default
@@ -0,0 +1,98 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute \
+// RUN: -fsyntax-only -verify %s
+
+__attribute__((availability(shadermodel, introduced = 6.5)))
+float fx(float); // #fx
+
+__attribute__((availability(shadermodel, introduced = 5.0, environment =
@@ -290,3 +294,295 @@ void SemaHLSL::DiagnoseAttrStageMismatch(
<< A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage)
<< (AllowedStages.size() != 1) << join(StageStrings, ", ");
}
+
+namespace {
+
+/// This class implements HLSL availability diagnostics for default
@@ -290,3 +294,295 @@ void SemaHLSL::DiagnoseAttrStageMismatch(
<< A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage)
<< (AllowedStages.size() != 1) << join(StageStrings, ", ");
}
+
+namespace {
+
+/// This class implements HLSL availability diagnostics for default
@@ -290,3 +294,295 @@ void SemaHLSL::DiagnoseAttrStageMismatch(
<< A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage)
<< (AllowedStages.size() != 1) << join(StageStrings, ", ");
}
+
+namespace {
+
+/// This class implements HLSL availability diagnostics for default
@@ -290,3 +294,295 @@ void SemaHLSL::DiagnoseAttrStageMismatch(
<< A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage)
<< (AllowedStages.size() != 1) << join(StageStrings, ", ");
}
+
+namespace {
+
+/// This class implements HLSL availability diagnostics for default
@@ -290,3 +294,295 @@ void SemaHLSL::DiagnoseAttrStageMismatch(
<< A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage)
<< (AllowedStages.size() != 1) << join(StageStrings, ", ");
}
+
+namespace {
+
+/// This class implements HLSL availability diagnostics for default
@@ -0,0 +1,108 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-library \
+// RUN: -fsyntax-only -Wno-error=hlsl-availability -verify %s
+
+__attribute__((availability(shadermodel, introduced = 6.5)))
+float fx(float); // #fx
+
+__attribute__((availability(shadermodel,
@@ -290,3 +294,295 @@ void SemaHLSL::DiagnoseAttrStageMismatch(
<< A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage)
<< (AllowedStages.size() != 1) << join(StageStrings, ", ");
}
+
+namespace {
+
+/// This class implements HLSL availability diagnostics for default
@@ -290,3 +294,295 @@ void SemaHLSL::DiagnoseAttrStageMismatch(
<< A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage)
<< (AllowedStages.size() != 1) << join(StageStrings, ", ");
}
+
+namespace {
+
+/// This class implements HLSL availability diagnostics for default
@@ -290,3 +294,295 @@ void SemaHLSL::DiagnoseAttrStageMismatch(
<< A << HLSLShaderAttr::ConvertShaderTypeToStr(Stage)
<< (AllowedStages.size() != 1) << join(StageStrings, ", ");
}
+
+namespace {
+
+/// This class implements HLSL availability diagnostics for default
@@ -1081,6 +1088,12 @@ static llvm::Triple::EnvironmentType
getEnvironmentType(llvm::StringRef Environm
.Case("hull", llvm::Triple::Hull)
.Case("domain", llvm::Triple::Domain)
.Case("compute", llvm::Triple::Compute)
+
@@ -1049,31 +1047,33 @@ static llvm::Error CopyFile(StringRef FilePath,
StringRef OutDirectory) {
std::error_code FileErr = llvm::sys::fs::copy_file(PathRead, PathWrite);
if (FileErr != OK) {
return llvm::createStringError(llvm::inconvertibleErrorCode(),
-
@@ -82,6 +82,7 @@ function createIndex(Index) {
document.addEventListener("DOMContentLoaded", function() {
// JsonIndex is a variable from another file that contains the index
// in JSON format
- var Index = JSON.parse(JsonIndex);
- createIndex(Index);
+
@@ -179,7 +183,7 @@ Example usage for a project using a compile commands
database:
SourceRoot,
RepositoryUrl,
{UserStylesheets.begin(), UserStylesheets.end()},
- {"index.js", "index_json.js"}};
+ {"index.js"}};
ilovepi wrote:
I
@@ -491,6 +491,7 @@ struct ClangDocContext {
std::string SourceRoot; // Directory where processed files are stored.
Links
// to definition locations will only be generated
if
// the file is in this dir.
+
@@ -155,6 +155,10 @@ Example usage for a project using a compile commands
database:
return 1;
}
+ // add option to customize url fragment
+ // such as
+ //
https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-doc/ClangDocMain.cpp#L1
+
@@ -1049,31 +1047,33 @@ static llvm::Error CopyFile(StringRef FilePath,
StringRef OutDirectory) {
std::error_code FileErr = llvm::sys::fs::copy_file(PathRead, PathWrite);
if (FileErr != OK) {
return llvm::createStringError(llvm::inconvertibleErrorCode(),
-
@@ -1049,31 +1047,33 @@ static llvm::Error CopyFile(StringRef FilePath,
StringRef OutDirectory) {
std::error_code FileErr = llvm::sys::fs::copy_file(PathRead, PathWrite);
if (FileErr != OK) {
return llvm::createStringError(llvm::inconvertibleErrorCode(),
-
https://github.com/ilovepi requested changes to this pull request.
I've noted several items that need to be addressed in line before this lands.
Both the commit title and description need to be updated. Please add a tag
`[clang-doc]` to the commit title, and include the full details of the
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/93276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -965,6 +965,16 @@ void Preprocessor::Lex(Token ) {
LastTokenWasAt = Result.is(tok::at);
--LexLevel;
+ if (Result.is(tok::l_brace)) {
+CurlyBraceLevel++;
+ } else if (Result.is(tok::r_brace)) {
+if (!RoundingPragmas.empty() &&
efriedma-quic
https://github.com/efriedma-quic commented:
This approach seems much better.
https://github.com/llvm/llvm-project/pull/92699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic edited
https://github.com/llvm/llvm-project/pull/92699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
farzonl wrote:
> IMO it'd be good to have a bit more context in the commit description about
> why this is being done. If you follow the breadcrumbs from the issue to the
> thread in the PR I think you can put it together, but a more local summary
> might be helpful.
done
https://github.com/farzonl edited
https://github.com/llvm/llvm-project/pull/93314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/93318
>From 16ec4c725d86020831541a64bada8f4629a0972c Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:15:54 +0300
Subject: [PATCH 01/10] [clang][ci] Move libc++ testing into the main PR
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/93318
>From 16ec4c725d86020831541a64bada8f4629a0972c Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:15:54 +0300
Subject: [PATCH 1/9] [clang][ci] Move libc++ testing into the main PR
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/93318
>From 16ec4c725d86020831541a64bada8f4629a0972c Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:15:54 +0300
Subject: [PATCH 1/8] [clang][ci] Move libc++ testing into the main PR
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/93318
>From 16ec4c725d86020831541a64bada8f4629a0972c Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:15:54 +0300
Subject: [PATCH 1/7] [clang][ci] Move libc++ testing into the main PR
Timm =?utf-8?q?Bäder?= ,Sven van Haastregt
,Kiran Chandramohan
,Vyacheslav
Levytskyy ,Alexey Bataev
,Simon Pilgrim ,Simon Pilgrim
,Shilei Tian ,Matheus Izvekov
,Teresa Johnson ,Matheus Izvekov
,Timm =?utf-8?q?Bäder?= ,Simon
Pilgrim ,
Timm =?utf-8?q?Bäder?= ,Daniel Paoliello
,Shih-Po Hung
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/93318
>From 16ec4c725d86020831541a64bada8f4629a0972c Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:15:54 +0300
Subject: [PATCH 1/6] [clang][ci] Move libc++ testing into the main PR
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/93318
>From 16ec4c725d86020831541a64bada8f4629a0972c Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:15:54 +0300
Subject: [PATCH 1/5] [clang][ci] Move libc++ testing into the main PR
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/93318
>From 16ec4c725d86020831541a64bada8f4629a0972c Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:15:54 +0300
Subject: [PATCH 1/4] [clang][ci] Move libc++ testing into the main PR
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/93318
>From 16ec4c725d86020831541a64bada8f4629a0972c Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 24 May 2024 19:15:54 +0300
Subject: [PATCH 1/3] [clang][ci] Move libc++ testing into the main PR
https://github.com/bogner approved this pull request.
https://github.com/llvm/llvm-project/pull/93314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -183,6 +183,14 @@ void foo(double *d, float f, float *fp, long double *l,
int *i, const char *c, _
// CHECK: call x86_fp80 @llvm.experimental.constrained.sqrt.f80(x86_fp80
%{{.*}}, metadata !"round.tonearest", metadata !"fpexcept.strict")
// CHECK: call fp128
https://github.com/damyanp approved this pull request.
IMO it'd be good to have a bit more context in the commit description about why
this is being done. If you follow the breadcrumbs from the issue to the thread
in the PR I think you can put it together, but a more local summary might be
https://github.com/damyanp edited
https://github.com/llvm/llvm-project/pull/93314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1426,12 +1428,9 @@ class AnnotatingParser {
// the colon are passed as macro arguments.
Tok->setType(TT_ObjCMethodExpr);
} else if (Contexts.back().ContextKind == tok::l_paren &&
- !Line.InPragmaDirective) {
-if
https://github.com/gedare updated
https://github.com/llvm/llvm-project/pull/92617
>From b4a8c06b79ec10ed2f53a7410bd847ecfa9e8450 Mon Sep 17 00:00:00 2001
From: Gedare Bloom
Date: Fri, 17 May 2024 17:18:59 -0600
Subject: [PATCH 1/3] [clang-format]: Annotate colons found in inline assembly
https://github.com/yronglin deleted
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/farzonl updated
https://github.com/llvm/llvm-project/pull/93314
>From 683dfa875e024acba12b229dbecd6d10573c891f Mon Sep 17 00:00:00 2001
From: Farzon Lotfi
Date: Fri, 24 May 2024 10:01:52 -0400
Subject: [PATCH 1/2] [clang] Add tanf16 builtin and support for tan
constrained
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7eeec8e6d10a796974c3439529f3de690251b004
683dfa875e024acba12b229dbecd6d10573c891f --
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-codegen
Author: Farzon Lotfi (farzonl)
Changes
- `Builtins.td` - replace TanF128 with F16F128MathTemplate
- `CGBuiltin.cpp` - map existing tan builtins to `tan` and `constrained_tan`
intrinsic
-
https://github.com/farzonl created
https://github.com/llvm/llvm-project/pull/93314
- `Builtins.td` - replace TanF128 with F16F128MathTemplate
- `CGBuiltin.cpp` - map existing tan builtins to `tan` and `constrained_tan`
intrinsic
- `ConstrainedOps.def` map tan and constrained_tan to an
https://github.com/MitalAshok edited
https://github.com/llvm/llvm-project/pull/78112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/daniel-grumberg closed
https://github.com/llvm/llvm-project/pull/93205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Daniel Grumberg
Date: 2024-05-24T16:32:25+01:00
New Revision: ab7e6b66fdd768f566e76972755de3578f1d0f4a
URL:
https://github.com/llvm/llvm-project/commit/ab7e6b66fdd768f566e76972755de3578f1d0f4a
DIFF:
https://github.com/dschuff closed
https://github.com/llvm/llvm-project/pull/93272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Brendan Dahl
Date: 2024-05-24T08:31:07-07:00
New Revision: 4ebe9bba59389b0788ca01ec3f4bd2cb7f567a17
URL:
https://github.com/llvm/llvm-project/commit/4ebe9bba59389b0788ca01ec3f4bd2cb7f567a17
DIFF:
https://github.com/llvm/llvm-project/commit/4ebe9bba59389b0788ca01ec3f4bd2cb7f567a17.diff
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/93272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/QuietMisdreavus approved this pull request.
https://github.com/llvm/llvm-project/pull/93205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nga888 updated
https://github.com/llvm/llvm-project/pull/93302
>From 0cfd700e604e5ec68856dfa7daca378e71795fb2 Mon Sep 17 00:00:00 2001
From: Andrew Ng
Date: Mon, 20 May 2024 18:26:32 +0100
Subject: [PATCH 1/3] [clang] Fix loss of `dllexport` for exported template
https://github.com/dschuff approved this pull request.
https://github.com/llvm/llvm-project/pull/93261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 70a54bca6f7f9f45b4b17974ddaa01cd7a5d64be
5425cfb18b53f767fd9dc18e5ac7e196b5349f23 --
@@ -4849,9 +4852,12 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef
MangledName, llvm::Type *Ty,
Entry->setLinkage(llvm::Function::ExternalLinkage);
}
-// Handle dropped DLL attributes.
-if (D && !D->hasAttr() && !D->hasAttr() &&
-
balazske wrote:
> Could you please show your commands which reproduced this crash? I tested
> locally with the following commands and it runs OK.
>
> ```c++
> clang++ -cc1 -std=c++17 -emit-pch -o test.cpp.ast test.cpp
> clang++ -cc1 -x c++ -ast-merge test.cpp.ast /dev/null -ast-dump
> ```
https://github.com/nga888 updated
https://github.com/llvm/llvm-project/pull/93302
>From 0cfd700e604e5ec68856dfa7daca378e71795fb2 Mon Sep 17 00:00:00 2001
From: Andrew Ng
Date: Mon, 20 May 2024 18:26:32 +0100
Subject: [PATCH 1/2] [clang] Fix loss of `dllexport` for exported template
https://github.com/dpaoliello closed
https://github.com/llvm/llvm-project/pull/93235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Daniel Paoliello
Date: 2024-05-24T07:56:17-07:00
New Revision: 53b904823cba4e93d58793b0804407f812477724
URL:
https://github.com/llvm/llvm-project/commit/53b904823cba4e93d58793b0804407f812477724
DIFF:
@@ -4849,9 +4852,12 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef
MangledName, llvm::Type *Ty,
Entry->setLinkage(llvm::Function::ExternalLinkage);
}
-// Handle dropped DLL attributes.
-if (D && !D->hasAttr() && !D->hasAttr() &&
-
nga888 wrote:
> Does the test exercise both modified paths? I'm guessing it only exercises
> GetOrCreateLLVMFunction, but I'm not a codegen expert.
Only 1 path is "exercised" but I believe neither path of the removed code was
exercised previously and no other tests are affected by the code
Author: Timm Bäder
Date: 2024-05-24T16:47:46+02:00
New Revision: 82a5d0da6007609ddcb3190530e0a269ae0452db
URL:
https://github.com/llvm/llvm-project/commit/82a5d0da6007609ddcb3190530e0a269ae0452db
DIFF:
https://github.com/llvm/llvm-project/commit/82a5d0da6007609ddcb3190530e0a269ae0452db.diff
@@ -4640,6 +4647,306 @@ class FunctionNoProtoType : public FunctionType, public
llvm::FoldingSetNode {
}
};
+//
--
+
+/// Represents an abstract function effect, using just an enumeration
@@ -4849,9 +4852,12 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef
MangledName, llvm::Type *Ty,
Entry->setLinkage(llvm::Function::ExternalLinkage);
}
-// Handle dropped DLL attributes.
-if (D && !D->hasAttr() && !D->hasAttr() &&
-
https://github.com/dougsonos edited
https://github.com/llvm/llvm-project/pull/84983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dougsonos edited
https://github.com/llvm/llvm-project/pull/84983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Bäder
Date: 2024-05-24T16:40:38+02:00
New Revision: d8c8c8c7b91ce51f3e2fc088a5fd365b23cd9889
URL:
https://github.com/llvm/llvm-project/commit/d8c8c8c7b91ce51f3e2fc088a5fd365b23cd9889
DIFF:
https://github.com/llvm/llvm-project/commit/d8c8c8c7b91ce51f3e2fc088a5fd365b23cd9889.diff
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/93266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Matheus Izvekov
Date: 2024-05-24T11:38:22-03:00
New Revision: ad190fcf15c1d0beea1ba93b4d250e15d2e944f4
URL:
https://github.com/llvm/llvm-project/commit/ad190fcf15c1d0beea1ba93b4d250e15d2e944f4
DIFF:
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/93266
>From 5b592204ddef177d612f8455f4e14ab9cf9c06bd Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Thu, 23 May 2024 23:57:01 -0300
Subject: [PATCH] [clang] add fallback to expr in the template differ when
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/93266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/93265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Matheus Izvekov
Date: 2024-05-24T11:33:16-03:00
New Revision: bd851eec34749023e5d967c03847df1635bbfa57
URL:
https://github.com/llvm/llvm-project/commit/bd851eec34749023e5d967c03847df1635bbfa57
DIFF:
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/93265
>From 2546c2c5d9e1bc6d1d4ddd818b4017073f17cec0 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Thu, 23 May 2024 21:23:21 -0300
Subject: [PATCH] [clang] Avoid crash due to unimplemented StructuralValue
@@ -4849,9 +4852,12 @@ CodeGenModule::GetOrCreateLLVMGlobal(StringRef
MangledName, llvm::Type *Ty,
Entry->setLinkage(llvm::Function::ExternalLinkage);
}
-// Handle dropped DLL attributes.
-if (D && !D->hasAttr() && !D->hasAttr() &&
-
@@ -4554,8 +4554,11 @@ llvm::Constant *CodeGenModule::GetOrCreateLLVMFunction(
Entry->setLinkage(llvm::Function::ExternalLinkage);
}
-// Handle dropped DLL attributes.
-if (D && !D->hasAttr() && !D->hasAttr() &&
+// Handle dropped dllimport.
+if (D
https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/93302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 commented:
Does the test exercise both modified paths? I'm guessing it only exercises
GetOrCreateLLVMFunction, but I'm not a codegen expert.
https://github.com/llvm/llvm-project/pull/93302
___
cfe-commits mailing list
@@ -4640,6 +4647,306 @@ class FunctionNoProtoType : public FunctionType, public
llvm::FoldingSetNode {
}
};
+//
--
+
+/// Represents an abstract function effect, using just an enumeration
@@ -1329,6 +1341,100 @@ bool Preprocessor::LexAfterModuleImport(Token ) {
return true;
}
+/// Lex a token following the 'module' contextual keyword.
+///
+/// [cpp.module]/p2:
+/// The pp-tokens, if any, of a pp-module shall be of the form:
+/// pp-module-name
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Andrew Ng (nga888)
Changes
In commit 0a20f541, "Better codegen support for DLL attributes being dropped
after the first declaration (PR20792)", code was added to enable "dropping" of
DLL attributes. The specific issue and example
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Andrew Ng (nga888)
Changes
In commit 0a20f541, "Better codegen support for DLL attributes being dropped
after the first declaration (PR20792)", code was added to enable "dropping" of
DLL attributes. The specific issue and example given
https://github.com/nga888 created
https://github.com/llvm/llvm-project/pull/93302
In commit 0a20f541, "Better codegen support for DLL attributes being dropped
after the first declaration (PR20792)", code was added to enable "dropping" of
DLL attributes. The specific issue and example given
@@ -0,0 +1,94 @@
+//===-- SemaSystemZ.cpp -- SystemZ target-specific routines
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/uweigand edited
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/uweigand commented:
See comment fix - otherwise SystemZ part LGTM.
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/93265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1576,7 +1576,10 @@ ExprResult Parser::ParseLambdaExpressionAfterIntroducer(
TrailingReturnTypeLoc, ),
std::move(Attributes), DeclEndLoc);
-Actions.ActOnLambdaClosureQualifiers(Intro, MutableLoc);
+// We have called
https://github.com/erichkeane commented:
I hope @cor3ntin comes and checks this out, but it generally looks OK to me. 1
oddity I'd like to hear about (why we can't do ActOnLambdaClosureQualifiers in
the same place).
https://github.com/llvm/llvm-project/pull/93206
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/93206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov approved this pull request.
Can you also add a test based on my example?
With also a variant on that in which the bad conversion happens on the last
element of the pack, instead of the last parameter.
Lastly, please namespace the tests with the name of, or add a
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/93079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11298,8 +11298,9 @@ static void DiagnoseBadConversion(Sema ,
OverloadCandidate *Cand,
Expr *FromExpr = Conv.Bad.FromExpr;
QualType FromTy = Conv.Bad.getFromType();
QualType ToTy = Conv.Bad.getToType();
- SourceRange ToParamRange =
- !isObjectArgument ?
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Balázs Kéri (balazske)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/93299.diff
3 Files Affected:
- (modified) clang/docs/analyzer/checkers.rst (+10)
- (modified)
https://github.com/balazske created
https://github.com/llvm/llvm-project/pull/93299
None
From 9baa8cc3a1a738a43deee811b51593db85d5c88c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?=
Date: Fri, 24 May 2024 15:22:22 +0200
Subject: [PATCH] [clang][analyzer]
301 - 400 of 434028 matches
Mail list logo