https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/93217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/93252
>From 994791b862dfecf7bb370f32834645011e69137d Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Fri, 24 May 2024 01:39:35 +0300
Subject: [PATCH 1/2] fix(92759): use const references
---
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6d2b23c46e6ad174d16721c4c42a00a2835eab92
994791b862dfecf7bb370f32834645011e69137d --
https://github.com/aheejin approved this pull request.
LGTM % `!HasHalfPrecision` thing
By the way I guess you can try getting a commit access soon? I think it is
still "Send an an email to Chris" though...
https://github.com/llvm/llvm-project/pull/93228
@@ -90,6 +90,7 @@ class LLVM_LIBRARY_VISIBILITY WebAssemblyTargetInfo : public
TargetInfo {
StringRef getABI() const override;
bool setABI(const std::string ) override;
+ bool useFP16ConversionIntrinsics() const override { return false; }
aheejin wrote:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Oleksandr T. (a-tarasyuk)
Changes
Fixes #92759
---
Full diff: https://github.com/llvm/llvm-project/pull/93252.diff
1 Files Affected:
- (modified) clang/lib/Frontend/Rewrite/RewriteModernObjC.cpp (+17-14)
``diff
diff --git
https://github.com/a-tarasyuk created
https://github.com/llvm/llvm-project/pull/93252
Fixes #92759
>From 994791b862dfecf7bb370f32834645011e69137d Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Fri, 24 May 2024 01:39:35 +0300
Subject: [PATCH] fix(92759): use const references
---
cjappl wrote:
Weekly ping of reviewers
@yln @vitalybuka @Sirraide @AaronBallman @zygoloid @compnerd @petrhosek
@isanbard
Looking for weighing in on any of the code as it stands now, or the naming
question posed by MaskRay
@@ -90,6 +90,7 @@ class LLVM_LIBRARY_VISIBILITY WebAssemblyTargetInfo : public
TargetInfo {
StringRef getABI() const override;
bool setABI(const std::string ) override;
+ bool useFP16ConversionIntrinsics() const override { return false; }
brendandahl
dcci wrote:
Example error while I reduce:
```
fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/stl_vector.h:404:21:
error: static assertion failed due to requirement
'is_same, std::allocator>,
quic::Interval>::value': std::vector must have the same
value_type as its
dcci wrote:
I am seeing something similar in vector (without modules). I'm reducing a test
case now.
https://github.com/llvm/llvm-project/pull/92855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/92704
>From 433b8e142d05a8fe2206ae0cec62423b21e792d2 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Sun, 19 May 2024 11:10:38 -0700
Subject: [PATCH 1/6] HLSL Default and Relaxed Availability Diagnostics (#3)
---
https://github.com/HendrikHuebner updated
https://github.com/llvm/llvm-project/pull/91057
From 487ec3df346924f71b66e5753c844c97991e Mon Sep 17 00:00:00 2001
From: hhuebner
Date: Sat, 4 May 2024 13:49:38 +0200
Subject: [PATCH] [Clang] Throw error when calling atomic with pointer to zero
jyknight wrote:
Heads up: this commit has triggered some weird errors for a compile, but only
when clang header modules are enabled. A std::vector, that's built through a
large amount of template gunk that definitely involves template template
parameter matching, ends up failing vector's
maryammo wrote:
In `PPCTargetMachine::PPCABI computeTargetABI` it specifies the ABI with this
```
switch (TT.getArch()) {
case Triple::ppc64le:
return PPCTargetMachine::PPC_ABI_ELFv2;
case Triple::ppc64:
if (TT.isPPC64ELFv2ABI())
return PPCTargetMachine::PPC_ABI_ELFv2;
else
@@ -90,6 +90,7 @@ class LLVM_LIBRARY_VISIBILITY WebAssemblyTargetInfo : public
TargetInfo {
StringRef getABI() const override;
bool setABI(const std::string ) override;
+ bool useFP16ConversionIntrinsics() const override { return false; }
dschuff wrote:
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/93233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Louis Dionne
Date: 2024-05-24T01:21:55+04:00
New Revision: dc1bfbc9735ba82bf319e6aa2209e1a795fb659f
URL:
https://github.com/llvm/llvm-project/commit/dc1bfbc9735ba82bf319e6aa2209e1a795fb659f
DIFF:
https://github.com/llvm/llvm-project/commit/dc1bfbc9735ba82bf319e6aa2209e1a795fb659f.diff
https://github.com/hanickadot approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/89869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chapuni approved this pull request.
I'd like other approvals by clang guys. @AaronBallman Could you nominate anyone?
https://github.com/llvm/llvm-project/pull/89869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,83 @@
+.. title:: clang-tidy - bugprone-exception-rethrow
+
+bugprone-exception-rethrow
+==
+
+Identifies problematic exception rethrowing, especially with caught exception
+variables or empty throw statements outside catch blocks.
+
+In C++
@@ -0,0 +1,83 @@
+.. title:: clang-tidy - bugprone-exception-rethrow
+
+bugprone-exception-rethrow
+==
+
+Identifies problematic exception rethrowing, especially with caught exception
+variables or empty throw statements outside catch blocks.
+
+In C++
@@ -0,0 +1,103 @@
+// RUN: %check_clang_tidy %s bugprone-exception-rethrow %t -- -- -fexceptions
+
+struct exception {};
+
+namespace std {
+ template
+ T&& move(T &) {
+return static_cast(x);
+ }
+}
+
+void correct() {
+ try {
+ throw exception();
+ } catch(const
@@ -0,0 +1,68 @@
+//===--- ExceptionRethrowCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,83 @@
+.. title:: clang-tidy - bugprone-exception-rethrow
+
+bugprone-exception-rethrow
+==
+
+Identifies problematic exception rethrowing, especially with caught exception
+variables or empty throw statements outside catch blocks.
+
+In C++
@@ -0,0 +1,68 @@
+//===--- ExceptionRethrowCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,103 @@
+// RUN: %check_clang_tidy %s bugprone-exception-rethrow %t -- -- -fexceptions
+
+struct exception {};
+
+namespace std {
+ template
+ T&& move(T &) {
+return static_cast(x);
+ }
+}
+
+void correct() {
+ try {
+ throw exception();
+ } catch(const
https://github.com/isuckatcs requested changes to this pull request.
Apart from some docs changes and the lambda false positive, the check looks
good.
https://github.com/llvm/llvm-project/pull/86448
___
cfe-commits mailing list
@@ -0,0 +1,83 @@
+.. title:: clang-tidy - bugprone-exception-rethrow
+
+bugprone-exception-rethrow
+==
+
+Identifies problematic exception rethrowing, especially with caught exception
+variables or empty throw statements outside catch blocks.
+
+In C++
@@ -0,0 +1,83 @@
+.. title:: clang-tidy - bugprone-exception-rethrow
+
+bugprone-exception-rethrow
+==
+
+Identifies problematic exception rethrowing, especially with caught exception
+variables or empty throw statements outside catch blocks.
+
+In C++
@@ -0,0 +1,68 @@
+//===--- ExceptionRethrowCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/isuckatcs edited
https://github.com/llvm/llvm-project/pull/86448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1062,6 +1063,159 @@ CodeGenFunction::emitFlexibleArrayMemberSize(const Expr
*E, unsigned Type,
return Builder.CreateSelect(Cmp, Res, ConstantInt::get(ResType, 0,
IsSigned));
}
+namespace {
+
+class ObjectSizeVisitor
+: public ConstStmtVisitor {
+ bool SkipASE;
+
@@ -1052,6 +1053,165 @@ CodeGenFunction::emitFlexibleArrayMemberSize(const Expr
*E, unsigned Type,
return Builder.CreateSelect(Cmp, Res, ConstantInt::get(ResType, 0,
IsSigned));
}
+namespace {
+
+class ObjectSizeVisitor
+: public ConstStmtVisitor {
+ bool SkipASE;
+
@@ -1062,6 +1063,159 @@ CodeGenFunction::emitFlexibleArrayMemberSize(const Expr
*E, unsigned Type,
return Builder.CreateSelect(Cmp, Res, ConstantInt::get(ResType, 0,
IsSigned));
}
+namespace {
+
+class ObjectSizeVisitor
+: public ConstStmtVisitor {
+ bool SkipASE;
+
@@ -1062,6 +1063,159 @@ CodeGenFunction::emitFlexibleArrayMemberSize(const Expr
*E, unsigned Type,
return Builder.CreateSelect(Cmp, Res, ConstantInt::get(ResType, 0,
IsSigned));
}
+namespace {
+
+class ObjectSizeVisitor
+: public ConstStmtVisitor {
+ bool SkipASE;
+
https://github.com/delcypher edited
https://github.com/llvm/llvm-project/pull/93121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/delcypher edited
https://github.com/llvm/llvm-project/pull/93121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/delcypher updated
https://github.com/llvm/llvm-project/pull/93121
>From 9e1a9e49b33d4b77d75cee243244dd66a40ea209 Mon Sep 17 00:00:00 2001
From: Dan Liew
Date: Fri, 17 May 2024 12:07:40 -0700
Subject: [PATCH] [BoundsSafety] Reland #93121 Allow 'counted_by' attribute on
https://github.com/delcypher updated
https://github.com/llvm/llvm-project/pull/93121
>From f9c8abdb243096b6fe0c2ad1a42023039ca7f1f2 Mon Sep 17 00:00:00 2001
From: Dan Liew
Date: Fri, 17 May 2024 12:07:40 -0700
Subject: [PATCH] [BoundsSafety] Reland #93121 Allow 'counted_by' attribute on
https://github.com/jcranmer-intel commented:
After banging my head on the desk trying to figure out why the tests were
giving such strange results, I realized the issue...
Could you please use `__builtin_complex` in the test to construct the complex
infinities instead of `__builtin_infinity()
https://github.com/delcypher updated
https://github.com/llvm/llvm-project/pull/93121
>From bc5b8bc34b50e2e98d2c6103c7b1c232a3e765b4 Mon Sep 17 00:00:00 2001
From: Dan Liew
Date: Fri, 17 May 2024 12:07:40 -0700
Subject: [PATCH] [BoundsSafety] Reland #93121 Allow 'counted_by' attribute on
@@ -4944,6 +4944,26 @@ void Parser::ParseStructDeclaration(
}
}
+// TODO: All callers of this function should be moved to
+// `Parser::ParseLexedAttributeList`.
+void Parser::ParseLexedCAttributeList(LateParsedAttrList , bool EnterScope,
+
@@ -1213,6 +1213,197 @@ static bool isRemark(const Record ) {
return ClsName == "CLASS_REMARK";
}
+// Presumes the text has been split at the first whitespace or hyphen.
+static bool isExemptAtStart(StringRef Text) {
+ // Fast path, the first character is lowercase or not
@@ -4944,6 +4944,26 @@ void Parser::ParseStructDeclaration(
}
}
+// TODO: All callers of this function should be moved to
+// `Parser::ParseLexedAttributeList`.
+void Parser::ParseLexedCAttributeList(LateParsedAttrList , bool EnterScope,
+
@@ -4944,6 +4944,26 @@ void Parser::ParseStructDeclaration(
}
}
+// TODO: All callers of this function should be moved to
+// `Parser::ParseLexedAttributeList`.
+void Parser::ParseLexedCAttributeList(LateParsedAttrList , bool EnterScope,
+
PiotrZSL wrote:
@nicovank Overall looks fine from functionality point of view.
Problem A)
Getting bunch of
```
task: wait_for=
cb=[as_completed.._on_completion() at
/usr/lib/python3.12/asyncio/tasks.py:618]>
Task was destroyed but it is pending!
```
When CTR+C a script. More graceful
https://github.com/amykhuang approved this pull request.
Thanks for the fix
https://github.com/llvm/llvm-project/pull/93235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4944,6 +4944,26 @@ void Parser::ParseStructDeclaration(
}
}
+// TODO: All callers of this function should be moved to
+// `Parser::ParseLexedAttributeList`.
+void Parser::ParseLexedCAttributeList(LateParsedAttrList , bool EnterScope,
+
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/92704
>From 433b8e142d05a8fe2206ae0cec62423b21e792d2 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Sun, 19 May 2024 11:10:38 -0700
Subject: [PATCH 1/6] HLSL Default and Relaxed Availability Diagnostics (#3)
---
@@ -1355,7 +1357,7 @@ static void verifyDiagnosticWording(const Record ) {
if (isDigit(FullDiagText.back()) && *(FullDiagText.end() - 2) == '}') {
// Scan backwards to find the opening curly brace.
size_t BraceCount = 1;
-auto Iter = FullDiagText.end() - /*}0*/
@@ -1302,7 +1302,8 @@ static void verifyDiagnosticWording(const Record ) {
// closing '}', skipping intermediary {} pairs.
size_t BraceCount = 1;
-auto Iter = FullDiagText.begin() + /*%select{*/ 8;
+constexpr size_t PercentSelectBraceLen = sizeof("%select{") -
@@ -1355,7 +1357,7 @@ static void verifyDiagnosticWording(const Record ) {
if (isDigit(FullDiagText.back()) && *(FullDiagText.end() - 2) == '}') {
// Scan backwards to find the opening curly brace.
size_t BraceCount = 1;
-auto Iter = FullDiagText.end() - /*}0*/
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/93229
>From 38d6d9b809e1cf9d6a8f577630c838421486cd04 Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Thu, 23 May 2024 14:55:16 -0400
Subject: [PATCH 1/2] Diagnose problematic diagnostic messages
Clang has
@@ -1213,6 +1213,194 @@ static bool isRemark(const Record ) {
return ClsName == "CLASS_REMARK";
}
+// Presumes the text has been split at the first whitespace or hyphen.
+static bool isExemptAtStart(StringRef Text) {
+ // Fast path, the first character is lowercase or not
Author: Xing Xue
Date: 2024-05-23T16:06:21-04:00
New Revision: 42b5daba504a8b4fd60a57dde93ee5d0118abf0b
URL:
https://github.com/llvm/llvm-project/commit/42b5daba504a8b4fd60a57dde93ee5d0118abf0b
DIFF:
https://github.com/llvm/llvm-project/commit/42b5daba504a8b4fd60a57dde93ee5d0118abf0b.diff
https://github.com/xingxue-ibm closed
https://github.com/llvm/llvm-project/pull/93204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
I will merge once the CI has passed. If someone else sees the CI green, feel
free to merge too.
@Endilll We could indeed "flatten" the `clang-ci` pipeline into the
`github-pull-requests` pipeline. Basically, instead of triggering the
`clang-ci` pipeline like this:
https://github.com/dmpolukhin approved this pull request.
https://github.com/llvm/llvm-project/pull/92659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/93229
>From 38d6d9b809e1cf9d6a8f577630c838421486cd04 Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Thu, 23 May 2024 14:55:16 -0400
Subject: [PATCH] Diagnose problematic diagnostic messages
Clang has some
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Daniel Paoliello (dpaoliello)
Changes
#67174 added the `__prefetch` intrinsic, however it used the wrong
signature: the argument should be `const void*`, not `void*`.
Docs:
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Daniel Paoliello (dpaoliello)
Changes
#67174 added the `__prefetch` intrinsic, however it used the wrong
signature: the argument should be `const void*`, not `void*`.
Docs:
Author: Aaron Ballman
Date: 2024-05-23T15:52:15-04:00
New Revision: 10be6c96b831a3511d2b381d5e1130d6b7e3e2ff
URL:
https://github.com/llvm/llvm-project/commit/10be6c96b831a3511d2b381d5e1130d6b7e3e2ff
DIFF:
https://github.com/llvm/llvm-project/commit/10be6c96b831a3511d2b381d5e1130d6b7e3e2ff.diff
https://github.com/dpaoliello created
https://github.com/llvm/llvm-project/pull/93235
#67174 added the `__prefetch` intrinsic, however it used the wrong signature:
the argument should be `const void*`, not `void*`.
Docs:
https://github.com/tstellar approved this pull request.
LGTM. Thanks, this should help free up some builder resources.
https://github.com/llvm/llvm-project/pull/93233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
AMP999 wrote:
This patch seems to break the following example (works in trunk, breaks after
this patch). Could you please add a test case for this?
https://godbolt.org/z/rdn74xn9M
```
struct S {
bool operator==(const S&) const = default;
};
struct Derived : S {
int j_ = 0;
};
https://github.com/Endilll approved this pull request.
OK, I'll try to add this testing to "GitHub Pull Requests" later so that we can
avoid building Clang twice.
https://github.com/llvm/llvm-project/pull/93233
___
cfe-commits mailing list
ldionne wrote:
> Do we even need to build Clang and run libc++ jobs? I don't even see them
> linked in libc++ PR, even besides the fact that I think libc++ is fully
> tested with GitHub Actions.
What we're testing is that the changes to Clang didn't break libc++. We're
testing Clang via
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/93233
>From 89afeebd55e0ae1167f5af803eb192b73a6e6799 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Thu, 23 May 2024 15:31:11 -0400
Subject: [PATCH 1/2] [clang][ci] Remove unnecessary BuildKite jobs for Clang
1.
Endilll wrote:
Do we even need to build Clang and run libc++ jobs? I don't even see them
linked in libc++ PR, even besides the fact that I think libc++ is fully tested
with GitHub Actions.
https://github.com/llvm/llvm-project/pull/93233
___
https://github.com/tstellar commented:
If we aren't running the tests any more, can we build clang with
`-DLLVM_TARGETS_TO_BUILD=Native`
https://github.com/llvm/llvm-project/pull/93233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Louis Dionne (ldionne)
Changes
1. Remove the format-checking job from the BuildKite pipeline. We now have a
monorepo-wide format checker implemented with Github Actions, so that should
not be necessary anymore.
2. Stop building and
bogner wrote:
I don't really understand the rationale for this, and it's kind of annoying.
Most of the compiler's flags behave in the "last one wins" fashion (such as
`-O2` and `-O0`) and it's always been convenient to add the flag you want at
the end. Why treat action flags any differently?
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/93233
1. Remove the format-checking job from the BuildKite pipeline. We now have a
monorepo-wide format checker implemented with Github Actions, so that should
not be necessary anymore.
2. Stop building and testing
@@ -1213,6 +1213,194 @@ static bool isRemark(const Record ) {
return ClsName == "CLASS_REMARK";
}
+// Presumes the text has been split at the first whitespace or hyphen.
+static bool isExemptAtStart(StringRef Text) {
+ // Fast path, the first character is lowercase or not
@@ -1213,6 +1213,194 @@ static bool isRemark(const Record ) {
return ClsName == "CLASS_REMARK";
}
+// Presumes the text has been split at the first whitespace or hyphen.
+static bool isExemptAtStart(StringRef Text) {
+ // Fast path, the first character is lowercase or not
https://github.com/erichkeane approved this pull request.
1 suggestion on improving the diagnostics, else, LGTM.
https://github.com/llvm/llvm-project/pull/93229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -1213,6 +1213,194 @@ static bool isRemark(const Record ) {
return ClsName == "CLASS_REMARK";
}
+// Presumes the text has been split at the first whitespace or hyphen.
+static bool isExemptAtStart(StringRef Text) {
+ // Fast path, the first character is lowercase or not
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/93229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AMP999 wrote:
Could you explain a bit about why we check `Decl->isTriviallyCopyable()` here?
https://github.com/llvm/llvm-project/pull/93113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hnrklssn wrote:
Blocked by pointer support for `counted_by` reverted. It's being relanded in
#93121
https://github.com/llvm/llvm-project/pull/93231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/rapidsna edited
https://github.com/llvm/llvm-project/pull/93121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Henrik G. Olsson (hnrklssn)
Changes
The attributes `sized_by`, `counted_by_or_null` and `sized_by_or_null` have
been added as variants on `counted_by`, each with slightly different semantics.
`sized_by` takes a byte size parameter
@@ -4944,6 +4944,26 @@ void Parser::ParseStructDeclaration(
}
}
+// TODO: All callers of this function should be moved to
+// `Parser::ParseLexedAttributeList`.
+void Parser::ParseLexedCAttributeList(LateParsedAttrList , bool EnterScope,
+
https://github.com/hnrklssn created
https://github.com/llvm/llvm-project/pull/93231
The attributes `sized_by`, `counted_by_or_null` and `sized_by_or_null` have
been added as variants on `counted_by`, each with slightly different semantics.
`sized_by` takes a byte size parameter instead of an
@@ -4944,6 +4944,26 @@ void Parser::ParseStructDeclaration(
}
}
+// TODO: All callers of this function should be moved to
+// `Parser::ParseLexedAttributeList`.
+void Parser::ParseLexedCAttributeList(LateParsedAttrList , bool EnterScope,
+
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
Clang has some unwritten rules about diagnostic wording regarding things like
punctuation and capitalization. This patch documents those rules and adds some
tablegen support for checking diagnostics
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/93229
Clang has some unwritten rules about diagnostic wording regarding things like
punctuation and capitalization. This patch documents those rules and adds some
tablegen support for checking diagnostics follow
@@ -4944,6 +4944,26 @@ void Parser::ParseStructDeclaration(
}
}
+// TODO: All callers of this function should be moved to
+// `Parser::ParseLexedAttributeList`.
+void Parser::ParseLexedCAttributeList(LateParsedAttrList , bool EnterScope,
+
@@ -4944,6 +4944,26 @@ void Parser::ParseStructDeclaration(
}
}
+// TODO: All callers of this function should be moved to
+// `Parser::ParseLexedAttributeList`.
+void Parser::ParseLexedCAttributeList(LateParsedAttrList , bool EnterScope,
+
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/93190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/92865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/brendandahl updated
https://github.com/llvm/llvm-project/pull/93228
>From 28cc678038feefffceba8cbe24349e1885b24c75 Mon Sep 17 00:00:00 2001
From: Brendan Dahl
Date: Tue, 21 May 2024 21:15:14 +
Subject: [PATCH] [WebAssembly] Implement prototype f16x8.splat instruction.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff dd2d132fb3521f37f44656edd65cca75430c251e
002e33294cae26796ca79a66dbd275f3e26807d2 --
brendandahl wrote:
cc @aheejin @dschuff
As mentioned in the meeting, it looks like it will be a lot more work to get
half value's working with normal patterns, so for now I'll stick to just
built-ins and intrinsics.
https://github.com/llvm/llvm-project/pull/93228
llvmbot wrote:
@llvm/pr-subscribers-mc
Author: Brendan Dahl (brendandahl)
Changes
Adds a builtin and intrinsic for the f16x8.splat instruction.
Specified at:
https://github.com/WebAssembly/half-precision/blob/29a9b9462c9285d4ccc1a5dc39214ddfd1892658/proposals/half-precision/Overview.md
https://github.com/brendandahl created
https://github.com/llvm/llvm-project/pull/93228
Adds a builtin and intrinsic for the f16x8.splat instruction.
Specified at:
https://github.com/WebAssembly/half-precision/blob/29a9b9462c9285d4ccc1a5dc39214ddfd1892658/proposals/half-precision/Overview.md
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/93079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11298,8 +11298,9 @@ static void DiagnoseBadConversion(Sema ,
OverloadCandidate *Cand,
Expr *FromExpr = Conv.Bad.FromExpr;
QualType FromTy = Conv.Bad.getFromType();
QualType ToTy = Conv.Bad.getToType();
- SourceRange ToParamRange =
- !isObjectArgument ?
https://github.com/mizvekov requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/93079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
601 - 700 of 433988 matches
Mail list logo
