[Lldb-commits] [lldb] [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (PR #94518)

2024-06-05 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r c6c08eee37bada190bd1aa4593c88a5e2c8cdaac...90602ed1b2f27fecb9e1fc28419587cf6bcb04bf

[Lldb-commits] [lldb] [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (PR #94518)

2024-06-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes `SBCommandInterpreter::CommandOverrideCallback` was not being exposed to the Python API has no coverage in the API test suite, so this commits exposes and adds a test for it. Doing this involves

[Lldb-commits] [lldb] [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (PR #94518)

2024-06-05 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/94518 `SBCommandInterpreter::CommandOverrideCallback` was not being exposed to the Python API has no coverage in the API test suite, so this commits exposes and adds a test for it. Doing this involves also

[Lldb-commits] [lldb] [lldb/crashlog] Add `--no-parallel-image-loading` hidden flag (PR #94513)

2024-06-05 Thread Med Ismail Bennani via lldb-commits
@@ -555,30 +555,44 @@ def load_images(self, options, loaded_images=None): futures = [] with tempfile.TemporaryDirectory() as obj_dir: -with concurrent.futures.ThreadPoolExecutor() as executor: -def add_module(image, target,

[Lldb-commits] [lldb] [lldb/crashlog] Use environment variable to manually set dsymForUUIDBinary (PR #94517)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/94517 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Use environment variable to manually set dsymForUUIDBinary (PR #94517)

2024-06-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes In lldb, users can change the `dsymForUUID` binary using the `LLDB_APPLE_DSYMFORUUID_EXECUTABLE` environment variable. This patch changes the crashlog to support the same behaviour as lldb and

[Lldb-commits] [lldb] [lldb/crashlog] Use environment variable to manually set dsymForUUIDBinary (PR #94517)

2024-06-05 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/94517 In lldb, users can change the `dsymForUUID` binary using the `LLDB_APPLE_DSYMFORUUID_EXECUTABLE` environment variable. This patch changes the crashlog to support the same behaviour as lldb and uses this

[Lldb-commits] [lldb] 39e12e0 - [lldb] Update error message in TestDAP_optimized after #94420

2024-06-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-05T11:25:17-07:00 New Revision: 39e12e0ab2dd3b0ed9741c9796de15a020741727 URL: https://github.com/llvm/llvm-project/commit/39e12e0ab2dd3b0ed9741c9796de15a020741727 DIFF:

[Lldb-commits] [lldb] [lldb/crashlog] Add `--no-parallel-image-loading` hidden flag (PR #94513)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
@@ -1720,6 +1735,13 @@ def CreateSymbolicateCrashLogOptions( help="show source for all threads, not just the crashed thread", default=False, ) +arg_parser.add_argument( +"--no-parallel-image-loading", +dest="parallel_image_loading", +

[Lldb-commits] [lldb] [lldb/crashlog] Add `--no-parallel-image-loading` hidden flag (PR #94513)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
@@ -1720,6 +1735,13 @@ def CreateSymbolicateCrashLogOptions( help="show source for all threads, not just the crashed thread", default=False, ) +arg_parser.add_argument( +"--no-parallel-image-loading", +dest="parallel_image_loading",

[Lldb-commits] [lldb] [lldb/crashlog] Add `--no-parallel-image-loading` hidden flag (PR #94513)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
@@ -555,30 +555,44 @@ def load_images(self, options, loaded_images=None): futures = [] with tempfile.TemporaryDirectory() as obj_dir: -with concurrent.futures.ThreadPoolExecutor() as executor: -def add_module(image, target,

[Lldb-commits] [lldb] [lldb/crashlog] Add `--no-parallel-image-loading` hidden flag (PR #94513)

2024-06-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch adds the `--no-parallel-image-loading` to the crashlog command. By default, image loading will happen in parallel in the crashlog script however, sometimes, when running tests or

[Lldb-commits] [lldb] [lldb/crashlog] Add `--no-parallel-image-loading` hidden flag (PR #94513)

2024-06-05 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/94513 This patch adds the `--no-parallel-image-loading` to the crashlog command. By default, image loading will happen in parallel in the crashlog script however, sometimes, when running tests or debugging the

[Lldb-commits] [lldb] [lldb] UpdateFormatsIfNeeded should respect the dynamic value type (PR #93262)

2024-06-05 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/93262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 59e9160 - [lldb] UpdateFormatsIfNeeded should respect the dynamic value type (#93262)

2024-06-05 Thread via lldb-commits
Author: Augusto Noronha Date: 2024-06-05T11:08:36-07:00 New Revision: 59e9160ac8c906c5448c2094cd28cb5bc7678a3f URL: https://github.com/llvm/llvm-project/commit/59e9160ac8c906c5448c2094cd28cb5bc7678a3f DIFF:

[Lldb-commits] [lldb] 539b72f - [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (#94420)

2024-06-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-05T10:57:46-07:00 New Revision: 539b72f2e15f0d8a74a6c05c7085035040a3a831 URL: https://github.com/llvm/llvm-project/commit/539b72f2e15f0d8a74a6c05c7085035040a3a831 DIFF:

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/94420 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

2024-06-05 Thread Miro Bucko via lldb-commits
mbucko wrote: > Would this affect other calls to `collect_console` too? Do we usually look > for a particular string? If so, would it make sense to change the function > (rather than this particular call site) or have a little helper? The problem is that the console hasn't had enough time to

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/94420 >From 22bb28a5e3fc84c75e1013c3b0c15654e7b786da Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 4 Jun 2024 17:04:15 -0700 Subject: [PATCH 1/6] [Support] Add variadic createStringError overload

[Lldb-commits] [lldb] [lldb] UpdateFormatsIfNeeded should respect the dynamic value type (PR #93262)

2024-06-05 Thread via lldb-commits
https://github.com/jimingham approved this pull request. I wish I knew why the original code was ignoring `GetDynamicValueType` here, when it does use it on the very next line... The old code looks wrong to me. However, the places where dynamic values matter for the Format choice are

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
@@ -52,9 +52,10 @@ __attribute__((noinline)) void func4_amb(int , int x) { //% expect_cmd_failure=True) //% self.filecheck("expr sink", "main.cpp","-check-prefix=FUNC4-EXPR", //% expect_cmd_failure=True) - // FUNC4-EXPR-FAIL: couldn't get the value of variable

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
@@ -1350,10 +1300,8 @@ bool DWARFExpression::Evaluate( if (pick_idx < stack.size()) stack.push_back(stack[stack.size() - 1 - pick_idx]); else { -if (error_ptr) - error_ptr->SetErrorStringWithFormat( - "Index %u out of range for

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. This is going to be great! Thanks. Minor nitpicks inside. https://github.com/llvm/llvm-project/pull/94420 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread Adrian Prantl via lldb-commits
@@ -2341,9 +2198,7 @@ bool DWARFExpression::Evaluate( // the stack by the called expression may be used as return values by prior // agreement between the calling and called expressions. case DW_OP_call2: - if (error_ptr) -

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread Adrian Prantl via lldb-commits
@@ -1350,10 +1300,8 @@ bool DWARFExpression::Evaluate( if (pick_idx < stack.size()) stack.push_back(stack[stack.size() - 1 - pick_idx]); else { -if (error_ptr) - error_ptr->SetErrorStringWithFormat( - "Index %u out of range for

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread Adrian Prantl via lldb-commits
@@ -52,9 +52,10 @@ __attribute__((noinline)) void func4_amb(int , int x) { //% expect_cmd_failure=True) //% self.filecheck("expr sink", "main.cpp","-check-prefix=FUNC4-EXPR", //% expect_cmd_failure=True) - // FUNC4-EXPR-FAIL: couldn't get the value of variable

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/94420 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Would this affect other calls to `collect_console` too? Do we usually look for a particular string? If so, would it make sense to change the function (rather than this particular call site) or have a little helper? https://github.com/llvm/llvm-project/pull/94494

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/94420 >From 22bb28a5e3fc84c75e1013c3b0c15654e7b786da Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 4 Jun 2024 17:04:15 -0700 Subject: [PATCH 1/5] [Support] Add variadic createStringError overload

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

2024-06-05 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/94494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

2024-06-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes Test Plan: llvm-lit llvm-project/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py --- Full diff: https://github.com/llvm/llvm-project/pull/94494.diff 1 Files Affected: - (modified)

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

2024-06-05 Thread Miro Bucko via lldb-commits
https://github.com/mbucko created https://github.com/llvm/llvm-project/pull/94494 Test Plan: llvm-lit llvm-project/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py >From 0d1eb164ab12773cb574de6066b717fd4c4c9e31 Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Wed, 5 Jun 2024 09:03:38

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
@@ -2042,7 +2043,7 @@ bool RegisterContextUnwind::ReadFrameAddress( return true; } UnwindLogMsg("Failed to set CFA value via DWARF expression: %s", - error.AsCString()); + llvm::toString(result.takeError()).c_str());

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-06-05 Thread via lldb-commits
cmtice wrote: I've updated with a few minor fixes. I've addressed all the review comments (I think). I've verified/tested that all the casting, etc. works properly. Please review/approve this. Thanks! https://github.com/llvm/llvm-project/pull/87197

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-06-05 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/5] [LLDB] Add more helper functions to ValueObject class.

[Lldb-commits] [lldb] [lldb] Split ValueObject::CreateChildAtIndex into two functions (PR #94455)

2024-06-05 Thread Pavel Labath via lldb-commits
@@ -488,66 +488,85 @@ void ValueObject::SetNumChildren(uint32_t num_children) { m_children.SetChildrenCount(num_children); } -ValueObject *ValueObject::CreateChildAtIndex(size_t idx, - bool synthetic_array_member, -

[Lldb-commits] [lldb] [lldb] Split ValueObject::CreateChildAtIndex into two functions (PR #94455)

2024-06-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The the function is doing two fairly different things, depending on how it is called. While this allows for some code reuse, it also makes it hard to override it correctly. Possibly for this reason

[Lldb-commits] [lldb] [lldb] Split ValueObject::CreateChildAtIndex into two functions (PR #94455)

2024-06-05 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/94455 >From d3d666886d6397bb031a3ad88f147fb9b1e2b3ed Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 5 Jun 2024 10:21:10 + Subject: [PATCH] [lldb] Split ValueObject::CreateChildAtIndex into two functions

[Lldb-commits] [lldb] [lldb] Split ValueObject::CreateChildAtIndex into two functions (PR #94455)

2024-06-05 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/94455 The the function is doing two fairly different things, depending on how it is called. While this allows for some code reuse, it also makes it hard to override it correctly. Possibly for this reason

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-06-05 Thread via lldb-commits
github-actions[bot] wrote: @AlexeyMerzlyakov Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-06-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/93297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d3a9043 - [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (#93297)

2024-06-05 Thread via lldb-commits
Author: Alexey Merzlyakov Date: 2024-06-05T10:14:48+01:00 New Revision: d3a9043ec2ee7ea278be4f3c86823512e44d01bf URL: https://github.com/llvm/llvm-project/commit/d3a9043ec2ee7ea278be4f3c86823512e44d01bf DIFF:

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-06-05 Thread David Spickett via lldb-commits
DavidSpickett wrote: Yeah we settled on https://github.com/psf/black as the formatter, but that itself didn't have a way to format the contents of a commit. So "darker" is black but it can do that. https://github.com/llvm/llvm-project/pull/93297 ___

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-06-05 Thread Alexey Merzlyakov via lldb-commits
AlexeyMerzlyakov wrote: Oops, I've checked it with flake8, but did not have an idea about the darker tool. Fixed in [latest](https://github.com/llvm/llvm-project/pull/93297/commits/041f5729920ed5f1b22745970b488d12438af1ba) commit. Thank you! https://github.com/llvm/llvm-project/pull/93297

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-06-05 Thread Alexey Merzlyakov via lldb-commits
https://github.com/AlexeyMerzlyakov updated https://github.com/llvm/llvm-project/pull/93297 >From d30c3b7017bd9f4b9f442ee728d7e3d7847c60cf Mon Sep 17 00:00:00 2001 From: Alexey Merzlyakov Date: Fri, 24 May 2024 11:54:16 +0300 Subject: [PATCH 1/5] Add RegisterContextPOSIXCore for RISC-V 64 Fix

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-06-05 Thread David Spickett via lldb-commits
DavidSpickett wrote: Not sure I agree with the formatter here but we must bow to it regardless :) Please fix the formatting and then I'll merge this. Thanks for the contribution! https://github.com/llvm/llvm-project/pull/93297 ___ lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-06-05 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r e3ed9e30b7b7102daf37f9464efc06b3d2e1a160...183f76dfb73821640cfdf19901703d0a8ff447ff

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread David Spickett via lldb-commits
@@ -2244,30 +2108,26 @@ bool DWARFExpression::Evaluate( const uint64_t piece_bit_offset = opcodes.GetULEB128(); switch (stack.back().GetValueType()) { case Value::ValueType::Invalid: - return false; + return llvm::createStringError( +

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread David Spickett via lldb-commits
@@ -1277,6 +1277,11 @@ inline Error createStringError(const Twine ) { return createStringError(llvm::inconvertibleErrorCode(), S); } +template +inline Error createStringError(char const *Fmt, const Ts &...Vals) { + return createStringError(llvm::inconvertibleErrorCode(),

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread David Spickett via lldb-commits
@@ -572,28 +572,32 @@ TypeSP DWARFASTParserClang::ParseTypeFromDWARF(const SymbolContext , static std::optional ExtractDataMemberLocation(DWARFDIE const , DWARFFormValue const _value, ModuleSP module_sp) { + Log *log =

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread David Spickett via lldb-commits
@@ -2244,30 +2108,26 @@ bool DWARFExpression::Evaluate( const uint64_t piece_bit_offset = opcodes.GetULEB128(); switch (stack.back().GetValueType()) { case Value::ValueType::Invalid: - return false; + return llvm::createStringError( +

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-05 Thread David Spickett via lldb-commits
@@ -2042,7 +2043,7 @@ bool RegisterContextUnwind::ReadFrameAddress( return true; } UnwindLogMsg("Failed to set CFA value via DWARF expression: %s", - error.AsCString()); + llvm::toString(result.takeError()).c_str());

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-06-05 Thread Alexey Merzlyakov via lldb-commits
https://github.com/AlexeyMerzlyakov updated https://github.com/llvm/llvm-project/pull/93297 >From d30c3b7017bd9f4b9f442ee728d7e3d7847c60cf Mon Sep 17 00:00:00 2001 From: Alexey Merzlyakov Date: Fri, 24 May 2024 11:54:16 +0300 Subject: [PATCH 1/4] Add RegisterContextPOSIXCore for RISC-V 64 Fix

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-06-05 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,202 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test import lldbplatformutil +import

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-06-05 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,202 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test import lldbplatformutil +import

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-06-05 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,202 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test import lldbplatformutil +import

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-06-05 Thread Pavel Labath via lldb-commits
labath wrote: > > FWIW, I think this feature would be more useful and easier to implement if > > there was just a single setting called "connection url" or something, which > > accepted all of the usual lldb connection urls (unix-abstract-connect://, > > listen://, ...). > > Since a simple

[Lldb-commits] [lldb] [lldb/crashlog] Always load Application Specific Backtrace Thread images (PR #94259)

2024-06-05 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/94259 >From d7bd20eb22896ff43ed2c840b1ede23c0f36aff9 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Tue, 4 Jun 2024 23:41:26 -0700 Subject: [PATCH] [lldb/crashlog] Always load Application Specific

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/94420 >From 22bb28a5e3fc84c75e1013c3b0c15654e7b786da Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 4 Jun 2024 17:04:15 -0700 Subject: [PATCH 1/4] [Support] Add variadic createStringError overload

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/94420 >From 22bb28a5e3fc84c75e1013c3b0c15654e7b786da Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 4 Jun 2024 17:04:15 -0700 Subject: [PATCH 1/3] [Support] Add variadic createStringError overload

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Change the interface of DWARFExpression::Evaluate and DWARFExpressionList::Evaluate to return an llvm::Expected instead of a boolean. This eliminates the Status output parameter and improves error

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

2024-06-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/94420 Change the interface of DWARFExpression::Evaluate and DWARFExpressionList::Evaluate to return an llvm::Expected instead of a boolean. This eliminates the Status output parameter and improves error handling.

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-06-04 Thread Santhosh Kumar Ellendula via lldb-commits
santhoshe447 wrote: > FWIW, I think this feature would be more useful and easier to implement if > there was just a single setting called "connection url" or something, which > accepted all of the usual lldb connection urls (unix-abstract-connect://, > listen://, ...). > > Since a simple tcp

[Lldb-commits] [clang] [lldb] [llvm] Refactor GDB Index into a new file (PR #94405)

2024-06-04 Thread Sayhaan Siddiqui via lldb-commits
https://github.com/sayhaan updated https://github.com/llvm/llvm-project/pull/94405 >From f3533c92b6b64f50a933a9eb2f9cc4229bbd8da3 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 1 Jun 2021 11:37:41 -0700 Subject: [PATCH 1/2] Rebase: [Facebook] Add clang driver options to test debug info

[Lldb-commits] [clang] [lldb] [llvm] Refactor GDB Index into a new file (PR #94405)

2024-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sayhaan Siddiqui (sayhaan) Changes Create a new class and file for functions that update GDB index. --- Patch is 40.93 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/94405.diff 24 Files

[Lldb-commits] [clang] [lldb] [llvm] Refactor GDB Index into a new file (PR #94405)

2024-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Sayhaan Siddiqui (sayhaan) Changes Create a new class and file for functions that update GDB index. --- Patch is 40.93 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/94405.diff 24 Files

[Lldb-commits] [clang] [lldb] [llvm] Refactor GDB Index into a new file (PR #94405)

2024-06-04 Thread Sayhaan Siddiqui via lldb-commits
https://github.com/sayhaan created https://github.com/llvm/llvm-project/pull/94405 Create a new class and file for functions that update GDB index. >From f3533c92b6b64f50a933a9eb2f9cc4229bbd8da3 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 1 Jun 2021 11:37:41 -0700 Subject: [PATCH

[Lldb-commits] [lldb] [lldb][test] Fix formatter tests for clang version 15 (PR #93710)

2024-06-04 Thread Miro Bucko via lldb-commits
https://github.com/mbucko closed https://github.com/llvm/llvm-project/pull/93710 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix formatter tests for clang version 15 (PR #93710)

2024-06-04 Thread Miro Bucko via lldb-commits
mbucko wrote: No longer needed, failing tests were due to local version override https://github.com/llvm/llvm-project/pull/93710 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] afe6ab7 - [lldb][DebugNames] Only skip processing of DW_AT_declarations for class/union types (#94400)

2024-06-04 Thread via lldb-commits
Author: Michael Buch Date: 2024-06-04T22:17:51+01:00 New Revision: afe6ab7586f7078cc410f6162bd9851e48e2a286 URL: https://github.com/llvm/llvm-project/commit/afe6ab7586f7078cc410f6162bd9851e48e2a286 DIFF: https://github.com/llvm/llvm-project/commit/afe6ab7586f7078cc410f6162bd9851e48e2a286.diff

[Lldb-commits] [lldb] [lldb][DebugNames] Only skip processing of DW_AT_declarations for class/union types (PR #94400)

2024-06-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/94400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [easy] Fix spacing in help message of 'process save-core' command (PR #89445)

2024-06-04 Thread via lldb-commits
https://github.com/GeorgeHuyubo closed https://github.com/llvm/llvm-project/pull/89445 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 679f75e - [easy] Fix spacing in help message of 'process save-core' command (#89445)

2024-06-04 Thread via lldb-commits
Author: Michael Christensen Date: 2024-06-04T14:02:41-07:00 New Revision: 679f75e24b81c3ba4a7666ad1f08aa40a6fdddfa URL: https://github.com/llvm/llvm-project/commit/679f75e24b81c3ba4a7666ad1f08aa40a6fdddfa DIFF:

[Lldb-commits] [lldb] [lldb][DebugNames] Only skip processing of DW_AT_declarations for class/union types (PR #94400)

2024-06-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. https://github.com/llvm/llvm-project/pull/94400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DebugNames] Only skip processing of DW_AT_declarations for class/union types (PR #94400)

2024-06-04 Thread Michael Buch via lldb-commits
Michael137 wrote: We might want to consider not omitting these constants into the index with dsymutil (since it's not spec conforming). And instead fix the expression evaluator to find the constants from context (but iirc that was a non-trivial undertaking).

[Lldb-commits] [lldb] [lldb][DebugNames] Only skip processing of DW_AT_declarations for class/union types (PR #94400)

2024-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This is a follow-up of https://github.com/llvm/llvm-project/pull/92328#issuecomment-2145849441 Clang attaches `DW_AT_declaration` to static inline data members and `dsymutil` indexes these constants.

[Lldb-commits] [lldb] [lldb][DebugNames] Only skip processing of DW_AT_declarations for class/union types (PR #94400)

2024-06-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/94400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DebugNames] Only skip processing of DW_AT_declarations for cla… (PR #94400)

2024-06-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/94400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DebugNames] Only skip processing of DW_AT_declarations for cla… (PR #94400)

2024-06-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/94400 …ss/union types This is a follow-up of https://github.com/llvm/llvm-project/pull/92328#issuecomment-2145849441 Clang attaches `DW_AT_declaration` to static inline data members and `dsymutil` indexes these

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-06-04 Thread David Blaikie via lldb-commits
dwblaikie wrote: > > > You can repro this by running ./bin/lldb-dotest -p > > > TestConstStaticIntegralMember.py --dwarf-version 5 > > > Could you take a look @ZequanWu ? > > > > > > It should be fixed by the following diff. We just need to skip the > > declaration DIEs that are

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-06-04 Thread Santhosh Kumar Ellendula via lldb-commits
@@ -348,6 +348,17 @@ "type": "string", "description": "The time in seconds to wait for a program to stop when attaching using \"attachCommands\". Defaults to 30 seconds." }, + "port": { +"type": [ +

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-06-04 Thread Santhosh Kumar Ellendula via lldb-commits
@@ -0,0 +1,142 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test import lldbplatformutil +import

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-06-04 Thread Santhosh Kumar Ellendula via lldb-commits
https://github.com/santhoshe447 updated https://github.com/llvm/llvm-project/pull/91570 >From 960351c9abf51f42d92604ac6297aa5b76ddfba5 Mon Sep 17 00:00:00 2001 From: Santhosh Kumar Ellendula Date: Fri, 17 Nov 2023 15:09:10 +0530 Subject: [PATCH 01/14] [lldb][test] Add the ability to extract

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-06-04 Thread Santhosh Kumar Ellendula via lldb-commits
https://github.com/santhoshe447 updated https://github.com/llvm/llvm-project/pull/91570 >From 960351c9abf51f42d92604ac6297aa5b76ddfba5 Mon Sep 17 00:00:00 2001 From: Santhosh Kumar Ellendula Date: Fri, 17 Nov 2023 15:09:10 +0530 Subject: [PATCH 01/13] [lldb][test] Add the ability to extract

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-06-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/94026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7dc84e2 - [lldb] Support reading DW_OP_piece from file address (#94026)

2024-06-04 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-06-04T10:24:59-07:00 New Revision: 7dc84e225e11e37925db6f4f08269f447d2f2347 URL: https://github.com/llvm/llvm-project/commit/7dc84e225e11e37925db6f4f08269f447d2f2347 DIFF:

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-06-04 Thread Michael Buch via lldb-commits
Michael137 wrote: > (Zequan is OOO for three weeks, I can take over this (tomorrow) if needed.) Ah no worries! I can put up the patch later today then to unblock the CI https://github.com/llvm/llvm-project/pull/92328 ___ lldb-commits mailing list

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-06-04 Thread Pavel Labath via lldb-commits
labath wrote: (Zequan is OOO for three weeks, I can take over this (tomorrow) if needed.) https://github.com/llvm/llvm-project/pull/92328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-06-04 Thread Michael Buch via lldb-commits
Michael137 wrote: > > Should we allow such entries in the index? And does this warrant rephrasing > > in the DWARF spec? > > It's fine to have those as _nameless_ entries (which we don't emit today), > but the entries that are reaching "process entry" have a name by definition. > That if

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-06-04 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: >Should we allow such entries in the index? And does this warrant rephrasing in >the DWARF spec? It's fine to have those as _nameless_ entries (which we don't emit today), but the entries that are reaching "process entry" are not nameless by definition. That if

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-06-04 Thread Santhosh Kumar Ellendula via lldb-commits
https://github.com/santhoshe447 updated https://github.com/llvm/llvm-project/pull/91570 >From 960351c9abf51f42d92604ac6297aa5b76ddfba5 Mon Sep 17 00:00:00 2001 From: Santhosh Kumar Ellendula Date: Fri, 17 Nov 2023 15:09:10 +0530 Subject: [PATCH 01/12] [lldb][test] Add the ability to extract

[Lldb-commits] [lldb] [lldb][test] Disable MD5 test for old versions of Visual Studio (PR #94325)

2024-06-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/94325 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8917739 - [lldb][test] Disable MD5 test for old versions of Visual Studio (#94325)

2024-06-04 Thread via lldb-commits
Author: David Spickett Date: 2024-06-04T15:38:11+01:00 New Revision: 8917739b4cb39e6cd2355672ff6e2c140b19aafd URL: https://github.com/llvm/llvm-project/commit/8917739b4cb39e6cd2355672ff6e2c140b19aafd DIFF:

[Lldb-commits] [lldb] [lldb][test] Disable MD5 test for old versions of Visual Studio (PR #94325)

2024-06-04 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/94325 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-06-04 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks, these look good. This does not include the FP registers, but I'm ok with you adding proper testing (with inline asm to set the registers) later, in the register class refactoring you mentioned. For now, if the core has them, please add checks for the FPU

[Lldb-commits] [lldb] [lldb][test] Disable MD5 test for old versions of Visual Studio (PR #94325)

2024-06-04 Thread David Spickett via lldb-commits
@@ -593,6 +593,10 @@ TEST_F(GDBRemoteCommunicationClientTest, WriteMemoryTags) { "E03", false); } +// Prior to this verison, constructing a std::future for a type without a +// default constructor is not possible. +//

[Lldb-commits] [lldb] [lldb][test] Disable MD5 test for old versions of Visual Studio (PR #94325)

2024-06-04 Thread Vassil Vassilev via lldb-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/94325 >From 125112e5864affd45a016a0870a40d2b4f516732 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 4 Jun 2024 09:32:22 + Subject: [PATCH 1/2] [lldb][test] Disable MD5 test for old versions of Visual

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-06-04 Thread Alexey Merzlyakov via lldb-commits
AlexeyMerzlyakov wrote: > Corefiles can be debugged anywhere, so you should add a test case to > `lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py`. I've added two testcases (one general and one checking main RISC-V registers) to `TestLinuxCore.py`. It was used the approach

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-06-04 Thread Alexey Merzlyakov via lldb-commits
https://github.com/AlexeyMerzlyakov edited https://github.com/llvm/llvm-project/pull/93297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-06-04 Thread Alexey Merzlyakov via lldb-commits
https://github.com/AlexeyMerzlyakov updated https://github.com/llvm/llvm-project/pull/93297 >From d30c3b7017bd9f4b9f442ee728d7e3d7847c60cf Mon Sep 17 00:00:00 2001 From: Alexey Merzlyakov Date: Fri, 24 May 2024 11:54:16 +0300 Subject: [PATCH 1/3] Add RegisterContextPOSIXCore for RISC-V 64 Fix

<    1   2   3   4   5   6   7   8   9   10   >