https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/92086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> I'm pretty sure lldb was sending these events at some point, but that could
> have change since then. I slightly surprised that this wasn't caught before
> as that would mean noone is running these tests remotely.
>
> Jonas, are you running lldb tests in remote
JDevlieghere wrote:
> If this is split out from the other larger PR, should there be `clang/`
> changes in here?
+1, please unstage the `clang` and `openmp` changes.
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing list
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/92124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. TILL about `qSpeedTest`.
https://github.com/llvm/llvm-project/pull/92124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath wrote:
> Ah, so the problem here is that we're missing the eh_frame instructions for
> _sigtramp on arm64 with macOS 14. `signal_generating_add` is a frameless
> function (a great stress test in this instance), and _sigtramp is called with
> enough of a faked-up stack that a stack walk
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Comparing a bit of the mock GDB server code to what was in the document I found
these:
* QLaunchArch
* qSpeedTest
* qSymbol
qSymbol is the most mysterious but it did have some examples in a comment
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/92124
Comparing a bit of the mock GDB server code to what was in the document I found
these:
* QLaunchArch
* qSpeedTest
* qSymbol
qSymbol is the most mysterious but it did have some examples in a comment so
mbucko wrote:
> I forgot to ask, what is the motivation behind this change? Is there
> something you can't do with the SBAPI right now or that is better expressed
> with SBAddressRange and SBAddressRangeList?
Yes, I want to add the following API:
lldb::SBError SBProcess::FindInMemory(const
@@ -242,6 +244,12 @@ class AddressRange {
lldb::addr_t m_byte_size = 0; ///< The size in bytes of this address range.
};
+// Forward-declarable wrapper.
+class AddressRanges : public std::vector {
+public:
+ using std::vector::vector;
+};
mbucko wrote:
I
labath wrote:
I'm currently optimizing our data formatters for some fairly complex data
structures, and I've ran into something I don't understand. My DAP packet
sequence for a hover request consists of two (mostly redundant) packets:
```
-->
Content-Length: 114
{
"arguments": {
@@ -0,0 +1,26 @@
+# REQUIRES: (target-aarch64 || target-arm) && native
+# UNSUPPORTED: system-windows
+
+# RUN: %clang_host %S/Inputs/unaligned-pc-sigbus.c -o %t
+# RUN: %lldb -s %s -o exit %t | FileCheck %s
+
+breakpoint set -n sigbus_handler
+# CHECK: Breakpoint 1: where =
@@ -0,0 +1,26 @@
+# REQUIRES: (target-aarch64 || target-arm) && native
+# UNSUPPORTED: system-windows
+
+# RUN: %clang_host %S/Inputs/unaligned-pc-sigbus.c -o %t
+# RUN: %lldb -s %s -o exit %t | FileCheck %s
+
+breakpoint set -n sigbus_handler
+# CHECK: Breakpoint 1: where =
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The stack validation heuristic is counter-productive in this case, as the
unaligned address is most likely the thing that caused the signal in the first
place.
---
Full diff:
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/92093
The stack validation heuristic is counter-productive in this case, as the
unaligned address is most likely the thing that caused the signal in the first
place.
>From 391a4129d3da4c4730e50d6ebca23a3c36c3b462 Mon
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/92082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-14T14:02:31+04:00
New Revision: f658d84e01bcdd49e27dc9ef80e1a6cc5f9417fe
URL:
https://github.com/llvm/llvm-project/commit/f658d84e01bcdd49e27dc9ef80e1a6cc5f9417fe
DIFF:
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/92080
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-14T14:00:16+04:00
New Revision: ac42f7689d741feda2badc438101e7952db048f3
URL:
https://github.com/llvm/llvm-project/commit/ac42f7689d741feda2badc438101e7952db048f3
DIFF:
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-14T13:57:37+04:00
New Revision: 7b1b1279414217ea7f2402a03dfb5a18ea5a5367
URL:
https://github.com/llvm/llvm-project/commit/7b1b1279414217ea7f2402a03dfb5a18ea5a5367
DIFF:
labath wrote:
Maybe the `skipIfWindows` decorator can also be removed here? We haven't been
historically very good at distinguishing windows hosts and targets (nobody
cared until now), and from the looks of things, these tests could conceivably
work in a linux->windows remote scenario
labath wrote:
Given that the tests use a mock server, why is it a problem that they're
running on a windows host? What's the actual failure? Could they be adapted so
that they run everywhere?
https://github.com/llvm/llvm-project/pull/92088
___
labath wrote:
I'm pretty sure lldb was sending these events at some point, but that could
have change since then. I slightly surprised that this wasn't caught before as
that would mean noone is running these tests remotely.
Jonas, are you running lldb tests in remote configurations?
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/92080
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/92082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
The tests TestPty and TestPtyServer use the Unix specific python builtin module
termios. They are failed in case of Windows host and Linux target. Disable them
for Windows host too.
---
Full diff:
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/92090
The tests TestPty and TestPtyServer use the Unix specific python builtin module
termios. They are failed in case of Windows host and Linux target. Disable them
for Windows host too.
>From
https://github.com/labath approved this pull request.
I like this new version, thanks for sticking with me.
https://github.com/llvm/llvm-project/pull/91887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: Dmitry Vasilyev
Date: 2024-05-14T10:15:03+01:00
New Revision: 429ce59bd0a7d93ef833939d4a92b56aae103a5a
URL:
https://github.com/llvm/llvm-project/commit/429ce59bd0a7d93ef833939d4a92b56aae103a5a
DIFF:
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/92077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/92077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
Can we make this less brute force? I believe searching for the Build ID Note
should be a completely deterministic process, without the need for heuristics.
You start with the elf header, find the program headers, iterate to find the
PT_NOTE segment (there could be more of them),
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
The tests `test_file_permissions` and `test_file_permissions_fallback` are
disabled for Windows target. These tests use MockGDBServerResponder and do not
depend on the real target. These tests failed in
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/92088
The tests `test_file_permissions` and `test_file_permissions_fallback` are
disabled for Windows target. These tests use MockGDBServerResponder and do not
depend on the real target. These tests failed in case
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
self.wait_for_running_event(process) is always called after
self.runCmd("continue"). It is strange to expect eStateConnected here. This
test failed in case of a remote target. The correct state is
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/92086
self.wait_for_running_event(process) is always called after
self.runCmd("continue"). It is strange to expect eStateConnected here. This
test failed in case of a remote target. The correct state is
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/91918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
If this is split out from the other larger PR, should there be `clang/` changes
in here?
I've copied your commit message into the PR description, because with the way
llvm is setup, we use the PR's description as the commit message for a squashed
version of the changes.
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c441aa51e16e2fa5f407191287f48d2b7c302ceb...a5b005cbbfd25c9fb3e59f2cb0f98c2f6a3e405d
Author: aabhinavg
Date: 2024-05-14T09:14:17+01:00
New Revision: c28529788955dbfada9f8a5092432f09eec2c3ab
URL:
https://github.com/llvm/llvm-project/commit/c28529788955dbfada9f8a5092432f09eec2c3ab
DIFF:
https://github.com/llvm/llvm-project/commit/c28529788955dbfada9f8a5092432f09eec2c3ab.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/91882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/91882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Install a.out and libsignal_file.so to the remote target if necessary.
---
Full diff: https://github.com/llvm/llvm-project/pull/92080.diff
1 Files Affected:
- (modified)
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/92078
>From fa962b461d949cc26f09f8b4bdbd533d7b73131d Mon Sep 17 00:00:00 2001
From: George Hu
Date: Mon, 13 May 2024 17:03:30 -0700
Subject: [PATCH] Read and store gnu build id from loaded core file
---
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/92080
Install a.out and libsignal_file.so to the remote target if necessary.
>From a5b005cbbfd25c9fb3e59f2cb0f98c2f6a3e405d Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Tue, 14 May 2024 12:05:27 +0400
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/92078
>From 4a360988cd7242736a9557463fe529c0eaf44dc2 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Mon, 13 May 2024 17:03:30 -0700
Subject: [PATCH] Read and store gnu build id from loaded core file
---
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff f8063ffe73a3a1d704b9738169bb76ebb0f8a5e0
6a84c484070d53515c7cc473b4a0c1d566342b0f --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (GeorgeHuyubo)
Changes
As we have debuginfod as symbol locator available in lldb now, we want to make
full use of it.
In case of post mortem debugging, we don't always have the main executable
available.
However, the
https://github.com/GeorgeHuyubo created
https://github.com/llvm/llvm-project/pull/92078
As we have debuginfod as symbol locator available in lldb now, we want to make
full use of it.
In case of post mortem debugging, we don't always have the main executable
available.
However, the
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Windows path is case insensitive. Tests `test_QMemTags_packets` and
`test_qMemTags_packets` will use the same build dir and conflict. Added a
suffix to resolve conflicts.
---
Full diff:
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/92077
Windows path is case insensitive. Tests `test_QMemTags_packets` and
`test_qMemTags_packets` will use the same build dir and conflict. Added a
suffix to resolve conflicts.
>From
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91931
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-14T11:26:14+04:00
New Revision: e2f079cc6c3689fa5a6f64550b2d4fdc628dad6f
URL:
https://github.com/llvm/llvm-project/commit/e2f079cc6c3689fa5a6f64550b2d4fdc628dad6f
DIFF:
@@ -108,6 +109,20 @@ def test_platform_file_wronly_fail(self):
)
self.expect_gdbremote_sequence()
+def remote_install(self, path, filename="test"):
+if lldb.remote_platform:
+remote_path =
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/91918
>From 4eee83a3a6b923075a9e6db217349726780c31f4 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 13 May 2024 10:34:04 +0400
Subject: [PATCH] [lldb] Fix the test TestGdbRemotePlatformFile
It is
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/91931
>From 361cd689e3900c5ab542a5158807eb532879677e Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 13 May 2024 11:26:03 +0400
Subject: [PATCH] [lldb] Fixed the test TestGdbRemoteLaunch
Install `a.out` to
Author: Dmitry Vasilyev
Date: 2024-05-14T10:59:16+04:00
New Revision: c441aa51e16e2fa5f407191287f48d2b7c302ceb
URL:
https://github.com/llvm/llvm-project/commit/c441aa51e16e2fa5f407191287f48d2b7c302ceb
DIFF:
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91944
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/91944
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> > > LLDB became unresponsive on windows when a `thread backtrace` command was
> > > issued after hitting the exception i have temporarily reverted the change
> > > to make buildbot green.
> >
> >
> > Could you please give me some more information about the problem? I don't
>
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/91944
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3857,8 +3857,8 @@ thread_result_t Process::RunPrivateStateThread(bool
is_secondary_thread) {
// case we should tell it to stop doing that. Normally, we don't NEED
// to do that because we will next close the communication to the stub
// and that
@@ -36,17 +35,37 @@ def verify_core_file(
self.assertEqual(module_file_name, expected_file_name)
self.assertEqual(module.GetUUIDString(), expected.GetUUIDString())
+red_zone = process.GetTarget().GetStackRedZoneSize()
for thread_idx in
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/92002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6410,12 +6410,20 @@ GetCoreFileSaveRangesStackOnly(Process ,
if (!reg_ctx_sp)
continue;
const addr_t sp = reg_ctx_sp->GetSP();
+const size_t red_zone = process.GetABI()->GetRedZoneSize();
lldb_private::MemoryRegionInfo sp_region;
if
@@ -36,17 +35,37 @@ def verify_core_file(
self.assertEqual(module_file_name, expected_file_name)
self.assertEqual(module.GetUUIDString(), expected.GetUUIDString())
+red_zone = process.GetTarget().GetStackRedZoneSize()
for thread_idx in
@@ -6410,12 +6410,20 @@ GetCoreFileSaveRangesStackOnly(Process ,
if (!reg_ctx_sp)
continue;
const addr_t sp = reg_ctx_sp->GetSP();
+const size_t red_zone = process.GetABI()->GetRedZoneSize();
lldb_private::MemoryRegionInfo sp_region;
if
https://github.com/jeffreytan81 commented:
The changes looks good but the title and description should make it clear that
we are only optimizing this for stack-only option.
https://github.com/llvm/llvm-project/pull/92002
___
lldb-commits mailing list
@@ -36,17 +35,37 @@ def verify_core_file(
self.assertEqual(module_file_name, expected_file_name)
self.assertEqual(module.GetUUIDString(), expected.GetUUIDString())
+red_zone = process.GetTarget().GetStackRedZoneSize()
jimingham wrote:
Can you take care of cleaning this up, this seems like a slightly complex patch
and not in an area I'm familiar with.
Thanks!
Jim
> On May 13, 2024, at 6:35 PM, Zequan Wu ***@***.***> wrote:
>
>
> Reverting those two commits seems to have caused this build failure on
ZequanWu wrote:
> Reverting those two commits seems to have caused this build failure on Ubuntu:
You forgot the delete the newly added test
SymbolFile/DWARF/delayed-definition-die-searching.test in the reverting:
jimingham wrote:
Reverting those two commits seems to have caused this build failure on Ubuntu:
Step 4 (build) warnings: build (warnings)
../llvm-project/clang/lib/Lex/PPDirectives.cpp:548:28: warning: comparison of
integers of different signs: 'unsigned int' and 'int' [-Wsign-compare]
1
JOE1994 wrote:
> We usually don't grant exclusive rights to work on an issue in the project,
> since individual priorities may always change and people might loose interest
> in an issue. Typically this kind of conflict doesn't happen very often
> either.
I understand that, but just for
ZequanWu wrote:
> your commit deleted that file I think, I added it back when I did the revert
> (possibly a mistake)... It passes on my macOS system but is failing on
> Ubuntu after the revert. I think I'll just disable it for now.
This change adds the new test, so deleting it as part of
Author: Jim Ingham
Date: 2024-05-13T18:18:40-07:00
New Revision: e6b2197a89f5d6d0f56a03c03b8afda561eee899
URL:
https://github.com/llvm/llvm-project/commit/e6b2197a89f5d6d0f56a03c03b8afda561eee899
DIFF:
https://github.com/llvm/llvm-project/commit/e6b2197a89f5d6d0f56a03c03b8afda561eee899.diff
jimingham wrote:
BTW, do you know what's up with this test:
SymbolFile/DWARF/delayed-definition-die-searching.test
your commit deleted that file I think, I added it back when I did the revert
(possibly a mistake)... It passes on my macOS system but is failing on Ubuntu
after the revert. I
jimingham wrote:
> On May 13, 2024, at 6:04 PM, Zequan Wu ***@***.***> wrote:
>
>
> I was able to reproduce the failure of these three:
>
> lldb-api :: lang/c/forward/TestForwardDeclaration.py
> lldb-api :: lang/cpp/unique-types3/TestUniqueTypes3.py
> lldb-api :: types/TestRecursiveTypes.py
ZequanWu wrote:
> I was able to reproduce the failure of these three:
>
> lldb-api :: lang/c/forward/TestForwardDeclaration.py
> lldb-api :: lang/cpp/unique-types3/TestUniqueTypes3.py
> lldb-api :: types/TestRecursiveTypes.py
>
> locally. Reverting this patch and
>
adrian-prantl wrote:
@ZequanWu in the future, if one of your commits break a bot, make sure to
revert it immediately, you can always re-land it later with a fix or an
explanation why it wasn't your commit that broke the bots. Reverting a commit
is cheap, red bots are expensive :-)
adrian-prantl wrote:
> A new user already asked to be assigned to work on #91209 2 days ago in the
> comments. **I think that user deserves an opportunity to work on the issue**.
>
> Next time when you see a **"good first issue"** which a new user had already
> asked to get assigned to,
jimingham wrote:
I was able to reproduce the failure of these three:
lldb-api :: lang/c/forward/TestForwardDeclaration.py
lldb-api :: lang/cpp/unique-types3/TestUniqueTypes3.py
lldb-api :: types/TestRecursiveTypes.py
locally. Reverting this patch and
Author: Jim Ingham
Date: 2024-05-13T17:47:49-07:00
New Revision: 70de9b21cbdeb1297108c4ee520b8f6dbd6496a7
URL:
https://github.com/llvm/llvm-project/commit/70de9b21cbdeb1297108c4ee520b8f6dbd6496a7
DIFF:
https://github.com/llvm/llvm-project/commit/70de9b21cbdeb1297108c4ee520b8f6dbd6496a7.diff
Author: Jim Ingham
Date: 2024-05-13T17:47:49-07:00
New Revision: 37b8e5feb1d065a7c474e6595bac6d2f65faeb51
URL:
https://github.com/llvm/llvm-project/commit/37b8e5feb1d065a7c474e6595bac6d2f65faeb51
DIFF:
https://github.com/llvm/llvm-project/commit/37b8e5feb1d065a7c474e6595bac6d2f65faeb51.diff
adrian-prantl wrote:
> Re-apply https://github.com/llvm/llvm-project/pull/81196, with a fix.
It's usually helpful to indicate what/where the fix is to make it easier to
re-review.
https://github.com/llvm/llvm-project/pull/91868
___
lldb-commits
@@ -658,6 +659,38 @@ static char ConvertValueObjectStyleToChar(
return '\0';
}
+static llvm::Regex LLVMFormatPattern{"x[-+]?\\d*|n|d",
llvm::Regex::IgnoreCase};
+
+static bool DumpValueWithLLVMFormat(Stream , llvm::StringRef options,
+
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/91868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/91868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
(and it turns out the reason we don't have eh_frame is because _sigtramp on
arm64 is written in C, and I'm not sure how I'm going to track which
callee-saved register the argument is copied into, so this is definitely not
something I can get fixed quickly.)
jimingham wrote:
I'm trying to reproduce locally as well. It's pretty clear that this patch is
implicated in the failure. The first failure we saw both on the incremental
bots and the first failure on the sanitized bots both had this patch, and no
other really relevant ones, in the commit
omjavaid wrote:
> > LLDB became unresponsive on windows when a `thread backtrace` command was
> > issued after hitting the exception i have temporarily reverted the change
> > to make buildbot green.
>
> Could you please give me some more information about the problem? I don't
> have access
Author: Muhammad Omair Javaid
Date: 2024-05-14T03:58:26+05:00
New Revision: 6cfac497e96978f2bfc50a00b51c198f2ed50f82
URL:
https://github.com/llvm/llvm-project/commit/6cfac497e96978f2bfc50a00b51c198f2ed50f82
DIFF:
@@ -0,0 +1,63 @@
+//===-- SBAddressRange.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -6410,12 +6410,20 @@ GetCoreFileSaveRangesStackOnly(Process ,
if (!reg_ctx_sp)
continue;
const addr_t sp = reg_ctx_sp->GetSP();
+const size_t red_zone = process.GetABI()->GetRedZoneSize();
lldb_private::MemoryRegionInfo sp_region;
if
https://github.com/clayborg requested changes to this pull request.
Change look good for the `GetCoreFileSaveRangesStackOnly`, but we want this to
work for the other two modes `modified-memory` and `full`. So we need to fix
`GetCoreFileSaveRangesFull` and `GetCoreFileSaveRangesDirtyOnly`.
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/92002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,63 @@
+//===-- SBAddressRange.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
901 - 1000 of 87360 matches
Mail list logo
