Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r214508181
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -517,10 +517,10 @@ private[spark] class TaskSchedulerImpl
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22205#discussion_r214505595
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1349,6 +1357,12 @@ object
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22282#discussion_r214084903
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -473,17 +474,6 @@ public static
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22282
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22282#discussion_r214075761
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -473,17 +474,6 @@ public static
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/2
@cloud-fan @rdblue
I want to leave some comments and thoughts during looking into this again,
hope these can help us deciding the next step plan.
Currently all the plan assumed input
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/2
Got it, I'll revert the changes in file source in this commit, thanks for
your reply.
---
-
To unsubscribe, e-mail
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22252#discussion_r213708177
--- Diff: docs/configuration.md ---
@@ -152,7 +152,7 @@ of the most common options to set are:
spark.driver.memory
1g
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/2
@cloud-fan Thanks for your reply Wenchen, I'm trying to achieve this in
this commit, please take a look, thanks
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22252#discussion_r213343952
--- Diff: docs/configuration.md ---
@@ -152,7 +152,7 @@ of the most common options to set are:
spark.driver.memory
1g
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22149
```
Is that possible to add a test case?
```
Thanks for your reply Xiao, we encountered some difficulties during the
test case, cause this need mock on speculative behavior. We
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22149
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22024
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22024#discussion_r213015113
--- Diff:
core/src/main/scala/org/apache/spark/network/BlockTransferService.scala ---
@@ -101,15 +101,7 @@ abstract class BlockTransferService extends
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22024#discussion_r213015245
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -160,7 +160,13 @@ private[spark] class TorrentBroadcast[T
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22198#discussion_r212822215
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala ---
@@ -191,6 +195,48 @@ class DataFrameJoinSuite extends QueryTest
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/2#discussion_r212820814
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -307,7 +308,7 @@ case class FileSourceScanExec
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/2
cc @cloud-fan and @rdblue have a look when you have time. If this PR
doesn't coincide with your expect, I'll close this soon. Thanks
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/2#discussion_r212784374
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -40,6 +42,29 @@ private[sql] trait ColumnarBatchScan
GitHub user xuanyuanking opened a pull request:
https://github.com/apache/spark/pull/2
[SPARK-25083][SQL] Remove the type erasure hack in data source scan
## What changes were proposed in this pull request?
1. Add function `inputBatchRDDs` and `inputRowRDDs` interface
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22202#discussion_r212365264
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2246,58 +2247,6 @@ class DAGSchedulerSuite extends
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22149
Gental ping @gatorsmile.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22165
@jiangxb1987 Great thanks for your comment!
```
One general idea is that we don't need to rely on the RPC framework to test
ContextBarrierState, just mock RpcCallContexts should
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22177
Please change title to "[SPARK-25199][Web UI] XXX " as we described in
http://spark.apache.org/contributing.html.
```
check the DAG chart in job page.
```
Could yo
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22177#discussion_r212003441
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala ---
@@ -337,7 +337,9 @@ private[ui] class JobPage(parent: JobsTab, store
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22177#discussion_r212002571
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala ---
@@ -18,18 +18,18 @@
package org.apache.spark.ui.jobs
import
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22180#discussion_r211996461
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -368,7 +369,11 @@ private[spark] class
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22180#discussion_r211996874
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -143,6 +143,7 @@ private[spark] class
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22140
AFAIC, the fix should forbid illegal extra value passing. If less values
than fields it should get a `AttributeError` while accessing as the currently
implement, not ban it here? What do you
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22165
My pleasure, just find this during glance over jira in recent days. :)
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22165
cc @gatorsmile @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22165
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22165
cc @jiangxb1987
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user xuanyuanking opened a pull request:
https://github.com/apache/spark/pull/22165
[SPARK-25017][Core] Add test suite for BarrierCoordinator and
ContextBarrierState
## What changes were proposed in this pull request?
Currently `ContextBarrierState
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22140
cc @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
GitHub user xuanyuanking opened a pull request:
https://github.com/apache/spark/pull/22140
[SPARK-25072][PySpark] Forbid extra value for custom Row
## What changes were proposed in this pull request?
Add value length check in `_create_row`, forbid extra value for custom Row
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22105#discussion_r210842394
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -140,8 +140,24 @@ private int
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22122
Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22122
```
Are they all instances to fix?
```
@HyukjinKwon Yep, I grep all `conf.get("spark.sql.xxx")` and make sure for
this. The remaining of hard code config is Sta
GitHub user xuanyuanking opened a pull request:
https://github.com/apache/spark/pull/22122
[SPARK-24665][PySpark][FollowUp] Use SQLConf in PySpark to manage all sql
configs
## What changes were proposed in this pull request?
Follow up for SPARK-24665, find some others hard
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22117
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22093
`Should I delete current UT from FileSuit?`
I think current UT in `FileSuite` is unnecessarily, you can leave it and
wait for other reviewer's opinion
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22093
Why we should create own SparkContext here? Could we just add a UT like
`registration of HighlyCompressedMapStatus` to check `TaskCommitMessage`
working
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22093#discussion_r209650955
--- Diff: core/src/test/scala/org/apache/spark/FileSuite.scala ---
@@ -424,6 +425,39 @@ class FileSuite extends SparkFunSuite with
LocalSparkContext
GitHub user xuanyuanking opened a pull request:
https://github.com/apache/spark/pull/22057
[SPARK-25077][SQL] Delete unused variable in WindowExec
## What changes were proposed in this pull request?
Just delete the unused variable `inputFields` in WindowExec, avoid making
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22017#discussion_r208260664
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -365,3 +364,101 @@ case class
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22017#discussion_r208257687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
---
@@ -267,22 +267,23 @@ case class
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21986#discussion_r207924294
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -205,29 +230,82 @@ case class
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21985#discussion_r207712639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -446,3 +448,88 @@ case class
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21985#discussion_r207712323
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -446,3 +448,88 @@ case class
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21945
Close this, the param `spark.reducer.maxBlocksInFlightPerAddress` added
after version 2.2 can solve my problem
Github user xuanyuanking closed the pull request at:
https://github.com/apache/spark/pull/21945
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21945
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user xuanyuanking opened a pull request:
https://github.com/apache/spark/pull/21945
[SPARK-24989][Core] Add retrying support for OutOfDirectMemoryError
## What changes were proposed in this pull request?
As the detailed description in
[SPARK-24989](https
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21881#discussion_r206203835
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -337,7 +337,11 @@ case class LoadDataCommand
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r206184350
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/MultiFormatTableSuite.scala
---
@@ -0,0 +1,514 @@
+/*
+ * Licensed
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r206190334
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/MultiFormatTableSuite.scala
---
@@ -0,0 +1,514 @@
+/*
+ * Licensed
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r206188190
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/MultiFormatTableSuite.scala
---
@@ -0,0 +1,514 @@
+/*
+ * Licensed
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r206182473
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/MultiFormatTableSuite.scala
---
@@ -0,0 +1,514 @@
+/*
+ * Licensed
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r206188295
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/MultiFormatTableSuite.scala
---
@@ -0,0 +1,514 @@
+/*
+ * Licensed
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r206188012
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/MultiFormatTableSuite.scala
---
@@ -0,0 +1,514 @@
+/*
+ * Licensed
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r206184183
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/MultiFormatTableSuite.scala
---
@@ -0,0 +1,514 @@
+/*
+ * Licensed
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r206188650
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/MultiFormatTableSuite.scala
---
@@ -0,0 +1,514 @@
+/*
+ * Licensed
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r206178526
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala
---
@@ -96,6 +96,9 @@ object ParserUtils
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r205945617
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -857,6 +857,32 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r205945564
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/MultiFormatTableSuite.scala
---
@@ -0,0 +1,512 @@
+/*
+ * Licensed
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r205945559
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -415,6 +415,51 @@ case class
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21893#discussion_r205945523
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -857,6 +857,32 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21618#discussion_r205478496
--- Diff: core/src/main/java/org/apache/hadoop/fs/SparkGlobber.java ---
@@ -0,0 +1,293 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/19773#discussion_r204805474
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -318,18 +318,34 @@ case class AlterTableChangeColumnCommand
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/19773
@gatorsmile @maropu Please have a look about this, solving the conflicts
takes me some time.
Also cc @jiangxb1987 because the conflict mainly with #20696, also thanks
for the work
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21839
Thanks for reviewing.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/19773
I'll resolve the conflicts today, thanks for ping me.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user xuanyuanking closed the pull request at:
https://github.com/apache/spark/pull/19745
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/19745
No problem.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21839
@gatorsmile Thanks for your advice, added ut in ScriptTransformationSuite.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21839#discussion_r204447671
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -450,13 +450,16 @@ object ColumnPruning extends
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21839
@gatorsmile @maropu This is the follow up PR for #21447, please have a look
when you have time, thanks
GitHub user xuanyuanking opened a pull request:
https://github.com/apache/spark/pull/21839
[SPARK-24339][SQL] Prunes the unused columns from child of
ScriptTransformation
## What changes were proposed in this pull request?
Modify the strategy in ColumnPruning to add
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21447
I want to give a follow up PR and cc @gatorsmile @maropu for a review.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21533
Thanks everyone for your help!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21533
@jiangxb1987 Thanks for reminding, rephrase done.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21789#discussion_r203037295
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
@@ -766,6 +774,14 @@ class
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21775#discussion_r202703129
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -114,7 +114,10 @@ case class CatalogTablePartition
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21775#discussion_r202701770
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -2248,4 +2249,20 @@ class HiveDDLSuite
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21775#discussion_r202704259
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -2248,4 +2249,20 @@ class HiveDDLSuite
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21775#discussion_r202703948
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -2248,4 +2249,20 @@ class HiveDDLSuite
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21775#discussion_r202701870
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -2248,4 +2249,20 @@ class HiveDDLSuite
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21618
gental ping @cloud-fan @gatorsmile @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21729
Please change the title to '[SPARK-24755][Core] Executor loss can cause
task to not be resubmitted'
---
-
To unsubscribe
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21618#discussion_r201007556
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -656,6 +656,25 @@ object SQLConf {
.intConf
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21618#discussion_r201006447
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -656,6 +656,25 @@ object SQLConf {
.intConf
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21618#discussion_r201006275
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -724,4 +726,35 @@ object DataSource extends
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21729#discussion_r200990424
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -1365,6 +1365,113 @@ class TaskSetManagerSuite extends
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21729#discussion_r200990279
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -1365,6 +1365,113 @@ class TaskSetManagerSuite extends
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21729#discussion_r200989413
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -87,7 +87,7 @@ private[spark] class TaskSetManager(
// Set
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21642#discussion_r200160518
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -73,6 +74,10 @@ private[spark] class AppStatusListener
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21642#discussion_r200159852
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -185,6 +185,24 @@ case class SparkListenerApplicationEnd(time
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21642#discussion_r200160022
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -19,6 +19,7 @@ package org.apache.spark.status
import
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21642#discussion_r200159949
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -185,6 +185,24 @@ case class SparkListenerApplicationEnd(time
301 - 400 of 777 matches
Mail list logo
