[Qemu-devel] [PATCH 14/26] hw/usb/dev-smartcard-reader.c: white space fixes

2013-03-18 Thread Alon Levy
From: Alon Levy a...@pobox.com Signed-off-by: Alon Levy al...@redhat.com --- hw/usb/dev-smartcard-reader.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index fc950c8..7205613 100644 --- a/hw/usb/dev-smartcard-reader.c +++ b

[Qemu-devel] [PATCH 26/26] libcacard/cac.c: questionable change to single return of big switch functions

2013-03-18 Thread Alon Levy
From: Alon Levy a...@pobox.com Signed-off-by: Alon Levy al...@redhat.com --- libcacard/cac.c | 73 - 1 file changed, 52 insertions(+), 21 deletions(-) diff --git a/libcacard/cac.c b/libcacard/cac.c index 5864539..7a06b5a 100644

[Qemu-devel] [PATCH 19/26] hw/usb/dev-smartcard-reader.c: dwFeadvertise support for T=0 only

2013-03-18 Thread Alon Levy
From: Alon Levy a...@pobox.com changes dwProtocols. to 0x1 and dwProtocols.=0 per spec. Signed-off-by: Alon Levy al...@redhat.com --- hw/usb/dev-smartcard-reader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev

[Qemu-devel] [PATCH 25/26] dev-smartcard-reader: empty implementation for Mechanical (fail correctly)

2013-03-18 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/usb/dev-smartcard-reader.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 3246fc1..f53956e 100644 --- a/hw/usb/dev-smartcard-reader.c +++ b/hw/usb/dev-smartcard-reader.c

[Qemu-devel] [PATCH 24/26] libcacard: move atr setting from macro to function

2013-03-18 Thread Alon Levy
Only because qemu's checkpatch complains about it. Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs | 1 + libcacard/vcard_emul_nss.c | 11 --- libcacard/vcardt.c | 40 libcacard/vcardt.h | 15

[Qemu-devel] [PATCH 18/26] hw/usb/dev-smartcard-reader.c: copy atr's protocol to ccid's parameters (adds todo's)

2013-03-18 Thread Alon Levy
From: Alon Levy a...@pobox.com Signed-off-by: Alon Levy al...@redhat.com --- hw/usb/dev-smartcard-reader.c | 46 +++ 1 file changed, 46 insertions(+) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 6894f36..522fefa 100644

Re: [Spice-devel] [PATCH spice 1/4] main-channel: Make main_channel_push_notify deal with dynamic memory

2013-03-14 Thread Alon Levy
ACK series, thanks for fixing my todo :) - Original Message - Currently main_channel_push_notify only gets passed a static string, but chances are in the future it may get passed dynamically allocated strings, prepare it for this. While at it also make clear that the arguments to

[Qemu-devel] [PATCH] spice-qemu-char: register interface on post load

2013-03-14 Thread Alon Levy
is static in the guest. By registering the interface on post load spice server will pass on the agent messages fixing the mouse behavior after migration. RHBZ #725965 Signed-off-by: Alon Levy al...@redhat.com v2: call qemu_del_timer, unregister vmstate --- spice-qemu-char.c | 64

Re: [Qemu-devel] [PATCH] spice-qemu-char: register interface on post load

2013-03-14 Thread Alon Levy
Hi, On 03/14/2013 04:12 PM, Alon Levy wrote: The target has not seen the guest_connected event via spice_chr_guest_open or spice_chr_write, and so spice server wrongly assumes there is no agent active, while the client continues to send motion events only by the agent channel

Re: [Spice-devel] German keymap in Windows 7

2013-03-13 Thread Alon Levy
Hi, i`m running Windows 7 Prof. 32-bit under KVM/QEMU. I`m using spice togehter with qxl. Guest drivers are all installed. I can succesfully connect to the guest client and everything works fine. But my keyboard is not using qwertz. The input language in the Windows 7 guest is DE. When

[Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction

2013-03-13 Thread Alon Levy
No change for 64 bit arches, but for 32 bit previously we zeroed half the surfaces cmd array, instead of all of it. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index ef69348..4cbab45 100644

Re: [Spice-devel] [spice-devel] [bug] is this a little bug ? (spice-common/common/region.c)

2013-03-10 Thread Alon Levy
Hi, Thanks for catching this! On 03/07/2013 11:55 AM, zhou link wrote: int region_bounds_intersects(const QRegion *rgn1, const QRegion *rgn2) { pixman_box32_t *extents1, *extents2; extents1 = pixman_region32_extents((pixman_region32_t *)rgn1); extents2 =

Re: [Spice-devel] [PATCH spice-server 05/28] mjpeg_encoder: adjust the stream bit rate based on periodic client feedback

2013-03-10 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:51PM -0500, Yonit Halperin wrote: mjpeg_encoder can receive periodic reports about the playback status on the client side. Then, mjpeg_encoder analyses the report and can increase or decrease the stream bit rate, depending on the report. When the bit rate is

Re: [Spice-devel] [PATCH spice 3/3] server/reds: Send the agent a CLIENT_DISCONNECTED msg on client disconnect

2013-03-06 Thread Alon Levy
Looks good to me, couldn't resist a nitpick though. Client - agent messages can spawn multiple VDIChunks. When this happens the agent re-assembles the chunks into a complete VDAgentMessage before processing it. The server only guarentees coherency at the chunk level, so it is not possible

Re: [Spice-devel] [PATCH spice-protocol 2/2] Prepare for a 0.12.5 release

2013-03-06 Thread Alon Levy
Both look good, as well as the whole spice-server 3 patchset using the message. Ack series. - Original Message - Signed-off-by: Hans de Goede hdego...@redhat.com --- NEWS | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS b/NEWS index df5d31c..a602292 100644 ---

Re: [Qemu-devel] [PATCH] libcacard: correct T0 historical bytes size

2013-03-05 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:58:36PM +0100, Marc-André Lureau wrote: ping Works, thanks. Reviewed-by: Alon Levy al...@redhat.com On Mon, Jan 14, 2013 at 5:18 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: ping On Sun, Dec 2, 2012 at 10:00 PM, Marc-André Lureau marcandre.lur

Re: [Spice-devel] [PATCH spice] Silence __spice_char_device_write_buffer_get: internal buf is not available

2013-03-04 Thread Alon Levy
These messages are printed when the server tries to push a mouse event to the agent before the previous one has been flushed. This is a normal condition (which gets tracked by the reds-pending_mouse_event boolean), and as such it should *not* trigger the printing of error messages. I've

Re: [Spice-devel] spice crashes

2013-03-03 Thread Alon Levy
Hi Klaus I am also having trouble with a windows 7 guest when I install guest-tools. I'm using some software called Altium Designer which freezes when I have guest-tools installed. I then installed just the win-qlx-debug driver and now, rather then freezing, the windows 7

Re: [Qemu-devel] Advice on some configuration parameters

2013-03-03 Thread Alon Levy
Il 01/03/2013 13:45, Paolo Bonzini ha scritto: Il 12/02/2013 14:05, Fabio Fantoni ha scritto: I'm making patches to enable some qemu upstream features in xen that are missing in libxl. I'm trying to do it just by giving arguments to qemu, and I want them to be dynamic (e.g. without

[Qemu-devel] [PATCH] configure: require spice-protocol = 0.12.3

2013-03-03 Thread Alon Levy
Required since v1.4.0-rc0 For SPICE_PORT_EVENT_BREAK used by spice-qemu-char.c since: commit 5a49d3e9a799b7e1bf87da7ae7f2a719e01da319 Author: Marc-André Lureau marcandre.lur...@gmail.com Date: Wed Dec 5 16:15:34 2012 +0100 spice-qemu-char: add spiceport chardev Signed-off-by: Alon Levy

Re: [Spice-devel] how can i set display resolution before connecting

2013-02-27 Thread Alon Levy
10:48,Alon Levy al...@redhat.com 写道: changxiaodong píše v St 20. 02. 2013 v 12:32 +0800: hello: how can i set the display resolution before connect to a desktop? no, that isn't possible. The windowed client will pick up whatever resolution is currently used in the guest, if the client

Re: [Spice-devel] how can i set display resolution before connecting

2013-02-27 Thread Alon Levy
Alon Levy píše v St 27. 02. 2013 v 03:57 -0500: In fact, I went a API that can send a message to agent in the guest and change resolution. There is no such API. You could make spice-gtk allow listening on a socket and receiving agent messages, or just a dbus protocol. What

Re: [Spice-devel] [PATCH] uxa: port over tiled fill code from EXA

2013-02-26 Thread Alon Levy
On Mon, Feb 25, 2013 at 03:39:00PM +1000, airl...@gmail.com wrote: From: Dave Airlie airl...@gmail.com This makes X -retro actually render fast, as opposed to glacially slow. Works with xspice. Didn't grok it otherwise. Tested-by ... Signed-off-by: Dave Airlie airl...@redhat.com ---

Re: [Spice-devel] qxl X.org driver bo abstraction for user mode setting

2013-02-26 Thread Alon Levy
On Tue, Feb 26, 2013 at 02:32:03PM +1000, Dave Airlie wrote: Hi, Patches don't apply on top of uxa: port over tiled fill code from EXA. Okay this is the next chunk of prep for getting KMS into the driver, the first 8 patches are just preparation work and moving stuff around, along with a

Re: [Spice-devel] how can i set display resolution before connecting

2013-02-26 Thread Alon Levy
changxiaodong píše v St 20. 02. 2013 v 12:32 +0800: hello: how can i set the display resolution before connect to a desktop? no, that isn't possible. The windowed client will pick up whatever resolution is currently used in the guest, if the client is run from full screen, it will try

Re: [Spice-devel] [PATCH 9/9] qxl: abstract object allocation away from surface/image/cursor code

2013-02-26 Thread Alon Levy
On Tue, Feb 26, 2013 at 02:32:12PM +1000, Dave Airlie wrote: ACK all the patches above, ACK this one too with small nit picks. Did not break xspice :) Regarding application of patches - I had to manually merge but the merges were the trivial ones so probably some whitespace? so if you manage to

Re: [Spice-devel] xorg driver cleanups

2013-02-25 Thread Alon Levy
On Mon, Feb 25, 2013 at 03:31:08PM +1000, airl...@gmail.com wrote: Hi, these patches just move code around in the X.org driver so it looks more like something that can be maintained, I'm going to start adding KMS support to it soon and i'd like to get stuff split out a bit better with an eye

Re: [Spice-devel] xorg driver cleanups

2013-02-25 Thread Alon Levy
On 02/24/2013 11:31 PM, airl...@gmail.com wrote: Hi, these patches just move code around in the X.org driver so it looks more like something that can be maintained, I'm going to start adding KMS support to it soon and i'd like to get stuff split out a bit better with an eye

Re: [Spice-devel] spice crashes

2013-02-21 Thread Alon Levy
- Original Message - 2013/2/20 Alon Levy al...@redhat.com: I haven't recompiled with debugging for the stack trace yet; is it still necessary, or does the information above suffice? Sorry for dropping the ball on this. I'm afraid it's hard to debug even with this information

Re: [Spice-devel] spice crashes

2013-02-21 Thread Alon Levy
What is the qemu command line? Are you running with kvm or with tcg? - Original Message - Hello Alon, ok, I've got the VM running under valgrind now, but valgrind quits logging due to excessive errors. The log is attached. Best regards, TF 2013/2/21 Trebor Forban

Re: [Spice-devel] spice crashes

2013-02-21 Thread Alon Levy
Can you run qemu built with debugging symbols? same goes for spice-server. - Original Message - Hello Alon, ok, I've got the VM running under valgrind now, but valgrind quits logging due to excessive errors. The log is attached. Best regards, TF 2013/2/21 Trebor Forban

Re: [Spice-devel] spice crashes

2013-02-20 Thread Alon Levy
disabled - see http://spice-space.org/wiki/index.php?title=Valgrind) it would perhaps point to the culprit. Stack trace would help too, but it won't point to the problem assuming it is memory corruption. Regards, TF 2013/1/22 Alon Levy al...@redhat.com: Hello All, while using remote

Re: [Spice-devel] recent spice-protocol doc

2013-02-20 Thread Alon Levy
Hi, Is there a more recent spice protocol definition than this one: http://spice-space.org/docs/spice_protocol.pdf ? Not that I'm aware of. You can always look at: http://cgit.freedesktop.org/spice/spice-common/tree/spice.proto Vincent DESPREZ

Re: [libvirt] [PATCH] Add support for qxl.revision in domain XML

2013-02-17 Thread Alon Levy
Hi Martin, On 02/04/2013 04:16 PM, Christophe Fergeau wrote: QXL devices have an associated 'revision' which is raised when new features have been introduced which would break migration to older versions. This commit makes it possible to set this revision as QEMU sometimes support newer

Re: [Spice-devel] Dinner tomorrow night (Mon Feb 17) in Brno

2013-02-17 Thread Alon Levy
Hi All, My plane lands in Brno tomorrow around 15:30, so I should be at Hotel Avanti around 16:30. Once I've checked in, I would like to go out and grab some dinner. So are there any other people in Brno tomorrow, who would also like to go out for dinner ? I would like to suggest to get

Re: [Spice-devel] [PATCH] Implement sending audio to the client from a directory of FIFO queues

2013-02-12 Thread Alon Levy
diff --git a/src/Makefile.am b/src/Makefile.am index 6950ba5..21d8dfc 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -77,6 +77,8 @@ spiceqxl_drv_la_SOURCES =\ spiceqxl_main_loop.h \ spiceqxl_display.c \ spiceqxl_display.h \ + spiceqxl_audio.c \ + spiceqxl_audio.h \

Re: [Spice-devel] Packaging spice-html5

2013-02-07 Thread Alon Levy
I'm going to put together a fedora package for spice-html5 and apply to become a package maintainer. That leads me to questions: 1. The process likes to have a static download location for the source tar ball. Presuming I make a spice-html5-0.0.1.tgz, where can I stash it?

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom size to 8192

2013-02-07 Thread Alon Levy
On 02/06/2013 05:52 PM, Cole Robinson wrote: On 01/22/2013 05:09 AM, Gerd Hoffmann wrote: From: Alon Levy al...@redhat.com This is a simpler solution to 869981, where migration breaks since qxl's rom bar size has changed. Instead of ignoring fields in QXLRom, which is what has

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom size to 8192

2013-02-07 Thread Alon Levy
On 02/07/2013 07:31 AM, Alon Levy wrote: On 02/06/2013 05:52 PM, Cole Robinson wrote: On 01/22/2013 05:09 AM, Gerd Hoffmann wrote: From: Alon Levy al...@redhat.com This is a simpler solution to 869981, where migration breaks since qxl's rom bar size has changed. Instead

Re: [Spice-devel] [PATCH] Establish a preferred default of 1024x768 correctly.

2013-02-05 Thread Alon Levy
Looks good to me, ACK. - Original Message - This fixes a bug with x-spice where you could not specify a default mode in an xorg.conf modeline that was greater than 1024x768. This also eliminates (and partially reverts) patch c1b537fc. It also fixes bug 894421, where gnome modes

Re: Proposed F19 Feature: QXL/Spice KMS Driver

2013-01-31 Thread Alon Levy
Dne 31.1.2013 12:52, Jaroslav Reznik napsal(a): = Features/QXLKMSSupport = https://fedoraproject.org/wiki/Features/QXLKMSSupport Feature owner(s): Alon Levy al...@redhat.com Currently the QXL driver is X.org only, a KMS driver is required to move forward with projects like spice

Re: Proposed F19 Feature: QXL/Spice KMS Driver

2013-01-31 Thread Alon Levy
On Thu, 2013-01-31 at 11:52 +, Jaroslav Reznik wrote: = Features/QXLKMSSupport = https://fedoraproject.org/wiki/Features/QXLKMSSupport Feature owner(s): Alon Levy al...@redhat.com Currently the QXL driver is X.org only, a KMS driver is required to move forward with projects

Re: [Spice-devel] FOSDEM?

2013-01-31 Thread Alon Levy
Hi everyone, On Fri, Jan 25, 2013 at 03:15:06PM +0100, Christophe Fergeau wrote: On Tue, Jan 22, 2013 at 10:47:05AM +0100, Hans de Goede wrote: On 01/21/2013 09:04 PM, Jeremy White wrote: Are there going to be any SPICE devs at FOSDEM? Anyone interested in trying to connect for

Re: [Spice-devel] settings for qxl memory size

2013-01-24 Thread Alon Levy
2013/1/23 Alon Levy al...@redhat.com: Looks like the client isn't supplying the correct password set below. You can also disable passwords by the disable-ticketing option, i.e. -spice disable-ticketing,... I didn't notice that warning, I should have disabled passwords for the sake

Re: [Spice-devel] Fedora 18 guest's GUI is slow. Due to 3D driver?

2013-01-24 Thread Alon Levy
hi list, I am running Fedora 18 (GNOME version) as a guest in a host with qemu 1.3. But the desktop is slow. I have already opened 3D acceleration in the guest's xml definition file.But the desktop is slow. I have already opened 3D acceleration in the guest's xml definition file. By the

[Spice-devel] [PATCH] RFC: add QXLListCmd for batched commands

2013-01-24 Thread Alon Levy
--- spice/qxl_dev.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index a3e91a5..c2fda3a 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -351,6 +351,12 @@ typedef struct SPICE_ATTR_PACKED QXLCursorCmd { uint8_t

[Spice-devel] [PATCH spice-common] common/draw.h: add SpiceCopyBits

2013-01-24 Thread Alon Levy
Similar to the almost identity relation between QXLFoo and SpiceFoo for other structs, this one has just been left out. --- common/draw.h | 4 1 file changed, 4 insertions(+) diff --git a/common/draw.h b/common/draw.h index 3704358..1df42e8 100644 --- a/common/draw.h +++ b/common/draw.h @@

[Spice-devel] [PATCH] server/red_parse_qxl.h: use SpiceCopyBits

2013-01-24 Thread Alon Levy
--- server/red_parse_qxl.h | 4 +--- spice-common | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/server/red_parse_qxl.h b/server/red_parse_qxl.h index 3adc9fa..58dc52d 100644 --- a/server/red_parse_qxl.h +++ b/server/red_parse_qxl.h @@ -43,9 +43,7 @@ typedef

Re: [Spice-devel] Fedora 18 guest's GUI is slow. Due to 3D driver?

2013-01-24 Thread Alon Levy
to speed that up, the usual spice approach of passing through commands all the way to the client only applies to 2d rendering. Windows XP/7 are not doing 3d rendering, hence the difference. Thanks. On 01/24/2013 09:13 PM, Alon Levy wrote: hi list, I am running Fedora 18 (GNOME version

Re: [Spice-devel] Question about poor performance of Ubuntu VMs

2013-01-24 Thread Alon Levy
Greetings, I'm a big Red Hat / clone slash Fedora guy... and I use use a lot of KVM. I primarily create Fedora, RHEL/clone, and Windows KVM guests and they work great... but every once in a while I like to try out an Ubuntu release just to see what's new. I have tried their Unity spin as

Re: [Spice-devel] spice crashes

2013-01-22 Thread Alon Levy
Hello All, while using remote-viewer, qemu and libs as compiled below, my 32bit-win7-VMs (spice-guest-tools-0.3.exe) are crashing quit frequently, and the following error is shown in the hosts dmesg log: segfault at 50 ip 7f8b6bab3119 sp 7f8b64db3b00 error 6 in

Re: [Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

2013-01-22 Thread Alon Levy
BTW reading patch 1 again, I wonder what exactly it tries to solve, since currently when using spice with qemu (no experience with x-spice) you can already set modes 1024x768 without problems. This will teach me to set down a patch for a few months while I work on other things :-(.

Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors

2013-01-21 Thread Alon Levy
On 01/16/13 18:59, Alon Levy wrote: Regarding orientation setting in windows 7 64 guest: Desktop, right click-Screen resolution - You can choose Orientation: Landscape, Portrait, Landscape (flipped), Portrait (flipped) - You can choose Resolution - You can click Advanced Settings

[Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision 4

2013-01-21 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 11 +++ trace-events | 2 ++ 2 files changed, 13 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 9dc44b9..0d81816 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -945,6 +945,12 @@ static void interface_set_client_capabilities

[Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192

2013-01-21 Thread Alon Levy
prior to the patch, and the patch loses the ability to set Portrait modes. But this is a separate bug to be fixed in the driver, and besides the patch doesn't affect the new arbitrary mode setting functionality. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 13 +++-- 1 file

Re: [Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision 4

2013-01-21 Thread Alon Levy
Adding Gerd. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 11 +++ trace-events | 2 ++ 2 files changed, 13 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 9dc44b9..0d81816 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -945,6 +945,12 @@ static void

Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors

2013-01-20 Thread Alon Levy
On Thu, Jan 17, 2013 at 02:02:26PM +0100, Gerd Hoffmann wrote: On 01/16/13 18:59, Alon Levy wrote: Regarding orientation setting in windows 7 64 guest: Desktop, right click-Screen resolution - You can choose Orientation: Landscape, Portrait, Landscape (flipped), Portrait (flipped

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-18 Thread Alon Levy
maybe you can solve it quicker for me then myself :) - Original Message - On 01/17/2013 12:35 PM, Alon Levy wrote: Adds a qxl-ram attribute globaly to the video.model element, that changes s/globaly/globally/ the resulting qemu command line only if video.type == qxl

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-18 Thread Alon Levy
On 01/17/2013 12:35 PM, Alon Levy wrote: Adds a qxl-ram attribute globaly to the video.model element, that changes s/globaly/globally/ check. the resulting qemu command line only if video.type == qxl. That attribute gets a default value of 64*1024 only if model.type is qxl

[libvirt] [PATCH v2] qemu: Support ram bar size for qxl devices

2013-01-18 Thread Alon Levy
Adds a ram attribute globally to the video.model element, that changes the resulting qemu command line only if video.type == qxl. video model type='qxl' ram='65536' vram='65536' heads='1'/ /video That attribute gets a default value of 64*1024. The schema is unchanged for other video element

Re: [Spice-devel] settings for qxl memory size

2013-01-18 Thread Alon Levy
Thanks for your reply, I did more tests with this new patch for qxl, but it still doesn't work: http://lists.xen.org/archives/html/xen-devel/2013-01/msg01405.html Hi Davide, Perhaps you should ask on xen-devel? I am curios about this effort but I don't think anyone involved with it is on

[Spice-devel] win7 guest display flipped

2013-01-18 Thread Alon Levy
Hi, Did this ever work: start win7 guest (I'm using 64 bit), desktop, screen resolution, choose one of the flipped options (landscape/portrait) - I get an error dialog: title: Change Settings Contents: Unable to save display settings. Choosing both of the non flipped modes (landscape,

[libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-17 Thread Alon Levy
Adds a qxl-ram attribute globaly to the video.model element, that changes the resulting qemu command line only if video.type == qxl. That attribute gets a default value of 64*1024 only if model.type is qxl. In effect not changing any xml or argv for non qxl devices. For qxl devices a new

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-17 Thread Alon Levy
On Thu, Jan 17, 2013 at 09:35:22PM +0200, Alon Levy wrote: Adds a qxl-ram attribute globaly to the video.model element, that changes the resulting qemu command line only if video.type == qxl. That attribute gets a default value of 64*1024 only if model.type is qxl. In effect

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-17 Thread Alon Levy
On 17.01.2013 20:35, Alon Levy wrote: Adds a qxl-ram attribute globaly to the video.model element, that changes the resulting qemu command line only if video.type == qxl. That attribute gets a default value of 64*1024 only if model.type is qxl. In effect not changing any xml

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-17 Thread Alon Levy
On Thu, Jan 17, 2013 at 09:35:22PM +0200, Alon Levy wrote: Adds a qxl-ram attribute globaly to the video.model element, that changes the resulting qemu command line only if video.type == qxl. That attribute gets a default value of 64*1024 only if model.type is qxl. In effect

Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors

2013-01-17 Thread Alon Levy
- Original Message - On 01/16/13 18:59, Alon Levy wrote: Regarding orientation setting in windows 7 64 guest: Desktop, right click-Screen resolution - You can choose Orientation: Landscape, Portrait, Landscape (flipped), Portrait (flipped) - You can choose Resolution

Re: [Spice-devel] spice multi-clients issue

2013-01-16 Thread Alon Levy
Hi,All, Currently I'm trying the multi-client feature of spice, the server side is spice-server-0.10 and qemu-kvm-1.1, if I use only from Linux machine the spicec-0.10 or spice-gtk-0.10 as clients, the multi-clients works fine, but if I use the old version(e.g. spicec-0.6) spicec-win32 or

[Qemu-devel] [PATCH v2 2/2] qxl: change rom size to 8192

2013-01-16 Thread Alon Levy
the future QXLRom increases via spice-protocol changes. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 0d81816..0cd854a 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -79,10 +79,7

[Qemu-devel] [PATCH v2 0/2] fix two revision related errors

2013-01-16 Thread Alon Levy
the normal - hard code 8192 bytes rom size - assert if the required size is larger Alon Levy (2): qxl: stop using non revision 4 rom fields for revision 4 qxl: change rom size to 8192 hw/qxl.c | 25 ++--- trace-events | 2 ++ 2 files changed, 20 insertions(+), 7

[Qemu-devel] [PATCH v2 1/2] qxl: stop using non revision 4 rom fields for revision 4

2013-01-16 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 11 +++ trace-events | 2 ++ 2 files changed, 13 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 9dc44b9..0d81816 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -945,6 +945,12 @@ static void interface_set_client_capabilities

Re: [Spice-devel] [PATCH spice 1/2] server: Fix SpiceWorker-CRITICAL **: red_worker.c:10968:red_push_monitors_config: condition `monitors_config != NULL' failed

2013-01-15 Thread Alon Levy
On Thu, Jan 10, 2013 at 11:52:38PM +0100, Hans de Goede wrote: During my dynamic monitor support testing today, I hit the following assert in red_worker.c: red_push_monitors_config: condition `monitors_config != NULL' failed This is caused by the following scenario: 1) Guest causes

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 size 8192

2013-01-15 Thread Alon Levy
On Sun, Dec 23, 2012 at 10:31:38PM +0200, Alon Levy wrote: On Thu, Dec 13, 2012 at 01:05:48PM +0100, Gerd Hoffmann wrote: On 12/13/12 12:36, Alon Levy wrote: This is a simpler solution to 869981, where migration breaks since qxl's rom bar size has changed. Instead of ignoring fields

Re: [Spice-devel] [PATCH] link libspice server with libm libpthread

2013-01-14 Thread Alon Levy
On Fri, Jan 11, 2013 at 11:23:33PM +0400, Michael Tokarev wrote: Ping? Pushed. More than half a year has been passed away, but the patch is still needed for current 0.12.2 version... (patchwork url: http://patchwork.freedesktop.org/patch/10546/ ) Thanks, /mjt 04.06.2012 13:35,

Re: [Spice-devel] Could you please give me some help on windows display driver?

2013-01-07 Thread Alon Levy
Forwarding to spice-devel. Please post there next time, thanks. Alon, I'm new to windows display driver, I read the qxl xddm driver and found you are the main committer to this project. I write a miniport driver and a display driver, install them to windows xp. And infos from

Re: [Spice-devel] multi-clients issue

2012-12-23 Thread Alon Levy
On Wed, Dec 19, 2012 at 01:05:04PM +0800, Rozen Lin wrote: Hi,All, Currently I'm trying the multi-client feature of spice, the server side is spice-server-0.10 and qemu-kvm-1.1, if I use only from Linux machine the spicec-0.10 or spice-gtk-0.10 as clients, the multi-clients works fine, but

Re: [Spice-devel] Announcing spice 0.12.2 spice-protocol 0.12.3

2012-12-23 Thread Alon Levy
On Thu, Dec 20, 2012 at 09:18:17PM +0100, Hans de Goede wrote: Hi All, I'm happy to announce a new bugfix (+ a small feature) release in the stable spice-0.12.x series. Changes in spice-0.12.2: * Skipped 0.12.1, it existed in git but was never released *

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 size 8192

2012-12-23 Thread Alon Levy
On Thu, Dec 13, 2012 at 01:05:48PM +0100, Gerd Hoffmann wrote: On 12/13/12 12:36, Alon Levy wrote: This is a simpler solution to 869981, where migration breaks since qxl's rom bar size has changed. Instead of ignoring fields in QXLRom, which is what has actually changed, we remove some

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision 4

2012-12-23 Thread Alon Levy
On Thu, Dec 13, 2012 at 03:43:46PM +0100, Gerd Hoffmann wrote: Hi, That is indeed a better solution, but it does change functionality. I think it is correct but I'd like to get some other opinions - Uri, Arnon, Yonit, Soren - any problems with dropping these? Orientation is used in

Re: [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386

2012-12-23 Thread Alon Levy
On Wed, Dec 19, 2012 at 09:33:28AM +0100, Paolo Bonzini wrote: Il 28/11/2012 10:53, Alon Levy ha scritto: Il 28/11/2012 10:16, Alon Levy ha scritto: diff --git a/roms/openbios b/roms/openbios index f095c85..d1d2787 16 --- a/roms/openbios +++ b/roms/openbios @@ -1 +1

[Qemu-devel] [PATCH] usb/redirect.c: unbreak compilation due to include/char/char.h

2012-12-23 Thread Alon Levy
Broken since: commit 927d4878b0ff319ed87fed9363f314613b0a5ed9 Author: Paolo Bonzini pbonz...@redhat.com Date: Mon Dec 17 18:20:05 2012 +0100 softmmu: move remaining include files to include/ subdirectories Signed-off-by: Alon Levy al...@redhat.com --- hw/usb/redirect.c | 1 + 1 file

[Qemu-devel] [PATCH] spice-qemu-char: register interface on post load

2012-12-23 Thread Alon Levy
is static in the guest. By registering the interface on post load spice server will pass on the agent messages fixing the mouse behavior after migration. RHBZ #725965 Signed-off-by: Alon Levy al...@redhat.com --- spice-qemu-char.c | 42 ++ 1 file changed, 42

Re: [Spice-devel] [PATCH] red_parse_qxl: fix throwing away drawables that have masks

2012-12-13 Thread Alon Levy
All looks good except the assert. We should be removing them whenever they are guest trigerable - maybe I'm not following the code, but if in red_get_image sees no pallete in the qxl struct then palette will be NULL, which means it's guest trigerable. Non rgb bitmaps are allowed to not have a

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision 4

2012-12-13 Thread Alon Levy
On 12/06/12 16:41, Alon Levy wrote: RHBZ 869981 Before this patch revision 4 (4 is the default) would result in a wrong qxl_rom size of 16384 instead of 8192 when building with spice-protocol-0.12, due to the addition of fields in the rom for client capabilities and monitors

Re: [Qemu-devel] [PATCH 0/4] virtio-serial: Rework, fix post_load code

2012-12-13 Thread Alon Levy
All looks good. Reviewed-by: Alon Levy al...@redhat.com - Original Message - This series reworks the post_load code recently introduced to allocate the structures only when required (i.e. only at load time). This helps keep the VirtIOSerial struct clean, and use less RAM. Also

[Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 size 8192

2012-12-13 Thread Alon Levy
in failure at startup (could do this compile time also but not sure how). Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 8611ee9..99b354a 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -88,9 +88,7

[Qemu-devel] [PATCH 1/2] qxl: stop using non revision 4 rom fields for revision 4

2012-12-13 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 11 +++ trace-events | 2 ++ 2 files changed, 13 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 3f835b8..8611ee9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -981,6 +981,12 @@ static void interface_set_client_capabilities

Re: [Spice-devel] Translating the Spice protocol using spice-client-glib

2012-12-11 Thread Alon Levy
Hello, I am looking to use spice-client-glib (which seems to be the only low-level client library available) to implement a plugin for guacd which translates between the Spice protocol and the Guacamole protocol, thus adding Spice support to Guacamole (an HTML5 remote desktop gateway).

Re: [Spice-devel] [PATCH spice-server] red_worker: revert 8855438a

2012-12-06 Thread Alon Levy
ACK - Original Message - red_proccess_commands calls were added after calling guest_set_client_capabilities in order to cleanup the command ring from old commands that the client might not be able to handle. However, calling red_process_commands at this stage does send messages to

Re: [Spice-devel] Building qxl w/WDK

2012-12-06 Thread Alon Levy
Hi, Is building qxl supported with the latest WDK 8.59.25584? http://www.spice-space.org/page/WinQXL I am trying to follow the directions. I open up a command prompt called Microsoft Windows 7 x64 Debug Build Environment and set SPICE_COMMON_DIR and run the build -cZg command. I get

[Qemu-devel] [PATCH] arch_init/ram_load: add error message for block length mismatch

2012-12-06 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- arch_init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index e6effe8..84bca99 100644 --- a/arch_init.c +++ b/arch_init.c @@ -808,8 +808,10 @@ static int ram_load(QEMUFile *f, void *opaque, int

[Qemu-devel] [PATCH v2] arch_init/ram_load: add error message for block length mismatch

2012-12-06 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- Please ignore previous version, accidentally removed goto done and used wrong format size specifiers. arch_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch_init.c b/arch_init.c index e6effe8..fba24f3 100644 --- a/arch_init.c +++ b

Re: [Qemu-devel] [PATCH] arch_init/ram_load: add error message for block length mismatch

2012-12-06 Thread Alon Levy
On 12/06/2012 02:02 PM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- arch_init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index e6effe8..84bca99 100644 --- a/arch_init.c +++ b/arch_init.c @@ -808,8

[Qemu-devel] [PATCH] qxl: use correct rom size for revision 4

2012-12-06 Thread Alon Levy
and nop-ing. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 37 - hw/qxl.h | 2 ++ trace-events | 2 ++ 3 files changed, 36 insertions(+), 5 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 3f835b8..4794f13 100644 --- a/hw/qxl.c +++ b/hw

Re: [Spice-devel] Adding the support for chromium to spice-xpi

2012-12-03 Thread Alon Levy
The goal of the following patches is to add the support for the chromium browser. Along the way small issues has been fixed. The resulting build for fedora 17 can be found here: http://fsimonce.fedorapeople.org/spice-xpi-chromium-f17/ And it has been succesfully tested with

Re: [Spice-devel] [Qemu-devel] [PATCH 2/6] spice-qemu-char: write to chardev whatever amount it can read

2012-12-02 Thread Alon Levy
The current code waits until the chardev can read MIN(len, VMC_MAX) But some chardev may never reach than amount, in fact some of them will only ever accept write of 1. Fix the min computation and remove the VMC_MAX constant. Looks good to me. Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH 2/6] spice-qemu-char: write to chardev whatever amount it can read

2012-12-02 Thread Alon Levy
The current code waits until the chardev can read MIN(len, VMC_MAX) But some chardev may never reach than amount, in fact some of them will only ever accept write of 1. Fix the min computation and remove the VMC_MAX constant. Looks good to me. Signed-off-by: Marc-André Lureau

Re: [Spice-devel] server RFC: 2 significant build-time changes

2012-11-28 Thread Alon Levy
On Fri, Nov 23, 2012 at 04:58:23PM +0100, Christophe Fergeau wrote: Hey, This patch series introduces 2 build system changes that are worth some attention. The first one disables client build by default as it's deprecated, and the second patch adds a dependency on glib2. Both of

Re: [Spice-devel] Spice Display updates

2012-11-28 Thread Alon Levy
Hi, Technologies like VNC send screen updates primarily to the client to reduce bandwidth utilization between client and server. But after every few seconds, VNC sends across entire screen data to VNC client (I believe to recover from any corruption). Does spice send entire screen data to

Re: [Spice-devel] [PATCH spice-protocol V3] vd_agent.h: drag-and-drop support

2012-11-28 Thread Alon Levy
Hi - Mensaje original - At present, Vmware and Virtualbox has supported file dragdrop feature, I think it's a good feature for users, so we want qemu/spice to supports it. This patch first adds communication protocol between client and guest, we must make the agent

<    1   2   3   4   5   6   7   8   9   10   >