Re: [Spice-devel] [Spice-commits] spice/enums.h

2012-07-16 Thread Alon Levy
On Mon, Jul 16, 2012 at 03:02:36PM +0200, Marc-André Lureau wrote: Hi On Mon, Jul 16, 2012 at 2:53 PM, Alon Levy al...@redhat.com wrote: [could you please keep me in cc/to?] I use GMail reply-to-all, and it doesn't include you. Sorry when that happens, but I don't pay attention

Re: [Spice-devel] [PATCH] build-sys: fix make distcheck

2012-07-16 Thread Alon Levy
d0cbc0518fcb0ad5f441387a4530c63ff377ba48 Author: Alon Levy al...@redhat.com Date: Mon Jul 16 12:04:34 2012 +0300 enums.h: generate in build directory, passes distcheck diff --git a/common/Makefile.am b/common/Makefile.am index 3210fc8..3ae2a6b 100644 --- a/common/Makefile.am +++ b/common/Makefile.am

Re: [Spice-devel] [PATCH spice 1/3] build-sys: define GL flags if enabled

2012-07-16 Thread Alon Levy
On Mon, Jul 16, 2012 at 04:17:24PM +0200, Marc-André Lureau wrote: The server too can use opengl, independently from client. ACK series. --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 8f9474e..75a062c 100644 ---

Re: [Spice-devel] [PATCH] build-sys: fix make distcheck

2012-07-16 Thread Alon Levy
On Mon, Jul 16, 2012 at 05:06:06PM +0200, Christophe Fergeau wrote: On Mon, Jul 16, 2012 at 06:00:45PM +0300, Alon Levy wrote: On Mon, Jul 16, 2012 at 04:16:54PM +0200, Marc-André Lureau wrote: - don't try to overwrite read-only enums.h I thought you were speaking about fixing non

Re: [Spice-devel] [PATCH] build-sys: fix make distcheck

2012-07-16 Thread Alon Levy
On Mon, Jul 16, 2012 at 05:06:42PM +0200, Marc-André Lureau wrote: Hi On Mon, Jul 16, 2012 at 5:00 PM, Alon Levy al...@redhat.com wrote: Drop this, instead use the following: commit d0cbc0518fcb0ad5f441387a4530c63ff377ba48 Author: Alon Levy al...@redhat.com Date: Mon Jul 16 12:04

Re: [Spice-devel] [PATCH] build-sys: fix make distcheck

2012-07-16 Thread Alon Levy
On Mon, Jul 16, 2012 at 11:26:28AM -0400, Marc-André Lureau wrote: - Mensaje original - On Mon, Jul 16, 2012 at 05:06:42PM +0200, Marc-André Lureau wrote: Hi On Mon, Jul 16, 2012 at 5:00 PM, Alon Levy al...@redhat.com wrote: Drop this, instead use the following

[Spice-devel] [PATCH] server: add monitors_config support

2012-07-16 Thread Alon Levy
a SpiceMsgDisplayMonitorsConfig is sent on two occasions: * as a result of a spice_qxl_monitors_config_async * whenever a client connects and there is a previously set monitors config Sending the new message is protected by a new cap, SPICE_DISPLAY_CAP_MONITORS_CONFIG More elaborately:

Re: [Spice-devel] [PATCH 1/2] server: factor out bitmap_fmt_is_rgb

2012-07-16 Thread Alon Levy
On Mon, Jul 16, 2012 at 11:40:51AM -0400, Marc-André Lureau wrote: - Mensaje original - --- server/red_common.h | 11 +++ server/red_worker.c | 15 +++ 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/server/red_common.h

Re: [Spice-devel] [PATCH spice-protocol] support multiple monitors on a single display channel

2012-07-14 Thread Alon Levy
On Fri, Jul 13, 2012 at 11:39:06AM +0200, Christophe Fergeau wrote: On Thu, Jul 12, 2012 at 07:49:45PM +0300, Alon Levy wrote: Adds on device: RAM Header monitors_config - pointer QXLMonitorsConfig count == n max_allowed = N = 0 QXLHead 1 ... QXLHead n

Re: [Spice-devel] [PATCH 2/2] server: don't abort on guest images with missing palettes

2012-07-14 Thread Alon Levy
On Thu, Jul 12, 2012 at 09:05:13PM +0200, Marc-André Lureau wrote: On Thu, Jul 12, 2012 at 7:46 PM, Alon Levy al...@redhat.com wrote: +if (!BITMAP_FMT_IS_RGB[qxl-bitmap.format] !qxl-bitmap.palette) { Could it be possible to make this a common inline function, and doing a check

[Spice-devel] [PATCH spice-protocol] support multiple monitors on a single display channel

2012-07-12 Thread Alon Levy
Adds on device: RAM Header monitors_config - pointer QXLMonitorsConfig count == n max_allowed = N = 0 QXLHead 1 ... QXLHead n id, surface_id, x, y, width, height, flags IO: QXL_IO_MONITORS_CONFIG server flushes command ring, then calls server callback for changing monitors

[Spice-devel] [PATCH spice-common] support multiple monitors in single display channel

2012-07-12 Thread Alon Levy
See spice-protocol commit for details: da908f89b581fd4725da997fdaea209f8e6548f6 support multiple monitors on a single display channel --- common/messages.h | 16 spice-protocol|2 +- spice.proto | 16 3 files changed, 33 insertions(+), 1

[Spice-devel] [PATCH 1/2] server/reds: more fixes for wrong spice_error in d2c99b59

2012-07-12 Thread Alon Levy
--- server/reds.c | 136 - 1 file changed, 68 insertions(+), 68 deletions(-) diff --git a/server/reds.c b/server/reds.c index c33c86c..e3ea154 100644 --- a/server/reds.c +++ b/server/reds.c @@ -1958,7 +1958,7 @@ static void

[Spice-devel] [PATCH 2/2] server: don't abort on guest images with missing palettes

2012-07-12 Thread Alon Levy
--- server/red_parse_qxl.c |9 + server/red_worker.c|4 2 files changed, 13 insertions(+) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index e6c2705..bae9135 100644 --- a/server/red_parse_qxl.c +++ b/server/red_parse_qxl.c @@ -328,6 +328,10 @@ static

[Spice-devel] [PATCH 1/2] server/red_worker: fix wrong spice_error in commit 706232a8

2012-07-11 Thread Alon Levy
--- server/red_worker.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index c492443..ac9baf2 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1212,7 +1212,7 @@ static inline void

[Spice-devel] [PATCH 2/2] server/reds: fix wrong spice_error in d2c99b59

2012-07-11 Thread Alon Levy
--- server/reds.c | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/server/reds.c b/server/reds.c index c8b5fc4..c33c86c 100644 --- a/server/reds.c +++ b/server/reds.c @@ -547,7 +547,7 @@ void

Re: [Spice-devel] [PATCH] validate tcp port values

2012-07-11 Thread Alon Levy
On Wed, Jul 11, 2012 at 01:03:28PM +0200, Peter Hatina wrote: Hi, I had a request to validate TCP port values in spice-xpi, so does this make sense for you? More info at https://bugzilla.redhat.com/show_bug.cgi?id=805602 --- SpiceXPI/src/plugin/plugin.cpp | 27

Re: [Users] [Spice-devel] The problem with spicevmc not supported in this QEMU binary

2012-07-09 Thread Alon Levy
On Mon, Jul 09, 2012 at 10:25:13AM +0800, xuejie chen wrote: 2012/7/6 Alon Levy al...@redhat.com: On Fri, Jul 06, 2012 at 03:55:30PM +0300, Itamar Heim wrote: On 07/06/2012 06:46 AM, xuejie chen wrote: Hi everyone, I installed the vdsm(4.9.6) in CentOS 6 and the libvirt version

Re: [Spice-devel] [Users] The problem with spicevmc not supported in this QEMU binary

2012-07-09 Thread Alon Levy
On Mon, Jul 09, 2012 at 10:25:13AM +0800, xuejie chen wrote: 2012/7/6 Alon Levy al...@redhat.com: On Fri, Jul 06, 2012 at 03:55:30PM +0300, Itamar Heim wrote: On 07/06/2012 06:46 AM, xuejie chen wrote: Hi everyone, I installed the vdsm(4.9.6) in CentOS 6 and the libvirt version

Re: [Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-09 Thread Alon Levy
On Sat, Jul 07, 2012 at 03:26:22PM -0500, Jeremy White wrote: On 07/06/2012 01:47 PM, Jeremy White wrote: On 07/05/2012 04:38 AM, Alon Levy wrote: Replaced mostly with spice_debug, but spice_warning spice_error as well where appropriate. Boy, I do like this patch, but oddly

Re: [Spice-devel] [PATCH] update rdf versions - plugin, firefox

2012-07-09 Thread Alon Levy
On Mon, Jul 09, 2012 at 03:25:54PM +0200, Peter Hatina wrote: Hi, I am rising spice-xpi version and also supported Raising. Ack. I sure hope there is a saner way then chasing the ever increasing version numbers.. versions of firefox. Peter Hatina EMEA ENG-Desktop Development Red Hat

Re: [Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-09 Thread Alon Levy
On Mon, Jul 09, 2012 at 08:47:34AM -0500, Jeremy White wrote: abort happens only on critical by default, not on error, so this is strange - unless you've set SPICE_ABORT_LEVEL_DEFAULT to something else. See http://cgit.freedesktop.org/spice/spice-common/tree/common/log.c#n84 Um, I think:

Re: [Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-08 Thread Alon Levy
On Sat, Jul 07, 2012 at 03:26:22PM -0500, Jeremy White wrote: On 07/06/2012 01:47 PM, Jeremy White wrote: On 07/05/2012 04:38 AM, Alon Levy wrote: Replaced mostly with spice_debug, but spice_warning spice_error as well where appropriate. Boy, I do like this patch, but oddly

Re: [Spice-devel] [protocol] Add spice/Makefile to the generated .gitignore

2012-07-06 Thread Alon Levy
On Thu, Jul 05, 2012 at 08:04:10PM -0500, Jeremy White wrote: Okay, I wrote to Behdad Esfahbod, who rapidly and cheerfully fixed the upstream issue. Attached is the upstream patch. If applied to spice-protocol, then it should no longer be the case that a clone spice; ./autogen.sh; make;

[Spice-devel] [PATCH spice-common] common/log.h: add spice_client_error

2012-07-05 Thread Alon Levy
To be used to mark client protocol violations, more easily greppable. --- common/log.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/common/log.h b/common/log.h index 37c491f..df8a756 100644 --- a/common/log.h +++ b/common/log.h @@ -28,6 +28,10 @@ SPICE_BEGIN_DECLS #define

[Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-05 Thread Alon Levy
Replaced mostly with spice_debug, but spice_warning spice_error as well where appropriate. --- server/red_worker.c | 182 +-- 1 file changed, 91 insertions(+), 91 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index

Re: [Spice-devel] [PATCH spice-common] common/log.h: add spice_client_error

2012-07-05 Thread Alon Levy
On Thu, Jul 05, 2012 at 01:10:44PM +0200, Marc-André Lureau wrote: On Thu, Jul 5, 2012 at 11:38 AM, Alon Levy al...@redhat.com wrote: To be used to mark client protocol violations, more easily greppable. --- common/log.h | 11 +++ 1 file changed, 11 insertions(+) diff --git

[Spice-devel] [PATCH spice-common] common/log.h: add spice_info

2012-07-05 Thread Alon Levy
--- common/log.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/common/log.h b/common/log.h index 37c491f..d9e6023 100644 --- a/common/log.h +++ b/common/log.h @@ -85,6 +85,12 @@ void spice_log(const char *log_domain, } SPICE_STMT_END #endif +#ifndef spice_info +#define

Re: [Spice-devel] [PATCH spice-common] common/log.h: add spice_client_error

2012-07-05 Thread Alon Levy
On Thu, Jul 05, 2012 at 01:20:35PM +0200, Marc-André Lureau wrote: Hi On Thu, Jul 5, 2012 at 1:17 PM, Alon Levy al...@redhat.com wrote: That doesn't allow me to have in the same compilation unit (red_worker.c) two domains. Also, you can't define macros with macros, so I'm not sure what

[Spice-devel] [PATCH 1/4] server/red_worker: cleanup lines starting with 5 spaces

2012-07-05 Thread Alon Levy
--- server/red_worker.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index ef1b1b1..3092218 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -6132,22 +6132,22 @@ static int

[Spice-devel] [PATCH 2/4] update spice-common for spice_info

2012-07-05 Thread Alon Levy
--- spice-common |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common b/spice-common index f8f6231..2449260 16 --- a/spice-common +++ b/spice-common @@ -1 +1 @@ -Subproject commit f8f6231ecdb99595a07e6c3933dedd7438ef4f1d +Subproject commit

[Spice-devel] [PATCH 3/4] server/red_worker: elevate some spice_debugs to spice_info

2012-07-05 Thread Alon Levy
Specifically all those that the previous patch converted to spice_debug. spice_debug contains very verbose stuff like update_area that drowns out those relatively rare (client connect / disconnect generated) messages. --- server/red_worker.c | 104

[Spice-devel] [PATCH 4/4] server/reds.c: spice_printerr cleanup

2012-07-05 Thread Alon Levy
Rules for replacing spice_printerr: * if it's a client drop / agent drop, spice_error * if it's important, spice_warning * else, spice_info. The fourth rule is spice_debug if it's going to fill up the log, but nothing of the sort here. Other things this patch does: * changed

[Qemu-devel] [Bug 1020484] Re: RFE: Support spice via unix domain socket

2012-07-04 Thread Alon Levy
There is already support for that in spice-server afaik, though I don't remember the api or what commit, or if it's in a released version (well, it's surely in 0.11.0, but that's unstable). Sorry about the lack of details, I suggest you search spice-devel mailing list archive though. I think

Re: [Spice-devel] [PATCH spice-gtk] controller: async flush read/write

2012-07-03 Thread Alon Levy
On Tue, Jul 03, 2012 at 03:41:21AM +0200, Marc-André Lureau wrote: Windows namedpipes behave a bit differently from Unix socket, and may return incomplete read/write. By using 2 read/write() helpers, try to complete the operation before returning. Since the IO operation may be splitted over

Re: [Qemu-devel] [PATCH] console: Implementing blinking of cursor

2012-07-03 Thread Alon Levy
On Mon, Jul 02, 2012 at 10:20:17AM +0200, Jan Kiszka wrote: One comment below. Reviewed-by: Alon Levy al...@redhat.com Let the text console cursor blink at 5 HZ. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- console.c | 26 +- 1 files changed, 25

Re: [Qemu-devel] [PATCH] console: Implementing blinking of cursor

2012-07-03 Thread Alon Levy
On Tue, Jul 03, 2012 at 11:05:50AM +0200, Jan Kiszka wrote: On 2012-07-03 10:59, Alon Levy wrote: On Mon, Jul 02, 2012 at 10:20:17AM +0200, Jan Kiszka wrote: One comment below. Reviewed-by: Alon Levy al...@redhat.com Let the text console cursor blink at 5 HZ. Signed-off

[Spice-devel] [PATCH] update spice-common

2012-07-02 Thread Alon Levy
Includes using the same spice.proto as spice-gtk now, with smartcard fixes, more verbose output when SSL verification fails, and some warnings fixes. shortlog: Alon Levy (6): python_modules/ptypes.py/EnumBaseType.c_enumname: add missing return to fix broken enums generation smartcard

Re: [Spice-devel] [PATCH spice-server 03/14] char_device: Introducing shared flow control code for char devices.

2012-07-02 Thread Alon Levy
On Wed, Jun 27, 2012 at 06:16:41PM +0300, Yonit Halperin wrote: I didn't review the whole series, but since I see Hans already provided some comments on this patch I'll add my own. I also think the patchset looks very good. For the future, it would be nice to have byte level accounting as well

Re: [Spice-devel] xf86-video-qxl performance

2012-06-30 Thread Alon Levy
On Fri, Jun 29, 2012 at 11:37:37AM -0500, Jeremy White wrote: I am going to dive into the xf86 driver performance in a serious way starting next week. I'm planning on building instrumentation to let me build sample data sets. I want to see what sort of X operations result from a typical

[PATCH xrandr] add EOL on XA_INTEGER properties of length % 16 != 15

2012-06-27 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- xrandr.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/xrandr.c b/xrandr.c index 6683ceb..7bc5eee 100644 --- a/xrandr.c +++ b/xrandr.c @@ -3143,6 +3143,8 @@ main (int argc, char **argv) if (k % 16 == 15

[Spice-devel] [PATCH] spice.h: bump SPICE_SERVER_VERSION for release 0.11.0

2012-06-21 Thread Alon Levy
--- server/spice.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/spice.h b/server/spice.h index a6b3c3d..abaffbd 100644 --- a/server/spice.h +++ b/server/spice.h @@ -22,7 +22,7 @@ #include sys/socket.h #include spice/qxl_dev.h -#define SPICE_SERVER_VERSION

Re: [Spice-devel] [PATCH] spice.h: bump SPICE_SERVER_VERSION for release 0.11.0

2012-06-21 Thread Alon Levy
On Thu, Jun 21, 2012 at 04:08:21PM +0300, Alon Levy wrote: Already pushed, please ignore. --- server/spice.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/spice.h b/server/spice.h index a6b3c3d..abaffbd 100644 --- a/server/spice.h +++ b/server/spice.h

Re: [Spice-devel] [spice-common PATCH 2/3] spice-protocol/spice/enums.h: rebuild from spice.proto

2012-06-20 Thread Alon Levy
On Wed, Jun 20, 2012 at 01:18:10PM +0200, Christophe Fergeau wrote: On Thu, Jun 14, 2012 at 02:03:25PM +0300, Alon Levy wrote: This file was hand generated until now, resulting in the wierd situation where it is different for spice-gtk and spice-server even though they both use the same

Re: [Spice-devel] [spice-common PATCH 2/3] spice-protocol/spice/enums.h: rebuild from spice.proto

2012-06-20 Thread Alon Levy
On Wed, Jun 20, 2012 at 01:18:10PM +0200, Christophe Fergeau wrote: On Thu, Jun 14, 2012 at 02:03:25PM +0300, Alon Levy wrote: This file was hand generated until now, resulting in the wierd situation where it is different for spice-gtk and spice-server even though they both use the same

Re: [Spice-devel] Student Project around Spice

2012-06-20 Thread Alon Levy
On Wed, Jun 20, 2012 at 01:07:01PM +0300, Yaniv Kaul wrote: Hi, I'm trying to get students to develop something for Spice as a project for their university. It should take 60-120 hours, though, and while they have basic C/C++ knowledge, I would not assume anything more. Any ideas? For

Re: [Spice-devel] Further thoughts on the write polling in the xf86_spice_xql driver

2012-06-20 Thread Alon Levy
On Wed, Jun 20, 2012 at 08:59:20AM -0500, Jeremy White wrote: I've started a conversation on the xorg-devel mailing list[1], and I'll follow up directly in irc with Adam and/or Keith if I don't get any answers. Keith very kindly put together a patch to add write block handlers for us:

Re: [Spice-devel] [spice-common PATCH 2/3] spice-protocol/spice/enums.h: rebuild from spice.proto

2012-06-20 Thread Alon Levy
On Wed, Jun 20, 2012 at 02:08:53PM +0200, Christophe Fergeau wrote: On Wed, Jun 20, 2012 at 02:56:58PM +0300, Alon Levy wrote: On Wed, Jun 20, 2012 at 01:18:10PM +0200, Christophe Fergeau wrote: Is make distcheck ok with generating a file in $(top_srcdir)? Is the enums.h file correctly

Re: [Spice-devel] Add support for A8 bitmap format

2012-06-18 Thread Alon Levy
On Mon, Jun 18, 2012 at 09:18:47AM +0200, Gerd Hoffmann wrote: Hi, Heavy handed alternative: - Filter the messages in the server and translate any A8 message to ?? For client compatibility this would be great, not sure how much effort this is though. On furthur thought about the

Re: Sound not working on vm clients

2012-06-17 Thread Alon Levy
On Sat, Jun 16, 2012 at 06:40:13PM -0700, David Highley wrote: We have two vm clients and neither have sound. hosting platform is Fedora 16 x86_64 first client is Fedora 17 i686 second client is Ubuntu 12.04 i686 libvirt-0.9.6-5.fc16.x86_64 qemu-kvm-0.15.1-5.fc16.x86_64 Tried both VNC

Re: [Spice-devel] Add support for A8 bitmap format

2012-06-17 Thread Alon Levy
On Sat, Jun 16, 2012 at 01:57:49AM -0400, Yaniv Kaul wrote: - Original Message - Hello, The following patches add support for a new A8 bitmap format, and for LZ compression of it. This format is heavliy used by the X server Render extension for glyphs and geometry information.

Re: [Spice-devel] [Common patch 2/2] Add support for A8 images to the LZ routines

2012-06-17 Thread Alon Levy
On Fri, Jun 15, 2012 at 02:59:24PM -0400, Søren Sandmann wrote: From: Søren Sandmann Pedersen s...@redhat.com Looks good, one comment below. This format is needed to add Render support to the X driver, so we need the ability to compress and decompress it. --- common/canvas_base.c

Re: [Spice-devel] [PATCH] Compute totalPixmapSize using the same logic as in dix/pixmap.c, rather than hard coding 100.

2012-06-17 Thread Alon Levy
On Wed, Jun 13, 2012 at 05:04:12PM -0500, Jeremy White wrote: This was found while building with a modified X server; one with a PixmapRec size of 224, not 64 :-/. pushed, thanks. --- src/qxl_driver.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [Spice-devel] [PATCH] Actually process write watches in the wakeup handler

2012-06-17 Thread Alon Levy
On Sun, Jun 03, 2012 at 10:28:05AM -0500, Jeremy White wrote: My apologies for the churn; this is, I think, a slightly better patch than my previous patch, 'Process watches even when there is no X activity', in that it avoids doing an extra polling select when we're idle. Pushed this version,

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-15 Thread Alon Levy
On Fri, Jun 15, 2012 at 11:17:34AM +0200, Gerd Hoffmann wrote: Hi, From 44.1 you'd still need to externally resample to one of 8, 12, 16, 24, or 48k - but you can put any of those rates in, and take any of those out again without them needing to be the same. So only endpoints actually

[Spice-devel] [spice-common PATCH] python_modules/ptypes.py/EnumBaseType.c_enumname: add missing return to fix broken enums generation

2012-06-14 Thread Alon Levy
--- python_modules/ptypes.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 132ba99..d9fbfe2 100644 --- a/python_modules/ptypes.py +++ b/python_modules/ptypes.py @@ -234,7 +234,7 @@ class EnumBaseType(Type):

Re: [Spice-devel] Join spice-devel@lists.freedesktop.org

2012-06-14 Thread Alon Levy
On Tue, Jun 12, 2012 at 06:02:45PM +0800, Xiang Hua wrote: to get information about all things related to the Spice project. thanks. Hua in Beijing You need to send a request through mailman, here: http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [spice-common PATCH] python_modules/ptypes.py/EnumBaseType.c_enumname: add missing return to fix broken enums generation

2012-06-14 Thread Alon Levy
On Thu, Jun 14, 2012 at 05:11:02AM -0400, Marc-André Lureau wrote: I don't see exactly what it will fixed, perhaps you should include a small example. But that looks like a typo and can't harm, ACK ./spice_codegen.py --generate-enums spice.proto spice-protocol/spice/enums.h Produces a file

Re: [Spice-devel] [PATCH] Compute totalPixmapSize using the same logic as in dix/pixmap.c, rather than hard coding 100.

2012-06-14 Thread Alon Levy
On Wed, Jun 13, 2012 at 05:04:12PM -0500, Jeremy White wrote: Looks good to me. This was found while building with a modified X server; one with a PixmapRec size of 224, not 64 :-/. --- src/qxl_driver.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[Spice-devel] [spice-common PATCH 0/3] smartcard autogenerated sources fixes

2012-06-14 Thread Alon Levy
to SPICE_MSG_SMARTCARD_MSG (even though the later is more correct). There is still an asymmetry - spice-gtk uses spice proto to parse and marshal smartcard messages, and spice-server uses libcacard. spice-common: Alon Levy (3): smartcard: build fixes for spice server spice-protocol/spice/enums.h: rebuild

[Spice-devel] [spice-common PATCH 1/3] smartcard: build fixes for spice server

2012-06-14 Thread Alon Levy
Define different enums that have a SPICE_ prefix to not conflict with same value enums from libcacard/vsccard_common.h, and continue to use the same SPICE_MSG_SMARTCARD_DATA and SPICE_MSGC_SMARTCARD_DATA enum that is used by the server and clients (spice-gtk, spicec) alike. ---

[Spice-devel] [spice-common PATCH 2/3] spice-protocol/spice/enums.h: rebuild from spice.proto

2012-06-14 Thread Alon Levy
This file was hand generated until now, resulting in the wierd situation where it is different for spice-gtk and spice-server even though they both use the same spice-common and spice-protocol (or at least close) versions. This patch generates the enums.h files from spice-common. While that file

[Spice-devel] [spice-common PATCH 3/3] updated spice-protocol for smartcard enums non conflict with libcacard

2012-06-14 Thread Alon Levy
--- spice-protocol |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-protocol b/spice-protocol index bf0daeb..6bae9fd 16 --- a/spice-protocol +++ b/spice-protocol @@ -1 +1 @@ -Subproject commit bf0daeb3a3c834133e781439f76b1c702470581b +Subproject commit

[Spice-devel] [PATCH spice-common] Makefile.am: fix .gitignore not being generated in spice-protocol/spice

2012-06-14 Thread Alon Levy
By adding spice-protocol to SUBDIRS configure and make will be called in it. Spotted by Marc-André. --- Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 28450b4..3b3c88d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,7 +1,7 @@

[Spice-devel] [spice-common PATCH] Makefile.am: now that spice_codegen.py is used add *.pyc to ignored files in root

2012-06-14 Thread Alon Levy
--- Makefile.am |2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.am b/Makefile.am index 3b3c88d..79f7903 100644 --- a/Makefile.am +++ b/Makefile.am @@ -10,6 +10,8 @@ EXTRA_DIST = \ spice1.proto\ $(NULL)

Re: [Spice-devel] [PATCH spice-common] Makefile.am: fix .gitignore not being generated in spice-protocol/spice

2012-06-14 Thread Alon Levy
On Thu, Jun 14, 2012 at 08:28:24AM -0400, Marc-André Lureau wrote: - Mensaje original - By adding spice-protocol to SUBDIRS configure and make will be called in it. Spotted by Marc-André. --- Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH 08/10] qxl: add vgamem_size_mb and vgamem_size

2012-06-14 Thread Alon Levy
On Tue, Jun 12, 2012 at 09:51:12AM +0200, Gerd Hoffmann wrote: From: Alon Levy al...@redhat.com Please don't push this, it breaks both drivers, leaving n_modes 0 in the rom. I'll send a fixed version. In preperation for supporting a larger framebuffer for multiple monitors on a single card

[Qemu-devel] [PATCH] qxl: fix broken n_modes

2012-06-14 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- Hi Gerd, Unfortunately I didn't test my previous patch qxl: add vgamem_size_mb and vgamem_size with the current drivers. This patch is not merged since I didn't know if it will reach before/after anothony pull. If before, then please merge

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Alon Levy
On Wed, Jun 13, 2012 at 09:25:59AM +0200, Gerd Hoffmann wrote: Hi, More official than the codec working group declaring it to be in its finally frozen form, or the codec specification being submitted to and approved by the IESG for publication? You keep refering to standards, while

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-13 Thread Alon Levy
On Wed, Jun 13, 2012 at 09:51:24AM +0400, Michael Tokarev wrote: On 13.06.2012 04:57, Brian Vetter wrote: As an outside observer with nothing really at stake here, it would seem that rather than Debian providing a hobbled version of the spice client that uses raw audio (disables Celt),

Re: [Spice-devel] [spice-gtk] Fix various memory leaks

2012-06-13 Thread Alon Levy
On Wed, Jun 13, 2012 at 12:15:39PM +0200, Christophe Fergeau wrote: ==25063== 12,827 (2,032 direct, 10,795 indirect) bytes in 127 blocks are definitely lost in loss record 9,477 of 9,502 ==25063==at 0x4A0884D: malloc (vg_replace_malloc.c:263) ==25063==by 0x3DE384D2BE: g_malloc

Re: [Qemu-devel] [PATCH 08/10] qxl: add vgamem_size_mb and vgamem_size

2012-06-13 Thread Alon Levy
On Tue, Jun 12, 2012 at 01:55:23PM +0200, Gerd Hoffmann wrote: On 06/12/12 11:37, Daniel P. Berrange wrote: On Tue, Jun 12, 2012 at 09:51:12AM +0200, Gerd Hoffmann wrote: From: Alon Levy al...@redhat.com In preperation for supporting a larger framebuffer for multiple monitors

Re: [Spice-devel] Any progress on agent support for Xspice?

2012-06-12 Thread Alon Levy
On Mon, Jun 11, 2012 at 03:04:05PM +0200, Eike Hein wrote: A few months ago we had a brief discussion about plans to add agent support to Xspice, primarily to get clipboard synchronization going. Has there been any progress since? I'm afraid not. -- Best regards, Eike Hein

Re: [Spice-devel] Development process?

2012-06-12 Thread Alon Levy
On Mon, Jun 11, 2012 at 07:58:24PM +0200, Hans de Goede wrote: Hi, On 06/11/2012 04:45 PM, Jeremy White wrote: Forgive me if this is FAQ'd elsewhere, but I did not find it in a short hunt, and I'm curious. Documentation is not our strong point, help with that is greatly appreciated :)

[Spice-devel] [PATCH 1/2] configure.ac: highlight current, revision and age

2012-06-12 Thread Alon Levy
Move to the top so anyone changing the library version will have a higher likelihood of noticing them and thinking if they need changes as well. Added the rules, copied from libtool's info page, as a reminder. --- configure.ac | 35 ++- 1 file changed, 34

[Spice-devel] [PATCH 2/2] Release 0.11.0

2012-06-12 Thread Alon Levy
Current bumped and age bumped. Current bumped twice since previous values (current = 1, age = 2) were illegal - age must be smaller or equal to current, since it's interpreted as meaning our library supports t interfaces [current, current - age]. New libtool version is thus 3.0.3, since there are

[Spice-devel] [PATCH v2 1/2] configure.ac: highlight current, revision and age

2012-06-12 Thread Alon Levy
Move to the top so anyone changing the library version will have a higher likelihood of noticing them and thinking if they need changes as well. Added the rules, copied from libtool's info page, as a reminder. Added some obvious docs for the already defined SPICE_MICRO, SPICE_MINOR and

[Spice-devel] [PATCH v2 2/2] Release 0.11.0

2012-06-12 Thread Alon Levy
Current bumped and age bumped. Current bumped twice since previous values (current = 1, age = 2) were illegal - age must be smaller or equal to current, since it's interpreted as meaning our library supports t interfaces [current, current - age]. New libtool version is thus 3.0.3, since there are

[Spice-devel] [PATCH v3 1/2] configure.ac: highlight current, revision and age

2012-06-12 Thread Alon Levy
Move to the top so anyone changing the library version will have a higher likelihood of noticing them and thinking if they need changes as well. Added the rules, copied from libtool's info page, as a reminder. Added some obvious docs for the already defined SPICE_MICRO, SPICE_MINOR and

Re: [Spice-devel] [PATCH 2/2] Release 0.11.0

2012-06-12 Thread Alon Levy
On Tue, 2012-06-12 at 12:32 +0100, Daniel P. Berrange wrote: On Tue, Jun 12, 2012 at 02:23:33PM +0300, Alon Levy wrote: Current bumped and age bumped. Current bumped twice since previous values (current = 1, age = 2) were illegal - age must be smaller or equal to current, since it's

Re: [Spice-devel] [PATCH v2 2/2] Release 0.11.0

2012-06-12 Thread Alon Levy
On Tue, 2012-06-12 at 13:01 +0100, Daniel P. Berrange wrote: On Tue, Jun 12, 2012 at 02:53:02PM +0300, Alon Levy wrote: Current bumped and age bumped. Current bumped twice since previous values (current = 1, age = 2) were illegal - age must be smaller or equal to current, since it's

Re: [Spice-devel] [PATCH v3 2/2] Release 0.11.0

2012-06-12 Thread Alon Levy
at 1:58 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: argh, spice/server/Makefile.am uses -version-number instead of -version-info.. On Tue, Jun 12, 2012 at 1:54 PM, Alon Levy al...@redhat.com wrote: Current bumped and age bumped. Current bumped twice since previous values

Re: [Spice-devel] [PATCH v2 2/2] Release 0.11.0

2012-06-12 Thread Alon Levy
- Original Message - On Tue, Jun 12, 2012 at 02:53:02PM +0300, Alon Levy wrote: Current bumped and age bumped. Current bumped twice since previous values (current = 1, age = 2) were illegal - age must be smaller or equal to current, since it's interpreted as meaning our library

Re: [Spice-devel] [PATCH v2 2/2] Release 0.11.0

2012-06-12 Thread Alon Levy
- Original Message - - Original Message - On Tue, Jun 12, 2012 at 02:53:02PM +0300, Alon Levy wrote: Current bumped and age bumped. Current bumped twice since previous values (current = 1, age = 2) were illegal - age must be smaller or equal to current

[Spice-devel] [PATCH v4 1/3] configure.ac: highlight current, revision and age

2012-06-12 Thread Alon Levy
Move to the top so anyone changing the library version will have a higher likelihood of noticing them and thinking if they need changes as well. Added the rules, copied from libtool's info page, as a reminder. Added some obvious docs for the already defined SPICE_MICRO, SPICE_MINOR and

[Spice-devel] [PATCH v4 2/3] server/Makefile.am: correct usage of libtool -version-info

2012-06-12 Thread Alon Levy
The new library so is named: libspice-server.so.1.2.0 The old was: libspice-server.so.1.0.2 --- configure.ac |2 +- server/Makefile.am |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index efb0128..5a5ee50 100644 ---

[Spice-devel] [PATCH v4 3/3] Release 0.11.0

2012-06-12 Thread Alon Levy
Current bumped and age bumped for new intefaces only (no backward incompatible changes). New libtool version is 4.0.3. Added interfaces: spice_server_set_name; spice_server_set_uuid; spice_server_set_listen_socket_fd; spice_server_is_server_mouse; New library name in linux:

Re: [Spice-devel] [PATCH v4 2/3] server/Makefile.am: correct usage of libtool -version-info

2012-06-12 Thread Alon Levy
- Original Message - I am confusing with old the patches bumping library version.. Can you just make one instead? hmm, why? isn't it cleaner this way? granted, it's a bit pointless since we are never going to release this. - Mensaje original - The new library so is named:

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Alon Levy
On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: Hi - Mensaje original - The ideal solution would be to have support for Opus, I think Marc André and Alon had started to look into that, but that's not done yet :( No, I didn't. Long time ago I proposed we have

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Alon Levy
On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: Hi - Mensaje original - The ideal solution would be to have support for Opus, I think Marc André and Alon had started to look into that, but that's not done yet :( No, I didn't. Long time ago I proposed we have

[Spice-devel] spice-server 0.11.0 development release

2012-06-12 Thread Alon Levy
Hi All, I'm happy to announce spice-0.11.0, a development release: Major changes in 0.11.0: * !Development Release! * 8817549..d905a1f * now using git submodules: spice-common and spice-protocol. * New spice protocol messages: (changes in spice-protocol, here for

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Alon Levy
On Wed, Jun 13, 2012 at 01:22:43AM +0930, Ron wrote: Hi Alon, On Tue, Jun 12, 2012 at 06:03:58PM +0300, Alon Levy wrote: On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote: Hi - Mensaje original - The ideal solution would be to have support for Opus, I

[Qemu-devel] [PATCH v5] Release 0.11.0

2012-06-12 Thread Alon Levy
Current bumped and age bumped for new intefaces only (no backward incompatible changes). New libtool version is 2.0.1, using --version-info instead of --version-name. Doing the version change and --version-name to --version-info change here to avoid changing the libtool version twice. Added

Re: [Spice-devel] rfc seamless migration

2012-06-11 Thread Alon Levy
On Mon, Jun 11, 2012 at 09:25:46AM +0200, Gerd Hoffmann wrote: Hi, I'm still not a big fan of the concept of server data going through the client, this means the server will need to seriously sanity check what it receives to avoid potentially new attacks on it. I'm wondering why

[Qemu-devel] [PATCH 0/3] qxl fb size and async fix

2012-06-11 Thread Alon Levy
larger framebuffers, second bugs out on too large primary create request, and third resets the current_async to allow recovery from bad state via reset. I'm dropping the qxl info patch for now, lack of time. Alon Alon Levy (3): qxl: add fb_size_mb and fb_size qxl: refuse to create primary

[Qemu-devel] [PATCH 2/3] qxl: refuse to create primary larger then fb size

2012-06-11 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index a9b4fd1..6596856 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1204,6 +1204,16 @@ static void qxl_create_guest_primary(PCIQXLDevice *qxl, int loadvm

[Qemu-devel] [PATCH 3/3] qxl: reset current_async on qxl_soft_reset

2012-06-11 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/qxl.c b/hw/qxl.c index 6596856..b18a59d 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -988,6 +988,7 @@ static void qxl_soft_reset(PCIQXLDevice *d) trace_qxl_soft_reset(d-id

[Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Alon Levy
In preperation for supporting a larger framebuffer for multiple monitors on a single card, add a property to qxl fb_size_mb, and corresponding byte sized fb_size, and use instead of VGA_RAM_SIZE. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 31 --- hw

Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Alon Levy
On Mon, Jun 11, 2012 at 09:42:28AM +0200, Gerd Hoffmann wrote: Hi, +if (d-fb_size fb) { +d-fb_size = fb; +} +if (fb = d-fb_size) { This check doesn't make sense, it will always be true. My mistake. Will remove the first three lines, so fb_size

Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Alon Levy
On Mon, Jun 11, 2012 at 10:29:59AM +0200, Gerd Hoffmann wrote: Hi, Reminds me that I have some pending work to make vga ram size configurable which I should finish and repost ... Current state pushed to http://www.kraxel.org/cgit/qemu/log/?h=vga.1 It probably makes sense to base

<    5   6   7   8   9   10   11   12   13   14   >