is
> + * command so reset it. */
> +red_drawable->self_bitmap = false;
Looks to me, ideally we could warn once when this is unexpectedly set,
but we are missing helpers for that at the moment.
Looks good otherwise,
Acked-by: Christophe Fergeau
Christophe
> +
> +
Hey,
On Tue, Jun 26, 2018 at 10:31:00AM +0100, Frediano Ziglio wrote:
> The type of the image is just copied from network without
> any check and later used for array indexing.
Have you considered something like this? This way we can be sure no code
can overflow the IS_IMAGE_TYPE_PLT[] array.
Acked-by: Christophe Fergeau
(when reverting this commit, compilation of the test case fails, with
this commit in, the test case succeeds)
Christophe
On Thu, Jun 28, 2018 at 07:40:20AM +0100, Frediano Ziglio wrote:
> Check the previous fix for "zero" attribute works correc
Acked-by: Christophe Fergeau
On Tue, Jul 03, 2018 at 11:24:03AM +0100, Frediano Ziglio wrote:
> Pointers to memory allocated in user space are never NULL.
> The only exception can be if you explicitly map memory at zero.
> There is however no reasons for such requirement and this
Most users of spice_common.h don't need it, or only need log.h. It only
has a few users outside of spice-common. It's not very well defined
which headers it should contain. This commit removes spice_common.h in
favour of direct inclusion of the needed headers.
Signed-off-by: Christophe Fergeau
spice-gtk was the last user, and stopped using it on Jun 14th 2017
in 040090ccba34 "build-sys: remove -DSPICE_DISABLE_ABORT"
Signed-off-by: Christophe Fergeau
---
common/log.c | 4
common/spice_common.h | 4
tests/test-logging.c | 14 ++
3 files
There are only 2 users in spice-common, and none in spice-gtk/spice
Signed-off-by: Christophe Fergeau
---
common/pixman_utils.c | 4 ++--
common/spice_common.h | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/common/pixman_utils.c b/common/pixman_utils.c
index 81806c9
Signed-off-by: Christophe Fergeau
---
server/dispatcher.c | 1 -
server/red-common.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index 0953db875..48dc915a6 100644
--- a/server/dispatcher.c
+++ b/server/dispatcher.c
@@ -26,7 +26,6 @@
#include
On Fri, Jun 29, 2018 at 05:21:22PM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin
>
> In some error cases, canvas_get_image may return NULL.
> When this happens, calls like pixman_image_get_width(s)
> will crash. Add additional error paths to deal with
> these cases.
I
spice-gtk was the last user, and stopped using it in 90ccba34
"build-sys: remove -DSPICE_DISABLE_ABORT"
Signed-off-by: Christophe Fergeau
---
common/log.c | 4
common/spice_common.h | 4
tests/test-logging.c | 14 ++
3 files changed, 2 inserti
Acked-by: Christophe Fergeau
On Wed, Jun 27, 2018 at 08:00:36AM +0100, Frediano Ziglio wrote:
> Check if encoder contains an invalid character.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/test-codecs-parsing.c | 6 ++
> 1 file changed, 6 insertions(+)
>
Acked-by: Christophe Fergeau
On Wed, Jun 27, 2018 at 08:00:37AM +0100, Frediano Ziglio wrote:
> In case we pass something like "spice:mjpeg$%*" the last part is
> ignore making the string parse correctly.
> A single pair should end by either string terminator or pair terminat
On Mon, Jul 02, 2018 at 01:20:39PM -0500, Carlos González wrote:
> https://lists.freedesktop.org/archives/spice-devel/2018-June/044237.html
> I just read spice-server thing is actually a hypervisor part. So if this
> patch makes it to release, what would I need to update in order to test?
> All
Acked-by: Christophe Fergeau
On Sat, Jun 30, 2018 at 05:34:00PM +0400, Roman Bogorodskiy wrote:
> Signed-off-by: Roman Bogorodskiy
> ---
> data/os/freebsd.org/freebsd-11.2.xml.in | 50 +
> 1 file changed, 50 insertions(+)
> create mode 100644 data
Acked-by: Christophe Fergeau
On Sat, Jun 30, 2018 at 05:34:36PM +0400, Roman Bogorodskiy wrote:
> Signed-off-by: Roman Bogorodskiy
> ---
> .../FreeBSD-11.2-RELEASE-amd64-disc1.iso.txt | 33 +++
> .../FreeBSD-11.2-RELEASE-amd64-dvd1.is
On Fri, Jun 29, 2018 at 06:25:23PM -0500, Carlos González wrote:
> 2018-06-29 10:34 GMT-05:00 Christophe Fergeau :
>
> > The way things flow are individual driver releases/builds (eg the
> > qxl-wddm-dod build you found on spice-space.org), then they are gathered
> > in t
e replaced with g_warning() so
> > > that users of spice-server can redirect them with
> > > g_log_set_default_handler().
> >
> > Maybe squash this in?
> >
> > Either way, Acked-by: Christophe Fergeau
> >
>
> I can do a follow up but IMO they don't see
Once the spice-gtk patch is in,
Acked-by: Christophe Fergeau
On Thu, Jun 28, 2018 at 04:42:25PM +0100, Frediano Ziglio wrote:
> All usages of this macro were removed.
> A library should not log to standard error but use log facilities
> so remove this macro to avoid possible fut
er().
Maybe squash this in?
Either way, Acked-by: Christophe Fergeau
diff --git a/src/channel-display.c b/src/channel-display.c
index 44ba0439..1c28aed1 100644
--- a/src/channel-display.c
+++ b/src/channel-display.c
@@ -1211,7 +1211,7 @@ static void report_invalid_stream(SpiceChannel *channel,
On Thu, Jun 28, 2018 at 01:42:40PM -0500, Carlos González wrote:
> First thanks all for helping in my previous thread.
> Since last answers were posted under a different thread title, I realized I
> did make a mistake in trying to mix different topics in a single thread.
> Sorry.
>
> Back to
On Wed, Jun 27, 2018 at 10:37:29AM -0500, Jonathon Jongsma wrote:
> Quick review from a native english speaker, as Frediano suggested.
Thanks a lot! I've adjusted the patch following your comments!
Christophe
signature.asc
Description: PGP signature
.
This commit wraps both the compat code and the g_strv_contains() call in
a strv_contains() helper where we can hide the magic needed to avoid
deprecation warnings.
Signed-off-by: Christophe Fergeau
---
src/ovirt-foreign-menu.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff
On Thu, Jun 28, 2018 at 05:09:48PM -0300, Eduardo Lima (Etrunko) wrote:
> On 14/06/18 13:01, Christophe Fergeau wrote:
> > spice_main_set_display and spice_main_set_display_enabled have been
> > superseded by spice_main_channel_update_display and
> > spice_main_channel_u
On Thu, Jun 28, 2018 at 04:45:01PM -0300, Eduardo Lima (Etrunko) wrote:
> On 14/06/18 13:01, Christophe Fergeau wrote:
> > The ovirt code uses g_strv_contains() with fallback code in
> > glib-compat.h when we are using a glib version where it's not available.
> > Howeve
Now warnings are printed through g_warning which causes the test to
fail. We need to use g_test_expect_message() to prevent that failure.
Signed-off-by: Christophe Fergeau
---
server/tests/test-agent-msg-filter.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/server/tests/test
For the 2 patches,
Acked-by: Christophe Fergeau
On Thu, Jun 28, 2018 at 08:14:01AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> tests/Makefile.am | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/Makefile.am b
The remaining occurrences of spice_printerr() are warnings when
something unexpected happens, they can be replaced with g_warning() so
that users of spice-server can redirect them with
g_log_set_default_handler().
---
server/agent-msg-filter.c | 8
server/char-device.c| 8
These calls seem to have been added for debugging for a very specific
purpose. At the very least, they should have been using g_debug() rather
than spice_printerr(). This commit removes these.
---
server/char-device.c | 1 -
server/inputs-channel.c | 2 --
Depending on the context, we want to output a warning or just a debug
log.
---
server/dcc.c | 6 +++--
server/inputs-channel-client.c| 3 ++-
server/inputs-channel.c | 6 ++---
server/main-channel-client.c | 42 ++-
It was only used twice, for what looks like adhoc debugging. This commit
removes it, similarly to what was done for some spice_printerr() calls.
---
server/red-channel.h | 3 ---
server/red-qxl.c | 4
2 files changed, 7 deletions(-)
diff --git a/server/red-channel.h
This allows users of the library to redirect where these messages go
through use of g_log_set_default_handler() rather than unconditionally
printing on stderr.
Signed-off-by: Christophe Fergeau
---
Let's first address spice-common use of spice_printerr, more patches
will be coming for spice
Yup, integrated something similar already, forgot to resend.
Christophe
On Wed, Jun 27, 2018 at 03:46:38PM +0100, Frediano Ziglio wrote:
> Style:
> - split long lines;
> - remove space between function and parameters.
> ---
> server/sound.c | 10 ++
> 1 file changed, 6 insertions(+), 4
and
RecordChannelClient implement GInitable, and move the code interacting
with the client in their _initable_init() function, as at this point the
objects will be able to send data.
https://bugzilla.redhat.com/show_bug.cgi?id=1549132
Signed-off-by: Christophe Fergeau
---
server/sound.c | 62
This prints to stdout, which is not desirable in an automated test.
Signed-off-by: Christophe Fergeau
---
tests/test-region.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/tests/test-region.c b/tests/test-region.c
index a5a5351..b7f5a22
Signed-off-by: Christophe Fergeau
---
tests/test-region.c | 106 ++--
1 file changed, 53 insertions(+), 53 deletions(-)
diff --git a/tests/test-region.c b/tests/test-region.c
index 5a00cce..a5a5351 100644
--- a/tests/test-region.c
+++ b/tests/test
On Wed, Jun 27, 2018 at 06:15:55AM -0400, Frediano Ziglio wrote:
> >
> > On Mon, Jun 18, 2018 at 12:04:18PM -0400, Frediano Ziglio wrote:
> > > Not much replies to this specific patch, but I agree was better to
> > > integrate dependencies (spice-protocol and spice-common) projects
> > > first.
>
On Wed, Jun 27, 2018 at 06:04:16AM -0400, Frediano Ziglio wrote:
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> > common/region.c | 28 ++--
> > tests/test-region.c | 106 ++--
> > 2 files cha
At the moment, test success/failure is only printed to stdout. This
commit adds some g_assert() so that test failures can be automatically
detected.
---
tests/test-region.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/tests/test-region.c
Signed-off-by: Christophe Fergeau
---
tests/test-region.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tests/test-region.c b/tests/test-region.c
index 38b3203..5a00cce 100644
--- a/tests/test-region.c
+++ b/tests/test-region.c
@@ -127,7 +127,7 @@ enum
From: Frediano Ziglio
region.c contained code to test the module.
Separate test code into a proper test.
Test is copied verbatim from the original code.
Signed-off-by: Frediano Ziglio
---
common/region.c | 378 -
tests/Makefile.am | 12 ++
Signed-off-by: Christophe Fergeau
---
tests/test-region.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-region.c b/tests/test-region.c
index 12fdfce..ec451c4 100644
--- a/tests/test-region.c
+++ b/tests/test-region.c
@@ -73,7 +73,7 @@ static void rect_set
__FUNCTION__ will always be rect_is_valid, and there is a g_assert to
check the region is valid, so we will get notified anyway if the
validity check fails.
Signed-off-by: Christophe Fergeau
---
tests/test-region.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/test-region.c b/tests
Signed-off-by: Christophe Fergeau
---
common/region.c | 28 ++--
tests/test-region.c | 106 ++--
2 files changed, 67 insertions(+), 67 deletions(-)
diff --git a/common/region.c b/common/region.c
index c950a9b..d690167 100644
--- a/common
On Tue, Jun 26, 2018 at 01:42:20PM -0400, Frediano Ziglio wrote:
> Why use GTest API ?
Mostly for consistency.
> I honestly just created a test and I prefer to have at least a first commit
> with a verbatim copy of the old test, in case we found some bugs later.
> For me is more important to
VM, run some testing, ... which I don't
really have time for right now, hence the lack of precise answer on my
side ;)
Christophe
>
> 2018-06-26 10:20 GMT-05:00 Christophe Fergeau :
>
> > On Tue, Jun 26, 2018 at 09:45:33AM -0500, Carlos González wrote:
> > > 2018-06-
On Wed, Jun 27, 2018 at 03:13:00AM -0400, Frediano Ziglio wrote:
> > ClientCbs is definitely not something which needs to be registered
> > per-channel instance, it's more of a class thing, and the dispatcher is
> > more something which could be thread local. I would not stick everything
> >
On Tue, Jun 26, 2018 at 09:45:33AM -0500, Carlos González wrote:
> 2018-06-26 4:54 GMT-05:00 Christophe Fergeau :
>
> >
> > Not fully clear whether you installed the qxl-wddm-dod driver as
> > suggested earlier or not. Are you using it in the guest?
> >
> > Ch
On Tue, Jun 19, 2018 at 11:05:26AM +0100, Frediano Ziglio wrote:
> Pointers to memory allocated in user space are never NULL.
> The only exception can be if you explicitly map memory at zero.
> There is however no reasons for such requirement and this practise
> was also removed from Linux due to
ers.
Acked-by: Christophe Fergeau
but why isn't this removing all the other (Foo*)memslots_get_virt()
casts from red-parse-qxl.c? I can send a followup patch.
Christophe
>
> Signed-off-by: Frediano Ziglio
> ---
> server/memslot.c | 14 +++---
> server/memslot.h
Acked-by: Christophe Fergeau
On Tue, Jun 19, 2018 at 11:05:25AM +0100, Frediano Ziglio wrote:
> Never used.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/jpeg-encoder.c | 16 ++--
> server/jpeg-encoder.h | 1 -
> 2 files changed, 2 insertions(+), 15 d
On Tue, Jun 19, 2018 at 11:05:23AM +0100, Frediano Ziglio wrote:
> Define JpegEncoderContext as an abstract structure.
> This allows to reduce casts.
> Also remove some alignment warnings on some architecture like mips.
Hmm indeed, the indirection is a bit odd..
Acked-by: Christoph
own implementation for backward compatibility.
Acked-by: Christophe Fergeau with the log fixed.
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/sp
_VERSION_NUMBER <
> 0x2070)
An alternative to this version checking would be to directly check for
the function we need in configure.ac. This should be good enough for
now, I'll look into that when we need to update that test again.
Acked-by: Christophe Fergeau
Christophe
> static BIO_ME
On Mon, Jun 18, 2018 at 12:04:18PM -0400, Frediano Ziglio wrote:
> Not much replies to this specific patch, but I agree was better to
> integrate dependencies (spice-protocol and spice-common) projects
> first.
>
> > diff --git a/subprojects/spice-common.wrap b/subprojects/spice-common.wrap
> >
On Thu, Jun 21, 2018 at 10:32:53PM +0100, Frediano Ziglio wrote:
> region.c contained code to test the module.
> Separate test code into a proper test.
> Test is copied verbatim from the original code.
>
> Signed-off-by: Frediano Ziglio
> ---
> common/region.c | 378
Acked-by: Christophe Fergeau
On Thu, Jun 21, 2018 at 10:32:52PM +0100, Frediano Ziglio wrote:
> This test can take quite some amount of time to run.
>
> Signed-off-by: Frediano Ziglio
> ---
> tests/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Hey,
This loops back on that old/unresolved discussion
https://lists.freedesktop.org/archives/spice-devel/2017-August/039541.html
I'd rather not make changes like this for now as we don't know where we
want to go with these ClientCbs ;)
The only reason why we have these ClientCbs is to be able
Acked-by: Christophe Fergeau
On Tue, Jun 26, 2018 at 11:02:56AM +0100, Frediano Ziglio wrote:
> The DUMP_JPEG compile time flag is used to dump all jpeg images
> to files.
> The code was saving garbage instead of proper data.
>
> Signed-off-by: Frediano Ziglio
> Reported-
Acked-by: Christophe Fergeau
On Mon, Jun 25, 2018 at 11:46:22AM +0100, Frediano Ziglio wrote:
> On some systems you need to call g_spawn_close_pid after
> spawning a process to avoid leaks (currently Windows).
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-record-qxl
Acked-by: Christophe Fergeau
On Mon, Jun 25, 2018 at 11:46:23AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/replay.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/tests/replay.c b/server/test
On Mon, Jun 25, 2018 at 01:56:14PM -0500, Carlos González wrote:
> Just a bump.
Not fully clear whether you installed the qxl-wddm-dod driver as
suggested earlier or not. Are you using it in the guest?
Christophe
>
> 2018-06-21 12:47 GMT-05:00 Carlos González :
>
> > Excuse me, some clue by
_t n = 0; n < data->num_chunks; ++n) {
> +fwrite(data->chunk[n].data, 1, data->chunk[n].len, f);
> +}
> fclose(f);
> }
> +#else
> +static inline void dump_jpeg(SpiceChunks* data, uint32_t data_size) {}
I'd jus trust the compiler to do the right thing here
Ok,
Acked-by: Christophe Fergeau
On Wed, Jun 20, 2018 at 02:31:40PM +0100, Frediano Ziglio wrote:
> In some environment pthread.h is not defined but its definitions
> are used in some headers.
> Actually happens using MingW.
>
> Signed-off-by: Frediano Ziglio
> ---
>
Acked-by: Christophe Fergeau
On Wed, Jun 20, 2018 at 02:31:41PM +0100, Frediano Ziglio wrote:
> Used only in this file.
> Not defined in MingW.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/display-channel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
f (argc >= 2) {
> GdkPixbuf *source_pixbuf;
>
> -source_pixbuf = gdk_pixbuf_new_from_file(argv[1], NULL);
> -test_pixbuf(source_pixbuf);
> -g_object_unref(source_pixbuf);
> +for (int i = 1; i < argc; ++i) {
Looks like you could
On Wed, Jun 20, 2018 at 09:02:05AM -0400, Frediano Ziglio wrote:
> >
> > Hi, I maintain the spice-gtk port in FreeBSD and noticed that in
> > spice-gtk-0.35, there was a fix for libressl but that fix needs to
> > only apply to older versions of libressl. Here is a patch that
> > implements this.
Acked-by: Christophe Fergeau
On Thu, Jun 21, 2018 at 11:52:52AM +0100, Frediano Ziglio wrote:
> For some reasons building with Meson "exit" is not declared.
>
> Signed-off-by: Frediano Ziglio
> ---
> tests/test-quic.c | 1 +
> 1 file changed, 1 insertion(+)
On Fri, Jun 22, 2018 at 11:28:50AM +0100, Frediano Ziglio wrote:
> These constant are meant to be used in format string for size_t
> types. Use them for portability.
Alternatively, this could be G_GSIZE_FORMAT
Christophe
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-record-qxl.c | 4
On Mon, Jun 25, 2018 at 06:15:30AM -0400, Frediano Ziglio wrote:
> > +Spice devel mailing list.
>
> > On Thu, Jun 21, 2018, 11:57 PM John Florian < jflor...@doubledog.org >
> > wrote:
>
> > > On 2018-06-21 08:20, Michal Skrivanek wrote:
> >
> > > > Any connectivity issue should no really be
On Mon, Jun 25, 2018 at 06:15:30AM -0400, Frediano Ziglio wrote:
> > +Spice devel mailing list.
>
> > On Thu, Jun 21, 2018, 11:57 PM John Florian < jflor...@doubledog.org >
> > wrote:
>
> > > On 2018-06-21 08:20, Michal Skrivanek wrote:
> >
> > > > Any connectivity issue should no really be
On Wed, Jun 20, 2018 at 12:15:49PM -0400, Frediano Ziglio wrote:
> Seems fine. Do you have a CI result?
https://gitlab.com/teuf/spice-common/commit/49d7e4d4d9425c39e15f4f7ded7ae9675ca0e197/pipelines?ref=master
signature.asc
Description: PGP signature
On Wed, Jun 20, 2018 at 12:15:49PM -0400, Frediano Ziglio wrote:
> >
> > These tests were checking that the expected messages were output, but
> > they were not checking that the messages we don't want are not output.
> > This commit adds this to make sure our log implementation does not
> >
Without an explicit call to SSL_CTX_set_ecdh_auto(reds->ctx, 1), OpenSSL
1.0 would not use ECDH ciphers (this is now automatic with OpenSSL
1.1.0). This commit adds this missing call. It's based on a suggestion
from David Jasa
Signed-off-by: Christophe Fergeau
https://bugzilla.redhat.
These tests were checking that the expected messages were output, but
they were not checking that the messages we don't want are not output.
This commit adds this to make sure our log implementation does not
output unwanted debug messages.
---
tests/test-logging.c | 17 +
1 file
On Wed, Jun 20, 2018 at 10:16:56AM -0400, Frediano Ziglio wrote:
> >
> > ---
> > common/log.h | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/common/log.h b/common/log.h
> > index e0fd34b..4058208 100644
> > --- a/common/log.h
> > +++ b/common/log.h
> > @@
Calling g_log_set_handler() is problematic as this means applications
using spice-server won't be able to use g_log_set_default_handler to
manage spice logging output themselves. Since this call is only needed
for backwards compatibility (so that calling g_log together with
SPICE_DEBUG_LEVEL set
---
common/log.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/common/log.h b/common/log.h
index e0fd34b..4058208 100644
--- a/common/log.h
+++ b/common/log.h
@@ -57,9 +57,7 @@ void spice_log(GLogLevelFlags log_level,
spice_log(G_LOG_LEVEL_WARNING, SPICE_STRLOC,
On Wed, Jun 20, 2018 at 12:38:00PM +0300, Yaniv Kaul wrote:
> On Wed, Jun 20, 2018 at 12:26 PM, Christophe Fergeau
> wrote:
> > > > -- Forwarded message --
> > > > From: Leo David
> > > > Date: Wed, Jun 13, 2018 at 8:24 PM
> > >
Ah right, noticed that, iirc it's a bit odd as direct cloning without
the .git works though.
Acked-by: Christophe Fergeau
On Wed, Jun 20, 2018 at 12:28:52PM +0300, Snir Sheriber wrote:
> Old git (e.g. on rhel 7.5) is failing to init/update spice-common
> submodule if .git is missin
Acked-by: Christophe Fergeau
On Wed, Jun 20, 2018 at 12:28:58PM +0300, Uri Lublin wrote:
> With the move to gitlab.freedesktop.org the spice-common submodule
> url changed, and now ends with .git
>
> Update .gitmodules to reflect that.
>
> Without this patch gi
On Wed, Jun 20, 2018 at 12:38:00PM +0300, Yaniv Kaul wrote:
> On Wed, Jun 20, 2018 at 12:26 PM, Christophe Fergeau
> wrote:
> > > > -- Forwarded message --
> > > > From: Leo David
> > > > Date: Wed, Jun 13, 2018 at 8:24 PM
> > >
On Tue, Jun 19, 2018 at 05:30:46PM +0200, Lukáš Hrázký wrote:
> I don't know. I've also just noticed today that the depth field
> actually seems to be unused, besides being set in the client.
The windows agent uses it
Hey,
On Wed, Jun 20, 2018 at 02:14:54AM +, 谢 昆明 wrote:
> Hey guys. I have dump some jpg file, but I can’t open it with eog.
I don't understand how this relates to spice? Is this some spice code
which is calling dump_jpeg?
Christophe
>
>
> static int jpeg_id = 0;
> static void
On Tue, Jun 19, 2018 at 06:36:26AM -0400, David Blechter wrote:
> re-directing to the correct upstream list. In the future all ovirt/spice
> related issue should be address in the spice-de...@freedesktop.org list.
>
>
> Thank you,
> David Blechter
> 978-392-3182 <(978)%20392-3182>
>
> On Tue,
what spice client are you using? I think there were such issues with
spice-html5 which were fixed a year ago with
https://gitlab.freedesktop.org/spice/spice-html5/commit/bfa85a7117fcf28ff19f2507f61db4620da2e828
This was done for configure.ac earlier, but is missing in meson.build
Signed-off-by: Christophe Fergeau
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 5ed4177..31531e2 100644
--- a/meson.build
+++ b/meson.build
@@ -2,7 +2,7
mon after recent changes there.
> >
> > Signed-off-by: Christophe Fergeau
> > ---
> > configure.ac | 10 --
> > 1 file changed, 10 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 1e569c30a..d71f0989f 100644
> > --- a/confi
in --help output.
Signed-off-by: Christophe Fergeau
---
configure.ac | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/configure.ac b/configure.ac
index 1e569c30a..27898d2e6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -181,15 +181,7 @@ AC_SUBST(PIXMAN_CFLAGS
spice-server does not have any code depending on libcelt, such code is
in spice-common. We can thus get rid of that check, especially as its
default got out of sync with spice-common after recent changes there.
Signed-off-by: Christophe Fergeau
---
configure.ac | 10 --
1 file changed
Ping?
Christophe
On Fri, Jun 08, 2018 at 04:25:28PM +0200, Christophe Fergeau wrote:
> Signed-off-by: Christophe Fergeau
> ---
> docs/manual/manual.txt | 51 ++
> 1 file changed, 51 insertions(+)
>
> diff --git a/docs/manual/manual
On Mon, Jun 18, 2018 at 10:24:11AM -0400, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > On Fri, Jun 08, 2018 at 04:25:29PM +0200, Christophe Fergeau wrote:
> > > Signed-off-by: Christophe Fergeau
> > > ---
> > > NEWS | 23 +
Acked-by: Christophe Fergeau
On Mon, Jun 18, 2018 at 08:35:52AM +0100, Frediano Ziglio wrote:
> This array is just used locally in red_channel_client_handle_outgoing
> so declare it there.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-channel-client.c | 9 -
Acked-by: Christophe Fergeau
On Mon, Jun 18, 2018 at 10:38:53AM +0100, Frediano Ziglio wrote:
> Although capabilities inside link message are handled as arrays
> of 4 bytes unsigned integers we don't need capabilities to be
> aligned to 4 bytes just to call g_memdup so use
Acked-by: Christophe Fergeau
On Mon, Jun 18, 2018 at 11:29:38AM +0100, Frediano Ziglio wrote:
> Most of pipe items use this name for the base field.
> This also allows to use SPICE_UPCAST macros instead of a long
> SPICE_CONTAINEROF.
>
> Signed-off-by: Frediano Ziglio
>
*
(*)(void *)' [-Wcast-function-type]
g_once(_formats_once, (GThreadFunc)init_image_formats, NULL);
Signed-off-by: Christophe Fergeau
---
src/virt-viewer-window.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
index
spice_main_set_display and spice_main_set_display_enabled have been
superseded by spice_main_channel_update_display and
spice_main_channel_update_display_enabled
Signed-off-by: Christophe Fergeau
---
src/virt-viewer-display-spice.c | 7 ++-
src/virt-viewer-session-spice.c | 27
.
This commit wraps both the compat code and the g_strv_contains() call in
a strv_contains() helper where we can hide the magic needed in the 2
cases to avoid compilation issues.
Signed-off-by: Christophe Fergeau
---
src/Makefile.am | 2 --
src/glib-compat.c| 35
Signed-off-by: Christophe Fergeau
---
src/channel-main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/channel-main.h b/src/channel-main.h
index 530378db..fd7a3bb3 100644
--- a/src/channel-main.h
+++ b/src/channel-main.h
@@ -113,7 +113,7 @@ void
Hey,
On Wed, May 09, 2018 at 01:20:19PM +0200, Lukáš Hrázký wrote:
> On Wed, 2018-05-09 at 05:18 -0400, Frediano Ziglio wrote:
> > The agent send a single message, but reads/writes to the device are
> > not atomic. Note that the current protocol introduce additional
> > delays as the frames
Acked-by: Christophe Fergeau
You probably need something like this for make distcheck/CI
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index a34eb0e7..e2c35ef9 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -10,7 +10,7 @@ before_script:
makecheck:
script:
- - ./autogen.sh --enable
701 - 800 of 10424 matches
Mail list logo
