On Thu, Oct 31, 2019 at 3:04 AM txfh2007 via discuss <
ovs-discuss@openvswitch.org> wrote:
> Hi Ben && Darrell：
> This patch works, but after merging this patch I have found the iperf
> throughout decrease from 5Gbps+ to 500Mbps.
what is the 5Gbps number ? Is that
This is fixed via 9171c63532ee9cbc63bb8cfae364ab071f44389b
2.10.4/3/2 will have it
On Thu, Oct 10, 2019 at 6:56 PM txfh2007 via discuss <
ovs-discuss@openvswitch.org> wrote:
> Hi Ben:
> This is my tcpdump result and the userspace datapath cache flow:
>
>Note: the icmp reply got by ovs
1/ Pls provide a hexdump capture of the request and corresponding reply
packets.
2/ Also, I would check 2.10.4 or latest 2.10.
On 10/10/19, 7:51 AM, "ovs-discuss-boun...@openvswitch.org on behalf of
txfh2007 via discuss" wrote:
Hi all:
I was using OVS-DPDK(version 2.10-1), and I
on.
> >>>>
> >>>> Also change the name of the test to make it more informativeand
> >>>> less redundant and add comments with a short explanation.
> >>>>
> >>>> Fixes: d7fd61a ("tests: Add check for correct l3l4 conntrack f
On Fri, Oct 4, 2019 at 7:05 AM Gregory Rose wrote:
>
> On 10/3/2019 6:56 PM, Darrell Ball wrote:
> > Thanks for the patch
> >
> > This approach will not work for the userspace datapath
> >
> > Few issues off the top of my head:
> >
> > 1/
On Thu, Oct 3, 2019 at 6:56 PM Darrell Ball wrote:
> Thanks for the patch
>
> This approach will not work for the userspace datapath
>
> Few issues off the top of my head:
>
> 1/ packet-out frees the packet (which is a fragment in this case) after
> completion
>
out the packet
Alternatively, if you want to use this simplified approach, you can disable
the test for the userspace datapath.
Darrell
On Thu, Oct 3, 2019 at 10:46 AM Greg Rose wrote:
> Two commits recently fixed an issue with setting the corrrect l3 and l4
> flow informatio
OSD/node count? Is
the concern just the large rebalance if a node fails and takes out a large
portion of the OSDs at once?
-Original Message-
From: Paul Emmerich
Sent: Tuesday, October 01, 2019 3:00 PM
To: Darrell Enns
Cc: ceph-users@ceph.io
Subject: Re: [ceph-users] RAM recommendation
The standard advice is "1GB RAM per 1TB of OSD". Does this actually still hold
with large OSDs on bluestore? Can it be reasonably reduced with tuning?
>From the docs, it looks like bluestore should target the "osd_memory_target"
>value by default. This is a fixed value (4GB by default), which
Thanks for the patch
Looks good and matches the upstream version, including the rcu deference
fixup.
Thanks for remembering to add the requested test incremental, post fix.
Darrell
On Fri, Sep 27, 2019 at 2:14 PM Yi-Hung Wei wrote:
> This patch is from the following upstream net-next com
Thanks for doing this Vishal !
Except for minor patch formatting issues (inline), this is fine and also
tests fine.
On Fri, Sep 27, 2019 at 10:54 PM Vishal Deep Ajmera <
vishal.deep.ajm...@ericsson.com> wrote:
> From: Darrell Ball
>
> The ICMPv4 error data L4 length check was
On Wed, Sep 25, 2019 at 1:46 PM Ben Pfaff wrote:
> On September 25, 2019 1:42:36 PM PDT, Darrell Ball
> wrote:
>>
>> Thank you
>>
>> Pls see inline
>>
>> On Wed, Sep 25, 2019 at 10:26 AM Ben Pfaff wrote:
>>
>>> On Tue, Sep 24, 201
.
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2019-May/359188.html
Signed-off-by: Darrell Ball
---
v4: Splice tcp sequence number check in tcp_conn_update() out as a function
for clarity (Ben).
Fix up some dpctl man page comments (Ben).
s/ckk/chk/ for 'tcp_seq_chk
Thank you
Pls see inline
On Wed, Sep 25, 2019 at 10:26 AM Ben Pfaff wrote:
> On Tue, Sep 24, 2019 at 03:47:35PM -0700, Darrell Ball wrote:
> > This may be needed in some special cases, such as to support some
> hardware
> > offload implementations. Note that disabling T
On Wed, Sep 25, 2019 at 10:51 AM Ben Pfaff wrote:
> On Mon, Aug 26, 2019 at 09:05:44AM -0700, Darrell Ball wrote:
> > Cache the 'conn' context and use it when it is valid. The cached 'conn'
> > context will get reset if it is not expected to be valid; the cost to do
> &g
.
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2019-May/359188.html
Signed-off-by: Darrell Ball
---
v3: Make manpage comments more verbose.
Expand commit message comments.
v2: Per particular requirement, support 'no-tcp-seq-chk' rather than
'liberal' mode.
NEWS
Thanks Ben
I just noticed I sent another version here
https://patchwork.ozlabs.org/patch/1153283/
but there were a couple of issues that deserve a resend.
It might need a rebase as well
Darrell
On Tue, Sep 24, 2019 at 3:18 PM Ben Pfaff wrote:
> On Wed, Jun 12, 2019 at 12:44:18PM -0
Thanks Ben
Would you mind applying to 2.12 as well.
Darrell
On Tue, Sep 24, 2019 at 2:34 PM Ben Pfaff wrote:
> On Mon, Sep 23, 2019 at 04:44:33PM -0700, Darrell Ball wrote:
> > Valgrind reported that 'pkt->md.ct_orig_tuple.ipv4.ipv4_proto' is
> > uninitialized in
4733c527da ("conntrack: Validate accessing of conntrack data in
pkt_metadata.")
CC: Yifeng Sun
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index fd71e6c..b56ef06 100644
--- a/l
No images ? Please Click Here
3 ways to reverse diabetes and high blood pressure
I’ve had BGP from comcast business in River North before, not sure what their
minimum bandwidth is for that. Tunnels may be simplest at that bandwidth level.
> On Sep 3, 2019, at 12:52 PM, Florian Brandstetter via NANOG
> wrote:
>
> Might be worth to consider running a software router on that
und by
inspection.
Fixes: edd1bef468c0 ("dpdk: Add more ICMP Related NAT support.")
Signed-off-by: Darrell Ball
---
v2: Elaborate added comments.
lib/conntrack.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index e5266e5..6452d82 100
und by
inspection.
Fixes: edd1bef468c0 ("dpdk: Add more ICMP Related NAT support.")
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index e5266e5..79d2711 100644
--- a/lib/conntrack.c
+++ b/li
. Your cluster will go write only
if it loses two nodes though, but you can always make a change to the
server-quorum-ratio later if you need to keep it running temporarily.
Hope that makes sense of what’s going on for you,
-Darrell
> On Aug 23, 2019, at 5:06 PM, Carl Sirotic
> wrot
Depends on your disks, your network, some CPU since you’re using a dispersed
volume, and the amount of data you’ve got on them. Watch this heal and see how
long it takes to baseline your system. If you’ve got 10G and SSDs, it’s
probably not going to take too long. If you’ve got 1G, HDDs, and
On Thu, Aug 29, 2019 at 7:37 AM Ben Pfaff wrote:
> On Tue, Aug 27, 2019 at 04:59:02PM -0700, Darrell Ball wrote:
> > The ICMPv4 error data L4 length check was found to be too strict for TCP,
> > expecting a minimum of 20 rather than 8 bytes. This worked by
> > hapens
On Thu, Aug 29, 2019 at 8:40 AM Yifeng Sun wrote:
> Thanks Ben and Darrell, let me check it out.
>
Can you also add a use case description ?
>From a controller POV, defining which interface is a vtep can be done in
one place and
distributed to the rest of the system; it is not
as the element, and then gradually shorten
them to adjust for resonance, depending on how the SWR looks.
In the past, the L has worked great for me. I now have about 115 countries
confirmed on 160, all with an L.
73 and best of luck with the project,
Darrell AB2E
From
Thanks for the patch
How about writing a system test ?
Darrell
On Wed, Aug 28, 2019 at 10:50 AM Yifeng Sun wrote:
> For userspace datapath, currently only the bridge itself, the LOCAL port,
> can be the tunnel endpoint to encap/decap tunnel packets. This patch
> enables non-br
On Wed, Aug 28, 2019 at 1:43 AM Vishal Deep Ajmera <
vishal.deep.ajm...@ericsson.com> wrote:
> That is interesting
>
> i just tried applying on top of tree and I see that the git applies some
> changes (2 lines)
>
> in extract_l4_icmp6() rather the intended extract_l4_icmp() as in the
> patch I
")
CC: Daniele Di Proietto
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2019-August/361949.html
Reported-by: Vishal Deep Ajmera
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Vishal Deep Ajmera
Signed-off-by: Darrell Ball
---
v2: Rebase to fix git applying to wron
On Tue, Aug 27, 2019 at 2:02 AM Vishal Deep Ajmera <
vishal.deep.ajm...@ericsson.com> wrote:
> Hi Darrell,
>
> Thanks for the patch. When I applied the patch to latest master,
> I see that we take care of length check (< 8) only for ICMPv6 and
> not for ICMPv4.
That is
On Fri, Aug 23, 2019 at 9:09 AM Darrell Ball wrote:
> Thanks for the patch
>
> Goes back to release 2.6/day one :-).
>
> I'll provide more feedback after today.
>
I sent an alternative patch here
https://mail.openvswitch.org/pipermail/ovs-dev/2019-August/362013.htm
Resent this patch, as it had a bad e-mail address
Darrell
On Mon, Aug 26, 2019 at 9:06 AM Darrell Ball wrote:
> The ICMP error data L4 length check was found to be too strict for TCP,
> expecting a minimum of 20 rather than 8 bytes. This worked by
> hapenstance for other inner
s-dev/2019-August/361949.html
Reported-by: Vishal Deep Ajmera
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Vishal Deep Ajmera
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 38 ++
lib/packets.h | 3 +++
2 files changed, 25 insertions(+), 16 deletion
s-dev/2019-August/361949.html
Reported-by: Vishal Deep Ajmera
Signed-off-by: Vishal Deep Ajmera
Co-authored-by: Vishal Deep Ajmera
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 38 ++
lib/packets.h | 3 +++
2 files changed, 25 insertions(+), 16 deletion
.
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2019-May/359188.html
Signed-off-by: Darrell Ball
---
v2: Per particular requirement, support 'no-tcp-seq-chk' rather than
'liberal' mode.
Make manpage comments more verbose.
Expand commit message comments.
lib/conntrack
. A negative test is added to check the resetting of the cached
'conn'.
Signed-off-by: Darrell Ball
---
v6: a/ Added 'conn' reset for mpls push case to force 'invalid', for
consistency reasons.
b/ Add missed lock around 'conn->mark' and 'conn->label' access in
'process_on
Thanks for the patch
Goes back to release 2.6/day one :-).
I'll provide more feedback after today.
On Fri, Aug 23, 2019 at 6:20 AM Vishal Deep Ajmera <
vishal.deep.ajm...@ericsson.com> wrote:
> An ICMP packet with type destination or host not reachable also carries
> 28 bytes of ICMP data
On Wed, Aug 21, 2019 at 3:13 PM Ben Pfaff wrote:
> On Mon, Aug 19, 2019 at 08:35:11AM -0700, Darrell Ball wrote:
> > Thanks for the patch
> >
> > On Sun, Aug 18, 2019 at 11:01 PM Li RongQing
> wrote:
> >
> > > the result of extract_l3_ipv4/6 should be c
On Mon, Aug 12, 2019 at 5:22 PM Yi-Hung Wei wrote:
> On Sun, Aug 11, 2019 at 12:30 PM Darrell Ball wrote:
> >
> > I did some further testing and ran into another issue; in this case,
> one, I did not expect.
> >
> > I added an additional sending of packet
On Tue, Aug 20, 2019 at 12:30 PM Yi-Hung Wei wrote:
> On Tue, Aug 20, 2019 at 12:46 AM Darrell Ball wrote:
> > After fixing a bug in my proposed incremental and adding tracking of an
> already removed sub timeout policy:
> > Pls double check.
>
> Thanks for the pro
On Mon, Aug 19, 2019 at 7:41 PM Darrell Ball wrote:
>
>
> On Mon, Aug 19, 2019 at 12:42 PM Darrell Ball wrote:
>
>>
>>
>> On Mon, Aug 19, 2019 at 10:52 AM Yi-Hung Wei
>> wrote:
>>
>>> On Fri, Aug 16, 2019 at 5:07 PM Darrell Ball wrote:
>
On Mon, Aug 19, 2019 at 12:42 PM Darrell Ball wrote:
>
>
> On Mon, Aug 19, 2019 at 10:52 AM Yi-Hung Wei wrote:
>
>> On Fri, Aug 16, 2019 at 5:07 PM Darrell Ball wrote:
>> >
>> > Thanks for the patch
>> >
>> > Pls let me know if this incr
On Mon, Aug 19, 2019 at 11:12 AM Yi-Hung Wei wrote:
> On Fri, Aug 16, 2019 at 5:10 PM Darrell Ball wrote:
> >
> > Thanks for the patch
> >
> > Pls let me know if the following incremental works for you.
> >
> > diff --git a/ofproto/ofproto-dpif.c b/o
but I suspect these two need another round or six of tuning to tell if they are
making a difference.
I use the throughput-performance tuned profile on my servers, so you should be
in good shape there.
> On Aug 19, 2019, at 12:22 PM, Guy Boisvert
> wrote:
>
> On 2019-08-19 12:08 p
y interested about these settings.
>
> Also, is it possible to turn the shard feature AFTER the volume was started
> to be used ?
>
>
> Carl
>
> On 2019-08-19 12:08 p.m., Darrell Budic wrote:
>> You also need to make sure your volume is setup properly for best
>
On Mon, Aug 19, 2019 at 10:52 AM Yi-Hung Wei wrote:
> On Fri, Aug 16, 2019 at 5:07 PM Darrell Ball wrote:
> >
> > Thanks for the patch
> >
> > Pls let me know if this incremental works for you.
> > Main change is logging fix for timeout policy deletion.
> &g
You also need to make sure your volume is setup properly for best performance.
Did you apply the gluster virt group to your volumes, or at least
features.shard = on on your VM volume?
> On Aug 19, 2019, at 11:05 AM, Carl Sirotic
> wrote:
>
> Yes, I made sure there was no heal.
> This is what
Thanks for the patch
On Sun, Aug 18, 2019 at 11:01 PM Li RongQing wrote:
> the result of extract_l3_ipv4/6 should be checked in reverse_nat_packet
> when it is false, meaning this packet is wrong, should not do handle it
> continually
>
> Signed-off-by: Li RongQing
> ---
> lib/conntrack.c |
Thanks for the patch
Pls let me know if the following incremental works for you.
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 244155a..cb8b51e 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -168,6 +168,12 @@ struct ct_timeout_policy {
Thanks for the patch
Pls let me know if this incremental works for you.
Main change is logging fix for timeout policy deletion.
Darrell
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index 1d4ee60..00d957b 100644
--- a/lib/dpif-netlink.c
+++ b/lib/dpif-netlink.c
@@ -2822,11 +2822,10
ebounce in previous version(s); maybe I missed it in my
quick check of v4; I'll check more later.
Anyways, we need some debouncing.
Also the vlog rate limiting may need adjustment to throttle more.
Thanks Darrell
On Thu, Aug 15, 2019 at 12:31 PM Yi-Hung Wei wrote:
> This patch series enables z
On Thu, Aug 15, 2019 at 10:53 AM William Tu wrote:
> Thanks for the review.
>
> On Mon, Aug 12, 2019 at 09:54:42PM -0700, Darrell Ball wrote:
> > Thanks for the patch
> >
> > Thanks for the fixups; mostly minor comments inline.
> >
> > On Mon, Aug 1
Thanks for the patch
mostly minor comments
On Mon, Aug 12, 2019 at 5:54 PM Yi-Hung Wei wrote:
> This patch first defines the dpif interface for a datapath to support
> adding, deleting, getting and dumping conntrack timeout policy.
> The timeout policy is identified by a 4 bytes unsigned
On Wed, Aug 14, 2019 at 1:28 PM Yi-Hung Wei wrote:
> On Tue, Aug 13, 2019 at 7:46 PM Darrell Ball wrote:
> >
> > Thanks for the patch
> >
> > Some high level comments:
> >
> > 1/ The ct_tp_kill_list code is still in common code
> > I think we
On Wed, Aug 14, 2019 at 9:47 AM Yi-Hung Wei wrote:
> On Mon, Aug 12, 2019 at 7:46 PM Darrell Ball wrote:
> >> diff --git a/vswitchd/vswitch.ovsschema b/vswitchd/vswitch.ovsschema
> >> index f7c6eb8983cd..c0a2242ad345 100644
> >> --- a/vswitchd/vswitch
On Tue, Aug 13, 2019 at 8:03 PM Darrell Ball wrote:
> Thanks for the patch
>
> few more comments
>
> On Mon, Aug 12, 2019 at 5:57 PM Yi-Hung Wei wrote:
>
>> This patch derives the timeout policy based on ct zone from the
>> internal data structure that we maintai
Thanks for the patch
few more comments
On Mon, Aug 12, 2019 at 5:57 PM Yi-Hung Wei wrote:
> This patch derives the timeout policy based on ct zone from the
> internal data structure that we maintain on dpif layer.
>
> It also adds a system traffic test to verify the zone-based conntrack
>
Thanks for the patch
Some high level comments:
1/ The ct_tp_kill_list code is still in common code
I think we discussed moving that to the dpif backer code
ct_timeout_policy_unref() is adding to this deferred kill list which is
not needed for userspace
datapath.
2/
On Tue, Aug 13, 2019 at 2:33 PM Yi-Hung Wei wrote:
> On Tue, Aug 13, 2019 at 11:43 AM Darrell Ball wrote:
> > Sure, circling back to this part
> >
> > yep, it is the Linux In-tree kernel module rather than OVS tree module
> >
> > dball@ubuntu:~/ovs$ modinfo
On Tue, Aug 13, 2019 at 11:01 AM Yi-Hung Wei wrote:
> On Mon, Aug 12, 2019 at 7:35 PM Darrell Ball wrote:
> >
> > Thanks for the patch
> >
> > Not a full review; I just did a quick run of the test using a more
> recent kernel version
> >
> > dball@u
Thanks for the patch
Thanks for the fixups; mostly minor comments inline.
On Mon, Aug 12, 2019 at 5:53 PM Yi-Hung Wei wrote:
> From: William Tu
>
> The patch adds commands creating/deleting/listing conntrack zone
> timeout policies:
> $ ovs-vsctl {add,del,list}-zone-tp dp zone=zone_id ...
>
Thanks for the patch
On Mon, Aug 12, 2019 at 5:52 PM Yi-Hung Wei wrote:
> From: Justin Pettit
>
> Signed-off-by: Justin Pettit
> Signed-off-by: Yi-Hung Wei
> Co-authored-by: Yi-Hung Wei
> ---
> vswitchd/vswitch.ovsschema | 51 -
> vswitchd/vswitch.xml | 275
>
0:00:00:00,dst=92:48:5b:47:e2:63/00:00:00:00:00:00),eth_type(0x0800),ipv4(src=
10.1.1.1/0.0.0.0,dst=10.1.1.2/0.0.0.0,proto=1,tos=0/0,ttl=64/0,frag=no),icmp(type=8/0,code=0/0),
actions:ct(commit,zone=5,timeout=ovs_tp_0_icmp4),3
2019-08-13T02:19:09Z|1|daemon_unix|WARN|/home/dball/ovs/_gcc/te
ixes.
> * ct-dpif
> - Fold in diff suggestion from Justin.
> * bridge, ofproto-dpif
> - Restruct the ofproto and dpif layer support for zone based timeout
> policy.
> * system traffic test
> - Fix bug reported by Darrell.
>
which one ?
> * Address re
On Mon, Aug 12, 2019 at 5:15 PM Yi-Hung Wei wrote:
> On Sun, Aug 11, 2019 at 12:30 PM Darrell Ball wrote:
> >
> > I did some further testing and ran into another issue; in this case,
> one, I did not expect.
> >
> > I added an additional sending of packet
On Mon, Aug 12, 2019 at 5:22 PM Yi-Hung Wei wrote:
> On Sun, Aug 11, 2019 at 12:30 PM Darrell Ball wrote:
> >
> > I did some further testing and ran into another issue; in this case,
> one, I did not expect.
> >
> > I added an additional sending of packet
c=10.1.1.2,dst=10.1.1.1,sport=,dport=),zone=5
On Tue, Aug 6, 2019 at 12:16 PM Darrell Ball wrote:
>
>
> On Tue, Aug 6, 2019 at 11:07 AM Yi-Hung Wei wrote:
>
>> On Tue, Aug 6, 2019 at 10:21 AM Darrell Ball wrote:
>> >
>> >
>> > I did
On Fri, Aug 9, 2019 at 1:10 PM Justin Pettit wrote:
>
> > On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote:
> >
> > diff --git a/lib/dpif-provider.h b/lib/dpif-provider.h
> > index 79a2314500cf..57b32ccb610f 100644
> > --- a/lib/dpif-provider.h
> > +++ b/lib/dpif-provider.h
> > @@ -536,6 +536,11
On Fri, Aug 9, 2019 at 1:23 PM Justin Pettit wrote:
>
> > On Aug 7, 2019, at 11:40 AM, Darrell Ball wrote:
> >
> > There are 3 behaviors with the patchset that are datapath specific
> >
> > 1/ Unwildcarding of commit flows with timeout policies
> > A
Yes that is correct.
Narrator once you bring it up, will give you a window with what is new and
other items.
Thanks,
Darrell
-Original Message-
From: Talk On Behalf Of
Debby Franson via Talk
Sent: Thursday, August 8, 2019 5:10 PM
To: Window-Eyes Discussion List
Cc: Debby Franson
On Wed, Aug 7, 2019 at 1:37 PM William Tu wrote:
> Thanks for the review.
>
> On Mon, Aug 05, 2019 at 04:12:02PM -0700, Darrell Ball wrote:
> > Thanks for the patch
> >
> > I noticed '--may-exist' and '--if-exists' are supported now for
> > add--zone-tp/d
On Wed, Aug 7, 2019 at 11:51 AM Darrell Ball wrote:
>
>
> On Wed, Aug 7, 2019 at 11:40 AM Darrell Ball wrote:
>
>>
>>
>> On Tue, Aug 6, 2019 at 9:57 PM Justin Pettit wrote:
>>
>>>
>>> > On Aug 5, 2019, at 8:07 PM, Darrell Ball wrot
On Wed, Aug 7, 2019 at 11:40 AM Darrell Ball wrote:
>
>
> On Tue, Aug 6, 2019 at 9:57 PM Justin Pettit wrote:
>
>>
>> > On Aug 5, 2019, at 8:07 PM, Darrell Ball wrote:
>> >
>> > On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei
>> wrote:
>> &
On Tue, Aug 6, 2019 at 9:57 PM Justin Pettit wrote:
>
> > On Aug 5, 2019, at 8:07 PM, Darrell Ball wrote:
> >
> > On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei wrote:
> >
> >> +struct ct_timeout_policy {
> >> +struct uuid uuid;
> >&g
On Tue, Aug 6, 2019 at 11:07 AM Yi-Hung Wei wrote:
> On Tue, Aug 6, 2019 at 10:21 AM Darrell Ball wrote:
> >
> >
> > I did some more testing and found a similar problem as in V1.
> >
> > This test can be run successfully once and then fails after
On Mon, Aug 5, 2019 at 8:51 PM Darrell Ball wrote:
> Thanks for the patch
>
> The main comment I had from the V1 patch was adding the check
>
> +if (ofc->flags & NX_CT_F_COMMIT) {
>
> in compose_conntrack_action()
>
> I see that was done.
>
> Aft
On Mon, Aug 5, 2019 at 9:03 PM Darrell Ball wrote:
> Thanks for the patch
>
> I see the test is much improved now from V1 and passes - thanks
>
> Ideally, tests should be associated with some code for context
> It could be folded into patch 8
>
I did some more testin
Thanks for the patch
I see the test is much improved now from V1 and passes - thanks
Ideally, tests should be associated with some code for context
It could be folded into patch 8
On Thu, Aug 1, 2019 at 3:12 PM Yi-Hung Wei wrote:
> This patch adds a system traffic test to verify the
Thanks for the patch
The main comment I had from the V1 patch was adding the check
+if (ofc->flags & NX_CT_F_COMMIT) {
in compose_conntrack_action()
I see that was done.
After a quick scan, I had one minor comment inline.
On Thu, Aug 1, 2019 at 3:12 PM Yi-Hung Wei wrote:
> This patch
Thanks for the patch
comments inline
On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei wrote:
> This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
> the zone-based timeout policy in the vswitchd. Whenever there is a
> database change, vswitchd will read the datapath, CT_Zone, and
Thanks for the patch
I am going to avoid commenting on style or code conciseness in the
interests of time
On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei wrote:
> This patch first defines the dpif interface for a datapath to support
> adding, deleting, getting and dumping conntrack timeout policy.
One comment fix:
s/ "min": 0, "max": "65535"}},/ "min": 0, "max": "65536"}},/
On Mon, Aug 5, 2019 at 4:09 PM Darrell Ball wrote:
> Thanks for the patch
>
> I avoided duplicate comments from what Justin suggested
>
Thanks for the patch
I noticed '--may-exist' and '--if-exists' are supported now for
add--zone-tp/del-zone-tp - thanks
The check for duplicate timeout policies now correctly checks all key and
values - thanks
Some more comments inline
I am trying to avoid duplicate comment from Justin, so I just
Thanks for the patch
I avoided duplicate comments from what Justin suggested
comments inline
On Thu, Aug 1, 2019 at 3:08 PM Yi-Hung Wei wrote:
> From: Justin Pettit
>
> From: Justin Pettit
>
> Signed-off-by: Justin Pettit
> ---
> vswitchd/vswitch.ovsschema | 43 +++-
>
Press Windows and then type winver and press enter.
Thanks,
Darrell
-Original Message-
From: Talk On Behalf Of
Carol Smith via Talk
Sent: Saturday, August 3, 2019 1:42 PM
To: Window-Eyes Discussion List
Cc: Carol Smith
Subject: Re: Windows Update 1903
This may be a silly question
on
anything similar.
-Darrell
> On Aug 2, 2019, at 9:23 AM, kevin.do...@manchester.ac.uk wrote:
>
> HI
> I think it is a bug with qemu, and isci disks. Has anyone else seen this
> issue VM crashes and lost communication with qemu Can I update qemu ? if so
> what is the late
On Wed, Jul 31, 2019 at 1:25 AM Ilya Maximets
wrote:
> On 29.07.2019 21:53, Yi-Hung Wei wrote:
> > Hi Ilya,
> >
> > Thanks for your comment.
> >
> > On Mon, Jul 29, 2019 at 2:22 AM Ilya Maximets
> wrote:
> >>
> >> Hi everyone,
> >>
> >> My 2 cents for the feature design:
> >>
> >> From the
Thanks Lorenzo
Looks good
I did not retest this patch, but it is the same code you sent before that I
had tested
On Mon, Jul 29, 2019 at 4:41 AM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> Fix conntrack checks in the following tests in tests/system-ovn.at:
> - ovn -- DNAT and SNAT
On Tue, Jul 30, 2019 at 10:41 AM Mark Michelson wrote:
> Why do these macros require python at all?
>
alg test tools
>
> On 7/29/19 7:48 AM, Lorenzo Bianconi wrote:
> > Do not strictly require python2 for CHECK_CONNTRACK macro definitions in
> > system-{kmod,userspace}-macros.at
> >
> >
Thanks Lorenzo
Looks good
On Mon, Jul 29, 2019 at 4:48 AM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> Do not strictly require python2 for CHECK_CONNTRACK macro definitions in
> system-{kmod,userspace}-macros.at
>
> Signed-off-by: Lorenzo Bianconi
> ---
>
On Mon, Jul 29, 2019 at 3:51 PM Yi-Hung Wei wrote:
> On Mon, Jul 29, 2019 at 1:12 PM Darrell Ball wrote:
> >> > "is_default" - can you explain this one ?
> >>
> >> This flag is used to configure the default timeout policy in the
> >> datapath
added one more comment.
On Fri, Jul 26, 2019 at 4:10 PM Darrell Ball wrote:
> added one more comment for now
>
>
> On Fri, Jul 26, 2019 at 11:13 AM Darrell Ball wrote:
>
>> Thanks for the patch
>>
>> Not a full review; just some initial testing
>>
>&g
On Mon, Jul 29, 2019 at 11:53 AM Yi-Hung Wei wrote:
> Hi Ilya,
>
> Thanks for your comment.
>
> On Mon, Jul 29, 2019 at 2:22 AM Ilya Maximets
> wrote:
> >
> > Hi everyone,
> >
> > My 2 cents for the feature design:
> >
> > From the user's perspective:
> >
> > * 'add-dp'/'del-dp' commands looks
On Mon, Jul 29, 2019 at 12:37 PM Yi-Hung Wei wrote:
> On Fri, Jul 26, 2019 at 11:41 AM Darrell Ball wrote:
> >
> > Thanks for the patch
> >
> > I found this patch hard to review since it does not contain
> implementations
> > The same comment applies to
On Fri, Jul 26, 2019 at 11:41 AM Darrell Ball wrote:
> Thanks for the patch
>
> I found this patch hard to review since it does not contain implementations
> The same comment applies to Patch 6
> I think Patches 5-7 can be combined into one patch, which will make review
> easi
One more comment
Not a full review; just focusing on the more important parts for now.
On Fri, Jul 26, 2019 at 5:44 PM Darrell Ball wrote:
> Thanks for the patch; not a full review
>
> On Thu, Jul 25, 2019 at 4:29 PM Yi-Hung Wei wrote:
>
>> This patch reads the
One more comment inline regarding to the cleanup part
On Fri, Jul 26, 2019 at 9:27 AM Darrell Ball wrote:
> Thanks for the patch
>
> Comments inline
>
> On Thu, Jul 25, 2019 at 4:31 PM Yi-Hung Wei wrote:
>
>> This patch adds a system traffic test to verify the zone-ba
One more comment inline
On Thu, Jul 25, 2019 at 10:02 PM Darrell Ball wrote:
> Thanks for the patch
>
> Few comments inline
>
> On Thu, Jul 25, 2019 at 4:30 PM Yi-Hung Wei wrote:
>
>> This patch derives the timeout policy based on ct zone from the
>> inte
201 - 300 of 8947 matches
Mail list logo
