Re: RFR (XS) 8033946 - Hotspot build should ignore ide folder

2014-09-04 Thread Dean Long
Wouldn't it be better to replace $(HOTSPOT_TOPDIR) with $(HOTSPOT_TOPDIRS), so we don't even search in top-level directories that aren't interesting? dl On 9/4/2014 9:45 AM, Gerard Ziemski wrote: hi all, Please review a very small fix that makes hotspot build ignore ide folder, which is

Re: Review Request (S) 8025841: JVMTI: vtable stub dynamic code notification is misplaced

2014-02-07 Thread Dean Long
What's the cost for adding a new BufferBlob subtype? We already have AdapterBlob and MethodHandlesAdapterBlob. dl On 2/6/2014 3:52 PM, Oleg Mazurov wrote: My understanding was that a buffer blob was just that - a buffer. Could potentially contain code fragments of different kinds. Thus,

Re: Review Request (S) 8025841: JVMTI: vtable stub dynamic code notification is misplaced

2014-02-07 Thread Dean Long
code. In fact, I was going to file a linked JIRA issue on that further improvement and if my idea for it holds true there would be no need for a new BufferBlob subtype. -- Oleg On 2/7/2014 1:06 PM, Dean Long wrote: What's the cost for adding a new BufferBlob subtype? We already have

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Dean Long
It seems like you could take this opportunity to make these declared fields of java.lang.Class, allowing, for example, getProtectionDomain0() to be a simple Java method instead of a native method. dl On 05/20/2013 03:39 PM, Coleen Phillimore wrote: Summary: Inject protection_domain, signers,

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Dean Long
On 5/20/2013 7:50 PM, Coleen Phillimore wrote: On 5/20/2013 8:42 PM, Dean Long wrote: It seems like you could take this opportunity to make these declared fields of java.lang.Class, allowing, for example, getProtectionDomain0() to be a simple Java method instead of a native method. We

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Dean Long
Right, unless there is a way to inject them conditionally. dl On 5/20/2013 9:02 PM, Ioi Lam wrote: But if you move these fields into Class.java (in JDK8), then hsx25 will not run on JDK7 anymore, unless these fields are also added in Class.java in JDK7. - Ioi On 05/20/2013 05:42 PM, Dean

Re: RFC 7038914: VM could throw uncaught OOME in ReferenceHandler thread

2013-05-10 Thread Dean Long
If you really want to bullet-proof ReferenceHandler (and other system threads) against OOME caused by native allocations, then don't forget about monitor inflation if there is contention for lock :-) dl On 5/10/2013 6:14 AM, David Holmes wrote: Hi Peter, So it would appear that it is not in

Re: RFC 7038914: VM could throw uncaught OOME in ReferenceHandler thread

2013-05-10 Thread Dean Long
On 5/10/2013 1:22 PM, Peter Levart wrote: On 05/10/2013 10:08 PM, Peter Levart wrote: On 05/10/2013 08:10 PM, Dean Long wrote: If you really want to bullet-proof ReferenceHandler (and other system threads) against OOME caused by native allocations, then don't forget about monitor inflation

Re: Request for review- RFE 8005716

2013-03-07 Thread Dean Long
function exported by the library Should these read linked with the VM, or linked with the native application loading the VM? Jeremy On Wed, Mar 6, 2013 at 8:21 AM, Bob Vandette bob.vande...@oracle.com mailto:bob.vande...@oracle.com wrote: On Mar 5, 2013, at 7:36 PM, Dean Long wrote

Re: Request for review- RFE 8005716

2013-03-06 Thread Dean Long
On 3/5/2013 8:13 PM, BILL PITTORE wrote: On 3/5/2013 7:36 PM, Dean Long wrote: If JNI_ONLOAD_SYMBOLS contains something like _JNI_OnLoad@8 on Windows, you can't just turn that into _JNI_OnLoad@8_ + libname. I think it needs to be _JNI_OnLoad_ + libname + @8 I'll look into that. When I built

Re: Request for review- RFE 8005716

2013-03-06 Thread Dean Long
If JNI_ONLOAD_SYMBOLS contains something like _JNI_OnLoad@8 on Windows, you can't just turn that into _JNI_OnLoad@8_ + libname. I think it needs to be _JNI_OnLoad_ + libname + @8 Looks like onLoadSymbols[] is unused in Java_java_lang_ClassLoader_00024NativeLibrary_findBuiltinLib(). Instead

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-05 Thread Dean Long
What if allocate_init_map() fails to allocate memory? Shouldn't add_class_share_map_info() follow the pattern of add_map_info(): return NULL or map, and have the caller check for NULL? dl On 3/4/2013 11:39 PM, David Holmes wrote: Looks fine to me - thanks Staffan! David On 5/03/2013 5:24

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-05 Thread Dean Long
On 3/5/2013 3:23 PM, David Holmes wrote: On 6/03/2013 9:08 AM, Dean Long wrote: What if allocate_init_map() fails to allocate memory? Shouldn't add_class_share_map_info() follow the pattern of add_map_info(): return NULL or map, and have the caller check for NULL? AFAICS apart from one

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-05 Thread Dean Long
On 3/5/2013 4:48 PM, David Holmes wrote: On 6/03/2013 10:44 AM, Dean Long wrote: On 3/5/2013 3:23 PM, David Holmes wrote: On 6/03/2013 9:08 AM, Dean Long wrote: What if allocate_init_map() fails to allocate memory? Shouldn't add_class_share_map_info() follow the pattern of add_map_info

Re: RFR(XXS): 8007147: Trace event ExecuteVMOperation may get dangling pointer

2013-02-19 Thread Dean Long
On 2/19/2013 11:00 AM, Staffan Larsen wrote: On 19 feb 2013, at 19:56, Dean Long dean.l...@oracle.com mailto:dean.l...@oracle.com wrote: When the VM_Operation is created, we could take a snapshot of the thread_id of the caller, then use that later. One problem

Re: RFR: 7152800: All tests using the attach API fail with well-known file is not secure on Mac OS X

2012-03-20 Thread Dean Long
2012, at 20:38, Dean Long wrote: On linux, you can control this behavior with the setgid mode bit on the parent directory. Does that also work on OSX? dl On 3/19/2012 6:03 AM, Staffan Larsen wrote: Please review the following fix: Webrev: http://cr.openjdk.java.net/~sla/7152800/webrev.00

Re: RFR: 7152800: All tests using the attach API fail with well-known file is not secure on Mac OS X

2012-03-19 Thread Dean Long
On linux, you can control this behavior with the setgid mode bit on the parent directory. Does that also work on OSX? dl On 3/19/2012 6:03 AM, Staffan Larsen wrote: Please review the following fix: Webrev: http://cr.openjdk.java.net/~sla/7152800/webrev.00/

Auto Reply: serviceability-dev Digest, Vol 48, Issue 5

2011-11-04 Thread dean . long
This is an auto-replied message. I am out of the office right now.

<    1   2   3   4