Dan Williams wrote:
> Now that free_dev_dax_id() internally manages the references it needs
> the extra references taken by the dax_region drivers are not needed.
>
> Reported-by: Ira Weiny
Reviewed-by: Ira Weiny
> Signed-off-by: Dan Williams
> ---
> drivers/d
9c-2ecc3d496...@hpe.com
> [2]
> Reported-by: Yongqiang Liu
> Reported-by: Paul Cassella
> Reported-by: Ira Weiny
> Signed-off-by: Dan Williams
> ---
> drivers/dax/bus.c | 56
> +++--
> drivers/dax/dax-private.h |
Dan Williams wrote:
> Replace an open-coded device_unregister() sequence with the helper.
>
Reviewed-by: Ira Weiny
> Signed-off-by: Dan Williams
> ---
their parent while
> registered. If a child needs a parent object to complete its release it
> needs to hold a reference that it drops from its release callback.
> Arrange for a dax_mapping to pin its parent dev_dax instance until
> dax_mapping_release().
>
> Fixes: 0b07ce872a9e ("device-dax: introduce 'mapping' devices")
Reviewed-by: Ira Weiny
later.
Cc: Yongqiang Liu
Cc: Dan Williams
Cc: Paul Cassella
Signed-off-by: Ira Weiny
---
drivers/dax/bus.c | 13 ++---
drivers/dax/cxl.c | 4
drivers/dax/hmem/hmem.c | 3 ---
drivers/dax/pmem.c | 8 +---
4 files changed, 7 insertions(+), 21 deletions(-)
diff
: 09d09e04d2fc ("cxl/dax: Create dax devices for CXL RAM regions")
Cc: Dan Williams
Cc: linux-...@vger.kernel.org
Signed-off-by: Ira Weiny
---
This work was inspired by Yongqiang Liu here:
https://lore.kernel.org/all/20221203095858.612027-1-liuyongqian...@huawei.com/
---
drivers/dax/cxl.c |
")
Cc: Dan Williams
Signed-off-by: Ira Weiny
---
drivers/dax/bus.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
index 227800053309..899e29d107b4 100644
--- a/drivers/dax/bus.c
+++ b/drivers/dax/bus.c
@@ -583,6 +583,7 @@ s
evice to
hmem_register_device")
Reviewed-by: Ira Weiny
Signed-off-by: Yongqiang Liu
---
drivers/dax/hmem/hmem.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/dax/hmem/hmem.c b/drivers/dax/hmem/hmem.c
index e5fe8b39fb94..b4831a3d3934 100644
--- a/drivers/dax/h
/20221203095858.612027-1-liuyongqian...@huawei.com/
Signed-off-by: Ira Weiny
---
Ira Weiny (3):
dax/bus: Fix leaked reference in alloc_dax_region()
dax/cxl: Fix refcount leak in cxl_dax_region_probe()
dax/bus: Remove unnecessary reference in alloc_dax_region()
Yongqiang Liu (1):
dax/hmem
Paul Cassella wrote:
> On Fri, 2 Jun 2023, Ira Weiny wrote:
> > Paul Cassella wrote:
> > > On Sat, 3 Dec 2022, Ira Weiny wrote:
> > > > On Sat, Dec 03, 2022 at 09:58:58AM +, Yongqiang Liu wrote:
>
> > > > > We should always ca
Paul Cassella wrote:
> On Sat, 3 Dec 2022, Ira Weiny wrote:
> > On Sat, Dec 03, 2022 at 09:58:58AM +, Yongqiang Liu wrote:
>
> > > We should always call dax_region_put() whenever devm_create_dev_dax()
> > > succeed or fail to avoid refcount leak of dax_regio
Fan Ni wrote:
> The 05/22/2023 16:09, Jonathan Cameron wrote:
> > From: Ira Weiny
> >
> > CXL testing is benefited from an artificial event log injection
> > mechanism.
> >
> > Add an event log infrastructure to insert, get, and clear events from
>
Jonathan Cameron wrote:
> On Thu, 18 May 2023 13:19:12 -0700
> Ira Weiny wrote:
>
> > Jonathan Cameron wrote:
> > > On Wed, 17 May 2023 19:45:54 -0700
> > > Ira Weiny wrote:
> > >
> > > > Magic numbers can be confusing.
> > > &g
"transaction-type": 192,
> > > "channel": 3,
> > > "rank": 17,
> > > "nibble-mask": 37421234,
> > > "bank-group": 7,
> > > "bank": 11,
>
Jonathan Cameron wrote:
> Current implementation is very simple so many of the corner
> cases do not exist (e.g. fragmenting larger poison list entries)
>
> Reviewed-by: Fan Ni
Minor nit below. Otherwise looks good.
Reviewed-by: Ira Weiny
> diff --git a/hw/mem/cxl_type3.c b/h
Jonathan Cameron wrote:
> On Wed, 17 May 2023 19:45:54 -0700
> Ira Weiny wrote:
>
> > Magic numbers can be confusing.
> >
> > Use the range size define for CXL.cachemem rather than a magic number.
> > Update/add spec references.
> >
> > Signed
-by: Ira Weiny
---
The device ID and class code are completely made up by me. As discussed
in the last community call perhaps these could be declared in some more
official capacity?
---
docs/system/devices/cxl.rst | 11 +++
hw/mem/cxl_type3.c | 28
The presence of the Back-Invalidate (BI) decoder capability structure
indicates a CXL downstream port, root port, or device supports the BI
messages.
Add the BI capability structure to the accelerator device.
Not-Yet-Signed-off-by: Ira Weiny
---
hw/cxl/cxl-component-utils.c | 5 +
hw
to
support UIO for testing.
Not-Yet-Signed-off-by: Ira Weiny
---
hw/cxl/cxl-component-utils.c | 6 ++
include/hw/cxl/cxl_component.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/hw/cxl/cxl-component-utils.c b/hw/cxl/cxl-component-utils.c
index a9efa252b4ae..252b2beb2110 100644
Magic numbers can be confusing.
Use the range size define for CXL.cachemem rather than a magic number.
Update/add spec references.
Signed-off-by: Ira Weiny
---
include/hw/cxl/cxl_component.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/hw/cxl
by a device type. Any capability which is not specified by the
type is left NULL'ed out which complies with the packed nature of the
register array.
Update all spec references to 3.0.
No functional changes should be seen with this patch.
Signed-off-by: Ira Weiny
---
hw/cxl/cxl-component-utils.c
-ac-mem5,id=cxl-dev5,sn=0xCAFE0005
...
NOTE: I'm leaving off Michael Tsirkin for now because this is really
rough and I'm mainly sending it out because it was talked about in the
CXL community call on 5/16.
Not-Yet-Signed-off-by: Ira Weiny
---
Ira Weiny (5):
hw/cxl: Use define for build bug
uot;
>
> +static bool g_nowait;
> +module_param_named(nowait, g_nowait, bool, 0444);
> +MODULE_PARM_DESC(nowait, "set QUEUE_FLAG_NOWAIT. Default: False");
Module parameters should be avoided. Since I'm not clear on the
performance benefit I can't comment on alternatives.
God bless you ! I am glad you are recovering.
Stay positive.
Ira
Sent via mobile.Please excuse typos and autocorrects.
> On May 3, 2023, at 7:53 PM, Tom Martin
> wrote:
>
> CAUTION: This email originated from outside of PBS. Do not click links or
> open att
Li Zhijian wrote:
> Each namespace has its own memmap, it will be udpated when
> namespace initializing/creating, updating, and deleting.
>
> CC: Dan Williams
> CC: Vishal Verma
> CC: Dave Jiang
> CC: Ira Weiny
> Signed-off-by: Li Zhijian
> ---
> drive
pcie_walk_rcec(rcec, handles_cxl_error_iter, _cxl);
> > > +
> > > + return !!handles_cxl;
> > > +}
> > > +
> > > +static int __cxl_unmask_internal_errors(struct pci_dev *rcec)
> > > +{
> > > + int aer, rc;
> > > + u32 mask;
> > >
>
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com
>
> v2: No code change since v1. Added description of the motivation of
> using kmap_local_page() and "Suggested-by" tag of Fabio.
>
> Suggested-by: Ira Weiny
> Suggested-by: Fa
>
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com
>
> v2: No code change since v1. Added description of the motivation of
> using kmap_local_page() and "Suggested-by" tag of Fabio.
>
> Suggested-by: Ira Weiny
> Suggested-by: Fa
ropped hot plug related description since it has nothing to do with
> kmap_local_page().
> * No code change since v1, and added description of the motivation of
> using kmap_local_page().
>
> Suggested-by: Dave Hansen
> Suggested-by: Ira Weiny
Reviewed-by: Ira Weiny
ropped hot plug related description since it has nothing to do with
> kmap_local_page().
> * No code change since v1, and added description of the motivation of
> using kmap_local_page().
>
> Suggested-by: Dave Hansen
> Suggested-by: Ira Weiny
Reviewed-by: Ira Weiny
.org/all/20220813220034.806698-1-ira.we...@intel.com
>
> v2:
> * Dropped hot plug related description since it has nothing to do with
> kmap_local_page().
> * No code change since v1, and added description of the motivation of
> using kmap_local_page().
>
> Suggested
.org/all/20220813220034.806698-1-ira.we...@intel.com
>
> v2:
> * Dropped hot plug related description since it has nothing to do with
> kmap_local_page().
> * No code change since v1, and added description of the motivation of
> using kmap_local_page().
>
> Suggested
_local_page() / kunmap_local().
>
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com
>
> v2:
> * Dropped hot plug related description since it has nothing to do with
> kmap_local_page().
> * No code change since v1, and added description of t
_local_page() / kunmap_local().
>
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com
>
> v2:
> * Dropped hot plug related description since it has nothing to do with
> kmap_local_page().
> * No code change since v1, and added description of t
page() / kunmap_local().
>
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com
>
> v2:
> * Dropped hot plug related description since it has nothing to do with
> kmap_local_page().
> * No code change since v1, and added description of the motivation of
> using kmap_local_page().
>
> Suggested-by: Dave Hansen
> Suggested-by: Ira Weiny
Reviewed-by: Ira Weiny
page() / kunmap_local().
>
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.we...@intel.com
>
> v2:
> * Dropped hot plug related description since it has nothing to do with
> kmap_local_page().
> * No code change since v1, and added description of the motivation of
> using kmap_local_page().
>
> Suggested-by: Dave Hansen
> Suggested-by: Ira Weiny
Reviewed-by: Ira Weiny
0813220034.806698-1-ira.we...@intel.com
>
> v2:
> * Used memcpy_from_page() and memcpy_to_page() to replace
> kmap_local_page() + memcpy().
> * Dropped hot plug related description since it has nothing to do with
> kmap_local_page().
> * Added description of the motivation of using kmap_local_page().
>
> Suggested-by: Dave Hansen
> Suggested-by: Ira Weiny
Reviewed-by: Ira Weiny
0813220034.806698-1-ira.we...@intel.com
>
> v2:
> * Used memcpy_from_page() and memcpy_to_page() to replace
> kmap_local_page() + memcpy().
> * Dropped hot plug related description since it has nothing to do with
> kmap_local_page().
> * Added description of the motivation of using kmap_local_page().
>
> Suggested-by: Dave Hansen
> Suggested-by: Ira Weiny
Reviewed-by: Ira Weiny
to do with
> kmap_local_page().
> * Rebased on f47e630 (drm/i915/gem: Typecheck page lookups) to keep
> the "idx" variable of type pgoff_t here.
> * Added description of the motivation of using kmap_local_page().
>
> Suggested-by: Dave Hansen
> Suggested-by: Ira Weiny
Reviewed-by: Ira Weiny
to do with
> kmap_local_page().
> * Rebased on f47e630 (drm/i915/gem: Typecheck page lookups) to keep
> the "idx" variable of type pgoff_t here.
> * Added description of the motivation of using kmap_local_page().
>
> Suggested-by: Dave Hansen
> Suggested-by: Ira Weiny
Reviewed-by: Ira Weiny
+ Konstantin
Michael Ellerman wrote:
> Ira Weiny writes:
> > Dave Hansen wrote:
> >> On 3/15/23 16:20, Ira Weiny wrote:
> >> > Commit 21b56c847753 ("iov_iter: get rid of separate bvec and xarray
> >> > callbacks") removed the calls to
Dave Hansen wrote:
> On 3/15/23 16:20, Ira Weiny wrote:
> > Commit 21b56c847753 ("iov_iter: get rid of separate bvec and xarray
> > callbacks") removed the calls to memcpy_page_flushcache().
> >
> > kmap_atomic() is deprecated and used in the x86
@lists.infradead.org
Signed-off-by: Ira Weiny
---
arch/arm64/include/asm/uaccess.h| 2 --
arch/arm64/lib/uaccess_flushcache.c | 6 --
2 files changed, 8 deletions(-)
diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
index 5c7b2f9d5913..4bf2c0975a82 100644
---
t;
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Ira Weiny
---
arch/powerpc/include/asm/uaccess.h | 2 --
arch/powerpc/lib/pmem.c| 7 ---
2 files changed, 9 deletions(-)
diff --git a/arch/powerpc/include/asm/uaccess.h
b/arch/powerpc/include/asm/uaccess.h
index 3ddc65c63a49.
ms"
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: Borislav Petkov
Cc: x...@kernel.org
Cc: "H. Peter Anvin"
Signed-off-by: Ira Weiny
---
arch/x86/include/asm/uaccess_64.h | 2 --
arch/x86/lib/usercopy_64.c| 9 -
2 files changed, 11 deletions(-)
diff --git a/arch/x86/includ
Signed-off-by: Ira Weiny
---
Ira Weiny (3):
x86, uaccess: Remove memcpy_page_flushcache()
powerpc: Remove memcpy_page_flushcache()
arm: uaccess: Remove memcpy_page_flushcache()
arch/arm64/include/asm/uaccess.h| 2 --
arch/arm64/lib/uaccess_flushcache.c | 6 --
arch/power
as its argument.
>
> In module_zstd_decompress() we currently map with kmap_local_page() and
> unmap with kunmap(). This breaks the code and so it should be fixed.
>
> Cc: Piotr Gorski
> Cc: Dmitry Torokhov
> Cc: Luis Chamberlain
> Cc: Stephen Boyd
> Cc: Ira Weiny
Revi
g_new0(CXLPoison, 1);
frag->start = dpa + 64;
frag->length = found->start + found->length - frag->start;
frag->type = found->type;
QLIST_INSERT_HEAD(poison_list, frag, node);
ct3d->poison_list_cnt++;
}
}
g_free(found);
}
...
> +/* Clearing a region with no poison is not an error so always do so */
> +if (cvc->set_cacheline)
For QEMU coding style you still need '{' '}'.
Ira
n your machine.
>
> Note that the poison list supported is kept short enough to avoid the
> complexity of state machine that is needed to handle the MORE flag.
>
Reviewed-by: Ira Weiny
> Signed-off-by: Jonathan Cameron
>
> ---
> v4:
> - Widen the mask on Poison source (lower bits of the address)
>to allow for Vendor Defined. Change will make it easier to potentially
>add a means to inject such poison in the future. Today it has no
>impact.
[...]
3.c
> +++ b/hw/mem/cxl_type3.c
> @@ -919,6 +919,41 @@ static void set_lsa(CXLType3Dev *ct3d, const void *buf,
> uint64_t size,
> */
> }
>
> +static bool set_cacheline(CXLType3Dev *ct3d, uint64_t dpa_offset, uint8_t
> *data)
> +{
> +MemoryRegion *vmr = NULL, *pmr = NULL;
>
s of the kernel code.
>
> Signed-off-by: Jonathan Cameron
Reviewed-by: Ira Weiny
uery_length ||
> +ent->start + ent->length <= query_start) {
> +continue;
> +}
> +
> +/* Deal with overlap */
> +start = MAX(ent->start & 0xffffffc0, query_start);
> +stop = MIN((ent->start & 0xf
ce the usefulness of this more basic generation of the events.
Seems very reasonable to me.
One spelling issue below. With that.
Reviewed-by: Ira Weiny
>
> Signed-off-by: Jonathan Cameron
> ---
> hw/mem/cxl_type3.c | 61 +
> hw/mem/cxl
lds = >cxl_dstate;
> +
> +rc = ct3d_qmp_cxl_event_log_enc(log);
> +if (rc < 0) {
> +error_setg(errp, "Unhandled error log type");
> +return;
> +}
> +enc_log = rc;
> +
> +memset(, 0, sizeof(dram));
> +cxl_
nt64 version at compile time.
> Replace the direct uint64 calls with this wrapped version.
>
> Link: https://github.com/pmem/ndctl/issues/233
> Fixes: 8dedc6cf5e85 ("cxl: add a helper to parse trace events into a json
> object")
> Reported-by: Michal Suchánek
> Cc: Dave J
ub.com/pmem/ndctl/issues/234
> Fixes: 8dedc6cf5e85 ("cxl: add a helper to parse trace events into a json
> object")
> Fixes: 7b237bc7a8ae ("cxl: add a helper to go through all current events and
> parse them")
> Reported-by: Michal Suchánek
> Cc: Dave Jiang
&
ter 'nvdimm'
> description in 'nvdimm_allocated_dpa
>
> Reported-by: Abaci Robot
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4118
Reviewed-by: Ira Weiny
> Signed-off-by: Yang Li
> ---
> drivers/nvdimm/dimm_devs.c | 4 ++--
> 1 file changed, 2 insertions(+),
@@ static int monitor_event(struct cxl_ctx *ctx)
> }
>
> parse_err:
> - rc = cxl_event_tracing_disable(inst);
> + if (cxl_event_tracing_disable(inst) < 0)
> + err(, "failed to disable tracing\n");
Is this even worth printing? Perhap
race events into a json
> object")
> Cc: Dave Jiang
> Cc: Dan Williams
Reviewed-by: Ira Weiny
> Signed-off-by: Vishal Verma
> ---
> cxl/event_trace.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/cxl/event_trace.c b/cxl/ev
/6 but still.
Reviewed-by: Ira Weiny
>
> Signed-off-by: Jonathan Cameron
> ---
> hw/cxl/cxl-mailbox-utils.c | 62 ++---
> include/hw/cxl/cxl_device.h | 2 +-
> 2 files changed, 32 insertions(+), 32 deletions(-)
>
a good clarification.
Reviewed-by: Ira Weiny
>
> Signed-off-by: Jonathan Cameron
> ---
> hw/cxl/cxl-mailbox-utils.c | 28
> include/hw/cxl/cxl_device.h | 28
> 2 files changed, 28 insertions(+), 28 deletions(-)
>
mp;& !pmr) {
> +return false;
> +}
> +
> +if (dpa_offset + 64 > int128_get64(ct3d->cxl_dstate.mem_size)) {
> +return false;
> +}
> +
> +if (vmr) {
> +if (dpa_offset <= int128_get64(vmr->size)) {
> +as = >hostvm
t; +uint64_t dpa;
> +};
> +struct inject_poison_pl *in = (void *)cmd->payload;
> +CXLPoison *p;
> +
> +QLIST_FOREACH(ent, poison_list, node) {
> +if (ent->start == in->dpa && ent->length == 64) {
How does this interact with the QMP i
t; @@ -292,6 +304,12 @@ struct CXLType3Dev {
>
> /* Error injection */
> CXLErrorList error_list;
> +
> +/* Poison Injection - cache */
> +CXLPoisonList poison_list;
> +unsigned int poison_list_cnt;
> +bool poison_list_overflowed;
> +uint64_t poison_list_overflow_ts;
> };
>
> #define TYPE_CXL_TYPE3 "cxl-type3"
> @@ -317,4 +335,6 @@ MemTxResult cxl_type3_write(PCIDevice *d, hwaddr
> host_addr, uint64_t data,
>
> uint64_t cxl_device_get_timestamp(CXLDeviceState *cxlds);
>
> +void cxl_set_poison_list_overflowed(CXLType3Dev *ct3d);
> +
> #endif
> diff --git a/qapi/cxl.json b/qapi/cxl.json
> index ac7e167fa2..bc099d695e 100644
> --- a/qapi/cxl.json
> +++ b/qapi/cxl.json
> @@ -5,6 +5,22 @@
> # = CXL devices
> ##
>
> +##
> +# @cxl-inject-poison:
> +#
> +# Poison records indicate that a CXL memory device knows that a particular
> +# memory region may be corrupted. This may be because of locally detected
> +# errors (e.g. ECC failure) or poisoned writes received from other components
> +# in the system. This injection mechanism enables testing of the OS handling
> +# of poison records which may be queried via the CXL mailbox.
> +#
> +# @path: CXL type 3 device canonical QOM path
> +# @start: Start address
NIT: "Must be 64 bytes aligned."
> +# @length: Length of poison to inject
NIT: "Must be in multiples of 64 bytes."
Ira
> +##
> +{ 'command': 'cxl-inject-poison',
> + 'data': { 'path': 'str', 'start': 'uint64', 'length': 'uint64' }}
> +
> ##
> # @CxlUncorErrorType:
> #
> --
> 2.37.2
>
Zhao Liu wrote:
> On Tue, Feb 14, 2023 at 08:25:08PM -0800, Ira Weiny wrote:
> > Date: Tue, 14 Feb 2023 20:25:08 -0800
> > From: Ira Weiny
> > Subject: Re: [PATCH 0/9] drm/i915: Replace kmap_atomic() with
> > kmap_local_page()
> >
> > Zhao Liu wrote:
>
Zhao Liu wrote:
> On Tue, Feb 14, 2023 at 08:25:08PM -0800, Ira Weiny wrote:
> > Date: Tue, 14 Feb 2023 20:25:08 -0800
> > From: Ira Weiny
> > Subject: Re: [PATCH 0/9] drm/i915: Replace kmap_atomic() with
> > kmap_local_page()
> >
> > Zhao Liu wrote:
>
> Fixes: 21083f51521f ("cxl/pmem: Register 'pmem' / cxl_nvdimm devices")
> Cc:
> Reported-by: Dave Jiang
Reviewed-by: Ira Weiny
> Tested-by: Dave Jiang
> Signed-off-by: Dan Williams
> ---
> drivers/cxl/pmem.c |1 +
> drivers/nvdimm/bus.c | 19
Zhao Liu wrote:
> From: Zhao Liu
>
> The use of kmap_atomic() is being deprecated in favor of
> kmap_local_page()[1].
Zhao,
Was there ever a v2 of this series? I'm not finding it on Lore.
Thanks,
Ira
>
> In the following patches, we can convert the calls of kmap_atomic()
Zhao Liu wrote:
> From: Zhao Liu
>
> The use of kmap_atomic() is being deprecated in favor of
> kmap_local_page()[1].
Zhao,
Was there ever a v2 of this series? I'm not finding it on Lore.
Thanks,
Ira
>
> In the following patches, we can convert the calls of kmap_atomic()
Bjorn Helgaas wrote:
> On Fri, Feb 10, 2023 at 02:33:23PM -0800, Ira Weiny wrote:
> > The CXL driver expects internal error reporting to be enabled via
> > pci_enable_pcie_error_reporting(). It is likely other drivers expect the
> > same.
> > Dave submitted a pat
aonkar
Cc: Oliver O'Halloran
Cc: linux-...@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Ira Weiny
---
This is RFC to see if it is acceptable to be part of the standard
pci_enable_pcie_error_reporting() call or perhaps
t; 1/ Use the above create_ram_region API, and
> 2/ Elide setting the UUID, since ram regions don't have one
>
> Cc: Dan Williams
> Reviewed-by: Dan Williams
Reviewed-by: Ira Weiny
> Signed-off-by: Vishal Verma
> ---
> Documentation/cxl/cxl-create-region.txt | 3 ++-
>
Verma, Vishal L wrote:
> On Tue, 2023-02-07 at 20:07 -0800, Ira Weiny wrote:
> > Vishal Verma wrote:
> > >
> > > diff --git a/cxl/region.c b/cxl/region.c
> > > index 9079b2d..1c8ccc7 100644
> > > --- a/cxl/region.c
> > > +++ b/cxl/region.c
Verma, Vishal L wrote:
> On Tue, 2023-02-07 at 19:55 -0800, Ira Weiny wrote:
> > Vishal Verma wrote:
> <..>
> > >
> > > diff --git a/cxl/region.c b/cxl/region.c
> > > index 38aa142..0945a14 100644
> > > --- a/cxl/region.c
> >
Vishal Verma wrote:
> From: Dan Williams
>
> Recently the kernel added support for routing newly mapped CXL regions to
> device-dax. Include the json representation of a DAX region beneath its
> host CXL region.
>
Reviewed-by: Ira Weiny
> Signed-off-by: Dan Williams
&
Vishal Verma wrote:
> From: Dan Williams
>
> When verbose listing was added, region listing support was not available, so
> it got missed. Add it now.
>
Reviewed-by: Ira Weiny
> Signed-off-by: Dan Williams
> Signed-off-by: Vishal Verma
> ---
> cxl/list.c
efault for p->mode should be moved here from
parse_create_options(). But I'm not sure what the flows might be like in
that case. That means p->mode would default to NONE until here.
That would make the man page behavior and this function match up nicely
for future maintenance.
But I do
pplied UUIDs, even though the man page for cxl-create-region
> advertised the option.
>
> Fix this by actually adding this option now, and add checks to validate
> the user-supplied UUID, and refuse it for ram regions.
>
> Cc: Dan Williams
Reviewed-by: Ira Weiny
> Signed-of
break;
> + default:
> + /*
> + * This will 'poison' ep_min_size with a 0, and
> + * subsequently cause the region creation to fail.
> + */
> + s
lder kernels that
> lack this, region listings will simply omit emitting this attribute,
> but otherwise not treat it as a failure.
>
> Cc: Dan Williams
Reviewed-by: Ira Weiny
> Signed-off-by: Vishal Verma
> ---
> Documentation/cxl/lib/libcxl.txt | 1 +
> cxl/lib/pr
>
> Since there's no need to walk through the topology after creating a
> region, and especially not to perform an invalid 'action', switch
> back to retuening early for create-region.
>
> Fixes: 3d6cd829ec08 ("cxl/region: Use cxl_filter_walk() to gather
> create-region ta
Jonathan Cameron wrote:
> On Wed, 25 Jan 2023 21:37:27 -0800
> Ira Weiny wrote:
>
> > CXL 3.0 8.2.9.4.2 Set Timestamp and 8.2.9.4.1 Get Timestamp define the
> > way for software to set and get the time stamp of a device. Events
> > should use a time stamp consis
overs the protocol
> related errors reported via PCIE AER - Ira Weiny has posted support for
> Event log based injection and I will post an update of Poison list injection
> shortly. My proposal is to upstream this one first, followed by Ira's Event
> Log series, then finally the Poiso
w/cxl/events: Wire up get/clear event mailbox commands")
Reported-by: Jonathan Cameron
Signed-off-by: Ira Weiny
---
hw/cxl/cxl-device-utils.c | 15 +++
hw/cxl/cxl-events.c | 4 +++-
hw/cxl/cxl-mailbox-utils.c | 11 +--
hw/mem/cxl_type3.c | 1 -
incl
://lore.kernel.org/all/20221221-ira-cxl-events-2022-11-17-v2-0-2ce2ecc06...@intel.com/
To: Jonathan Cameron
Cc: Michael Tsirkin
Cc: Ben Widawsky
Cc: Peter Maydell
Cc:
Cc:
Signed-off-by: Ira Weiny
---
Ira Weiny (2):
hw/cxl: Fix event log time stamp fields
hw/cxl: Remove check for g_new0
g_new0() will terminate the application if it fails. Remove the check.
Fixes: fb64c5661d5f ("hw/cxl/events: Wire up get/clear event mailbox commands")
Reported-by: Jonathan Cameron
Signed-off-by: Ira Weiny
---
hw/cxl/cxl-events.c | 6 --
1 file changed, 6 deletions(-)
diff --gi
On Wed, Jan 11, 2023 at 02:24:37PM +, Jonathan Cameron wrote:
> Noticed as this prevents iASL disasembling the DSDT table.
>
> Signed-off-by: Jonathan Cameron
Reviewed-by: Ira Weiny
> ---
> hw/i386/acpi-build.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --gi
On Wed, Jan 11, 2023 at 02:24:35PM +, Jonathan Cameron wrote:
> From: Gregory Price
>
> Current code sets to STORAGE_EXPRESS and then overrides it.
>
> Signed-off-by: Gregory Price
> Reviewed-by: Davidlohr Bueso
Reviewed-by: Ira Weiny
> Signed-off-by: Jonathan Cam
On Wed, Jan 11, 2023 at 02:24:34PM +, Jonathan Cameron wrote:
> Fix capitalization difference between struct name and typedef.
>
> Signed-off-by: Jonathan Cameron
Reviewed-by: Ira Weiny
> ---
> hw/pci-bridge/cxl_downstream.c | 2 +-
> 1 file changed, 1 insert
On Wed, Jan 11, 2023 at 02:24:33PM +, Jonathan Cameron wrote:
> msix_init_exclusive_bar() can fail, so if it does cleanup the address space.
>
> Signed-off-by: Jonathan Cameron
Reviewed-by: Ira Weiny
> ---
> hw/mem/cxl_type3.c | 12 ++--
> 1 file changed, 1
On Tue, Jan 03, 2023 at 06:07:19PM +, Jonathan Cameron wrote:
> On Wed, 21 Dec 2022 20:24:38 -0800
> Ira Weiny wrote:
>
> > To facilitate testing provide a QMP command to inject a general media
> > event. The event can be added to the log specified.
> >
&
rought up an empty log. As I spend most of my time looking at virtual
mailboxes, I don't usually see a status bar with any information and at some
level was not even aware it existed.
-- Ira
'Using TBBETA' information:
http://www.silverstones.c
clicking on the
status bar would bring that up. I've probably only cared about that log a
couple of time in the many years I've been using The Bat, rarely enough I would
never remember a secret button like that.
-- Ira
'Using TBBETA' informat
impossible to see what went wrong. Could
that be changed so that the results of the last attempt can be reviewed?
-- Ira
'Using TBBETA' information:
http://www.silverstones.com/thebat/TBUDLInfo.html
herefore, replace kmap() with kmap_local_page() in hostfs_kern.c, it
> being the only file with kmap() call sites currently left in fs/hostfs.
>
> Cc: "Venkataramanan, Anirudh"
> Suggested-by: Ira Weiny
What can we do to move this patch along?
I'm not an expert but it looks ok to m
Merry Christmas and happy Birthday Tommy ! As we know. He shares the day
with my son Ravi.
Sent via mobile.Please excuse typos and autocorrects.
> On Dec 22, 2022, at 8:29 PM, Tom Martin
> wrote:
>
> CAUTION: This email originated from outside of PBS. Do not click links
To facilitate testing provide a QMP command to inject a general media
event. The event can be added to the log specified.
Signed-off-by: Ira Weiny
---
Changes from RFC:
Add all fields for this event
irq happens automatically when log transitions from 0 to 1
---
hw/mem
tor=127 type=3 transactiontype=192
\
channel=3 rank=-1 device=5 componentid='Iras mem'" |
$qmpcmd
View events on the guest:
$ cat /sys/kernel/tracing/trace
To: Jonathan Cameron
Cc: Michael Tsirkin
Cc: Ben Widawsky
Cc: Ira Weiny
Cc: qemu-devel@nongnu.org
Cc: linux-...@v
3.0 the version of the device status register block needs
to be 2. Change the macro to allow for setting the version.
Signed-off-by: Ira Weiny
---
Changes from RFC:
New patch to cover this register which was not being used
before.
---
hw/cxl/cxl-device-utils.c | 50
Replace the stubbed out CXL Get/Set Event interrupt policy mailbox
commands. Enable those commands to control interrupts for each of the
event log types.
Skip the standard input mailbox length on the Set command due to DCD
being optional. Perform the checks separately.
Signed-off-by: Ira Weiny
101 - 200 of 13057 matches
Mail list logo
