[PATCH V4 03/10] x86/pks: Add additional PKEY helper macros

2021-03-21 Thread ira . weiny
From: Ira Weiny Avoid open coding shift and mask operations by defining and using helper macros for PKey operations. Reviewed-by: Dan Williams Signed-off-by: Ira Weiny --- Changes from V3: new patch suggested by Dan Williams to use macros better. --- arch/x86/include/asm/pgtable.h

[PATCH V4 06/10] x86/fault: Adjust WARN_ON for PKey fault

2021-03-21 Thread ira . weiny
From: Ira Weiny PKey faults may now happen on kernel mappings if the feature is enabled. Remove the warning in the fault path if PKS is enabled. Reviewed-by: Dan Williams Signed-off-by: Ira Weiny --- arch/x86/mm/fault.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[PATCH V4 04/10] x86/pks: Add PKS defines and Kconfig options

2021-03-21 Thread ira . weiny
From: Ira Weiny Protection Keys for Supervisor pages (PKS) enables fast, hardware thread specific, manipulation of permission restrictions on supervisor page mappings. It uses the same mechanism of Protection Keys as those on User mappings but applies that mechanism to supervisor mappings using

[PATCH V4 01/10] x86/pkeys: Create pkeys_common.h

2021-03-21 Thread ira . weiny
From: Ira Weiny Protection Keys User (PKU) and Protection Keys Supervisor (PKS) work in similar fashions and can share common defines. Specifically PKS and PKU each have: 1. A single control register 2. The same number of keys 3. The same number of bits in the register

[PATCH V4 00/10] PKS Add Protection Key Supervisor support

2021-03-21 Thread ira . weiny
From: Ira Weiny Introduce a new page protection mechanism for supervisor pages, Protection Key Supervisor (PKS). Generally PKS enables protections on 'domains' of supervisor pages to limit supervisor mode access to pages beyond the normal paging protections. PKS works in a similar fashion

Re: [mm/highmem] 61b205f579: WARNING:at_mm/highmem.c:#__kmap_local_sched_out

2021-03-18 Thread Ira Weiny
On Wed, Mar 17, 2021 at 02:44:41PM +0100, Thomas Gleixner wrote: > On Tue, Mar 16 2021 at 00:37, Ira Weiny wrote: > > > > I think I see the issue. I think this is an invalid configuration. > > > > 00:26:43 > grep DEBUG_KMAP config-5.11.0-rc7-2-g61b205f57991

[PATCH] mm/highmem: Fix CONFIG_DEBUG_KMAP_LOCAL_FORCE_MAP

2021-03-18 Thread ira . weiny
From: Ira Weiny The kernel test robot found that __kmap_local_sched_out() was not correctly skipping the guard pages when CONFIG_DEBUG_KMAP_LOCAL_FORCE_MAP was set.[1] This was due to CONFIG_DEBUG_HIGHMEM check being used. Change the configuration check to be correct. [1] https

Re: Picked up a Brewtus II. Tips on troubleshooting.

2021-03-18 Thread Ira
and I only used one or two to keep it warm. -- Ira -- You received this message because you are subscribed to the Google Groups "Brewtus" group. To unsubscribe from this group and stop receiving emails from it, send an email to brewtus+unsubscr...@googlegroups.com. To view this discus

Re: Picked up a Brewtus II. Tips on troubleshooting.

2021-03-18 Thread Ira
Title: Re: Picked up a Brewtus II. Tips on troubleshooting. Hello Roger, You might find this useful. www.roasterthing.com/downloads/brewtus.zip Everything I've ever collected on the Brewtus. -- Ira -- You received this message because you are subscribed to the Google Groups "Br

Re: kmap_local semantics

2021-03-17 Thread Ira Weiny
On Wed, Mar 17, 2021 at 02:59:01PM +0100, Thomas Gleixner wrote: > On Fri, Mar 12 2021 at 07:36, Ira Weiny wrote: > > On Fri, Mar 12, 2021 at 07:54:13AM +0100, Christoph Hellwig wrote: > >> So with the new kmap_local interface is it possible / advisable to > >> use local

[cobirds] Harris's Sparrow -Wheat Ridge - Jeffco

2021-03-17 Thread Ira Sanders
Birders Patty Ecklemeyer called to say she has a juv Harris's Sparrow in her yard on and off. It's been there the last couple of days and occasionally since 1/2. -- Ira Sanders Golden, CO "My mind is a raging torrent flooded with rivulets of thought cascading into a waterfall of cre

Re: [PATCH v5] x86: Remove unnecessary kmap() from sgx_ioc_enclave_init()

2021-03-17 Thread Ira Weiny
On Fri, Mar 05, 2021 at 04:20:58PM -0800, 'Ira Weiny' wrote: > From: Ira Weiny > > kmap is inefficient and we are trying to reduce the usage in the kernel. > There is no readily apparent reason why initp_page needs to be allocated > and kmap'ed() but sigstruct needs to be page al

Re: [PATCH 0/4] btrfs: Convert more kmaps to kmap_local_page()

2021-03-16 Thread Ira Weiny
On Tue, Mar 16, 2021 at 12:07:24PM +0100, David Sterba wrote: > On Fri, Mar 12, 2021 at 12:05:00PM -0800, Ira Weiny wrote: > > On Fri, Mar 12, 2021 at 08:41:41PM +0100, David Sterba wrote: > > > On Tue, Feb 16, 2021 at 06:48:22PM -0800, ira.we...@intel.com wrote: >

Re: [mm/highmem] 61b205f579: WARNING:at_mm/highmem.c:#__kmap_local_sched_out

2021-03-16 Thread Ira Weiny
Adding Thomas. Thomas I've been looking into the following test failure: https://lore.kernel.org/lkml/20210304083825.GB17830@xsang-OptiPlex-9020/ See below. On Fri, Mar 12, 2021 at 02:27:55PM +0800, Oliver Sang wrote: > Hi Ira, [snip] > > > > > > > > caused

Re: [cobirds] Lincoln’s Sparrows early? El Paso Co.

2021-03-13 Thread Ira Sanders
Steve I had 1 Lincoln's Sparrow yesterday in the yard. Ira Sanders On Sat, Mar 13, 2021, 9:42 AM Steve Brown wrote: > Hey COBirders, > > I have had a couple of Lincoln’s Sparrows in my yard in NW COS, one 3/8 > that I banded, and another one seen this morning (unbanded). Looking

Re: [RFC PATCH v2 07/11] dma-mapping: Add flags to dma_map_ops to indicate PCI P2PDMA support

2021-03-12 Thread Ira Weiny
ogic correct? I would have expected. return (ops && ops->flags & DMA_F_PCI_P2PDMA_SUPPORTED); Ira

Re: [RFC PATCH v2 07/11] dma-mapping: Add flags to dma_map_ops to indicate PCI P2PDMA support

2021-03-12 Thread Ira Weiny
ogic correct? I would have expected. return (ops && ops->flags & DMA_F_PCI_P2PDMA_SUPPORTED); Ira ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [RFC PATCH v2 04/11] PCI/P2PDMA: Introduce pci_p2pdma_should_map_bus() and pci_p2pdma_bus_offset()

2021-03-12 Thread Ira Weiny
ing at the implementation I'm not clear why pci_p2pdma_dma_map_type() needs to exist? Ira [snip] > + > +/** > + * pci_p2pdma_dma_map_type - determine if a DMA mapping should use the > + * bus address, be mapped normally or fail > + * @dev: device doing the DMA request > + * @pgmap:

Re: [RFC PATCH v2 04/11] PCI/P2PDMA: Introduce pci_p2pdma_should_map_bus() and pci_p2pdma_bus_offset()

2021-03-12 Thread Ira Weiny
ing at the implementation I'm not clear why pci_p2pdma_dma_map_type() needs to exist? Ira [snip] > + > +/** > + * pci_p2pdma_dma_map_type - determine if a DMA mapping should use the > + * bus address, be mapped normally or fail > + * @dev: device doing the DMA request > + * @pgmap:

Re: [RFC PATCH v2 04/11] PCI/P2PDMA: Introduce pci_p2pdma_should_map_bus() and pci_p2pdma_bus_offset()

2021-03-12 Thread Ira Weiny
ap = to_p2p_pgmap(page->pgmap); > + > + WARN_ON(!is_pci_p2pdma_page(page)); Shouldn't this check be before the to_p2p_pgmap() call? And I've been told not to introduce WARN_ON's. Should this be? if (!is_pci_p2pdma_page(page)) return -1; ??? Ira

Re: [RFC PATCH v2 04/11] PCI/P2PDMA: Introduce pci_p2pdma_should_map_bus() and pci_p2pdma_bus_offset()

2021-03-12 Thread Ira Weiny
ap = to_p2p_pgmap(page->pgmap); > + > + WARN_ON(!is_pci_p2pdma_page(page)); Shouldn't this check be before the to_p2p_pgmap() call? And I've been told not to introduce WARN_ON's. Should this be? if (!is_pci_p2pdma_page(page)) return -1; ??? Ira __

Re: [PATCH 0/4] btrfs: Convert more kmaps to kmap_local_page()

2021-03-12 Thread Ira Weiny
On Fri, Mar 12, 2021 at 08:41:41PM +0100, David Sterba wrote: > On Tue, Feb 16, 2021 at 06:48:22PM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > I am submitting these for 5.13. > > > > Further work to remove more kmap() call

Re: [PATCH 1/4] fs/btrfs: Convert kmap to kmap_local_page() using coccinelle

2021-03-12 Thread Ira Weiny
sting ordering of kmap_local_page() makes converting the other calls hacky at best. I'm not sure what to do about them. The best I've come up with is doing a hacky extra unmap/remap to preserve the nesting. Anyway, I'd prefer to leave this additional temp variable but I can certainly change if it you want. The other conversions may never work/land. :-/ Ira

Re: kmap_local semantics

2021-03-12 Thread Ira Weiny
tter than I what performance would be. FWIW I have been working on converting kmaps to kmap_local. Most of the instances don't schedule AFAICT. What I really don't want to see is any kmap'ings handed to another thread. I am working hard to eliminate the use of kmap for that use. Is that going to be a problem? Ira

Re: [PATCH 0/4] btrfs: Convert more kmaps to kmap_local_page()

2021-03-11 Thread Ira Weiny
On Tue, Feb 16, 2021 at 06:48:22PM -0800, 'Ira Weiny' wrote: > From: Ira Weiny > > I am submitting these for 5.13. Just a friendly ping on this set. Ira > > Further work to remove more kmap() calls in favor of the kmap_local_page() > this > series converts those call

Re: [mm/highmem] 61b205f579: WARNING:at_mm/highmem.c:#__kmap_local_sched_out

2021-03-11 Thread Ira Weiny
On Tue, Mar 09, 2021 at 08:53:04PM +, Chaitanya Kulkarni wrote: > Ira, > > On 3/4/21 00:23, kernel test robot wrote: > > Greeting, > > > > FYI, we noticed the following commit (built with gcc-9): > > > > commit: 61b205f579911a11f0b576f73275eca2aed0

Re: [PATCH 0/3] btrfs: Convert kmap/memset/kunmap to memzero_user()

2021-03-11 Thread Ira Weiny
may take the patches via the mm tree, unless Linus is ok with a late pull." -- https://lore.kernel.org/lkml/20210224123049.gx1...@twin.jikos.cz/ But reading that again I'm not sure what he meant. David? Ira > > Acked-by: Andrew Morton >

[cobirds] Cassin's Finch- Golden

2021-03-10 Thread Ira Sanders
Birders Just to complicate things, a female Cassin's just showed up. Head pattern and streaking are different from the Purple Finch. Ira Sanders Golden -- -- You received this message because you are subscribed to the Google Groups "Colorado Birds" group. To post to this group,

[cobirds] Purple Finch - Golden

2021-03-10 Thread Ira Sanders
Birders The Purple Finch is back. It was here yesterday about the same time. Ira Sanders Golden -- -- You received this message because you are subscribed to the Google Groups "Colorado Birds" group. To post to this group, send email to cobirds@googlegroups.com For more opti

[PATCH 2/3] mm/highmem: Convert memzero_page() to kmap_local_page()

2021-03-09 Thread ira . weiny
From: Ira Weiny The memset() does not need to be performed atomically. Use kmap_local_page() which will improved performance for this call. Cc: Chaitanya Kulkarni Cc: David Sterba Signed-off-by: Ira Weiny --- include/linux/highmem.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 0/3] btrfs: Convert kmap/memset/kunmap to memzero_user()

2021-03-09 Thread ira . weiny
From: Ira Weiny Previously this was submitted to convert to zero_user()[1]. zero_user() is not the same as memzero_user() and in fact some zero_user() calls may be better off as memzero_user(). Regardless it was incorrect to convert btrfs to zero_user(). This series corrects this by lifting

[PATCH 1/3] iov_iter: Lift memzero_page() to highmem.h

2021-03-09 Thread ira . weiny
From: Ira Weiny memzero_page() can replace the kmap/memset/kunmap pattern in other places in the code. While zero_user() has the same interface it is not the same call and its use should be limited and some of those calls may be better converted from zero_user() to memzero_page().[1

[PATCH 3/3] btrfs: Use memzero_page() instead of open coded kmap pattern

2021-03-09 Thread ira . weiny
From: Ira Weiny There are many places where kmap/memset/kunmap patterns occur. Use the newly lifted memzero_page() to eliminate direct uses of kmap and leverage the new core functions use of kmap_local_page(). The development of this patch was aided by the following coccinelle script

[jira] [Closed] (ARROW-11915) Pyarrow: non-legacy filesystem connection doesn't work while legacy does.

2021-03-09 Thread Ira Saktor (Jira)
[ https://issues.apache.org/jira/browse/ARROW-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ira Saktor closed ARROW-11915. -- Resolution: Not A Problem Turns out it is just a problem with classpath variable not configured

[jira] [Created] (ARROW-11915) Pyarrow: non-legacy filesystem connection doesn't work while legacy does.

2021-03-09 Thread Ira Saktor (Jira)
Ira Saktor created ARROW-11915: -- Summary: Pyarrow: non-legacy filesystem connection doesn't work while legacy does. Key: ARROW-11915 URL: https://issues.apache.org/jira/browse/ARROW-11915 Project

[jira] [Created] (ARROW-11915) Pyarrow: non-legacy filesystem connection doesn't work while legacy does.

2021-03-09 Thread Ira Saktor (Jira)
Ira Saktor created ARROW-11915: -- Summary: Pyarrow: non-legacy filesystem connection doesn't work while legacy does. Key: ARROW-11915 URL: https://issues.apache.org/jira/browse/ARROW-11915 Project

Re: [cobirds] Re: Purple Finch - Jeffco - Golden

2021-03-06 Thread Ira Sanders
Josh, Thanks for the post and picture. The bird shown looks the same as the birds at my feeder. Ira On Sat, Mar 6, 2021, 3:38 PM Josh Bruening <87211...@gmail.com> wrote: > All, > > To piggy-back on Ira's post, there are at least 4 different Purple Finches > that have be

[cobirds] Purple Finch - Jeffco - Golden

2021-03-06 Thread Ira Sanders
. After they left the water they flew into the trees across the street. I'll watch for them. -- Ira Sanders Golden, CO "My mind is a raging torrent flooded with rivulets of thought cascading into a waterfall of creative alternatives." -- -- You received this message because you are

[PATCH v5] x86: Remove unnecessary kmap() from sgx_ioc_enclave_init()

2021-03-05 Thread ira . weiny
From: Ira Weiny kmap is inefficient and we are trying to reduce the usage in the kernel. There is no readily apparent reason why initp_page needs to be allocated and kmap'ed() but sigstruct needs to be page aligned and token 512 byte aligned. kmalloc() can give us this alignment but we need

Re: [PATCH v3 04/11] x86/kthread,dumpstack: Set task_pt_regs->cs.RPL=3 for kernel threads

2021-03-04 Thread Ira Weiny
lags, unsigned long > sp, unsigned long arg, > /* Kernel thread ? */ > if (unlikely(p->flags & PF_KTHREAD)) { > memset(childregs, 0, sizeof(struct pt_regs)); > + > + /* > + * Even though there is no real user state he

Re: [GIT PULL] Kmap conversions for 5.12

2021-02-26 Thread Ira Weiny
On Fri, Feb 26, 2021 at 03:23:40PM +0100, David Sterba wrote: > On Thu, Feb 25, 2021 at 08:32:34AM -0800, Ira Weiny wrote: > > On Thu, Feb 25, 2021 at 02:12:52PM +0100, David Sterba wrote: > > > On Wed, Feb 24, 2021 at 09:59:12AM -0800, Ira Weiny wrote: > > > > On W

Re: [GIT PULL] Kmap conversions for 5.12

2021-02-25 Thread Ira Weiny
On Thu, Feb 25, 2021 at 02:12:52PM +0100, David Sterba wrote: > On Wed, Feb 24, 2021 at 09:59:12AM -0800, Ira Weiny wrote: > > On Wed, Feb 24, 2021 at 01:30:49PM +0100, David Sterba wrote: > > > On Tue, Feb 23, 2021 at 11:25:06AM -0800, Ira Weiny wrote: > > > > On T

Re: [GIT PULL] Kmap conversions for 5.12

2021-02-24 Thread Ira Weiny
On Wed, Feb 24, 2021 at 01:30:49PM +0100, David Sterba wrote: > On Tue, Feb 23, 2021 at 11:25:06AM -0800, Ira Weiny wrote: > > On Tue, Feb 23, 2021 at 09:13:42AM -0800, Linus Torvalds wrote: > > > On Tue, Feb 23, 2021 at 7:03 AM David Sterba wrote: > [...] > &

Re: [cobirds] Re: NM birding guide - free

2021-02-24 Thread Ira Sanders
Well David, I feel Chris Fleuriel was doing a service for cobirders in offering that book and don't see a problem with it. Ira Sanders On Wed, Feb 24, 2021, 9:12 AM David Suddjian wrote: > Dear CoBirders, > > This is a Colorado Birds list, so let's keep discussion focused there,

Re: [GIT PULL] Kmap conversions for 5.12

2021-02-23 Thread Ira Weiny
On Tue, Feb 23, 2021 at 09:13:42AM -0800, Linus Torvalds wrote: > On Tue, Feb 23, 2021 at 7:03 AM David Sterba wrote: > > Ira Weiny (8): > > iov_iter: Remove memzero_page() in favor of zero_user() > > Ugh. I absolutely _detest_ this patch. Sorry. > > &q

Re: linux-next: manual merge of the btrfs tree with the fscache tree

2021-02-17 Thread Ira Weiny
On Fri, Feb 12, 2021 at 02:04:44PM +1100, Stephen Rothwell wrote: > Hi Ira, > > On Thu, 11 Feb 2021 17:07:41 -0800 Ira Weiny wrote: > > > > On Fri, Feb 12, 2021 at 10:38:10AM +1100, Stephen Rothwell wrote: > > > from the fscache tree and commit: > > >

[PATCH 2/4] fs/btrfs: Convert raid5/6 kmaps to kmap_local_page()

2021-02-16 Thread ira . weiny
From: Ira Weiny These kmaps are thread local and don't need to be atomic. So they can use the more efficient kmap_local_page(). However, the mapping of pages in the stripes and the additional parity and qstripe pages are a bit trickier because the unmapping must occur in the opposite order

[PATCH 0/4] btrfs: Convert more kmaps to kmap_local_page()

2021-02-16 Thread ira . weiny
From: Ira Weiny I am submitting these for 5.13. Further work to remove more kmap() calls in favor of the kmap_local_page() this series converts those calls which required more than a common pattern which were covered in my previous series[1]. This is the second of what I hope to be 3 series

[PATCH 4/4] fs/btrfs: Convert block context kmap's to kmap_local_page()

2021-02-16 Thread ira . weiny
From: Ira Weiny btrfsic_read_block() (which calls kmap()) and btrfsic_release_block_ctx() (which calls kunmap()) are always called within a single thread of execution. Therefore the mappings created within these calls can be a thread local mapping. Convert the kmap() of bloc_ctx->pa

[PATCH 3/4] fs/btrfs: Use kmap_local_page() in __btrfsic_submit_bio()

2021-02-16 Thread ira . weiny
From: Ira Weiny Again there is an array of pointers which must be unmapped in the correct order. Convert the kmap()'s to kmap_local_page() and adjust the unmapping to work backwards through the unmapping loop. Signed-off-by: Ira Weiny --- fs/btrfs/check-integrity.c | 8 1 file

[PATCH 1/4] fs/btrfs: Convert kmap to kmap_local_page() using coccinelle

2021-02-16 Thread ira . weiny
From: Ira Weiny Use a simple coccinelle script to help convert the most common kmap()/kunmap() patterns to kmap_local_page()/kunmap_local(). Note that some kmaps which were caught by this script needed to be handled by hand because of the strict unmapping order of kunmap_local() so

Re: linux-next: manual merge of the btrfs tree with the fscache tree

2021-02-11 Thread Ira Weiny
After doing that I don't see the zero_user() as below. All that said the resolution below seems correct. Ira > > from the btrfs tree. > > I fixed it up (see below) and can carry the fix as necessary. This > is now fixed as far as linux-next is concerned, but any non trivial

Re: [PATCH V2 0/8] btrfs: convert kmaps to core page calls

2021-02-11 Thread Ira Weiny
On Thu, Feb 11, 2021 at 08:38:03PM +0100, David Sterba wrote: > On Tue, Feb 09, 2021 at 10:22:13PM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > Per the conversation on V1 it looks like Andrew would like this to go > > through > > the

Re: [TLS] EXTERNAL: TLS 1.3 Authentication and Integrity only Cipher Suites

2021-02-11 Thread Ira McDonald
Hi, I agree with Bill. Keeping confidentiality in all TLS/1.3 connections is future proofing. Supposedly analyzing and then leaving confidentiality out invites future attacks. Cheers, - Ira On Thu, Feb 11, 2021 at 9:56 AM Bill Frantz wrote: > On 2/11/21 at 9:01 PM, rsalz=40aka

Re: [PATCH v4 1/1] mm/highmem: Remove deprecated kmap_atomic

2021-02-10 Thread Ira Weiny
On Thu, Feb 04, 2021 at 01:02:53PM +0530, Prathu Baronia wrote: > From: Ira Weiny > > kmap_atomic() is being deprecated in favor of kmap_local_page(). > > Replace the uses of kmap_atomic() within the highmem code. > > On profiling clear_huge_page() using ftrace a

Re: [PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls

2021-02-10 Thread Ira Weiny
On Wed, Feb 10, 2021 at 06:56:06PM +, Matthew Wilcox wrote: > On Wed, Feb 10, 2021 at 08:29:01AM -0800, Ira Weiny wrote: > > And I thought it was a good idea. Any file system development should have > > tests with DEBUG_VM which should cover Matthew's concern w

[PATCH V2.1] mm/highmem: Add VM_BUG_ON() to mem*_page() calls

2021-02-10 Thread ira . weiny
From: Ira Weiny Add VM_BUG_ON bounds checks to ensure the newly lifted and created page memory operations do not result in corrupted data in neighbor pages.[1][2] [1] https://lore.kernel.org/lkml/20201210053502.gs1563...@iweiny-desk2.sc.intel.com/ [2] https://lore.kernel.org/lkml

Re: [PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls

2021-02-10 Thread Ira Weiny
On Wed, Feb 10, 2021 at 04:41:34PM +, Christoph Hellwig wrote: > On Wed, Feb 10, 2021 at 08:29:01AM -0800, Ira Weiny wrote: > > On Wed, Feb 10, 2021 at 12:55:02PM +, Christoph Hellwig wrote: > > > On Tue, Feb 09, 2021 at 10:22:17PM -0800, ira.we...@intel.com wrote: >

Re: [PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls

2021-02-10 Thread Ira Weiny
On Wed, Feb 10, 2021 at 06:57:30AM +, Chaitanya Kulkarni wrote: > On 2/9/21 22:25, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > Add VM_BUG_ON bounds checks to ensure the newly lifted and created page > > memory operations do not result in corru

Re: [PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls

2021-02-10 Thread Ira Weiny
On Wed, Feb 10, 2021 at 12:55:02PM +, Christoph Hellwig wrote: > On Tue, Feb 09, 2021 at 10:22:17PM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > Add VM_BUG_ON bounds checks to ensure the newly lifted and created page > > memory operations do n

[PATCH V2 6/8] btrfs: use memcpy_[to|from]_page() and kmap_local_page()

2021-02-09 Thread ira . weiny
From: Ira Weiny There are many places where the pattern kmap/memcpy/kunmap occurs. This pattern was lifted to the core common functions memcpy_[to|from]_page(). Use these new functions to reduce the code, eliminate direct uses of kmap, and leverage the new core functions use of kmap_local_page

[PATCH V2 7/8] btrfs: use copy_highpage() instead of 2 kmaps()

2021-02-09 Thread ira . weiny
From: Ira Weiny There are many places where kmap/memove/kunmap patterns occur. This pattern exists in the core common function copy_highpage(). Use copy_highpage to avoid open coding the use of kmap and leverages the core functions use of kmap_local_page(). Development of this patch was aided

[PATCH V2 8/8] btrfs: convert to zero_user()

2021-02-09 Thread ira . weiny
From: Ira Weiny There are many places where kmap/memset/kunmap patterns occur. This pattern exists in the core as zero_user() Use zero_user() to eliminate direct uses of kmap and leverage the new core functions use of kmap_local_page(). The development of this patch was aided by the following

[PATCH V2 3/8] mm/highmem: Introduce memcpy_page(), memmove_page(), and memset_page()

2021-02-09 Thread ira . weiny
From: Ira Weiny 3 more common kmap patterns are kmap/memcpy/kunmap, kmap/memmove/kunmap. and kmap/memset/kunmap. Add helper functions for those patterns which use kmap_local_page(). Cc: Andrew Morton Cc: Christoph Hellwig Signed-off-by: Ira Weiny --- New for V2 --- include/linux/highmem.h

[PATCH V2 5/8] iov_iter: Remove memzero_page() in favor of zero_user()

2021-02-09 Thread ira . weiny
From: Ira Weiny zero_user() is already defined with the same interface and contains the same code pattern as memzero_page(). Remove memzero_page() and use the already defined common function zero_user() To: Alexander Viro Cc: Andrew Morton Cc: Christoph Hellwig Signed-off-by: Ira Weiny

[PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls

2021-02-09 Thread ira . weiny
From: Ira Weiny Add VM_BUG_ON bounds checks to ensure the newly lifted and created page memory operations do not result in corrupted data in neighbor pages and to make them consistent with zero_user().[1][2] [1] https://lore.kernel.org/lkml/20201210053502.gs1563...@iweiny-desk2.sc.intel.com

[PATCH V2 0/8] btrfs: convert kmaps to core page calls

2021-02-09 Thread ira . weiny
From: Ira Weiny Changes from V1: Rework commit messages because they were very weak Change 'fs/btrfs: X' to 'btrfs: x' https://lore.kernel.org/lkml/20210209151442.gu1...@suse.cz/ Per Andrew Split out changes to highmem.h

[PATCH V2 1/8] mm/highmem: Lift memcpy_[to|from]_page to core

2021-02-09 Thread ira . weiny
From: Ira Weiny Working through a conversion to a call kmap_local_page() instead of kmap() revealed many places where the pattern kmap/memcpy/kunmap occurred. Eric Biggers, Matthew Wilcox, Christoph Hellwig, Dan Williams, and Al Viro all suggested putting this code into helper functions. Al

[PATCH V2 2/8] mm/highmem: Convert memcpy_[to|from]_page() to kmap_local_page()

2021-02-09 Thread ira . weiny
From: Ira Weiny kmap_local_page() is more efficient and is well suited for these calls. Convert the kmap() to kmap_local_page() Cc: Andrew Morton Cc: Christoph Hellwig Signed-off-by: Ira Weiny --- New for V2 --- include/linux/highmem.h | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH 0/4] btrfs: Convert kmaps to core page calls

2021-02-09 Thread Ira Weiny
On Tue, Feb 09, 2021 at 01:58:37PM -0800, Andrew Morton wrote: > On Tue, 9 Feb 2021 13:52:29 -0800 Ira Weiny wrote: > > > > > > > Let's please queue this up separately. > > > > Ok can I retain your Ack on the move part of the patch? > > I mis

Re: [cobirds] Mute Swans

2021-02-09 Thread Ira Sanders
Question: Since when have Mute Swans been counted anywhere in Colorado? Ira Sanders On Tue, Feb 9, 2021, 4:23 PM Cinnamon Bergeron wrote: > I saw the Broadmoor Mute Swans years ago and have never reported them on > eBird. I have been seeing so many report them lately and have been t

Re: [PATCH 0/4] btrfs: Convert kmaps to core page calls

2021-02-09 Thread Ira Weiny
t; > (Although I expect VM_BUG_ON() would be better - will give us sufficient > coverage without the overall impact.) I'm ok with VM_BUG_ON() > > Let's please queue this up separately. Ok can I retain your Ack on the move part of the patch? Note that it does change kmap_atomic() to kmap_local_page() currently. Would you prefer a separate change for that as well? Ira PS really CC'ing Matthew now...

Re: [PATCH 0/4] btrfs: Convert kmaps to core page calls

2021-02-09 Thread Ira Weiny
On Tue, Feb 09, 2021 at 11:09:31AM -0800, Andrew Morton wrote: > On Tue, 9 Feb 2021 16:11:23 +0100 David Sterba wrote: > > > On Fri, Feb 05, 2021 at 03:23:00PM -0800, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > There are many places

Re: [PATCH 0/4] btrfs: Convert kmaps to core page calls

2021-02-09 Thread Ira Weiny
On Tue, Feb 09, 2021 at 04:11:23PM +0100, David Sterba wrote: > On Fri, Feb 05, 2021 at 03:23:00PM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > There are many places where kmap//kunmap patterns occur. We lift > > these various patterns to core co

Re: [f2fs-dev] [RFC PATCH 0/8] use core page calls instead of kmaps

2021-02-07 Thread Ira Weiny
of places in brd code we can use memcpy_to_page() > and get rid the local variable, once I get some feedback I'll add those > to the V1. Except for the one comment I had this series look's good to me. Reviewed-by: Ira Weiny Thanks! Ira ___ Linux

Re: [f2fs-dev] [RFC PATCH 2/8] brd: use memcpy_from_page() in copy_from_brd()

2021-02-07 Thread Ira Weiny
opy; > page = brd_lookup_page(brd, sector); > - if (page) { > - src = kmap_atomic(page); > - memcpy(dst, src, copy); > - kunmap_atomic(src); > - } else > + if (page) >

Re: [PATCH 1/4] mm/highmem: Lift memcpy_[to|from]_page to core

2021-02-07 Thread Ira Weiny
, size_t > offset, > size_t len) It is an easy change and It is up to Andrew. But I thought we were making the line length limit longer now. Ira > > +{ > > + char *from = kmap_local_page(page); > > + > > + BUG_ON(offset + le

[PATCH 4/4] fs/btrfs: Convert to zero_user()

2021-02-05 Thread ira . weiny
From: Ira Weiny The development of this patch was aided by the following coccinelle script: // // SPDX-License-Identifier: GPL-2.0-only // Find kmap/memset/kunmap pattern and replace with memset*page calls // // NOTE: Offsets and other expressions may be more complex than what the script

[PATCH 0/4] btrfs: Convert kmaps to core page calls

2021-02-05 Thread ira . weiny
From: Ira Weiny There are many places where kmap//kunmap patterns occur. We lift these various patterns to core common functions and use them in the btrfs file system. At the same time we convert those core functions to use kmap_local_page() which is more efficient in those calls. I think

[PATCH 2/4] fs/btrfs: Use memcpy_[to|from]_page()

2021-02-05 Thread ira . weiny
From: Ira Weiny Development of this patch was aided by the coccinelle script: // // SPDX-License-Identifier: GPL-2.0-only // Find kmap/memcpy/kunmap pattern and replace with memcpy*page calls // // NOTE: Offsets and other expressions may be more complex than what the script

[PATCH 3/4] fs/btrfs: Use copy_highpage() instead of 2 kmaps()

2021-02-05 Thread ira . weiny
From: Ira Weiny Development of this patch was aided by the following coccinelle script: // // SPDX-License-Identifier: GPL-2.0-only // Find kmap/copypage/kunmap pattern and replace with copy_highpage calls // // NOTE: The expressions in the copy page version of this kmap pattern are // overly

[PATCH 1/4] mm/highmem: Lift memcpy_[to|from]_page to core

2021-02-05 Thread ira . weiny
From: Ira Weiny Working through a conversion to a call kmap_local_page() instead of kmap() revealed many places where the pattern kmap/memcpy/kunmap occurred. Eric Biggers, Matthew Wilcox, Christoph Hellwig, Dan Williams, and Al Viro all suggested putting this code into helper functions. Al

[PATCH v4] x86: Remove unnecessary kmap() from sgx_ioc_enclave_init()

2021-02-05 Thread ira . weiny
From: Ira Weiny kmap is inefficient and we are trying to reduce the usage in the kernel. There is no readily apparent reason why initp_page needs to be allocated and kmap'ed() but sigstruct needs to be page aligned and token 512 byte aligned. kmalloc() can give us this alignment but we need

Re: [PATCH] fs/btrfs: Fix raid6 qstripe kmap'ing

2021-02-05 Thread Ira Weiny
On Fri, Feb 05, 2021 at 04:34:41PM +0100, David Sterba wrote: > On Thu, Feb 04, 2021 at 07:52:36PM -0800, Ira Weiny wrote: > > On Thu, Feb 04, 2021 at 04:26:08PM +0100, David Sterba wrote: > > > On Wed, Feb 03, 2021 at 04:56:48PM +0100, David Sterba wrote: > > > >

Re: [PATCH V3] x86: Remove unnecessary kmap() from sgx_ioc_enclave_init()

2021-02-04 Thread Ira Weiny
On Wed, Feb 03, 2021 at 12:45:33AM +0200, Jarkko Sakkinen wrote: > On Tue, Feb 02, 2021 at 11:47:19AM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > kmap is inefficient and we are trying to reduce the usage in the kernel. > > There is no readily app

Re: [PATCH] fs/btrfs: Fix raid6 qstripe kmap'ing

2021-02-04 Thread Ira Weiny
On Thu, Feb 04, 2021 at 04:26:08PM +0100, David Sterba wrote: > On Wed, Feb 03, 2021 at 04:56:48PM +0100, David Sterba wrote: > > On Wed, Jan 27, 2021 at 10:15:03PM -0800, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > When a qstripe is

[PATCH] fs/coredump: Use kmap_local_page()

2021-02-03 Thread ira . weiny
From: Ira Weiny In dump_user_range() there is no reason for the mapping to be global. Use kmap_local_page() rather than kmap. Cc: Andrew Morton Cc: linux-kernel@vger.kernel.org Cc: linux-fsde...@vger.kernel.org Signed-off-by: Ira Weiny --- fs/coredump.c | 4 ++-- 1 file changed, 2 insertions

Re: [PATCH v2 1/1] mm: Optimizing hugepage zeroing in arm64

2021-02-03 Thread Ira Weiny
On Wed, Feb 03, 2021 at 04:08:08PM +0530, Prathu Baronia wrote: >Hey Ira, >I looked at your below-mentioned patch and I agree that the >above-mentioned functions also need modification similar to >clear_user_highpage(). >Would it be okay with you if I send y

Re: [PATCH v2 1/1] mm: Optimizing hugepage zeroing in arm64

2021-02-02 Thread Ira Weiny
--- > > Malloc test timings for 100MB anon allocation:- > > Base data:- > Number of iterations: 100 > Mean of allocation time: 31831 us > std deviation: 4286 us > > v1 data:- > Number of iterations: 100 > Mean of allocation time: 1819

[PATCH V3] x86: Remove unnecessary kmap() from sgx_ioc_enclave_init()

2021-02-02 Thread ira . weiny
From: Ira Weiny kmap is inefficient and we are trying to reduce the usage in the kernel. There is no readily apparent reason why initp_page needs to be allocated and kmap'ed() but sigstruct needs to be page aligned and token 512 byte aligned. kmalloc() can give us this alignment but we need

[PATCH] x86: Remove unnecessary kmap() from sgx_ioc_enclave_init()

2021-02-01 Thread ira . weiny
From: Ira Weiny kmap is inefficient and we are trying to reduce the usage in the kernel. There is no readily apparent reason why the initp_page page needs to be allocated and kmap'ed() but sigstruct needs to be page aligned and token 512 byte aligned. In this case page_address() can be used

[cobirds] Golden-crowned Sparrow - Chatfield - Jeffco

2021-01-31 Thread Ira Sanders
Birders Tammy and I went to Chatfield Stables and got the GCSP under the junipers with a couple of WCSP. We also looked for the Redpoll but couldn't find any passarines in the area. -- Ira Sanders Golden, CO "My mind is a raging torrent flooded with rivulets of thought casc

Re: More Steam Boiler Problems

2021-01-31 Thread Ira
Title: Re: More Steam Boiler Problems Hello winnipegger65, Sunday, January 31, 2021, 4:12:39 PM, you wrote: Thanks as always for your thoughts Ira, If it's really bouncing around then it would seem to follow there are bad contacts in the pressurestat. If you jumper the supply and steam

Re: More Steam Boiler Problems

2021-01-31 Thread Ira
there? Do you own a voltmeter or a neon test light? -- Ira -- You received this message because you are subscribed to the Google Groups "Brewtus" group. To unsubscribe from this group and stop receiving emails from it, send an email to brewtus+unsubscr...@googlegroups.com. To view this

Re: [cobirds] Looking for Sharp=tailed Grouse

2021-01-31 Thread Ira Sanders
Bill This posted at 8:14 am Sunday morning. When did you really post it? Ira Sanders On Sun, Jan 31, 2021, 8:14 AM Bill Schreitz wrote: > I am planning to go to the Pawnee National Grasslands this Sunday the > 31thfor the day to look for the elusive Sharp-tailed Grouse that has been

[PATCH] x86: Remove unnecessary kmap() from sgx_ioc_enclave_init()

2021-01-28 Thread ira . weiny
From: Ira Weiny There is no reason to alloc a page and kmap it to store this temporary data from the user. This is especially true when we are trying to remove kmap usages. Also placing the token pointer 1/2 way into the page is fragile. Replace this allocation with two kzalloc()'s which also

[PATCH] fs/btrfs: Fix raid6 qstripe kmap'ing

2021-01-27 Thread ira . weiny
From: Ira Weiny When a qstripe is required an extra page is allocated and mapped. There were 3 problems. 1) There is no reason to map the qstripe page more than 1 time if the number of bits set in rbio->dbitmap is greater than one. 2) There is no reason to map the parity page and un

[MOPO] WTB JAPANESE ANIME FILM YOUR NAME POSTER

2021-01-27 Thread Ira Rubenstein
Hi there, I am looking for this poster for my daughter.YOUR NAME It is a Japanese Anime film. Please email prices and condition. Thanks, Ira Visit the MoPo Mailing List Web Site at www.filmfan.com

[cobirds] White-winged Dove - Golden - Jeffco

2021-01-22 Thread Ira Sanders
it in the branches, it turned out to be a WW Dove. It changed position and moved deeper into the branches but stayed in the trees in my neighbors yard. This is the 2nd time I've had a WWDO in the yard. The 1st time was years ago and only for 1 day. -- Ira Sanders Golden, CO "My mind is a r

[cobirds] WW Crossbill - Lakewood - NO

2021-01-06 Thread Ira Sanders
Birders I spent 2 1/2 hours looking for the WWCR this morning with no luck. -- Ira Sanders Golden, CO "My mind is a raging torrent flooded with rivulets of thought cascading into a waterfall of creative alternatives." -- You received this message because you are subscribed to the Goo

<    2   3   4   5   6   7   8   9   10   11   >